Re: [RFC] Apache "look and feel" for stdcxx docs

2007-08-14 Thread mark.g.brown
Martin Sebor wrote: Hey everyone, Marc Betz has been working on the improvements to the stdcxx documentation outlined in STDCXX-391. Most of them are pretty straightforward and can, IMO, be implemented without much debate (although feedback is always appreciated :) but there is one that I think

[jira] Created: (STDCXX-522) std::filebuf::overflow(EOF) writes EOF to file in unbuffered mode

2007-08-14 Thread Martin Sebor (JIRA)
std::filebuf::overflow(EOF) writes EOF to file in unbuffered mode - Key: STDCXX-522 URL: https://issues.apache.org/jira/browse/STDCXX-522 Project: C++ Standard Library Issue Typ

Re: svn commit: r565959 - /incubator/stdcxx/trunk/etc/config/src/EXTERN_C_EXCEPTIONS.cpp

2007-08-14 Thread Martin Sebor
Travis Vitek wrote: Martin, I'm not sure if you're aware, but I don't believe that the destructors for stack objects inside the C functions will be called. I know that this is the case for MSVC7/8. This isn't an issue for your testcase, but it may be an issue for the functions invoked by __rw_on

Re: [PATCH] Update tests 22.locale.[money,num,time].put.mt.cpp to validate results [take 3]

2007-08-14 Thread Martin Sebor
Travis Vitek wrote: Attached is a patch to enhance the money_put, num_put and time_put facet mt tests. Threads verify that the values put compare equal to those put in the primary thread. Also includes change to rw_locale() so that the C locale can always appear at the front of the locale list.

RE: svn commit: r565959 - /incubator/stdcxx/trunk/etc/config/src/EXTERN_C_EXCEPTIONS.cpp

2007-08-14 Thread Travis Vitek
Sorry, I should clarify that. Destructors for stack objects in C functions aren't called when an exception is thrown. Testcase... C:\>(type t.cpp) && (cl /nologo /EHsc t.cpp) struct Object { static int counter; Object() { Object::counter += 1; } ~Object() { Object:

RE: svn commit: r565959 - /incubator/stdcxx/trunk/etc/config/src/EXTERN_C_EXCEPTIONS.cpp

2007-08-14 Thread Travis Vitek
Martin, I'm not sure if you're aware, but I don't believe that the destructors for stack objects inside the C functions will be called. I know that this is the case for MSVC7/8. This isn't an issue for your testcase, but it may be an issue for the functions invoked by __rw_once. I think this is

[jira] Closed: (STDCXX-482) [Sun C++ 5.9] LIMITS configuration test enters infinite loop in optimized builds

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor closed STDCXX-482. --- Resolution: Fixed Nightly tests indicate that the problem has been resolved. > [Sun C++ 5.9] LIMITS

[jira] Updated: (STDCXX-482) [Sun C++ 5.9] LIMITS configuration test enters infinite loop in optimized builds

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor updated STDCXX-482: Affects Version/s: (was: 4.2) trunk Fix Version/s: trunk 4.1.3 d

[jira] Closed: (STDCXX-470) [Sun C++/Solaris/AMD64] BUILDMODE=wide has no effect

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor closed STDCXX-470. --- Resolution: Fixed Fix Version/s: 4.2 Nightly build results confirm that the patch fixed it. >

[jira] Updated: (STDCXX-470) [Sun C++/Solaris/AMD64] BUILDMODE=wide has no effect

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor updated STDCXX-470: Affects Version/s: (was: 4.2) 4.1.3 I suspect (but haven't actually conf

[jira] Assigned: (STDCXX-470) [Sun C++/Solaris/AMD64] BUILDMODE=wide has no effect

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-470: --- Assignee: Martin Sebor > [Sun C++/Solaris/AMD64] BUILDMODE=wide has no effect > -

[jira] Updated: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor updated STDCXX-521: Affects Version/s: (was: 4.2) trunk > [gcc/GNU make 3.79.1] linker error

[jira] Closed: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor closed STDCXX-521. --- Resolution: Fixed Fix Version/s: trunk Builds from last night indicate that the the problem ha

[jira] Commented: (STDCXX-504) Add Apache copyright notices

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519754 ] Martin Sebor commented on STDCXX-504: - I looked at one of the HTML files in the attachment and noticed that the n

Re: [RFC] Apache "look and feel" for stdcxx docs

2007-08-14 Thread Martin Sebor
Martin Sebor wrote: [...] I expanded the .zip file containing a mock-up of Marc's proposed changes and put it up on my home page: http://people.apache.org/~sebor/stdcxx-506/ We're looking for feedback on the changes, positive or negative, as well as suggestions for additional improvements. To

[jira] Updated: (STDCXX-260) configure-like script to configure library

2007-08-14 Thread Eric Lemings (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Lemings updated STDCXX-260: Attachment: configure.out For ease of reference, the attached file contains the help/usage message

Re: Taking tasks for STDCXX-391

2007-08-14 Thread Martin Sebor
Just a couple of high-level comments: Unless you're posting a preview of your changes please submit patches with diffs (in a unified diff format) against the latest files on trunk. When posting previews, it would make it easier if you could post them live on your own publicly accessible web site

[RFC] Apache "look and feel" for stdcxx docs

2007-08-14 Thread Martin Sebor
Hey everyone, Marc Betz has been working on the improvements to the stdcxx documentation outlined in STDCXX-391. Most of them are pretty straightforward and can, IMO, be implemented without much debate (although feedback is always appreciated :) but there is one that I think we need input on from

[jira] Assigned: (STDCXX-504) Add Apache copyright notices

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-504: --- Assignee: Marc Betz Assigned to Marc. Marc: please attach diffs against the original files i

[jira] Commented: (STDCXX-505) Update the Acknowledgments page

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519744 ] Martin Sebor commented on STDCXX-505: - I think we might want to retain Rogue Wave people that actually worked on

Re: svn commit: r565221 - /incubator/stdcxx/trunk/tests/src/char.cpp

2007-08-14 Thread Martin Sebor
[EMAIL PROTECTED] wrote: Author: faridz Date: Sun Aug 12 18:47:17 2007 New Revision: 565221 URL: http://svn.apache.org/viewvc?view=rev&rev=565221 Log: 2007-08-13 Farid Zaripov <[EMAIL PROTECTED]> * char.cpp (rw_widen): Don't write after end of dst. Why not? I.e., what was wrong with t

[jira] Assigned: (STDCXX-516) Rename generate.bat as configure.bat.

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-516: --- Assignee: Farid Zaripov Assigning to the maintainer of the Windows infrastructure. > Rename

[jira] Assigned: (STDCXX-260) configure-like script to configure library

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-260: --- Assignee: Martin Sebor (was: Farid Zaripov) Rats! I meant to assign this to myself and STDCX

[jira] Commented: (STDCXX-516) Rename generate.bat as configure.bat.

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519734 ] Martin Sebor commented on STDCXX-516: - This makes sense to me, although I think we want to hold off on renaming i

[jira] Assigned: (STDCXX-260) configure-like script to configure library

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-260: --- Assignee: Farid Zaripov Assigning to Farid, the maintainer of the Windows infrastructure. >

Re: svn commit: r564213 - /incubator/stdcxx/trunk/include/sstream.cc

2007-08-14 Thread Martin Sebor
This isn't the reason for STDCXX-515, is it? Martin [EMAIL PROTECTED] wrote: Author: faridz Date: Thu Aug 9 07:21:44 2007 New Revision: 564213 URL: http://svn.apache.org/viewvc?view=rev&rev=564213 Log: 2007-08-09 Farid Zaripov <[EMAIL PROTECTED]> STDCXX-514 * sstream.cc (str)

Re: svn commit: r563682 - in /incubator/stdcxx/trunk/src: once.cpp once.h

2007-08-14 Thread Martin Sebor
Thanks for pointing it out! I noticed it too when I tested the change on Windows but I haven't decided how to deal with it yet. Compilers often assume that functions with C linkage don't throw exceptions and generate code that breaks when an exception does end up being thrown. I think MSVC is one

Re: svn commit: r544831 - /incubator/stdcxx/trunk/examples/tutorial/dynatype.cpp

2007-08-14 Thread Martin Sebor
[EMAIL PROTECTED] wrote: Author: faridz Date: Wed Jun 6 06:03:48 2007 New Revision: 544831 URL: http://svn.apache.org/viewvc?view=rev&rev=544831 Log: 2007-06-06 Farid Zaripov <[EMAIL PROTECTED]> * dynatype.cpp (copy): static_cast to const T& instead of T Why is this an improvement ov

[jira] Assigned: (STDCXX-517) No required options for generate.bat script

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-517: --- Assignee: Farid Zaripov Assigned to Farid, the Windows infrastructure maintainer. > No requi

[jira] Commented: (STDCXX-517) No required options for generate.bat script

2007-08-14 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519720 ] Martin Sebor commented on STDCXX-517: - Makes sense to me. What do you think about it, Farid? > No required optio

Re: svn commit: r564694 - /incubator/stdcxx/trunk/util/exec.cpp

2007-08-14 Thread Martin Sebor
[EMAIL PROTECTED] wrote: Author: faridz Date: Fri Aug 10 10:48:01 2007 New Revision: 564694 URL: http://svn.apache.org/viewvc?view=rev&rev=564694 Log: 2007-08-10 Farid Zaripov <[EMAIL PROTECTED]> * exec.cpp (fttoull) [_WIN32]: New function to convert from FILETIME to ULONGLONG.

Re: [PATCH] STDCXX-515

2007-08-14 Thread Martin Sebor
Farid Zaripov wrote: Below is the patch for fix STDCXX-515. ChangeLog: * sstream.cc (xsputn): Correct write position after growing the buffer. Why do we need to do it in xsputn()? Isn't str() supposed to keep pptr() at the right offset after growing the buffer? Martin Index: sstream.

Re: [PATCH] for string::append(const_pointer)

2007-08-14 Thread Martin Sebor
mark.g.brown wrote: Hi, I have been working on a fix for STDCXX-493. The attached patch tries to improve both the const_pointer and string overloads but makes no attempt to do anything with the value_type overload. I was successful in making the const_pointer overload run faster (about 6 times f

Re: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2]

2007-08-14 Thread Martin Sebor
Travis Vitek wrote: Martin Sebor wrote: +#define countof(x) (sizeof (x) / sizeof (*x)) Since you seem to like it so much ;-) we might as well move this macro to some central test suite header (and rename it according to the naming convention). I'd love to, provided that we can define the n