RE: Wildcard-matched actions (again)

2003-08-14 Thread Steve Raeburn
-Original Message- From: Robert Leland [mailto:[EMAIL PROTECTED] Sent: August 11, 2003 7:41 PM To: Struts Developers List Subject: Re: Wildcard-matched actions (again) Don Brown wrote: Heh, thankfully no. :) In fact, that's one of the reasons I'd like to incorporate

Re: Wildcard-matched actions (again)

2003-08-14 Thread Don Brown
Heh, thankfully no. :) In fact, that's one of the reasons I'd like to incorporate this into Struts itself to remove that alternate processor requirement. The patch adds a couple of lines to RequestProcessor.processMapping() to, in the case of no direct mapping found, try to match any wildcards.

RE: Wildcard-matched actions (again)

2003-08-14 Thread Craig R. McClanahan
On Mon, 11 Aug 2003, Steve Raeburn wrote: Date: Mon, 11 Aug 2003 19:55:14 -0700 From: Steve Raeburn [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED], [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Wildcard-matched actions (again) I

Re: Wildcard-matched actions (again)

2003-08-14 Thread Matthias Bauer
If performance is not affected, then there is indeed no need to turn this feature off. Don Brown wrote: I apologize if I wasn't clear; there is absolutely no performance penalty for any existing or future Struts applications that do not use wildcards. Upon initialization of the

Re: Wildcard-matched actions (again)

2003-08-14 Thread Ted Husted
The one thing that the ticket doesn't say specifically is whether you are already using the patch in a working application. If so, and it's working well for you in practice, then I'd say commit it. But, if its experimental, then I'd say let's roll a 1.2.x GA first before playing with something

Re: Wildcard-matched actions (again)

2003-08-14 Thread Don Brown
I apologize if I wasn't clear; there is absolutely no performance penalty for any existing or future Struts applications that do not use wildcards. Upon initialization of the RequestProcessor, it runs through each action mapping to see if any of them use wildcards. Only if a wildcard is found in

Re: Wildcard-matched actions (again)

2003-08-14 Thread Matthias Bauer
I haven't actually look at the code yet, but as I understand it, wildcards are not even considered unless no other match is found. In which case you would be getting an error page anyway. If that's the way it actually works (and I believe this was the original proposal), I'm ok with it --

RE: Wildcard-matched actions (again)

2003-08-14 Thread Deadman, Hal
Developers List Subject: Re: Wildcard-matched actions (again) --- Robert Leland [EMAIL PROTECTED] wrote: Matthias Bauer wrote: I would like to be able to turn off this pattern matching feature, as performance is a very critical issue for a CMS. +1 So far I haven't heard any

Re: Wildcard-matched actions (again)

2003-08-14 Thread mrdon
You still wouldn't see any performance hit as since you aren't using any action mappings with wildcards, there would be no pattern matching. It can only match a URI against a compiled pattern if one or more action mappings use wildcards. If there are no compiled patterns, the method will simply

Wildcard-matched actions (again)

2003-08-14 Thread Don Brown
I'd like to put the wildcard-matched action code from Bug #21813 (http://issues.apache.org/bugzilla/show_bug.cgi?id=21813) into Struts. When I mentioned it last, the only concern I heard raised was from Craig regarding performance penalties. As I noted in the bug description, the path isn't

Re: Wildcard-matched actions (again)

2003-08-14 Thread David Graham
--- Robert Leland [EMAIL PROTECTED] wrote: Matthias Bauer wrote: I would like to be able to turn off this pattern matching feature, as performance is a very critical issue for a CMS. +1 So far I haven't heard any definitive answer to the performance question. If there isn't any

Re: Wildcard-matched actions (again)

2003-08-14 Thread Robert Leland
Matthias Bauer wrote: I would like to be able to turn off this pattern matching feature, as performance is a very critical issue for a CMS. +1 --- Matthias - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: Wildcard-matched actions (again)

2003-08-14 Thread Robert Leland
Don Brown wrote: Heh, thankfully no. :) In fact, that's one of the reasons I'd like to incorporate this into Struts itself to remove that alternate processor requirement. The patch adds a couple of lines to RequestProcessor.processMapping() to, in the case of no direct mapping found, try to

Re: Wildcard-matched actions (again)

2003-08-12 Thread David Graham
--- Don Brown [EMAIL PROTECTED] wrote: I'd like to put the wildcard-matched action code from Bug #21813 (http://issues.apache.org/bugzilla/show_bug.cgi?id=21813) into Struts. When I mentioned it last, the only concern I heard raised was from Craig regarding performance penalties. As I noted