Re: export to diveshare?

On Fri, Sep 19, 2014 at 4:25 AM, Salvo Tomaselli wrote: > Hello, > > I've been improving http://dive-share.appspot.com/ > I took a quick look at the web page, and the first link is dead ("Upload a log from subsurface"). > > So I think it is time to sta

Re: XDeep Black BT import

just right click on one heading marker and filter thfm out. Not perfect, but a functional workaround. This has been brought up before, but no real solution is implemented so far. miika > On 16 Sep 2014, at 06:02, Davide DB wrote: > > Hi all, > > I downloaded my first dives logged with this n

[PATCH] Fix water temperature on Suunto SDM import

Seems that Suunto stores temperature value of 0 when there is no temperature reading (I guess). Thus this patch ignores temperature samples that are zero. Otherwise, Subsurface looks into the samples and grabs the lowest number as water temperature. See #720 Signed-off-by: Miika Turkia

Re: Ubuntu -- how upgrade Subsurface?

On Fri, Aug 22, 2014 at 6:40 AM, Steve Butler wrote: > "Canonical does not provide updates for subsurface. Some updates may be > provided by the Ubuntu community" according to the software center in > Ubuntu 13.04 > > Suggestions? > We have our own PPA to provide the latest release of Subsurface

Re: first glimpse at some statistics

On Thu, Aug 21, 2014 at 8:55 PM, Dirk Hohndel wrote: > On Thu, Aug 21, 2014 at 05:37:47PM +0300, Miika Turkia wrote: > > On Thu, Aug 21, 2014 at 3:06 PM, Dirk Hohndel wrote: > > > > > > > > Download statistics: > > > Downloads: 700 > > > Ma

Re: first glimpse at some statistics

On Thu, Aug 21, 2014 at 3:06 PM, Dirk Hohndel wrote: > > Download statistics: > Downloads: 700 > Mac 176 (25%) > Windows 524 (74%) > I have some additional info from the beloved Ubuntu. These are the downloads from our PPA repository of the 4.2 version of Subsurface: trusty_amd64: 49 tr

Re: help : resizable is not possible

On Wed, Aug 20, 2014 at 3:29 PM, Dirk Hohndel wrote: > On Wed, Aug 20, 2014 at 08:23:51AM -0300, Tomaz Canabrava wrote: > > Em 20/08/2014 06:39, "Benjamin" escreveu: > > > > > > This may be flogging a dead horse, but maybe instead of just changing > the > > icon layout, would it help if the user

Re: Gehad's pathes

On Sun, Aug 17, 2014 at 7:01 PM, Miika Turkia wrote: > Hello, > > yet again a set of patches from Gehad. I did not include the fake > precision one as it breaks gas consumption graph. (There is also one patch > from me fixing a typo that causes the Location text to be undef

Re: My progress in HTML export.

nd sent two other fixes. > > > On Sun, Aug 17, 2014 at 6:59 PM, Miika Turkia > wrote: > >> Following patch breaks the gas consumption graph: >> >> b06b0cd008a76b28f29f6f9fc649ed08e56e6207 HTML: Fix Fake precision >> value. >> >> miika >>

Gehad's pathes

From: Gehad elrobey Date: Sat, 16 Aug 2014 17:23:34 +0300 Subject: [PATCH 7/8] HTML: change empty O2 Value to Air. -Change column name to 'Gas' as changed in Subsurface. -Replace '--' with 'Air' to empty tanks. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turk

Re: My progress in HTML export.

d arrows navigation >> between dives I will fix it and submit a patch later. >> I ll also work on some style enhancement. >> >> thanks. >> >> >> On Sun, Aug 10, 2014 at 6:22 PM, Miika Turkia >> wrote: >> >>> Thanks. I just fixed a few typo

Re: [PATCH] HTML export fixes

On Sat, Aug 16, 2014 at 4:00 PM, Gehad Elrobey wrote: > > > > On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel wrote: > > - Gas list >> While air gets '0' as O₂ value (for reasons Linus has explained many >> times), we should show "Air" and not an O₂ of "--" >> > > I don't understand this, do I

Re: twin tanks and export to divelogs.de

k dive. Of course this is true for the predefined double cylinders but I have no idea how imperial people would mark their cylinders... miika From 451422ef40ca9ebccd63389cd9720128fff7b3d9 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Sat, 16 Aug 2014 10:00:14 +0300 Subject: [PATCH] Hack dou

Re: [PATCH] HTML export fixes

We should have created tickets on bugtracker of all the issues instead of just listing them on emails. I haven't been able to follow all the issues I have mentioned and I am sure it is even harder for Gehad... miika From 2dfc869eaccbae285c9c96f9b65643f957ae41be Mon Sep 17 00:00:00 2001 From: Miik

[PATCH] HTML export fixes

st view and detailed dive view. - Add hyperlink that opens the dive location in a new tab viewed in Google maps. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- save-html.c | 18 +- theme/list_lib.js | 31 +++ 2 files changed,

[PATCH] HTML export patches

Resending as requested. miika -- Forwarded message -- From: Miika Turkia Date: Sun, Aug 10, 2014 at 6:30 PM Subject: HTML export patches To: Subsurface Mailing List Hi, here are some patches (from Gehad) to the HTML export. A couple of new strings now that 4.2 is out :D Now

HTML export patches

will contain characters that should be quoted? miika From 14525ed3e05c7895958fdb6da64f435870de3ed5 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Sun, 10 Aug 2014 18:10:07 +0300 Subject: [PATCH 10/10] Fix typo on HTML export Signed-off-by: Miika Turkia --- save-html.c | 2 +-

Re: My progress in HTML export.

; This is a try to make the HTML exports Multilingual I also fixed some bugs. > I still need to update the user-manual if you find that these patches are > good. > > Thanks. > > > On Fri, Aug 8, 2014 at 6:22 PM, Miika Turkia > wrote: > >> On Fri, Aug 8, 2014 at 5

Re: My progress in HTML export.

On Fri, Aug 8, 2014 at 5:32 PM, Gehad Elrobey wrote: > I have attached some patches that improves the statistics table view and > fix the cells layout. > > Thanks, I'll take a look later. > > > On Mon, Aug 4, 2014 at 6:40 PM, Miika Turkia > wrote: > >> Lo

[PATCH 2/2] Improve wording on ReleaseNotes

Signed-off-by: Miika Turkia --- ReleaseNotes.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ReleaseNotes.txt b/ReleaseNotes.txt index 510ed05..64d646b 100644 --- a/ReleaseNotes.txt +++ b/ReleaseNotes.txt @@ -56,11 +56,12 @@ Some of the changes since 4.1 This is

[PATCH 1/2] Improve wording on README

Signed-off-by: Miika Turkia --- README | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/README b/README index da25f29..d82d035 100644 --- a/README +++ b/README @@ -17,12 +17,12 @@ git clone git://subsurface.hohndel.org/subsurface.git . You can also browse the

[PATCH] Fix compile warning

warning: format not a string literal and no format arguments Signed-off-by: Miika Turkia --- planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planner.c b/planner.c index 3efa702..60751fc 100644 --- a/planner.c +++ b/planner.c @@ -534,7 +534,7 @@ static void

Re: test binaries for Beta 5

On Tue, Aug 5, 2014 at 5:49 PM, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: > > Export to divelogs.de is working great now! Win7 64 bit. > > Good. > > > Error messages look much better with the Close on the right hand side. > > :-) > > > Unfortunately I a

[PATCH] Remove wrong unit from CNS in UDDF import

Signed-off-by: Miika Turkia --- xslt/uddf.xslt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xslt/uddf.xslt b/xslt/uddf.xslt index d8ea618..c4911c5 100644 --- a/xslt/uddf.xslt +++ b/xslt/uddf.xslt @@ -454,7 +454,7

Re: test binaries for Beta 5

On Tue, Aug 5, 2014 at 12:20 PM, Lubomir I. Ivanov wrote: > On 5 August 2014 06:40, Miika Turkia wrote: > > Can someone also test the divelogs.de upload/download on Windows? > > > > download(import) from divelogs.de works, but i can't find where the > upload is.

Re: test binaries for Beta 5

On Tue, Aug 5, 2014 at 12:05 AM, Lubomir I. Ivanov wrote: > On 4 August 2014 23:29, Dirk Hohndel wrote: > > I think these are the binaries that I want for Beta 5 > > > > Please give them a try, ESPECIALLY(!!!) the Mac DMG. There have been > quite > > a few changes under the hood (and no, I don't

[PATCH] HTML export patches

. miika From 0d133413f58e4c04c356b19102e6958cb2deba59 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Mon, 4 Aug 2014 18:22:05 +0300 Subject: [PATCH 10/10] HTML: prevent implicit type conversion Signed-off-by: Miika Turkia --- theme/dive_export.html | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: My progress in HTML export.

ay, I had some family vacations this week. > I Implemented the yearly statistics into the HTML exports (Patches are > attached), also there are some patches not applied to current master yet.. > I am waiting your feedback. > > Regards, > Gehad > > > On Mon, Jul 28, 2014 at 5:

Re: [PATCH] Various updates to user manual

On Mon, Aug 4, 2014 at 11:08 AM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > On 04/08/2014 07:00, Miika Turkia wrote: > > On Thu, Jul 24, 2014 at 10:31 PM, Willem Ferguson < > willemfergu...@zoology.up.ac.za> wrote: > >> >> N.B.: >>

Re: [PATCH] Various updates to user manual

On Thu, Jul 24, 2014 at 10:31 PM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > > N.B.: > The only outstanding issue that I am aware of, is the discussion last week > about including > depth and time pointers along the Y and X axes respectively when the > cursor is > moved about on t

Re: anyone with access to Windows (real or VM), please test...

On Sun, Aug 3, 2014 at 10:25 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > On Sun, Aug 3, 2014 at 12:09 PM, Dirk Hohndel wrote: > > On Sun, Aug 03, 2014 at 11:13:23AM -0700, Linus Torvalds wrote: > >> > >> It looks like the windows vsnprintf() function doesn't understand > >> posit

Re: anyone with access to Windows (real or VM), please test...

On Sun, Aug 3, 2014 at 4:20 PM, Thiago Macieira wrote: > On Sunday 03 August 2014 10:17:56 Miika Turkia wrote: > > - QString filename = QDir::tempPath() + "/import-" + > > QString::number(qrand() % ) + ".dld"; > > + QString filename

Re: some corrections to the manual

ng the final PDF. HTML document seems to work. miika From cd6bc0433bc1b51172b0d67d308c9d5aa52b00c6 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Sun, 3 Aug 2014 20:04:06 +0300 Subject: [PATCH] Fix some compile issues in Spanish user manual It seems that anchors cannot be placed on paragraphs

Re: anyone with access to Windows (real or VM), please test...

t or \windows directory with no access rights). If so, the attached patch should fix this. miika From 142f04b97b05cd05017a6aa5a8c8df7052fed555 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Sun, 3 Aug 2014 10:11:20 +0300 Subject: [PATCH] Try to fix divelogs upload on Windows We use zip_open w

patches for user manual

only the part that is different. miika From 708eac9d10a798efa8ef2e4e9259d5b7c755825b Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Sat, 2 Aug 2014 09:07:57 +0300 Subject: [PATCH 4/4] Some more clarifications and fixes to user manual Signed-off-by: Miika Turkia --- Documentation/user

[PATCH 1/2] User manual: data base -> database

Signed-off-by: Miika Turkia --- Documentation/user-manual.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index de3e8af..d065c9f 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user

[PATCH 2/2] Reasoning for importing dives from other log books

Signed-off-by: Miika Turkia --- Documentation/user-manual.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index d065c9f..2551cf4 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user

[PATCH] tuning user manual

Here are two small patches for the user manual. Trying to avoid repetition and use a bit more common sentences. So far I only took a look at the start of the manual... miika From b931fe1cb654ba6911de620c5d02e311f26b2607 Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Wed, 30 Jul 2014 07:26:04

[PATCH] user manual syntax fixes

Turkia Date: Tue, 29 Jul 2014 21:56:57 +0300 Subject: [PATCH 2/2] Image declaration to one line on ES manual It appears that new lines are not allowed on image declarations on user manual. Signed-off-by: Miika Turkia --- Documentation/user-manual_es.txt | 3 +-- 1 file changed, 1 insertion(+), 2

Re: My progress in HTML export.

a On Sun, Jul 27, 2014 at 11:01 PM, Gehad Elrobey wrote: > I Attached four patches that fix the mentioned bugs. I ll still work on > more improvements for the current javascript code. > > Regards, > Gehad > > > On Fri, Jul 25, 2014 at 8:02 AM, Miika Turkia > wrote:

[PATCH] CSV import: add min:sec format support

On CSV import the time can be represented with seconds, min:sec or hour:min:sec. This patch adds support for the min:sec format that was missing. See #662 Signed-off-by: Miika Turkia --- xslt/csv2xml.xslt | 5 + 1 file changed, 5 insertions(+) diff --git a/xslt/csv2xml.xslt b/xslt

[PATCH] Fix for sample interval on Divelogs.de export

Logic when to use default sample interval was mixed. Fixes #657 Signed-off-by: Miika Turkia --- xslt/divelogs-export.xslt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xslt/divelogs-export.xslt b/xslt/divelogs-export.xslt index 5022428..3de8c60 100644 --- a/xslt/divelogs

[PATCH] HTML export

last sorting to new search results. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/dive_export.html | 12 +-- theme/list_lib.js | 55 +- 2 files changed, 47 insertions(+), 20 deletions(-) diff --git a/theme

Re: My progress in HTML export.

y implemented first than a whole lot of incomplete mess... > On Mon, Jul 21, 2014 at 7:32 AM, Miika Turkia > wrote: > >> On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey >> wrote: >> >>> >>> Hi miika, >>> >>> On Sun, Jul 20, 2014 at

Re: Wrong profiles importing from Diving log 5.0 to Subsurface 4.1

maximum depth, then it was considered to be imperial units. Attached patch doubles the maximum depth value of this comparison, so the difference must be quite significant for this test to fail in the future. miika From 417ce39ed6d69a4d491abbbfab2e03fd9504e984 Mon Sep 17 00:00:00 2001 From: Miika T

Re: My progress in HTML export.

Here is the latest set with my SOB and some typo fixes for the commit messages. Event value of 0 for the events that don't really have any value looks a bit weird.   would be a better choice, I suppose. miika On Mon, Jul 21, 2014 at 8:32 AM, Miika Turkia wrote: > On Mon, Jul 21, 2014

Re: My progress in HTML export.

On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey wrote: > > Hi miika, > > On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia > wrote: > >> New bugs I spotted: >> >> - The tooltip on temperature graphs shows actually the time (concatenated >> with temperature

Re: [PATCH 2/2] Add type for gaschange events, if missing

On Thu, Jul 17, 2014 at 7:45 PM, Anton Lundin wrote: > On 17 July, 2014 - Miika Turkia wrote: > > > On Thu, Jul 17, 2014 at 10:05 AM, Anton Lundin > wrote: > > > > > On 12 July, 2014 - Miika Turkia wrote: > > > > > > > On Sat, Jul 12, 2014 at 3

Re: My progress in HTML export.

din wrote: >> > On 15 July, 2014 - Anton Lundin wrote: >> > >> >> On 15 July, 2014 - Miika Turkia wrote: >> >> >> >> > A few more bugs: >> >> > - Trimix dives are missing He content (use e.g. test20.xml for >> testing >

Re: [PATCH 2/2] Add type for gaschange events, if missing

On Thu, Jul 17, 2014 at 10:05 AM, Anton Lundin wrote: > On 12 July, 2014 - Miika Turkia wrote: > > > On Sat, Jul 12, 2014 at 3:21 PM, Anton Lundin wrote: > > > > > On 12 July, 2014 - Miika Turkia wrote: > > > > > > > On Sat, Jul 12, 2014 at 2:24

[PATCH] Set proper gas type on UDDF import

Use type 25 on UDDF import when the gas mix contains some helium. Signed-off-by: Miika Turkia --- xslt/uddf.xslt | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/xslt/uddf.xslt b/xslt/uddf.xslt index 618c080..d8ea618 100644 --- a/xslt/uddf.xslt

[PATCH] Index used cylinder properly on divelogs.de export

The wrong O2 percentage was due to not referring to the correct cylinder but grabbing any o2 value in any cylinder. While fixing this, I noticed that also end pressure was missing the cylinder selection, so fixing that as well. Fixes #626 Signed-off-by: Miika Turkia --- xslt/divelogs

Re: [PATCH] Suppress XML preamble in CSV export

On Wed, Jul 16, 2014 at 11:57 AM, Sergey Starosek wrote: > To obey element > one should rely on libxslt to do its job instead of writing > document himself. > Excellent, just one nitpick. On C side we declare variables at the beginning of a function or code block. This doesn't seem to be stated

[PATCH 1/2] Fix the description of test dive cylinders

It is really confusing when the size of the cylinder does not match the description. Inconsistent data in will mean inconsistent data out and validating that export works means I try to get consistent data out... Signed-off-by: Miika Turkia --- dives/test18.xml | 2 +- dives/test19.xml | 2

[PATCH 2/2] Try to detect first cylinder on divelogs.de export

#626 Signed-off-by: Miika Turkia --- xslt/divelogs-export.xslt | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/xslt/divelogs-export.xslt b/xslt/divelogs-export.xslt index 614fafd..b13006d 100644 --- a/xslt/divelogs-export.xslt +++ b/xslt

Re: My progress in HTML export.

A few more bugs: - Trimix dives are missing He content (use e.g. test20.xml for testing purposes) - Reported by Roberto, but mailing list was not included - Gas change and heading events should have the value information shown; mix and direction - When there is no pressure samples, the y-axis on ri

Re: My progress in HTML export.

On Tue, Jul 15, 2014 at 12:31 PM, "Paul-Erik Törrönen" wrote: > > If you have time and want to implement a worldmap integration to the > > logbook export, it sure would be a nice to have feature. Of course it > > would > > be nice to know if other people are interested in using such feature with

Re: XML preamble in CSV export

On Tue, Jul 15, 2014 at 4:00 PM, Sergey Starosek wrote: > Miika, > > Is it OK that exported CSV file contains XML preamble along with header? > > >> "dive number","date","time","duration","depth","temperature","pressure" >> "83","2014-07-13","13:35:00","0:00","0.0",, > > I would prefer the expor

Re: tissue saturation in repetitive diving

On Tue, Jul 15, 2014 at 10:48 AM, Miika Turkia wrote: > On Tue, Jul 15, 2014 at 10:26 AM, Robert Helling > wrote: > >> >> On 15.07.2014, at 07:14, Miika Turkia wrote: >> >> There is something wrong currently with the calculation of tissue >> satura

Re: tissue saturation in repetitive diving

On Tue, Jul 15, 2014 at 10:26 AM, Robert Helling wrote: > > On 15.07.2014, at 07:14, Miika Turkia wrote: > > There is something wrong currently with the calculation of tissue > saturation. It looks like the earlier dive is getting cumulative saturation > from the later div

tissue saturation in repetitive diving

There is something wrong currently with the calculation of tissue saturation. It looks like the earlier dive is getting cumulative saturation from the later dive. Clearly visible when you open the XML and switch between the dives. There is also a spike on the start of the earlier dive as show on sc

Re: My progress in HTML export.

os slider style and adding > additional dive data to the dive status. > > Also do you think adding a Google map or some kind of maps to show the > dive location will be needed? > > waiting for your feedback. > > Regards, > Gehad > > > On Fri, Jul 11, 2014 at 6:

Re: Beta1

> On 14 Jul 2014, at 18:37, Jan Birk wrote: > > Den 13-07-2014 13:44, Miika Turkia skrev: >> Ubuntu binaries available in ppa:miika-turkia/subsurface-git - we could also >> have a beta repository under the subsurface Launchpad site, but as I do not >> have power t

[PATCH] Remove theme directory when uninstalling on Windows

I assume the theme directory should be deleted on uninstall the same way e.g. Documentation directory is deleted. Signed-off-by: Miika Turkia --- This is not tested --- packaging/windows/subsurface.nsi.in | 1 + 1 file changed, 1 insertion(+) diff --git a/packaging/windows/subsurface.nsi.in b

[PATCH 2/3] Typo fix Ave. => Avg.

Fixes #619 Signed-off-by: Miika Turkia --- qt-ui/maintab.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/maintab.ui b/qt-ui/maintab.ui index 7fa8620..2770801 100644 --- a/qt-ui/maintab.ui +++ b/qt-ui/maintab.ui @@ -547,7 +547,7

[PATCH 3/3] Change default export tab to "General export"

I prefer that we show the first tab by default. Everyone should remember that Qt Creator changes the currently shown tab as default on save. Signed-off-by: Miika Turkia --- qt-ui/divelogexportdialog.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui

[PATCH 1/3] Add tooltip for toggle pictures

Fixes #618 Signed-off-by: Miika Turkia --- qt-ui/mainwindow.ui | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui/mainwindow.ui b/qt-ui/mainwindow.ui index 3bcfb7e..b2391fe 100644 --- a/qt-ui/mainwindow.ui +++ b/qt-ui/mainwindow.ui @@ -497,6 +497,9

Re: Beta1

On Sun, Jul 13, 2014 at 8:30 AM, Dirk Hohndel wrote: > Tagged, binaries are in the downloads folder. > > I didn't get as much done today as I had planned since my brand new > quadcopter decided to take a rest at the top of an 80ft / 25m tree for a > few hours while I desperately tried to get it d

Re: [PATCH 2/2] Add type for gaschange events, if missing

On Sat, Jul 12, 2014 at 3:21 PM, Anton Lundin wrote: > On 12 July, 2014 - Miika Turkia wrote: > > > On Sat, Jul 12, 2014 at 2:24 PM, Anton Lundin wrote: > > > > > On 12 July, 2014 - Miika Turkia wrote: > > > > > > > Subsurface has saved

Re: [PATCH 2/2] Add type for gaschange events, if missing

On Sat, Jul 12, 2014 at 2:24 PM, Anton Lundin wrote: > On 12 July, 2014 - Miika Turkia wrote: > > > Subsurface has saved gas change events without type attribute at some > > point. Thus we need to add the type when reading in log files, if it is > > missing. (Gas change

[PATCH 1/2] Fix inserting gaschange events

Use a macro that works to get the current DC. Fixes #613 Signed-off-by: Miika Turkia --- qt-ui/profile/profilewidget2.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/profile/profilewidget2.cpp b/qt-ui/profile/profilewidget2.cpp index b0f2216..dfe514f 100644 --- a

[PATCH 2/2] Add type for gaschange events, if missing

Subsurface has saved gas change events without type attribute at some point. Thus we need to add the type when reading in log files, if it is missing. (Gas change logic relies on the type field nowadays.) Fixes #617 Fixes #600 Signed-off-by: Miika Turkia --- parse-xml.c | 6 ++ 1 file

[PATCH] Mark divelist changed when adding bookmark

Signed-off-by: Miika Turkia --- qt-ui/profile/profilewidget2.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-ui/profile/profilewidget2.cpp b/qt-ui/profile/profilewidget2.cpp index 69c52b7..b0f2216 100644 --- a/qt-ui/profile/profilewidget2.cpp +++ b/qt-ui/profile/profilewidget2.cpp

[PATCH] Add support for decimal comma on UDDF import

Gas changes generated by Xdeep can contain mix information with decimal comma instead of decimal point. Thus we need to convert the comma to point before performing mathematical operations on it. Fixes #612 Signed-off-by: Miika Turkia --- Note that the bug report wants also to ignore gas change

[PATCH] Add image support to UDDF export

This patch adds image support to UDDF export. As far as I can tell from the UDDF specification, the images can only be added to notes field, so that is what we do here. (buddy and owner can also have image tags, but that is irrelevant for Subsurface currently.) Signed-off-by: Miika Turkia

Re: My progress in HTML export.

e values of the pressure in the first and the last samples instead. Use the first / last non-zero values. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/list_lib.js | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/theme/list_lib.js

Re: Bug with Dive log from Suunto( without attachment)

On Thu, Jul 10, 2014 at 4:05 PM, oldrich.olmer wrote: > Hi Miika, > > Your XML works correctly :-) In the attachment you can see my not > function XML. When i tried to save your XML by my SUBSURFACE 4.1.0.0 and > open it again, it was also not working ... :-( > I use Windows XP SP3 and SUBSURF

[PATCH] Fix exporting all dives in Subsurface format

Exporting in Subsurface format saved only selected dives even if user attempted to save all dives. Signed-off-by: Miika Turkia --- qt-ui/divelogexportdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/divelogexportdialog.cpp b/qt-ui/divelogexportdialog.cpp

Re: Bug with Dive log from Suunto( without attachment)

Seems that the attachments have been removed. Can you try to send them directly to me? miika On Thu, Jul 10, 2014 at 2:48 PM, oldrich.olmer wrote: > > > Hi, > > Unfortunately last dive was my Suunto D6 flooded by salty water. In Suunto > service replaced electronic inside by Suunto D6i so I ca

Re: Downgrade

On Wed, Jul 9, 2014 at 4:20 PM, Davide DB wrote: > Can I downgrade from 4.1.379 to official 4.1 without braking my logbook? > I just realized that some dives have correct bottle info saved but CAS and > gas used doesn't appear on the information panel. > Should work fine. Of course, when using d

Re: Seabear dive computer integration in subsurface

On 08 Jul 2014, at 20:14, Dirk Hohndel wrote: > >> On Tue, Jul 08, 2014 at 02:42:57PM +0200, Benjamin Kuch wrote: >> Hi, >> >> >> >> I’m embedded software developer at Seabear diving technology. Currently we >> have one dive computer on the market (Seabear HUDC). Three others will >> follow so

Loading photos broken?

Is the loading of photos broken on current master? At least currently I am not getting any images included in a dive. (Works on Subsurface 4.1 when I have the time shift set to 12:00AM, but I haven't figured out how to get this to work on current master, which is quite weird for someone living with

Re: Restore autofilling coordinates for added dives

On Tue, Jul 8, 2014 at 10:52 AM, Gaetan Bisson wrote: > [2014-07-07 21:13:03 -1000] Gaetan Bisson: > > But somehow the loop at line 720 of qt-ui/maintab.cpp (after the comment > > "if we have a location text and haven't edited the coordinates...") does > > not work with a single dive. > > Alright

Re: Restore autofilling coordinates for added dives

Still does not seem to work for me. I have same location 5 times, 2 of them has GPS coordinates. And when I re-edit the location on the ones missing the coordinates, that still does not add them. It does not matter if I edit the dives singly or all 3 at one go. And it does not help if I clear the l

[PATCH] Show the gas mixing information only when needed

Recreational divers, especially ones diving with air, do not need to be shown that their gas can be mixed with 0 liters of O2 and He. And similarly Nitrox diver does not need to know about 0 liters of He. Signed-off-by: Miika Turkia --- qt-ui/maintab.cpp | 15 ++- 1 file changed, 14

[PATCH 7/8] Clean list_lib and remove unused code from canvas profile.

From: Gehad elrobey Comment some functions. remove leftover code from list_lib. Some code organization. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/list_lib.js | 228 -- 1 file changed, 50 insertions(+), 178 deletions

[PATCH 8/8] HTML: depth value must be positive

From: Gehad elrobey Remove negative sign from the inverted y-axis Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/list_lib.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/theme/list_lib.js b/theme/list_lib.js index 23906b4..718ea4c 100644 --- a

[PATCH 4/8] HTML: add events to detailed profile view

From: Gehad elrobey Export events to detailed dive view and add events to the profile. Events names must appear on mouse hover. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- save-html.c | 2 +- theme/list_lib.js | 35 --- 2 files changed

[PATCH 6/8] HTML: add temperature curve to profile.

From: Gehad elrobey Add temperature curve to profile view, The curve is tracable by mouse. The temperature has a hidden axis that doesn't appear in the detailed view. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/list_lib.js | 35 +

Re: My progress in HTML export.

About the patches... Why the commented lines below? +for (var i = 0; i < items[dive_id].events.length; i++) { +//var x = get_sample(items[dive_id].events[i].time); +d3.push([ +items[dive_id].events[i].time / 60, +0, +//-1 * mm_to_meter(items

[PATCH 5/8] HTML: dive numbering starts from one instead of zero

From: Gehad elrobey since the practise is that the first dive is number 1. so change the first dive number to 1 instead of 0. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- theme/list_lib.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/theme

[PATCH 3/8] Typo fixes on User Manual

Signed-off-by: Miika Turkia --- Documentation/user-manual.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index 48c8c07..4ff0a22 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user

[PATCH 2/8] Minor edits on HTML export (User Manual)

Signed-off-by: Miika Turkia --- Documentation/user-manual.txt | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index 563c593..48c8c07 100644 --- a/Documentation/user-manual.txt +++ b

[PATCH 1/8] User manual: HTML export update

From: Gehad elrobey This patch updated the export section in the user manual. Some changes to the description of the HTML export options. Signed-off-by: Gehad elrobey Signed-off-by: Miika Turkia --- Documentation/user-manual.txt | 23 +-- 1 file changed, 17 insertions

Re: My progress in HTML export.

On Fri, Jul 4, 2014 at 1:59 AM, Gehad Elrobey wrote: > I attached some patches that > -Fix the negative value of the depth axis. > -Added temperature curve and events to profile. > -Update user manual. > > About the (start and end pressures) null values bug, I found that these > values are missin

Re: [PATCH] User manual: Updates to dive export section (Worldmap, HTML)

;> Regards, >> Gehad >> >> >>> On Sun, Jun 29, 2014 at 12:58 AM, Miika Turkia >>> wrote: >>> Gehad, can you write a bit more about the HTML export before the next >>> release. I know, I do not fully understand all the differencies of the

Re: [PATCH] HTML: use Right/Left arrows to switch between dives

> On 01 Jul 2014, at 06:06, Gehad Elrobey wrote: > > > > >> On Mon, Jun 30, 2014 at 6:32 PM, "Paul-Erik Törrönen" >> wrote: >> This is not strictly on-topic, rather more generally about the HTML-export. >> >> A couple of issues spotted: >> >> * The tank display is messed up (see attachme

Re: [PATCH] User manual: Updates to dive export section (Worldmap, HTML)

Gehad, can you write a bit more about the HTML export before the next release. I know, I do not fully understand all the differencies of the options. (I don't remember when you planned the documentation, but before release would be good time to write for the end users.) miika > On 29 Jun 2014,

Re: homework

gmt+8 for one more week, so no progress on this end. miika > On 28 Jun 2014, at 01:59, Dirk Hohndel wrote: > > This drew remarkably few responses... > > So I'll try again :-) > >> On Mon, Jun 23, 2014 at 07:05:58AM +0800, Dirk Hohndel wrote: >> Hi, >> >> I'm still traveling and will be until

Re: My progress in HTML export.

> - fix any semantic errors in the dive profile or the events list and add > missing values. > - will have some clean documentation and polishing to the javascript code. > > Regards, > Gehad > > > > > > > > On Tue, Jun 24, 2014 at 4:41 PM, Dirk Hohndel w

  1   2   3   >