or maybe like this:
*ClassName::ClassName()*
* : **x(1)*
* , **y(2)*
* , **z(3)*
*{*
*}*
Benefits:
* Members are aligned(easy to read)
* Eazyer for adding new members to the end of the list(no need to worry
about the comma to last entry)
br, Boris..
On Mon, Mar 23, 2015 at 4:59 AM, Marcos Cardi
Hi Marcos,
*- Asset Management*
>
> The main concept of this project is very clear[2], but as I'm not a diver,
> I really appreciate your help to better understand all the details expected
> for this project. In this way I would have more knowledge to think about
> the data structure.
>
> Do you r
Hi Martin,
Good post indeed!
You gave a lot of useful info. Basically everything someone needs to start
working on this.
At this stage I think further details will just obfuscate your straight and
clear description.
Best
___
subsurface mailing list
su
Somali,
I'm not a mentor. Mentors haven't yet been assigned as this happens much
later in the process. However, I can give you some feedback on your
proposal.
The first thing you should know is that there are people interested in
almost every project on the list. It will be competitive, and those
Sorry... I missed this line, previously: "cloned the repo in a fedora vm
built it from the code using instructions given"
However, I don't see any patches from you on the mailing list. This should
probably be your next step.
Regards
Martin
On 23 March 2015 at 09:37, Long, Martin wrote:
> Soma
On 20 March 2015 at 03:27, Marcos Cardinot wrote:
> Hi everyone,
>
> Firstly, I would like to introduce myself...
> I'm a computer engineer and a physics student who wishes to apply for GSoC
> this year.
>
> In order to get familiar with the source code, I have been studying it and
> working on so
On Mon, Mar 23, 2015 at 12:29:48AM -0300, Marcos Cardinot wrote:
> From b4cd8716513a6448a84f144b76c33095b1aa0513 Mon Sep 17 00:00:00 2001
> From: Marcos CARDINOT
> Date: Sun, 22 Mar 2015 22:53:16 -0300
> Subject: [PATCH] load-git::walk_tree_file - missing break in switch
>
> Simple control flow i
On Mon, Mar 23, 2015 at 12:33:03AM -0300, Marcos Cardinot wrote:
> Hi,
>
> It's a simple issue, it seems that someone forgot the braces... please see
> attached patch.
Excellent find!
So Miika, without this patch it seems we only ever matched the first
cylinder...
> diff --git a/parse-xml.c b/p
On Mon, Mar 23, 2015 at 12:59:39AM -0300, Marcos Cardinot wrote:
> Hello folks,
>
> It is just a naive discussion about coding style... =D
Our favorite topic :-)
> According to the CodingStyle.txt:
>
> *"- in a C++ constructor initialization list, the colon is on the same line
> and*
> * conti
On Mon, Mar 23, 2015 at 09:44:33AM +0100, Boris Barbulovski wrote:
> or maybe like this:
>
> *ClassName::ClassName()*
> * : **x(1)*
> * , **y(2)*
> * , **z(3)*
> *{*
> *}*
>
> Benefits:
> * Members are aligned(easy to read)
> * Eazyer for adding new members to the end of the list(no need to worry
> 18 March 2015 at 02:22, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov"
>
> The extra call "dosomethingelse()" is added with the
> intention that user will not be confused to add braces
> around single lined "if" conditions.
>
> Signed-off-by: Lubomir I. Ivanov
> ---
> CodingStyle | 1 +
On 22 March 2015 at 22:57, Gehad Elrobey wrote:
> Hello,
>
> I have attached an updated version of my proposal.
> I am glad to hear any remarks.
>
thanks for the update, Gehad.
i have no more remarks ATM.
if others are interested in the future printing capabilities of
Subsurface, you can have a
On 22 March 2015 at 13:48, Claudiu Olteanu
wrote:
> Hello,
>
> This patch fixes some memory leaks from datatrak implementation.
>
it could clash with a change that the author / maintainer (Salvador)
has recently sent.
(the patch is not in master yet)
[PATCH] [datatrak.c] Improve error management
On 22 March, 2015 - Harshal Jalan wrote:
> The volumes of cylinders displayed in equipments tab was wrong. It was
> corrected by changing data about the cylinders in the code.
> Please have a look at the attached patch and suggest changes...
>
> Harshal Jalan
> From f6adc09d5aa9d8a5a9f958c318e14
On 22 March 2015 at 17:46, Claudiu Olteanu
wrote:
> I added more patches which will fix some memory leaks.
> Regarding the uemis-downloader.c source I am not sure if
> "iparam_buff" and "mbuf" variables should be freed too.
>
> I saw that one of the elements of "param_buff" is used as a result for
On 23 March 2015 at 06:43, Marcos Cardinot wrote:
> Hi,
>
> The attached patches initialize some members in several classes of the
> qt-ui package...
>
>
hello,
do these patches have the idea to solve compiler warnings (what GCC version
and -W level) or potentially dangerous lack of initializati
Yes, you are right. There is a simple white space fix in the
context of the memory leaks. I thought that since it is regarded
with the memory allocation/deallocation it wouldn't be a problem and
a second patch will be unnecessary. Sorry, my mistake.
I will create a new one when I will get home.
I
On Sun, Mar 22, 2015 at 01:48:43PM +0200, Claudiu Olteanu wrote:
> Hello,
>
> This patch fixes some memory leaks from datatrak implementation.
The reason I haven't applied these is simple.
Having these allocations hang around can be annoying and creates noise in
the valgrind output, but isn't ca
On Mon, Mar 23, 2015 at 05:37:32PM +0200, Claudiu Olteanu wrote:
> Yes, you are right. There is a simple white space fix in the
> context of the memory leaks. I thought that since it is regarded
> with the memory allocation/deallocation it wouldn't be a problem and
> a second patch will be unnecess
On Sun, Mar 22, 2015 at 10:58:21PM +0530, Harshal Jalan wrote:
> The volumes of cylinders displayed in equipments tab was wrong. It was
> corrected by changing data about the cylinders in the code.
> Please have a look at the attached patch and suggest changes...
>
> Harshal Jalan
> From f6adc09d
All of them are used locally. If you believe that it will be helpful I can
write a detailed report about each free call and the reason I used it.
Claudiu
On Mon, Mar 23, 2015 at 5:39 PM, Dirk Hohndel wrote:
> On Sun, Mar 22, 2015 at 01:48:43PM +0200, Claudiu Olteanu wrote:
> > Hello,
> >
> > Th
On Mon, Mar 23, 2015 at 05:50:07PM +0200, Claudiu Olteanu wrote:
> All of them are used locally. If you believe that it will be helpful I can
> write a detailed report about each free call and the reason I used it.
I usually prefer small, obvious patches with good commit messages. But
that doesn't
Hi Lubomir,
It's not about a dangerous lack of initialization - it's more about code
consistence. So, the question should be why not initialize all members as
we should do?
In addition, most of these are not following the new coding style (which we
discussed in another thread), so if you want to
On 23 March 2015 at 21:19, Dirk Hohndel wrote:
> On Sun, Mar 22, 2015 at 10:58:21PM +0530, Harshal Jalan wrote:
> > The volumes of cylinders displayed in equipments tab was wrong. It was
> > corrected by changing data about the cylinders in the code.
> > Please have a look at the attached patch a
please, use bottom posting.
On 23 March 2015 at 18:47, Marcos Cardinot wrote:
> Hi Lubomir,
>
> It's not about a dangerous lack of initialization - it's more about code
> consistence. So, the question should be why not initialize all members as we
> should do?
the answer is in the requests to ch
On Mon, Mar 23, 2015 at 10:46:45PM +0530, Harshal Jalan wrote:
> So what would be the correct way to solve this bug?
>
> One way that I can think of is to edit tank_info_t to contain the
> conversion factor between the internal volume and the air volume of the
> cylinder.
The problem is that the
On Mon, Mar 23, 2015 at 2:42 PM, Dirk Hohndel wrote:
> On Mon, Mar 23, 2015 at 12:33:03AM -0300, Marcos Cardinot wrote:
>> Hi,
>>
>> It's a simple issue, it seems that someone forgot the braces... please see
>> attached patch.
>
> Excellent find!
Indeed!
> So Miika, without this patch it seems w
I attached the rebased patches.
I also created a new one for the white spaces fix, as Lubomir suggested.
Happy hacking,
Claudiu
>>
>> Are you going to rebase them on the latest master?
>>
>> /D
>>
>
>
From 0b7abc44e7c89edcdf8a7a892f9897a4c03b6229 Mon Sep 17 00:00:00 2001
From: Claudiu Olteanu
D
On Sun, Mar 22, 2015 at 6:08 PM, André Lourenço
wrote:
> Hello, I'm André Lourenço and I'm pursuing a BSc in Computer Science in
> University of Évora, Portugal. I am interested in working with you in the
> "Asset Management" project for GSoC 2015. My main Language is C++ and I'm
> also experience
29 matches
Mail list logo
