Re: Q_PROPERTYs in preferences code

2017-12-21 Thread Sebastian Kügler
Hi Berthold, On Saturday, December 16, 2017 1:26:16 PM CET Berthold Stoeger wrote: > Short question: Are the numerous Q_PROPERTY macros in core/subsurface-qt/ > SettingsObjectWrapper.h needed for the mobile version? If I remove them, the > desktop version compiles and works just fine. > > Somehow

Re: Kirigami question

2017-12-08 Thread Sebastian Kügler
Marco, I'm not that familiar with Kirigami internals, do you know this off the top of your head? -- sebas On woensdag 6 december 2017 13:34:08 CET Dirk Hohndel wrote: > I know that both Sebastian and Marco read our mailing list from time to > time, but I figured sending this directly To: them mi

Re: INSTALL recommends package libqt5declarative5...

2017-02-05 Thread Sebastian Kügler
On zondag 5 februari 2017 15:32:47 CET Cristian Ionescu-Idbohrn wrote: > ... but I can't find anything by that name, neither in debian strech > (next stable) nor sid (unstable) :( Does anyone know what that is? A > fuzzy search brings this up: > > libkdeclarative5 - declarative library for plasm

Re: entering cloud PIN in Subsurface-mobile

2016-06-16 Thread Sebastian Kügler
On maandag 13 juni 2016 22:12:11 CEST Dirk Hohndel wrote: > > - it is not possible to paste the pin, I think this would be a nice > > option. > > Unfortunately it seems that all of the Kirigami components have the problem > that you can't paste text. > > Sebastian - any insights into this limitat

Re: [PLEASE VOTE] so what should we be working on

2016-06-05 Thread Sebastian Kügler
ly earns a sustainable base. In my experience, the kind of soul-searching we should be doing is best done in-person, so if a subsurface real-life meeting is still an option, I'd love to use it for this kind of thing, with an open end. All that said, I'll try to find some time in the near

Re: two questions regarding QML

2016-03-14 Thread Sebastian Kügler
Hi Dirk, On Sunday, March 13, 2016 11:30:15 AM Dirk Hohndel wrote: > I guess you are the most likely people who have a good answer here... > > a) is there a simple, concise, useful introduction to localization of QML > code? The way we do localization in Subsurface is a bit odd because of the > l

Re: red error messages in qml

2016-03-12 Thread Sebastian Kügler
On Saturday, March 12, 2016 09:22:54 Dirk Hohndel wrote: > On Mar 12, 2016, at 7:38 AM, Sebastian Kügler wrote: > > On Friday, March 11, 2016 03:00:26 Tomaz Canabrava wrote: > error messages in red. > > Br. Encapsulate that in a small method? So it can be more easily

Re: last call for the Android release

2016-03-12 Thread Sebastian Kügler
loper and diver ... what Dirk said. :-) -- subsurfbas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: red error messages in qml

2016-03-12 Thread Sebastian Kügler
to errors by translators.) -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Android app -923

2016-03-05 Thread Sebastian Kügler
On Thursday, March 03, 2016 03:22:40 PM Dirk Hohndel wrote: > Sebas, now that we are on Qt 5.6... do you remember what you and I tested > a couple of months ago with getting the correct keyboard geometry from Qt? > I know that worked with 5.6... so maybe you could create a Kirigami patch > to use t

Re: Renaming Plasma Mobile Components and design philosophy to Kirigami

2016-03-01 Thread Sebastian Kügler
On Saturday, February 27, 2016 02:55:42 PM Marco Martin wrote: > http://notmart.org/misc/kirigami You continue to surprise me, Marco. :-) -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mailing list subsurface@subsurface-divelog.org ht

Re: New Bug Reports/Feature Requests

2016-02-25 Thread Sebastian Kügler
On Tuesday, February 23, 2016 03:46:44 PM Linus Torvalds wrote: > So even if there was 80 cuft of air in the cylinder, you won't > get all out of *out* of the cylinder, there will be that 11.1L > (roughly 0.4 cuft) remaining in the bottle. Should that not be the intermediate pressure, i.e. 9-

Re: [PATCH 2/2] Adding about page to Subsurface-mobile

2016-02-11 Thread Sebastian Kügler
On Wednesday, February 10, 2016 07:50:00 PM Miika Turkia wrote: > On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler wrote: > > On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: > >> +import QtQuick.Window 2.2 > >> +import QtQuick.Dialog

Re: [PATCH 2/2] Adding about page to Subsurface-mobile

2016-02-10 Thread Sebastian Kügler
On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: > +import QtQuick.Window 2.2 > +import QtQuick.Dialogs 1.2 Seems unused? > + signal accept What is this used for? Could you attach or link a screenshot to this page? That makes it much easier to review the visual aspects. --

Re: [PATCH 1/2] Support function to print version string

2016-02-10 Thread Sebastian Kügler
On Wednesday, February 10, 2016 05:09:50 PM Miika Turkia wrote: > + return ""; return QString(); -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divel

Re: mobile: not smooth scrolling from dive-detail to dive-detail

2016-02-10 Thread Sebastian Kügler
On Wednesday, February 10, 2016 03:59:52 PM Jan Mulder wrote: > On 10-02-16 15:28, Sebastian Kügler wrote: > > On Wednesday, February 10, 2016 03:24:38 PM Jan Mulder wrote: > >> As has been noticed by a number of people that are active in the android > >> mobile develop

Re: mobile: not smooth scrolling from dive-detail to dive-detail

2016-02-10 Thread Sebastian Kügler
On Wednesday, February 10, 2016 03:24:38 PM Jan Mulder wrote: > As has been noticed by a number of people that are active in the android > mobile development, the scrolling/swiping from dive-detail to > dive-detail is not "smooth". It stops and moves forward at (lets say) > 80% of the width of t

Re: C++ cout within Subsurface

2016-02-09 Thread Sebastian Kügler
On Tuesday, February 09, 2016 04:57:09 PM Willem Ferguson wrote: > What do you do? Use qDebug(). -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin

Re: Now Accepting GSoC 2016 Mentor Organization Applications

2016-02-09 Thread Sebastian Kügler
On Tuesday, February 09, 2016 12:53:42 PM JB2Cool wrote: > On 9 February 2016 at 12:48, Sebastian Kügler wrote: [...] > I'd much rather have something small, stable and high quality than a swiss > army knife that falls apart the moment you look at it. > > There are many areas

Re: Now Accepting GSoC 2016 Mentor Organization Applications

2016-02-09 Thread Sebastian Kügler
On Tuesday, February 09, 2016 12:17:50 PM Henrik Brautaset Aronsen wrote: > On Tue, Feb 9, 2016 at 11:37 AM, Robert Helling wrote: > > A possible project I could mentor in the summer would be a mobile version of > the planner (if nobody vetos it). That would be a separate app from > subsurface-mo

Re: punch list for public beta of Subsurface-mobile for Android

2016-02-05 Thread Sebastian Kügler
ore, we may be lucky. > - keyboard size error: especially in landscape - the content of the page > being edited shifts up too much and there's a big empty area above the > keyboard. > Sebastian, I know that you said you know what causes that. Any chance > you can l

Re: QtCreator problem?

2016-01-26 Thread Sebastian Kügler
On Tuesday, January 26, 2016 04:16:05 PM Willem Ferguson wrote: > I am working with the subsurface project loaded into QtCreator. I > created a new class, the files (.cpp, .h) of which exists in the > directory: desktop-widgets. When I refer to this class from within the > Subsurface C++ code, I

Re: [PATCH] QML UI: If a dive has multiple cylinders show "Multiple" in the details page

2016-01-26 Thread Sebastian Kügler
On Monday, January 25, 2016 09:28:10 PM Joakim Bygdell wrote: > + cylinder = "Multiple"; QStringLiteral("multiple") saves conversion costs. Perhaps even qsTr("Multiple"), since this will show up in the UI, untranslated. (Better already do it for new user-facing strings, eve

Re: [PATCH 1/3] QML-UI: Rearrange the DiveDetails page

2016-01-26 Thread Sebastian Kügler
On Monday, January 25, 2016 06:44:50 PM Joakim Bygdell wrote: > After adding "Cylinder" to the DiveDetails page the objects had to be > rearranged in order to better utilise the space. > To get a cleaner look on smaller screens the left side is left aligned and > the right side is right aligend. I

Re: [PATCH] Return to divelist even from "further away"

2016-01-25 Thread Sebastian Kügler
On Monday, January 25, 2016 06:26:16 AM Dirk Hohndel wrote: > On Mon, Jan 25, 2016 at 01:03:54PM +0000, Sebastian Kügler wrote: > > On Friday, January 22, 2016 10:02:28 PM Miika Turkia wrote: > > > If one browses the application more than one step (e.g. details, gps fix > >

Re: [PATCH] Return to divelist even from "further away"

2016-01-25 Thread Sebastian Kügler
On Friday, January 22, 2016 10:02:28 PM Miika Turkia wrote: > If one browses the application more than one step (e.g. details, gps fix > list and preferences), we need to pop the stack a bit more to get back > to the dive list. This will clear the whole stackView as I saw no harm > in discarding th

Re: Feature request: "Dive list" entry in Subsurface-mobile side-bar menu

2016-01-21 Thread Sebastian Kügler
list, so a quick entry in the side-bar menu would be nice. I think it would be useful. Would you like to try a patch? (It's fairly straightforward to do, so very suitable for someone who'd like to start contributing to the mobile app.) -- sebas Sebastian Kügler|http://v

Re: [PATCH] QML UI: Don't explicitly set width of GridLayout items

2016-01-19 Thread Sebastian Kügler
d to go. (The change I suggested can be submitted separately). Thanks, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/ma

Re: [PATCH] QML UI DiveDetailsView: shift dive number to right of top row

2016-01-19 Thread Sebastian Kügler
. I can't see this being a problem, but I haven't tested any other > locales or devices. Look good to me. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsur

Re: Subsurface-mobile Android app profile scaling

2016-01-18 Thread Sebastian Kügler
On Monday, January 18, 2016 15:12:06 Dirk Hohndel wrote: > > On Jan 18, 2016, at 3:01 PM, Sebastian Kügler wrote: > > > > On Monday, January 18, 2016 22:45:19 John Smith wrote: > >> Actually, just nosticed that the weight value is empty in all my dives. > > &

Re: Subsurface-mobile Android app profile scaling

2016-01-18 Thread Sebastian Kügler
just a small fix. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile Android app profile scaling

2016-01-18 Thread Sebastian Kügler
P) Thanks a lot for being stubborn about this issue, Dirk! -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: preferences and settings for Subsurface-mobile

2016-01-11 Thread Sebastian Kügler
On Monday, January 11, 2016 07:11:35 AM Dirk Hohndel wrote: > > > But what about things like calculated ceiling. Various partial > > > pressures. > > > The tank bar. Should we make those preferences on the mobile device? > > > Should we do the same we do for the units and just carry over the > > >

Re: preferences and settings for Subsurface-mobile

2016-01-11 Thread Sebastian Kügler
On Monday, January 11, 2016 06:30:44 AM Dirk Hohndel wrote: > When testing Subsurface-mobile Jan noticed something rather important that > I of course "kinda sorta" knew, but had forgotten to follow up on. In > Subsurface-mobile you get the default setting for all our numerous > preferences on how

Re: Silly button [was Re: latest Android apk]

2016-01-11 Thread Sebastian Kügler
On Sunday, January 10, 2016 04:55:48 PM Dirk Hohndel wrote: > > On Jan 10, 2016, at 3:33 PM, Sebastian Kügler wrote: > > > > > > On Sunday, January 10, 2016 21:57:40 Henrik Brautaset Aronsen wrote: > >> 9. jan. 2016 21.55 skrev "Dirk Hohndel" : >

Re: Silly button [was Re: latest Android apk]

2016-01-10 Thread Sebastian Kügler
latest apk (.600) Seems there were some model changes. The (overlapping) text in the bottom right of the is now the location, and its duplicated while it was the dive number. Looks like a relatively simple mistake slipped in which caused this. I'll fix that. -- sebas Sebastia

Re: Subsurface-mobile dc downloads

2016-01-06 Thread Sebastian Kügler
On Wednesday, January 06, 2016 07:21:37 AM Dirk Hohndel wrote: > > in Qt: QML and the Qt .ui file approach differ vastly. I hope the > > binding of QStringLists inside the C++ with the QML models holds, so > > that when the underlying stringlists are modified, the display is > > updated at the sam

Re: Yet more progress on Subsurface-mobile

2016-01-06 Thread Sebastian Kügler
On Wednesday, January 06, 2016 07:26:33 AM Dirk Hohndel wrote: > On Wed, Jan 06, 2016 at 07:31:03PM +1100, Rick Walsh wrote: > > > > > > A great set of updates there. Most noticeable improvement I notice is > > accelerating the scrolling. Much snappier. I was curious about imperial > > units, b

Re: latest Android apk

2016-01-05 Thread Sebastian Kügler
much, as to be held back by a broken build, I did put an hour in here and there, but nothing really came out of it, so you didn't hear from me. That said, the work done in the meantime is awesome. I'm particularly happy with the black icons investigation, as that was quite the myst

Re: latest Android apk

2016-01-05 Thread Sebastian Kügler
On Tuesday, January 05, 2016 05:19:56 PM Lubomir I. Ivanov wrote: > cd ./qt-mobile/qml > git log --follow --oneline ./mobilecomponents > > 8e29972 QML-UI: fix black squares on some Android devices > 44fd9bf sync with mobilecomponents f4d5d19fc > 936c9ce Add more icons > b6f5f23 sync with mobilecom

Re: latest Android apk

2016-01-05 Thread Sebastian Kügler
On Monday, January 04, 2016 09:49:40 PM Linus Torvalds wrote: > On Jan 4, 2016 21:40, "Dirk Hohndel" wrote: > > But, if I may say so, I think this is getting better and better. :-) > > The current version looks good, I agree. > > The one thing I find myself always looking for is some way to go t

Re: [PATCH] QML UI: give context drawer and implicit width

2016-01-05 Thread Sebastian Kügler
On Tuesday, January 05, 2016 06:53:10 PM Rick Walsh wrote: > This makes the context drawer wide enough to read what the actions are I can take this (and the followup patch) and merge it upstream, so we don't increase the delta between subsurface and Plasma's mobilecomponents, but I don't have th

Re: latest Android apk

2016-01-05 Thread Sebastian Kügler
On Tuesday, January 05, 2016 08:37:07 AM Henrik Brautaset Aronsen wrote: > On Mon, Jan 4, 2016 at 4:24 PM, Dirk Hohndel wrote: > I think my > preference would be to get rid of the magic button and have triple bar on > the left and triple dot on the right as some other mobile apps do. Tapping > tho

Re: QML learning curve

2016-01-04 Thread Sebastian Kügler
On Sunday, January 03, 2016 11:00:31 AM Dirk Hohndel wrote: > > public slots: // I get compilation error: > >"undefined reference to vtable for MessageClass" Huh?? > How about adding a constructor? Maybe that helps. This is one of those > completely incomprehensible C++ er

Re: latest Windows daily

2015-12-18 Thread Sebastian Kügler
t; Oh, and the version number is screwy. "screwy" isn't easy-to-decode information. Could you clarify or simply show it? -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list s

Re: Never-ending story: Mac and mobile

2015-12-09 Thread Sebastian Kügler
I have no > idea what changed to before. Heisenbug. Could be that the switching back and forth left marble disabled at some point, at which your build proceeds and finishes ... the mobile version doesn't use marble. Just a guess, really. -- sebas Sebastian Kügler|http://vizZzion.

[pull request]: dive details rework

2015-12-07 Thread Sebastian Kügler
esigners, and we'll put the actions in the top toolbar. Saving the new dive data has broken right now in master, and this patch-set unfortunately doesn't change that. Something we have to look into. Cheers, -- sebas Sebastian Kügler|

Re: Subsurface mobile and the GPS service

2015-12-07 Thread Sebastian Kügler
On Saturday, December 05, 2015 06:23:39 AM Dirk Hohndel wrote: > > 1) When I activate Subsurface-mobile I get the screen on the left of the > > attached image. The button at the bottom allows me to drag the screen to > > the right, bringing up the middle screen in the attached image. Notice > > tha

Re: mobile ui todo

2015-12-07 Thread Sebastian Kügler
On Sunday, December 06, 2015 10:03:40 PM Lubomir I. Ivanov wrote: > On 3 December 2015 at 21:04, Sebastian Kügler wrote: > > Hey all, > > > > We received pretty useful feedback during the testing of the latest mobile > > ui changes. > i just tested quickly the mobi

Re: Fwd: Re: mobile ui

2015-12-03 Thread Sebastian Kügler
On Thursday, December 03, 2015 14:50:48 Dirk Hohndel wrote: > On Thu, Dec 03, 2015 at 10:26:24PM +0000, Sebastian Kügler wrote: > > On Thursday, December 03, 2015 14:04:50 Dirk Hohndel wrote: > > > > > I knew my fix was too easy > > > > > > > >

Re: Fwd: Re: mobile ui

2015-12-03 Thread Sebastian Kügler
re painting. > I remember Tomaz telling me to be very very careful what I call from > within paint. Both for performance issues but also for infinite > recursions. Thinking about it, it would probably be easier to resize the profileWidget from that v

Re: Fwd: Re: mobile ui

2015-12-03 Thread Sebastian Kügler
ble on the Android device, run logcat on the host with the device connected: adb logcat -s Subsurface:V Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-dive

Re: fix crash and indentation

2015-12-03 Thread Sebastian Kügler
27;ll look into splitting out the action into their own file in a separate patch. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-di

fix crash and indentation

2015-12-03 Thread Sebastian Kügler
#2 seems good to have in quickly, so I'm submitting the indentation fix with it. - fix a crasher in DiveList::clear() (checking for !count() now) - indentation of actions was messed up -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: Fwd: Re: mobile ui

2015-12-03 Thread Sebastian Kügler
gt; Despite the above, you are doing great work. This may well become the > most frequently used version of Subsurface. Thanks! -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@s

Re: mobile ui todo

2015-12-03 Thread Sebastian Kügler
Hi Dirk, On Thursday, December 03, 2015 11:49:29 Dirk Hohndel wrote: > I have ordered your list below in what I think is a ROUGH priority order > and indicated the things that I plan to work on myself... > > On Thu, Dec 03, 2015 at 07:04:55PM +0000, Sebastian Kügler wrote: > >

Re: Subsurface-mobile use

2015-12-03 Thread Sebastian Kügler
> the rationale behind the behavior. Yes, that's intended behaviour. I'm having our usability people looking into it right now, and they'll probably suggest a few changes to this element. I personally think it works quite well and doesn't get in the way of interestin

mobile ui todo

2015-12-03 Thread Sebastian Kügler
become the current page until that is redone as well) The list may be incomplete, and it's not prioritized yet. Feel free to take on issues (let us know here, first, so we don't duplicate work or end up in a merge conflict). Cheers, -- sebas Sebastian Kügler|http://vizZzion.org

Re: [PATCH] QML-UI: Remove button from dive details

2015-12-03 Thread Sebastian Kügler
t; > diff --git a/qt-mobile/qml/DiveDetails.qml b/qt-mobile/qml/DiveDetails.qml > index bff6453..b335631 100644 +1 -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@

Re: [PATCH 1/3] Remove defaults for Android from cmake

2015-12-02 Thread Sebastian Kügler
From a cursory glance, patches look good to me. On Tuesday, December 01, 2015 08:46:58 PM Anton Lundin wrote: > Some of the flags needed to build for android was set in cmake. There > are many more that needs to be set correctly for things to work, so > having some in cmake and some in the Android

Re: [mobile ui] navigation rework

2015-12-01 Thread Sebastian Kügler
rong there. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface mobile video

2015-11-30 Thread Sebastian Kügler
I've taken some time to record a video of our latest work on subsurface mobile and explain a bit the role of the Plasma components we're using. It may be an interesting watch or read for some, so I'm shamelessly plugging my blog here: http://vizzzion.org/blog/2015/11/plasma-components-on-andro

Re: [mobile ui] navigation rework

2015-11-30 Thread Sebastian Kügler
And since you didn't touch compiled code (except for > > adding the //imports) I didn't see any concern in doing this, anyway - > > this is truly just moving the mobile UI forward. > > > > On Mon, Nov 30, 2015 at 02:35:49AM +, Sebastian Kügler wrote: > >

Re: [mobile ui] navigation rework

2015-11-29 Thread Sebastian Kügler
an easy to hit fat-finger-target. Also, Android has a back button by default everywhere, so we don't need to provide our own. Take it for a ride, I'm sure there are a bunch of glitches that we haven't spotted, feedback is most welcome. Cheers, -- sebas Sebastian Kügler|

Re: [mobile ui] navigation rework

2015-11-29 Thread Sebastian Kügler
On Sunday, November 29, 2015 13:25:10 Dirk Hohndel wrote: > On Sun, Nov 29, 2015 at 05:41:45PM +0000, Sebastian Kügler wrote: > > Marco Martin (a Plasma colleague are currntly sitting at my place and > > hacking on subsurface and the components it's using, with the goal t

Re: [PATCHES]

2015-11-25 Thread Sebastian Kügler
On Tuesday, November 24, 2015 05:49:21 PM Robert Helling wrote: > + QPixmap tempPixmap = pixmap; > + QPainter painter; > + painter.begin(&tempPixmap); > + painter.fillRect(pixmap.rect(), QColor(127, 127, 127, 127)); > + painter.end(); I may be dense today, but this se

Re: Patch update INSTALL file

2015-11-25 Thread Sebastian Kügler
On Tuesday, November 24, 2015 09:08:42 AM Dirk Hohndel wrote: > On Ubuntu it definitely is qtlocation5-dev Same in Debian unstable/sid/stretch. -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mailing list subsurface@subsurface-divelog.

Re: [PATCH 7/7] main.qml: fix crash on native Win32 desktop

2015-11-19 Thread Sebastian Kügler
On Thursday, November 19, 2015 02:46:00 PM Lubomir I. Ivanov wrote: > On 19 November 2015 at 14:21, Sebastian Kügler wrote: > > On Wednesday, November 18, 2015 11:47:00 PM Lubomir I. Ivanov wrote: > > > > I haven't, but it's OK. The difference between Window and &g

Re: [PATCH 7/7] main.qml: fix crash on native Win32 desktop

2015-11-19 Thread Sebastian Kügler
etter platform integration of things like menus. Let's prevent that crasher for now, though. Holler if I introduce it without checkout with you that the crashes aren't still an issue. I'm not 100% sure about the sign-off procedure, but in case you need it, here's my li

Re: [PATCH 1/7] gpslocation.cpp: fix unused variable warning

2015-11-19 Thread Sebastian Kügler
On Wednesday, November 18, 2015 11:46:54 PM Lubomir I. Ivanov wrote: > + (void)changed; Q_UNUSED is more Qt-ish (but I haven't checked if that's in line with surrounding code). -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mai

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-17 Thread Sebastian Kügler
On Tuesday, November 17, 2015 04:43:41 PM Lubomir I. Ivanov wrote: > On 17 November 2015 at 16:35, Lubomir I. Ivanov wrote: > > On 16 November 2015 at 23:47, Sebastian Kügler wrote: > >> On Friday, November 13, 2015 23:59:09 Lubomir I. Ivanov wrote: > > changing Applica

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-17 Thread Sebastian Kügler
[no need to CC: me, I'm on the list, and CC:ing me breaks my threading] On Tuesday, November 17, 2015 06:34:10 AM Miika Turkia wrote: > On Tue, Nov 17, 2015 at 12:47 AM, Sebastian Kügler wrote: > > On Tuesday, November 17, 2015 00:35:49 Lubomir I. Ivanov wrote: > >> >&

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-16 Thread Sebastian Kügler
> sorry. no promises, as i'm entering a complicated project for my > employer soon... > i'd suggest that you give that a push forward in the meantime. No problem, I put it on my list. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org _

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-16 Thread Sebastian Kügler
t theme, so try that. Otherwise, specifying width and height in the top-level item works: it puts the initial window at exactly that size. You can also try using Window (effectively a QQuickWindow) as top-level item, see attached example. Let us know what works for you, then we'll put that i

Re: mobile app vs. companion app

2015-11-16 Thread Sebastian Kügler
On Monday, November 16, 2015 07:08:04 Dirk Hohndel wrote: > > On Nov 16, 2015, at 04:37, Sebastian Kügler wrote: > > > >> On Friday, November 13, 2015 10:08:18 PM Dirk Hohndel wrote: > >> But as far as I can tell all that is missing are a few small things on > &

Re: mobile app vs. companion app

2015-11-16 Thread Sebastian Kügler
On Friday, November 13, 2015 10:08:18 PM Dirk Hohndel wrote: > But as far as I can tell all that is missing are a few small things on the > edges, the core of what the companion app can do is there and appears to > be working in my minimal testing. Obvious question: Do you have a list of the missi

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Sebastian Kügler
hat I have seen them, nothing else will ever do. > > The only question in my mind is whether just one shark per profile is enough, > or if we need more. follow-up dillemma: left or right shark... -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org __

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Sebastian Kügler
delete the delegates as needed. As a bonus, we don't have to copy a whole lot of data between divelist and details view, we just set the detail's listview.currentItem to whatever the user picked in the overview list (and possibly avoid animations). Do I make sense to you? If not, proof-of-co

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-12 Thread Sebastian Kügler
On Wednesday, November 11, 2015 20:45:53 Dirk Hohndel wrote: > On Thu, Nov 12, 2015 at 01:27:54AM +0000, Sebastian Kügler wrote: > > Heya, > > > > Some more work on the mobile version, especially on the divelist and details. > > Great! > > > - bugfix for lab

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-11 Thread Sebastian Kügler
On Thursday, November 12, 2015 01:27:54 Sebastian Kügler wrote: > Some more work on the mobile version, especially on the divelist and > details. I just noticed that a new file CloudStorage.qml slipped in, which isn't used yet. I suggest to leave that in, it will be used shortly, e

[PATCH] mobile: divedetails page etc. improvements

2015-11-11 Thread Sebastian Kügler
anups (#0001, #0003) - further layout and styling improvements (all the other patches) Most visible is probably the rework of the dive profile page, aside various text display fixes. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

[PATCH] fix startpage appearing over dive list

2015-11-07 Thread Sebastian Kügler
Use the view, rather than the model to check if the list is empty. This allows us to use the property notifiers rather than a function call, and hence fixes updating the visibility of the startpage when the listview gets filled (or emptied). Signed-off-by: Sebastian Kügler --- qt-mobile/qml

[PATCH] Flip visibility when opacity is 0

2015-11-07 Thread Sebastian Kügler
This makes sure we don't accept any input from the startpage when interacting with the divelist -- they're really mutually exclusive. Signed-off-by: Sebastian Kügler --- qt-mobile/qml/DiveList.qml | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-mobile/qml/DiveList.qml b/qt-

Re: [PATCH 11/11] android build: remote -u flag from git pull

2015-11-07 Thread Sebastian Kügler
On Saturday, November 07, 2015 23:45:58 Henrik Brautaset Aronsen wrote: > On Fri, Nov 6, 2015 at 10:57 PM, Sebastian Kügler wrote: > > > git pull -u isn't known on my systems (recent Debian and Ubuntu), so > > better not use this flag. > > Which Git version do you

[PATCH]es: mobile ui improvements

2015-11-07 Thread Sebastian Kügler
e dpi and sizing problems are fixed navigation logic is improved, the code organization is a bit more scalable and it starts to look purty. Much more work ahead, but it shows promise. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org From 4d494a7be0f2cd339749bef83c3f79a4392f

[PATCH 10/11] More info in ThemeTest

2015-11-06 Thread Sebastian Kügler
This makes problems with the default font more apparent Signed-off-by: Sebastian Kügler --- qt-mobile/Label.qml | 3 --- qt-mobile/ThemeTest.qml | 16 +++- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/qt-mobile/Label.qml b/qt-mobile/Label.qml index f340d0b

[PATCH 11/11] android build: remote -u flag from git pull

2015-11-06 Thread Sebastian Kügler
git pull -u isn't known on my systems (recent Debian and Ubuntu), so better not use this flag. Signed-off-by: Sebastian Kügler --- packaging/android/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/android/build.sh b/packaging/android/build.sh index 1c

[PATCH 09/11] Improve theme information panel

2015-11-06 Thread Sebastian Kügler
mpute ourselves. Signed-off-by: Sebastian Kügler --- qt-mobile/ThemeTest.qml | 53 - 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/qt-mobile/ThemeTest.qml b/qt-mobile/ThemeTest.qml index 55c15ed..c848f1a 100644 --- a/qt-mobile/ThemeTest.qml

[PATCH 08/11] Include label in the binary

2015-11-06 Thread Sebastian Kügler
Signed-off-by: Sebastian Kügler --- qt-mobile/mobile-resources.qrc | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-mobile/mobile-resources.qrc b/qt-mobile/mobile-resources.qrc index c09dca5..77ab761 100644 --- a/qt-mobile/mobile-resources.qrc +++ b/qt-mobile/mobile-resources.qrc @@ -9,6

[PATCH 06/11] Theme tweaks

2015-11-06 Thread Sebastian Kügler
- gridUnits is dynamic again, using FontMetrics now - Add a page to display some sizing-relevant details, so we can debug dpi problems a bit better on Android Signed-off-by: Sebastian Kügler --- qt-mobile/ThemeTest.qml| 15 +++ qt-mobile/main.qml | 12

[PATCH 07/11] new Label item

2015-11-06 Thread Sebastian Kügler
Add a Label that we can use for styled text until we figured out how to set the default font size. Signed-off-by: Sebastian Kügler --- qt-mobile/Label.qml | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 qt-mobile/Label.qml diff --git a/qt-mobile/Label.qml b/qt-mobile

[PATCH 05/11] Replace units.spacing with units.smallSpacing

2015-11-06 Thread Sebastian Kügler
In line with the new Units API. Signed-off-by: Sebastian Kügler --- qt-mobile/DiveList.qml | 26 +- qt-mobile/TopBar.qml | 10 +- qt-mobile/main.qml | 9 - 3 files changed, 22 insertions(+), 23 deletions(-) diff --git a/qt-mobile/DiveList.qml b/qt

[PATCH 03/11] Add qmldir file

2015-11-06 Thread Sebastian Kügler
This will be needed at some point, so better put it in the right place already, so we don't forget enabling the singleton usage once we've fleshed out how that could work exactly. Signed-off-by: Sebastian Kügler --- qt-mobile/theme/qmldir | 2 ++ 1 file changed, 2 insertions(+) c

[PATCH 04/11] Add some compatibility extensions to theme and unit

2015-11-06 Thread Sebastian Kügler
- This allows us to use these new things without changing much in our own code, things now work again. Signed-off-by: Sebastian Kügler --- qt-mobile/main.qml| 4 qt-mobile/theme/Theme.qml | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/qt-mobile/main.qml b/qt

[PATCH 02/11] some changes from the upstream wip-branch

2015-11-06 Thread Sebastian Kügler
7;m not sure we can depend on Qt 5.4 and QtQuick 2.5. Signed-off-by: Sebastian Kügler --- qt-mobile/mobile-resources.qrc | 1 + qt-mobile/theme/Theme.qml | 4 ++-- qt-mobile/theme/Units.qml | 18 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/q

[PATCH 01/11] more complete implementation of Plasma's Units

2015-11-06 Thread Sebastian Kügler
inimal new dependencies (for now: none). Signed-off-by: Sebastian Kügler --- qt-mobile/theme/Theme.qml | 68 - qt-mobile/theme/Units.qml | 109 ++ 2 files changed, 158 insertions(+), 19 deletions(-) diff --git a/qt-mo

[PATCH] use default font size on Android

2015-11-06 Thread Sebastian Kügler
From: Sebastian Kügler This solves the root problem of most of the dpi-depdent sizing in the mobile Android version. When setting a custom font size, we circumvent Android's defaults, which means that we end up setting the font size further down the road to get readable fonts. I suppose

Re: mobile ui considerations

2015-10-21 Thread Sebastian Kügler
e, what's more and what's not so important to you, etc.? -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-b

Re: FW: mobile ui considerations

2015-10-20 Thread Sebastian Kügler
On Tuesday, October 20, 2015 04:15:01 PM Davide DB wrote: > On Tue, Oct 20, 2015 at 3:54 PM, Sebastian Kügler wrote: > > What do you mean by "default development OS"? > > > > > > That said, I'd like to run the app on Android. I'm personally not

Re: FW: mobile ui considerations

2015-10-20 Thread Sebastian Kügler
On Tuesday, October 20, 2015 09:32:06 AM Davide DB wrote: > On Tue, Oct 20, 2015 at 9:17 AM, Dirk Hohndel wrote: > > Sebastian is a rather experienced Qt/QML developer so I'm sure he will get > > us to something ready for a beta release fairly soon. I certainly hope to > > be able to use Subsurfac

  1   2   >