The patch looks fine to me. I'm not sure the all caps ATTENTION is
necessary but if you want to keep it s/ATENTION/ATTENTION. And let's add
the comment about gtk2 we discussed before. Feel free to push with these
changes.
On 30 October 2013 15:27, Gonzalo Odiard gonz...@laptop.org wrote:
Today
Was already pushed by manuq.
Gonzalo
On Thu, Oct 31, 2013 at 8:04 PM, Daniel Narvaez dwnarv...@gmail.com wrote:
The patch looks fine to me. I'm not sure the all caps ATTENTION is necessary
but if you want to keep it s/ATENTION/ATTENTION. And let's add the comment
about gtk2 we discussed
2013/10/31 Daniel Narvaez dwnarv...@gmail.com:
The patch looks fine to me. I'm not sure the all caps ATTENTION is necessary
but if you want to keep it s/ATENTION/ATTENTION. And let's add the comment
about gtk2 we discussed before. Feel free to push with these changes.
Yes, I pushed it
Today I received this mail from Esteban Arias in Uruguay:
Cuando sugar cambió el toolbar, o cuando se pasó a gtk3, se mantuvo
compatibilidad hacia atrás.
Pero al pasar a sugar 0.98 varias de las actividades dejaron de funcionar
por tener *service_name* en lugar de* bundle_id *enel
This breaks gtk2 activities right? I think that should be considered a bug
and thus we should take the patch (I have not reviewed it). I would add a
comment though so that when we will finally drop gtk2 support we will
remove this too.
On Wednesday, 30 October 2013, Gonzalo Odiard wrote:
Today
Yes, all the affected activities are gtk2 activities.
We removed the code to support service_name in gtk3,
and did not affected the old activities until we ported sugar to gtk3.
About the comment you suggest, do we have any convention for this case?
Gonzalo
On Wed, Oct 30, 2013 at 12:44 PM,
For the comment I mean just something like This is necessary only to keep
gtk2 activities working. It's not obvious unless you know the whole
history of those properties.
On Wednesday, 30 October 2013, Gonzalo Odiard wrote:
Yes, all the affected activities are gtk2 activities.
We removed the
Hi,
2013/10/30 Daniel Narvaez dwnarv...@gmail.com:
This breaks gtk2 activities right? I think that should be considered a bug
and thus we should take the patch (I have not reviewed it). I would add a
comment though so that when we will finally drop gtk2 support we will remove
this too.
First
On Wed, Oct 30, 2013 at 1:51 PM, Manuel Quiñones ma...@laptop.org wrote:
Hi,
2013/10/30 Daniel Narvaez dwnarv...@gmail.com:
This breaks gtk2 activities right? I think that should be considered a
bug
and thus we should take the patch (I have not reviewed it). I would add a
comment though
2013/10/30 Gonzalo Odiard gonz...@laptop.org:
On Wed, Oct 30, 2013 at 1:51 PM, Manuel Quiñones ma...@laptop.org wrote:
Hi,
2013/10/30 Daniel Narvaez dwnarv...@gmail.com:
This breaks gtk2 activities right? I think that should be considered a
bug
and thus we should take the patch (I
Oh, good Gonzalo, this is the bug to solve then. Your patch is in the
correct direction, but allows GTK3 activities to use service_name,
which I don't think is correct. The fix should allow only GTK2
activities to use service_name, and log a deprecation warning message,
as you did.
I
: [Sugar-devel] service_name and bundle_id... again
Oh, good Gonzalo, this is the bug to solve then. Your patch is in the
correct direction, but allows GTK3 activities to use service_name,
which I don't think is correct. The fix should allow only GTK2
activities to use service_name, and log
: Wed, 30 Oct 2013 15:41:56 -0200
From: gonz...@laptop.org
To: ma...@laptop.org
CC: dwnarv...@gmail.com; sugar-devel@lists.sugarlabs.org
Subject: Re: [Sugar-devel] service_name and bundle_id... again
Oh, good Gonzalo, this is the bug to solve then. Your patch is in the
correct direction
But anyway we have the problem of all the activities not available in aslo.
Wich activities are not in aslo??
Date: Wed, 30 Oct 2013 16:02:25 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz...@laptop.org
To: alan...@hotmail.com
CC: ma...@laptop.org; dwnarv
??
--
Date: Wed, 30 Oct 2013 16:02:25 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz...@laptop.org
To: alan...@hotmail.com
CC: ma...@laptop.org; dwnarv...@gmail.com; sugar-devel@lists.sugarlabs.org
Gonzalo: you have the list
: gonz...@laptop.org
To: ma...@laptop.org
CC: dwnarv...@gmail.com; sugar-devel@lists.sugarlabs.org
Subject: Re: [Sugar-devel] service_name and bundle_id... again
Oh, good Gonzalo, this is the bug to solve then. Your patch is in the
correct direction, but allows GTK3 activities to use
That is Ceibal problem.. not our problem..We mantain more than 700 activities
and all works.. if Ceibal want, their can fix very easy this problem(only
change 1 line in the activity.info !!! )
Date: Wed, 30 Oct 2013 16:12:31 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
activities and all works.. if Ceibal want, their
can fix very easy this problem
(only change 1 line in the activity.info !!! )
--
Date: Wed, 30 Oct 2013 16:12:31 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz...@laptop.org
To: alan
that are uploaded on SugarLabs site (aslo).
From: ebor...@plan.ceibal.edu.uy
Date: Wed, 30 Oct 2013 16:20:43 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
To: alan...@hotmail.com
CC: gonz...@laptop.org; ma...@laptop.org; dwnarv...@gmail.com;
sugar-devel@lists.sugarlabs.org
to make the patchs for the activities that have that problem..
Date: Wed, 30 Oct 2013 16:24:15 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz...@laptop.org
To: alan...@hotmail.com
CC: ma...@laptop.org; dwnarv...@gmail.com; sugar-devel@lists.sugarlabs.org
Alan,We don't
activities: all that are uploaded on SugarLabs site (aslo).
--
From: ebor...@plan.ceibal.edu.uy
Date: Wed, 30 Oct 2013 16:20:43 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
To: alan...@hotmail.com
CC: gonz...@laptop.org; ma...@laptop.org; dwnarv
!!! )
--
Date: Wed, 30 Oct 2013 16:12:31 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz...@laptop.org
To: alan...@hotmail.com
CC: ma...@laptop.org; dwnarv...@gmail.com; sugar-devel@lists.sugarlabs.org
All the Cazaproblemas, all the things done by Ceibal (like
alan...@hotmail.com wrote:
But anyway we have the problem of all the activities not available in
aslo.
Wich activities are not in aslo??
--
Date: Wed, 30 Oct 2013 16:02:25 -0200
Subject: Re: [Sugar-devel] service_name and bundle_id... again
From: gonz
On Wed, Oct 30, 2013 at 12:27:57PM -0200, Gonzalo Odiard wrote:
What you think about include it in Sugar?
Yes, include it.
It has no effect unless it is necessary. (Small functional footprint).
It fixes an unnecessary incompatibility.
I have seen no significant evidence for excluding the
:
Message: 3
Date: Thu, 31 Oct 2013 08:03:58 +1100
From: James Cameronqu...@laptop.org
To:sugar-devel@lists.sugarlabs.org
Subject: Re: [Sugar-devel] service_name and bundle_id... again
Message-ID:20131030210358.gd20...@us.netrek.org
Content-Type: text/plain; charset=iso-8859-1
On Wed, Oct 30, 2013
To:sugar-devel@lists.sugarlabs.org
Subject: Re: [Sugar-devel] service_name and bundle_id... again
Message-ID:20131030210358.gd20...@us.netrek.org
Content-Type: text/plain; charset=iso-8859-1
On Wed, Oct 30, 2013 at 12:27:57PM -0200, Gonzalo Odiard wrote:
What you think about include it ?in Sugar
2013/10/30 James Cameron qu...@laptop.org:
Yes, it could, but tracking down every copy of every activity is
impractical for some deployments. Activities are shared around, on
school servers, by e-mail, by USB drive. Adding a needless
incompatibility breaks all this. May as well not have
27 matches
Mail list logo
