Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Pavel Machek
Hi! > > > > Why do we switch to KD_GRAPHIC just before freeze and KD_TEXT just > > > > after? > > > > Shouldn't we KDGETMODE and restore that? > > > > > > prepare_console() is supposed to leave is in KD_TEXT. However it's > > > probably > > > a good idea to use KDGETMODE anyway. > > > > I did

Re: [Suspend-devel] [PATCH] Separate s2disk and s2both

2006-07-07 Thread Pavel Machek
Hi! > As stated in the subject. :-) > > This will make s2disk runnable on all architectures on which the in-kernel > swsusp > is supported. Looks good to me. Pavel -- (english) http://www.livejournal.com/~pavelmachek (ces

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Tim Dijkstra
On Fri, 7 Jul 2006 23:23:07 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Friday 07 July 2006 21:13, Rafael J. Wysocki wrote: > > On Friday 07 July 2006 15:02, Tim Dijkstra wrote: > > > On Fri, 7 Jul 2006 14:44:19 +0200 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > >

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Rafael J. Wysocki
On Friday 07 July 2006 21:13, Rafael J. Wysocki wrote: > On Friday 07 July 2006 15:02, Tim Dijkstra wrote: > > On Fri, 7 Jul 2006 14:44:19 +0200 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > On Friday 07 July 2006 14:30, Tim Dijkstra wrote: > > > > On Fri, 7 Jul 2006 13:25:20 +0200

Re: [Suspend-devel] Userspace splash?

2006-07-07 Thread Rafael J. Wysocki
On Friday 07 July 2006 22:46, Holger Macht wrote: > On Fri 07. Jul - 13:04:15, Rafael J. Wysocki wrote: ]--snip--[ > > splash_prepare() here sets up the splash system and makes sure it _won't_ > > draw > > anything while the console is being prepared. > > > > IOW, we should call splash->to_silent

Re: [Suspend-devel] Userspace splash?

2006-07-07 Thread Holger Macht
On Fri 07. Jul - 13:04:15, Rafael J. Wysocki wrote: > Hi, > > On Friday 07 July 2006 10:29, Tim Dijkstra wrote: [...] > > #define switch_vt_mode(fd, vt, ioc1, ioc2) ioctl(fd, KDSKBMODE, ioc1); > > \ > > ioctl(fd, VT_ACTIVATE, vt); > > \ > >

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Rafael J. Wysocki
On Friday 07 July 2006 15:02, Tim Dijkstra wrote: > On Fri, 7 Jul 2006 14:44:19 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Friday 07 July 2006 14:30, Tim Dijkstra wrote: > > > On Fri, 7 Jul 2006 13:25:20 +0200 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Tim Dijkstra
On Fri, 7 Jul 2006 14:44:19 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Friday 07 July 2006 14:30, Tim Dijkstra wrote: > > On Fri, 7 Jul 2006 13:25:20 +0200 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > > > Apparently we have used wrond console ioctls aro

[Suspend-devel] [PATCH] Separate s2disk and s2both

2006-07-07 Thread Rafael J. Wysocki
Hi, As stated in the subject. :-) This will make s2disk runnable on all architectures on which the in-kernel swsusp is supported. Rafael -- Makefile | 15 ++- suspend.c | 29 + 2 files changed, 23 insertions(+), 21 deletions(-) Index: suspend/sus

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Rafael J. Wysocki
On Friday 07 July 2006 14:30, Tim Dijkstra wrote: > On Fri, 7 Jul 2006 13:25:20 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > Apparently we have used wrond console ioctls around freeze() in > > suspend_system() and in a wrong order. The appended patch fixes > > this. >

Re: [Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Tim Dijkstra
On Fri, 7 Jul 2006 13:25:20 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > Hi, > > Apparently we have used wrond console ioctls around freeze() in > suspend_system() and in a wrong order. The appended patch fixes > this. > > Comments welcome. Just some questions. You told me this was a

[Suspend-devel] s2ram works on Latitude D820 (fwd)

2006-07-07 Thread Pavel Machek
I guess this gets best solved on the mailinglist. Usually Stefan adds s2ram whitelist entries. Pavel - Forwarded message from Geoff Kuenning <[EMAIL PROTECTED]> - X-Original-To: [EMAIL PROTECTED] X-Sieve: CMU Sieve 2.2 To: [EMAIL PR

[Suspend-devel] [PATCH] Fix console ioctls in suspend.c:suspend_system()

2006-07-07 Thread Rafael J. Wysocki
Hi, Apparently we have used wrond console ioctls around freeze() in suspend_system() and in a wrong order. The appended patch fixes this. Comments welcome. Rafael -- suspend.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) Index: suspend/suspend.c =

Re: [Suspend-devel] Userspace splash?

2006-07-07 Thread Rafael J. Wysocki
Hi, On Friday 07 July 2006 10:29, Tim Dijkstra wrote: > I'm trying to integrate another splash system into suspend. Great. :-) > It's a userspace splash program (splashy) so it should be easier for people > to use (no kernel patches), but 'm not really sure if it's going to work at > all. >

[Suspend-devel] Userspace splash?

2006-07-07 Thread Tim Dijkstra
Hi, I'm trying to integrate another splash system into suspend. It's a userspace splash program (splashy) so it should be easier for people to use (no kernel patches), but 'm not really sure if it's going to work at all. Being a userspace program, is it going to be frozen? I guess it will fro