Re: Input needed: JDK-8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

Alexandr, that sounds right. It took me a while to figure out the exact circumstances to trigger this memory leak. In my application where I found this bug, I have a progress bar which is repeatedly switched from between visible and invisible, and between determinate and indeterminate. I could

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.03/ Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 14 July 2016 16:58 To: Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy Subject: Re: [9]

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Hello Sergey, It works fine on linux. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 20 July 2016 01:13 To: Rajeev Chamyal; Semyon Sadetsky; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Review Request JDK-8159168 [hidpi] Window.setShape()

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Hi, Rajeev. Can you please clarify how it works(if it works) on Linux/Solaris? On 11.07.16 12:08, Rajeev Chamyal wrote: Hello Semyon, Please review the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8159168/webrev.04/ Regards, Rajeev Chamyal *From:*Semyon

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Sergey, thanks a lot for looking at this! Best regards, Goetz. > -Original Message- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Tuesday, July 19, 2016 9:17 PM > To: Lindenmaier, Goetz ; awt- > d...@openjdk.java.net;

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Look fine to me. On 07.07.16 18:01, Lindenmaier, Goetz wrote: Hi, This change is ‘L’ because there are changes to a lot of files, but the changes are all similar, so it’s rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

So rename Bug8161483 to AccessibleActionOnAccessibleJListChild? Do we need input from an SQE lead for guidance for this bug and all future bugs? Pete On 7/19/16 2:02 PM, Phil Race wrote: > A meaningful name with some relevance to what the test tests ? > > -phil. > > On 07/19/2016 12:03 PM, Pete

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

A meaningful name with some relevance to what the test tests ? -phil. On 07/19/2016 12:03 PM, Pete Brunet wrote: On 7/19/16 1:52 PM, Phil Race wrote: The fix is fine but as I've said elsewhere I really don't like BugXX as test names. Hi Phil, I haven't seen any of your prior comments

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

On 7/19/16 1:52 PM, Phil Race wrote: > The fix is fine but as I've said elsewhere I really don't like > BugXX as test names. Hi Phil, I haven't seen any of your prior comments about this matter. I haven't seen any other style so just assumed that is/was the standard. Is there an

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

The fix is fine but as I've said elsewhere I really don't like BugXX as test names. -phil. On 07/19/2016 11:43 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/19/2016 8:50 PM, Pete Brunet wrote: Look at .02 instead. I had an extraneous println left in

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

The fix looks good to me. Thanks, Alexandr. On 7/19/2016 8:50 PM, Pete Brunet wrote: Look at .02 instead. I had an extraneous println left in .01. http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.02/ On 7/19/16 11:48 AM, Pete Brunet wrote: I added a regression test:

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

Look at .02 instead. I had an extraneous println left in .01. http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.02/ On 7/19/16 11:48 AM, Pete Brunet wrote: > I added a regression test: > http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.01/ > > Could someone please review that? > >

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

I added a regression test: http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.01/ Could someone please review that? I also need one more +1 on the code change. TiA, Pete On 7/19/16 3:17 AM, Alexandr Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/19/2016

Re: Input needed: JDK-8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

On 7/19/2016 4:33 PM, Robin Stevens wrote: Hello Alexandr, very valid remark. Running that same test program on Linux with the metal look and feel reveals no memory leak. I have no access to a Windows machine, so I couldn't get the Windows specific look and feel. The other ProgressBarUI

Re: [9] Review request for 8160246: Regression: 4410243 reproducible with GTK LaF

The fix looks good to me. Thanks, Alexandr. On 7/19/2016 4:56 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160246 webrev: http://cr.openjdk.java.net/~ssadetsky/8160246/webrev.00/ When the scrolled text component width is set

[9] Review request for 8160246: Regression: 4410243 reproducible with GTK LaF

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160246 webrev: http://cr.openjdk.java.net/~ssadetsky/8160246/webrev.00/ When the scrolled text component width is set to zero the text rootView is initialized and its preferred spans becomes unconstrained. But

Re: Input needed: JDK-8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

Hello Alexandr, very valid remark. Running that same test program on Linux with the metal look and feel reveals no memory leak. I have no access to a Windows machine, so I couldn't get the Windows specific look and feel. The other ProgressBarUI implementations seem to extend from

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 19.07.2016 14:20, Alexandr Scherbatiy wrote: The fix prints the warning method in case of wrong row sorter usage. How often this can happen? Could the large number of the messages overflow a user output? In the FilePane this happened only once after the initial file list loading.

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

The fix prints the warning method in case of wrong row sorter usage. How often this can happen? Could the large number of the messages overflow a user output? Thanks, Alexandr. On 7/19/2016 12:30 PM, Semyon Sadetsky wrote: On 19.07.2016 12:18, Alexandr Scherbatiy wrote: On 7/18/2016

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 19.07.2016 12:18, Alexandr Scherbatiy wrote: On 7/18/2016 11:46 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160087 webrev: http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.00/ A warning is added to avoid issues in

Input needed: JDK-8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

Hello, I wanted to discuss my approach for issue JDK-8161664 ( https://bugs.openjdk.java.net/browse/JDK-8161664) before I started working on this issue. In certain scenarios (see the JIRA issue for an example), the Timer in the Animator inner class of the AquaProgressBarUI class remains running,

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 7/18/2016 11:46 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160087 webrev: http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.00/ A warning is added to avoid issues in user code to throw exceptions which were masked

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

The fix looks good to me. Thanks, Alexandr. On 7/19/2016 5:10 AM, Pete Brunet wrote: Please review the following: Bug: https://bugs.openjdk.java.net/browse/JDK-8161483 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.00/ This is a followon to the patch for JDK-8145207 [macosx]

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

The fix looks good to me. Thanks, Alexandr. On 7/19/2016 9:45 AM, Avik Niyogi wrote: Hi All, Kindly review the fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8161470* *Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 19 July 2016 12:12 To: Alexandr Scherbatiy Cc: Rajeev Chamyal; Semyon Sadetsky; Yuri Nesterenko; swing-dev@openjdk.java.net Subject: Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java

8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8161470 Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ Issue: This test

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi All, Another gentle reminder. Please review the changes made. > On 15-Jul-2016, at 2:50 pm, Avik Niyogi wrote: > > A gentle reminder, please review the changes > >> On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy >>