Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Jonathan Gibbons
On Wed, 7 Apr 2021 20:34:22 GMT, Alexey Ivanov wrote: >>> I dont see any update in JDK-8264217. Is this then considered to be a >>> javadoc bug? >> >> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be >> fixed and spec will be returned for the current method. If it

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec

2021-04-01 Thread Jonathan Gibbons
> On 4/1/21 5:43 AM, Kevin Rushforth wrote: >>> >>> The |javadoc| tool (or the standard doclet) used to automatically copy >>> the description from the superclass, and it seems that it no longer >>> does. Perhaps @jonathan-gibbons >>> <h

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec

2021-04-01 Thread Jonathan Gibbons
The |javadoc| tool (or the standard doclet) used to automatically copy > the description from the superclass, and it seems that it no longer > does. Perhaps @jonathan-gibbons > <https://urldefense.com/v3/__https://github.com/jonathan-gibbons__;!!GqivPVa7Brio!Nt46yROIsMrLvPBMvzgGTeSnh

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Jonathan Gibbons
On Tue, 26 Jan 2021 18:33:48 GMT, Alexey Ivanov wrote: >>> Probably we can import the CSS used by the javadoc itself? >> >> We do. For example, [AWT Modality in JDK >> 15](https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/java/awt/doc-files/Modality.html) >> has borders because

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-10 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-21 Thread Jonathan Gibbons
"Invisible" captions need to be discussed for our documentation in general. Although is optional for HTML 5, the accessibility guidelines that we follow require that we use it. We need to work to provide useful (and visible) captions on tables. -- Jon On 06/21/2019 01:54 PM, Alexey Ivanov

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-21 Thread Jonathan Gibbons
Sounds good; note you should cc: build-dev@ojn for changes to build files. -- Jon On 3/21/19 3:23 AM, Prasanta Sadhukhan wrote: FYI...it does build fine with this build change. Regards Prasanta On 19-Mar-19 10:58 PM, Jonathan Gibbons wrote: Prasanta, Note that if you believe you have fixed

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-19 Thread Jonathan Gibbons
Prasanta, Note that if you believe you have fixed all the heading issues in the java.desktop module, you can re-enable the doclint checks for the module by removing "-accessibility" from the java.desktop line in make/CompileJavaModules.gmk

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-10 Thread Jonathan Gibbons
://cr.openjdk.java.net/~psadhukhan/8220250/webrev.2/ Any more comments? Regards Prasanta On 09-Mar-19 2:24 AM, Jonathan Gibbons wrote: Prasanta, You should double check this file: http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.1/src/java.desktop/share/classes/javax/print/attribute/package

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-08 Thread Jonathan Gibbons
Hi Prasanta, You mentioned the tool I was using to find the issues with headings... It's a bit of a hack -- it's an annotation processor that can be run by javac -- but while it is reasonably good at _detecting, it is not good at checking that you have fixed them _correctly_.  This is because

FYI: new javadoc tag to document system properties

2018-11-14 Thread Jonathan Gibbons
This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (JDK-5076751). Currently, system properties are just documented using ad-hoc narrative text, which is fine if you know where to look for any given property. JDK 12 introduces a new

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-17 Thread Jonathan Gibbons
On 05/17/2017 11:52 AM, Jonathan Gibbons wrote: Phil, The bottom line is that in the JDK docs, tables should not have a summary attribute and should have a caption. This comes down to accessibility requirements, where we are slowly raising the bar on our docs, to be in accordance with Oracle

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-17 Thread Jonathan Gibbons
to be visible when we were fine without. But being there and invisible may be pointless unless screen readers look for it even if invisible. But if its not doing any harm I guess we can leave it as proposed I still need to look at the rest of the changes. -phil. On 05/12/2017 05:11 PM, Jo

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
Sergey, FWIW, the invisible caption should be regarded as a temporary solution, until content authors can review/update the text of the caption and make it visible. The general guideline in this conversion work has been to avoid changing the visible text of the specification, and captions

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
On 05/12/2017 05:03 PM, Philip Race wrote: On 5/12/17, 4:58 PM, Jonathan Gibbons wrote: Phil, 1. javadoc now provides support for 3 named styles in the default stylesheet: borderless: no borders plain: simple 1px borders around tables and cells striped: reduced

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

2017-05-12 Thread Jonathan Gibbons
Phil, 1. javadoc now provides support for 3 named styles in the default stylesheet: borderless: no borders plain: simple 1px borders around tables and cells striped: reduced borders; rows have alternating white and light grey backgrounds 2. summary attributes are

Re: [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-09 Thread Jonathan Gibbons
Sergey, This is not a comment on the content of the review; it is a minor comment on your interpretation of . is a block-level tag that is implicitly terminated by any of many block-level tags. For the full list, see the W3C definition of the p element in HTML 5:

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-08 Thread Jonathan Gibbons
There is no issue here and the tests that used to work with jtreg b05 didn't do what you thought they did. Just look at the .jtr file and see what jtreg actually did before. First, you need to realize that @build is a shorthand for @run build.The section on shorthands is in the very next