On Wed, 27 Jan 2021 11:40:10 GMT, Matthias Perktold
wrote:
> This PR supersedes #2223.
> The original PR was created from master, whereas this PR is created from a
> fresh branch.
>
> Below is a copy of the original description, but as @mrserb correctly
> [pointed
> ou
On Thu, 4 Feb 2021 22:01:18 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix JDK-8260687: don't use font inherit for W3C_LENGTH_UNIT
>
> Changes reques
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with two
additional commits since the last revision:
- Remove "@key headful" from
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with one
additional commit since the last revision:
Fix JDK-8260687: don't use font inherit f
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in
On Tue, 2 Feb 2021 21:01:09 GMT, Kevin Rushforth wrote:
>
>
> Merging, rather than rebasing, is usually preferred as it doesn't involve
> force pushing and makes incremental reviews easier. The answer is the same,
> though: no, it won't cause problems. The bot comment was that you used
> "ma
On Tue, 2 Feb 2021 21:35:00 GMT, Alexey Ivanov wrote:
> I think we should hard-code 96. Does JDK treat 93/94/95 differently? Does it
> change font size in any other place but CSS with W3C_LENGTH_UNITS?
But isn't that precesily the only situation in which the old length mappings
were correct al
On Mon, 25 Jan 2021 16:22:33 GMT, Matthias Perktold
wrote:
> @prsadhuk asked me to take over his pull request #1628, since I filed the bug
> an suggested this fix.
>
> I thought the current behavior would be buggy, but actually the units are
> quite precise. I checked the si
On Tue, 2 Feb 2021 12:29:00 GMT, Prasanta Sadhukhan
wrote:
>>>
>>>
>>> > It seems for screen with low resolution, this change might cause some
>>> > failure as can be seen in the testcase attached in JBS Test.java.
>>>
>>> I'm afraid we can't make 72pt be exactly 96px because of the nature o
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with three
additional commits since the last revision:
- Remove unnecessary import
- Remove unn
On Mon, 1 Feb 2021 18:15:13 GMT, Alexey Ivanov wrote:
> It is likely because sun.java2d.uiScale gets applied to both frames. If the
> font size is the same, 2d surface gets scaled up to the same level, which
> results in the same size of the frames.
>
> Yet the calculations of the conversion r
On Sat, 30 Jan 2021 16:22:17 GMT, Alexey Ivanov wrote:
>>> The test passes for me with the fresh build of JDK, even without the fix
>>> applied.
>>> Indeed, I get the same frame dimensions in both cases: 150×42.
>>>
>>> However, the test fails when run with JDK 11.0.10 or JDK 15, the dimension
On Fri, 29 Jan 2021 14:16:46 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2870:
>>
>>> 2868: w3cLengthMapping.put("cm", 37.7952f); //96px/2.54
>>> 2869: w3cLengthMapping.put("pc", 16f); //1/6 of 1in
>>> 2870:
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with one
additional commit since the last revision:
Link to CSS 2.2 spec from length mapping comme
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with three
additional commits since the last revision:
- Moved HtmlFontSizeTest into ./CSS/8231
On Fri, 29 Jan 2021 18:14:59 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Move StyleSheet rule into body tag
>> - Measure preferredSize of htmlPane ins
nged the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with this PR as well.
>
Matthias Perktold has updated the pull request incrementally with three
additional commits since the last revision:
- Move StyleSheet rule into body tag
- Measur
This PR supersedes #2223.
The original PR was created from master, whereas this PR is created from a
fresh branch.
-
Commit messages:
- Make fields volatile since changed from other thread, and put them on
separate lines
- Corrected copyright year
- Space after comma in argument
gt;> change was made because too much existing content relies on the assumption
>> of 96dpi, and breaking that assumption breaks the content.)
>
> So the spec changed the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with t
gt;> change was made because too much existing content relies on the assumption
>> of 96dpi, and breaking that assumption breaks the content.)
>
> So the spec changed the behavior to better support high-DPI devices with
> existing content, and that is exactly my intention with th
On Tue, 26 Jan 2021 16:41:52 GMT, Alexey Ivanov wrote:
> I see you opened the PR from master branch in your personal fork rather than
> a new branch.
>
> Yes, I think you should go on as suggested: create a new PR from a new branch.
OK, will do. If you don't mind, I have a couple of noob quest
On Tue, 26 Jan 2021 14:36:09 GMT, Alexey Ivanov wrote:
>>> This is what I mean, the quoted text of the CSS spec is the same for both
>>> versions.
>>
>> Oh right I misread that, I really thought it changed, but it didn't.
>> In that case I can also leave the link as it was, should I revert that
On Tue, 26 Jan 2021 01:34:42 GMT, Sergey Bylokhov wrote:
> This is what I mean, the quoted text of the CSS spec is the same for both
> versions.
Oh right I misread that, I really thought it changed, but it didn't.
In that case I can also leave the link as it was, should I revert that change?
-
@prsadhuk asked me to take over his pull request #1628, since I filed the bug
an suggested this fix.
I thought the current behavior would be buggy, but actually the units are quite
precise. I checked the size of a text in font-size of 1 in, and it really was
approximately 1 inch. The problem is
On Wed, 9 Dec 2020 03:34:14 GMT, Sergey Bylokhov wrote:
>> Issue is when using a JEditorPane to render HTML views with W3C_UNIT_LENGTHS
>> enabled, font-sizes set using CSS are much larger than the same font size
>> outside the HTML.
>> It's because CSS LengthUnit uses screen resolution to calc
does not really represent an error, so we should
not display a message.
Instead, I propose to restore the interrupt status.
Best regards,
Matthias Perktold
26 matches
Mail list logo
