and
BasicScrollBarUI::scrollByUnit method is again getting called recursively,
Because of which the scroll bar pointer keeps on moving till the end of
scrollbar.
With this new implementation these issue are not seen.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25
Hello Sergey,
Thanks for the review. I have updated the code.
http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25 December 2015 21:23
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev
Hello Alexey,
Thanks for the review. I have updated the code as suggested.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.02/
Please see response to questions inline.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 25 December 2015 18:14
To: Rajeev Chamyal
Hello Sergey,
Thanks for the review.
The issues is reproducible with mac Aqua LAF only with other LAF/platforms
issue is not reproducible.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8078489/webrev.01/
Regards,
Rajeev Chamyal
-Original Message
Hello Alexey,
Thanks for the review.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 23 December 2015 19:27
To: swing-dev@openjdk.java.net
Subject: Re: Review
://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 22 December 2015 05:13
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-8075084
Component orientation is missing.
Fix: Updated the property change listener of Aqua LAF to update editor text
orientation.
Regards,
Rajeev Chamyal
Fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 21 December 2015 09:47
To: Sergey Bylokhov
Cc: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review request for 8041894: Test
javax/swing/JSpinner/8008657/bug8008657.java failed on Mac
Hello Sergey,
Yes, similar issue is there with maximize as well. I will raise a separate bug
for it.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 19 December 2015 03:51
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Hello Alexandr,
I have updated the fix. Please review it.
http://cr.openjdk.java.net/~rchamyal/8075084/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 10 December 2015 16:59
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev
for parent and Desktop pane are missing
Fix: Added null checks for parent and desktop pane.
Verified the fix on windows,Ubuntu and Mac with all supported LAF.
Regards,
Rajeev Chamyal
JDesktopPane.java as part of fix.
Regards,
Rajeev Chamyal
Hello,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 10 December 2015 22:42
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net; Prasanta
Sadhukhan
Subject: RE: JDK9 Review Request for JDK-7104635 HTMLEditorKit
has already
updated the cache so
Current frame is not found in cache and focus shift fails.
Fix: Internal frame removal from container is done after focus shift.
Regards,
Rajeev Chamyal
Hello Sergey,
Thanks for the review.
indentLevel is decremented in AbstractWriter :: incrIndent method as well.
Here also we have a check before decrementing indentLevel.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 December 2015 01:49
To: Rajeev Chamyal
Hello Avik,
Can you use @requires (os.family == "mac") instead of a method to check the OS
type.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 30 November 2015 17:22
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
swing-dev@openjdk.java.net
Subject: Revi
t disabled on windows.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 27 November 2015 19:21
To: Rajeev Chamyal
Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: JDK9 Review Request for 8067660: JFileChooser create
new fo
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8067660/webrev.01/
Attached image shows the error message.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 26 November 2015 16:18
To: Rajeev Chamyal
Cc
: The AbstractWriter::indent method is passing negative length of
indentChars to writer.
Fix: Added checks for negative value while decrementing the
AbstractWriter::indentlevel.
Regards,
Rajeev Chamyal
, along with all necessary parent
directories; false otherwise.
Please let me know if your inputs on this.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 25 November 2015 21:30
To: Rajeev Chamyal
Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: JDK9
from GenericFileSystemView:: createNewFolder,
WindowsFileSystemView:: createNewFolder and UnixFileSystemView::
createNewFolder if mkdirs call returns false.
Regards,
Rajeev Chamyal
The fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 17 November 2015 11:16
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review for 8132770: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails in MacOSX
The fix looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 17 November 2015 15:34
To: Avik Niyogi
Cc: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for 7124218: Space should select cell in the JTable
The fix looks
Hello Prasanta,
Please review the updated webrev. I have updated it as per review comments.
http://cr.openjdk.java.net/~rchamyal/6288609/webrev.01
Regards,
Rajeev Chamyal
-Original Message-
From: prasanta sadhukhan
Sent: 16 November 2015 12:32
To: Rajeev Chamyal
Cc: Alexander
Hello Phil,
I have updated the test case as per your review comments.
Could you please review it.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 12 November 2015 16:02
To: Rajeev Chamyal; Philip Race
The fix looks good to me.
Regards,
Rajeev Chamyal
Subject:
Re: RFR: [9] [JDK-8081491] The case print incomplete.
Date:
Fri, 16 Oct 2015 13:19:37 +0300
From:
Alexander Scherbatiy HYPERLINK
"mailto:alexandr.scherba...@oracle.com;<alexandr.scherba...@oracle.com>
To:
themselves.
I have tested the fix with all look and feels on Windows and Ubuntu and on MAC
with Aqua LAF as well.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 06 November 2015 19:41
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject
Hello Avik,
1) In the tryLookAndFeel exception handling is skipped. createUI and other
calls should be skipped in case of exception..
2) What all platforms you have tested the bug?
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 04 November 2015 14:51
To: Rajeev Chamyal
repeatedly till it reaches the other end of
scrollbar.
Fix: Added checks in the BasicScrollBarUI action listener to stop the recursion.
Regards,
Rajeev Chamyal
e.
Also we need set the opaque property on label component which makes sure that
all of the bits contained within component's rectangular bounds are painted.
Fix: Setting the default look and feel decoration for frame size issue and
making label opaque.
Regards,
Rajeev Chamyal
Hello Alexander,
Thanks for the review.
We need to set the opaque property on the label as well.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 06 November 2015 15:39
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
The test case has been updated as per review comments. Added tests for both
Parallel and default collector.
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: 30
Hello Sergey,
Please review the updated test case.
Webrev : http://cr.openjdk.java.net/~rchamyal/8030099/webrev.01/
As this issue is reported for Parallel GC collector. So, I have added
-XX:+UseParallelGC to child process VM arguments in test case.
Regards,
Rajeev Chamyal
-Original
by dispose method
DefaultDeskTopManager:closeFrame is unable to find reference to previous frame.
Fix: Removed the selection change code from Dispose method.
Regards,
Rajeev Chamyal
,
Rajeev Chamyal
Hello Sergey,
Thanks for the review. The test was working before the fix as well.
The current implementation of OSInfo.getWindowsVersion() adds the missing
values also to windowsVersionMap.
So test always passes.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent
Hello Sergey,
Thanks for the review. I have updated the webrev with review comments.
WebRev : http://cr.openjdk.java.net/~rchamyal/8138881/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 14 October 2015 20:44
To: Rajeev Chamyal; Alexander Scherbatiy
Hello Alexey,
Thanks for noticing it. Yes, we need to resolve it.
Alexander, Should I create a new bug for this or I can submit against the
existing bug.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: Friday, October 02, 2015 7:30 PM
To: Alexander Scherbatiy
Hello Alexander,
Thanks for the review. I have updated webrev as per review comments.
Bug: https://bugs.openjdk.java.net/browse/JDK-8067346
Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8067346/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
.
Current implementation is applying Vista defaults to Windows7 as well and as a
result submenu on windows7 has changed offset.
Added checks in WindowsLookAndFeel.java to skip Vista menu defaults for
Windows7.
Verified changes on Netbeans9 Dev build and SwingSet2 applications.
Regards,
Rajeev
Hello Alexander,
Thanks for the review. Please push the changes to JDK9.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Friday, September 18, 2015 9:22 PM
To: Rajeev Chamyal
Cc: Alexander Zvegintsev; swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re
Hi All,
Please review the following fix for jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-7190596
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/7190596/webrev.00/
Test being moved from closed to open repository.
Regards,
Rajeev Chamyal
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: Tuesday, September 08, 2015 2:38 PM
To: Sergey Bylokhov
Hi Alexander,
Could you please push the fix to JDK9.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: Wednesday, September 09, 2015 6:03 PM
To: Rajeev Chamyal; Alexander Zvegintsev; swing-dev@openjdk.java.net; Alexander
Scherbatiy
Subject: Re: Request for review
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Tuesday, September 08, 2015 2:27 PM
To: Rajeev Chamyal
Cc
Hello All,
Please review the below webrev.
http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Monday, September 07, 2015 6:21 PM
To: Rajeev Chamyal
Cc: Philip Race; Alexander Zvegintsev; swing
Hello All,
Please review the following webrev. I have updated the fix as per review
comments.
http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: Thursday, September 03, 2015 11:26 PM
To: Rajeev Chamyal
Cc
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, September 03, 2015 9:05 PM
To: Rajeev Chamyal
Hello All,
Please review the below webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-7190596
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/7190596/webrev.00/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: Monday, August 31, 2015 6:14 PM
To: Alexander Scherbatiy
for different languages.
For example in German close mnemonic is now S and for French its now F. To fix
the issue we are now finding the correct mnemonic character and passing it to
robo.
Regards,
Rajeev Chamyal
Hello All,
I need one more review for this fix. Can someone please review it.
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.open/
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.closed/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent
and child components.
Added a default Insets value for Nimbus look and feel, similar to other layouts.
Regards,
Rajeev Chamyal
Hi All,
Please review the following webrev.
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.open/
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.closed/
Test has been moved to open repository.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander
Hello All,
Please review the updated webrev.
Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8025082/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8025082
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Wednesday, August 26, 2015 6:39 PM
or less size. Test condition was
checking for inequality and throwing Runtime exception.
Regards,
Rajeev Chamyal
Hello All,
Please review the below fix for JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8025082
webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8025082/webrev.00/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: Friday, August 21, 2015 5:40 PM
To: swing-dev
focus.
Added a method to update the selection ownership for caret when text is
selected/unselected in the JTextPane/JTextArea.
Regards,
Rajeev Chamyal
101 - 157 of 157 matches
Mail list logo