Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Jason Moore
I watched Raymond's talk but didn't come away thinking that we should merge formatting and functionality edits. That seems to cloud the history even more. With git blame you can see the commit message and if it says formatting, then you need to git blame before that commit to see who actually

[sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread James Crist
I expect this to turn into a flamewar, so I'm going to ask everyone to only give one opinion (voting style). Please please please don't fight about this. I just got back from PyCon, and there was a presentation there on pep 8 formatting, and one of the main points was that pure formatting PRs

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread James Crist
Have you tried git blame -CCC -M? According to the manpage it is supposed to be smarter about stuff. I had not, but it looks better. I've rarely encountered this issue, I just thought I'd ask how the community felt about it. Personally, I still feel like cleaning up code should be done only

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread James Crist
Side tracking the conversation a bit, PyCon was very productive for me. I gave a talk to a group of Sage users, and they seemed excited about SymPy. Apparently (at least according to them) the symbolic support in sage is poor, and sympy is much better. It word be nice to get sympy/csympy to be the

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Aaron Meurer
On Tue, Apr 14, 2015 at 4:36 PM, James Crist crist...@umn.edu wrote: Side tracking the conversation a bit, PyCon was very productive for me. I gave a talk to a group of Sage users, and they seemed excited about SymPy. Apparently (at least according to them) the symbolic support in sage is

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Aaron Meurer
Have you tried git blame -CCC -M? According to the manpage it is supposed to be smarter about stuff. There is also the -w flag which makes it ignore whitespace (I haven't really tested it, though). In general, git blame only gets you to the last change of a line. You typically have to checkout the

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Aaron Meurer
On Tue, Apr 14, 2015 at 3:00 PM, Ondřej Čertík ondrej.cer...@gmail.com wrote: On Tue, Apr 14, 2015 at 1:02 PM, Aaron Meurer asmeu...@gmail.com wrote: Have you tried git blame -CCC -M? According to the manpage it is supposed to be smarter about stuff. There is also the -w flag which makes it

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Ondřej Čertík
On Tue, Apr 14, 2015 at 1:02 PM, Aaron Meurer asmeu...@gmail.com wrote: Have you tried git blame -CCC -M? According to the manpage it is supposed to be smarter about stuff. There is also the -w flag which makes it ignore whitespace (I haven't really tested it, though). In general, git blame

Re: [sympy] [code quality] - Pure formatting PRs possibly harmful?

2015-04-14 Thread Joachim Durchholz
Am 14.04.2015 um 19:54 schrieb James Crist: For example, say I make a tiny bug fix in function foo - I could also clean up some of the code in foo. That way the last person to touch foo is not someone who added a space between an operator, but someone who actually changed the functionality of

[sympy] Multivariate Meijer G or Fox H-Functions

2015-04-14 Thread brandon willard
Is anyone working on multivariate Meijer G or Fox H functions? -- You received this message because you are subscribed to the Google Groups sympy group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group,

Re: [sympy] Multivariate Meijer G or Fox H-Functions

2015-04-14 Thread Aaron Meurer
meijerg is already implemented http://docs.sympy.org/latest/modules/functions/special.html#sympy.functions.special.hyper.meijerg. I don't think Fox H is, though. Aaron Meurer On Tue, Apr 14, 2015 at 3:30 PM, brandon willard brandonwill...@gmail.com wrote: Is anyone working on multivariate