Status: Started
Owner: mattpap
Labels: Type-Enhancement Priority-High NeedsReview Milestone-Release0.7.0
New issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
So, after 5 weeks of coding new module is done. Well, almost done because
m
Comment #1 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Wow! This is great. Simplification is much better with this. For
example, consider the complex expression
from issue 1562. In your branch:
>>> a = wronskian([sin(x
Comment #2 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
Wow, Mateusz, you are a genius.
I tried this:
In [1]: a = (x+y+z)**20
In [2]: b = a.expand()
In [6]: time factor(b)
CPU times: user 3.08 s, sys: 0.00 s, tota
Comment #3 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
(the test tests a bug in py.test, that it fails to execute two files in the
sympy
tree with the same filenames, e.g. one in mpmath and one in polys)
--
You rec
Comment #4 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
Mateusz, would you manage to use cython to speed up the factorization a
bit? Just for
fun, so that I can show it on scipy09, as an example of using cython. Here
Comment #5 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
And for this:
In [5]: a = (x+y+sin(z))**20
In [6]: b = a.expand()
In [7]: time factor(b)
CPU times: user 3.38 s, sys: 0.00 s, total: 3.38 s
Wall time: 3.46 s
O
Comment #6 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
SO NICE to see the changes...this is going to make some of my other work
much easier.
Thanks!
I noticed that expressions with NumberSymbols can be made into polys, but
Comment #7 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Thanks guys for comments. So ...
Ondrej:
What's really slow in your examples is expand(). See the following
phenomenon:
In [1]: a = (x+y+sin(z))**20
In [2]: %time b
Comment #8 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I forgot to mention that you can easily switch between different ground
types, just
specify SYMPY_GROUND_TYPES=something before isympy. So lets factor once
again, thi
Comment #10 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
Yeah, but once we beat Sage, it's still nothing, since Mathematica can do
this instantly:
In[1]:= c = Factor[Expand[(x+y+z)^100]]
100
Out
Comment #11 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> This code was a part of Poly.cancel, which was copied from radsimp().
> However,
> radsimp() tries to do more and is problematic (there are issues opened
> for th
Comment #12 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
It looks like factor also chokes on reals, and you have a bug:
>>> factor(x*(y + z)**(1/2)*(1 + y))
Traceback (most recent call last):
File "", line 1, in
File "
Comment #9 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
ok, first expand=False only speeds things up a bit for me (from 3.16s to
2.84s),
however, this:
$ SYMPY_GROUND_TYPES=gmpy bin/isympy
Python 2.6.2 console for S
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1647.
See http://code.google.com/p/sympy/issues/detail?id=1647
--
You received this message because you are listed in the owner
or CC fields of this issue, or bec
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue sympy:829.
See http://code.google.com/p/sympy/issues/detail?id=829
--
You received this message because you are listed in the owner
or CC fields of this issue, or
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue sympy:829.
See http://code.google.com/p/sympy/issues/detail?id=829
--
You received this message because you are listed in the owner
or CC fields of this issue, or
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is no longer blocking issue sympy:829.
See http://code.google.com/p/sympy/issues/detail?id=829
--
You received this message because you are listed in the owner
or CC fields of this issu
Updates:
Cc: smichr
Comment #13 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Chris, could you please try to rebase this branch on master? There are some
non-trivial conflicts with your improvements, I think
Comment #14 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Do you mean the polys branch?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adju
Comment #15 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Yeah, please try to rebase polys on master, I think you know the code
better.
--
You received this message because you are listed in the owner
or CC fields
Comment #16 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
OK, give me a day or two...
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust
Comment #17 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Great, looking forward!
Maybe we should release 0.6.6 before without new polynomials?
--
You received this message because you are listed in the owner
or CC
Comment #18 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
ok, there are some issues to attend to as the test will show and there are
a couple
of things discussed in the commit. I think I've got it rebased properly.
See the
po
Comment #19 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Was I right in deleting trim and cancel from simplify, Matteusz?
Also, factor still should be doing something different. It's failing to
factor this
function:
>>> from
Comment #20 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I posted a rebased-on-master version of polys named polys2 to my smichr
github
account. How shall we keep track of work that is to be done on this? Will
each person
th
Comment #21 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I think everyone can post his progress here. git is decentralized, so
everyone can
work on his own branch and pull changes from others. So if Mateusz wanted
Comment #22 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
But who merges all the changes. I can keep pushing my changes here, but
unless (like
for master) someone will oversee the updating as changes are made, you can
end up
Comment #23 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I think you need to try again. You left a merge line in test_basic.py.
Also, a ton of tests are failing now, so it is
definitely a good idea I think to postpone the
Comment #24 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> But who merges all the changes. I can keep pushing my changes here, but
> unless
> (like for master) someone will oversee the updating as changes are made,
> you ca
Comment #26 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
in light of Mateusz's comment above I will stop trying to rebase this on
master.
--
You received this message because you are listed in the owner
or CC fields of this i
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 829.
See http://code.google.com/p/sympy/issues/detail?id=829
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1469.
See http://code.google.com/p/sympy/issues/detail?id=1469
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1562.
See http://code.google.com/p/sympy/issues/detail?id=1562
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 199.
See http://code.google.com/p/sympy/issues/detail?id=199
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 317.
See http://code.google.com/p/sympy/issues/detail?id=317
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 326.
See http://code.google.com/p/sympy/issues/detail?id=326
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 588.
See http://code.google.com/p/sympy/issues/detail?id=588
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 595.
See http://code.google.com/p/sympy/issues/detail?id=595
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 783.
See http://code.google.com/p/sympy/issues/detail?id=783
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1095.
See http://code.google.com/p/sympy/issues/detail?id=1095
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1097.
See http://code.google.com/p/sympy/issues/detail?id=1097
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1106.
See http://code.google.com/p/sympy/issues/detail?id=1106
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1122.
See http://code.google.com/p/sympy/issues/detail?id=1122
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1243.
See http://code.google.com/p/sympy/issues/detail?id=1243
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1343.
See http://code.google.com/p/sympy/issues/detail?id=1343
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1355.
See http://code.google.com/p/sympy/issues/detail?id=1355
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1432.
See http://code.google.com/p/sympy/issues/detail?id=1432
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1568.
See http://code.google.com/p/sympy/issues/detail?id=1568
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1587.
See http://code.google.com/p/sympy/issues/detail?id=1587
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 1598: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
This issue is now blocking issue 1349.
See http://code.google.com/p/sympy/issues/detail?id=1349
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #27 on issue 1598 by ondrej.certik: New polynomials manipulation
module
http://code.google.com/p/sympy/issues/detail?id=1598
Let's improve this as Mateusz has said, then put it in (probably after the
release).
--
You received thi
Comment #28 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I have a patch for consideration...factor() in polytools should not be
returning two
arguments.
The commit with memo to that effect is pushed to the polys2 branch.
Als
Comment #29 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> I have a patch for consideration...factor() in polytools should not be
> returning
> two arguments
I already fixed that in polys3 and written tests.
> Also, I made
Comment #30 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
The functionality for gcdfactor is there, but a simple wrapper for someone
who
doesn't want to get into Polys is not there. Compare
expr = gcdfactor(expr)
with
Comment #31 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
1. I'm talking about this commit:
http://github.com/mattpap/sympy-polys/commit/8e1c2fd03f29128eefb584bce28c3ddde42dcf2c
Example:
In [3]: terms_gcd(x**3*y-x*y**3)
Out[3
Comment #32 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I think we can drop fraction(), if we don't improve it. Currently
as_numer_denom()
seems to be more powerful.
--
You received this message because you are
Comment #33 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
see issue 1731.
Also, Poly.terms() is giving out monom, coeff whereas the old
Poly.iter_terms() gave
out coeff, monom...is this intentional?
--
You received this messa
Comment #34 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I'm running on polys3 and observe the following:
>>> n
6*(-a + x**2)**8*(-a - 3*x**2) - 48*x**3*(-a + x**2)**6*(a*x + x**3) +
24*x*(-a +
x**2)**7*(a*x + x**3) + 24*x**2
Comment #35 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
You are right. fraction() is like as_numer_denom() except for a
little "magic", but I think we should move all of the code there into
as_numer_denom() as it is duplic
Comment #36 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Also, is there a way to make monic work even when coefficients don't reduce
to
multiples of the leading coefficient?
###
>>> Poly(3*x**3+5*x**2+7*x+11,x).monic()
Traceb
Comment #37 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
re comment 35:
Yes, factor should be used whenever there is a term in the resultant Mul
that has
more than one symbol in it, otherwise it doesn't need to overwork itsel
Comment #38 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> Also, Poly.terms() is giving out monom, coeff whereas the old
> Poly.iter_terms()
> gave out coeff, monom...is this intentional?
Yes, because this is coherent with d
Comment #39 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Forgot to say, that there always exists a suitable evaluation set. Our task
is to
find the one which results in a univariate polynomial which has exactly the
same
num
Comment #40 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
One other observation on polys3...when sending roots a Poly, even if the
heuristics
fail, the whole process shouldn't fail if the Poly is 4th order or less--a
call to
Comment #41 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> Also, is there a way to make monic work even when coefficients don't
> reduce to
> multiples of the leading coefficient?
Yes, there is only one issue:
In [1]: f = 3
Comment #42 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> ExactQuotientFailed: DMP([12, 0, -84], ZZ) does not divide DMP([48, 0,
> 96], ZZ)
> in ZZ[a]
That's a bug. There should be K.exquo instead of K.quo in:
g[s-i]
Comment #43 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
PolynomialError should be imported in polyclasses.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred thi
Comment #44 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
PolynomialError should be imported in polyclasses.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred thi
Comment #45 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I went ahead and finished refactoring polytools.py and writing tests for
it. Now
coverage for this file is 100%. Also added tests for monomialtools.py and
fixed all
b
Comment #46 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Also, perhaps roots_cubic and roots_quartic should use the monic function
rather than
the monic method for reasons discussed in comment 41:
###
>>> var('x');p=Poly(3*x*
Comment #47 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
or should that be exquo in line 143 of densearith.py?
return [ K.exquo(cf, c) for cf in f ]
--
You received this message because you are listed in the owner
or CC field
Comment #48 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Yes, making the change in densearith.py solves the problem:
>>> var('x');p=Poly(3*x**3+5*x**2+7*x+11)
>>> roots(p)
{-1/3 + (65/54 + 5*21**(1/2)/18)**(1/3)*(1/2 + I*3**(1/
Comment #49 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> or should that be exquo in line 143 of densearith.py?
No, because you are changing dup_quo_ground(). See a few lines below that,
there is a
function dup_exquo_ground
Comment #50 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I wonder if roots(basic) should accept a basic expression or if it should
perhaps
give a tuple as a result. With the expanded capabilities of polys, you can
now get a
Comment #51 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> Do you think roots should return (gen, dict) as a result?
It might be useful. Actually I didn't care much about root-finding code
yet, when
working on new polys. For
Comment #52 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I was bored with what I was supposed to do today, so in the mean time I
implemented
factorization algorithm over algebraic number fields, e.g.:
In [1]: factor(x**4+1,
Comment #53 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
And multivariate support is ready:
In [1]: factor(x**2 - 2*y**2, extension=sqrt(2))
Out[1]:
⎛⎽⎽⎽⎞ ⎛⎽⎽⎽⎞
⎝x + y⋅╲╱ 2 ⎠⋅⎝x - y⋅╲╱ 2 ⎠
So, only multiple ex
Comment #54 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
New functionality available in polys4 branch. Note that the new
factorization code is
experimental, so it might be still quite buggy. Anyway, now I will be able
to fi
Comment #55 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Perhaps the solution to comment 46 is to have Poly instantiate from a basic
expression with field=True automatically:
>>> p=Poly(3*x**3+5*x**2+7*x+11)
>>> roots(p)
Traceb
Comment #56 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Issue 1759 has an upgrade possibility for the factor/gcd method wherein
Adds that
appear in things that might be expanded (like the base or exponent of a
Pow) are
fact
Comment #57 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
After a lot of work, finally, multiple algebraic extensions are ready, e.g.:
In [1]: factor(x**4+2, extension=[I])
Out[1]:
4
2 + x
In [2]: factor(x**4+2, extensio
Comment #58 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
|Is there a reason why you can't just write this:
|
|>>> roots(3*x**3+5*x**2+7*x+11)
No. I'm realizing that you may just feed roots Basic (as done in comment
50).
|> I
Comment #59 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
There is actually quite a lot more you can do:
1. You can factor a polynomial over a non trivial domain:
In [1]: factor(x**2-2, extension=sqrt(2)+sqrt(3))
Out[1]:
⎛
Comment #60 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
> Then perhaps this should be done only to separatevars.
It depends on how useful this can be. Possibly we should finally derive
some scheme
for implementing simplific
Comment #61 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Update of the new polynomials module is available at:
http://github.com/mattpap/sympy-polys/commits/polys5
(rebased on top of master). Changes:
- implemented real a
Comment #62 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Great! Do you think we should merge before or after the next release, which
is
necessary to happen soon due to issue 1783?
I'm getting this failure on 6
Comment #63 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
If you want to do a release for issue 1783, I would suggest just having a
0.6.6.1 release (or 0.6.7), and putting the new
polys and hopefully the new assumptions in
Comment #64 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I think that the new polys module might possibly be more stable than the
old one, as
it should fix many bugs.
--
You received this message because you a
Comment #65 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I agree (the blocking list for this issue is quite large by now). But it
will no doubt introduce many bugs too (the sad truth with any
program is that you have to co
Comment #66 on issue 1598 by ronan.l...@gmail.com: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
The minor release (0.6.7 or whatever) shouldn't introduce
incompatibilities. The new
module should appear in 0.7.0 but not before.
BTW, I wonder how
Comment #67 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
BTW, I wonder how to review such a big chunk of code sensibly.
Release early, release often. :) The module is under review for quite some
time
already
Comment #68 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I agree that 0.7.0 is the right time to merge new polynomials module.
Introducing
such a big change in a minor release would be very confusing to our users,
especial
Comment #69 on issue 1598 by Vinzent.Steinberg: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
One tests seems to be failing currently:
___ sympy/solvers/tests/test_ode.py:test_separable2
File "/home/one/src/sympy/sy
Comment #70 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
One tests seems to be failing currently:
Fixed (but needs improvements -> more coercion rules).
--
You received this message because you are listed in the owner
or C
Comment #71 on issue 1598 by ronan.l...@gmail.com: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Well, here are some comments.
General comments:
* Many identifiers are too short. For instance, DUP should be
DenseUnivariatePolynomial, or something
Comment #72 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
[1] GFP, DUP, DMP, DMF, SDP, ANP -> short but meaningful names, at least to
me. When
the module will be fully operational, you won't see any of those names
during yo
Comment #73 on issue 1598 by asmeurer: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I disagree about self. The use of "self" makes it very clear that this is
a class method and that the first argument
will be implicitly the class object, not passed
Comment #74 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
In master, when calling Poly(1) with no symbols, an error was raised. In
polys5 this
doesn't raise an error, returns S.One, and the user won't know that they
don't ha
Comment #75 on issue 1598 by mattpap: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
I disagree about self. The use of "self" makes it (...)
We can discuss it further, but now I would like to focus on delivering
implementation
of RootOf class and
Comment #76 on issue 1598 by smichr: New polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
<>>
Does this mean a new solve routine as well?
--
You received this message because you are listed in the owner
or CC fields of this issue, or becaus
1 - 100 of 135 matches
Mail list logo
