On 05/12/15(Sat) 13:07, Vincent Gross wrote:
> in6_selectsrc() uses two different rtalloc calls depending on whether or
> not the destination address is multicast or not, but there is nothing to
> explain why. I dug a bit and found this commit from itojun@ :
>
> diff -u -r1.6 -r1.7
> ---
On Sat, Dec 05, 2015 at 06:26:35AM -0500, Ted Unangst wrote:
> may i suggest strlen(s) instead of strchr(s, 0)?
There's actually one part in newfs' code that uses this. And in theory
it has the same issue, not checking if s (which is special, which might
be argv[0]) is empty. I highly doubt this
On Wed, Dec 02, 2015 at 08:37:05AM -0500, Ted Unangst wrote:
> This is a variant of the diffs sent by Daniel Micay, and then assembled by
> Theo Buehler. I've looked it over and made a few tweaks.
>
> One: validate the junk in malloc hasn't been touched. I've tweaked this to
> always be on if
On 4.12.2015. 17:35, Hrvoje Popovski wrote:
> On 4.12.2015. 12:47, Mark Kettenis wrote:
>> Here is a new diff to make ix(4) mpsafe. Should now longer get stuck
>> in the OACTIVE state. Tests more than welcome.
>>
>
>
> Hi,
>
> i have tested this patch with 82599 and x540 while sending 6Mpps
So Mark and I spent some time to figure out what the issue was with ix(4)
based on that info I resurected the em(4) mpsafe diff that got backed out
and I applied the same fix. It is somewhat unclear if this fixes the
watchdog timeouts since in theory the wdog timer should be stopped when
hitting
Thoughts? ok?
Index: README
===
RCS file: /cvs/src/bin/ksh/README,v
retrieving revision 1.15
diff -u -p -r1.15 README
--- README 5 Dec 2015 19:40:45 - 1.15
+++ README 6 Dec 2015 04:58:27 -
@@ -15,8 +15,3 @@
The main interesting bit here is the txeof and start loops, which previously
operated based on the prod/cons indices and the contents of the tx queue,
but now just uses the indices as that's the only way to get a consistent view
of the tx queue state.
At the moment I don't think the tx ring is
On Tue, Dec 01, 2015 at 05:46:07PM +0100, David Coppa wrote:
>
> Hi!
>
> Here's the update to freetype-2.6.2.
>
> It shouldn't cause any fallout, but who knows with freetype... So
> probably a ports bulk build can be useful.
>
> FreeType homepage says it's mostly a bugfixing release, but I've
XenStore provides a hierarchical storage for Xen configuration
ala OpenFirmware. Itself it's an interrupt driven producer/
consumer interface with two 1kb queues for input and output.
It's required in order to do virtual device discovery and
device configuration (MAC address, various
This implements simple device probing.
I have discussed this with deraadt@ and then later with kettenis@
and mpi@ and we've decided that OpenFirmware emulation would be a
bit too much (at least for now).
This is a work in progress, it will improve a bit once we start
working on the Netfront
On 2015 Dec 05 (Sat) at 16:16:50 +0100 (+0100), Hrvoje Popovski wrote:
:On 4.12.2015. 17:35, Hrvoje Popovski wrote:
:> On 4.12.2015. 12:47, Mark Kettenis wrote:
:>> Here is a new diff to make ix(4) mpsafe. Should now longer get stuck
:>> in the OACTIVE state. Tests more than welcome.
:>>
:>
:>
This brings in support for Xen hypercalls via an MI interface
and implements functions to fetch extended version and features.
OK?
---
sys/dev/pv/xen.c| 227
sys/dev/pv/xenreg.h | 184 ++
This allocates a page-aligned page in the kernel text segment
to be used by the hypercall interface. The content of the page
is provided by the Hypervisor itself when it's physical address
is communicated via an MSR write (in the next diff).
OK?
---
sys/arch/amd64/amd64/locore.S | 10
Tobias Stoeckmann wrote:
>
> And I still think that the current code is a bit too permissive in parsing
> things. I mean what's the point in allowing lines like:
>
> sometextwithoutspace/bin/ksh should be used for logins # seriously!
>
> Which would result in /bin/ksh, by the way.
>
> Didn't
Allocate and hook up a "shared info page" that provides a matrix
of pending events and some other information like hypervisor
timecounter. I'd like to keep the debugging function
xen_print_info_page around for a while.
OK?
---
sys/dev/pv/xen.c| 82
sys/dev/pv/xenreg.h | 368
To me the new code seems broken. It keeps a fd open between
libc calls. It requires endusershell() to be called later.
Not even close-on-exec can work here, because libc is remembering
a FILE * referring to an open fd.
Leaving a fd open between libc calls is verboten, unless there is
On Sat, Dec 05, 2015 at 05:05:07PM +0100, Martin Pieuchot wrote:
> Here's a rewrite of glibtop_get_netload_p(). I tested it with custom
> code because I could not trigger this code path with our ports.
>
> This unbreaks devel/libgtop2 after the recent commit.
>
> I believe this should go
Tobias Stoeckmann wrote:
> There's still a possible overflow in getusershell.c. We could increase
> the buffer allocation yet again, but I have to agree with the glibc
> developers here: enough is enough. The code is ugly and has proven to be
> difficult to review.
Another approach is to rewrite
Here's a rewrite of glibtop_get_netload_p(). I tested it with custom
code because I could not trigger this code path with our ports.
This unbreaks devel/libgtop2 after the recent commit.
I believe this should go upstream, how should I submit this?
ok?
Index: Makefile
On Tue, Nov 24, 2015 at 01:03:39PM +0500, Alexandr Shadchin wrote:
> Hi,
>
> This diff updates xf86-input-keyboard to the latest release.
> Tested on amd64.
>
> Comments ? OK ?
I had the same diff for some time on my machines.
ok matthieu@
--
Matthieu Herrb
pgpuFQh60jB3B.pgp
Description:
On Tue, Nov 24, 2015 at 01:32:01PM +0500, Alexandr Shadchin wrote:
> Hi,
>
> This diff updates xf86-input-synaptics to the latest release.
> Tested on amd64.
>
> Comments ? OK ?
ok matthieu@ and sorry for the delay.
>
> --
> Alexandr Shadchin
>
> Index: ChangeLog
>
> Index: gen/getusershell.c
> ===
> RCS file: /cvs/src/lib/libc/gen/getusershell.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 getusershell.c
> --- gen/getusershell.c14 Sep 2015 16:09:13 - 1.16
> +++
This adds a Netfront device stub. Diff is more for educational
purposes at the moment. Perhaps Paul will chip in and help me
add flesh to it.
---
sys/arch/amd64/conf/GENERIC | 1 +
sys/dev/pv/files.pv | 4
sys/dev/pv/if_xnf.c | 46
On 5.12.2015. 16:35, Peter Hessler wrote:
> On 2015 Dec 05 (Sat) at 16:16:50 +0100 (+0100), Hrvoje Popovski wrote:
> :On 4.12.2015. 17:35, Hrvoje Popovski wrote:
> :> On 4.12.2015. 12:47, Mark Kettenis wrote:
> :>> Here is a new diff to make ix(4) mpsafe. Should now longer get stuck
> :>> in the
On 05/12/15(Sat) 19:12, Mike Belopuhov wrote:
> This diff doesn't do much by itself, just hooks up minimal Xen
> files to the tree. I've split it so that all changes on top
> will look logically complete.
>
> OK?
Can you add "const" before your "struct cfattach"?
Do you need a separate
Starting with this one, all further patches are sort of
work in progress. This diff implements a way to detach
emulated devices (like a em network interface) in order
to switch them to paravirtualized drivers (e.g. Netfront).
Currently I'm not detaching anything, but provide a way
to do it via
On Sat, Dec 05, 2015 at 01:25:10PM -0500, Ted Unangst wrote:
> ok. i was going to leave the behavior alone, but we can fix that too.
>
> - use getline to read lines of any length.
> - only consider lines that start with a /.
> - truncate lines after a #, but not after spaces.
ok tobias, thanks
This diff doesn't do much by itself, just hooks up minimal Xen
files to the tree. I've split it so that all changes on top
will look logically complete.
OK?
---
sys/arch/amd64/conf/GENERIC | 2 +
sys/dev/pv/files.pv | 5 ++
sys/dev/pv/xen.c| 113
We're going to support two ways of delivering the combined
Xen interrupt that later fans out into event port specific
(device specific) interrupts: IDT method and a PCI device
method.
This diff adds a Xen IDT vector the same way LAPIC timer and
IPIs are implemented. The additional machinery is
This diff communicates an allocated IDT vector to the Hypervisor.
OK?
---
sys/dev/pv/xen.c| 34 ++
sys/dev/pv/xenvar.h | 2 ++
2 files changed, 36 insertions(+)
diff --git sys/dev/pv/xen.c sys/dev/pv/xen.c
index e8aeeb8..8643636 100644
--- sys/dev/pv/xen.c
This adds support for establishing virtual interrupts via Xen
event channel ports.
During boot, Xen will use polling mode, but once the system
enables interrupts after cpu_configure(), xen_intr_enable
will be called from the mountrook hook to unmask event ports.
xen_intr is the combined
On Sat, Dec 05, 2015 at 07:19:18PM +0100, Mike Belopuhov wrote:
> This allocates a page-aligned page in the kernel text segment
> to be used by the hypercall interface. The content of the page
> is provided by the Hypervisor itself when it's physical address
> is communicated via an MSR write (in
Here's the spin-off from previous __progname patch.
It's possible to have an out-of-boundary read in newfs_ext2fs when
supplying an empty partition name. Before calling strchr() - 1, it should
be verified that it's not empty. While at it, the result of the strchr call
will never be NULL, because
in6_selectsrc() uses two different rtalloc calls depending on whether or
not the destination address is multicast or not, but there is nothing to
explain why. I dug a bit and found this commit from itojun@ :
diff -u -r1.6 -r1.7
--- src/sys/netinet6/in6_src.c 2000/06/18 04:49:32 1.6
+++
On Sat, Dec 05, 2015 at 01:25:10PM -0500, Ted Unangst wrote:
> Tobias Stoeckmann wrote:
> >
> > And I still think that the current code is a bit too permissive in parsing
> > things. I mean what's the point in allowing lines like:
> >
> > sometextwithoutspace/bin/ksh should be used for logins #
On Sat, Dec 05, 2015 at 20:13 +0100, Karel Gardas wrote:
> > +void
> > +xen_disable_emulated_devices(struct xen_softc *sc)
> > +{
> > +#if defined(__i386__) || defined(__amd64__)
>
> just a nitpick, not in a position to comment on your patches but this
> has caught my eyes. So far everything was
Tobias Stoeckmann wrote:
> Opinions, thoughts?
looks good, but you've got some mostly unrelated changes in here. this should
be separate, but ok for the rest.
> > Index: sbin/newfs_ext2fs/newfs_ext2fs.c
> > ===
> > RCS file:
On Sat, Dec 05, 2015 at 07:33:11AM +0100, Stefan Kempf wrote:
Tati Chevron wrote:
This assembled and linked without problems on 5.7-release, but now when
I try it on 5.8-release, I get an error:
$ as -o charset.o charset.S
$ ld -Bstatic charset.o
ld: charset.o: relocation R_X86_64_32S
On Sat, Dec 05, 2015 at 03:29:06AM -0500, Ted Unangst wrote:
> looks good, but you've got some mostly unrelated changes in here. this should
> be separate, but ok for the rest.
It started with a "check argv" code review and ended up with __progname
adjustments, so I agree here and removed the
Hello,
henning@ and mikeb@ showed some interest to change handling of once rules to
the same way as PF has it on Solaris. Just to refresh the audience on once
option offered by PF:
onceCreates a one shot rule that will remove itself from an active
ruleset after the first
The previous thread[1] discussing these controllers includes two
patches but they seem to have been merged for the commit in a way
that limits support to only Microsoft controllers. 3rd party Xbox 360
controllers have their own vendor and product IDs but use the same
subclass and protocol as the
Tobias Stoeckmann wrote:
> On Sat, Dec 05, 2015 at 06:26:35AM -0500, Ted Unangst wrote:
> > may i suggest strlen(s) instead of strchr(s, 0)?
>
> There's actually one part in newfs' code that uses this. And in theory
> it has the same issue, not checking if s (which is special, which might
> be
the current code for serialising if_start calls for mpsafe nics does what it
says.
however, kettenis realised it doesnt help us much when we're trying
to coordinate between the start and txeof side of a driver when
setting or clearing oactive. in particular, a start routine can
figure out
43 matches
Mail list logo
