Re: vfs: drop proc from VOP_OPEN

2023-07-17 Thread Thordur Bjornsson
36PM +0200, Thordur Bjornsson wrote: > First of a few. > > Many thanks to mpi@ for adding the curproc assert's! > > Two questions: > - NOCRED: Best this should just be NULL ? > - FSCRED: This is only AFAICT used for mounts > Not 100% clear, but this could perhaps be

vfs: drop proc from VOP_OPEN

2023-07-17 Thread Thordur Bjornsson
First of a few. Many thanks to mpi@ for adding the curproc assert's! Two questions: - NOCRED: Best this should just be NULL ? - FSCRED: This is only AFAICT used for mounts Not 100% clear, but this could perhaps be done away with at the loss of some metadata (it just forces spec_open to open u

Re: deadfs cleanup

2023-07-17 Thread Thordur Bjornsson
ping beck@ stacking vp->v_lock (rwlock, couldn't bring myself to call it interlock) diffs ontop of this to kill v_id and VXLOCK. Could use an eyeball or two :) On Tue, Jul 11, 2023 at 09:34:01PM +0200, thib4711 wrote: > deadfs cleanup > > chkvnlock() is useless, since deadfs vops are only ever a

Re: vfs: drop unnecessary cache_purge()s

2023-07-17 Thread Thordur Bjornsson
On Mon, Jul 17, 2023 at 11:38:49AM +0200, Sebastien Marie wrote: > On Sat, Jul 15, 2023 at 09:21:40AM +0200, Thordur Bjornsson wrote: > > yes, vclean() will call cache_purge() after calling VOP_RECLAIM(). so we > ended-up > to have called cache_purge() several times. > > b

vfs: drop unnecessary cache_purge()s

2023-07-16 Thread Thordur Bjornsson
VOP_RECLAIM is only ever called from vclean() to cleanup fs dependent data, and vclean() calls cache_purge(). Makes all of the reclaim implementations the same in this regard. diff --git sys/isofs/cd9660/cd9660_node.c sys/isofs/cd9660/cd9660_node.c index bce99d77c22..300277f3b37 100644 --- sys/is

Re: Expose some scheduler statistics to userland via sysctl

2011-11-17 Thread Thordur Bjornsson
On 2011 Nov 17 (Thu) at 21:18:24 -0200 (-0200), Christiano F. Haesbaert wrote: > Moving this to tech@ > > Hi, > > I was studying the scheduler code after watching tedu's talk, I'd like > to expose this statistics to userland so that I can try playing with > cache affinity in the future: > > giml

Re: dd(1) human-readable output

2011-08-23 Thread Thordur Bjornsson
On 2011 Aug 23 (Tue) at 20:48:09 +0200 (+0200), Thomas Pfaff wrote: > This patch makes dd(1) output change from e.g. > > $ dd if=/dev/sd0c of=/dev/null bs=512 count=16000 > 16000+0 records in > 16000+0 records out > 8192000 bytes transferred in 3.002 secs (2728488 bytes/sec

Re: kdump: resolve sysctl numbers

2011-07-27 Thread Thordur Bjornsson
On 2011 Jul 27 (Wed) at 19:22:34 +0200 (+0200), Jasper Lievisse Adriaanse wrote: > On Wed, Jul 27, 2011 at 10:58:22AM -0400, Ted Unangst wrote: > > On Wed, Jul 27, 2011, Otto Moerbeek wrote: > > > > > +#define SETNAME(name) do { names = (name); limit = nitems(name); } while > > > (0) > > > > use

Re: vnode(9) man page

2011-07-18 Thread Thordur Bjornsson
On Mon, Jul 18, 2011 at 07:11:54AM +0059, Jason McIntyre wrote: > On Sun, Jul 17, 2011 at 03:25:29PM +0000, Thordur Bjornsson wrote: > > > > > > The commit comment indicates to me that the underlying mechanism > > > changed significantly, so now I wonder if the info

Re: vnode(9) man page

2011-07-17 Thread Thordur Bjornsson
On Sun, Jul 17, 2011 at 04:25:59PM +0200, Benny Lofgren wrote: > While reading up on vnodes I found a couple of glitches in the > vnode(9) man page (diff below). It refers in one place to the > file sys/kern/vnode_if.src which was deleted by this commit: Good catch. I thought I had nuked that; >

Re: Introducing rrw locks;

2011-07-07 Thread Thordur Bjornsson
On Thu, Jul 07, 2011 at 06:59:53PM +, Thordur Bjornsson wrote: > On Wed, Jul 06, 2011 at 10:05:00PM +0000, Thordur Bjornsson wrote: > > I really need to hear back from you guys with reports, i.e. on > what, with what fs and a short description of what you toyed with > maybe

Re: Introducing rrw locks;

2011-07-07 Thread Thordur Bjornsson
On Wed, Jul 06, 2011 at 10:05:00PM +, Thordur Bjornsson wrote: I really need to hear back from you guys with reports, i.e. on what, with what fs and a short description of what you toyed with maybe ? ciao, thib. > Hi, > > > This diff introduces rrwlocks or recursive/re-ent

Introducing rrw locks;

2011-07-06 Thread Thordur Bjornsson
NOSTIC */ #if defined(MULTIPROCESSOR) /* @@ -343,7 +104,7 @@ lockmgr_printinfo(__volatile struct lock *lkp) * so that they show up in profiles. */ -struct __mp_lock kernel_lock; +struct __mp_lock kernel_lock; void _kernel_lock_init(void) @@ -385,10 +146,4 @@ _kernel_proc_unlock(struct proc *p

Re: Future of ccd(4) and raid(4)?

2011-06-24 Thread Thordur Bjornsson
On Fri, Jun 24, 2011 at 03:38:48PM +, Christian Weisgerber wrote: > Matthew Dempsky wrote: > > > What should be done about ccd(4) and raid(4)? They both seem > > superseded in functionality by softraid(4), which also has much more > > developer interest and active development. > > Is softra

Re: Move uvm_pglist* to uvm_page.c

2011-06-24 Thread Thordur Bjornsson
On Thu, Jun 23, 2011 at 07:04:48PM +0100, Owain Ainsworth wrote: > How about this now? > > On Tue, May 31, 2011 at 12:05:04AM +0100, Owain Ainsworth wrote: > > These functions used to be big and complicated, now they are glorified > > wrappers around pmemrange and don't really need their own file

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:54:07PM +0200, Janjaap van Velthooven wrote: > Thordur Bjornsson wrote and mailed: > > On Wed, Jun 22, 2011 at 09:34:55PM +0200, Janjaap van Velthooven wrote: > > > Just a vague idea for the moment; > > > > > > How aboot some mechanis

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:34:55PM +0200, Janjaap van Velthooven wrote: > On Wed, Jun 22, 2011 at 08:12:28PM +0100, Stuart Henderson wrote: > > On 2011/06/22 21:07, Wouter Coene wrote: > > > Also, this is certainly not useless if you have more than a handfull of > > > disks > > > or SAN volumes, o

Re: Identifying disks by name

2011-06-22 Thread Thordur Bjornsson
On Wed, Jun 22, 2011 at 09:07:41PM +0200, Wouter Coene wrote: > On 22 jun 2011, at 20:53, Kenneth R Westerback wrote: > > On Wed, Jun 22, 2011 at 06:48:14PM +0200, Wouter Coene wrote: > >> The patch below builds on the disk UID code to implement disk names. Disk > >> names must match [a-zA-Z0-9_]{1

Re: AVL tree

2011-05-19 Thread Thordur Bjornsson
On Thu, May 19, 2011 at 07:21:21PM +0200, Mike Belopuhov wrote: > On Thu, May 19, 2011 at 7:12 PM, Thordur Bjornsson wrote: > > On Thu, May 19, 2011 at 07:52:44PM +0300, Michael Pounov wrote: > >> Add AVL tree implementation and merge few RB tree related macros. > >> &

Re: AVL tree

2011-05-19 Thread Thordur Bjornsson
On Thu, May 19, 2011 at 07:52:44PM +0300, Michael Pounov wrote: > Add AVL tree implementation and merge few RB tree related macros. > > If you have comments or any claims, please send me feedback > and I will fix them. cool. but tech@ removes attachments, send your diffs inline. I'm assuming you

Re: Filesystem Hierarchy Standard (FHS) and OpenBSD

2011-05-10 Thread Thordur Bjornsson
On Mon, May 09, 2011 at 11:33:27PM -0400, Jeff Licquia wrote: > (Sorry if this isn't the proper list for this discussion. If not, > please point me in the right direction.) This is the proper list. > Despite all the "Linux" in the names above, we're wanting to make > sure that the FHS remains in

Re: vnds considerd harmful.

2011-04-07 Thread Thordur Bjornsson
On Wed, Apr 06, 2011 at 04:25:15PM -0400, Jonathan Thornburg wrote: > In <http://marc.info/?l=openbsd-tech&m=130200205608892&w=1>, > Thordur Bjornsson wrote: > > Now that I've disallowed swapping to vnd's the purpose > > of vnd (vs svnd) is su

merge vfs_conf.c and vfs_init.c

2011-04-05 Thread Thordur Bjornsson
no need to have two tiny files around. stuff everything into vfs_init, it belongs there (along with other stuff, that will get moved soonish). OK ? Index: conf/files === RCS file: /home/thib/cvs/src/sys/conf/files,v retrieving revi

vnds considerd harmful.

2011-04-05 Thread Thordur Bjornsson
Hi, Now that I've disallowed swapping to vnd's the purpose of vnd (vs svnd) is suspect, it serves no purpose other then providing a different way of doing what svnd does (which imo, isn't even better). So, nuke vnds (keep svnds though!). This will make svndXn the same as vndXn etc. The idea is t

Re: drop ICMP redirects if ipforwaring = 1

2011-04-04 Thread Thordur Bjornsson
On Mon, Apr 04, 2011 at 08:24:38PM +0200, Claudio Jeker wrote: > On Mon, Apr 04, 2011 at 10:10:49AM -0700, Matthew Dempsky wrote: > > On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker > > wrote: > > > + if (icmp_rediraccept == 0 || ipforwarding == 1) > > > > Would "ipforwarding != 0" be

tweak for mount.h

2011-04-04 Thread Thordur Bjornsson
o Collapse a few _KERNEL's and move some definitions to allow this. o Expose a few NFSMOUNT stuffs (one I will remove, the other I'm going to use later anyways). o Kill a protection for a forward decleration o Kill __STDC__ protection (which is under _KERNEL). OK ? Index: sys/mount.h

Re: pool_debug is good, but also bad

2011-04-04 Thread Thordur Bjornsson
On Sun, Apr 03, 2011 at 06:38:51PM -0600, Theo de Raadt wrote: > based on a conversation at the bar. > > POOL_DEBUG is expensive. But we really want it because it finds bugs > before they hurt us. The solution to this is to make it simpler to > turn off. > > This diff starts the kernel with pool

Disable BSD4.3 COMPAT

2011-04-04 Thread Thordur Bjornsson
tiny tedu moment of mine, disable COMPAT_43 and keep it so for a few releases and if noone complains, nuke it. OK/Thoughts ? Index: conf/GENERIC === RCS file: /var/cvs/src/sys/conf/GENERIC,v retrieving revision 1.172 diff -u -p -r1.1

Re: no swapping to vnds

2011-04-04 Thread Thordur Bjornsson
On Mon, Apr 04, 2011 at 12:34:17PM +0200, Otto Moerbeek wrote: > On Mon, Apr 04, 2011 at 09:22:41AM +0000, Thordur Bjornsson wrote: > > > Hi, > > > > 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been > >broken since forever. > > 2) Swap

bye bye o43statfs

2011-04-04 Thread Thordur Bjornsson
this one is unused. OK ? Index: sys/mount.h === RCS file: /var/cvs/src/sys/sys/mount.h,v retrieving revision 1.100 diff -u -p -r1.100 mount.h --- sys/mount.h 29 Jun 2010 04:09:32 - 1.100 +++ sys/mount.h 4 Apr 2011 10:28:59

no swapping to vnds

2011-04-04 Thread Thordur Bjornsson
Hi, 1) Swapping to svnds has issues (pagedaemon deadlocks) and has been broken since forever. 2) Swapping to vnds makes no sense, why add another layer when you can just swap to a regular file instead ? so stop supporting swapping to vnds. If this turns out to be kosher I have a diff tested

Re: atascsi dma_alloc() - make atascsi play nicer with bigmem

2011-04-02 Thread Thordur Bjornsson
On Sat, Apr 02, 2011 at 09:15:37AM -0400, Kenneth R Westerback wrote: > Another driver malloc'ing and passing potentially dma unsafe memory > to do i/o into. > > ok? yub > > Ken > > Index: atascsi.c > === > RCS file: /cvs/src/s

remove bufqs from vnds

2011-04-02 Thread Thordur Bjornsson
Hi, So, it doesn't make sense to have a bufq for vnds. The disk that stores the image backing the vnd has it's own bufq ofcourse and what happens is that vnd puts a buf on it's bufq, which is promptly removed when we call vndstart, followed by a call to strategy so the buf ends up almost immedi

Re: netinet6 bread crumbs

2011-04-02 Thread Thordur Bjornsson
On Sat, Apr 02, 2011 at 02:13:45PM +0200, Stefan Sperling wrote: > Feel free to ack or reject these individually. > > > Kill redundant offsetof definitions. All of these files include sys/param.h. Those look fine. > Index: in6.c >

Re: Incorrect exit status from which(1)/whereis(1)

2011-02-15 Thread Thordur Bjornsson
On Tue, Feb 15, 2011 at 05:30:11PM +, Jason McIntyre wrote: > On Mon, Feb 14, 2011 at 11:31:18AM +, David Julio wrote: > > Is the exit status of which(1)/whereis(1) correct? > > > > $ which a b c > > which: a: Command not found > > which: b: Command not found > > which: c: Command not foun

Re: softraid clarification in manpage

2011-01-27 Thread Thordur Bjornsson
On Thu, Jan 27, 2011 at 02:35:54PM -0500, Nick Guenther wrote: > On Thu, Jan 27, 2011 at 9:39 AM, Jason McIntyre wrote: > > On Wed, Jan 26, 2011 at 04:24:07PM -0600, Amit Kulkarni wrote: > >> Hi, > >> > >> I just configured a mirror using softraid, the manpage was extremely > >> helpful. I just co

cut vnd's over to bufqs, again.

2010-12-29 Thread Thordur Bjornsson
hi, so cut vnds over to bufqs. this diff is similar to a diff that was commited, but got backed out after one of the hackathon fiasco's, with a small difference. there is no reason to keep an active count, bufq_peek is enough to figure out if the queue is empty or not. in

Re: yield in long kernel loops

2010-10-14 Thread Thordur Bjornsson
On Wed, Oct 13, 2010 at 08:08:34PM -0400, Ted Unangst wrote: > So it's not a good idea to perform long lasting operations in the kernel. > The scheduler doesn't deal well with it and nobody else gets to run. > > One of those long loops is loading a large table into pf. If you're > lucky, you'l

Re: more assertwaitok() love

2010-10-06 Thread Thordur Bjornsson
On Thu, Sep 30, 2010 at 12:29:54AM +, Thordur Bjornsson wrote: > Hi. > > Try to catch more places where we sleep and are not allowed. > > One thing of note, msleep() is missing in this diff, but there > it is needed to call to sleep_setup routines with the mutex > held,

Re: Slow I/O usb sticks

2010-10-06 Thread Thordur Bjornsson
On Wed, Oct 06, 2010 at 04:06:47PM -0300, Gonzalo L. R. wrote: > Hi guys, > > I have a slow I/O in usb sticks with big files, I use -current with the > last weekend cvs code. > > If I cp a big file in the usb stick take several minutes (~10 minutes of > 175M in a msdos stick, 2 minutes in a ffs

more assertwaitok() love

2010-09-29 Thread Thordur Bjornsson
Hi. Try to catch more places where we sleep and are not allowed. One thing of note, msleep() is missing in this diff, but there it is needed to call to sleep_setup routines with the mutex held, and after we release it we _will_ sleep so a sleep there with another mutex held will be caught by the

Re: de-static uvm_swap

2010-09-24 Thread Thordur Bjornsson
and I'd like to kill these to: Index: uvm_pdaemon.c === RCS file: /cvs/src/sys/uvm/uvm_pdaemon.c,v retrieving revision 1.55 diff -u -p -r1.55 uvm_pdaemon.c --- uvm_pdaemon.c 14 Oct 2009 17:53:30 - 1.55 +++ uvm_pdaemon.

de-static uvm_swap

2010-09-24 Thread Thordur Bjornsson
Hi, hitting some panics coming through the swap code and it is a bit annoying having them not show up in the ddb trace. OK ? Index: uvm/uvm_swap.c === RCS file: /home/cvs/src/sys/uvm/uvm_swap.c,v retrieving revision 1.97

Re: fstab.5: FSTAB_RQ

2010-09-23 Thread Thordur Bjornsson
On Thu, Sep 23, 2010 at 06:36:43PM +0059, Jason McIntyre wrote: > is there a reason why we don;t document FSTAB_RQ? Not one that I can think of. If this works as intended go ahead (it should). > jmc > > Index: fstab.5 > === > RCS fil

Re: Source Overview

2010-04-19 Thread Thordur Bjornsson
> And if you value your sanity, stay out of anything resembling filesystems. This is a lie. Hacking on filesystems, and the VFS layer in general is a very rewarding experince, just ask Bob. NFS for example, has been a source of joy for OpenBSD developers for years! >> 2) Is there something like