Re: [5.0.8] Tag soon

2003-08-18 Thread Kin-Man Chung
Remy, I discovered there is a jasper bug that causes wrong Java line numbers to be mapped when codes for invoking tag handlers are generated in separate methods. This would completely screw up JSP debugging, and causes javac error messages to be lost if it happens in the generated method. I have

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
This seems easy enough to implement, so I'll look into it. Concatenating texts is also on my list, and it should help a little in this case. - Kin-man > Date: Mon, 08 Sep 2003 08:46:32 +0200 > From: Torsten Fohrer <[EMAIL PROTECTED]> > Subject: AW: [5.0] JSP performance ... > To: 'Tomcat Develop

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
rat <[EMAIL PROTECTED]> > Subject: Re: AW: [5.0] JSP performance ... > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Kin-Man Chung wrote: > > This seems easy enough to implement, so I'll look into it. Concatenating > > texts is also on my list, and i

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
any value in committing my change. :( -Kin-man > Date: Mon, 08 Sep 2003 15:18:34 -0700 (PDT) > From: Kin-Man Chung <[EMAIL PROTECTED]> > Subject: Re: AW: [5.0] JSP performance ... > To: [EMAIL PROTECTED] > Content-MD5: +Y/z1F8l8EXxpI9LL3yPSA== > > I took a look at o.a.

Re: AW: [5.0] JSP performance ...

2003-09-09 Thread Kin-Man Chung
> Date: Tue, 09 Sep 2003 08:59:51 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: AW: [5.0] JSP performance ... > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Kin-Man Chung wrote: > > I have implemented generating text strings as char a

Re: AW: AW: AW: [5.0] JSP performance ...

2003-09-10 Thread Kin-Man Chung
> Date: Wed, 10 Sep 2003 18:34:40 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: AW: AW: AW: [5.0] JSP performance ... > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Torsten Fohrer wrote: > > > next try > > Yes, the code is better (IMO) and performs a little better also.

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-11 Thread Kin-Man Chung
Yeah, now I remember; but I didn't pay attention then! :-) Anyway, the print methods handle null String and Object, so we are covered. This is true for outputting expressions in text mode; evaluating attributes with expressions is, however, another matter. BTW, I also think it acceptable to rais

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2003-09-15 Thread Kin-Man Chung
Ah, I forgot about the fix that you did in SmapUtil to improve line mappings for template texts. Sorry. :-( But this also shows that tight coupling between Generator and SmapUtil is flagile and error prone. I think it would be a better design if we decouple these two modules somehow. We could

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2003-09-16 Thread Kin-Man Chung
> Date: Mon, 15 Sep 2003 22:57:32 -0700 > From: Eric Carmichael <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties > X-Originating-IP: [64.203.49.21] > To: Tomcat Developers List <[EMAIL PROTECTED]> > X-MIMEOLE:

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2003-09-16 Thread Kin-Man Chung
xpect more use there. -Kin-man > Date: Tue, 16 Sep 2003 19:46:19 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties > To: Tomcat Developers List <[EMAIL PROT

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java

2003-09-22 Thread Kin-Man Chung
SmapStratum.java 31 Aug 2003 03:46:29 - 1.10 > > +++ SmapStratum.java 16 Sep 2003 17:46:43 - 1.11 > > @@ -210,6 +210,12 @@ > > */ > >public void optimizeLineSection() { > > > > +/* Some debugging code > > +for

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-22 Thread Kin-Man Chung
Eric, I forgot about those generated Declartions. It good to have an extra pair of eyes to keep one honest. Thanks. :) I have committed a fix for this and the last you reported. Please see if it works better now. I have noticed that smap now contains lots of overlaps, because of duplications

Re: \<% not handled right?

2003-09-23 Thread Kin-Man Chung
This is a bug. I have committed a fix in Tomcat 5. Thanks for reporting. -Kin-man > Date: Tue, 23 Sep 2003 07:30:29 -0400 > From: Tim Funk <[EMAIL PROTECTED]> > Subject: \<% not handled right? > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Attached is a note from tomcat-user which I thin

Re: cvs commit:jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServletWrapper.java

2002-08-28 Thread Kin-Man Chung
> Date: Wed, 28 Aug 2002 16:41:16 -0700 (PDT) > From: "Craig R. McClanahan" <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java > To: Tomcat Developers List <[EMAIL PROTECTED]> > > > > On 28 Aug 2002 [EMAIL P

Re: JSP Bug

2002-09-09 Thread Kin-Man Chung
This is not a bug. Any %> that appears in an expression bracketed by <% ... %> needs to be escaped as %\> (JSP.2.6). > Date: Mon, 09 Sep 2002 15:17:04 -0400 > From: Stephane Zafirov <[EMAIL PROTECTED]> > Subject: JSP Bug > To: [EMAIL PROTECTED] > > I just wanted to make sure the following bug h

Re: Catalina tester failure on JSP Document Parsing

2002-09-11 Thread Kin-Man Chung
I'd suggest that we remove this test. Jasper 2 and jasper produces different but correct XML view of the JSP document. If the golden file is fixed to pass in TC5, it would then fail in TC4.0. > Date: Wed, 11 Sep 2002 18:10:59 -0400 > From: Steve Downey <[EMAIL PROTECTED]> > Subject: Catalina te

Re: JSR45

2002-09-23 Thread Kin-Man Chung
JSR45 support is already in Tomcat 5, which is yet to be released. You can, however, build it from source and try it out yourself. > Date: Wed, 18 Sep 2002 16:48:00 +0200 > From: Damian Frach <[EMAIL PROTECTED]> > Subject: JSR45 > To: [EMAIL PROTECTED] > > Hi, > > I am a member of the web app

Re: [5.0] Build issue - where is jasper.runtime.el and why is itchecked in as binary ?

2002-09-25 Thread Kin-Man Chung
> Date: Wed, 25 Sep 2002 09:20:16 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: [5.0] Build issue - where is jasper.runtime.el and why is it checked in as binary ? > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Costin Manolache wrote: > > See the subject :-) > > > > I'm

Re: [VOTE] [5.0] Milestones

2002-09-29 Thread Kin-Man Chung
+1 > Date: Sat, 28 Sep 2002 16:12:06 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: [VOTE] [5.0] Milestones > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Hi, > > Now that the first stable releases of Tomcat 4.1 are out (and according > to reports, of good overall quality),

Re: JSP Compilation Issues (Multiple Domains)

2002-09-30 Thread Kin-Man Chung
If you are using JDK javac for compiling the servlet generated by the JSP compiler, then you probably ran into the problem that the javac not being thread-safe. In Tomcat 5 the javac compilation is synchronized, so that the compilation is serialized. Guess that fix is not ported to 4.1.5. :-(

Help! Tomcat problem

2002-10-08 Thread Kin-Man Chung
I got the following exception when I run TC5. I am using xerces-2_0_1. I tried disable xmlValidation, but still have the problem. catalina.sh run Using CATALINA_BASE: /home/kchung/tc/jakarta-tomcat-5/build Using CATALINA_HOME: /home/kchung/tc/jakarta-tomcat-5/build Using CATALINA_TMPDIR: /h

Re: New JSR on Java(TM) Compiler API

2002-10-11 Thread Kin-Man Chung
This is great and is sorely needed. I am all for it! It'd be nice if the new API also include supports for JSR-45 (Debugging Support for Other Languages). For instance, when invoking javac with a smap file, javac should 1) report errors by JSP page source and line numbers, and 2) incoporate t

costin: fix reverted

2002-11-04 Thread Kin-Man Chung
costin, This fix seems to break errorPage handling in JSP, causing the errorPage example to fail, and a couple of JSP watchdog tests too. I have reverted your fix. I have not reverted the tomcat_4_branch. > Date: Thu, 24 Oct 2002 19:18:55 + > From: [EMAIL PROTECTED] > Subject: cvs commit:

Re: costin: fix reverted

2002-11-04 Thread Kin-Man Chung
TP-posting-date: Mon, 4 Nov 2002 22:10:09 + (UTC) > X-Injected-Via-Gmane: http://gmane.org/ > NNTP-posting-host: 64.84.39.162 > > Kin-Man Chung wrote: > > > costin, > > > > This fix seems to break errorPage handling in JSP, causing the errorPage > >

Re: TagHandlerPool doesn't release Tags on reuse

2002-11-11 Thread Kin-Man Chung
According to the JSP 1.2 Spec, the release method is not invoked between tag usages, but is invoked before GC of the tag handler. Therefore it should not be used to reset the tag handler to its initial state; you should do that in doStartTag. See p164 and p166. > Date: Mon, 11 Nov 2002 13:32:31

Re: TagHandlerPool doesn't release Tags on reuse

2002-11-11 Thread Kin-Man Chung
(_jspx_th_tools_simpleCell_0.doEndTag() == > javax.servlet.jsp.tagext.Tag.SKIP_PAGE) > return; > > > example > > If i now reset my tag to a initial state in doStartTag() i haven't any > properties set > > Who call the release method i

[Jasper2] framework for tag optimization

2002-11-22 Thread Kin-Man Chung
I am designing a framework in Jasper for enabling plugins that work closely with Jasper to generate Java codes instead of calls to tag handlers. The main idea is to take take JSTL tags, such as ${i} and generates the Java codes for (int i = 0; i <= 100; i++

Re: [5] Unable to initialize TldLocationsCache: zip file closed

2003-10-07 Thread Kin-Man Chung
I have encountered such message in a number of occasions, usually related to reading a jar file from cache. This is likely a VM bug and the work- around is usually to not use cache after opening a JarURLconnection. The stack trace seems to indicate that this happens when reading web.xml. Did you

[5] IndexOutOfBoundsException from CharChunk

2003-10-08 Thread Kin-Man Chung
I am getting a sporadic IndexOutOfBoundsException and it seems to come from org.apache.tomcat.util.buf.CharChunk.flushBuffer. The trace is Servlet.service() for servlet jsp threw exception java.lang.IndexOutOfBoundsException at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:132)

Re: [5] IndexOutOfBoundsException from CharChunk

2003-10-08 Thread Kin-Man Chung
> Date: Wed, 08 Oct 2003 21:22:07 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: [5] IndexOutOfBoundsException from CharChunk > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Kin-Man Chung wrote: > > > I am getting a sporadic IndexOu

Re: [5] IndexOutOfBoundsException from CharChunk

2003-10-15 Thread Kin-Man Chung
me reason. This turns out to be more elusive that it appears. I might have to give this up as another mystery of the universe. :-) -Kin-man > Date: Wed, 15 Oct 2003 10:36:01 +0200 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: [5] IndexOutOfBoundsException from Cha

Re: [VOTE] New builds

2003-10-29 Thread Kin-Man Chung
> Date: Wed, 29 Oct 2003 11:32:58 +0100 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: [VOTE] New builds > To: Tomcat Developers List <[EMAIL PROTECTED]> > > > Release 4.1.29 as Stable ? > [ ] Yes > [ ] No > > > > Release 5.0.14 as Beta ? > [X] Yes Jasper seems solid. > [ ] No > >

Re: Jasper used for Tomcat 4.0.6

2003-10-30 Thread Kin-Man Chung
The code for Jasper in 4.0.x is in the module jakarta-tomcat-4.0. > Date: Thu, 30 Oct 2003 14:51:13 -0600 > From: Ken Sipe <[EMAIL PROTECTED]> > Subject: Jasper used for Tomcat 4.0.6 > To: [EMAIL PROTECTED] > X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 > Importance: Normal > X-Priorit

Re: Understanding jakarta-tomcat-4.0 cvs source base / jasper

2003-12-15 Thread Kin-Man Chung
The source for Jasper in Tomcat 4.1.29 is from j-t-j/jasper2 with Tomcat_4_branch tag. The head branch is for Tomcat 5. A lot of bugs filed against Tomcat 4.1.x has been fixed in Tomcat 5. Unfortunately I don't have cycles to apply the fixes to 4.1.x. It would be great if someone can do that, an

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
-1. Remy, please reread JSP 2.0 spec, p 1-101,1-102. Bullet .2 of the Semantics section was added to allow for this kind of optimization. Bullet .5 and .6 will be executed ONLY IF the container choose not to issue translation errors. -Kin-man > Date: Mon, 02 Feb 2004 18:18:01 + > From: [EM

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
;ll make people happy... -Kin-man > Date: Mon, 02 Feb 2004 19:41:54 +0100 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java > To: Tomcat Developers List <[EMAIL PROTECTE

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
> Date: Mon, 02 Feb 2004 20:17:29 +0100 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java > To: Tomcat Developers List <[EMAIL PROTECTED]> > > Kin-Man Chung wrote

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/xmlparser ParserUtils.java UTF8Reader.java

2004-09-17 Thread Kin-man Chung
I have no problem getting rid of all those messages, since they are no longer useful. - Kin-man On Fri, 2004-09-17 at 14:23, Amy Roh wrote: > > [EMAIL PROTECTED] wrote: > > > >>amyroh 2004/09/17 14:02:34 > >> > >> Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java > >>

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspWriterImpl.java

2004-03-18 Thread Kin-Man Chung
-1. The patch breaks the spec. According to JSP 2.0 spec, JSP.5.5 (p1-111), "If the page output was unbuffered and anything has been written to it, an attempt to forward the request will result in an IllegalStateException." -Kin-man > Date: Thu, 18 Mar 2004 21:05:17 + > Fr

RE: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspWriterImpl.java

2004-03-18 Thread Kin-Man Chung
immediate > pageContext.forward() on an unbuffered page. My reading of the spec is that this > shouldn't happen. I can't see how this check helps meet the part of the spec you > quoted. > > Am I being stupid and missing the blindingly obvious here? > > Mark >

Re: Tomcat 5.0.20 Issue

2004-03-24 Thread Kin-Man Chung
I think your only valid point is the one about the need to make errorOnUseBeanInvalidClassAttribute be switchable from Jspc main, but we are not bundling jspc scripts anymore, so I didn't feel there is a need for it. Anyway, its value can be set with an ant task. Otherwise, Jasper behaves the sam

Re: Tomcat 5.0.20 Issue

2004-03-30 Thread Kin-Man Chung
asper. -Kin-man > Date: Tue, 30 Mar 2004 08:30:05 -0600 > From: Jess Holle <[EMAIL PROTECTED]> > Subject: Re: Tomcat 5.0.20 Issue > To: Tomcat Developers List <[EMAIL PROTECTED]> > X-OriginalArrivalTime: 30 Mar 2004 14:30:06.0040 (UTC) FILETIME=[7EEF4580:01C41663] > &

Re: Question on 5.0.23

2004-05-05 Thread Kin-Man Chung
Which watchdog is it? Can you send me the other part (tld and tag handler) of it? If the tag is of a TAGDEPENDENT body type, then its body is should not be evaluated. It used to be evaluated in XML syntax, which is wrong and which is what the patch intend to fix. If this is the case, then the g

Re: JSP Compile Hangs

2004-10-20 Thread Kin-man Chung
Please file a report on bugzilla. If you also include a test case (to save me some typing :)), I'll take a look to see where Jasper is spending its time. Did you said it was in commons-el? That'd be bad. -Kin-man On Wed, 2004-10-20 at 00:43, Eric Blenkush wrote: > On Oct 19, 2004, at 10:41 PM,

Re: New TLP draft

2005-04-06 Thread Kin-man Chung
It appears that my name (Kin-man Chung [EMAIL PROTECTED]) has been dropped from the PMC. Hope this is not intentional. :-) On Wed, 2005-04-06 at 05:15, Remy Maucherat wrote: > Hi, > > Here's a new draft with the necessary updates. > > I suppose this needs to be sent to

Re: tag plugin

2005-08-22 Thread Kin-man Chung
The body content of a tag is a runtime entity, and you cannot generally get it during compilation time, since it may contain non-template texts. You need to achieve what you want in another way, such as the use of JSP fragments. -Kin-man On Sat, 2005-08-20 at 00:26, wing lee wrote: > I think it'

Re: tag plugin

2005-08-23 Thread Kin-man Chung
The method generateBody() is meant to "continue to generate codes for body of the tag, as usual". What you want is a method to "generate codes to get the body content", which is certainly doable, but is not currently available. You are welcome to have the first crack at extending the plugin frame

Re: re:tag plugin

2005-08-26 Thread Kin-man Chung
For practical purposes, I don't think you'll gain much using plugins for and , since they are relatively simple, and the overheads for invoking the corresponding tag handlers is relatively minor. You'll probably achieve most benefit if you can provide plugins for them that only handle tags with n

<    1   2