Re: [PATCH 12/12] net: smc911x: Add DM support

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:01 AM Marek Vasut wrote: > > Add support for U-Boot DM and DT probing. Furthermore, build the > SMC911x standalone EEPROM example only for the non-DM case, as it > is not converted yet. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada > --- >

Re: Please pull u-boot-marvell/master (watchdog related)

2020-03-16 Thread Stefan Roese
Hi Tom, On 16.03.20 20:39, Tom Rini wrote: please pull the following watchdog related fixes: BTW, I think you need to check the project settings on your tree and mark it as public. I just checked and the Marvell repo seems to be public already: Project visibility: Public Thanks, Stefan

Re: [tiU20.01 PATCH] configs: am65x_evm_a53: Re order the overlay files

2020-03-16 Thread Lokesh Vutla
On 17/03/20 12:14 PM, Lokesh Vutla wrote: > In case of SPL_LOAD_FIT_APPLY_OVERLAY, overlay files are applied in the > order as specified in overlay structure in board/ti/am65x/evm.c: > - k3-am654-gp.dtbo > - k3-am654-idk.dtbo > - k3-am654-pcie-usb2.dtbo > - k3-am654-pcie-usb3.dtbo > - k3-am654-e

Re: [PATCH 07/12] net: smc911x: Drop weak alias from 32bit accessors

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote: > > These accessors are not overriden by any board, and even if they were, One more nit. overriden -> overridden -- Best Regards Masahiro Yamada

[tiU20.01 PATCH] configs: am65x_evm_a53: Re order the overlay files

2020-03-16 Thread Lokesh Vutla
In case of SPL_LOAD_FIT_APPLY_OVERLAY, overlay files are applied in the order as specified in overlay structure in board/ti/am65x/evm.c: - k3-am654-gp.dtbo - k3-am654-idk.dtbo - k3-am654-pcie-usb2.dtbo - k3-am654-pcie-usb3.dtbo - k3-am654-evm-oldi-lcd1evm.dtbo Since it is peripheral boot and overl

Re: [PATCH 10/12] net: smc911x: Clean up the status handling in smc911x_recv()

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:01 AM Marek Vasut wrote: > > Invest the status handling logic in smc911x_recv(), to make the > function easier to read, no functional change. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada > --- > drivers/net/smc911x.c | 31

Re: [PATCH 07/12] net: smc911x: Drop weak alias from 32bit accessors

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote: > > These accessors are not overriden by any board, and even if they were, > this is something which should be handled via DM now, so remove the > weak alias option. Moreover, drop the inline keyword, as the compiler > can decide better. > > Signe

Re: [PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote: > > Inline all the functions from the header file, as they are not used > outside of the driver or the standalone EEPROM example. Meh for 'static inline' in .c files, but you will rip it off in the next commit. So, the resulted code seems good.

Re: [PATCH 05/12] net: smc911x: Fix potential memleak() in init fail path

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 1:59 AM Marek Vasut wrote: > > Fix memleak in the init fail path, where if allocation or registration > of MDIO bus fails, then ethernet interface is not unregistered and the > private data are not freed, yet the probe function reports a failure. > > Signed-off-by: Marek Va

Re: [PATCH 02/12] net: smc911x: Replace malloc()+memset() with calloc()

2020-03-16 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote: > > Replace combination of malloc()+memset() with calloc() as the behavior > is exactly the same and the amount of code is reduced. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada > --- > drivers/net/smc911x.c | 3 +-

Re: [PATCH 00/12] net: smc911x: Convert to DM

2020-03-16 Thread Masahiro Yamada
Hi Marek, On Mon, Mar 16, 2020 at 1:59 AM Marek Vasut wrote: > > Perform DM conversion of the SMC911x driver. Note that as I do not have > any hardware with this chip, I only compile-tested this conversion. But > it seems Yamada-san has one, so please test. With a quick test on my board, it wor

[U-Boot] Please pull from u-boot-i2c/next

2020-03-16 Thread Heiko Schocher
he Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-i2c.git tags/20200316-for-next for you to fetch changes up to 80e8b8add057d2c947394d9d57fc2dcc7ff886d1: bootcounter: add DM support for memory based bootcounter (2020-0

Re: [PATCH 2/2] misc: i2c_eeprom: store pagesize instead of pagewidth in i2c_eeprom_drv_data

2020-03-16 Thread Heiko Schocher
Hello Masahiro, Am 28.02.2020 um 14:04 schrieb Masahiro Yamada: Associate the pagesize with compatible strings, and copy it to priv->pagesize. This is more straight-forward. Signed-off-by: Masahiro Yamada --- drivers/misc/i2c_eeprom.c | 32 1 file changed,

Re: [PATCH 1/2] misc: i2c_eeprom: remove pagewidth field from i2c_eeprom

2020-03-16 Thread Heiko Schocher
Hello Masahiro, Am 28.02.2020 um 14:04 schrieb Masahiro Yamada: This struct member is not used in any effective way. Remove it. Signed-off-by: Masahiro Yamada --- drivers/misc/i2c_eeprom.c | 8 +++- include/i2c_eeprom.h | 2 -- 2 files changed, 3 insertions(+), 7 deletions(-) A

Re: [PATCH 4/4] i2c: designware_i2c: add 'hs_hcnt' and 'hs_lcnt' for high speed

2020-03-16 Thread Heiko Schocher
Hello Jun Chen, Am 02.03.2020 um 09:58 schrieb Jun Chen: From: Jun Chen Add support for high speed if scl_sda_cfg exist. Signed-off-by: Jun Chen Signed-off-by: Jun Chen --- drivers/i2c/designware_i2c.c | 3 +++ drivers/i2c/designware_i2c.h | 4 2 files changed, 7 insertions(+) A

Re: [PATCH 3/4] i2c: designware_i2c: remove 'has_high_speed'

2020-03-16 Thread Heiko Schocher
Hello Jun Chen, Am 02.03.2020 um 09:58 schrieb Jun Chen: From: Jun Chen Remove 'has_high_speed' config since we can check high speed support from IC_COMP_PARAM_1 register. Signed-off-by: Jun Chen Signed-off-by: Jun Chen --- drivers/i2c/designware_i2c.c | 3 +-- drivers/i2c/designware_i2

Re: [PATCH 2/4] i2c: designware_i2c: check is high speed possible support

2020-03-16 Thread Heiko Schocher
Hello Jun Chen, Am 02.03.2020 um 09:58 schrieb Jun Chen: From: Jun Chen To read IC_COMP_PARAM_1[3:2] to check is high speed possible, and fall back to fast mode if not. Signed-off-by: Jun Chen Signed-off-by: Jun Chen --- drivers/i2c/designware_i2c.c | 10 ++ drivers/i2c/designwa

Re: [PATCH 1/4] i2c: designware_i2c: Fix IC_CON register setting for high speed mode

2020-03-16 Thread Heiko Schocher
Hello Jun Chen, Am 02.03.2020 um 09:58 schrieb Jun Chen: From: Jun Chen IC_CON[2:1] should be 3 for high speed mode Signed-off-by: Jun Chen Signed-off-by: Jun Chen --- drivers/i2c/designware_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-i2c next, thanks

Re: [PATCH 2/2] dm: i2c-gpio: add support for clock stretching

2020-03-16 Thread Heiko Schocher
Hello Michael, Am 07.02.2020 um 17:55 schrieb Michael Auchter: This adds support for clock stretching to the i2c-gpio driver. This is accomplished by switching the GPIO used for the SCL line to an input when it should be driven high, and polling on the SCL line value until it goes high (indicati

Re: [PATCH] doc: i2c: gpio: Document deblock sequence on probe

2020-03-16 Thread Heiko Schocher
Hello Marek, Am 18.02.2020 um 18:24 schrieb Marek Vasut: Document the gpio-i2c deblocking sequence binding. Signed-off-by: Marek Vasut --- doc/device-tree-bindings/i2c/i2c-gpio.txt | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-i2c next, thanks! bye, Heiko -- DENX Software Eng

Re: [PATCH 1/2] dm: i2c-gpio: rework gpio get/set functions

2020-03-16 Thread Heiko Schocher
Hello Michael, Am 07.02.2020 um 17:55 schrieb Michael Auchter: This patch reworks i2c-gpio to make it easier to switch out the implementation of the sda/scl get/set functions. This is in preparation for a patch to conditionally implement clock stretching support. Signed-off-by: Michael Auchter

Re: [PATCH 4/4] i2c: gpio: Run deblock sequence on probe

2020-03-16 Thread Heiko Schocher
Hello Marek, Am 07.02.2020 um 16:57 schrieb Marek Vasut: Add deblock dequence for the I2C bus, needed on some devices. This sequence is issued once, when probing the driver, and is controlled by DT property, "i2c-gpio,deblock". Signed-off-by: Marek Vasut --- drivers/i2c/i2c-gpio.c | 15 +

Re: [PATCH 3/4] i2c: Add option to send start condition after deblocking

2020-03-16 Thread Heiko Schocher
Hello Marek, Am 07.02.2020 um 16:57 schrieb Marek Vasut: Add option to send start condition after deblocking SDA. Signed-off-by: Marek Vasut --- drivers/i2c/i2c-uclass.c | 23 --- include/i2c.h| 4 +++- 2 files changed, 23 insertions(+), 4 deletions(-) Ap

Re: [PATCH 1/4] i2c: Make deblock delay and SCL clock configurable

2020-03-16 Thread Heiko Schocher
Hello Marek, Am 07.02.2020 um 16:57 schrieb Marek Vasut: Make the delay between SCL line changes and the number of SCL clock changes configurable as a parameter of the deblock function. No functional change. Signed-off-by: Marek Vasut --- drivers/i2c/i2c-uclass.c | 21 +++--

Re: [PATCH 2/4] i2c: Export i2c_deblock_gpio_loop()

2020-03-16 Thread Heiko Schocher
Hello Marek, Am 07.02.2020 um 16:57 schrieb Marek Vasut: Export the i2c_deblock_gpio_loop() so it can be used in other places in U-Boot. In particular, this is useful in the GPIO I2C driver, which claims the SDA/SCL GPIOs and thus prevents the i2c_deblock() implementation from claiming the pins

Re: travis build fails for all arm boards

2020-03-16 Thread Heiko Schocher
Hello Tom, Am 16.03.2020 um 19:13 schrieb Tom Rini: On Mon, Mar 16, 2020 at 09:14:15AM +0100, Heiko Schocher wrote: Hello Tom, just started a travis build for i2c next branch, based on origin/next. All arm jobs fail: https://travis-ci.org/github/hsdenx/u-boot-i2c/builds/662944932 because pr

[RFC 09/14] efi_loader: add simple firmware management protocol for FIT image

2020-03-16 Thread AKASHI Takahiro
In this commit, a very simple firmware management protocol driver is implemented. It will take a single FIT image firmware in a capsule and apply the data using an existing update_tftp() interface. To specify a device and location to be updated, CONFIG_EFI_CAPSULE_FIT_INTERFACE, and CONFIG_EFI

[RFC 12/14] cmd: add "efidebug capsule" command

2020-03-16 Thread AKASHI Takahiro
"efidebug capsule" is more or less a debugging utility. efidebug capsule update: invoke UpdateCapsule against data on memory efidebug capsule show: show a header of a capsule efidebug capsule result: dump a capsule result variable Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 234 +++

[RFC 13/14] tools: add mkeficapsule command for UEFI capsule update test

2020-03-16 Thread AKASHI Takahiro
This is a utility mainly for test purpose. mkeficapsule -f: create a FIT image firmware capsule mkeficapsule -v: create a specific test case capsule for variables Having said that, you will be able to customize the code to fit your specific requirements for your platform. Signed-off-by: AKASH

[RFC 11/14] efi_loader: variable: export variables table for runtime access

2020-03-16 Thread AKASHI Takahiro
There are platforms on which OS's won't be able to access UEFI variables at runtime (i.e. after ExitBootServices). With this patch, all the UEFI variables are exported as a configuration table so as to enable retrieving variables' values from the table, and later modifying them via capsule-on-disk

[RFC 14/14] test/py: add efi capsule test

2020-03-16 Thread AKASHI Takahiro
We will have two pytest scenarios for capsule update here. * for firmware update (based on simple firmware management protocol) * for variable update Both can run on sandbox build and gives you some idea about how they should work on production system. Signed-off-by: AKASHI Takahiro --- tes

[RFC 08/14] efi_loader: capsule: support firmware update

2020-03-16 Thread AKASHI Takahiro
A capsule tagged with the guid, EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID, is handled as a firmware update object. What efi_update_capsule() basically does is to load any firmware management protocol (or fmp) drivers contained in a capsule, find out an appropriate fmp driver and then invoke its set_i

[RFC 10/14] efi_loader: capsule: support variable update

2020-03-16 Thread AKASHI Takahiro
See EBBR specification v1.0. A capsule tagged with the guid, EFI_VARIABLE_STORAGE_GUID, will be handled as a variable update object. What efi_update_capsule() basically does is to re-play SetVariable against each variable entry in a capsule. Signed-off-by: AKASHI Takahiro --- include/efi_api.h

[RFC 07/14] efi_loader: capsule: add memory range capsule definitions

2020-03-16 Thread AKASHI Takahiro
Memory range capsule gives us a way to notify that some memory regions should be left untouched across the next reset. See UEFI specification, section 8.5.3. Since how we should handle this kind of capsule is totally up to the system, no implementation will be added in this commit. Signed-off-by:

[RFC 06/14] efi_loader: capsule: add capsule_on_disk support

2020-03-16 Thread AKASHI Takahiro
Capsule data can be loaded into the system either via UpdateCapsule runtime service or files on a file system (of boot device). The latter case is called "capsules on disk", and actual updates will take place at the next boot time. In this commit, we will support capsule on disk mechanism. Please

[RFC 05/14] efi_loader: define UpdateCapsule api

2020-03-16 Thread AKASHI Takahiro
In this commit, skeleton functions for capsule-related API's are added under CONFIG_EFI_CAPSULE_UPDATE configuration. Detailed implementation will be added in the succeeding patches. Signed-off-by: AKASHI Takahiro --- include/efi_api.h| 12 include/efi_loader.h | 11 ++

[RFC 04/14] efi_loader: correct a definition of struct efi_capsule_header

2020-03-16 Thread AKASHI Takahiro
See UEFI specification, section 8.5.3. In addition, the structure, efi_capsule_header, should be "packed" as it is a serialized binary format in a capsule file. Signed-off-by: AKASHI Takahiro --- include/efi_api.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/ef

[RFC 02/14] efi_loader: define System Resource Table macros

2020-03-16 Thread AKASHI Takahiro
Some of those values will be used in an implementation of UEFI firmware management protocol as part of my capsule update patch. Signed-off-by: AKASHI Takahiro --- include/efi_api.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/include/efi_api.h b/include/efi_ap

[RFC 01/14] efi_loader: define OsIndicationsSupported flags

2020-03-16 Thread AKASHI Takahiro
These flags are expected to be set in OsIndicationsSupported variable if corresponding features are supported. See UEFI specification, section 8.5.4. In particular, capsule-related flags will be used in my capsule update patch. Signed-off-by: AKASHI Takahiro --- include/efi_api.h | 11 +

[RFC 03/14] efi_loader: export a couple of protocol related functions

2020-03-16 Thread AKASHI Takahiro
This is a preparatory patch. Those functions will be used in an implementation of UEFI firmware management protocol as part of my capsule update patch. Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 14 ++ lib/efi_loader/efi_boottime.c | 16 2 fil

[RFC 00/14] efi_loader: add capsule update support

2020-03-16 Thread AKASHI Takahiro
Summary === 'UpdateCapsule' is one of runtime services defined in UEFI specification and its aim is to allow a caller to pass information to the firmware. This is mostly used to update firmware binary on devices by instructions from OS. In this patch series, all the related definitions and str

Re: [PATCH 09/12] net: smc911x: Pass around driver private data

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:01 PM Marek Vasut wrote: > > Introduce a private data structure for this driver with embedded > struct eth_device and pass it around. This prepares the driver to > work with both DM and non-DM systems. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro

fdtdec: what is the purpose of the compat_names array

2020-03-16 Thread Rasmus Villemoes
I was running strings(1) on my SPL to see if there was something obvious I could find and compile away. To my surprise, I found strings such as altr,socfpga-dw-mshc altr,socfpga-fpga2hps-bridge altr,socfpga-fpga2sdram0-bridge altr,socfpga-fpga2sdram1-bridge which are of course quickly tracked to

Re: [PATCH 08/12] net: smc911x: Convert IO accessors to {read, write}{w, l}()

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Convert the IO accessors to standard ones instead of using volatile > void pointers, as those do not cover all the bus access details. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 07/12] net: smc911x: Drop weak alias from 32bit accessors

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > These accessors are not overriden by any board, and even if they were, > this is something which should be handled via DM now, so remove the > weak alias option. Moreover, drop the inline keyword, as the compiler > can decide better. > > Sign

Re: [PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Inline all the functions from the header file, as they are not used > outside of the driver or the standalone EEPROM example. > > Note that this does introduce considerable amount of duplication in > the standalone EEPROM example, however tha

Re: [PATCH 05/12] net: smc911x: Fix potential memleak() in init fail path

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 11:59 AM Marek Vasut wrote: > > Fix memleak in the init fail path, where if allocation or registration > of MDIO bus fails, then ethernet interface is not unregistered and the > private data are not freed, yet the probe function reports a failure. > > Signed-off-by: Marek V

Re: [PATCH 02/12] net: smc911x: Replace malloc()+memset() with calloc()

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Replace combination of malloc()+memset() with calloc() as the behavior > is exactly the same and the amount of code is reduced. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 01/12] net: smc911x: Remove pkt_data_{push,pull}

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 11:59 AM Marek Vasut wrote: > > These functions are never used and are likely a pre-DM remnant > from times long past, just remove them. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH v2 23/23] test/py: Allow using buildman to build U-Boot

2020-03-16 Thread Stephen Warren
On 3/15/20 5:43 PM, Simon Glass wrote: > It is a pain to have to set the CROSS_COMPILE environment variable when > using test.py's --build option. It is possible to get this using the -A > option from buildman. But it seems better to just use buildman to do the > build when it is available. > > Ho

[PATCH 0/2] mmc: t210: fix autocal and 400KHz clock

2020-03-16 Thread twarren
From: Tom Warren These two patches contain fixes for two issues found on T210 MMC during Nano bringup. Autocal wasn't being done correctly as per the TRM, and the 375/400KHz MMC card detect clock wasn't using the correct parameters as per the TRM. Tom Warren (2): mmc: t210: Add autocal and

[PATCH 1/2] mmc: t210: Add autocal and tap/trim updates for SDMMC1/3

2020-03-16 Thread twarren
From: Tom Warren As per the T210 TRM, when running at 3.3v, the SDMMC1 tap/trim and autocal values need to be set to condition the signals correctly before talking to the SD-card. This is the same as what's being done in CBoot, but it gets reset when the SDMMC1 HW is soft-reset during SD driver i

[PATCH 2/2] mmc: t210: Fix 'bad' SD-card clock when doing 400KHz card detect

2020-03-16 Thread twarren
From: Tom Warren According to the HW team, for some reason the normal clock select code picks what appears to be a perfectly valid 375KHz SD card clock, based on the CAR clock source and SDMMC1 controller register settings (CAR = 408MHz PLLP0 divided by 68 for 6MHz, then a SD Clock Control regist

Re: [PATCH resend 0/5] spi: mpc8xxx_spi: bug fixes, real ->set_speed and a pseudo-gpio driver

2020-03-16 Thread Rasmus Villemoes
On 11/02/2020 16.20, Rasmus Villemoes wrote: > This is a combination of a single patch and a 4-part series sent > previously [1,2], this time with Jagan on Cc. > > Patch 1 is a convenient pseudo-gpio driver for controlling a single > output signal on mpc830x. Since it's (usually) used as a chip se

Re: [PATCH v2 23/23] test/py: Allow using buildman to build U-Boot

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:43:03PM -0600, Simon Glass wrote: > It is a pain to have to set the CROSS_COMPILE environment variable when > using test.py's --build option. It is possible to get this using the -A > option from buildman. But it seems better to just use buildman to do the > build when i

Re: [PATCH v2 17/23] gitlab/azure: Use -w flag for all test.py builds

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:57PM -0600, Simon Glass wrote: > Avoid needing to know about the internal .bm-work directory, by passing > the -w flag to buildman. > > This is not needed on travis since the -w flag is already used (from a > previous patch). > > Drop the -P flag since this has no e

Re: [PATCH v2 22/23] travis/gitlab/azure: Drop repeated buildman call with test.py

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:43:02PM -0600, Simon Glass wrote: > It does not seem to be necessary to run buildman again to show errors, > since any errors can be shown by the first invocation and there is only > a single board being built. Update this to simplify the code, using the > -e flag to mak

Re: [PATCH v2 20/23] travis/gitlab/azure: Enable test_handoff

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:43:00PM -0600, Simon Glass wrote: > Ensure that this SPL test runs on gitlab. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 18/23] travis/gitlab/azure: Use bash to avoid a_test_which_does_not_exist

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:58PM -0600, Simon Glass wrote: > Bash allows for variables to expand only if non-empty: > > $ var=test > $ echo ${var:+"$var"} > test > $ echo ${var:+"-k $var"} > -k test > $ var= > $ echo ${var:+"-k $var"} > > Use this feat

Re: [PATCH v2 16/23] gitlab/azure: Drop unnecessary if..fi when using test.py

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:56PM -0600, Simon Glass wrote: > Since TEST_PY_BD is always defined we can drop this check. > > This does not affect travis since it has a single, unified script. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signa

Re: [PATCH v2 13/23] travis/gitlab/azure: Use --board buildman flag with test.py

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:53PM -0600, Simon Glass wrote: > The current method of selecting the board to build with test.py is a bit > error-prone, e.g. with "^sandbox$" it actually builds 5 boards (all of > those in the sandbox architecture). > > Use the (newish) --board flag instead, to get

Re: [PATCH v2 15/23] travis/gitlab/azure: Drop the buildman -d flag

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:55PM -0600, Simon Glass wrote: > This has no effect since -S is not given also. Drop it. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 12/23] gitlab/azure: Use the -w option for sandbox_spl

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:52PM -0600, Simon Glass wrote: > Avoid needing to know about the internal .bm-work directory, by passing > the -w flag to buildman. > > This does not affect travis since the previous commit already used the -w > flag. > > Signed-off-by: Simon Glass Reviewed-by: To

Re: [PATCH v2 11/23] travis: Split the building into two parts

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:51PM -0600, Simon Glass wrote: > Buildman is used in two ways: > > - to build a selection of boards (with no testing) > - to build a single board (and run pytest) > > The gitlab and azure scrips do this in separate places, but travis does > not. To aid the refactori

Re: [PATCH v2 10/23] travis: Don't copy files into .bm-work/

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:50PM -0600, Simon Glass wrote: > At present if TEST_PY_BD is empty the script copies various files into a > directory, to no purpose. This happens because UBOOT_TRAVIS_BUILD_DIR is > set before TEST_PY_BD is tested. > > Move the 'if' to fix this. > > Signed-off-by:

[PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

2020-03-16 Thread Rasmus Villemoes
wait_ticks() is only used by the ppc-specific __udelay() function. Having the powerpc version of __udelay implicitly call WATCHDOG_RESET() is inconsistent with other architectures' (and the generic __udelay() in lib/time.c) implementations. It also means a driver cannot use __udelay() as the raw pr

Re: [PATCH v2 19/23] travis/gitlab/azure: Drop the -E flag

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:59PM -0600, Simon Glass wrote: > It doesn't seem to make sense to tell buildman to report warning as errors > (thus ensuring there are no warnings) and then ignore the warnings. > > The simplist thing is to just drop the -E flag. This allows us to drop the > check fo

Re: [PATCH v2 14/23] travis/gitlab/azure: Drop BUILDMAN variable with test.py

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:54PM -0600, Simon Glass wrote: > This is not needed in the test.py part of the config, now since we use the > same name as the pytests. > > Drop BUILDMAN, retaining it only for the 'build' parts of the config, i.e. > where we build multiple boards and don't run any t

[PATCH] powerpc: allow opting out of WATCHDOG_RESET() from timer interrupt

2020-03-16 Thread Rasmus Villemoes
When using CONFIG_(SPL_)WDT, the watchdog_reset function is a lot more complicated than just poking a few SOC-specific registers - it involves accessing all kinds of global data, and if the interrupt happens at the wrong time (say, in the middle of an WATCHDOG_RESET() call from ordinary code), that

Re: [PATCH v2 06/23] buildman: Allow ignoring warnings in the return code

2020-03-16 Thread Tom Rini
On Sun, Mar 15, 2020 at 05:42:46PM -0600, Simon Glass wrote: > Sometimes we don't want to get an error with warnings. Add a -W option to > support this. If buildman detects warnings (and no error) it will return > an exit code of 0 (success). > > Signed-off-by: Simon Glass > --- > > Changes in

[PATCH] mtd: spi-nor-core: call WATCHDOG_RESET() in spi_nor_ready()

2020-03-16 Thread Rasmus Villemoes
I have a board for which doing "sf erase 0x10 0x8" consistently causes the external watchdog circuit to reset the board. Make sure to pet the watchdog during slow operations such as erasing or writing large areas of a spi nor flash. Signed-off-by: Rasmus Villemoes --- drivers/mtd/spi/spi

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 20:55 schrieb Dalon L Westergreen: > > > On Mon, 2020-03-16 at 20:06 +0100, Marek Vasut wrote: >> On 3/16/20 8:04 PM, Simon Goldschmidt wrote: >>> Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: > On 3/12/20

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Dalon L Westergreen
On Mon, 2020-03-16 at 20:06 +0100, Marek Vasut wrote: > On 3/16/20 8:04 PM, Simon Goldschmidt wrote: > > Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: > > > > > > On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: > > > > On 3/12/20 4:54 PM, Dalon L Westergreen wrote: > > > > [...] > >

Re: Please pull u-boot-marvell/master (watchdog related)

2020-03-16 Thread Tom Rini
On Mon, Mar 16, 2020 at 03:23:02PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related fixes: > BTW, I think you need to check the project settings on your tree and mark it as public. Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP si

[PATCH 2/5] t210: do not enable PLLE and UPHY PLL HW PWRSEQ

2020-03-16 Thread twarren
From: JC Kuo This commit removes the programming sequence that enables PLLE and UPHY PLL hardware power sequencers. Per TRM, boot software should enable PLLE and UPHY PLLs in software controlled power-on state and should power down PLL before jumping into kernel or the next stage boot software.

[PATCH 0/5] Misc fixes for Tegra

2020-03-16 Thread twarren
From: Tom Warren These fixes originated on our downstream L4T U-Boot, and include fdt, pinmux, pll and code relocation changes. JC Kuo (1): t210: do not enable PLLE and UPHY PLL HW PWRSEQ Stephen Warren (1): ARM: tegra: rework fdt_serial_tag_setup_one Tom Warren (2): fdt: Fix 'system' co

[PATCH 3/5] ARM: tegra: p2771-0000: enable PIE relocation

2020-03-16 Thread twarren
From: Vishruth U-Boot is configured to build as position independent executable. Enable relocation of RELA section required to work with different load addresses. Signed-off-by: Vishruth Signed-off-by: Tom Warren --- configs/p2771--000_defconfig | 1 + configs/p2771--500_defconfig | 1

[PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one

2020-03-16 Thread twarren
From: Stephen Warren Reword fdt_serial_tag_setup_one() so that the types it uses aren't tied to CONFIG_SERIAL_TAG, and rename the function to better indicate its purpose. This will allow it to be re-used by future board info related code. Signed-off-by: Stephen Warren Signed-off-by: Tom Warren

[PATCH 5/5] ARM: Tegra: Use calc env var feature on all boards

2020-03-16 Thread twarren
From: Tom Warren Large kernels (>32MB) can fail to boot because they overwrite the FDT address, corrupting the DTB. Stephen Warren had created a fix to dynamically adjust the fdt/ramdisk/pxefile/kernel addr vars at boot time for T186, which allows a large kernel to load and boot. This is based o

[PATCH 4/5] fdt: Fix 'system' command

2020-03-16 Thread twarren
From: Tom Warren 'fdt systemsetup' wasn't working, due to the fact that the 'set' command was being parsed in do_fdt() by only testing for the leading 's' instead of "se", which kept the "sys" test further down from executing. Changed to test for "se" instead, now 'fdt systemsetup' works (to test

Re: [PATCH v2 4/4] riscv: Setup reserved-memory node for FU540

2020-03-16 Thread Atish Patra
On Sat, Mar 14, 2020 at 3:18 AM Bin Meng wrote: > > Hi Atish, > > On Sat, Mar 14, 2020 at 8:11 AM Atish Patra wrote: > > > > FU540 uses OF_SEPARATE instead of OF_PRIOR. > > > > Enable OF_BOARD_FIXUP to update the DT with reserved-memory node. > > > > Signed-off-by: Atish Patra > > --- > > board

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Marek Vasut
On 3/16/20 8:09 PM, Simon Goldschmidt wrote: [...] >>> Today, too much >>> configuration is applied at compile time (or when programming SPL to >>> flash at latest) - there's currently no way to switch peripherals to >>> FPGA for one image but not for another, for example. >> >> Yes >> >>> Worse: i

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 20:06 schrieb Marek Vasut: > On 3/16/20 8:04 PM, Simon Goldschmidt wrote: >> Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: >>> >>> >>> On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: On 3/12/20 4:54 PM, Dalon L Westergreen wrote: [...] (thanks for fi

ext4: invalid extent block on imx7

2020-03-16 Thread Jan Kiszka
Hi all, => ls mmc 0:1 /usr/lib/linux-image-4.9.11-1.3.0-dirty CACHE: Misaligned operation at range [bdfff998, bdfffd98] CACHE: Misaligned operation at range [bdfff998, bdfffd98] CACHE: Misaligned operation at range [bdfff998, bdfffd98] CACHE: Misaligned operation at range [bdfff998, bdfffd98] inv

Re: [PATCH v2 3/4] riscv: Provide a mechanism for riscv boards to parse reserved memory

2020-03-16 Thread Atish Patra
On Sat, Mar 14, 2020 at 3:00 AM Bin Meng wrote: > > Hi Atish, > > On Sat, Mar 14, 2020 at 8:54 AM Atish Patra wrote: > > > > On Fri, Mar 13, 2020 at 5:12 PM Atish Patra wrote: > > > > > > In RISC-V, M-mode software can reserve physical memory regions > > > by setting appropriate physical memory

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Marek Vasut
On 3/16/20 8:04 PM, Simon Goldschmidt wrote: > Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: >> >> >> On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: >>> On 3/12/20 4:54 PM, Dalon L Westergreen wrote: >>> [...] >>> >>> (thanks for fixing your mailer :)) >>> > The problem was tha

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: > > > On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: >> On 3/12/20 4:54 PM, Dalon L Westergreen wrote: >> [...] >> >> (thanks for fixing your mailer :)) >> The problem was that this was causing weird sporadic hangs on Ge

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Walter Lozano
Hi Baruch, On 16/3/20 15:11, Baruch Siach wrote: Hi Walter, On Mon, Mar 16, 2020 at 02:53:58PM -0300, Walter Lozano wrote: On 16/3/20 14:25, Baruch Siach wrote: On Mon, Mar 16, 2020 at 02:05:57PM -0300, Walter Lozano wrote: On 16/3/20 13:28, Baruch Siach wrote: On Thu, Mar 12, 2020 at 01:52

Re: travis build fails for all arm boards

2020-03-16 Thread Tom Rini
On Mon, Mar 16, 2020 at 09:14:15AM +0100, Heiko Schocher wrote: > Hello Tom, > > just started a travis build for i2c next branch, based on origin/next. > > All arm jobs fail: > https://travis-ci.org/github/hsdenx/u-boot-i2c/builds/662944932 > > because problems fetching arm toolchain... > > Er

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Baruch Siach
Hi Walter, On Mon, Mar 16, 2020 at 02:53:58PM -0300, Walter Lozano wrote: > On 16/3/20 14:25, Baruch Siach wrote: > > On Mon, Mar 16, 2020 at 02:05:57PM -0300, Walter Lozano wrote: > > > On 16/3/20 13:28, Baruch Siach wrote: > > > > On Thu, Mar 12, 2020 at 01:52:13PM -0300, Walter Lozano wrote: >

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Dalon L Westergreen
On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: > On 3/12/20 4:54 PM, Dalon L Westergreen wrote: > [...] > > (thanks for fixing your mailer :)) > > > > > > > > The problem was that this was causing weird sporadic hangs on > > > > > > > Gen5, > > > > > > > which is why it was removed. So

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Walter Lozano
Hi Baruch, On 16/3/20 14:25, Baruch Siach wrote: Hi Walter On Mon, Mar 16, 2020 at 02:05:57PM -0300, Walter Lozano wrote: On 16/3/20 13:28, Baruch Siach wrote: On Thu, Mar 12, 2020 at 01:52:13PM -0300, Walter Lozano wrote: Thanks for sharing. On 12/3/20 02:02, Baruch Siach wrote: Hi Walter

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Baruch Siach
Hi Walter On Mon, Mar 16, 2020 at 02:05:57PM -0300, Walter Lozano wrote: > On 16/3/20 13:28, Baruch Siach wrote: > > On Thu, Mar 12, 2020 at 01:52:13PM -0300, Walter Lozano wrote: > > > Thanks for sharing. > > > > > > On 12/3/20 02:02, Baruch Siach wrote: > > > > Hi Walter, > > > > > > > > On We

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Walter Lozano
On 16/3/20 13:28, Baruch Siach wrote: Hi Walter, On Thu, Mar 12, 2020 at 01:52:13PM -0300, Walter Lozano wrote: Hi Baruch, Thanks for sharing. On 12/3/20 02:02, Baruch Siach wrote: Hi Walter, On Wed, Mar 11 2020, Walter Lozano wrote: In SPL legacy code only one MMC device is created, bas

Re: [PATCH v2 2/4] mx6cuboxi: customize board_boot_order to access eMMC

2020-03-16 Thread Baruch Siach
Hi Walter, On Thu, Mar 12, 2020 at 01:52:13PM -0300, Walter Lozano wrote: > Hi Baruch, > > Thanks for sharing. > > On 12/3/20 02:02, Baruch Siach wrote: > > Hi Walter, > > > > On Wed, Mar 11 2020, Walter Lozano wrote: > > > In SPL legacy code only one MMC device is created, based on BOOT_CFG >

Re: [PATCH 0/3] watchdog: honour hw_margin_ms property

2020-03-16 Thread Rasmus Villemoes
On 14/03/2020 13.04, Stefan Roese wrote: > On 13.03.20 17:04, Rasmus Villemoes wrote: >> That at least solves half my problems and >> might be useful to others as well. Then I'll have to figure out the >> time-stands-still problem in some other way. > > If its too hard to enable interrupts in SPL

Re: [PATCH 0/4] TI K3 DSP remoteproc fixes/enhancements

2020-03-16 Thread Lokesh Vutla
On 11/03/20 2:35 AM, Suman Anna wrote: > Hi All, > > The following series updates the K3 DSP remoteproc driver to fix couple > of issues, and add the internal memory loading support on C66x DSPs. > Patches are on top of latest master branch. > > Following is the patch summary: > - Patch 1 fix

Re: [PATCH] remoteproc: k3-r5: Fix rproc init failure on Split-mode _only_ devices

2020-03-16 Thread Lokesh Vutla
On 11/03/20 6:54 AM, Suman Anna wrote: > The R5F subsystem/cluster on K3 SoCs can support both LockStep and > Split-modes (superset) or just Split-mode depending on an eFUSE > capability register. The LockStep configuration bit is Read-only > though on Split-mode _only_ devices and as such the S

Re: [PATCH] remoteproc: k3-r5: Fix rproc init failure for Main R5FSS0

2020-03-16 Thread Lokesh Vutla
On 11/03/20 5:04 AM, Suman Anna wrote: > The Main R5FSS0 cluster is also enabled to probe the R5F remoteproc > driver within R5 SPL for booting the Core0 very early. This results > in a ti_sci_power_domain_on failure during the probe from the A72 > U-Boot when "rproc init" is executed at U-Boot

Re: [PATCH 3/3] watchdog: honour hw_margin_ms DT property

2020-03-16 Thread Rasmus Villemoes
On 14/03/2020 12.57, Stefan Roese wrote: > On 13.03.20 17:04, Rasmus Villemoes wrote: >>   int initr_watchdog(void) >>   { >>   u32 timeout = WATCHDOG_TIMEOUT_SECS; >> @@ -36,6 +42,8 @@ int initr_watchdog(void) >>   if (CONFIG_IS_ENABLED(OF_CONTROL)) { >>   timeout = dev_read_u32_de

  1   2   >