Re: board/emulation/qemu-riscv/Kconfig: missing CONFIG_RAM?

2020-11-04 Thread Bin Meng
Hi Heinrich, On Wed, Nov 4, 2020 at 5:14 PM Heinrich Schuchardt wrote: > > Hello Bin, > > why do we have > > imply SPL_RAM_SUPPORT > imply SPL_RAM_DEVICE > > in file board/emulation/qemu-riscv/Kconfig which have no effect because > CONFIG_RAM is not selected by any qemu-riscv*_defconfig? > > Shou

Re: [PATCH v2] mmc: fsl_esdhc_imx: add wait_dat0() support

2020-11-04 Thread Jaehoon Chung
Dear Haibo, On 11/5/20 3:57 PM, haibo.c...@nxp.com wrote: > From: Haibo Chen > > Add wait_dat0() support, upper layer will use this callback. > > Signed-off-by: Haibo Chen Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/fsl_esdhc_imx.c | 15 +++ > 1

Re: [PATCH v2 0/3] allow positional arguments with "run"

2020-11-04 Thread Rasmus Villemoes
On 07/10/2020 09.20, Rasmus Villemoes wrote: > This enables one to use positional arguments $1..$9 in functions > defined in the environment, Tom, can I ask for a decision on these? I know Wolfgang is opposed, and if that counts as a veto, fine, I'd just like to know so these are at least not kep

[PATCH v2] mmc: fsl_esdhc_imx: add wait_dat0() support

2020-11-04 Thread haibo . chen
From: Haibo Chen Add wait_dat0() support, upper layer will use this callback. Signed-off-by: Haibo Chen --- drivers/mmc/fsl_esdhc_imx.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index 22040c67a8..29592d1f2c 10

Re: [PATCH v3 0/3] Various minor patches

2020-11-04 Thread Bin Meng
On Thu, Nov 5, 2020 at 12:59 AM Simon Glass wrote: > > This series contains a number of minor patches collected while completing > the ACPI updates for U-Boot. > > Changes in v3: > - Rebase to master > > Changes in v2: > - Drop patches already applied > - Rebase to master > > Simon Glass (3): >

Re: [PATCH v3 00/30] x86: Allow Coral to boot into Chrome OS

2020-11-04 Thread Bin Meng
On Thu, Nov 5, 2020 at 12:57 AM Simon Glass wrote: > > This series adds various minor features and tweaks to allow Coral to boot > into Chrome OS from U-Boot. > > It relies on three other series which have been recently sent: > >- smbios (u-boot-dm/smbios-working) >- bootm (u-boot-dm/bootm

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Ilias Apalodimas
On Thu, Nov 05, 2020 at 03:27:15AM +0100, Heinrich Schuchardt wrote: > On 11/5/20 1:22 AM, Ilias Apalodimas wrote: > > On Wed, Nov 04, 2020 at 10:59:03PM +0100, Heinrich Schuchardt wrote: > >> On 11/4/20 6:26 PM, Ilias Apalodimas wrote: > >>> Hi Heinrich, > >>> > >>> On Wed, Nov 04, 2020 at 05:50:1

Re: [PATCH v5 13/13] smbios: Drop the unused Kconfig options

2020-11-04 Thread Bin Meng
Hi Simon, On Wed, Nov 4, 2020 at 11:23 PM Simon Glass wrote: > > Now that we can use devicetree to specify this information, drop the old > CONFIG options. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Rename smbios_add_prop_default() to smbios_add_prop() > > Changes in v3: > - Add

Re: [PATCH v5 12/13] x86: galileo: Use devicetree for SMBIOS settings

2020-11-04 Thread Bin Meng
On Wed, Nov 4, 2020 at 11:20 PM Simon Glass wrote: > > Add settings and enable the default sysinfo driver so that these can come > from the device tree. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Move the Kconfig comment into the devicetree > > arch/x86/dts/galileo.dts| 28 +

Re: [PATCH v5 07/13] sysinfo: Provide a default driver to set SMBIOS values

2020-11-04 Thread Bin Meng
Hi Simon, On Wed, Nov 4, 2020 at 11:20 PM Simon Glass wrote: > > Some boards want to specify the manufacturer or product name but do not > need to have their own sysinfo driver. > > Add a default driver which provides a way to specify this SMBIOS > information in the devicetree, without needing a

Re: [PATCH v5 04/13] smbios: Allow properties to come from the device tree

2020-11-04 Thread Bin Meng
On Wed, Nov 4, 2020 at 11:21 PM Simon Glass wrote: > > Support a way to put SMBIOS properties in the device tree. These can be > placed in a 'board' device in an 'smbios' subnode. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Fix "manufactuer" typo > - Fix "Informaiton" typo > > Cha

Re: [PATCH v5 05/13] smbios: Add more properties

2020-11-04 Thread Bin Meng
On Wed, Nov 4, 2020 at 11:22 PM Simon Glass wrote: > > The current tables only support a subset of the available fields defined > by the SMBIOS spec. Add a few more. > > We could use CONFIG_SYS_CPU or CONFIG_SYS_SOC as a default for family, but > the meaning of that value relates more to the whole

Re: [PATCH v5 02/13] doc: Add a binding for sysinfo

2020-11-04 Thread Bin Meng
On Wed, Nov 4, 2020 at 11:20 PM Simon Glass wrote: > > Add a simple binding file for this, so that it is clear what this binding > directory is for. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Fix up the example for the binding > > doc/device-tree-bindings/sysinfo/sysinfo.txt | 1

Re: [PATCH v5 01/13] board: Rename uclass to sysinfo

2020-11-04 Thread Bin Meng
On Wed, Nov 4, 2020 at 11:21 PM Simon Glass wrote: > > This uclass is intended to provide a way to obtain information about a > U-Boot board. But the concept of a U-Boot 'board' is the whole system, > not just one circuit board, meaning that 'board' is something of a > misnomer for this uclass. >

RE: [PATCH v4 3/3] armv8: lx2162aqds: Add support for LX2162AQDS platform

2020-11-04 Thread Meenakshi Aggarwal
Any comments? > -Original Message- > From: Meenakshi Aggarwal > Sent: Thursday, October 29, 2020 7:16 PM > To: u-boot@lists.denx.de; tr...@konsulko.com; Priyanka Jain > > Cc: Varun Sethi ; Meenakshi Aggarwal > ; Ioana Ciornei ; > Qiang Zhao ; Hui Song ; Manish > Tomar ; Vikas Singh > Su

Re: [PATCH v3 1/2] smbios: add parsing API

2020-11-04 Thread Bin Meng
On Tue, Nov 3, 2020 at 10:34 PM Christian Gmeiner wrote: > > Add a very simple API to be able to access SMBIOS strings > like vendor, model and bios version. > > Signed-off-by: Christian Gmeiner > Reviewed-by: Bin Meng > --- > include/smbios.h| 27 + > lib/Kconfig | 5 +

Re: [PATCH v3 2/2] coreboot: make use of smbios parser

2020-11-04 Thread Bin Meng
On Tue, Nov 3, 2020 at 10:34 PM Christian Gmeiner wrote: > > If u-boot gets used as coreboot payload it might be nice to get > vendor, model and bios version from smbios. I am not sure about > the output of all the read information. > > With qemu target for coreboot this could look this: > > CBFS:

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Heinrich Schuchardt
On 11/5/20 1:22 AM, Ilias Apalodimas wrote: > On Wed, Nov 04, 2020 at 10:59:03PM +0100, Heinrich Schuchardt wrote: >> On 11/4/20 6:26 PM, Ilias Apalodimas wrote: >>> Hi Heinrich, >>> >>> On Wed, Nov 04, 2020 at 05:50:16PM +0100, Heinrich Schuchardt wrote: On 04.11.20 16:56, Ilias Apalodimas wr

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Ilias Apalodimas
On Wed, Nov 04, 2020 at 11:09:22PM +0100, Heinrich Schuchardt wrote: > On 11/4/20 10:06 PM, Ilias Apalodimas wrote: > > Hi Heinrich > >>> > > [...] > >>> Why are we using COMMAND_BUFFER_SIZE throughout the TPM code if the > >>> required buffer size for commands and responses can be read from the TP

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Ilias Apalodimas
On Wed, Nov 04, 2020 at 03:02:06PM -0700, Simon Glass wrote: > Hi Ilias, > > On Wed, 4 Nov 2020 at 11:52, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Wed, Nov 04, 2020 at 11:08:42AM -0700, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Wed, 4 Nov 2020 at 06:48, Ilias Apalodimas > >

[PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD

2020-11-04 Thread Heinrich Schuchardt
The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y. Add a build dependency. Signed-off-by: Heinrich Schuchardt --- test/lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/lib/Makefile b/test/lib/Makefile index 98a9abf40e..97c11e35a8 100644

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Ilias Apalodimas
On Wed, Nov 04, 2020 at 10:59:03PM +0100, Heinrich Schuchardt wrote: > On 11/4/20 6:26 PM, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Wed, Nov 04, 2020 at 05:50:16PM +0100, Heinrich Schuchardt wrote: > >> On 04.11.20 16:56, Ilias Apalodimas wrote: > > > > u32 tpm2_get_capability(s

[PATCH 1/1] cmd: CMD_CPU depends on CPU

2020-11-04 Thread Heinrich Schuchardt
Compiling with CONFIG_CMD_CPU=y and CONFIG_CPU=n fails with: aarch64-linux-gnu-ld.bfd: cmd/built-in.o: in function `print_cpu_list': /home/user/u-boot/cmd/cpu.c:34: undefined reference to `cpu_get_desc' aarch64-linux-gnu-ld.bfd: /home/user/u-boot/cmd/cpu.c:39: undefined reference to `cpu_get_info'

Re: [PATCH] dfu: add DFU_SKIP layout concept

2020-11-04 Thread Jaehoon Chung
On 11/4/20 3:17 PM, Minkyu Kang wrote: > Hi, > > On Wed, 4 Nov 2020 at 08:36, Jaehoon Chung wrote: > >> Add DFU_SKIP layout cencept. >> > > "cencept" -> typo?? Will fix. Best Regards, Jaehoon Chung > > >> If layout is "skip", it will be skipped after nothing to do. >> It's useful to suppor

Re: [PATCH v4 1/1] cmd: gpt: add eMMC and GPT support

2020-11-04 Thread Thirupathaiah Annapureddy
On 7/23/2020 5:00 AM, Rayagonda Kokatanur wrote: > From: Corneliu Doban > > Add eMMC and GPT support. > - GPT partition list and command to create the GPT added to u-boot > environment > - eMMC boot commands added to u-boot environment > - new gpt commands (enumarate and setenv) that are use

Re: U-Boot 2020.07 seems confused by valid GPT partition tables

2020-11-04 Thread Tom Rini
On Wed, Nov 04, 2020 at 11:19:47AM -0500, Dennis Clarke wrote: > > I am trying to boot a reasonable qemu instance that was running for > about a dozen hours. I have four qemu raw disk images which have > valid GPT partition labels and filesystem regions therein thus : [snip] > Device 0: QEMU Vir

Re: [PATCH] arch: Move NEEDS_MANUAL_RELOC symbol to Kconfig

2020-11-04 Thread Tom Rini
On Wed, Nov 04, 2020 at 03:33:20PM +0100, Michal Simek wrote: > CONFIG_NEEDS_MANUAL_RELOC macro was out of Kconfig. Move it there to be > able to use compile-time checks to reduce the number of build paths. > > Fixes: f9a882438966 ("dm: core: Convert #ifdef to if() in root.c") for > Microblaze >

Re: [PATCH] mmc: fsl_esdhc_imx: add wait_dat0() support

2020-11-04 Thread Jaehoon Chung
On 11/3/20 6:03 PM, Bough Chen wrote: > >> -Original Message- >> From: Peng Fan >> Sent: 2020年11月3日 16:17 >> To: Jaehoon Chung ; Bough Chen >> ; u-boot@lists.denx.de >> Cc: dl-uboot-imx >> Subject: RE: [PATCH] mmc: fsl_esdhc_imx: add wait_dat0() support >> >>> Subject: Re: [PATCH] mmc: fs

Re: [PATCH v2 01/21] mmc: sdhci: Add helper functions for UHS modes

2020-11-04 Thread Jaehoon Chung
On 11/5/20 4:05 AM, Faiz Abbas wrote: > Jaehoon, > > On 21/10/20 5:08 pm, Jaehoon Chung wrote: >> Hi Faiz, >> >> On 10/16/20 8:08 PM, Faiz Abbas wrote: >>> Add a set_voltage() function which handles the switch from 3.3V to 1.8V >>> for SD card UHS modes. >>> >>> Signed-off-by: Faiz Abbas >>> ---

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Heinrich Schuchardt
On 11/4/20 10:06 PM, Ilias Apalodimas wrote: > Hi Heinrich >>> > [...] >>> Why are we using COMMAND_BUFFER_SIZE throughout the TPM code if the >>> required buffer size for commands and responses can be read from the TPM >>> device? >> >> I think the logic is that 256b is enough for the basic comman

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Simon Glass
Hi Ilias, On Wed, 4 Nov 2020 at 11:52, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, Nov 04, 2020 at 11:08:42AM -0700, Simon Glass wrote: > > Hi Ilias, > > > > On Wed, 4 Nov 2020 at 06:48, Ilias Apalodimas > > wrote: > > > > > > Since U-boot EFI implementation is getting richer it makes sens

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Heinrich Schuchardt
On 11/4/20 6:26 PM, Ilias Apalodimas wrote: > Hi Heinrich, > > On Wed, Nov 04, 2020 at 05:50:16PM +0100, Heinrich Schuchardt wrote: >> On 04.11.20 16:56, Ilias Apalodimas wrote: > > u32 tpm2_get_capability(struct udevice *dev, u32 capability, u32 > property, > - vo

U-Boot 2020.07 seems confused by valid GPT partition tables

2020-11-04 Thread Dennis Clarke
I am trying to boot a reasonable qemu instance that was running for about a dozen hours. I have four qemu raw disk images which have valid GPT partition labels and filesystem regions therein thus : deimos_rv64gc$ ls -lap total 18886740 drwxr-xr-x 7 riscv riscv4096 Nov 3 20:40 ./ drwxr

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-11-04 Thread Alper Nebi Yasak
On 30/10/2020 21:15, Simon Glass wrote: > Hi Alper, > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > wrote: >> What I meant is using pairs of , >> to avoid losing position information of >> compressed entries, but honestly I'm not sure if any of this will be >> necessary. I think the single

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-11-04 Thread Alper Nebi Yasak
On 03/11/2020 18:11, Simon Glass wrote: > Hi Alper, > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > wrote: >> >> On 26/10/2020 22:22, Simon Glass wrote: >>> I've added a few test cases along these lines in v2, and one of them >>> certainly different behaviour. This is good actually since it

[PATCH 1/1] efi_selftest: add tool to download dtb

2020-11-04 Thread Heinrich Schuchardt
For validating the fixed up device tree we need a tool to need to save it to a file. dtbdump.efi copies the configuration table with the device tree to a file on the same partition from which dtbdump.efi was invoked. The file name can be entered on the console. Signed-off-by: Heinrich Schuchardt

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-04 Thread Etienne Carriere
Hi Alex, On Wed, 4 Nov 2020 at 20:55, Alex G. wrote: > > > > On 11/4/20 1:07 AM, Etienne Carriere wrote: > > On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: > >> > >> On 10/30/20 3:28 AM, Etienne Carriere wrote: > >>> On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: > > On 9/30/20 6:03 PM, Al

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Ilias Apalodimas
Hi Heinrich > > [...] > > Why are we using COMMAND_BUFFER_SIZE throughout the TPM code if the > > required buffer size for commands and responses can be read from the TPM > > device? > > I think the logic is that 256b is enough for the basic commands we needed. > I can change that here. Get the

RE: [PATCH v5 1/2] arm: rmobile: Add RZ/G2[HMNE] SoC support

2020-11-04 Thread Biju Das
Hi Marek, > On 11/3/20 11:06 AM, Biju Das wrote: > > Hi Marek, > > Hi, > > [...] > > >>> On the next version, I will send Renesas SoC identification driver, > >>> which supports caching family type which can be used to provide > >>> unique > >> identification for CPU type. > >> > >> Please mak

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-04 Thread Alex G.
On 11/4/20 1:07 AM, Etienne Carriere wrote: On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: On 10/30/20 3:28 AM, Etienne Carriere wrote: On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: On 9/30/20 6:03 PM, Alex G. wrote: Hi I'm trying to wrap my head around the purpose of the following lines

Re: [RESEND PATCH 1/3] pinctrl: renesas: Drop unused members from struct sh_pfc_pinctrl

2020-11-04 Thread Marek Vasut
On 11/4/20 6:27 PM, Lad Prabhakar wrote: Drop unused members from struct sh_pfc_pinctrl. Applied, thanks.

Re: [PATCH v5 1/2] arm: rmobile: Add RZ/G2[HMNE] SoC support

2020-11-04 Thread Marek Vasut
On 11/3/20 11:06 AM, Biju Das wrote: Hi Marek, Hi, [...] On the next version, I will send Renesas SoC identification driver, which supports caching family type which can be used to provide unique identification for CPU type. Please make sure to check it on RCar2 as well, those use SPL and

Re: [RESEND PATCH 2/3] pinctrl: renesas: Make sure the pin type is updated after setting the MUX

2020-11-04 Thread Marek Vasut
On 11/4/20 6:27 PM, Lad Prabhakar wrote: Update pin type after every successful call to sh_pfc_config_mux(). This fixes pin functionality from being overwritten. Can you please provide more details about the problem you are fixing here ? What is the problem ? What triggers it ?

Re: [PATCH v2 01/21] mmc: sdhci: Add helper functions for UHS modes

2020-11-04 Thread Faiz Abbas
Jaehoon, On 21/10/20 5:08 pm, Jaehoon Chung wrote: > Hi Faiz, > > On 10/16/20 8:08 PM, Faiz Abbas wrote: >> Add a set_voltage() function which handles the switch from 3.3V to 1.8V >> for SD card UHS modes. >> >> Signed-off-by: Faiz Abbas >> --- >> drivers/mmc/sdhci.c | 51 ++

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Ilias Apalodimas
Hi Simon, On Wed, Nov 04, 2020 at 11:08:42AM -0700, Simon Glass wrote: > Hi Ilias, > > On Wed, 4 Nov 2020 at 06:48, Ilias Apalodimas > wrote: > > > > Since U-boot EFI implementation is getting richer it makes sense to > > add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM >

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Simon Glass
Hi Ilias, On Wed, 4 Nov 2020 at 06:48, Ilias Apalodimas wrote: > > Since U-boot EFI implementation is getting richer it makes sense to > add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM > available on the device. > > This is the initial implementation of the protocol which o

Re: [PATCH v3 1/3] x86: zimage: Add a little more logging

2020-11-04 Thread Igor Opaniuk
On Wed, Nov 4, 2020 at 7:08 PM Simon Glass wrote: > > Add logging for each part of the boot process, using a new > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > (no changes since v1) > > arch/x86/lib/zimage.c | 6 ++ > common/log.c | 1 + > include/log.h |

Re: [PATCH v3 3/3] x86: zimage: Quieten down the zimage boot process

2020-11-04 Thread Igor Opaniuk
On Wed, Nov 4, 2020 at 7:07 PM Simon Glass wrote: > > Much of the output is not very useful. The bootm command is quite a bit > quieter. Convert some output to use log_debug(). > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: > - Rebase to master > > Changes in v2:

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Ilias Apalodimas
Hi Heinrich [...] > > +#define TPM2_NUM_PCR_BANKS 16 > > + > > +/* Table 22 — Definition of (UINT32) TPM_CAP Constants */ > > +#define TPM_CAP_FIRST 0xU > > +#define TPM_CAP_ALGS0xU > > +#define TPM_CAP_HANDLES 0x0001U > > +#define TPM_CAP_COMM

[RESEND PATCH 2/3] pinctrl: renesas: Make sure the pin type is updated after setting the MUX

2020-11-04 Thread Lad Prabhakar
Update pin type after every successful call to sh_pfc_config_mux(). This fixes pin functionality from being overwritten. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a

[RESEND PATCH 3/3] pinctrl: renesas: Implement get_pin_muxing() callback

2020-11-04 Thread Lad Prabhakar
Implement get_pin_muxing() callback so that pinmux status command can be used on Renesas platforms. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/pinctrl/renesas/p

[RESEND PATCH 0/3] pinctrl: renesas: trivial fixes and enhancements

2020-11-04 Thread Lad Prabhakar
Hi All, This patch series includes trivial fixes and enhancements to renesas pfc driver. This is exactly the same series posted earlier [1]. [1] https://patchwork.ozlabs.org/project/uboot/list/?series=203651 Cheers, Prabhakar Lad Prabhakar (3): pinctrl: renesas: Drop unused members from stru

[RESEND PATCH 1/3] pinctrl: renesas: Drop unused members from struct sh_pfc_pinctrl

2020-11-04 Thread Lad Prabhakar
Drop unused members from struct sh_pfc_pinctrl. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/pinctrl/renesas/pfc.c b/drivers/pinctrl/renesas/pfc.c index db0fa9b728..fb811a95bc 100644 --- a/dri

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Ilias Apalodimas
Hi Heinrich, On Wed, Nov 04, 2020 at 05:50:16PM +0100, Heinrich Schuchardt wrote: > On 04.11.20 16:56, Ilias Apalodimas wrote: > >>> > >>> u32 tpm2_get_capability(struct udevice *dev, u32 capability, u32 > >>> property, > >>> - void *buf, size_t prop_count) > >>> +

[PATCH v3 1/3] x86: zimage: Add a little more logging

2020-11-04 Thread Simon Glass
Add logging for each part of the boot process, using a new Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/zimage.c | 6 ++ common/log.c | 1 + include/log.h | 1 + 3 files changed, 8 insertions(+) diff --git a/arch/x86/lib/zimage.

[PATCH v3 2/3] x86: zimage: Sanity-check the kernel version before printing it

2020-11-04 Thread Simon Glass
With Chrome OS the kernel setup block is stored in a separate place from the kernel, so it is not possible to access the kernel version string. At present, garbage is printed. Add a sanity check to avoid this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x8

[PATCH v3 3/3] x86: zimage: Quieten down the zimage boot process

2020-11-04 Thread Simon Glass
Much of the output is not very useful. The bootm command is quite a bit quieter. Convert some output to use log_debug(). Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: - Rebase to master Changes in v2: - Drop patches already applied - Rebase to master arch/x86/lib/zimage

[PATCH v3 28/30] x86: acpi: Don't show the UART address by default

2020-11-04 Thread Simon Glass
This is useful when using Linux's earlycon since the MMIO address must be provided on some platforms, e.g.: earlycon=uart8250,mmio32,0xddffc000,115200n8 However this is only for debugging, so don't show it by default. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v

[PATCH v3 23/30] x86: Set up Chrome OS to boot into developer mode

2020-11-04 Thread Simon Glass
Set up a few fields necessarily to make Chrome OS boot without showing a firmware error. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/apollolake/acpi.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/ar

[PATCH v3 0/3] Various minor patches

2020-11-04 Thread Simon Glass
This series contains a number of minor patches collected while completing the ACPI updates for U-Boot. Changes in v3: - Rebase to master Changes in v2: - Drop patches already applied - Rebase to master Simon Glass (3): x86: zimage: Add a little more logging x86: zimage: Sanity-check the kern

[PATCH v3 25/30] x86: fsp: Convert fsp_dram to use log_debug()

2020-11-04 Thread Simon Glass
Use log_debug() instead of debug() in this file, to enable the extra features. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/fsp2/fsp_dram.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/x86/lib/fsp2/fsp_dram.c b/arc

[PATCH v3 30/30] x86: fsp: Adjust calculations for MTRR range and DRAM top

2020-11-04 Thread Simon Glass
At present the top of available DRAM is the same as the top of the range of the low-memory MTRR. In fact, U-Boot is allowed to use memory up until the start of the FSP reserved memory. Use that value for low_end, since it makes more memory available. Keep the same calculation as before for mtrr_t

[PATCH v3 24/30] x86: Boot coral into Chrome OS by default

2020-11-04 Thread Simon Glass
Add a script to boot Chrome OS from the internal MMC. This involved adding a few commands and options. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) configs/chromebook_coral_defconfig | 10 +++--- include/configs/chromebook_coral.h | 9 - 2 files chan

[PATCH v3 26/30] x86: Silence some logging statements

2020-11-04 Thread Simon Glass
Quite a few log_info() calls are included in the x86 code which should use log_debug() instead. Convert them to reduce unwanted output. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/apollolake/fsp_s.c| 8 arch/x86/cpu/intel_common

[PATCH v3 29/30] x86: pinctrl: Silence the warning when a pin is not found

2020-11-04 Thread Simon Glass
This does not necessarily indicate a problem, since some pins are optional. Let the caller show an error if necessary. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- (no changes since v1) drivers/pinctrl/intel/pinctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 22/30] x86: Use CONFIG_CHROMEOS_VBOOT for verified boot

2020-11-04 Thread Simon Glass
At present CONFIG_CHROMEOS is used to determine whether verified boot is in use. The code to implement that is not in U-Boot mainline. However, it is useful to be able to boot a Chromebook in developer mode in U-Boot mainline without needing the verified boot code. To allow this, use CONFIG_CHROM

[PATCH v3 13/30] x86: nhlt: Correct output of bytes and 16-bit data

2020-11-04 Thread Simon Glass
At present these functions are incorrect. Fix them and add some logging and checking to avoid future problems. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: - Correct printf specifier for debug lines arch/x86/lib/acpi_nhlt.c | 13 ++--- 1 file changed, 10 inserti

[PATCH v3 27/30] x86: acpi: Include the TPMv1 table only if needed

2020-11-04 Thread Simon Glass
This table is not needed if a v2 TPM is in use. Add a condition to avoid adding it when not needed. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/acpi_table.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/arc

[PATCH v3 20/30] acpi: Don't reset the tables with every new generation

2020-11-04 Thread Simon Glass
At present if SSDT and DSDT code is created, only the latter is retained for examination by the 'acpi items' command. Fix this by only resetting the list when explicitly requested. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/acpi_table.c | 1 + dri

[PATCH v3 21/30] x86: Define the Chrome OS GNVS region

2020-11-04 Thread Simon Glass
It is not possible to boot Chrome OS properly without passing some basic information from U-Boot. This applies even if verified boot is not being used. Add a structure definition for this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Rename struct

[PATCH v3 10/30] x86: coral: Correct max98357 file

2020-11-04 Thread Simon Glass
This somehow ended up as an empty file. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) .../max98357-render-2ch-48khz-24b.dat | Bin 0 -> 116 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/board/google/chromebook_coral/max98357-render-2ch-48khz-24b

[PATCH v3 19/30] x86: acpi: Put the generated code first in DSDT

2020-11-04 Thread Simon Glass
The current implementation for DSDT tables is not correct for the case where there is generated code, as the length ends up being incorrect. Also, we want the generated code to go first in the table. Rewrite this piece to correct these problems. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

[PATCH v3 16/30] x86: sound: Correct error handling

2020-11-04 Thread Simon Glass
A few functions have changed to return pin numbers or I2C addresses. The error checking for some of the callers is therefore wrong. Fix them. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) drivers/sound/da7219.c| 4 ++-- drivers/sound/max98357a.c | 2 +- 2 file

[PATCH v3 18/30] x86: acpi: Allow the SSDT to be empty

2020-11-04 Thread Simon Glass
If there is nothing in the SSDT we should not include it in the tables. Update the implementation to check this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/acpi_table.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-)

[PATCH v3 15/30] x86: Show the interrupt pointer with 'irqinfo'

2020-11-04 Thread Simon Glass
It is useful for this command to show the address of the interrupt table. Add support for this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/i386/interrupt.c| 14 +++--- arch/x86/include/asm/interrupt.h | 17 + arch/x86/li

[PATCH v3 14/30] x86: nhlt: Fix a few bugs in the table generation

2020-11-04 Thread Simon Glass
At present these tables do not have the correct header, and there is an occasional incorrect value due to uninited data. Fix these bugs. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/acpi_nhlt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH v3 09/30] x86: Add SMBIOS info for Coral

2020-11-04 Thread Simon Glass
This is required by Chrome OS so that the audio and other unibuild features work correctly. Add it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/dts/chromebook_coral.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/x86/dts/chromebook_

[PATCH v3 17/30] acpi: Correct reset handling in acpi_device_add_power_res()

2020-11-04 Thread Simon Glass
If there is no reset line, this still emits ACPI code for the reset GPIO. Fix it by updating the check. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) lib/acpi/acpi_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/acpi/acpi_device.c

[PATCH v3 08/30] x86: coral: Drop the duplicate PCIe settings

2020-11-04 Thread Simon Glass
These settings are included twice. The second lot are correct, so drop the others. Signed-off-by: Simon Glass Reported-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/dts/chromebook_coral.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/dts/chro

[PATCH v3 11/30] x86: Use if instead of #ifdef in write_tables()

2020-11-04 Thread Simon Glass
Use if() to remove the extra build path in this code. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/tables.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/x86/lib/tables.c b/arch/x86/

[PATCH v3 12/30] x86: Allow putting some tables in the bloblist

2020-11-04 Thread Simon Glass
At present all tables are placed starting at address f in memory, and can be up to 64KB in size. If the tables are very large, this may not provide enough space. Also if the tables point to other tables (such as console log or a ramoops area) then we must allocate other memory anyway. The blo

[PATCH v3 03/30] x86: Add a layout for Chrome OS verified boot

2020-11-04 Thread Simon Glass
Add definitions for part of the vboot context used with verified boot. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Convert spaces to tabs for consistency arch/x86/include/asm/acpi/vbnv_layout.h | 38 + 1 file changed, 38

[PATCH v3 07/30] x86: Don't bother clearing global NVS

2020-11-04 Thread Simon Glass
The bloblist guarantees that blobs are zeroed so there is no need to do an additional memset(). Drop it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/intel_common/acpi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/cpu/intel_common/acp

[PATCH v3 02/30] x86: apl: Add core init for the SoC

2020-11-04 Thread Simon Glass
Set up MSRs required for Apollo Lake. This enables Linux to use the timers correctly. Also write the fixed MSRs for this platform. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Rename update_fixed_mtrss() to update_fixed_mtrrs() - Add comments to e

[PATCH v3 06/30] x86: acpi: Store the ACPI context in global_data

2020-11-04 Thread Simon Glass
At present we create the ACPI context but then drop it after generation of tables is complete. This is annoying because we have to then search for tables later. To fix this, allocate the context and store it in global_data. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: -

[PATCH v3 01/30] Add an assembly guard around linux/bitops.h

2020-11-04 Thread Simon Glass
This file can be included by any header but it includes C code. Guard it to avoid errors when compiling ASL, etc. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) include/linux/bitops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/l

[PATCH v3 00/30] x86: Allow Coral to boot into Chrome OS

2020-11-04 Thread Simon Glass
This series adds various minor features and tweaks to allow Coral to boot into Chrome OS from U-Boot. It relies on three other series which have been recently sent: - smbios (u-boot-dm/smbios-working) - bootm (u-boot-dm/bootm-working) - misca (u-boot-dm/misca-working) This should provid

[PATCH v3 04/30] x86: Add support for private files

2020-11-04 Thread Simon Glass
Some boards need to include binary data into the image for use during the boot process. Add a node for these. An example is the audio-codec configuration used by some audio drivers on Intel platforms. If no private files are provided, they will be omitted. Signed-off-by: Simon Glass Reviewed-by:

[PATCH v3 05/30] x86: Allow writing tables to fail

2020-11-04 Thread Simon Glass
At present write_tables() can fail but does not report this problem to its caller. Fix this by changing the return type. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Use log_err() to report error arch/x86/cpu/cpu.c| 9 - arch

Re: [PATCH 1/2] tpm: Make response length of tpm2_get_capability() configurable

2020-11-04 Thread Heinrich Schuchardt
On 04.11.20 16:56, Ilias Apalodimas wrote: > Hi Heinrich, > > [...] >>> +++ b/lib/tpm-v2.c >>> @@ -161,7 +161,7 @@ u32 tpm2_pcr_read(struct udevice *dev, u32 idx, >>> unsigned int idx_min_sz, >>> } >>> >>> u32 tpm2_get_capability(struct udevice *dev, u32 capability, u32 property, >>> -

Re: [PATCH 2/2] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-04 Thread Heinrich Schuchardt
On 04.11.20 14:47, Ilias Apalodimas wrote: > Since U-boot EFI implementation is getting richer it makes sense to > add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM > available on the device. > > This is the initial implementation of the protocol which only adds > support for G

[PATCH] net: e1000: implement eth_write_hwaddr for DM_ETH

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Implement programming MAC address to the hardware also for device model configuration. Fixes: b565b18a294f ("board: ge: bx50v3: Enable DM for PCI and ethernet") Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- drivers/net/e1000.c | 17 ++--- 1 file changed

Re: [PATCH v4 05/13] smbios: Add more properties

2020-11-04 Thread Simon Glass
Hi Bin, On Tue, 3 Nov 2020 at 01:40, Bin Meng wrote: > > Hi Simon, > > On Thu, Oct 22, 2020 at 10:20 PM Simon Glass wrote: > > > > The current tables only support a subset of the available fields defined > > by the SMBIOS spec. Add a few more. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [PATCH v2 03/30] x86: Add a layout for Chrome OS verified boot

2020-11-04 Thread Simon Glass
Hi Bin, On Tue, 3 Nov 2020 at 00:47, Bin Meng wrote: > > Hi Simon, > > On Thu, Oct 22, 2020 at 11:03 AM Simon Glass wrote: > > > > Add definitions for part of the vboot context used with verified boot. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: > > - Convert tabs to space

[PATCH 9/9] board: ge: bx50v3: check b850v3 power management watchdog

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Set `bootcause' from b850v3 power management watchdog status. Boot cause "REVERT" is no longer used, remove it. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c| 17 + include/configs/ge_bx50v3.h | 4 +--- 2 files changed

[PATCH 7/9] board: ge: bx50v3: reduce magic numbers

2020-11-04 Thread Sebastian Reichel
Use VPD product ID instead of confidx, so that we can easily reuse the product ID defines and avoid some magic numbers. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/board/ge/bx50v3/

[PATCH 4/9] board: ge: common: vpd: fix name

2020-11-04 Thread Sebastian Reichel
Commit f692b479f02d changed the VPD partition name from "vpd" to "vpd@0". Fix the VPD reader code to use the new name, so that the VPD code keeps working. Fixes: f692b479f02d ("i2c: eeprom: Use reg property instead of offset and size") Signed-off-by: Sebastian Reichel --- board/ge/common/vpd_rea

[PATCH 0/9] GE Board cleanups

2020-11-04 Thread Sebastian Reichel
Hi, This series contains a collection of cleanups and fixes for the GE boards. They are mostly independent patches, but all of them just touch the GE boards so I grouped them together: PATCH 1-3: Update/Create MAINTAINERS files for all GE boards PATCH 4: Fix regression due to recent device tree c

[PATCH 3/9] board: ge: b1x5v2: Add MAINTAINERS

2020-11-04 Thread Sebastian Reichel
Introduce maintainers file for the GE B1x5 board. Cc: Huan 'Kitty' Wang Cc: Ian Ray Signed-off-by: Sebastian Reichel --- board/ge/b1x5v2/MAINTAINERS | 9 + 1 file changed, 9 insertions(+) create mode 100644 board/ge/b1x5v2/MAINTAINERS diff --git a/board/ge/b1x5v2/MAINTAINERS b/board/

[PATCH 5/9] board: ge: bx50v3: correct CONFIG_CMD_NFS

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Fix typo in NFS command configuration check. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- include/configs/ge_bx50v3.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h index 4fdc2b6596

  1   2   >