, Since TI doesn't have access to the customer key it
cannot have a component that is signed by customer key.
Hence, it's left as part of binman to be signed and packaged.
Acked-by: Neha Malcom Francis
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33
documentation in each soc.
* Reword the TIFS Stub documentation slightly to show that DM can be
built by customers and is open source.
Link to v5:
https://lore.kernel.org/all/20240705164833.2386549-1-d-g...@ti.com/
Dhruva Gole (6):
MAINTAINERS: Include the TI docs under ARM TI
doc: ti: k3
* Include the actual common documentation about the TIFS Stub and role
it plays to enable Low Power Modes in the platform.
* Add the AM62x boot flow to show at which point the TIFS Stub actually
gets loaded.
* Mention the TIFS Stub in the TISPL image format.
Signed-off-by: Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low
power mode s/w ARCH is also similar in the way that they make use of the
TIFS Stub, update their documentation to show where TIFS Stub is.
Signed-off-by: Dhruva Gole
---
doc/board/ti/am62ax_sk.rst |4
the firmware
documentation chunks. This will make it easier to include them one by
one wherever applicable
Signed-off-by: Dhruva Gole
---
doc/board/ti/am62ax_sk.rst| 4 +++
doc/board/ti/am62px_sk.rst| 4 +++
doc/board/ti/am62x_sk.rst | 4 +++
doc/board/ti/k3.rst
Use the new boot_firmwares labels that help make documentation more
specific as to which firmwares are used in which devices
Signed-off-by: Dhruva Gole
---
doc/board/beagle/j721e_beagleboneai64.rst | 4
doc/board/phytec/phycore-am62x.rst| 4
doc/board/phytec/phycore-am64x.rst
Add entry for the TI boards documentation under ARM TI
Signed-off-by: Dhruva Gole
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 19ca57d200b9..23246414d6f4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -732,6 +732,7 @@ F: arch/arm/mach-omap2
On Jul 17, 2024 at 13:49:07 -0500, Nishanth Menon wrote:
> On 22:18-20240705, Dhruva Gole wrote:
> > This series includes the binman related changes required to package TIFS
> > Stub to support Low Power Modes on BeaglePlay.
> > It also documents the boot flow and tispl packag
On Jul 17, 2024 at 13:47:19 -0500, Nishanth Menon wrote:
> On 22:18-20240705, Dhruva Gole wrote:
> > Add documentation to briefly explain the role of TIFS Stub in relevant
> > K3 SoC's.
> > This also sheds light on why TIFS Stub isn't package with the DM firmware
> >
Add entry for the TI boards documentation under ARM TI
Signed-off-by: Dhruva Gole
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6b32a6d94644..da730c6e4840 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -733,6 +733,7 @@ F: arch/arm/mach-omap2
Add documentation to briefly explain the role of TIFS Stub in relevant
K3 SoC's.
This also sheds light on why TIFS Stub isn't package with the DM firmware
itself.
Signed-off-by: Dhruva Gole
---
doc/board/ti/k3.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/board/ti/k3
Since AM62x, AM62P and AM62A all use similar boot flows and their low
power mode s/w ARCH is also similar in the way that they make use of the
TIFS Stub, update their documentation to show where TIFS Stub is.
Signed-off-by: Dhruva Gole
---
doc/board/ti/am62ax_sk.rst | 4 ++--
doc/board/ti
Mention the TIFS Stub in the TISP image format
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 2 +-
doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 +
2 files changed, 354 insertions(+), 1 deletion(-)
create mode 100644 doc/board/ti/img
Add the AM62x boot flow to show at which point the TIFS Stub actually
gets loaded.
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst |2 +-
doc/board/ti/img/boot_diagram_am62.svg | 1983
2 files changed, 1984 insertions(+), 1 deletion(-)
create
, Since TI doesn't have access to the customer key it
cannot have a component that is signed by customer key.
Hence, it's left as part of binman to be signed and packaged.
Acked-by: Neha Malcom Francis
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33
in DM.
Link to previous series:
https://lore.kernel.org/u-boot/20240704084207.2211801-1-d-g...@ti.com/
[1] https://lore.kernel.org/u-boot/20240705151753.7v3geqkupqu673x3@ambiance/
Thanks for the explanation given in [1] Sebin,
Cc: Sebin Francis
Dhruva Gole (6):
arm: dts: k3-am625-beagleplay
On Jul 05, 2024 at 10:20:21 +0530, Chintan Vankar wrote:
> Initialize DRAM size in SPL stage since networking requires DDR
> to be initialized.
>
> Signed-off-by: Kishon Vijay Abraham I
> Signed-off-by: Chintan Vankar
> ---
>
Reviewed-by: Dhruva Gole
Best regards,
On Jul 02, 2024 at 22:42:01 -0700, Daniel Schultz wrote:
> Use our common environment file to implement MMC boot.
>
> Signed-off-by: Daniel Schultz
> ---
Reviewed-by: Dhruva Gole
> board/phytec/phycore_am62x/phycore_am62x.env | 11 +--
> 1 file changed, 1 insertio
Add entry for the TI boards documentation under ARM TI
Signed-off-by: Dhruva Gole
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6b32a6d94644..da730c6e4840 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -733,6 +733,7 @@ F: arch/arm/mach-omap2
Add documentation to briefly explain the role of TIFS Stub in relevant
K3 SoC's.
Signed-off-by: Dhruva Gole
---
doc/board/ti/k3.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst
index 67b066a07d3a..2f63852b3801 100644
--- a/doc/board/ti/k3
Since AM62x, AM62P and AM62A all use similar boot flows and their low
power mode s/w ARCH is also similar in the way that they make use of the
TIFS Stub, update their documentation to show where TIFS Stub is.
Signed-off-by: Dhruva Gole
---
doc/board/ti/am62ax_sk.rst | 4 ++--
doc/board/ti
Mention the TIFS Stub in the TISP image format
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 2 +-
doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 +
2 files changed, 354 insertions(+), 1 deletion(-)
create mode 100644 doc/board/ti/img
Add the AM62x boot flow to show at which point the TIFS Stub actually
gets loaded.
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst |2 +-
doc/board/ti/img/boot_diagram_am62.svg | 1983
2 files changed, 1984 insertions(+), 1 deletion(-)
create
Add support for packaging the TIFS Stub as it's required for basic Low
Power Modes like Deep Sleep.
Acked-by: Neha Malcom Francis
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git
formatting errors.
* Add entry to MAINTAINERS for doc/board/ti
Link to previous series:
https://lore.kernel.org/u-boot/20240628093252.1864609-1-d-g...@ti.com/
Dhruva Gole (6):
arm: dts: k3-am625-beagleplay: Package TIFS Stub
doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub
Since AM62x, AM62P and AM62A all use similar boot flows and their low
power mode s/w ARCH is also similar in the way that they make use of the
TIFS Stub, update their documentation to show where TIFS Stub is.
Signed-off-by: Dhruva Gole
---
This series depends on TIFS Stub BeaglePlay series sent
Add documentation to briefly explain the role of TIFS Stub in relevant
K3 SoC's.
Signed-off-by: Dhruva Gole
---
doc/board/ti/k3.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst
index 88821a15e4c6..f45a285db21b 100644
--- a/doc/board/ti/k3
Mention the TIFS Stub in the TISP image format
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 2 +-
doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 4
2 files changed, 5 insertions(+), 1 deletion(-)
create mode 100644 doc/board/ti/img/tifsstub_dm_tispl.bin.svg
Add the AM62x boot flow to show at which point the TIFS Stub actually
gets loaded.
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 2 +-
doc/board/ti/img/boot_diagram_am62.svg | 4
2 files changed, 5 insertions(+), 1 deletion(-)
create mode 100644 doc/board/ti/img
format for TISPL
* Add new changes in boot flow for am62 family of devices.
[0] https://lore.kernel.org/u-boot/20240618045610.271884-1-d-g...@ti.com/
Dhruva Gole (4):
arm: dts: k3-am625-beagleplay: Package TIFS Stub
doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub
doc
Add support for packaging the TIFS Stub as it's required for basic Low
Power Modes like Deep Sleep.
Acked-by: Neha Malcom Francis
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git
Nishanth,
On Jun 19, 2024 at 13:47:36 -0500, Nishanth Menon wrote:
> On 10:26-20240618, Dhruva Gole wrote:
> > Add support for packaging the TIFS Stub as it's required for basic Low
> > Power Modes like Deep Sleep.
>
> What the heck is tifs stub?
> https://docs.u-boot.org
Bryan,
On Jun 19, 2024 at 16:44:48 -0500, Bryan Brattlof wrote:
> On June 18, 2024 thus sayeth Dhruva Gole:
> > Add support for packaging the TIFS Stub as it's required for basic Low
> > Power Modes like Deep Sleep.
> >
> > Acked-by: Neha Malcom Francis
>
locator to clobber TF-A and break its boot.
> >
> > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the
> > actual location of the firmware
> >
> > CC: Andrew Davis
> > CC: Nishanth Menon
> > CC: Robert Nelson
> > Reported-b
implications there are of reverting this so I
don't suggest immediately dropping it, however some hints around what's
missing on beagleplay vs other platforms would be helpful.
Because other platforms based off the same SoC don't seem to be
affected.
--
Best regards,
Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low
Power Modes like Deep Sleep.
Acked-by: Neha Malcom Francis
Signed-off-by: Dhruva Gole
---
No changes from v1, just picked Neha's ack and rebased on master again.
Link to v1:
https://lore.kernel.org/u-boot
by: Chirag Shilwant
Signed-off-by: Dhruva Gole
---
No changes, just picked the r-by's and acks.
Link to v1:
https://lore.kernel.org/u-boot/20240613080604.3828083-1-d-g...@ti.com/
board/beagle/beagleplay/beagleplay.env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bo
Rename the boot bins as the _unsigned postfixes are not longer
required. We have symlinks in place for having generic names for all the
boot bins now.
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Add symlinks for both tiboot3.bin and tispl.bin because a user has to
anyway rename these files to get the platform to boot up.
This just makes it more intuitive and convenient.
Reviewed-by: Manorit Chawdhry
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1
Add symlinks for both tiboot3.bin and tispl.bin because a user has to
anyway rename these files to get the platform to boot up.
Also update the documentation to reflect above change.
Changes in v4:
* Add the docs patch.
Cc: Nishant Menon
Cc: Robert Nelson
Dhruva Gole (2):
arm: dts: k3-am625
0x9d5a1a, 0, 64 * 1024, 1024,
> SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES |
> SPI_NOR_HAS_TB) },
> + { INFO("is25lp01gg", 0x9d6021, 0, 64 * 1024, 2048,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_TB) },
Otherwise looks good to me,
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva
Hi Robert and Bryan,
On Jun 15, 2024 at 21:30:55 -0500, Robert Nelson wrote:
> On Sat, Jun 15, 2024 at 8:55 PM Bryan Brattlof wrote:
> >
> > On June 13, 2024 thus sayeth Dhruva Gole:
> > > The Kernel Image and DTB files are supposed to be picked from the rootfs
> >
Add symlinks for both tiboot3.bin and tispl.bin because a user has to
anyway rename these files to get the platform to boot up.
This just makes it more intuitive and convenient.
Signed-off-by: Dhruva Gole
---
This is just a RESEND of v1, because the changes in v2 were not
required. Link
On Jun 14, 2024 at 17:23:40 +0530, Dhruva Gole wrote:
> Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to
> anyway rename these files to get the platform to boot up.
> This just makes it more intuitive and convenient.
>
> Signed-off-by: Dhruva Gole
On Jun 14, 2024 at 15:16:30 +0530, Manorit Chawdhry wrote:
> Hi Dhruva,
>
> On 14:10-20240614, Dhruva Gole wrote:
> > Add symlinks for both tiboot3.bin and tispl.bin because a user has to
> > anyway rename these files to get the platform to boot up.
> > This j
Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to
anyway rename these files to get the platform to boot up.
This just makes it more intuitive and convenient.
Signed-off-by: Dhruva Gole
---
Changes:
Add symlink for u-boot.img as well as per Manorit's suggestion.
Add symlinks for both tiboot3.bin and tispl.bin because a user has to
anyway rename these files to get the platform to boot up.
This just makes it more intuitive and convenient.
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1 +
arch/arm/dts/k3-am625-r5
Robert,
On Jun 13, 2024 at 16:51:24 -0500, Robert Nelson wrote:
> On Thu, Jun 13, 2024 at 4:47 PM Robert Nelson wrote:
> >
> > On Thu, Jun 13, 2024 at 3:06 AM Dhruva Gole wrote:
> > >
> > > The Kernel Image and DTB files are supposed to be picked from the rootfs
The Kernel Image and DTB files are supposed to be picked from the rootfs
of the SD Card, this fails in legacy boot flow because bootpart is set
to 1:1. Fix it.
Fixes: a200f428b5b21 ("board: ti: am62x: Add am62x_beagleplay_* defconfigs and
env file")
Signed-off-by: Dhruva Gole
---
bo
Add support for packaging the TIFS Stub as it's required for basic Low
Power Modes like Deep Sleep.
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/arch/arm/dts/k3-am625
Adds TIFS stub binaries, this is required for deepsleep functionality.
This implements the same change as commit 128f81290b7d ("arm: dts: k3:
binman: am625: add support for signing TIFSSTUB Images") did for TI AM62
SK board.
Signed-off-by: Vibhore Vardhan
Signed-off-by: Dhruva Gole
Signed-off-by: Vibhore Vardhan
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am62a-sk-binman.dtsi | 138 ++-
1 file changed, 136 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/k3-am62a-sk-binman.dtsi
b/arch/arm/dts/k3-am62a-sk-binman.dtsi
index ec3bf7ce913b..d7
used in the Low Power Exit sequences.
Boot tested on both platforms that are being touched:
[0] AM62A, [1] AM62P
[0] https://gist.github.com/DhruvaG2000/d5f2a46818d8025a540efe9289feacb4
[1] https://gist.github.com/DhruvaG2000/ce29f6e9315a78d3e9e5810f55f17f43
Dhruva Gole (2):
arm: dts: k3: binman
ts: am62a7_sk: Switch to OF_UPSTREAM
>
For the series,
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
I still carry your re-based series on top of latest master [1] and USB DFU
> > is working very well on Verdin AM62.
> >
> > Thanks!
> >
> > [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support
>
> As the am62 files have been re-synced, re-basing this and re-posting for
> next would be appropriate at this point.
Any updates on this? Do you have plans to rebase and resend this series?
--
Best regards,
Dhruva Gole
Egorov
> Tested-by: John Ma
> ---
> board/phytec/common/am6_som_detection.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Dhruva Gole
[...]
--
Best regards,
Dhruva Gole
Hi,
On May 22, 2024 at 09:55:01 +0200, Wadim Egorov wrote:
> SoM detection is using I2C driver model functions.
> Let's depend on I2C.
>
> Signed-off-by: Wadim Egorov
> Tested-by: John Ma
> ---
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
F_UPSTREAM=y
> diff --git a/configs/am62x_lp_sk_r5_defconfig
> b/configs/am62x_lp_sk_r5_defconfig
> new file mode 100644
> index 0..93b3922e6fec5
> --- /dev/null
> +++ b/configs/am62x_lp_sk_r5_defconfig
> @@ -0,0 +1,2 @@
> +#include
> +CONFIG_DEFAULT_DEVICE_TREE="k3-am62-r5-lp-sk"
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
; b/arch/arm/dts/k3-am62-lp-sk-u-boot.dtsi
> new file mode 100644
> index 0..08f572446657e
> --- /dev/null
> +++ b/arch/arm/dts/k3-am62-lp-sk-u-boot.dtsi
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * AM62x LP SK dts file for SPLs
> + * Copyright (C) 2021-2023 Texas Instruments Incorporated -
> https://www.ti.com/
2024 ^^
[...]
With that fixed,
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
BE_4K;
> +
> /* Support 8 x 4KB sectors at bottom */
> - return spansion_erase_non_uniform(nor, addr, SPINOR_OP_BE_4K_4B, 0,
> SZ_32K);
> + return spansion_erase_non_uniform(nor, addr, opcode, 0, SZ_32K);
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva
256 * 1024, 128,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> + { INFO6("s25fl256s1", 0x010219, 0x4d0180, 64 * 1024, 512,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva
Hi Neha!
On Apr 04, 2024 at 10:20:21 +0530, Neha Malcom Francis wrote:
> Hi Dhruva
>
> On 03/04/24 17:33, Dhruva Gole wrote:
> > From: Kamlesh Gurudasani
> >
> > Add support for signing of TIFSSTUB images for HSSE, HSFS and GP devices
> > and include them in
From: Kamlesh Gurudasani
Add support for signing of TIFSSTUB images for HSSE, HSFS and GP devices
and include them in tispl.bin and tispl.bin_unsigned.
Signed-off-by: Kamlesh Gurudasani
Signed-off-by: Dhruva Gole
---
arch/arm/dts/k3-am625-sk-binman.dtsi | 141 ++-
1
will be discarded.
Signed-off-by: Kamlesh Gurudasani
Signed-off-by: Dhruva Gole
---
arch/arm/mach-k3/r5/common.c | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-k3/r5/common.c b/arch/arm/mach-k3/r5/common.c
index c02f8d330998..0f6c294f1eb2 100644
--- a/arch
Add support for signing, detection and loading of TIFSSTUB images for
for HSSE, HSFS and GP AM62x devices.
Boot tested and Deepsleep entry exist tested with ti-linux:
https://gist.github.com/DhruvaG2000/036010f6ae75aa6443fc77f61fd74893
Patches are based on top of tag: v2024.04
Cc: Tom Rini
Cc:
*-u-boot.dtsi files
> - update MAINTAINERS file
>
> Signed-off-by: Marcel Ziswiler
>
> ---
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva
buck_probe(struct udevice *dev)
> case TPS65941_BUCK_ID_2:
> case TPS65941_BUCK_ID_3:
> case TPS65941_BUCK_ID_4:
> - case TPS65941_BUCK_ID_5:
> debug("Single phase regulator\n");
> break;
> + case TPS65941_BUCK_ID_5:
> + if (chip_id != TPS65224) {
> + debug("Single phase regulator\n");
> + } else {
> + printf("Wrong ID for regulator\n");
no printfs please.
> + return -EINVAL;
> + }
> + break;
> case TPS65941_BUCK_ID_12:
> + idx = 1;
> + break;
> case TPS65941_BUCK_ID_123:
> case TPS65941_BUCK_ID_1234:
> - idx = 1;
> + if (chip_id != TPS65224) {
> + idx = 1;
> + } else {
> + printf("Wrong ID for regulator\n");
ditto.
> + return -EINVAL;
> + }
> break;
> case TPS65941_BUCK_ID_34:
> - idx = 3;
> + if (chip_id != TPS65224) {
> + idx = 3;
> + } else {
> + printf("Wrong ID for regulator\n");
Like in your other patches, can you please use pr_err or friends?
> + return -EINVAL;
> + }
> break;
> default:
> pr_err("Wrong ID for regulator\n");
> --
> 2.25.1
>
--
Best regards,
Dhruva Gole
On Mar 06, 2024 at 19:09:43 +0530, Bhargav Raviprakash wrote:
> Re-use the TPS65941 PMIC driver for TPS65224 PMIC.
> Add additional macros of TPS65224 to aid in the driver
> re-use.
>
> Signed-off-by: Bhargav Raviprakash
> ---
Reviewed-by: Dhruva Gole
> include/
UCK_ID_12:
> + case TPS65941_BUCK_ID_123:
> + case TPS65941_BUCK_ID_1234:
> idx = 1;
> - } else if (idx == 34) {
> + break;
> + case TPS65941_BUCK_ID_34:
> idx = 3;
> - } else if (idx == 123) {
> - idx = 1;
> - } else if (idx == 1234) {
> - idx = 1;
> - } else {
> - printf("Wrong ID for regulator\n");
> + break;
> + default:
> + pr_err("Wrong ID for regulator\n");
> return -EINVAL;
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
atible = "ti,tps659412", .data = TPS659411 },
> { .compatible = "ti,tps659413", .data = TPS659413 },
> { .compatible = "ti,lp876441", .data = LP876441 },
> + { .compatible = "ti,tps65224", .data = TPS65224 },
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
Hi,
+ Tom
On 28/02/24 14:28, Wadim Egorov wrote:
Use proper binary artifact names for HSFS devices.
Do not use the *_unsigned binaries.
Signed-off-by: Wadim Egorov
---
Reviewed-by: Dhruva Gole
doc/board/phytec/phycore-am62x.rst | 6 +++---
1 file changed, 3 insertions(+), 3
h a FAT
> filesystem.
> +Assuming the uSD card is `/dev/mmcblk0`:
> +
> +.. code-block:: bash
> +
> + $ mkfs.vfat /dev/mmcblk0p1
> +
> +To boot from a micro SD card on a HSFS device simply copy the following
> +artifacts to the FAT partition:
> +
> +* tiboot3.bin from R5 build as tiboot3.bin
> +* tispl.bin_unsigned from Cortex-A build as tispl.bin
> +* u-boot.img_unsigned from Cortex-A build as u-boot.img
Is the _unsigned really required? I guess the regular tispl and
u-boot.img should also work right? It will just skip auth I guess.
[...]
Mostly looks good, thanks!
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
p, bool *enable)
> return 0;
> }
>
> -static int tps65941_buck_volt2val(int uV)
> +static int tps65941_buck_volt2val(int /*idx*/, int uV)
IMHO /*idx*/ does NOT look good.
Check something like __maybe_unused attribute
[...]
--
Best regards,
Dhruva Gole
Add a comment to explain the code under is_secure condition of
ti_sci_do_xfer. This will help avoid confusion amongst people who may in
future touch upon this code.
Reviewed-by: Nishanth Menon
Signed-off-by: Dhruva Gole
---
drivers/firmware/ti_sci.c | 6 ++
1 file changed, 6 insertions
ntrol
Interface (TI SCI)")
Reviewed-by: Nishanth Menon
Signed-off-by: Dhruva Gole
---
drivers/firmware/ti_sci.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 6e9f93e9a302..b77ac36af284 100644
---
Cc: Kamlesh Gurudasani
Cc: Andrew Davis
Dhruva Gole (2):
firmware: ti_sci: fix the secure_hdr in do_xfer
firmware: ti_sci: Add comment explaining the is_secure code
drivers/firmware/ti_sci.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
Add a comment to explain the code under is_secure condition of
ti_sci_do_xfer. This will help avoid confusion amongst people who may in
future touch upon this code.
Signed-off-by: Dhruva Gole
---
drivers/firmware/ti_sci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
ntrol
Interface (TI SCI)")
Cc: Nishanth Menon
Cc: Andrew Davis
Cc: Manorit Chawdhry
Signed-off-by: Dhruva Gole
---
drivers/firmware/ti_sci.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 6e
ddress Kamlesh's comment on v2: use sizeof(struct ti_sci_secure_msg_hdr)
v1 --> v2
Rebased on top of latest master branch
Cc: Nishanth Menon
Cc: Tom Rini
Cc: Neha Francis
Cc: Manorit Chawdhry
Cc: Vignesh Raghavendra
Cc: Kamlesh Gurudasani
Dhruva Gole (2):
firmware: ti_sci: fix the secure_hdr i
On Jan 24, 2024 at 12:09:06 -0600, Nishanth Menon wrote:
> On 18:37-20240124, Dhruva Gole wrote:
> > The secure_hdr needs to be 0 init-ed however this was never being put
> > into the secure_buf, leading to possibility of the first 4 bytes of
> > secure_buf being possibly
On Jan 24, 2024 at 12:08:13 -0600, Nishanth Menon wrote:
> On 23:07-20240124, Dhruva Gole wrote:
> > On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote:
> > > On 18:38-20240124, Dhruva Gole wrote:
> > > > On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasan
On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote:
> On 18:38-20240124, Dhruva Gole wrote:
> > On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote:
> > > Dhruva Gole writes:
> > >
> > > > The secure_hdr needs to be 0 i
On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote:
> Dhruva Gole writes:
>
> > The secure_hdr needs to be 0 init-ed however this was never being put
> > into the secure_buf, leading to possibility of the first 4 bytes of
> > secure_buf being possi
the first 4
bytes are 0.
Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control
Interface (TI SCI)")
Signed-off-by: Dhruva Gole
---
Boot tested for sanity on AM62x SK
https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074
Changelog:
v2 --> v3
Addr
On Jan 24, 2024 at 15:45:58 +0530, Dhruva Gole wrote:
> The secure_hdr needs to be 0 init-ed however this was never being put
> into the secure_buf, leading to possibility of the first 4 bytes of
> secure_buf being possibly garbage.
>
> Fix this by initialising the se
the first 4
bytes are 0.
Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control
Interface (TI SCI)")
Signed-off-by: Dhruva Gole
---
Boot tested for sanity on AM62x SK
https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074
Changelog:
Rebased on top
the first 4
bytes are 0.
Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control
Interface (TI SCI)")
Signed-off-by: Dhruva Gole
---
Boot tested for sanity on AM62x SK
https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074
Cc: Nishanth Menon
Cc
CTAL_DTR_READ) },
> { INFO("s28hs01gt", 0x345b1b, 0, 256 * 1024, 512,
> SPI_NOR_OCTAL_DTR_READ) },
> + { INFO("s28hs02gt", 0x345b1c, 0, 256 * 1024, 1024,
> SPI_NOR_OCTAL_DTR_READ) },
Reviewed-by: Dhruva Gole
> #endif
> #endif
> #ifdef CONFIG_SPI_FLASH_SST /* SST */
> --
> 2.34.1
>
--
Best regards,
Dhruva Gole
Hi Nishanth,
On 05/12/23 01:00, Nishanth Menon wrote:
On 15:59-20231201, Dhruva Gole wrote:
The CFG_WITH_SOFTWARE_PRNG option was needed once when there were some
issues with system crashes/ hangs after a suspend-resume cycle. However
this seems to no longer be the case with newer firmwares
M: https://www.phytec.com/product/phycore-am62x
>
> Device trees were taken from Linux v6.7-rc3.
Thanks for providing the Linux tag, since DT changes are in sync with
kernel,
Reviewed-by: Dhruva Gole
>
> Signed-off-by: Wadim Egorov
> ---
> v2:
> - Add cover-letter &
This SoC does not require the CFG_WITH_SOFTWARE_PRNG option to be set
for base boot support, hence remove it from the U-Boot documentation.
Signed-off-by: Dhruva Gole
---
doc/board/ti/am62x_sk.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti
Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot
requirement for this SoC
Signed-off-by: Dhruva Gole
---
doc/board/beagle/am62x_beagleplay.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/doc/board/beagle/am62x_beagleplay.rst
b/doc/board/beagle/am62x_beagleplay.rst
the docs.
Cc: Kamlesh
Cc: Vibhore Vardhan
Cc: Wadim Egorov
Dhruva Gole (2):
doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE
doc: board: ti: am62x_sk: Remove SW_PRNG Flag for OPTEE
doc/board/beagle/am62x_beagleplay.rst | 1 -
doc/board/ti/am62x_sk.rst | 1 -
2
-boot.img
> + sf update $loadaddr 0x28 $filesize
> +
Want to add some documentation on Boot Modes? Something like [0]?
> +Further Information
> +---
> +
> +Please see :doc:`../ti/am62x_sk` chapter for further AM62 SoC related
> documentation
> +and http
*/
> pinctrl-single,pins = <
> AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
> @@ -109,14 +61,6 @@
> >;
> };
>
> - {
> - bootph-all;
> -};
> -
> - {
> - bootph-all;
> -};
> -
> #ifdef CONFIG_TARGET_AM625_A53_EVM
>
> #define SPL_AM625_BEAGLEPLAY_DTB "spl/dts/k3-am625-beagleplay.dtb"
You didn't talk about this in the commit message?
> --
> 2.40.0
>
>
Rest looks ok,
Reviewed-by: Dhruva Gole
--
Best regards,
Dhruva Gole
; - bootph-all;
> -};
> -
> -_phy0 {
> - bootph-all;
> -};
> -
> -_phy1 {
> - bootph-all;
> -};
> -
> -_rgmii1_pins_default {
> - bootph-all;
> -};
> -
> -_rgmii2_pins_default {
> - bootph-all;
> -};
> -
> -_gmii_sel {
> - bootph-all;
> -};
> -
> - {
> - bootph-all;
> - ethernet-ports {
> - bootph-all;
> - };
> -};
> -
> -_port1 {
> - bootph-all;
> -};
> -
> _port2 {
> status = "disabled";
> };
> --
> 2.40.0
Looks okay,
Reviewed-by: Dhruva Gole
>
>
--
Best regards,
Dhruva Gole
0626
GNU ld (Arm GNU Toolchain 12.3.Rel1 (Build arm-12.35)) 2.40.0.20230627
=>
...
Tested-by: Dhruva Gole
>
> arch/arm/dts/k3-am62-main.dtsi| 12 +-
> arch/arm/dts/k3-am62-mcu.dtsi | 2 +
> arch/arm/dts/k3-am62-verdin-wifi.dtsi | 6 +
&g
ies with a cover letter
summarising your changes. You can also attach boot logs or any
additional info you may want the people reviewing/ testing the patches to
know in the cover letter.
>
> dtb-$(CONFIG_SOC_K3_AM62A7) += k3-am62a7-sk.dtb \
> k3-am62a7-r5-sk.dtb
[..snip..]
--
Best regards,
Dhruva Gole
> $ export OPTEE_PLATFORM=k3-am62x
> $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y"
>
> +For SK-AM62x-LP, set the UBOOT_CFG_CORTEXR variable as shown below:
> +
> +.. code-block:: bash
> +
> + $ export UBOOT_CFG_CORTEXR=am62x_evm_r5_defconfig am62x_lpsk_r5.config
> +
/ti/am62x/am62x_lpsk_r5.config
> @@ -0,0 +1,5 @@
> +# Defconfig fragment to apply on top of am62x_evm_r5_defconfig
> +
> +CONFIG_DEFAULT_DEVICE_TREE="k3-am62-r5-lp-sk"
> +CONFIG_SPL_OF_LIST="k3-am62-r5-lp-sk"
> +CONFIG_OF_LIST="k3-am62-r5-lp-sk"
Changes look fine, so with commit message fixed,
Reviewed-by: Dhruva Gole
> --
> 2.25.1
>
>
--
Best regards,
Dhruva Gole
1 - 100 of 161 matches
Mail list logo
