Re: [PATCH 32/81] fwu-mdata: Remove and add needed includes

2024-05-02 Thread Jassi Brar
On Wed, May 1, 2024 at 8:45 PM Tom Rini wrote: > > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tom Rini > Cc: Ilias Apalodimas > Cc: Jassi Brar > Cc: Etienne Carriere > --- Acked-by: Jassi Brar Thanks

Re: [PATCH v2] board: synquacer: developerbox: add myself as maintainer

2024-02-29 Thread Jassi Brar
On Thu, 29 Feb 2024 at 22:38, Masahisa Kojima wrote: > > Add myself as maintainer for SynQuacer Developerbox, > as I'm currently working on it. > This commit also removes Jassi from maintainer since he > no longer has a Developerbox. > Acked-by: Jassi Brar

Re: [PATCH] board: synquacer: developerbox: add myself as co-maintainer

2024-02-29 Thread Jassi Brar
) > > diff --git a/board/socionext/developerbox/MAINTAINERS > b/board/socionext/developerbox/MAINTAINERS > index c6d4f2749d..d772bc3b4c 100644 > --- a/board/socionext/developerbox/MAINTAINERS > +++ b/board/socionext/developerbox/MAINTAINERS > @@ -1,5 +1,6 @@ > DEVELOPER BOX

Re: [PATCH v2] FWU: developerbox: read boot index from NOR flash

2024-02-28 Thread Jassi Brar
n the NOR flash. > Add a function to read the boot index value from the NOR flash. > > Signed-off-by: Masahisa Kojima Acked-by: Jassi Brar

Re: [PATCH] board: synquacer: set actual gd->ram_top and gd->ram_size

2023-10-03 Thread Jassi Brar
information to > gd->ram_top and gd->ram_size. > > Signed-off-by: Masahisa Kojima Acked-by: Jassi Brar

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-09-08 Thread Jassi Brar
Hi Simon, On Thu, Sep 7, 2023 at 3:08 PM Simon Glass wrote: > On Wed, 6 Sept 2023 at 23:20, Ilias Apalodimas > > > > > > I beg to differ. Devicetree is more than just hardware and always has > > > > been. See, for example the /chosen and /options nodes. > > > > > > There are exceptions... > > >

Re: [PATCH] fwu: Initialize global fwu library state during CI test

2023-08-25 Thread Jassi Brar
at global state, and move the sandbox specific exit > from fwu_boottime_checks after g_dev is initialized. > > Signed-off-by: Marek Vasut Acked=by: Jassi Brar

Re: [PATCH] fwu: Allow code to properly decode trial state

2023-07-15 Thread Jassi Brar
> But if acceptance bit is no and images are in trial state in_trial variable > is never setup. Which means that from new flashed image stable image can be > rewritten because in_trial is not setup properly. > > Signed-off-by: Michal Simek > --- Acked-by: Jassi Brar

Re: [PATCH] fwu: Show number of attempts in Trial State

2023-07-15 Thread Jassi Brar
On Fri, 14 Jul 2023 at 03:47, Michal Simek wrote: > > It is not visible anywhere in Trial State if this is the first, second, etc > attempt that's why show a message to be aware about status. > > Signed-off-by: Michal Simek > --- Acked-by: Jassi Brar

Re: [PATCH] fwu: mtd: Fix dfu_alt_info generation for 2 images per bank

2023-07-13 Thread Jassi Brar
;bank1 raw 282 400' > > And after it: > Make dfu_alt_info: 'mtd nor0=bank0 raw 232 8;bank1 raw 27a > 8 nor0=bank0 raw 23a 400;bank1 raw 282 400' > > Size for bank0 and bank1 must be the same because it is the same image. > > Signed-off-by: Michal Simek Acked-by: Jassi Brar

Re: [PATCH v6 0/6] FWU: Add support for mtd backed feature on DeveloperBox

2023-06-20 Thread Jassi Brar
On Tue, 20 Jun 2023 at 05:05, Ilias Apalodimas wrote: > > Sorry for being late to the party, > > +cc Jose who maintains DEN0118 > > On Mon, Jun 19, 2023 at 11:16:53AM -0500, Jassi Brar wrote: > > Hi Michal, > > > > On Mon, 19 Jun 2023 at 10:02, Micha

Re: [PATCH v6 0/6] FWU: Add support for mtd backed feature on DeveloperBox

2023-06-19 Thread Jassi Brar
Hi Michal, On Mon, 19 Jun 2023 at 10:02, Michal Simek wrote: > > Hi Jassi, > > On 5/31/23 07:28, jaswinder.si...@linaro.org wrote: > > From: Jassi Brar > > > > Introduce support for mtd backed storage for FWU feature and enable it on > > S

Re: [PATCH] configs: synquacer: increase SYS_MALLOC_F_LEN

2023-06-01 Thread Jassi Brar
, Developerbox will not boot due to lack of > heap memory. > > This commit increases the size of heap memory. > > Signed-off-by: Masahisa Kojima Acked-by: Jassi Brar

Re: [PATCH] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-05-04 Thread Jassi Brar
On Thu, 4 May 2023 at 11:31, Ilias Apalodimas wrote: > > Replying to both Jassi and Tom here since it makes more sense, > > On Thu, 4 May 2023 at 19:19, Tom Rini wrote: > > > > On Thu, May 04, 2023 at 10:39:06AM -0500, Jassi Brar wrote: > > > On Thu, 4 May

Re: [PATCH] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-05-04 Thread Jassi Brar
On Thu, 4 May 2023 at 10:19, Rob Herring wrote: > On Thu, May 4, 2023 at 9:01 AM Jassi Brar wrote: > > > I may be wrong, but I see having fwu properties contained within the > > fwu node is cleaner than having them embedded into existing bindings > > (potentially dif

Re: [PATCH] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-05-04 Thread Jassi Brar
On Thu, 4 May 2023 at 07:08, Ilias Apalodimas wrote: > [...] > > > > > I'm assuming it's per partition type rather than storage medium (e.g. > > > > SATA, USB, SD, NAND, SPI-NOR)? GPT, 'fixed-partitions', other DT > > > > partition bindings, etc. If so, then I'm really wondering why it's a > > >

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-18 Thread Jassi Brar
On Tue, 18 Apr 2023 at 20:46, Simon Glass wrote: > > Hi, > > On Fri, 14 Apr 2023 at 07:53, Michal Simek wrote: > > > > > > > > On 4/10/23 06:25, Jassi Brar wrote: > > > On Wed, 29 Mar 2023 at 15:02, Simon Glass wrote: > > >> >

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-17 Thread Jassi Brar
On Mon, 17 Apr 2023 at 09:29, Michal Simek wrote: > > > > On 4/17/23 15:48, Jassi Brar wrote: > > On Mon, 17 Apr 2023 at 01:38, Michal Simek wrote: > >> On 4/14/23 17:02, Jassi Brar wrote: > > > >>>>>>> + > >>>>&g

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-17 Thread Jassi Brar
On Mon, 17 Apr 2023 at 01:38, Michal Simek wrote: > On 4/14/23 17:02, Jassi Brar wrote: > >>>>> + > >>>>> +/* This will dynamically allocate the fwu_mdata */ > >>>>> +#define CONFIG_FWU_NUM_BANKS 0 > >>>>&

Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions

2023-04-14 Thread Jassi Brar
On Fri, Apr 14, 2023 at 8:56 AM Michal Simek wrote: > On 4/10/23 05:56, Jassi Brar wrote: > > On Wed, 29 Mar 2023 at 07:00, Michal Simek wrote: > >> On 3/27/23 23:15, jassisinghb...@gmail.com wrote: > > > >>> diff --git a/drivers/fwu-mdata/raw_mtd.c b/driver

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-14 Thread Jassi Brar
On Fri, Apr 14, 2023 at 8:53 AM Michal Simek wrote: > > > > On 4/10/23 06:05, Jassi Brar wrote: > > On Wed, 29 Mar 2023 at 07:29, Michal Simek wrote: > >> On 3/27/23 23:16, jassisinghb...@gmail.com wrote: > > > >>> diff --git a/tools/mkfwumdata.c b/

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-09 Thread Jassi Brar
lementation. > > > > Signed-off-by: Masami Hiramatsu > > Signed-off-by: Sughosh Ganu > > Signed-off-by: Jassi Brar > > --- > > tools/Kconfig | 9 ++ > > tools/Makefile | 4 + > > tools/mkfwumdata.c | 334 +

Re: [PATCH v4 6/6] fwu: DeveloperBox: add support for FWU

2023-04-09 Thread Jassi Brar
On Wed, 29 Mar 2023 at 08:02, Michal Simek wrote: > On 3/27/23 23:16, jassisinghb...@gmail.com wrote: . > > + > > +void fwu_plat_get_bootidx(uint *boot_idx) > > +{ > > + int ret; > > + u32 active_idx; > > + u32 *bootidx = boot_idx; > > + > > + ret =

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-09 Thread Jassi Brar
in A/B Update imeplementation. > > > >Signed-off-by: Masami Hiramatsu > >Signed-off-by: Sughosh Ganu > >Signed-off-by: Jassi Brar > >--- > > tools/Kconfig | 9 ++ > > tools/Makefile | 4 + > > tools/mkfwumdata.c | 334 +

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-09 Thread Jassi Brar
On Wed, 29 Mar 2023 at 07:29, Michal Simek wrote: > On 3/27/23 23:16, jassisinghb...@gmail.com wrote: > > diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c > > new file mode 100644 > > index 00..43dabf3b72 > > --- /dev/null > > +++ b/tools/mkfwumdata.c > > @@ -0,0 +1,334 @@ > > +//

Re: [PATCH v4 2/6] FWU: mtd: Add helper functions for accessing FWU metadata

2023-04-09 Thread Jassi Brar
On Wed, 29 Mar 2023 at 06:55, Michal Simek wrote: > On 3/27/23 23:16, jassisinghb...@gmail.com wrote: > > +/** > > + * fwu_gen_alt_info_from_mtd() - Parse dfu_alt_info from metadata in mtd > > + * @buf: Buffer into which the dfu_alt_info is filled > > + * @len: Maximum characters that can be

Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions

2023-04-09 Thread Jassi Brar
On Wed, 29 Mar 2023 at 07:00, Michal Simek wrote: > On 3/27/23 23:15, jassisinghb...@gmail.com wrote: > > diff --git a/drivers/fwu-mdata/raw_mtd.c b/drivers/fwu-mdata/raw_mtd.c > > new file mode 100644 > > index 00..4b1a10073a > > --- /dev/null > > +++ b/drivers/fwu-mdata/raw_mtd.c > >

Re: [PATCH] spi: synquacer: Silence unused variable warnings

2023-04-08 Thread Jassi Brar
alize bus_width to 1 and add a warning if none of the configured > modes matches > > Signed-off-by: Ilias Apalodimas > Acked-by: Jassi Brar

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-03-06 Thread Jassi Brar
On Mon, Feb 27, 2023 at 7:28 PM Tom Rini wrote: > > On Mon, Feb 27, 2023 at 07:00:10PM -0600, Jassi Brar wrote: > > On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > > > > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote:

Re: [PATCH v5 3/6] fwu: move meta-data management in core

2023-03-06 Thread Jassi Brar
On Wed, Mar 1, 2023 at 5:16 AM Etienne Carriere wrote: > On Tue, 28 Feb 2023 at 01:52, wrote: > > > > From: Jassi Brar > > > > Instead of each i/f having to implement their own meta-data verification > > and storage, move the logic in common code. This simplif

Re: [PATCH v5 1/6] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-02-28 Thread Jassi Brar
On Tue, Feb 28, 2023 at 4:50 AM Michal Simek wrote: > On 2/28/23 01:52, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Any requirement of FWU should not require changes to bindings > > of other subsystems. For example, for mtd-backed storage we > >

Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Jassi Brar
Hi Ilias, On Thu, Feb 23, 2023 at 2:36 AM Ilias Apalodimas wrote: > > +int fwu_get_verified_mdata(struct fwu_mdata *mdata) > > +{ > > + int err; > > + bool pri_ok, sec_ok; > > + struct fwu_mdata s, *p_mdata, *s_mdata; > > + > > + p_mdata = _mdata; > > + s_mdata = > > + > > +

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Jassi Brar
On Mon, Feb 27, 2023 at 7:28 PM Tom Rini wrote: > > On Mon, Feb 27, 2023 at 07:00:10PM -0600, Jassi Brar wrote: > > On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > > > > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote:

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Jassi Brar
On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > The patchset reduces ~400 lines of code, while keeping the functionality > > same and making > > met

Re: [PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-02-27 Thread Jassi Brar
On Sat, 4 Feb 2023 at 22:09, Jassi Brar wrote: > > > > + fwu-mdata { > > + compatible = "u-boot,fwu-mdata-mtd"; > > + fwu-mdata-store = <_flash>; > > +

Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Jassi Brar
On Mon, Feb 27, 2023 at 10:30 AM Etienne Carriere wrote: > > Hello Jassi, > > On Sun, 5 Feb 2023 at 04:01, wrote: > > > > From: Jassi Brar > > > > Instead of each i/f having to implement their own meta-data verification > > and storage, move the log

Re: [PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-02-04 Thread Jassi Brar
On Wed, 18 Jan 2023 at 08:24, Michal Simek wrote: > > > > On 1/9/23 02:06, Jassi Brar wrote: > > From: Sughosh Ganu > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, on a separate

Re: [PATCHv3 2/5] fwu: move meta-data management in core

2023-02-04 Thread Jassi Brar
On Mon, 9 Jan 2023 at 06:54, Ilias Apalodimas wrote: > > Hi Jassi, > > On Mon, Jan 02, 2023 at 12:26:40PM -0600, Jassi Brar wrote: > > Instead of each i/f having to implement their own meta-data verification > > and storage, move the logic in common code. This simplifi

Re: [PATCHv3 4/5] fwu: DeveloperBox: add support for FWU

2023-01-21 Thread Jassi Brar
On Wed, Jan 18, 2023 at 8:46 AM Michal Simek wrote: > > > > On 1/9/23 02:07, Jassi Brar wrote: > > Add code to support FWU_MULTI_BANK_UPDATE. > > The platform does not have gpt-partition storage for > > Banks and MetaData, rather it used SPI-NOR backed &

Re: [PATCHv3 0/5] FWU: Handle meta-data in common code

2023-01-18 Thread Jassi Brar
On Wed, Jan 18, 2023 at 7:28 AM Michal Simek wrote: > > Hi, > > On 1/2/23 19:25, Jassi Brar wrote: > > The patchset reduces ~400 lines of code, while keeping the functionality > > same and making > > meta-data operations much faster (by using cached structures).

[PATCHv3 5/5] tools: Add mkfwumdata tool for FWU metadata image

2023-01-08 Thread Jassi Brar
From: Masami Hiramatsu Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data partition to be used in A/B Update imeplementation. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu Signed-off-by: Jassi Brar --- tools/Kconfig | 9 ++ tools/Makefile | 4

[PATCHv3 4/5] fwu: DeveloperBox: add support for FWU

2023-01-08 Thread Jassi Brar
Add code to support FWU_MULTI_BANK_UPDATE. The platform does not have gpt-partition storage for Banks and MetaData, rather it used SPI-NOR backed mtd regions for the purpose. Signed-off-by: Jassi Brar --- board/socionext/developerbox/Makefile | 1 + board/socionext/developerbox

[PATCHv3 3/5] dt: fwu: developerbox: enable fwu banks and mdata regions

2023-01-08 Thread Jassi Brar
Specify Bank-0/1 and fwu metadata mtd regions. Signed-off-by: Jassi Brar Acked-by: Ilias Apalodimas --- .../synquacer-sc2a11-developerbox-u-boot.dtsi | 22 ++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi

[PATCHv3 2/5] FWU: mtd: Add helper functions for accessing FWU metadata

2023-01-08 Thread Jassi Brar
From: Sughosh Ganu Add helper functions needed for accessing the FWU metadata which contains information on the updatable images. Signed-off-by: Sughosh Ganu Signed-off-by: Jassi Brar --- include/fwu.h | 27 ++ lib/fwu_updates/Makefile | 1 + lib/fwu_updates/fwu_mtd.c

[PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-01-08 Thread Jassi Brar
. Signed-off-by: Sughosh Ganu Signed-off-by: Jassi Brar --- drivers/fwu-mdata/Kconfig | 15 +++ drivers/fwu-mdata/Makefile | 1 + drivers/fwu-mdata/raw_mtd.c | 201 3 files changed, 217 insertions(+) create mode 100644 drivers/fwu-mdata/raw_mtd.c diff --git

[PATCHv3 0/5] FWU: Add support for mtd backed feature on DeveloperBox

2023-01-08 Thread Jassi Brar
Introduce support for mtd backed storage for FWU feature and enable it on Synquacer platform based DeveloperBox. This revision is rebased onto patchset that trims the FWU api https://lore.kernel.org/u-boot/20230102182532.2411125-1-jaswinder.si...@linaro.org/ Jassi Brar (2): dt: fwu

[PATCHv3 5/5] fwu: rename fwu_get_verified_mdata to fwu_get_mdata

2023-01-02 Thread Jassi Brar
fwu_get_mdata() sounds more appropriate than fwu_get_verified_mdata() Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- cmd/fwu_mdata.c | 2 +- include/fwu.h | 4 ++-- lib/fwu_updates/fwu.c | 6 +++--- 3 files changed, 6 insertions(+), 6

[PATCHv3 4/5] fwu: meta-data: switch to management by common code

2023-01-02 Thread Jassi Brar
() and .write_mdata_partition() and also the corresponding wrapper functions. Signed-off-by: Jassi Brar --- cmd/fwu_mdata.c | 17 +- drivers/fwu-mdata/fwu-mdata-uclass.c | 165 --- drivers/fwu-mdata/gpt_blk.c | 124 +- include/fwu.h

[PATCHv3 3/5] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-01-02 Thread Jassi Brar
Moving towards using common code for meta-data management, implement the read/write mdata hooks. Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- drivers/fwu-mdata/gpt_blk.c | 36 1 file changed, 36 insertions

[PATCHv3 2/5] fwu: move meta-data management in core

2023-01-02 Thread Jassi Brar
Instead of each i/f having to implement their own meta-data verification and storage, move the logic in common code. This simplifies the i/f code much simpler and compact. Signed-off-by: Jassi Brar --- drivers/fwu-mdata/fwu-mdata-uclass.c | 34 +++ include/fwu.h

[PATCHv3 1/5] fwu: gpt: use cached meta-data partition numbers

2023-01-02 Thread Jassi Brar
Use cached values and avoid parsing and scanning through partitions everytime for meta-data partitions because they can't change after bootup. Acked-by: Etienne Carriere Signed-off-by: Jassi Brar --- drivers/fwu-mdata/gpt_blk.c | 43 + 1 file changed, 24

[PATCHv3 0/5] FWU: Handle meta-data in common code

2023-01-02 Thread Jassi Brar
missing mdata copy before return Changes since v1: * Fix typos and misc cosmetic changes * Catch error returns Jassi Brar (5): fwu: gpt: use cached meta-data partition numbers fwu: move meta-data management in core fwu: gpt: implement read_mdata and write_mdata callbacks fwu

Re: [PATCHv2 1/4] fwu: gpt: use cached meta-data partition numbers

2023-01-02 Thread Jassi Brar
On Thu, 22 Dec 2022 at 06:45, Ilias Apalodimas wrote: > > On Fri, Dec 02, 2022 at 09:16:51PM -0600, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Use cached values and avoid parsing and scanning through partitions > > everytime for meta-data partit

Re: [PATCHv2 2/4] fwu: move meta-data management in core

2023-01-02 Thread Jassi Brar
On Tue, 13 Dec 2022 at 09:00, Etienne Carriere wrote: > > Hello Jassi, > > On Sat, 3 Dec 2022 at 04:17, wrote: > > > > From: Jassi Brar > > > > Instead of each i/f having to implement their own meta-data verification > > and storage, move the logic in

Re: [PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-01-02 Thread Jassi Brar
On Mon, 2 Jan 2023 at 03:48, Etienne Carriere wrote: > > Hi Jassi, > > On Thu, 22 Dec 2022 at 13:59, Ilias Apalodimas > wrote: > > > > Hi Jassi, > > > > On Fri, Dec 02, 2022 at 09:17:12PM -0600, jassisinghb...@gmail.com wrote: > > > From: Jassi Br

Re: [PATCH 2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

2022-12-09 Thread Jassi Brar
100644 > > --- a/arch/arm/dts/synquacer-sc2a11.dtsi > > +++ b/arch/arm/dts/synquacer-sc2a11.dtsi > > @@ -497,7 +497,6 @@ > > gpio-controller; > > #gpio-cells = <2>; > > clocks = <_apb>; > > -base = <0>; > > Reviewed-by: Masahisa Kojima > Acked-by: Jassi Brar

Re: [PATCH 1/2] dts: synquacer: Drop unused and undocumented SPI properties

2022-12-09 Thread Jassi Brar
t; #address-cells = <1>; > > #size-cells = <0>; > > status = "okay"; > > - active_clk_edges; > > - chipselect_num = <1>; > > Reviewed-by: Masahisa Kojima > Acked-by: Jassi Brar

Re: [PATCH 2/4] fwu: move meta-data management in core

2022-11-07 Thread Jassi Brar
On Mon, Nov 7, 2022 at 2:13 PM Etienne Carriere wrote: > > Hello Jassi, > > On Mon, 7 Nov 2022 at 19:29, Jassi Brar wrote: > > > > On Mon, Nov 7, 2022 at 11:24 AM Etienne Carriere > > wrote: > > > On Fri, 4 Nov 2022 at 03:43, wrote: > > > &

Re: [PATCH 1/4] fwu: gpt: use cached meta-data partition numbers

2022-11-07 Thread Jassi Brar
On Mon, Nov 7, 2022 at 11:24 AM Etienne Carriere wrote: > > Hello Jassi, > > Acked-by: Etienne Carriere > with the 2 below comments addressed. > > On Fri, 4 Nov 2022 at 03:42, wrote: > > > > From: Jassi Brar > > > > Use cached values and

Re: [PATCH 4/4] fwu: meta-data: switch to management by common code

2022-11-07 Thread Jassi Brar
On Mon, Nov 7, 2022 at 11:23 AM Etienne Carriere wrote: > > Hello Jassi, > > FYI, I've successfully tested this series on stm32mp1 for FWU, once > the few typos fixed to build it them. > Thanks for testing. I will fix the typos and resubmit. . > > @@ -831,11 +662,7 @@ static int

Re: [PATCH 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

2022-11-07 Thread Jassi Brar
On Mon, Nov 7, 2022 at 11:23 AM Etienne Carriere wrote: > > On Fri, 4 Nov 2022 at 03:43, wrote: > > > > From: Jassi Brar > > > > Moving towards using common code for meta-data management, > > implement the read/write mdata hooks. > > > > Signed-of

Re: [PATCH 2/4] fwu: move meta-data management in core

2022-11-07 Thread Jassi Brar
On Mon, Nov 7, 2022 at 11:24 AM Etienne Carriere wrote: > On Fri, 4 Nov 2022 at 03:43, wrote: > > > > +/** > > + * fwu_get_verified_mdata() - Read, verify and return the FWU metadata > > + * > > + * Read both the metadata copies from the storage media, verify their > > checksum, > > + * and

Re: [PATCHv2 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2022-10-31 Thread Jassi Brar
On Fri, Oct 14, 2022 at 2:07 AM Ilias Apalodimas wrote: > > On Sun, Oct 02, 2022 at 06:51:32PM -0500, jassisinghb...@gmail.com wrote: > > + > > +static bool mtd_is_aligned_with_block_size(struct mtd_info *mtd, u64 size) > > +{ > > + return !do_div(size, mtd->erasesize); > > +} > > + > > Can

Re: [PATCHv2 4/5] fwu: DeveloperBox: add support for FWU

2022-10-03 Thread Jassi Brar
On Mon, Oct 3, 2022 at 9:44 PM AKASHI Takahiro wrote: > On Mon, Oct 03, 2022 at 09:00:35PM -0500, Jassi Brar wrote: > > > My question is why you use a single capsule (FIP) in A/B update while you > > > use > > > three separate capsule files in normal case. &g

Re: [PATCHv2 4/5] fwu: DeveloperBox: add support for FWU

2022-10-03 Thread Jassi Brar
On Mon, Oct 3, 2022 at 8:06 PM AKASHI Takahiro wrote: > > On Mon, Oct 03, 2022 at 04:51:32PM +0300, Ilias Apalodimas wrote: > > Hi Jassi, > > > > On Mon, 3 Oct 2022 at 16:40, Jassi Brar wrote: > > > > > > On Mon, Oct 3, 2022 at 6:04 AM AKASHI Takahir

Re: [PATCHv2 4/5] fwu: DeveloperBox: add support for FWU

2022-10-03 Thread Jassi Brar
On Mon, Oct 3, 2022 at 6:04 AM AKASHI Takahiro wrote: > > diff --git a/board/socionext/developerbox/developerbox.c > > b/board/socionext/developerbox/developerbox.c > > index f5a5fe0121..a0db26eaf3 100644 > > --- a/board/socionext/developerbox/developerbox.c > > +++

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-03 Thread Jassi Brar
Hi Ilias, On Mon, Oct 3, 2022 at 7:21 AM Ilias Apalodimas wrote: > > Hi Jassi, > > On Wed, Sep 28, 2022 at 10:16:53AM -0500, Jassi Brar wrote: > > Hi Etienne, > > > > On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere > > wrote: > > > Hello Jassi, Sugh

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-28 Thread Jassi Brar
On Wed, Sep 28, 2022 at 1:00 AM Sughosh Ganu wrote: > > On Tue, 27 Sept 2022 at 21:55, Jassi Brar wrote: > > > > On Tue, Sep 27, 2022 at 2:14 AM Sughosh Ganu > > wrote: > > > > > > On Mon, 26 Sept 2022 at 20:12, Jassi Brar > > > wrote: >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-28 Thread Jassi Brar
Hi Etienne, On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere wrote: > Hello Jassi, Sughosh and all, > > >>> But a malicious user may force some old vulnerable image back into use > >>> by updating all but that image. > > When the system boots with accepted images (referring to fwu-mdata >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-27 Thread Jassi Brar
On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu > > wrote: > > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar > > > wrote: > > > >

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-27 Thread Jassi Brar
On Tue, Sep 27, 2022 at 2:14 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 20:12, Jassi Brar wrote: > > > > On Mon, Sep 26, 2022 at 5:00 AM Sughosh Ganu > > wrote: > > > > > > On Mon, 26 Se

Re: [PATCH 5/5] fwu: DeveloperBox: add support for FWU

2022-09-26 Thread Jassi Brar
On Thu, 1 Sept 2022 at 02:28, Heinrich Schuchardt wrote: > > On 7/22/22 19:43, jassisinghb...@gmail.com wrote: > >> diff --git a/board/socionext/developerbox/developerbox.c > >> b/board/socionext/developerbox/developerbox.c > >> index f5a5fe0121..ad2260e3d7 100644 > >> ---

Re: [PATCH v10 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-26 Thread Jassi Brar
On Mon, Sep 26, 2022 at 3:48 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 08:22, Jassi Brar wrote: > > > > On Thu, Sep 15, 2022 at 3:16 AM Sughosh Ganu > > wrote: > > > > > diff --git a/drivers/fwu-mdata/Kconfig b/drivers/fwu-mdata/Kconfig

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-26 Thread Jassi Brar
On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu wrote: > On Mon, 26 Sept 2022 at 08:25, Jassi Brar wrote: > > . > > > > > > +static __maybe_unused efi_status_t fwu_post_update_process(bool > > > fw_accept_os) > > > +{ > > &

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-26 Thread Jassi Brar
On Mon, Sep 26, 2022 at 5:00 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 08:28, Jassi Brar wrote: > > > > > > . > > > +/** > > > + * fwu_revert_boot_index() - Revert the active index in the FWU metadata > > > + * > >

Re: [PATCH v10 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-09-26 Thread Jassi Brar
On Mon, Sep 26, 2022 at 5:08 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 08:29, Jassi Brar wrote: > > . > > > +static int fwu_boottime_checks(void *ctx, struct event *event) > > > +{ > > > + int ret; > > > + struct udev

Re: [PATCH v10 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-09-25 Thread Jassi Brar
On Thu, Sep 15, 2022 at 3:17 AM Sughosh Ganu wrote: > diff --git a/include/fwu.h b/include/fwu.h > index 484289ed4f..d5f77ce83c 100644 > --- a/include/fwu.h > +++ b/include/fwu.h > @@ -256,4 +256,17 @@ int fwu_plat_get_update_index(uint *update_idx); > * > */ > void

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-25 Thread Jassi Brar
On Thu, Sep 15, 2022 at 3:15 AM Sughosh Ganu wrote: > +/** > + * @mdata_check: check the validity of the FWU metadata partitions > + * @get_mdata() - Get a FWU metadata copy > + * @update_mdata() - Update the FWU metadata copy > + */ > +struct fwu_mdata_ops { > + /** > +*

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-25 Thread Jassi Brar
On Thu, Sep 15, 2022 at 3:17 AM Sughosh Ganu wrote: > + > +static __maybe_unused void fwu_post_update_checks( > + struct efi_capsule_header *capsule, > + bool *fw_accept_os, bool *capsule_update) > +{ > + if (fwu_empty_capsule(capsule)) > + *capsule_update =

Re: [PATCH v10 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-25 Thread Jassi Brar
On Thu, Sep 15, 2022 at 3:16 AM Sughosh Ganu wrote: > diff --git a/drivers/fwu-mdata/Kconfig b/drivers/fwu-mdata/Kconfig > new file mode 100644 > index 00..7322da48b1 > --- /dev/null > +++ b/drivers/fwu-mdata/Kconfig > @@ -0,0 +1,16 @@ > +config FWU_MDATA > + bool "Driver support

Re: [PATCH v10 15/15] FWU: doc: Add documentation for the FWU feature

2022-09-19 Thread Jassi Brar
On Thu, 15 Sept 2022 at 03:16, Sughosh Ganu wrote: > diff --git a/doc/develop/uefi/fwu_updates.rst > b/doc/develop/uefi/fwu_updates.rst > new file mode 100644 > index 00..fad3fbb3a8 > --- /dev/null > +++ b/doc/develop/uefi/fwu_updates.rst > @@ -0,0 +1,165 @@ > +..

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-18 Thread Jassi Brar
On Thu, 15 Sept 2022 at 03:15, Sughosh Ganu wrote: > +/** > + * fwu_get_active_index() - Get active_index from the FWU metadata > + * @active_idxp: active_index value to be read > + * > + * Read the active_index field from the FWU metadata and place it in > + * the variable pointed to be the

Re: [PATCH v8 02/13] FWU: Add FWU metadata structure and driver for accessing metadata

2022-08-19 Thread Jassi Brar
On Fri, Aug 19, 2022 at 10:25 AM Simon Glass wrote: > > Hi Jassi, > > On Fri, 19 Aug 2022 at 08:59, Jassi Brar wrote: > > > > Hi Simon, > > > > On Thu, Aug 18, 2022 at 12:50 PM Simon Glass wrote: > > > > > > > > +/** > > &

Re: [PATCH v8 02/13] FWU: Add FWU metadata structure and driver for accessing metadata

2022-08-19 Thread Jassi Brar
Hi Simon, On Thu, Aug 18, 2022 at 12:50 PM Simon Glass wrote: > > > > +/** > > > > + * struct fwu_image_bank_info - firmware image information > > > > + * @image_uuid: Guid value of the image in this bank > > > > + * @accepted: Acceptance status of the image > > > > + * @reserved: Reserved > >

Re: [PATCH v8 06/13] FWU: Add helper functions for accessing FWU metadata

2022-08-17 Thread Jassi Brar
On Wed, 17 Aug 2022 at 07:44, Sughosh Ganu wrote: . > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c > new file mode 100644 > index 00..9808036eec > --- /dev/null > +++ b/lib/fwu_updates/fwu.c > @@ -0,0 +1,22 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + *

Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox

2022-07-25 Thread Jassi Brar
Hi Sughosh, On Mon, 25 Jul 2022 at 02:18, Sughosh Ganu wrote: > > hi Jassi, > > On Fri, 22 Jul 2022 at 23:12, wrote: > > > > From: Jassi Brar > > > > The mtd and synquacer (developerbox) support was dropped from v6[1] > > This patchset re-introdu

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-22 Thread Jassi Brar
On Fri, Jul 22, 2022 at 3:37 AM Ilias Apalodimas wrote: > > Hi Jassi > > On Wed, 20 Jul 2022 at 17:30, Jassi Brar wrote: > > > > On Wed, Jul 20, 2022 at 2:54 AM Ilias Apalodimas > > wrote: > > > > > > Hi Jassi, > > > >

Re: [PATCH v7 06/13] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-07-21 Thread Jassi Brar
On Thu, 14 Jul 2022 at 13:40, Sughosh Ganu wrote: > > Add helper functions needed for accessing the FWU metadata which > contains information on the updatable images. These functions have > been added for the STM32MP157C-DK2 board which has the updatable > images on the uSD card, formatted as GPT

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-20 Thread Jassi Brar
On Wed, Jul 20, 2022 at 2:54 AM Ilias Apalodimas wrote: > > Hi Jassi, > > On Tue, 19 Jul 2022 at 18:27, Jassi Brar wrote: > > > > On Mon, 18 Jul 2022 at 16:00, Tom Rini wrote: > > > On Mon, Jul 18, 2022 at 1

Re: [PATCH v5 20/23] FWU: synquacer: Generate dfu_alt_info from devicetree partition

2022-07-19 Thread Jassi Brar
On Tue, 19 Jul 2022 at 20:13, Takahiro Akashi wrote: > > On Mon, Jul 18, 2022 at 09:49:56AM -0500, Jassi Brar wrote: > > On Fri, 17 Jun 2022 at 09:02, Michal Simek wrote: > > > On 6/9/22 14:30, Sughosh Ganu wrote: > > > > From: Masami Hiramatsu > > ...

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-19 Thread Jassi Brar
On Mon, Jul 18, 2022 at 4:00 PM Tom Rini wrote: > On Mon, Jul 18, 2022 at 10:31:56AM -0500, Jassi Brar wrote: > > > > > > > > + > > > > > > > > +#define PLAT_METADATA_OFFSET 0x51 > > > > >

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-19 Thread Jassi Brar
On Mon, 18 Jul 2022 at 16:00, Tom Rini wrote: > On Mon, Jul 18, 2022 at 10:31:56AM -0500, Jassi Brar wrote: > > > > > > > > > > > > > > + > > > > > > > > +#define PLAT_METADATA_OFFSET 0x51 > &g

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-18 Thread Jassi Brar
On Mon, 18 Jul 2022 at 10:31, Jassi Brar wrote: > > Hi Ilias, > > On Mon, 18 Jul 2022 at 10:16, Ilias Apalodimas > wrote: > > > > Hi Jassi > > > > On Mon, 18 Jul 2022 at 18:08, Jassi Brar wrote: > > > > > > On Mon, 18 Jul 2022 at 09:

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-18 Thread Jassi Brar
Hi Ilias, On Mon, 18 Jul 2022 at 10:16, Ilias Apalodimas wrote: > > Hi Jassi > > On Mon, 18 Jul 2022 at 18:08, Jassi Brar wrote: > > > > On Mon, 18 Jul 2022 at 09:47, Ilias Apalodimas > > wrote: > > > > > > Hi all, > > > >

Re: [PATCH v6 00/13] FWU: Add FWU Multi Bank Update feature support

2022-07-18 Thread Jassi Brar
On Mon, 4 Jul 2022 at 00:17, Sughosh Ganu wrote: > > The earlier patchset contained patches for both the DK2 and the > Synquacer platforms. The handling of review comments for the Synquacer > platform is to be taken up by a different engineer, and > That would be me. > has not been > done

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-18 Thread Jassi Brar
On Mon, 18 Jul 2022 at 09:47, Ilias Apalodimas wrote: > > Hi all, > > On Mon, 18 Jul 2022 at 17:43, Jassi Brar wrote: > > > > On Mon, 20 Jun 2022 at 03:23, Michal Simek wrote: > > > On 6/9/22 14:30, Sughosh Ganu wrot

Re: [PATCH v5 20/23] FWU: synquacer: Generate dfu_alt_info from devicetree partition

2022-07-18 Thread Jassi Brar
On Fri, 17 Jun 2022 at 09:02, Michal Simek wrote: > On 6/9/22 14:30, Sughosh Ganu wrote: > > From: Masami Hiramatsu . > > > > @@ -188,6 +178,9 @@ int board_late_init(void) > > { > > int ret; > > > > + /* Make mmc available for EFI */ > > + run_command("mmc dev 0", 0); > > +

Re: [PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-07-18 Thread Jassi Brar
On Mon, 20 Jun 2022 at 03:23, Michal Simek wrote: > On 6/9/22 14:30, Sughosh Ganu wrote: > > From: Masami Hiramatsu > > > > +} > > + > > +static int plat_sf_get_flash(struct spi_flash **flash) > > +{ > > + int ret = 0; > > + > > + if (!plat_spi_flash) > > + ret =

Re: [PATCH v7 01/13] dt/bindings: Add bindings for FWU Metadata storage device

2022-07-16 Thread Jassi Brar
On Thu, 14 Jul 2022 at 13:39, Sughosh Ganu wrote: > > Add bindings needed for accessing the FWU metadata partitions. These > include the compatible string which point to the access method and the > actual device which stores the FWU metadata. > > The current patch adds basic bindings needed for

Re: [PATCH 4/4] spi: synquacer: simplify tx completion checking

2022-05-18 Thread Jassi Brar
Okamoto > --- Acked-by: Jassi Brar

  1   2   >