Re: [PATCH v3] board: rockchip: add Radxa ROCK 3 Model C

2024-07-22 Thread Jonas Karlman
2230 Connector > - GbE LAN with POE > - 3.5mm jack with mic > - HDMI 2.0, MIPI DSI/CSI > - USB 3.0 Host/OTG, USB 2.0 Host > - 40-pin GPIO expansion ports > > Signed-off-by: Maxim Moskalets > Suggested-by: Jonas Karlman > --- > v3: > add suggested by Jonas

Re: [PATCH v2] rockchip: bring-up to Radxa Rock 3C board

2024-07-21 Thread Jonas Karlman
Hi Maxim, On 2024-07-21 16:53, Maxim Moskalets wrote: > Just copy of rock-3a-rk3568_defconfig with dts for rock-3c-rk3566. > Separated from the original due to the use of different DTS, than > fixed primarily network support. What does this reference to? There has never been support for ROCK 3C

Re: [PATCH v2 2/5] phy: rockchip: naneng-combphy: Introduce PHY-IDs to fix RK3588 muxing

2024-07-21 Thread Jonas Karlman
Hi Sebastian, On 2024-07-16 22:42, Sebastian Kropatsch wrote: > Fix multiplex configuration for PCIe1L0 and PCIe1L1 in PCIESEL_CON for > RK3588 to correctly select between Combo PHYs and PCIe3 PHY. > Currently, the code incorrectly muxes both ports to Combo PHYs, > interfering with PCIe3 PHY

Re: radxa cm3 2024.01 mmc write error

2024-07-11 Thread Jonas Karlman
Hi Marek, On 2024-07-10 21:26, Belisko Marek wrote: > Hi, > > I'm playing with radxa cme and mainline u-boot 2024.01 (present in > scarthgap yocto). > I realized that mmc write fails all the time like: > => md.l $loadaddr > 00c00800: ff7ff7eb fffd fff5 9fff > => mmc

Re: [PATCH v5 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-27 Thread Jonas Karlman
Hi Simon, On 2024-06-27 10:02, Simon Glass wrote: > Hi Jonas, > > On Wed, 26 Jun 2024 at 17:16, Jonas Karlman wrote: >> >> Hi Simon, >> >> On 2024-06-26 17:59, Simon Glass wrote: >>> The code here is confusing due to large blocks which are #ifdefe

Re: [PATCH v5 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-26 Thread Jonas Karlman
Hi Simon, On 2024-06-26 17:59, Simon Glass wrote: > The code here is confusing due to large blocks which are #ifdefed out. > Add a function phase_sdram_init() which returns whether SDRAM init > should happen in the current phase, using that as needed to control the > code flow. > > This

Re: [PATCH v4 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-26 Thread Jonas Karlman
Hi Simon, On 2024-06-26 16:54, Simon Glass wrote: > Hi Jonas, > > On Mon, 24 Jun 2024 at 09:53, Jonas Karlman wrote: >> >> Hi Simon, >> >> On 2024-06-23 19:53, Simon Glass wrote: >>> The code here is confusing due to large blocks which are #ifdefe

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-25 Thread Jonas Karlman
Hello Etienne, On 2024-06-25 12:12, Etienne Dublé wrote: > > Hello Jonas, > > Le 25/06/2024 à 10:29, Jonas Karlman a écrit : >> I do not understand the need for such/this patch. The changed address is >> the internal io address that is shared with the pci controller and

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-25 Thread Jonas Karlman
Hi Etienne, On 2024-06-25 08:47, Etienne Dublé wrote: > Hi Quentin, > > Le 24/06/2024 à 15:15, Quentin Schulz a écrit : >> Hi Etienne, >> >> On 6/24/24 2:40 PM, ETIENNE DUBLE wrote: >>> One of the PCI ranges was wrong in this device tree. >>> When testing with a FriendlyElec Nanopi R5C board,

Re: [PATCH v4 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-24 Thread Jonas Karlman
Hi Simon, On 2024-06-23 19:53, Simon Glass wrote: > The code here is confusing due to large blocks which are #ifdefed out. > Add a function phase_sdram_init() which returns whether SDRAM init > should happen in the current phase, using that as needed to control the > code flow. > > This

Re: [RFC] rockchip: add support for Radxa ROCK Pi E v3.0 which uses DDR4 SDRAM

2024-06-23 Thread Jonas Karlman
On 2024-06-23 06:15, FUKAUMI Naoki wrote: > rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in > upstream. only difference between v3.0 and prior ver. is, using > rk3328-sdram-ddr4-666.dtsi instead of rk3328-sdram-ddr3-666.dtsi. > > here is console output from ROCK Pi E v3.0: > >

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-21 Thread Jonas Karlman
Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: > The code here is confusing due to large blocks which are #ifdefed out. > Add a function phase_sdram_init() which returns whether SDRAM init > should happen in the current phase, using that as needed to control the > code flow. > > This

Re: [PATCH v2 2/3] rockchip: rk3328: Enable ARMv8 crypto extensions

2024-06-18 Thread Jonas Karlman
Hi Jagan, On 2024-06-18 21:18, Jagan Teki wrote: > On Mon, 22 Apr 2024 at 01:40, Jonas Karlman wrote: >> >> The RK3328 SoC support ARMv8 Cryptography Extensions and use of the >> ARMv8 crypto extensions help speed up FIT checksum validation in SPL. >> >> Imply

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Jonas Karlman
Hi Quentin, On 2024-06-17 16:03, Quentin Schulz wrote: > Hi Jonas, > > On 6/17/24 3:44 PM, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2024-06-17 15:29, Quentin Schulz wrote: >>> Hi Jonas, >>> >>> On 6/17/24 3:26 PM, Jonas Karlman wrote: &

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Jonas Karlman
Hi Quentin, On 2024-06-17 15:29, Quentin Schulz wrote: > Hi Jonas, > > On 6/17/24 3:26 PM, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2024-06-17 15:10, Quentin Schulz wrote: >>> From: Quentin Schulz >>> >>> In commit 100f489f58a6 (&q

Re: [PATCH COVER] rockchip: rk3399: fix SPI-NOR flash not found in U-Boot pre-reloc

2024-06-17 Thread Jonas Karlman
rom eMMC") > Signed-off-by: Quentin Schulz Reviewed-by: Jonas Karlman Regards, Jonas > --- > arch/arm/dts/rk3399-u-boot.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi > index b6b43271172..2be

Re: [PATCH 1/2] phy: Extend generic_setup_phy() with PHY mode and submode

2024-06-16 Thread Jonas Karlman
s not error out, so this > should not break any existing systems. > > Signed-off-by: Marek Vasut > --- > Cc: Caleb Connolly > Cc: Fabio Estevam > Cc: Fabrice Gasnier > Cc: Jonas Karlman > Cc: Mathieu Othacehe > Cc: Mattijs Korpershoek > Cc: Neil Armstrong

Re: [PATCH 2/3] arm: dts: rockchip: rock-5a: enable USB3 OTG port

2024-06-16 Thread Jonas Karlman
On 2024-06-15 09:46, FUKAUMI Naoki wrote: > enable USB3 OTG (upper) port for ums and rockusb commands on ROCK 5A. > > Signed-off-by: FUKAUMI Naoki > --- > arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi | 16 > 1 file changed, 16 insertions(+) > > diff --git

Re: [PATCH 1/3] rockchip: rock-3a: rock5a: rock5b: add USB GADGET related configs

2024-06-16 Thread Jonas Karlman
On 2024-06-15 09:46, FUKAUMI Naoki wrote: > add USB GADGET related configs for USB OTG port on ROCK 3A/5A/5B. > > Signed-off-by: FUKAUMI Naoki > --- > configs/rock-3a-rk3568_defconfig | 6 ++ > configs/rock5a-rk3588s_defconfig | 6 ++ > configs/rock5b-rk3588_defconfig | 1 + > 3 files

Re: [PATCH v2 7/9] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-11 Thread Jonas Karlman
Hi Simon and Quentin, On 2024-06-11 13:27, Quentin Schulz wrote: > Hi Simon, > > On 6/10/24 4:59 PM, Simon Glass wrote: >> At present gd->ram_size is 0 in SPL, meaning that it is not possible to >> enable the cache. Correct this by always populating the RAM size >> correctly. >> >> Part of the

Re: [PATCH 7/9] rockchip: bob: kevin: Disable dcache in SPL

2024-06-05 Thread Jonas Karlman
Hi Simon, On 2024-06-05 05:25, Simon Glass wrote: > This causes a hang, so disable it. When I initially tested this on multiple boards there was some boards that also hanged, that turned out to be an issue in one of the drivers. If I remember correctly such hang was related to a null pointer

Re: [PATCH 4/9] power: regulator: Handle autoset in regulators_enable_boot_on()

2024-06-05 Thread Jonas Karlman
s also called for rockchip boards in the rockchip common boards.c board_init(). Maybe the call to regulators_enable_boot_on() in veyron_init() could be dropped? > > Fixes: d99fb64a98a power: regulator: Only run autoset once for each regulator > > Signed-off-by: Simon Glass Reviewed

Re: [PATCH v1 0/5] FUSB302 USB-C controller support

2024-06-03 Thread Jonas Karlman
Hi Sebastian, On 2024-05-31 17:08, Sebastian Reichel wrote: > Hi, > > On ROCK 5B power is usually supplied via it's USB-C port. This port has the > data lines connected to RK3588, VBUS connected to the input regulator and > CC pins connected to FUSB302. FUSB302 is a USB-C controller, which can

Re: [PATCH RFC v2 22/23] sysreset: rockchip: use fst reset for ARM64 SOC

2024-05-31 Thread Jonas Karlman
Hi Anand and Kever, On 2024-05-31 16:18, Anand Moon wrote: > From: Kever Yang > > Rockchip ARM64 SOC will change cpu entry, only fst reset can reset it. What is this trying to fix? And what SoCs is affected? My arm64 RK SoCs seem to reset using warm reset (second global reset). > > Cc:

Re: [PATCH v3 7/7] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-27 Thread Jonas Karlman
Hi Jianfeng, On 2024-05-27 19:02, Jianfeng Liu wrote: > ArmSoM Sige7 is a Rockchip RK3588 based SBC (Single Board Computer) by > ArmSoM. > > There are two variants depending on the DRAM size : 8G and 16G. > > Specification: > > Rockchip Rk3588 SoC > 4x ARM Cortex-A76, 4x ARM Cortex-A55

Re: [PATCH v3 0/7] add ArmSoM Sige7 Rk3588 board

2024-05-27 Thread Jonas Karlman
Hi Jianfeng, On 2024-05-27 19:02, Jianfeng Liu wrote: > Devicetree of ArmSoM Sige7 is merged to kernel v6.10-rc1 with USBDP and > GPU nodes. So I use update-dts-subtree.sh to pick related commits of > rk3588s.dtsi, and then pick the commit of ArmSoM Sige7's devicetree. > I also did run command: >

Re: [PATCH v2] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-22 Thread Jonas Karlman
On 2024-05-22 20:03, Quentin Schulz wrote: > Hi Jianfeng Liu, > > On 5/22/24 6:58 PM, Jianfeng Liu wrote: > [...] >> Note that these commits: >> - e18e5e8188f2 (arm64: dts: rockchip: add USBDP phys on rk3588) >> - 6fca4edb93d3 (arm64: dts: rockchip: Add rk3588 GPU node) >> are not synced to

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-22 Thread Jonas Karlman
On 2024-05-22 16:18, Alex Bee wrote: > Am 13.05.24 um 01:22 schrieb Jonas Karlman: >> On 2024-05-13 00:34, Alex Bee wrote: >>> Am 12.05.24 um 23:37 schrieb Jonas Karlman: >>>> Hi Alex, >>>> >>>> On 2024-05-12 21:49, Alex Bee wrote: >>&g

Re: [ANN] U-Boot v2024.07-rc3 released

2024-05-21 Thread Jonas Karlman
Hi Quentin, On 2024-05-21 11:53, Quentin Schulz wrote: > Hi all, > > On 5/20/24 6:06 PM, Tom Rini wrote: >> Hey all, >> >> It's release day and here is -rc3. At this point, I think we're firmly >> on "bug fix and documentation" ground moving forward for changes to >> v2024.07 and the next branch

Re: [PATCH v1 6/9] rockchip: RK3568: Read the reset cause from clock reset unit for RK356x SoC

2024-05-16 Thread Jonas Karlman
Hi Anand, On 2024-05-16 10:59, Anand Moon wrote: > Read the reset cause from clock reset unit for RK356x SoC. > > Cc: Jagan Teki > Signed-off-by: Anand Moon > --- > arch/arm/mach-rockchip/cpu-info.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH v1 5/9] arm: rockchip: Enable display cpuinfo to be build with SPL_BUILD

2024-05-16 Thread Jonas Karlman
Hi Anand, On 2024-05-16 10:59, Anand Moon wrote: > Changes help enable CONFIG_DISPLAY_CPUINFO to build with SPL_BUILD for > SoC RK356x and RK3588. > > Cc: Jagan Teki > Signed-off-by: Anand Moon > --- > arch/arm/mach-rockchip/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v2 09/12] clk: boston: Allow to get regmap from parent device

2024-05-16 Thread Jonas Karlman
Hi Jiaxun, On 2024-05-16 13:40, Jiaxun Yang wrote: > In upstream devicetree, clk_boston is a child of syscon node > and there is no "regmap" property for clk_boston node. > > Try to check parent device first to look for syscon. > > Signed-off-by: Jiaxun Yang > --- > v2: Move syscon_get_regmap

Re: [PATCH 1/1] Squashed 'dts/upstream/' changes from b35b9bd1d4ee..7e08733c96c8

2024-05-15 Thread Jonas Karlman
Hi Sumit, On 2024-05-15 10:49, Sumit Garg wrote: > Hi Jonas, > > On Wed, 15 May 2024 at 13:11, Jonas Karlman wrote: >> >> Hi Tom, >> >> On 2024-05-14 18:42, Tom Rini wrote:> >>> git-subtree-dir: dts/upstream >>> git-subtree-split: 7e08733c9

Re: [PATCH 1/1] Squashed 'dts/upstream/' changes from b35b9bd1d4ee..7e08733c96c8

2024-05-15 Thread Jonas Karlman
Hi Tom, On 2024-05-14 18:42, Tom Rini wrote:> > git-subtree-dir: dts/upstream > git-subtree-split: 7e08733c96c84eb323f47e9b248c924e2ac6272a > --- > This moves OF_UPSTREAM to be tracking the v6.9 release and is for the > -next branch. To test these changes yourself locally, either use my >

Re: [PATCH 09/13] syscon: Probe device first in syscon_get_regmap

2024-05-15 Thread Jonas Karlman
Hi Jiaxun, On 2024-05-15 02:12, Jiaxun Yang wrote: > > > 在2024年5月14日五月 下午3:50,Jonas Karlman写道: >> Hi Jiaxun, > [...] >>> + return ERR_PTR(ret); >> >> Please explain in more details what the issue this is trying to solve. >> >> T

Re: [PATCH 09/13] syscon: Probe device first in syscon_get_regmap

2024-05-14 Thread Jonas Karlman
Hi Jiaxun, On 2024-05-13 20:13, Jiaxun Yang wrote: > When bootph-all is enabled for a syscon driver, the device > may leave unprobed when syscon_get_regmap is called by another > driver. > > Perform device_probe in syscon_get_regmap, there is no side > affect as device_probe will return 0

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-12 Thread Jonas Karlman
On 2024-05-13 00:34, Alex Bee wrote: > > Am 12.05.24 um 23:37 schrieb Jonas Karlman: >> Hi Alex, >> >> On 2024-05-12 21:49, Alex Bee wrote: >>> Am 11.05.24 um 20:47 schrieb Jonas Karlman: >>>> Hi Alex, >>>> >>>> On 2024-05-11 19

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-12 Thread Jonas Karlman
Hi Mark, On 2024-05-12 22:41, Mark Kettenis wrote: >> Date: Sat, 11 May 2024 22:55:18 +0200 >> From: Jonas Karlman >> >> Hi Mark, >> >> On 2024-05-11 21:57, Mark Kettenis wrote: >>>> Date: Sat, 11 May 2024 20:47:40 +0200 >>>> Fr

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-12 Thread Jonas Karlman
Hi Alex, On 2024-05-12 21:49, Alex Bee wrote: > Am 11.05.24 um 20:47 schrieb Jonas Karlman: >> Hi Alex, >> >> On 2024-05-11 19:44, Alex Bee wrote: >>> Hi Jonas, >>> >>> Am 11.05.24 um 13:28 schrieb Jonas Karlman: >>>> This series

[PATCH 9/9] rockchip: gpio: Add gpio-ranges props

2024-05-12 Thread Jonas Karlman
-by: Jonas Karlman --- Cc: Johan Jonker --- arch/arm/dts/rk3036-u-boot.dtsi | 12 arch/arm/dts/rk3066a-u-boot.dtsi | 3 +-- arch/arm/dts/rk3128-u-boot.dtsi | 16 arch/arm/dts/rk322x-u-boot.dtsi | 16 arch/arm/dts/rk3288-u-boot.dtsi | 33

[PATCH 8/9] pinctrl: rockchip: Add pinmux status related ops

2024-05-12 Thread Jonas Karlman
: gpio GPIO0_A7 : func-1 GPIO0_B0 : gpio GPIO0_B1 : func-1 GPIO0_B2 : func-1 GPIO0_B3 : gpio [...] The change to use ENOENT for unrouted pins also help hide a "Error -22" message for unrouted pins using the gpio status -a cmd. Signed-off-by: Jonas Karlman --- .../pinctrl/

[PATCH 6/9] gpio: rockchip: Get pinctrl device from gpio-ranges prop

2024-05-12 Thread Jonas Karlman
Get pinctrl device from gpio-ranges phandle when the property exists, fallback to get the first pinctrl device. Signed-off-by: Jonas Karlman --- drivers/gpio/rk_gpio.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/rk_gpio.c b

[PATCH 7/9] gpio: rockchip: Use pinctrl pin offset to get_gpio_mux()

2024-05-12 Thread Jonas Karlman
are used meaning the pinctrl pin offset start at pin 24 for gpio1. Use DIV_ROUND_UP to get the 32 pin aligned bank num. Signed-off-by: Jonas Karlman --- drivers/gpio/rk_gpio.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers

[PATCH 2/9] pinctrl: rockchip: rv1126: Fix support for IOMUX_L_SOURCE_PMU flag

2024-05-12 Thread Jonas Karlman
nctrl support"). Signed-off-by: Jonas Karlman --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c b/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c index b6

[PATCH 1/9] pinctrl: rockchip: rk3188: Fix support for IOMUX_GPIO_ONLY flag

2024-05-12 Thread Jonas Karlman
Signed-off-by: Jonas Karlman --- Based on the old Linux commit and TRM it looks like GPIO0_B0-B7 should also be flagged as IOMUX_GPIO_ONLY. --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockchip/pinctrl-rockc

[PATCH 4/9] pinctrl: rockchip: Use syscon_regmap_lookup_by_phandle()

2024-05-12 Thread Jonas Karlman
Use syscon_regmap_lookup_by_phandle() to simplify the code. Signed-off-by: Jonas Karlman --- .../pinctrl/rockchip/pinctrl-rockchip-core.c | 39 ++- 1 file changed, 12 insertions(+), 27 deletions(-) diff --git a/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c b/drivers

[PATCH 5/9] pinctrl: rockchip: Update get_gpio_mux() ops

2024-05-12 Thread Jonas Karlman
verify_config() of banknum and index to avoid an out of range access of the pin_banks array, i.e. with gpio6 on rk3066a. Signed-off-by: Jonas Karlman --- The pin_to_mux() helper will be used in the get_pin_muxing() ops added in a later patch to support the pinmux status cmd. --- .../pinctrl/rockchip

[PATCH 3/9] pinctrl: rockchip: rk3588: Fix support for rockchip_get_mux()

2024-05-12 Thread Jonas Karlman
GPIO IOMUX control is located at PMU2_IOC or BUS_IOC offset on RK3588. Based on Linux commit fdc33eba11c5 ("pinctrl/rockchip: add rk3588 support"). Compared to the Linux commit, this include a fix so that the iomux of GPIO0_B4-D7 is reported correctly. Signed-off-by: Jonas Karlman -

[PATCH 0/9] rockchip: pinctrl: Minor fixes and add support for pinmux status cmd

2024-05-12 Thread Jonas Karlman
ranges props for RK3288. This series depends on the "rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround" [1] series. [1] https://patchwork.ozlabs.org/cover/1934100/ Jonas Karlman (9): pinctrl: rockchip: rk3188: Fix support for IOMUX_GPIO_ONLY flag pinctrl: rockchi

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-11 Thread Jonas Karlman
Hi Mark, On 2024-05-11 21:57, Mark Kettenis wrote: >> Date: Sat, 11 May 2024 20:47:40 +0200 >> From: Jonas Karlman > > Hi Jonas & Alex, > >> Hi Alex, >> >> On 2024-05-11 19:44, Alex Bee wrote: >>> Hi Jonas, >>> >>> Am 11.0

Re: [PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-11 Thread Jonas Karlman
Hi Alex, On 2024-05-11 19:44, Alex Bee wrote: > Hi Jonas, > > Am 11.05.24 um 13:28 schrieb Jonas Karlman: >> This series add gpio request() and pinctrl gpio_request_enable() ops so >> that a gpio requested pin automatically use gpio pinmux and U-Boot >> behaves m

[PATCH 3/4] rockchip: rk3568-rock-3a: Drop PCIe reset-gpios workaround

2024-05-11 Thread Jonas Karlman
automatically use gpio pinmux when a gpio is requested. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 12 1 file changed, 12 deletions(-) diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi index 9d18f5d0b364

[PATCH 4/4] rockchip: rk3568-radxa-e25: Drop PCIe reset-gpios workaround

2024-05-11 Thread Jonas Karlman
automatically use gpio pinmux when a gpio is requested. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi | 12 1 file changed, 12 deletions(-) diff --git a/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi b/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi index 74755a44eaee

[PATCH 2/4] gpio: rockchip: Add request() ops

2024-05-11 Thread Jonas Karlman
Some boards use pinctrl to set a non-gpio pinmux on a pin that is later requested to be used for gpio output. Add a request() ops that call pinctrl_gpio_request() when the required gpio-ranges prop has been defined to signal pinctrl driver to use gpio pinmux. Signed-off-by: Jonas Karlman

[PATCH 1/4] pinctrl: rockchip: Add gpio_request_enable() ops

2024-05-11 Thread Jonas Karlman
, similar to Linux kernel. Reset ctrl->nr_pins to 0 so that pin_to_bank() can locate a bank after the second probe in U-Boot proper. Signed-off-by: Jonas Karlman --- The pin_to_bank() helper will also be used in a follow up series adding support for the pinmux status cmd. --- .../pinctrl/rockc

[PATCH 0/4] rockchip: Add gpio request() ops and drop PCIe reset-gpios workaround

2024-05-11 Thread Jonas Karlman
from board u-boot.dtsi. PX30, RK3066, RK3188, RK356x and RK3588 are the only SoCs that currently define gpio-ranges props and is affected by this series. A follow up series adding support for the pinmux status cmd will also add gpio-ranges props for remaining RK SoCs. Jonas Karlman (4): pinctrl

[PATCH] pinctrl: Fix pinctrl_gpio_get_pinctrl_and_offset()

2024-05-10 Thread Jonas Karlman
n pin controller "foo" instead of "bar". Fix this by using an exclusive range check. Fixes: d0bb00adccb8 ("pinctrl: fix pinctrl_gpio_get_pinctrl_and_offset for gpio-ranges array") Signed-off-by: Jonas Karlman --- drivers/pinctrl/pinctrl-uclass.c | 2 +- 1 file changed,

Re: [PATCH v1] rockchip: rv1126: Migrate to OF_UPSTREAM

2024-05-09 Thread Jonas Karlman
Hi Anand, On 2024-05-09 18:42, Anand Moon wrote: > Hi Jonas > > On Thu, 9 May 2024 at 21:38, Jonas Karlman wrote: >> >> Hi, >> >> On 2024-05-09 17:26, Anand Moon wrote: >>> Migrate RV1126 boards that exists in Linux v6.8 to use OF_UPSTREAM. >&g

Re: [PATCH v1] rockchip: rv1126: Migrate to OF_UPSTREAM

2024-05-09 Thread Jonas Karlman
Hi, On 2024-05-09 17:26, Anand Moon wrote: > Migrate RV1126 boards that exists in Linux v6.8 to use OF_UPSTREAM. > > Following targets is not migrated to use OF_UPSTREAM: At first I got a little bit confused about the "not migrated", but see now that these are the boards that is migrated. > -

Re: [PATCH v2 03/22] clk: rockchip: rk3399: Improve support for SCLK_PCIEPHY_REF clock

2024-05-06 Thread Jonas Karlman
Hi Quentin, On 2024-05-06 13:07, Quentin Schulz wrote: > Hi Jonas, > > On 5/1/24 6:22 PM, Jonas Karlman wrote: >> rk3399-nanopi-4.dtsi try to set parent of and set rate to 100 MHz of the >> SCLK_PCIEPHY_REF clock. >> >> The existing enable/disable ops for SCLK_P

Re: [PATCH 09/16] rockchip: rk356x: Remove redundant device tree files

2024-05-04 Thread Jonas Karlman
Hi Chris, On 2024-05-04 22:51, Chris Morgan wrote: > On Sat, May 04, 2024 at 07:43:01PM +0000, Jonas Karlman wrote: >> Remove redundant device tree files now that RK356x boards have been >> migrated to use OF_UPSTREAM. >> >> Signed-off-by: Jonas Karlman >> ---

[PATCH 04/16] rockchip: rk3328: Remove redundant device tree files

2024-05-04 Thread Jonas Karlman
Remove redundant device tree files now that RK3328 boards have been migrated to use OF_UPSTREAM. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3328-evb.dts | 289 --- arch/arm/dts/rk3328-nanopi-r2c-plus.dts | 33 - arch/arm/dts/rk3328-nanopi-r2c.dts | 40

[PATCH 15/16] rockchip: rk3588: Migrate to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
Migrate RK3588 boards that exists in Linux v6.8 to use OF_UPSTREAM. Following targets is not migrated to use OF_UPSTREAM: - generic-rk3588: Generic target only meant for U-Boot use - toybrick-rk3588: Merged in v6.9-rc1 Signed-off-by: Jonas Karlman --- arch/arm/dts/Makefile

[PATCH 14/16] rockchip: rk3588: Update USB3 related nodes in u-boot.dtsi

2024-05-04 Thread Jonas Karlman
The USB3 related DT nodes in SoC u-boot.dtsi is slightly different from the final nodes being targeted for Linux kernel v6.10. Sync USB3 related nodes from Linux maintainer v6.10-rockchip-dts64-1 tag to prepare for migration of RK3588 to use OF_UPSTREAM. Signed-off-by: Jonas Karlman --- arch

[PATCH 13/16] rockchip: rk3588-rock-5b: Drop usb-typec node from u-boot.dtsi

2024-05-04 Thread Jonas Karlman
and maximum-speed prop to cleanup the board u-boot.dtsi file. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 106 +--- 1 file changed, 2 insertions(+), 104 deletions(-) diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock

[PATCH 12/16] phy: rockchip: usbdp: Adopt driver to work with upstream DT

2024-05-04 Thread Jonas Karlman
_USB3> Adopt the usbdp phy driver to work with upstream DT binding targeted for Linux kernel v6.10. Signed-off-by: Jonas Karlman --- drivers/phy/rockchip/phy-rockchip-usbdp.c | 63 ++- 1 file changed, 17 insertions(+), 46 deletions(-) diff --git a/drivers/phy/rockchip/phy-

[PATCH 08/16] rockchip: rk356x: Migrate to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
Migrate RK356x boards that exists in Linux v6.8 to use OF_UPSTREAM. Following targets is not migrated to use OF_UPSTREAM: - anbernic-rgxx3-rk3566: Multi device target - generic-rk3568: Generic target only meant for U-Boot use - pinetab2-rk3566: Merged in v6.9-rc1 Signed-off-by: Jonas Karlman

[PATCH 11/16] phy: rockchip: usbdp: Drop rockchip_u3phy_uboot_init()

2024-05-04 Thread Jonas Karlman
Remove the rockchip_u3phy_uboot_init() function, it has no caller and is not needed with proper driver model use. Signed-off-by: Jonas Karlman --- drivers/phy/rockchip/phy-rockchip-usbdp.c | 24 --- 1 file changed, 24 deletions(-) diff --git a/drivers/phy/rockchip/phy

[PATCH 10/16] phy: rockchip: usbdp: Find phy-id from the io address

2024-05-04 Thread Jonas Karlman
river"). Signed-off-by: Jonas Karlman --- drivers/phy/rockchip/phy-rockchip-usbdp.c | 39 --- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c index baf92529348c..8e5821069

[PATCH 05/16] rockchip: rk3399: Migrate to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
-off-by: Jonas Karlman --- arch/arm/dts/Makefile| 31 arch/arm/mach-rockchip/Kconfig | 1 + configs/chromebook_bob_defconfig | 2 +- configs/chromebook_kevin_defconfig | 2 +- configs/eaidk-610-rk3399_defconfig

[PATCH 07/16] rockchip: rk356x: Add rk3568-u-boot.dtsi

2024-05-04 Thread Jonas Karlman
Add a -u-boot.dtsi file that gets included by default for RK356x boards when a board specific u-boot.dtsi file dont exists. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3568-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 arch/arm/dts/rk3568-u-boot.dtsi diff --git

[PATCH 03/16] rockchip: rk3328: Migrate to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
All RK3328 boards has now been synced to Linux kernel v6.8 DTs and can migrate to use OF_UPSTREAM. Migrate all RK3328 boards to use OF_UPSTREAM. Signed-off-by: Jonas Karlman --- arch/arm/dts/Makefile | 11 --- arch/arm/mach-rockchip/Kconfig| 1

[PATCH 02/16] rockchip: rk3308: Remove redundant device tree files

2024-05-04 Thread Jonas Karlman
Remove redundant device tree files now that RK3308 boards have been migrated to use OF_UPSTREAM. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3308-evb.dts| 230 --- arch/arm/dts/rk3308-roc-cc.dts | 190 --- arch/arm/dts/rk3308-rock-pi-s.dts | 314 arch/arm

[PATCH 01/16] rockchip: rk3308: Migrate to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
All RK3308 boards has now been synced to Linux kernel v6.8 DTs and can migrate to use OF_UPSTREAM. Migrate all RK3308 boards to use OF_UPSTREAM. Signed-off-by: Jonas Karlman --- arch/arm/dts/Makefile | 5 - arch/arm/mach-rockchip/Kconfig | 1 + configs/evb-rk3308_defconfig

[PATCH 00/16] rockchip: Migrate RK3308, RK3328, RK356x and RK3588 to OF_UPSTREAM

2024-05-04 Thread Jonas Karlman
-of-upstream-v1 Jonas Karlman (16): rockchip: rk3308: Migrate to OF_UPSTREAM rockchip: rk3308: Remove redundant device tree files rockchip: rk3328: Migrate to OF_UPSTREAM rockchip: rk3328: Remove redundant device tree files rockchip: rk3399: Migrate to OF_UPSTREAM rockchip: rk3399: Remove

Re: [PATCH 2/2] board: rockchip: rgxx3: Use sdmmc0 as first device

2024-05-02 Thread Jonas Karlman
Hi Chris, On 2024-05-02 21:34, Chris Morgan wrote: > From: Chris Morgan > > Some of the rgxx3 devices do not have a way to recover from a poor > flash of a bootloader to eMMC. Set the device to always attempt to boot > from sdmmc0 first which ensures that we can override the boot from > emmc if

[PATCH] clk: rockchip: rk3328: Add SCLK_USB3OTG_REF support

2024-05-01 Thread Jonas Karlman
The SCLK_USB3OTG_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of SCLK_USB3OTG_REF clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman --- This has been runtime tested on a Rock64 and NanoPi R2S Plus. --- drivers/clk/rockchip

[PATCH] rockchip: rk3328: Add missing bootph-some-ram props

2024-05-01 Thread Jonas Karlman
Signed-off-by: Jonas Karlman --- This has been runtime tested on a Rock64 and NanoPi R2S Plus. The uart2m1_xfer change help speed up boot by around 100 ms. --- arch/arm/dts/rk3328-nanopi-r2s-u-boot.dtsi| 2 +- .../rk3328-orangepi-r1-plus-lts-u-boot.dtsi | 7 --- .../dts/rk3328-orangepi

[PATCH v2 21/22] rockchip: rk3399-pinephone-pro: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang --- v2: Collect r-b tags --- arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 12 ++ arch/arm/dts/rk3399-pinephone-pro.dts | 147 ++ configs/pinephone-pro

[PATCH v2 15/22] rockchip: rk3399-nanopi-4: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Only enable AHCI/SCSI on M4 variant v2: Skip enable of PCI on NEO4 variant v2: Keep SDHCI enabled on R4S variant v2: Collect r-b tag --- arch/arm/dts/rk3399-nanopc-t4.dts | 2 +- arch/arm/dts/rk3399-nanopi-m4

[PATCH v2 18/22] rockchip: rk3399-rock-pi-4: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
to configure io-domain voltage. Add PHY_REALTEK=y and DM_ETH_PHY=y to support ethernet PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Christopher Obbard Reviewed-by: Kever Yang --- v2: Collect r-b tags --- arch/arm/dts

[PATCH v2 19/22] rockchip: rk3399-rockpro64: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
=y to support poweroff using cmdline and power on using the pwr button on the board. Add PHY_REALTEK=y and DM_ETH_PHY=y to support ethernet PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang --- v2: Collect r-b

[PATCH v2 17/22] rockchip: rk3399-khadas: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
. Add DM_ETH_PHY=y to support ethernet PHY. Add PHY_ROCKCHIP_INNO_USB2=y and PHY_ROCKCHIP_TYPEC=y to support USB PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Drop enable of AHCI/SCSI support v2: Collect r-b tag --- arch

[PATCH v2 16/22] rockchip: rk3399-rock960: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
CMD_ROCKUSB=y, CMD_USB_MASS_STORAGE=y and USB_GADGET=y to support RockUSB and UMS gadget. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Drop enable of AHCI/SCSI support on ROCK960 v2: Collect r-b tag --- arch/arm/dts/rk3399

[PATCH v2 20/22] rockchip: rk3399-pinebook-pro: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang --- v2: Collect r-b tags --- arch/arm/dts/rk3399-pinebook-pro.dts | 24 +++- configs/pinebook-pro-rk3399_defconfig | 6 -- 2 files changed, 11 insertions(+), 19

[PATCH v2 22/22] rockchip: rk3399: Drop ethernet0 alias from SoC u-boot.dtsi

2024-05-01 Thread Jonas Karlman
Remove the obsolete ethernet0 alias now that all board device tree files have been fully synced with Linux kernel v6.8. Signed-off-by: Jonas Karlman --- v2: New patch --- arch/arm/dts/rk3399-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch

[PATCH v2 13/22] rockchip: rk3399-orangepi: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
and DM_ETH_PHY=y to support ethernet PHY. Add PHY_ROCKCHIP_INNO_USB2=y and PHY_ROCKCHIP_TYPEC=y to support USB PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect r-b tag --- arch/arm/dts/rk3399-orangepi.dts | 12

[PATCH v2 14/22] rockchip: rk3399-roc-pc: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
and DM_ETH_PHY=y to support ethernet PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Remove USE_PREBOOT=y to speed up booting, standard boot will init USB after faster boot media has been evaluated. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Drop enable of AHCI/SCSI

[PATCH v2 10/22] rockchip: rk3399-leez: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
and DM_ETH_PHY=y to support ethernet PHY. Add PHY_ROCKCHIP_INNO_USB2=y and PHY_ROCKCHIP_TYPEC=y to support USB PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect r-b tag --- arch/arm/dts/rk3399-leez-p710.dts | 8 +--- configs

[PATCH v2 12/22] rockchip: rk3399-firefly: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
PHY_ROCKCHIP_INNO_USB2=y and PHY_ROCKCHIP_TYPEC=y to support USB PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Drop enable of AHCI/SCSI support v2: Collect r-b tag --- arch/arm/dts/rk3399-firefly.dts | 17

[PATCH v2 11/22] rockchip: rk3399-evb: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
can be up to 256 KiB. Remove CONFIG_NET_RANDOM_ETHADDR=y, ethaddr and eth1addr is set based on cpuid read from eFUSE. Add PHY_REALTEK=y and DM_ETH_PHY=y to support ethernet PHY. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2

[PATCH v2 09/22] rockchip: rk3399-eaidk-610: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
and DM_ETH_PHY=y to support ethernet PHY. Add PHY_ROCKCHIP_INNO_USB2=y and PHY_ROCKCHIP_TYPEC=y to support USB PHY. Remove REGULATOR_PWM=y, board does not use pwm-regulator compatible. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect

[PATCH v2 06/22] rockchip: rk3399-gru: Sync DT from Linux kernel v6.8

2024-05-01 Thread Jonas Karlman
Sync rk3399-gru related device tree from Linux kernel v6.8. The spi_flash symbol is no longer part of upstream DT, it is re-defined to allow existing reference use in related u-boot.dtsi-files. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect r-b tag The spi_flash node

[PATCH v2 05/22] rockchip: rk3399: Sync SoC DT from Linux kernel v6.8

2024-05-01 Thread Jonas Karlman
, both can supply random numbers. There is no other intended change with this patch. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Add ethernet0 alias to rk3399-u-boot.dtsi v2: Keep dfi node for all boot phases v2: Collect r-b tag --- arch/arm/dts/rk3399-op1-opp.dtsi | 31

[PATCH v2 08/22] rockchip: rk3399-rock-pi-n10: Sync DT from v6.8 and update defconfig

2024-05-01 Thread Jonas Karlman
PHY_REALTEK=y and DM_ETH_PHY=y to support ethernet PHY. Remove REGULATOR_PWM=y, board does not use pwm-regulator compatible. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect r-b tag --- arch/arm/dts/rk3288-vmarc-som.dtsi| 48 +++ arch/arm/dts/rk3399pro

[PATCH v2 07/22] rockchip: rk3399-puma: Sync DT from Linux kernel v6.8

2024-05-01 Thread Jonas Karlman
Sync rk3399-puma related device tree from Linux kernel v6.8. The vdd_log node is already part of rk3399-puma.dtsi, only keep the regulator-init-microvolt prop in u-boot.dtsi. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang --- v2: The SPL_PAD_TO defconfig

[PATCH v2 01/22] clk: rockchip: rk3399: Rename SCLK_DDRCLK to SCLK_DDRC

2024-05-01 Thread Jonas Karlman
Sync rk3399-cru.h with one from Linux kernel v6.2+ and fix use of the SCLK_DDRCLK name that was only used by U-Boot. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: Collect r-b tag The dt-bindings/clock/rk3399-cru.h file could instead be dropped to pick an updated version from dts

[PATCH v2 04/22] clk: rockchip: rk3399: Add SCLK_USB3OTGx_REF support

2024-05-01 Thread Jonas Karlman
The SCLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of SCLK_USB3OTGx_REF clocks to fix reference clock period configuration. Also replace use of 2400 with the OSC_HZ constant. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz

[PATCH v2 00/22] rockchip: rk3399: Sync DT with v6.8 and update defconfigs

2024-05-01 Thread Jonas Karlman
nds on the following series: - rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC [1] A copy of this series and its depend can be found at [2] [1] https://patchwork.ozlabs.org/cover/1929673/ [2] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3399-dt-sync-v2-part2 Jo

[PATCH v2 03/22] clk: rockchip: rk3399: Improve support for SCLK_PCIEPHY_REF clock

2024-05-01 Thread Jonas Karlman
assign-clock props for pciephy refclk in DT. This limited implementation only support setting 24 or 100 MHz rate, and expect npll and clk_pciephy_ref100m divider to use default values. Signed-off-by: Jonas Karlman --- v2: Implement partial instead of dummy support for SCLK_PCIEPHY_REF

  1   2   3   4   5   6   7   8   9   10   >