Re: [PATCH v3 20/28] rockchip: rk3588-toybrick: Add .dtb-file entry in Makefile

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Add Rockchip Toybrick TB-RK3588X .dtb-file entry in Makefile. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: New patch split f

Re: [PATCH v3 19/28] rockchip: rk3588-toybrick: Use pinctrl and aliases in SPL

2024-04-22 Thread Kever Yang
. Also enable the SPL_DM_SEQ_ALIAS Kconfig option to ensure that the storage device sequence number matches in both SPL and U-Boot proper. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kev

Re: [PATCH v3 18/28] rockchip: rk3588-coolpi: Fix .dtb-file entries in Makefile

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Fix CoolPi 4 Model B and CoolPi CM5 EVB .dtb-file entries in Makefile. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yan

Re: [PATCH v3 17/28] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yan

Re: [PATCH v3 16/28] rockchip: rk3566-pinetab2: Fix reading FIT from SPI flash

2024-04-22 Thread Kever Yang
-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: No change v2: No change --- configs/pinetab2-rk3566_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig index edeb1d89b993..525a002a2

Re: [PATCH v3 15/28] rockchip: rk3588-evb: Use pinctrl and aliases in SPL

2024-04-22 Thread Kever Yang
. Also enable the SPL_DM_SEQ_ALIAS Kconfig option to ensure that the storage device sequence number matches in both SPL and U-Boot proper. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: New patch, split from rk3588 Update bootph props patch --- configs/evb

Re: [PATCH v3 14/28] rockchip: rk3568-evb: Use pinctrl in SPL

2024-04-22 Thread Kever Yang
. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: New patch, split from rk356x Update bootph props patch --- configs/evb-rk3568_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/evb-rk3568_defconfig b/configs/evb

Re: [PATCH v3 13/28] rockchip: rk3588: Update bootph props

2024-04-22 Thread Kever Yang
ded bootph props that automatically is propagated to parent nodes. Also adjust pinctrl nodes to only be included in boot phases where they are needed and add any missing pinctrl node needed in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kev

Re: [PATCH v3 12/28] rockchip: rk356x: Update bootph props

2024-04-22 Thread Kever Yang
ded bootph props that automatically is propagated to parent nodes. Also adjust pinctrl nodes to only be included in boot phases where they are needed and add any missing pinctrl node needed in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: Split evb-rk3568

Re: [PATCH v3 11/28] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically

2024-04-22 Thread Kever Yang
Karlman Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- v3: Include binman node in sort (Quentin) v3: Collect r-b tag v2: Follow kernel sort order (Quentin) [1] https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device

Re: [PATCH v3 10/28] rockchip: rk356x: Imply enhanced features for standard boot

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Imply BOOTSTD_FULL for all RK356x boards to more closely follow RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change --- arch/arm/mach-rockchip/Kconfig

Re: [PATCH v3 09/28] rockchip: rk35xx: Imply support for GbE PHY

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r

Re: [PATCH v3 08/28] rockchip: rk35xx: Enable random generator

2024-04-22 Thread Kever Yang
-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change --- arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi | 6 -- arch/arm/dts/rk356x-u-boot.dtsi| 5 + arch/arm/dts/rk3588s-u-boot.dtsi | 1 - arch/arm/mach-rockchip/Kconfig

Re: [PATCH v3 07/28] rockchip: rk35xx: Sort imply statements alphabetically

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Sort imply statements under ROCKCHIP_RK3568 and ROCKCHIP_RK3588 alphabetically. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change --- arch/arm/mach-rockchip

Re: [PATCH v3 06/28] rockchip: rk3566-anbernic-rgxx3: Remove SPL_ROCKCHIP_BACK_TO_BROM option

2024-04-22 Thread Kever Yang
from defconfig to align with other RK356x boards. This patch have no intended change in boot behavior. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: No change v2: No change --- configs/anbernic-rgxx3-rk3566_defconfig | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH v3 05/28] rockchip: rk3588: Drop REGULATOR_PWM Kconfig option

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: RK3588 boards do not have any pwm-regulator compatible nodes in DT, drop the superfluous REGULATOR_PWM Kconfig options. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2

Re: [PATCH v3 04/28] rockchip: rk35xx: Drop USB_GADGET_PRODUCT_NUM Kconfig option

2024-04-22 Thread Kever Yang
as Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change --- configs/pinetab2-rk3566_defconfig | 1 - configs/rock5b-rk3588_defconfig | 1 - configs/turing-rk1-rk3588_defconfig | 1 - 3 files changed, 3 deletions(-) diff --git

Re: [PATCH v3 03/28] clk: rockchip: rk356x: Fix set rate of SCLK_SFC clock

2024-04-22 Thread Kever Yang
match these rates use of SPI flash may fail. Fix this by using the highest possible rate that exceeds or is equal to the requested rate. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: New patch --- drivers/clk/rockchip/clk_rk3568.c | 32

Re: [PATCH v3 02/28] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-22 Thread Kever Yang
Anderson Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect a-b tag v2: Collect r-b tag --- drivers/clk/rockchip/clk_rk3588.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/rockchip/clk_rk3588.c b/drivers/clk/rockchip/clk_rk3588.c index 8f33843179b0..4c611a390499

Re: [PATCH v3 01/28] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The CLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of CLK_USB3OTGx_REF clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Acked-by: Sean Anderson Reviewed-by: Kever

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-27 Thread Kever Yang
Hi Chris,     The ATAGS is used for passing parameter from bootloader to kernel at first, which has been replaced by DTB now for ARM platform.     And Rockchip using ATAGs for passing parameter like dram memory size/board uart in different boot process like DRAM init binary/ TPL/SPL to

Re: [PATCH] rockchip: ringneck-px30: put STM32_RST line in input mode instead of output

2024-03-26 Thread Kever Yang
Hi Quentin, On 2024/3/22 17:38, Quentin Schulz wrote: Hi Kever, On 2/19/24 10:50, Quentin Schulz wrote: Hi Kever, On 2/18/24 02:14, Kever Yang wrote: Hi Quentin, On 2024/2/9 21:18, Quentin Schulz wrote: From: Quentin Schulz The STM32_RST line is routed to the ATtiny microcontroller PA0

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Kever Yang
et to f1ee6710 => fdt list /chosen chosen { u-boot,spl-boot-device = "/spi@ff1d/flash@0"; stdout-path = "serial2:150n8"; u-boot,spl-boot-order = "same-as-spl", "/mmc@fe33", "/mmc@fe32"; }; Signed-off-

Pull request: u-boot-rockchip/for-next

2024-03-14 Thread Kever Yang
Hi Tom, This is for next; Please pull the updates for rockchip platform: - Add board: rk3588 Generic, Cool Pi CM5, Theobroma-Systems RK3588 Jaguar SBC, Toybrick TB-RK3588X; rk3588s Cool Pi 4B; rk3566 Pine64 PineTab2; - Add saradc v2 support; - Add PMIC RK806

Re: [PATCH v2] rockchip: load env from boot MMC device

2024-03-14 Thread Kever Yang
on a Rock64v2. Signed-off-by: Ben Wolsieffer Reviewed-by: Kever Yang Thanks, - Kever --- v2: * Use #ifdef rather than if(CONFIG_IS_ENABLED(...)) * Add a debug message if boot device is not found arch/arm/mach-rockchip/board.c | 31 board/rockchip/tinker_rk3288

Re: [PATCH] rockchip: board: Add minimal generic RK3588S/RK3588 board

2024-03-14 Thread Kever Yang
Hi Jonas, On 2024/3/14 15:04, Jonas Karlman wrote: Hi Kever, On 2024-03-14 07:58, Kever Yang wrote: On 2024/2/1 06:08, Jonas Karlman wrote: Add a minimal generic RK3588S/RK3588 board that only have eMMC and SDMMC enabled. This defconfig can be used to boot from eMMC or SD-card on most

Re: [PATCH] rockchip: board: Add minimal generic RK3588S/RK3588 board

2024-03-14 Thread Kever Yang
listed in Makefile and documentation. Signed-off-by: Jonas Karlman Since rk356x already have a generic board, rk3588 can also have one. Reviewed-by: Kever Yang Thanks, - Kever --- This patch depend on the series "rockchip: rk35xx: Sync device tree with linux v6.8-rc1" [1].

Re: [PATCH 4/4] board: rockchip: Add early ADC button detect for RGxx3

2024-03-14 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c b/board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c index 5c57b902d1..099eea60c3 100644

Re: [PATCH 1/4] arm: dts: rockchip: rk3566: Remove unnecessary clks from rgxx3

2024-03-14 Thread Kever Yang
On 2024/2/6 02:58, Chris Morgan wrote: From: Chris Morgan Remove unnecessary clock frequency defines from the RGxx3 u-boot dts. Move the necessary defines to the RGxx3 main dts file. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- .../arm/dts/rk3566-anbernic

Re: [PATCH] board: rockchip: Add Pine64 PineTab2

2024-03-14 Thread Kever Yang
tree is imported from linux maintainer branch v6.9-armsoc/dts64, commit 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64 PineTab2"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This patch depend on the series "rockchip: rk35xx: S

Re: [PATCH v2 3/5] rockchip: rk3328: regenerate defconfigs

2024-03-14 Thread Kever Yang
On 2024/3/13 23:32, Jonas Karlman wrote: Hi Kever and Chen-Yu, On 2024-03-13 15:43, Chen-Yu Tsai wrote: Hi, On Wed, Mar 13, 2024 at 6:29 PM Kever Yang wrote: Hi Chen-Yu, On 2024/2/12 21:51, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Regenerate RK3328 defconfigs after adding imply

Re: [PATCH v2 15/15] rockchip: rk3328-orangepi-r1-plus: Enable boot from SPI NOR flash

2024-03-13 Thread Kever Yang
s written, 249856 bytes skipped in 14.22s, speed 100542 B/s Signed-off-by: Jonas Karlman Reviewed-by: Tianling Shen Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Include SPI flash pinctrl nodes in SPL - Enable SPI_FLASH_XMC and SPI_FLASH_ZBIT, zb25vq128 was reported on my R1 Plus

Re: [PATCH v2 14/15] rockchip: rk3328-rock64: Enable boot from SPI NOR flash

2024-03-13 Thread Kever Yang
664 bytes skipped in 8.516s, speed 163516 B/s Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Include SPI flash pinctrl nodes in SPL - Enable SPI_FLASH_XTX - Collect r-b tag --- arch/arm/dts/rk3328-rock64-u-boot.

Re: [PATCH v2 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-03-13 Thread Kever Yang
of SPI NOR flash. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change --- arch/arm/dts/rk3328-u-boot.dtsi| 11 +++ arch/arm/mach-rockchip/rk3328/rk3328.c | 1 + 2 files changed, 12 insertions(+) diff --git a/arch/arm/dts/rk3328-u

Re: [PATCH v2 12/15] Revert "rockchip: Allow booting from SPI"

2024-03-13 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change --- arch/arm/mach-rockchip/spl-boot-order.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-rockchip/spl-boot-order.c b/arch/arm/mach-rockchip/spl-boot-order.c index 2c39a215c107..79c856d2a0ac 100644 --- a/arch/arm

Re: [PATCH v2 11/15] rockchip: rk3328: Sync device tree from linux v6.8-rc1

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Sync rk3328 device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change --- arch/arm/dts/rk3328-evb.dts | 1 + arch/arm/dts/rk3328-nanopi-r2s.dts | 3

Re: [PATCH v2 10/15] rng: rockchip: Use same compatible as linux

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas Karlman Reviewed-by: Heinrich Schuchardt Reviewed-by: Kever

Re: [PATCH v2 08/15] rockchip: rk3328: Fix loading FIT from SD-card when booting from eMMC

2024-03-13 Thread Kever Yang
Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add missing UART2 pinctrl nodes to soc u-boot.dtsi - Mark the pinctrl node to be included in U-Boot proper pre-reloc phase - Add SD-card IO-voltage related nodes to nanopi-r2 u-boot.dtsi --- arch/arm/dts/rk3328-evb-u-boot.dtsi

Re: [PATCH v2 09/15] gpio: rockchip: Use gpio alias id as gpio bank id

2024-03-13 Thread Kever Yang
fallback to not affect any existing unsynced DT. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change --- drivers/gpio/rk_gpio.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index

Re: [PATCH v2 07/15] rockchip: rk3328-orangepi-r1-plus: Update defconfig

2024-03-13 Thread Kever Yang
generator. Also add missing device tree files to MAINTAINERS file. Signed-off-by: Jonas Karlman Reviewed-by: Tianling Shen Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_REGULATOR, DM_MDIO and PHY_GIGE - Remove SPL_I2C, SPL_PMIC_RK8XX and REGULATOR_PWM - Collect r-b tag

Re: [PATCH v2 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-03-13 Thread Kever Yang
is not used. Add RNG_ROCKCHIP=y and DM_RNG=y options to support the onboard random generator. Also add myself as a reviewer for this board. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_REGULATOR, DM_MDIO and PHY_GIGE - Remove SPL_I2C

Re: [PATCH v2 06/15] rockchip: rk3328-nanopi-r2: Update defconfig

2024-03-13 Thread Kever Yang
the onboard random generator. Also add missing device tree files to MAINTAINERS file. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_REGULATOR, DM_MDIO, PHY_GIGE, DM_REGULATOR_GPIO and SPL_DM_REGULATOR_GPIO - Remove SPL_I2C, SPL_PMIC_RK8XX

Re: [PATCH v2 04/15] rockchip: rk3328-roc-cc: Update defconfig

2024-03-13 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_POWEROFF, CMD_REGULATOR and PHY_GIGE - Remove SPL_I2C, SPL_PMIC_RK8XX and REGULATOR_PWM --- board/rockchip/evb_rk3328/MAINTAINERS | 2 ++ configs/roc-cc-rk3328_defconfig | 15 ++- doc/board/rockchip

Re: [PATCH v2 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-03-13 Thread Kever Yang
is not used. Add RNG_ROCKCHIP=y and DM_RNG=y options to support the onboard random generator. Also add myself as a reviewer for this board. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_REGULATOR, DM_MDIO and PHY_GIGE - Remove SPL_I2C

Re: [PATCH v2 03/15] rockchip: rk3328-rock64: Update defconfig

2024-03-13 Thread Kever Yang
REGULATOR_PWM=y, the pwm-regulator compatible is not used. Also add missing device tree file to MAINTAINERS and add myself as a reviewer for this board. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add CMD_GPIO, CMD_POWEROFF

Re: [PATCH v2 02/15] rockchip: rk3328-evb: Update defconfig

2024-03-13 Thread Kever Yang
the obsolete README file. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add DM_RESET, CMD_GPIO, CMD_REGULATOR, PHY_GIGE and SYSINFO - Remove REGULATOR_PWM --- board/rockchip/evb_rk3328/MAINTAINERS | 2 + board/rockchip/evb_rk3328/README | 70

Re: [PATCH v2 01/15] rockchip: rk3328: Update default u-boot,spl-boot-order prop

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Change to use a common FIT load order, same-as-spl > SD-card > eMMC on RK3328 boards. Only EVB and Radxa ROCK Pi E is affected by this change. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH v3 05/16] power: rk8xx: add support for RK806

2024-03-13 Thread Kever Yang
Hi Quentin,     This patch build fail in CI: Building current source for 1 boards (1 thread, 32 jobs per thread)    sandbox:  +   sandbox64 +drivers/power/pmic/rk8xx.c:141:10: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1

Re: [PATCH v2 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-13 Thread Kever Yang
h the migration to DM_USB_GADGET completed the U-Boot specific change to reorder usb nodes in the soc device tree can be reverted. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Drop use of DWC3_GENERIC and revert to use XHCI_DWC3 for USB 3.0 host for devices using another port with otg/per

Re: [PATCH v2 1/4] rockchip: Update the default USB Product ID value

2024-03-13 Thread Kever Yang
used in Maskrom mode. Also remove a reference to an undefined ROCKCHIP_RK3229 Kconfig symbol. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Update commit message --- drivers/usb/gadget/Kconfig | 15 --- 1 file changed, 12 insertions(+), 3

Re: [PATCH v4] board: rockchip: add Rockchip Toybrick TB-RK3588X board

2024-03-13 Thread Kever Yang
: arm: rockchip: Add Toybrick TB-RK3588X") Reviewed-by: Weizhao Ouyang Signed-off-by: Elon Zhang Reviewed-by: Kever Yang Thanks, - Kever --- Changes since v3: - unsigned int ret -> int ret of fdtdec_add_reserved_memory() Changes since v2: - Sync dts file from upstream linux k

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-13 Thread Kever Yang
used in Mask ROM mode. Also remove a reference to the unknown ROCKCHIP_RK3229 symbol. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/usb/gadget/Kconfig | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget

Re: [PATCH v3 3/6] rockchip: Use common bss and stack addresses on RK3328

2024-03-13 Thread Kever Yang
Hi Jonas,     This patch does not able to apply on next, could you help to take a look. And also add document of memory layout in rockchip.rst if possible. Thanks, - Kever On 2024/3/3 03:16, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3328 there

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-13 Thread Kever Yang
-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 117 +++--- 1 file changed, 14 insertions(+), 103 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c

Re: [PATCH v3 01/16] rockchip: spi: rk_spi: do not write bytes when in read-only mode

2024-03-13 Thread Kever Yang
for that last byte and skip any write in the xfer loop. This is required for 3-wire SPI mode where PICO/POCI lanes are shorted on HW level. This incidentally the recommended design for RK806 PMIC for RK3588 products. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang

Re: [PATCH v2 3/5] rockchip: rk3328: regenerate defconfigs

2024-03-13 Thread Kever Yang
Hi Chen-Yu, On 2024/2/12 21:51, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Regenerate RK3328 defconfigs after adding imply statements. Signed-off-by: Chen-Yu Tsai Reviewed-by: Christopher Obbard Reviewed-by: Dragan Simic --- configs/evb-rk3328_defconfig | 3 ---

Re: [PATCH v2 12/12] rockchip: board: Move gpt_capsule_update_setup() call

2024-03-13 Thread Kever Yang
On 2024/3/13 07:36, Jonas Karlman wrote: Move the call to gpt_capsule_update_setup() from the weak function rk_board_late_init() into the main board_late_init() function. Also change to use IS_ENABLED() instead for defined(). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks

Re: [PATCH v2 01/12] board: rockchip: rk3399: Add device tree files to MAINTAINERS

2024-03-13 Thread Kever Yang
On 2024/3/13 07:36, Jonas Karlman wrote: Update MAINTAINERS files for RK3399 boards to include related device tree files. Also correct a few filenames. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Use glob pattern where appropriate --- board/firefly

Re: [PATCH v3 16/16] rockchip: boot_mode: fix rockchip_dnl_key_pressed requiring ADC support

2024-03-11 Thread Kever Yang
functions from the ADC subsystem which do not exist when ADC is not enabled, failing the build. Therefore, let's encapsulate this logic with a check on the ADC symbol being selected. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach

Re: [PATCH v3 15/16] button: add missing ADC dependency for BUTTON_ADC

2024-03-11 Thread Kever Yang
sure it cannot be built without ADC support. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/button/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/button/Kconfig b/drivers/button/Kconfig index 097b05f822e..3918b05ae03

Re: [PATCH v3 14/16] adc: add missing depends on ADC for controller drivers

2024-03-11 Thread Kever Yang
in menuconfig when ADC isn't selected. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig index a01d73846b7..c9cdbe6942d 100644

Re: [PATCH v3 13/16] rockchip: jaguar-rk3588: enable SARADC and derivatives

2024-03-11 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/jaguar-rk3588_defconfig | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/configs/jaguar-rk3588_defconfig b/configs/jaguar-rk3588_defconfig index f55bfb1c82b..275d70ae008 100644 --- a/configs

Re: [PATCH v3 11/16] rockchip: adc: rockchip-saradc: add support for RK3588

2024-03-11 Thread Kever Yang
Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/rockchip-saradc.c | 102 +- 1 file changed, 101 insertions(+), 1 deletion(-) diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c index b5df58fe3eb..10ded1b088f 100644

Re: [PATCH v3 12/16] power: pmic: rk8xx: fix duplicate prompt

2024-03-11 Thread Kever Yang
tin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/pmic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig index 9b61b18e11f..562c1a3b122 100644 --- a/drivers/

Re: [PATCH v4 11/20] rockchip: rk3588: disable force_jtag by default

2024-03-11 Thread Kever Yang
with soc_con[1] than soc_con[0], and that soc_con0 would actually be located at 4 bytes before soc_con1, let's just make soc_con0 part of the soc_con array. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/grf_rk3588.h

Re: [PATCH v3 10/16] rockchip: adc: rockchip-saradc: factor out stop callback

2024-03-11 Thread Kever Yang
Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/rockchip-saradc.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c index 607d10b5b70..b5df58fe3eb

Re: [PATCH v3 09/16] rockchip: adc: rockchip-saradc: factor out start_channel callback

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz SARADC v1 and v2 have a different way of starting a channel, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever

Re: [PATCH v3 08/16] rockchip: adc: rockchip-saradc: factor out channel_data callback

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz SARADC v1 and v2 have a different way of reading data, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang

Re: [PATCH v3 07/16] rockchip: adc: rockchip-saradc: use union for preparing for v2

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz The registers are entirely different between SARADC v1 and SARADC v2, so let's prepare to add another struct for accessing v2 registers by adding a union. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever

Re: [PATCH v3 06/16] pmic: reword help text

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz Reword the help text for the pmic read and pmic write commands to better match what's expected from the user. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- cmd/pmic.c | 4

Re: [PATCH v3 05/16] power: rk8xx: add support for RK806

2024-03-11 Thread Kever Yang
rom the DT node name, NLDO and PLDO will have overlapping indices. Therefore, we need a separate logic from the already-existing ldo callbacks. Let's reuse as much as possible though. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/

Re: [PATCH v3 04/16] regulator: rk8xx: add indirection level for some ldo callbacks

2024-03-11 Thread Kever Yang
for RK806. No logic change is expected. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 48 ++--- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/power

Re: [PATCH v3 03/16] regulator: rk8xx: fix SWITCH enable on RK809

2024-03-11 Thread Kever Yang
-by: William Wu [reworded commit log] Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c index

Re: [PATCH v3 02/16] regulator: rk8xx: remove unused functions

2024-03-11 Thread Kever Yang
Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 31 --- include/power/rk8xx_pmic.h | 2 -- 2 files changed, 33 deletions(-) diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8

Re: [PATCH v3 6/6] rockchip: Use common bss and stack addresses on RK3588

2024-03-11 Thread Kever Yang
bss, stack and malloc heap size and addresses to mitigate these limitations and allow for a larger U-Boot proper size. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3588/Kconfig| 7 +-- configs/evb-rk3588_defconfig

Re: [PATCH v3 5/6] rockchip: Use common bss and stack addresses on RK356x

2024-03-11 Thread Kever Yang
) - SPL bss (SPL_BSS_START_ADDR, SPL_BSS_MAX_SIZE) SPL can safely load U-Boot proper + FDT to [10M, 12M-128K) with this layout. Migrate to use common bss, stack and malloc heap size and addresses to remove this size limitation. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH v3 4/6] rockchip: Use common bss and stack addresses on RK3399

2024-03-11 Thread Kever Yang
Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3399/Kconfig| 7 +-- configs/eaidk-610-rk3399_defconfig | 10 -- configs/evb-rk3399_defconfig | 10 -- configs/firefly-rk3399_defconfig | 10

Re: [PATCH v3 3/6] rockchip: Use common bss and stack addresses on RK3328

2024-03-11 Thread Kever Yang
Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3328/Kconfig | 11 --- configs/evb-rk3328_defconfig | 17 - configs/nanopi-r2c-plus-rk3328_defconfig | 15 --- configs/nanopi-r2c-rk3328_defconfig

Re: [PATCH v3 2/6] rockchip: Use common bss and stack addresses on RK3308

2024-03-11 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- Kconfig | 2 +- arch/arm/mach-rockchip/rk3308/Kconfig | 7 +-- configs/evb-rk3308_defconfig | 13 - configs/roc-cc-rk3308_defconfig | 13 - configs/rock-pi-s-rk3308_defconfig

Re: [PATCH v3 1/6] rockchip: Add common default bss and stack addresses

2024-03-11 Thread Kever Yang
relocated to top of memory we should be able to use 2M+ for loading kernel, initrd, scripts etc. Very good update and also good description here, can we also add the memory usage  description  after update to rockchip.rst? Reviewed-by: Kever Yang Thanks, - Kever Signed-off-by: Jonas

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-11 Thread Kever Yang
On 2024/3/2 23:28, Jonas Karlman wrote: Hi Christopher, On 2024-03-02 15:34, Christopher Obbard wrote: Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can be booted from. This patch enables support in U-Boot for building the image for the SPI flash, support for booting

Re: [PATCH v1 1/2] arm: rockchip: sync ROCK Pi 4A DTS from Linux

2024-03-11 Thread Kever Yang
A/B/C") Signed-off-by: Christopher Obbard Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-rock-pi-4a.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/dts/rk3399-rock-pi-4a.dts b/arch/arm/dts/rk3399-rock-pi-4a.dts index 931334aa3d6..d5df8939

Re: [PATCH 10/11] rockchip: theobroma-systems: puma: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone with a puma

Re: [PATCH 11/11] rockchip: google: gru: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone with a gru

Re: [PATCH 09/11] rockchip: vamrs: rock960: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/vamrs/rock960_rk3399/Makefile | 6

Re: [PATCH 08/11] rockchip: pine64: pinephone-pro: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone

Re: [PATCH 07/11] rockchip: pine64: pinebook-pro: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399/Makefile | 1

Re: [PATCH 06/11] rockchip: pine64: rockpro64: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/rockpro64_rk3399/Makefile| 7

Re: [PATCH 05/11] rockchip: io-domain: Add support for RK3399

2024-03-11 Thread Kever Yang
that have been configured. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/misc/rockchip-io-domain.c | 79 +-- 1 file changed, 75 insertions(+), 4 deletions(-) diff --git a/drivers/misc/rockchip-io-domain.c b/drivers/misc

Re: [PATCH 04/11] board: rockchip: Add a common ROCK Pi 4 target

2024-03-11 Thread Kever Yang
Hi Jonas, On 2024/2/19 17:13, Quentin Schulz wrote: Hi Jonas, On 2/17/24 19:35, Jonas Karlman wrote: Move ROCK Pi 4 specific board code from the shared evb_rk3399 target into its own board target and update related defconfigs to use the new TARGET_ROCKPI4_RK3399 option. Also move the call to

Re: [PATCH 04/11] board: rockchip: Add a common ROCK Pi 4 target

2024-03-11 Thread Kever Yang
Hi Jonas, On 2024/2/18 02:35, Jonas Karlman wrote: Move ROCK Pi 4 specific board code from the shared evb_rk3399 target into its own board target and update related defconfigs to use the new TARGET_ROCKPI4_RK3399 option. Also move the call to gpt_capsule_update_setup() from the weak function

Re: [PATCH 03/11] board: rockchip: rk3399: Remove unused board_early_init_f functions

2024-03-11 Thread Kever Yang
, and fixed/gpio regulators now have basic reference counting support so the original intent of this code is no longer valid. Remove the unneeded and unused code that used to enable usb regulators. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/firefly/roc-pc

Re: [PATCH 02/11] board: rockchip: rk3399: Add myself as reviewer to MAINTAINERS

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Add myself as a reviewer for RK3399 boards that I have and can help with review and testing of defconfig and device tree changes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399

Re: [PATCH 02/11] board: rockchip: rk3399: Add myself as reviewer to MAINTAINERS

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Add myself as a reviewer for RK3399 boards that I have and can help with review and testing of defconfig and device tree changes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399

Re: [PATCH v3 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-03-11 Thread Kever Yang
Hi Quentin, On 2024/3/9 01:55, Quentin Schulz wrote: Hi Kever, On 3/8/24 11:05, Kever Yang wrote: Hi Quentin, On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-10 Thread Kever Yang
Hi Jonas, On 2024/3/8 18:42, Jonas Karlman wrote: Hi Kever, On 2024-03-08 10:22, Kever Yang wrote: Hi Jonas,     Thanks for your patch. On 2024/2/27 07:08, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used

Re: [PATCH v3 20/20] rockchip: ringneck_px30: update website link

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz The original link returns a custom 404, so let's point to a link that works today instead. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems

Re: [PATCH v3 19/20] rockchip: ringneck_px30: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/ringneck_px30/MAINTAINERS | 1 + board/theobroma-systems/ringneck_px30/README | 70 + doc/board/theobroma-systems/index.rst | 1 + doc/board/theobroma-systems/ringneck_px30.rst | 95

Re: [PATCH v3 18/20] rockchip: rk3399-puma: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/puma_rk3399/MAINTAINERS | 1 + board/theobroma-systems/puma_rk3399/README | 90 + doc/board/theobroma-systems/index.rst | 1 + doc/board/theobroma-systems/puma_rk3399.rst | 126

Re: [PATCH v3 17/20] rockchip: puma-rk3399: MAINTAINERS: use glob for dtses

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz There are multiple Device Trees in U-Boot git repo for Puma, so let's make the MAINTAINERS entry match them all. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board

<    1   2   3   4   5   6   7   8   9   10   >