Re: [PATCH 00/14] rockchip: rk35xx: Update defconfigs and enable boot from SPI NOR flash

Hi Jonas and Eugen, On 2023/4/22 09:23, Jonas Karlman wrote: This series sync some defconfig options across the different rk35xx boards and enables boot from SPI NOR flash on rk3568-rock-3a and rk3588-rock-5b. Patch 1 fixes use of sfc-no-dma prop in rockchip sfc driver. Patch 2-7 updates

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

Hi Eugen, I'm not able to apply this patch, maybe for some conflict, could you help to send it again with rebase? Thanks, - Kever On 2023/4/13 19:36, Eugen Hristev wrote: The current DT bindings for the rk3588 clock use a different ID than the one that is supposed to be written to the

Re: [PATCH 5/5] rockchip: rockpro64: Build u-boot-rockchip-spi.bin

1421824 bytes written, 20480 bytes skipped in 9.501s, speed 155432 B/s Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/rockpro64-rk3399_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/

Re: [PATCH 4/5] rockchip: rock-pi-4: Use SDMA to boost eMMC performance

ore: time: 3.178 seconds After: time: 0.402 seconds This also enables CONFIG_SPL_FIT_SIGNATURE option to help discover any possible future issue with loading TF-A into DRAM/SRAM. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi

Re: [PATCH 3/5] rockchip: rockpro64: Use SDMA to boost eMMC performance

ore: time: 3.178 seconds After: time: 0.402 seconds This also enables CONFIG_SPL_FIT_SIGNATURE option to help discover any possible future issue with loading TF-A into DRAM/SRAM. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-rockpro64-u-boot.dtsi

Re: [PATCH 2/5] mmc: rockchip_sdhci: Disable DMA mode using a device tree property

nd instead disable DMA using the device tree property for all RK3588 boards, also apply similar workaround for all RK3399 boards. Fixes: 2cc6cde647e2 ("mmc: rockchip_sdhci: Limit number of blocks read in a single command") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks,

Re: [PATCH 1/5] mmc: rockchip_sdhci: Skip blocks read workaround on RK3399

ingle command") Suggested-by: Simon Glass Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/mmc/rockchip_sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index 4f

Re: [PATCH 5/5] doc: rockchip: update list of Radxa ROCK (Pi) 4 boards

On 2023/4/26 10:23, FUKAUMI Naoki wrote: add Radxa ROCK (Pi) 4 variants. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- doc/board/rockchip/rockchip.rst | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/board/rockchip/rockchip.rst b

Re: [PATCH 4/5] configs: rockchip: add Radxa ROCK 4C+

On 2023/4/26 10:23, FUKAUMI Naoki wrote: add defconfig for Radxa ROCK 4C+. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-4c-plus-rk3399_defconfig | 97 +++ 1 file changed, 97 insertions(+) create mode 100644 configs

Re: [PATCH 3/5] arm: dts: rockchip: add Radxa ROCK 4C+

Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile| 1 + arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi | 5 + arch/arm/dts/rk3399-rock-4c-plus.dts | 709 +++ arch/arm/dts/rk3399-t-opp.dtsi | 114 +++ 4 files

Re: [PATCH 2/5] configs: rockchip: rock-pi-4: use dtb for ROCK Pi 4A instead of 4B

On 2023/4/26 10:23, FUKAUMI Naoki wrote: rk3399-rock-pi-4a.dtb is enough for Radxa ROCK Pi 4A/B/A+/B+ and ROCK 4SE. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-4-rk3399_defconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 1/5] arm: dts: rockchip: rock-pi-4: sync with Linux 6.3

On 2023/4/26 10:23, FUKAUMI Naoki wrote: sync dts{,i} files for Radxa ROCK Pi 4 series with Linux 6.3. because rk3399-rock-pi-4a.dts is enough for ROCK Pi 4A/B/A+/B+ and ROCK 4SE, delete dts{,i} for ROCK Pi 4B. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 4/8] pci: pcie_dw_rockchip: Hide BARs of the root complex

Hi Jonas, On 2023/4/23 02:19, Jonas Karlman wrote: PCI Autoconfig read the Root Complex BARs and try to claim the entire 1 GiB memory region on RK3568, leaving no space for any attached device. Return an invalid value during config read of Root Complex BARs during autoconfig to work around

Re: [PATCH 7/8] rockchip: rk3568-rock-3a: Enable PCIe and NVMe support

Hi Jonas, On 2023/4/23 02:19, Jonas Karlman wrote: Add missing pinctrl and defconfig options to enable PCIe and NVMe support on Radxa ROCK 3 Model A. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 14 ++ configs/rock-3a-rk3568_defconfig| 4

Re: [PATCH 8/8] rockchip: rk356x: Update PCIe config, IO and memory regions

On 2023/4/23 02:19, Jonas Karlman wrote: Update config, IO and memory regions used based on [1] with pcie3x2 config reg size corrected from 16 to 1 MiB. [1] https://lore.kernel.org/lkml/20221112114125.1637543-2-ahol...@omnom.net/ Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang

Re: [PATCH 6/8] rockchip: clk: clk_rk3568: Add CLK_PCIEPHY2_REF support

On 2023/4/23 02:19, Jonas Karlman wrote: Add dummy support for the CLK_PCIEPHY2_REF clock. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3568.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk_rk3568.c

Re: [PATCH 5/8] regulator: fixed: Add support for gpios prop

-regulator driver. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/fixed.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/power/regulator/fixed.c b/drivers/power/regulator/fixed.c index ad3b4b98d667..fcfb467a4

Re: [PATCH 3/8] pci: pcie_dw_rockchip: Speed up link probe

Hi Jonas, On 2023/4/23 02:19, Jonas Karlman wrote: Use a similar pattern and delay values as the linux mainline driver to speed up failing when nothing is connected. Reduce fail speed from around 5+ seconds down to around one second on a Radxa ROCK 3 Model A, where pcie2x1 is probed before

Re: [PATCH 2/8] pci: pcie_dw_rockchip: Use regulator_set_enable_if_allowed

Hi Jonas, On 2023/4/23 02:19, Jonas Karlman wrote: The vpcie3v3 regulator is typically a fixed regulator controlled using gpio. Change to use enable and disable calls on the regulator instead of trying to set a voltage value. Signed-off-by: Jonas Karlman --- drivers/pci/pcie_dw_rockchip.c |

Re: [PATCH 1/8] pci: pcie_dw_rockchip: Get config region from reg prop

On 2023/4/23 02:19, Jonas Karlman wrote: Get the config region to use from the reg prop. Also check the return value from dev_read_addr_index correctly. And update the referenced region index used in comment. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH 14/14] Revert "arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb"

ference counter". This reverts commit 7911f409ff20dce5995cc1b703a6e30c94022f6b. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- After [1] and [2] these regulator-boot-on props can be removed. [1] https://patchwork.ozlabs.org/project/uboot/patch/20230419134014

Re: [PATCH 13/14] rockchip: rk3588-rock-5b: Enable boot from SPI NOR flash

On 2023/4/22 09:23, Jonas Karlman wrote: Add sfc and flash node to device tree and config options to enable support for booting from SPI NOR flash on Radxa ROCK 5 Model B. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi

Re: [PATCH 12/14] rockchip: rk3588-rock-5b: Add bootph prop to pinctrl for uart2 and sdhci

On 2023/4/22 09:23, Jonas Karlman wrote: Enable pinctrl for sdhci in SPL to support loading of FIT image from SD and eMMC storage when booting from SPI NOR flash. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28

Re: [PATCH 11/14] rockchip: rk3588-rock-5b: Update defconfig

register. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 2e034b724cc9..2f0a74ee5559 100644

Re: [PATCH 10/14] rockchip: rk3588-evb: Update defconfig

option to use PIO to load TF-A into DRAM and SRAM. Remove CONFIG_DEBUG_UART_ANNOUNCE=y to remove debug messages. Add CONFIG_SYS_NS16550_MEM32=y to use 32bit access of serial register. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3588_defconfig | 9

Re: [PATCH 09/14] rockchip: rk3588: Select DM_RESET and DM_REGULATOR_FIXED in arch Kconfig

On 2023/4/22 09:23, Jonas Karlman wrote: Like other Rockchip SoCs, DM_RESET and DM_REGULATOR_FIXED is useful across RK3588 platform. Select them from arch Kconfig. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/Kconfig| 2

Re: [PATCH 08/14] rockchip: rk3568-rock-3a: Enable boot from SPI NOR flash

; load mmc 1:1 1000 u-boot-rockchip-spi.bin 1384448 bytes read in 119 ms (11.1 MiB/s) => sf update $fileaddr 0 $filesize device 0 offset 0x0, size 0x152000 1179648 bytes written, 204800 bytes skipped in 9.901s, speed 143185 B/s Signed-off-by: Jonas Karlman Reviewed-by: K

Re: [PATCH 07/14] rockchip: rk3568-rock-3a: Use pinctrl for sdmmc and sdhci in SPL

On 2023/4/22 09:23, Jonas Karlman wrote: Enable pinctrl for sdmmc and sdhci in SPL to support loading of FIT image from SD and eMMC storage when booting from SPI NOR flash. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi

Re: [PATCH 06/14] rockchip: rk3568-rock-3a: Update defconfig

. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-3a-rk3568_defconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig index f0db15baa30e..5126feb6b11d 100644

Re: [PATCH 05/14] rockchip: rk3568-evb: Update defconfig

for the RK809 PMIC. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3568_defconfig | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/configs/evb-rk3568_defconfig b/configs/evb-rk3568_defconfig index c929bac509c0..0b4fc52e263d

Re: [PATCH] reset: reset-rockchip: fix trivial line spacing alignment

On 2023/4/11 15:20, Eugen Hristev wrote: Fix line spacing aligment in bind function Fixes: 760188c1aa5b ("rockchip: reset: support a (common) rockchip reset drivers") Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/reset/reset-rockchip.c |

Re: [PATCH] clk: rockchip: correct trivial typo in debug message

On 2023/4/11 15:17, Eugen Hristev wrote: s/faile/failed in debug message Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_px30.c | 2 +- drivers/clk/rockchip/clk_rk3036.c | 2 +- drivers/clk/rockchip/clk_rk3188.c | 2 +- drivers/clk

Re: [PATCH] pci: pcie_dw_rockchip: release resources on failing probe

, the user will get the same error message, and not something different that doesn't make sense. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/pci/pcie_dw_rockchip.c | 41 +- 1 file changed, 30 insertions(+), 11 deletions(-) diff

Re: [PATCH v5 1/6] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

Hi Eugen,     When I try to apply this patch, I got conflict for rk3588-rock-5b-u-boot.dtsi, could you please help to send a rebase? Thanks, - Kever On 2023/4/19 21:40, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu

Re: [PATCH v5 1/6] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

On 2023/4/19 21:40, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v5: - none Changes in v4: - removed u-boot,dm-spl on regulator which

Re: [PATCH 04/14] rockchip: rk3566-radxa-cm3-io: Use pinctrl for sdmmc and sdhci in SPL

On 2023/4/22 09:23, Jonas Karlman wrote: Enable pinctrl for sdmmc and sdhci in SPL to support loading of FIT image from SD and eMMC storage when booting from SPI NOR flash. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-radxa-cm3-io-u

Re: [PATCH 03/14] rockchip: rk3566-radxa-cm3-io: Update defconfig

CONFIG_SYS_NS16550_MEM32=y to use 32bit access of serial register. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 5 + configs/radxa-cm3-io-rk3566_defconfig| 9 + 2 files changed, 10 insertions(+), 4

Re: [PATCH 02/14] rockchip: rk356x-u-boot: Add xin24m clock node to SPL

On 2023/4/22 09:23, Jonas Karlman wrote: Add bootph-all prop to xin24m clock node, it is referenced by cru node. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x-u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm

Re: [PATCH 01/14] spi: rockchip_sfc: Use linux rockchip,sfc-no-dma prop

On 2023/4/22 09:23, Jonas Karlman wrote: Use the same prop as linux to control the use of fifo or dma mode. Also add a u-boot,spl-sfc-no-dma prop to control the same in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/spi/rockchip_sfc.c | 10

Re: [PATCH v3 7/7] configs: rock5b-rk3588: add PCI drivers and command

On 2023/4/27 15:35, Eugen Hristev wrote: Add drivers for PCIe , phy, and command. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3; - s/pciE/PCIe Changes in v2: - binman_fdt is now removed configs/rock5b-rk3588_defconfig | 4 1 file

Re: [PATCH v3 6/7] ARM: dts: rockchip: rock5b: enable pcie2x1l2 and associated combphy

[jo...@kwiboo.se: add PCIe pins] Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3: - s/pciE/PCIe Changes in v2: - add pcie2x1l2_pins by Jonas arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff

Re: [PATCH v3 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

to kernel node] Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3: - s/pciE/PCIe/ Changes in v2: - add compliance with linux by Jonas arch/arm/dts/rk3588s-u-boot.dtsi | 77 1 file changed, 77 insertions(+) diff --git

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

ing of DSI controller driver and DSI-DPHY driver to send DSI commands to the panel). Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever Changes from V1: - Fixed sphinx error for title underline. - Updated u-boot.dtsi file to support bootph. --- arch/arm/dt

Re: [PATCH v5 4/6] phy: remove phy-supply related code

Hi Neil,     Could you take a look at this patch? Thanks, - Kever On 2023/4/19 21:40, Eugen Hristev wrote: phy-supply is now handled at uclass level. Remove it from the drivers that implement it at the driver level. Suggested-by: Jonas Karlman Signed-off-by: Eugen Hristev ---

Re: [PATCH v5 6/6] phy: Keep balance of counts when ops is missing

On 2023/4/19 21:40, Eugen Hristev wrote: From: Jonas Karlman Fixes: 226fce6108fe ("phy: Track power-on and init counts in uclass") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/phy-uclass.c | 80 ---

Re: [PATCH v5 5/6] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 60 ++- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip

Re: [PATCH v5 3/6] phy: add support for phy-supply

regulator_set_enable_if_allowed and disable if power_on ops fails] Signed-off-by: Jonas Karlman Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v5: - add changes done by Jonas drivers/phy/phy-uclass.c | 51 +++- 1 file changed, 40 insertions

Re: [PATCH v5 2/6] configs: rockchip: rock5b-rk3588: enable USB and regulators

On 2023/4/19 21:40, Eugen Hristev wrote: Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 17 + 1 file changed, 17 insertions

Re: [PATCH v2 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

Hi Eugen, On 2023/4/26 23:53, Eugen Hristev wrote: From: Joseph Chen Add the node for pciE 2x1l 2 device together with the corresponding Typo "pciE" in the patch 5-7? We use 'PCIe' in term or 'pcie' in code. Thanks, - Kever combphy. Signed-off-by: Joseph Chen

Re: [PATCH v2 4/7] phy: rockchip: naneng-combphy: Support rk3588

On 2023/4/26 23:53, Eugen Hristev wrote: From: Jon Lin Add support for rk3588 phy variant. The PHY clock is fixed at 100MHz. Signed-off-by: Jon Lin [kever.y...@rock-chips.com: update pcie pll parameters] Co-developed-by: Kever Yang Signed-off-by: Kever Yang [eugen.hris...@collabora.com

Re: [PATCH v2 3/7] phy: rockchip: naneng-combphy: Add support for multiple resets

On 2023/4/26 23:53, Eugen Hristev wrote: Some variants of the PHY have more than just one reset. To cover all cases, request the rests in bulk rather than just the reset at index 0. Co-developed-by: Ren Jianing Signed-off-by: Ren Jianing Signed-off-by: Eugen Hristev Reviewed-by: Kever

Re: [PATCH v2 2/7] pci: pcie_dw_rockchip: Support max_link_speed dts property

to dev_read_u32_default] Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - move to dev_read_u32_default drivers/pci/pcie_dw_rockchip.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers

Re: [PATCH v2 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

On 2023/4/26 23:53, Eugen Hristev wrote: From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - none drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci

Re: [PATCH] rk3399: r4s: Derive local MAC address if EEPROM is missing

Hi Christian,     Sorry for reply late for this patch, could you pls send again with sign-off-by. for the code change looks OK for me. Reviewed-by: Kever Yang Thanks, - Kever On 2022/9/27 23:05, Christian Kohlschütter wrote: Some RK3399 boards, such as newer revisions of NanoPi R4S, do

Re: [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1

Hi Johan, On 2023/4/21 23:34, Johan Jonker wrote: On 4/21/23 05:15, Kever Yang wrote: Hi Johan,     I got below error report from CI test, I think it should be relate to this patch set. === FAILURES === 1107 <ht

Pull request: u-boot-rockchip-20230421

: rk3588-rock-5b: Include eMMC node in SPL dtb clk: rockchip: rk3588: Add limited TMCLK_EMMC clock support mmc: rockchip_sdhci: Limit number of blocks read in a single command Jonathan Liu (1): ram: rk3399: add missing high row detection Kever Yang (1): board: rockchip: Add

Re: [PATCH 7/7] configs: rock5b-rk3588: add pci drivers and command

Hi Eugen, On 2023/4/17 17:19, Eugen Hristev wrote: Add drivers for pciE , phy, and command. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig

Re: [PATCH 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

On 2023/4/17 17:19, Eugen Hristev wrote: From: Joseph Chen Add the node for pciE 2x1l 2 device together with the corresponding combphy. Signed-off-by: Joseph Chen [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor adaptations] Signed-off-by: Eugen Hristev ---

Re: [PATCH 3/7] phy: rockchip: naneng-combphy: Add support for multiple resets

On 2023/4/17 17:19, Eugen Hristev wrote: Some variants of the PHY have more than just one reset. To cover all cases, request the rests in bulk rather than just the reset at index 0. Co-developed-by: Ren Jianing Signed-off-by: Ren Jianing Signed-off-by: Eugen Hristev Reviewed-by: Kever

Re: [PATCH 4/7] phy: rockchip: naneng-combphy: Support rk3588

On 2023/4/17 17:19, Eugen Hristev wrote: From: Jon Lin Add support for rk3588 phy variant. The PHY clock is fixed at 100MHz. Signed-off-by: Jon Lin [kever.y...@rock-chips.com: update pcie pll parameters] Co-developed-by: Kever Yang Signed-off-by: Kever Yang [eugen.hris...@collabora.com

Re: [PATCH 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

On 2023/4/17 17:19, Eugen Hristev wrote: From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin Reviewed-by: Kever Yang Thanks, - Kever --- drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci

Re: [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC

On 2023/4/20 20:00, FUKAUMI Naoki wrote: it's not used by rk35xx Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- v2: - new patch configs/radxa-cm3-io-rk3566_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/radxa-cm3-io-rk3566_defconfig b

Re: [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work

On 2023/4/20 20:00, FUKAUMI Naoki wrote: add support for USB host function on ROCK 3A Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- v2: - drop CONFIG_USB_DWC3_GENERIC configs/rock-3a-rk3568_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff

Re: [PATCH v3 08/10] pinctrl: rockchip: Fix IO mux selection on RK3568

k3568 pinctrl driver") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: - Patch picked from [1] [1] https://patchwork.ozlabs.org/project/uboot/patch/20230318233039.799975-1-jo...@kwiboo.se/ drivers/pinctrl/rockchip/pinctrl-rk3568.c | 66 +

Re: [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1

Hi Johan,     I got below error report from CI test, I think it should be relate to this patch set. === FAILURES === 1107 _

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

Hi Chris, On 2023/3/17 01:46, Chris Morgan wrote: + + { + clock-frequency = <2400>; + u-boot,dm-spl; Please rebase the patch, this has been migrate to bootph. Thanks, - Kever

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

Hi Chris, I got below CI error report for this patch: Warning, treated as error: /builds/u-boot/custodians/u-boot-rockchip/doc/board/anbernic/index.rst:4:Title underline too short. Anbernic = make[1]: *** [doc/Makefile:70: htmldocs] Error 2 make: *** [Makefile:2373: htmldocs] Error 2

Re: [PATCH 2/2] rockchip: rk3328: Add support for Orange Pi R1 Plus LTS

On 2023/4/21 05:08, Tianling Shen wrote: The OrangePi R1 Plus LTS is a minor variant of OrangePi R1 Plus with the on-board NIC chip changed from rtl8211e to yt8531c, and RAM type changed from DDR4 to LPDDR3. There is no difference in U-Boot, and these two board can use the same U-Boot,

Re: [PATCH 1/2] rockchip: rk3328: Add support for Orange Pi R1 Plus

independent MAC addresses. The device tree and description are taken from kernel v6.3-rc1: https://github.com/torvalds/linux/commit/51712e1d0144c6e1e7e84932d58b5c0f59ed Signed-off-by: Tianling Shen Reviewed-by: Kever Yang Thanks, - Kever --- Please note this patch is based on my previous

Re: [PATCH v2 06/17] mmc: rockchip_sdhci: Use set_clock and config_dll sdhci_ops

Hi Tom, I got error report like below log when apply many of this patchset with "git-pw patch apply 1770392", did you met this kind of issue and do you know why? error: sha1 information is lacking or useless (drivers/mmc/rockchip_sdhci.c). error: could not build fake ancestor hint: Use

Re: [PATCH v3 03/10] rockchip: rk35xx: Fix boot with a large fdt blob

recent sync of device tree. Fixes: 073d911ae64a ("rockchip: rk3568-rock-3a: Sync device tree from linux") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: - No change v2: - New patch arch/arm/mach-rockchip/Kconfig | 2 ++ 1 file changed, 2 insertion

Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb

On 2023/4/20 17:56, FUKAUMI Naoki wrote: enable regulators for usb host function Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 2 files changed

Re: [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator

On 2023/4/20 17:56, FUKAUMI Naoki wrote: enable commands for i2c/pmic/regulator and relevant configs. also drop configs for unused regulators. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/radxa-cm3-io-rk3566_defconfig | 8 ++-- configs/rock-3a

Re: [PATCH 1/3] configs: rockchip: rock-3a: make usb host work

On 2023/4/20 17:56, FUKAUMI Naoki wrote: add support for USB host function on ROCK 3A Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-3a-rk3568_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs/rock-3a

Re: [PATCH] arm: dts: rockchip: rock-3a: drop u-boot,spl-boot-order

On 2023/4/20 17:42, FUKAUMI Naoki wrote: use common one defined in rk356x-u-boot.dtsi. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/rk3568-rock-3a-u

Re: [PATCH v2 17/17] mmc: rockchip_sdhci: Limit number of blocks read in a single command

(ret = -1) mmc_load_image_raw_sector: mmc block read error Fix this by using PIO mode in SPL and limit the number of blocks used in a single read command to avoid triggering Data End Bit Error interrupt. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2

Re: [PATCH v2 15/17] clk: rockchip: rk3588: Add limited TMCLK_EMMC clock support

On 2023/4/19 00:46, Jonas Karlman wrote: The device tree sdhci node reference the TMCLK_EMMC clock, add limited support this clock to rk3588 cru driver. Fixes probe of sdhci driver. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/clk

Re: [PATCH v2 14/17] rockchip: rk3588-rock-5b: Include eMMC node in SPL dtb

On 2023/4/19 00:46, Jonas Karlman wrote: Add sdhci node to SPL and u-boot,spl-boot-order. Also add more supported mmc modes and pinctrl. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Change u-boot,dm-spl to bootph-pre-ram arch/arm/dts/rk3588-rock-5b-u

Re: [PATCH v2 13/17] mmc: rockchip_sdhci: Add support for RK3588

Jonas Karlman Reviewed-by: Shawn Lin Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Add Signed-off-by tag - Update commit message - Rename quirks to flags - Save HS200/HS400 txclk_tapnum as driver data - Remove use of rockchip,txclk-tapnum prop - Collect r-b tag drivers/mmc/rockchip_sdhc

Re: [PATCH v2 12/17] rockchip: rk3568-rock-3a: Enable support for more eMMC modes

On 2023/4/19 00:46, Jonas Karlman wrote: Add supported mmc modes to rk3568-rock-3a device tree. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH v2 11/17] mmc: rockchip_sdhci: Fix HS400 and HS400ES mode on RK3568

r each of the modes below. 0 = MMC legacy 1 = MMC High Speed (26MHz) 3 = MMC High Speed (52MHz) 4 = MMC DDR52 (52MHz) 10 = HS200 (200MHz) 11 = HS400 (200MHz) 12 = HS400ES (200MHz) Signed-off-by: Yifeng Zhao Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Ke

Re: [PATCH v2 10/17] mmc: rockchip_sdhci: Rearrange and simplify used regs and flags

removes use of the misspelled const for the RK3588 CMDOUT reg, it will be re-added when support for RK3588 is introduced. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 40 1 file

Re: [PATCH v2 09/17] mmc: rockchip_sdhci: Remove empty get_phy and set_enhanced_strobe ops

On 2023/4/19 00:46, Jonas Karlman wrote: Remove empty implementations of get_phy and set_enhanced_strobe ops. Change driver set_enhanced_strobe to return 0 in order to allow missing implementation of the ops. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2

Re: [PATCH v2 08/17] mmc: rockchip_sdhci: Update speed mode controls in set_ios_post

mode. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 68 ++-- 1 file changed, 42 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc

Re: [PATCH v2 07/17] mmc: rockchip_sdhci: Refactor execute tuning error handling

On 2023/4/19 00:46, Jonas Karlman wrote: Check return value from mmc_send_cmd and clear HOST_CONTROL2 when there is an error. Also skip enable of interrupt signaling and remove a delay, a delay is already happening in sdhci_send_command. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang

Re: [PATCH v2 06/17] mmc: rockchip_sdhci: Use set_clock and config_dll sdhci_ops

Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index bc9838ac7c45..fdf48f4066c9 100644

Re: [PATCH v2 05/17] mmc: rockchip_sdhci: Add set_clock and config_dll sdhci_ops

On 2023/4/19 00:46, Jonas Karlman wrote: Add support for the set_clock and config_dll sdhci_ops. Use of these ops will allow configuration of DLL while the output clock is disabled. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc

Re: [PATCH v2 04/17] mmc: rockchip_sdhci: Remove unneeded emmc_phy_init

On 2023/4/19 00:46, Jonas Karlman wrote: Remove the unneeded emmc_phy_init now that the no-inverter flag is handled correctly after commit 2321a991bbb5 ("rockchip: sdhci: rk3568: bypass DLL when clk <= 52 MHz"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - K

Re: [PATCH v2 03/17] mmc: rockchip_sdhci: Fix use of device private data

man Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/rockchip_sdhci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index e1409dd2c749..ae28840f6081 100644 --- a/drivers/

Re: [PATCH v2 02/17] mmc: sdhci: Set UHS Mode Select field for UHS SDR25 mode

On 2023/4/19 00:46, Jonas Karlman wrote: Set correct UHS Mode Select field value for UHS SDR25 (50MHz) mode. Fixes: d1c0a2200afb ("mmc: sdhci: Add support for HOST_CONTROL2 and setting UHS timings") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Keve

Re: [PATCH v2 01/17] mmc: sdhci: Fix HISPD bit handling for MMC HS 52MHz mode

On 2023/4/19 00:46, Jonas Karlman wrote: Set High Speed Enable bit for MMC High Speed (52MHz) mode. Fixes: f12341a95295 ("mmc: sdhci: Fix HISPD bit handling") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change drivers/mmc/sdhci.c | 1

Re: [PATCH v3 1/2] ARM: dts: rk3588-rock-5b-u-boot: add bootph-all to pinctrl for sdmmc

On 2023/4/17 18:06, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3: - change to bootph-all props

Re: [PATCH v3 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

On 2023/4/17 18:06, Eugen Hristev wrote: Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2,v3: - no change configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2

Re: [PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

On 2023/4/14 17:45, Eugen Hristev wrote: On 4/14/23 11:55, Kever Yang wrote: On 2023/3/18 00:29, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

3588.c has been copied as much as possible from Linux. Adapt the clk rk3588 driver as well to bind the reset driver with the lookup table. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/clock.h | 21 + drivers/clk/rockchip/cl

Re: [PATCH 1/2] clk: rockchip: rk3588: add hardcoded assigned clocks values

for Uboot operations, there is no need to do any different kind of initialization. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3588.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/clk/rockchip

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

Hi Sebastian and Eugen,     Thanks for your information. On 2023/4/14 21:15, Sebastian Reichel wrote: Hi Kever, On Fri, Apr 14, 2023 at 12:03:00PM +0300, Eugen Hristev wrote: On 4/14/23 10:02, Kever Yang wrote: On 2023/4/13 19:36, Eugen Hristev wrote: The current DT bindings for the rk3588

Re: [PATCH] ram: rk3399: add missing high row detection

Add missing high row detection so that U-Boot TPL prints Row=16, same as the Rockchip ddr init bin: "BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB" Signed-off-by: Jonathan Liu Reviewed-by: Kever Yang Thanks, - Kever --- drivers/ram/rockchip/sdram_rk3399.c | 2 ++ 1 file

Re: [PATCH v2 3/3] rk3566: radxa-cm3: Enable USB OTG

On 2023/2/26 21:22, Manoj Sai wrote: Enable USB OTG support and update the fastboot buffer address for Radxa Compute Module 3 IO Board. This would help to use fastboot by default. Signed-off-by: Manoj Sai --- Changes for v2 :- - Updated the fastboot buffer address in

Re: [PATCH v2 2/3] rockchip: rk356x: update the dwc3_device register offset

Hi Manoj, This functions has been update, please check the latest version. Thanks, - Kever On 2023/2/26 21:22, Manoj Sai wrote: update the dwc3_device register offset in board_usb_init() for rk3568 platforms. Signed-off-by: Manoj Sai Reviewed-by: Jagan Teki --- Changes for v2:- - None

<    3   4   5   6   7   8   9   10   11   12   >