Re: [PATCH] usb: gadget: f_mass_storage: Stop ums on START-STOP UNIT SCSI command

2023-11-13 Thread Mattijs Korpershoek
Hi, On Tue, 07 Nov 2023 01:09:59 +0100, Marek Vasut wrote: > Exit the UMS handler loop in case START-STOP UNIT SCSI command is > received. This is sent e.g. by the util-linux eject(1) command and > indicates to the device that it is supposed to spin down the media > and enter low power state. >

Re: [PATCH v1 0/5] Implement fastboot multiresponce

2023-11-09 Thread Mattijs Korpershoek
Hi Svyatoslav, On jeu., nov. 09, 2023 at 11:01, Svyatoslav Ryhel wrote: > 9 листопада 2023 р. 10:41:30 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, Ion, >> >>Thank you for these series. >> >>On mar., nov. 07, 2023 at 14:42, Svyatoslav R

Re: eMMC broken on SK-AM62

2023-11-09 Thread Mattijs Korpershoek
Hi Maxime, Nishanth, On mer., nov. 08, 2023 at 16:05, Maxime Ripard wrote: > Hi Nishanth, > > I've been trying for the last few days to get an SK-AM62 to boot from > the eMMC user data area. > > I finally got the jumper configuration to make the CPU boot from there > thanks to Mattijs, but it

Re: [PATCH 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-09 Thread Mattijs Korpershoek
On jeu., nov. 09, 2023 at 10:40, Mattijs Korpershoek wrote: > Hi Dmitrii, > > Thank you for your patch. > > Thank you as well for taking the time to upstream things from: > https://android.googlesource.com/platform/external/u-boot/ > > On jeu., nov. 09, 2023 at 00:36, Dm

Re: [PATCH 2/2] cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-09 Thread Mattijs Korpershoek
t; Co-developed-by: Cody Schuffelen > Signed-off-by: Cody Schuffelen > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen I could test th

Re: [PATCH 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-09 Thread Mattijs Korpershoek
rt MMC interface. Extend it to allow various block > device interfaces. > > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen This breaks vim3/vim

Re: [PATCH v1 0/5] Implement fastboot multiresponce

2023-11-09 Thread Mattijs Korpershoek
Hi Svyatoslav, Ion, Thank you for these series. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-07 Thread Mattijs Korpershoek
Hi Jaehoon, On ven., nov. 03, 2023 at 14:49, "Jaehoon Chung" wrote: > Hi, > >> -Original Message- >> From: U-Boot On Behalf Of Jaehoon Chung >> Sent: Friday, November 3, 2023 10:07 AM >> To: 'Mattijs Korpershoek' >> Cc: lu...@denx.de; u-

Re: [PATCH] usb: gadget: f_mass_storage: Stop ums on START-STOP UNIT SCSI command

2023-11-07 Thread Mattijs Korpershoek
the media > and enter low power state. > > This effectively adds support for exitting the 'ums' command from > host using 'eject /dev/sdN' that is on par with 'dfu-util -e' . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Lukasz Ma

[GIT PULL] Please pull u-boot-dfu-20231103

2023-11-03 Thread Mattijs Korpershoek
Hi Tom, Here is my first pull request of u-boot-dfu which includes: - Fix CRC chunk size in fastboot - Make size optional for dfu on mmc The CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/18433 Thanks, Mattijs The following changes since commit

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-03 Thread Mattijs Korpershoek
Hi Jaehoon, On ven., nov. 03, 2023 at 10:07, "Jaehoon Chung" wrote: > Hi Mathtjjs, > >> -Original Message- >> From: Mattijs Korpershoek >> Sent: Thursday, November 2, 2023 6:15 PM >> To: Jaehoon Chung >> Cc: lu...@denx.de; u-boot@

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-02 Thread Mattijs Korpershoek
Hi Jaehoon, On mar., oct. 31, 2023 at 15:50, Mattijs Korpershoek wrote: > Hi, > > On Mon, 20 Jun 2022 20:13:54 +0900, Jaehoon Chung wrote: >> Add CONFIG_DFU_NAME_MAX_SIZE to change the proper size. >> If name is longer than default size, it can do wrong behavior during

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-10-31 Thread Mattijs Korpershoek
Hi, On Mon, 20 Jun 2022 20:13:54 +0900, Jaehoon Chung wrote: > Add CONFIG_DFU_NAME_MAX_SIZE to change the proper size. > If name is longer than default size, it can do wrong behavior during updating > image. So it need to change the proper maximum size. > > This patch is proviced the solution to

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-10-31 Thread Mattijs Korpershoek
imum size. > > This patch is proviced the solution to change value with configuration. > > Signed-off-by: Jaehoon Chung I could not find a maximum size in the DFU 1.1 spec [1] neither in the dfu-util codebase. [1] https://www.usb.org/sites/default/files/DFU_1.1.pdf Reviewed-by

Re: [PATCH] dfu: mmc: Add support for exposing whole mmc device

2023-10-31 Thread Mattijs Korpershoek
Hi, On Sun, 29 Oct 2023 23:37:22 +0100, Marek Vasut wrote: > Add support for exposing the whole mmc device by setting the 'size' > parameter to 0. This can be useful in case it is not clear what the > total device size is up front. Update the documentation accordingly. > > Thanks, Applied to

Re: [PATCH] fastboot: fix CRC32 chunk size checking

2023-10-31 Thread Mattijs Korpershoek
Hi, On Mon, 25 Sep 2023 12:37:15 +0200, Wojciech Nizinski wrote: > genimage create android-sparse file with CRC32 chunk at end. When > U-Boot's fastboot receives this chunk it returns error message: > `Fail Bogus chunk size for chunk type Dont Care` > > According to reference implementation of

Re: [PATCH] dfu: mmc: Add support for exposing whole mmc device

2023-10-31 Thread Mattijs Korpershoek
by: Marek Vasut > --- > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > doc/usage/dfu.rst | 5 + > drivers/dfu/dfu_mmc.c | 10 ++ > 2 files changed, 15 insertions(+) > > diff --git a/

[PATCH] configs: khadas-vim3*_android: fix environment saving

2023-10-26 Thread Mattijs Korpershoek
: b749d5ecdc06 ("configs: meson64_android: define raw parts for bootloader") Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 4 configs/khadas-vim3_android_defconfig | 4 configs/khadas-vim3l_android_ab_defconfig | 4 conf

Re: [PATCH 0/4] ARM: meson: Add boot over DFU RAM as an USB boot step

2023-10-24 Thread Mattijs Korpershoek
rmstrong I did a simple boot to aosp/main test on vim3 and also used fastboot to flash the bootloader. Tested-by: Mattijs Korpershoek # on vim3 > --- > Neil Armstrong (4): > ARM: meson: enable FIT with LEGACY_IMAGE_FORMAT on all configs > configs: meson64: declare addr

Re: [PATCH] doc: Replace dm_dump_all() with dm_dump_tree()

2023-10-20 Thread Mattijs Korpershoek
ed-off-by: Dylan Corrales Reviewed-by: Mattijs Korpershoek > --- > > doc/develop/driver-model/debugging.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/develop/driver-model/debugging.rst > b/doc/develop/driver-model/debugging.rst > index

Re: [PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-19 Thread Mattijs Korpershoek
On jeu., oct. 19, 2023 at 10:18, Lukasz Majewski wrote: > On Thu, 19 Oct 2023 09:40:37 +0200 > Mattijs Korpershoek wrote: > >> Hi Lukasz, Marek, >> >> On mer., oct. 18, 2023 at 12:52, Lukasz Majewski >> wrote: >> >> > Hi Mattijs, >> &

Re: [PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-19 Thread Mattijs Korpershoek
oot/custodians/u-boot-dfu ? If yes, I imagine I would need write access to it. > >> Signed-off-by: Mattijs Korpershoek >> --- >> Mattijs Korpershoek (2): >> MAINTAINERS: usb gadget: add Mattijs >> MAINTAINERS: fastboot: add Mattijs >> >>

Re: [PATCH v3 1/3] cmd: Change the dependencies between CMD_BIND and USB_GADGET

2023-10-18 Thread Mattijs Korpershoek
ply' keyword to enforce this. > > Signed-off-by: Miquel Raynal Tested that the bind command exists when building with: configs/khadas-vim3_android_defconfig Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > cmd/Kconfig| 1 - > drivers/us

Re: [PATCH] phy: meson-g12a-usb2: fix ret check on power_domain_get

2023-10-18 Thread Mattijs Korpershoek
domain > No USB device found > USB init failed: -19 > > Add ENOENT check on ret in probe function. > > Fixes: 5533c883ce10 ("phy: support Amlogic A1 family") > > Signed-off-by: Guillaume La Roque Tested on vim3 with: => fastboot usb 0 Tested-by: Mattij

[PATCH 2/2] MAINTAINERS: fastboot: add Mattijs

2023-10-05 Thread Mattijs Korpershoek
Fastboot has been marked as orphaned since 2021. Since I'm interested in maintaining this, assign myself. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 008c593f30ee..6790f4ddbd45 100644

[PATCH 1/2] MAINTAINERS: usb gadget: add Mattijs

2023-10-05 Thread Mattijs Korpershoek
It seems that Lukasz and Marek could get some help in maintaining the usb gadget drivers. Assign myself as maintainer. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4df79254dfe1..008c593f30ee 100644

[PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-05 Thread Mattijs Korpershoek
ell. Note that I have no previous (open-source) maintainer experience so I will do my best to learn. Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): MAINTAINERS: usb gadget: add Mattijs MAINTAINERS: fastboot: add Mattijs MAINTAINERS | 4 +++- 1 file changed, 3 inserti

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-05 Thread Mattijs Korpershoek
ses. Let's also hint people who would get this error and grep it into > the sources a better explanation of what's wrong with their workflow. > > Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek > --- > While doing this I really wanted to add "much more" er

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-05 Thread Mattijs Korpershoek
textual line. Unfortunately, > because of how this string is used (like within the 'help' command) I > cannot detail much more, but at least the pointer is there. > > Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek > --- > Resend: no change. > > Changes in

Re: [PATCH] fastboot: fix CRC32 chunk size checking

2023-10-02 Thread Mattijs Korpershoek
> > the chunk_header.total_sz is CHUNK_HEADER_LEN + 4 (CRC32 size). > > Signed-off-by: Wojciech Nizinski However, the change looks fine to me. Reviewed-by: Mattijs Korpershoek I also tested by reflashing a super image from aosp/main on the vim3 board. Base commit: 2173c4a99066 ("Me

Re: [PATCH v5 39/43] command: Include a required header in command.h

2023-09-30 Thread Mattijs Korpershoek
On mer., sept. 27, 2023 at 08:22, Simon Glass wrote: > This uses ARRAY_SIZE() but does not include the header file which declares > it. Fix this, so that command.h can be included without common.h > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- &g

Re: [PATCH v2 4/4] usb: Avoid unbinding devices in use by bootflows

2023-09-23 Thread Mattijs Korpershoek
Hi Simon, Thank you for your patch. On ven., sept. 22, 2023 at 15:38, Simon Glass wrote: > When a USB device is unbound, it causes any bootflows attached to it to > be removed, via a call to bootdev_clear_bootflows() from > bootdev_pre_unbind(). This obviously makes it impossible to boot the >

Re: [PATCH v5 10/21] boot: Rename Android-boot text

2023-09-15 Thread Mattijs Korpershoek
On jeu., sept. 14, 2023 at 10:55, Simon Glass wrote: > Phrases like 'Enable support for' are pointless since this is an option > which enables things. Drop that part so it is easier to follow. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > >

Re: [PATCH 2/2] arm: dts: k3-am625: Sync with kernel v6.6-rc1

2023-09-12 Thread Mattijs Korpershoek
On lun., sept. 11, 2023 at 09:02, Nishanth Menon wrote: > Sync device tree with v6.6-rc1 > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/k3-am62-main.dtsi | 52 - > arch/arm/dts/k3-am62-mcu.dtsi| 24 +

Re: [PATCH 1/2] arm: dts: k3-pinctrl: Sync with kernel v6.6-rc1

2023-09-12 Thread Mattijs Korpershoek
On lun., sept. 11, 2023 at 09:02, Nishanth Menon wrote: > Sync pinctrl header with v6.6-rc1 > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/k3-pinctrl.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arc

Re: [PATCH v2 15/17] usb: gadget: ether: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On lun., sept. 04, 2023 at 11:10, Marek Vasut wrote: > On 9/4/23 09:56, Mattijs Korpershoek wrote: >> On ven., sept. 01, 2023 at 11:50, Marek Vasut wrote: >> >>> Convert to plain udevice interaction with UDC controller >>> device, avoid the use of UDC ucla

Re: [PATCH v2 15/17] usb: gadget: ether: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > V2: Use udev-

Re: [PATCH v2 14/17] usb: gadget: acm: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:50, Marek Vasut wrote: > Convert to plain udevice interaction with UDC controller > device, avoid the use of UDC uclass dev_array . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merk

Re: [PATCH v2 13/17] thordown: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm Reviewed-by: Mattijs Ko

Re: [PATCH v2 07/17] cmd: thordown: Reorder variable declaration

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:49, Marek Vasut wrote: > Move the variable declaration around to improve code readability. > No functional change. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc

Re: [PATCH v2 05/17] cmd: rockusb: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:49, Marek Vasut wrote: > Convert to plain udevice interaction with UDC controller > device, avoid the use of UDC uclass dev_array . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merk

Re: [PATCH v1] include: configs: verdin-am62: drop unused sdram address

2023-08-29 Thread Mattijs Korpershoek
> Signed-off-by: Marcel Ziswiler Reviewed-by: Mattijs Korpershoek > > --- > > include/configs/verdin-am62.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h > index 7990ea831

Re: [PATCH V6 16/20] configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support

2023-08-28 Thread Mattijs Korpershoek
> Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > New patch picked from Jan > https://lore.kernel.org/all/c93b19ed-43fe-44a2-9726-371fb9d2f...@web.de/ > Changes: > - modify am62x_evm as common change. > - slight update to $subject and commit messag

Re: [PATCH V6 11/20] board: ti: am62x: am62x.env: Use default findfdt

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Use the default findfdt using CONFIG_DEFAULT_DEVICE_TREE > > Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change that pick

Re: [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env

2023-08-28 Thread Mattijs Korpershoek
multiple boards and handles > architecture folder location changes centrally. > > TI ARMV7 platforms will need to override default_device_tree_subarch > in the env file to point to the appropriate platform. Note: default > "omap" is used to cater to "most common" default

Re: [PATCH V6 08/20] include: configs: am62x_evm: Drop distro_bootcmd usage

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Now that BOOTSTD is used by default, drop un-used header file > inclusion. > > Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- &

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

2023-08-28 Thread Mattijs Korpershoek
> Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > V5: https://lore.kernel.org/r/20230824031101.3460411-6...@ti.com > configs

Re: [PATCH V6 06/20] board: ti: am62x: am62x.env: Add explicit boot_targets

2023-08-28 Thread Mattijs Korpershoek
ivalent > class. > > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > > V5: https://lore.kernel.org/r/20230824031101.3460411-5...@ti.com > board/ti/

Re: [PATCH V6 05/20] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS

2023-08-28 Thread Mattijs Korpershoek
t; Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > > V5: https://lore.kernel.org/r/20230824031101.3460411-4...@ti.com > > include/configs/am62x_ev

Re: [PATCH V6 04/20] include: configs: am62x_evm: Drop unused SDRAM address

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Drop unused macro. This was meant for a second region of DDR which we > do not need for AM62x evm configurations. > > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek &g

Re: [PATCH V6 02/20] include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > 'script' bootmethod that should be used with CONFIG_BOOTSTD. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > > Since Simon educated me to realize that the published documentation can > b

Re: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > If mmc dev reports that the device is not present, there is no point in > proceeding further to attempt to load the files. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > new patch - notice

Re: [PATCH V6 00/20] board: ti: Add support for BeaglePlay

2023-08-28 Thread Mattijs Korpershoek
> > Robert Nelson (1): > arm: dts: Add k3-am625-beagleplay I re-tested v6. Using baseline 11cf91f755c7 ("Merge branch '2023-08-26-bootstd-chromeos-impreovements-and-move-to-gcc-13.2' into next") I could boot all the way to U-boot proper shell. And the LEDs work for me as well

Re: [RFC PATCH 2/2] doc: board: ti: k3: Convert to sphinx-prompt

2023-08-28 Thread Mattijs Korpershoek
> [1] https://lore.kernel.org/all/87fs48rgto@baylibre.com/ > Reported-by: Simon Glass > Suggested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek Small nitpick below, which is probably a matter of preference > --- &

Re: [RFC PATCH 1/2] doc: sphinx: Add sphinx-prompt

2023-08-28 Thread Mattijs Korpershoek
/all/87fs48rgto@baylibre.com/ > Suggested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Version picked is the best that works with Sphinx 3.4.3 > > doc/conf.py | 2 +- > doc/sphinx/requirements.txt | 1 + &g

Re: [PATCH V5 16/17] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file

2023-08-24 Thread Mattijs Korpershoek
On mer., août 23, 2023 at 22:11, Nishanth Menon wrote: > Add defconfig fragments for am625 based beagleplay and corresponding > customized environment file for beagleplay. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Changes Since V4: > *

Re: [PATCH V5 13/17] arm: mach-k3: am625: Add support for UDA FS

2023-08-24 Thread Mattijs Korpershoek
stem configuration to > pick data from UDA. > > While at this, drop the extraneous whitespace. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Changes since V4: > - Did'nt pickup Mattijs' reviewed-by - no more iffdeffery - so mig

Re: [PATCH V5 11/17] arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static

2023-08-24 Thread Mattijs Korpershoek
turn for a void function. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > new patch (cleanup before modifying for adding UDA-FS) > > arch/arm/mach-k3/am625_init.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/a

Re: [PATCH V5 10/17] arm: mach-k3: am625_init: Use IS_ENABLED()

2023-08-24 Thread Mattijs Korpershoek
On mer., août 23, 2023 at 22:10, Nishanth Menon wrote: > Drop the #ifdeffery and use IS_ENABLED() inline check and let the compiler > do it's thing. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > new patch (cleanup before modifying for adding UDA

Re: [PATCH V5 07/17] include: env: ti: ti_armv7_common.env: Rename to ti_common.env

2023-08-24 Thread Mattijs Korpershoek
On mer., août 23, 2023 at 22:10, Nishanth Menon wrote: > ti_armv7_common does not make any more sense as it is used by armv7 > and armv8 TI based platforms. > > Reported-by: Tom Rini > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > New patc

Re: [PATCH V4 8/8] doc: board: ti: Add BeaglePlay documentation

2023-08-24 Thread Mattijs Korpershoek
On mer., août 23, 2023 at 22:27, Nishanth Menon wrote: > On 21:01-20230823, Simon Glass wrote: >> Hi Nishanth, >> >> On Wed, 23 Aug 2023 at 18:18, Nishanth Menon wrote: >> > >> > On 17:57-20230823, Simon Glass wrote: >> > [...] >> > > > This is how we have a common bit of rST for how to build

Re: [PATCH V5 02/17] include: configs: am62x_evm: Drop unused SDRAM address

2023-08-24 Thread Mattijs Korpershoek
Hi Nishanth, On mer., août 23, 2023 at 22:10, Nishanth Menon wrote: > Drop unused macro. This was meant for a second region of DDR which we > do not need for AM62x evm configurations. > > Signed-off-by: Nishanth Menon > --- > New patch (part of bootstd transition) > >

Re: [PATCH V5 01/17] include: configs: ti_armv7_common: Add documentation for protected section

2023-08-24 Thread Mattijs Korpershoek
On mer., août 23, 2023 at 22:10, Nishanth Menon wrote: > Make the section protected by CONFIG_DISTRO_DEFAULTS macro clear. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > > New patch (part of bootstd transition) > > include/configs/ti_ar

Re: [PATCH V5 00/17] board: ti: Add support for BeaglePlay

2023-08-24 Thread Mattijs Korpershoek
BeaglePlay documentation > > Robert Nelson (1): > arm: dts: Add k3-am625-beagleplay I re-tested v5. Using baseline 97841de68043 ("Merge branch '2023-08-22-assorted-code-cleanups' into next") I could boot all the way to U-boot proper shell. And the LEDs work for me as

Re: [PATCH V4 6/8] arm: dts: Add k3-am625-beagleplay

2023-08-23 Thread Mattijs Korpershoek
> Signed-off-by: Robert Nelson > Co-developed-by: Nishanth Menon > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Changes since V3: > * Added LEDs to u-boot.dtsi boot phase properties and default to be on. > * Dropped the slowing down of emm

Re: [PATCH V4 8/8] doc: board: ti: Add BeaglePlay documentation

2023-08-23 Thread Mattijs Korpershoek
Hi Nishanth, On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > Add base documentation for BeaglePlay > > Signed-off-by: Nishanth Menon This is great! Thanks a lot for the documentation update, especially the "Flash to eMMC" section. Reviewed-by: Mattijs Korpe

Re: [PATCH V4 7/8] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file

2023-08-23 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > Add defconfig fragments for am625 based beagleplay and corresponding > customized environment file for beagleplay. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Changes: > * new env

Re: [PATCH V4 5/8] arm: dts: k3-am625-sk-binman: Add labels for unsigned binary

2023-08-23 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > Add labels for unsigned binary to permit over-ride. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Cc: Simon Glass > > Changes since V3: None > > V3: https://lore.kernel.org/a

Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > From: Nitin Yadav > > U-Boot is fail to boot class U1 UHS SD cards (such as microcenter) > due to incorrect OTAP and ITAP delay select values. Update OTAP and > ITAP delay select values based on recommeded RIOT values to fix boot > issue.

Re: [PATCH V4 3/8] arm: mach-k3: am625: Add support for UDA FS

2023-08-23 Thread Mattijs Korpershoek
stem configuration to > pick data from UDA. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > New patch > arch/arm/mach-k3/am625_init.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/ma

Re: [PATCH V4 2/8] configs: am62x_evm*: Enable EMMC_BOOT configuration

2023-08-23 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > Enable EMMC boot support for AM62x evm base configuration. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > New patch > > configs/am62x_evm_a53_defconfig | 1 + > configs/am62x_evm_

Re: [PATCH V4 1/8] env_default: Allow CONFIG_EXTRA_ENV_TEXT to override CFG_EXTRA_ENV_SETTINGS

2023-08-23 Thread Mattijs Korpershoek
0 > > By changing the order of the inclusion, we allow for the > CONFIG_EXTRA_ENV_TEXT to have a higher priority in the definition. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > Cc: Simon Glass > > New patch > > include/env_default.h | 6 +++--- > 1 file

Re: [PATCH V4 0/8] board: ti: Add support for BeaglePlay

2023-08-23 Thread Mattijs Korpershoek
file > doc: board: ti: Add BeaglePlay documentation > > Nitin Yadav (1): > drivers: mmc: am654_sdhci: Update OTAP/ITAP delay > > Robert Nelson (1): > arm: dts: Add k3-am625-beagleplay Using baseline 7e6e40c57233 ("Merge tag 'v2023.10-rc3' into next"), I could

Re: [PATCH 17/17] board: usb: Replace legacy usb_gadget_handle_interrupts()

2023-08-22 Thread Mattijs Korpershoek
/dwc3_uboot_exit() > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Phil

Re: [PATCH 16/17] dm: usb: udc: Drop legacy udevice handler functions

2023-08-22 Thread Mattijs Korpershoek
all call sites use dm_usb_gadget_handle_interrupts(). > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc:

Re: [PATCH 12/17] sdp: Use plain udevice for UDC controller interaction

2023-08-22 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > cmd/usb_gadget_

Re: [PATCH 11/17] spl: sdp: Detach the controller on error

2023-08-22 Thread Mattijs Korpershoek
: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefa

Re: [PATCH 10/17] dfu: Use plain udevice for UDC controller interaction

2023-08-22 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > common/dfu.c | 15

Re: [PATCH 09/17] dfu: Detach the controller on error

2023-08-22 Thread Mattijs Korpershoek
: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc:

Re: [PATCH 08/17] cmd: ums: Use plain udevice for UDC controller interaction

2023-08-22 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > cmd/usb_ma

Re: [PATCH 06/17] cmd: sdp: Reorder variable declaration

2023-08-22 Thread Mattijs Korpershoek
> Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > cmd/usb_gadget_sdp.c | 4 ++-- > 1 f

Re: [PATCH 04/17] cmd: fastboot: Use plain udevice for UDC controller interaction

2023-08-22 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > cmd/fastboot.c | 7 +++

Re: [PATCH 03/17] configs: sandbox: Enable DM_USB_GADGET

2023-08-22 Thread Mattijs Korpershoek
On sam., août 19, 2023 at 16:23, Marek Vasut wrote: > Switch sandbox to DM_USB_GADGET, DM is the future. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Ray

Re: [PATCH 02/17] usb: sandbox: Add DM_USB_GADGET support

2023-08-22 Thread Mattijs Korpershoek
> Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Phi

Re: [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-08-22 Thread Mattijs Korpershoek
se functions and the dev_array can be dropped. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patric

Re: [PATCH V3 0/4] board: ti: Add support for BeaglePlay

2023-08-22 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 10:40, Nishanth Menon wrote: > On 17:33-20230822, Mattijs Korpershoek wrote: >> On mar., août 15, 2023 at 11:44, Nishanth Menon wrote: >> >> > Add support for BeaglePlay - rev 3 >> > >> > Boot log: https://gist.github.c

Re: [PATCH V3 0/4] board: ti: Add support for BeaglePlay

2023-08-22 Thread Mattijs Korpershoek
On mar., août 15, 2023 at 11:44, Nishanth Menon wrote: > Add support for BeaglePlay - rev 3 > > Boot log: https://gist.github.com/nmenon/3e99b44380873263e39ba4d84788db89 > > Full series(including dependencies) can be found at: > https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3 >

Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-31 Thread Mattijs Korpershoek
On dim., juil. 30, 2023 at 11:15, Simon Glass wrote: > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass Reviewed-by: Matt

Re: [PATCH 3/8] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-28 Thread Mattijs Korpershoek
On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass > --- > > boot/bootdev-uclass.c

Re: [PATCH 4/8] bootstd: Correct creating of bootdev sibling

2023-07-28 Thread Mattijs Korpershoek
On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > Use the correct function here, since there may be multiple IDE devices > available. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > drivers/block/ide.c | 4 ++-- > 1 file changed, 2 in

Re: [RFC PATCH 3/4] arm: dts: Fix build of am62a7 dtbs

2023-07-13 Thread Mattijs Korpershoek
Dolcini > Cc: Sjoerd Simons > Cc: Wadim Egorov > Signed-off-by: Nishanth Menon > --- Reviewed-by: Mattijs Korpershoek > > Found this as i was building and wondering why 62a7 dtbs were building.. > > arch/arm/dts/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-07 Thread Mattijs Korpershoek
Hi Qianfan, Thank you for your review. On ven., juil. 07, 2023 at 18:54, qianfan wrote: > 在 2023/7/7 16:13, Mattijs Korpershoek 写道: >> Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") >> fixed cache alignment for systems with a D-CACHE. >>

[PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-07 Thread Mattijs Korpershoek
ore.kernel.org/r/20221118121323.4009193-1-gary.bis...@boundarydevices.com [2] https://lore.kernel.org/r/all/43e4c17c-4483-ec8e-f843-9b4c5569b...@seco.com/ Fixes: 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") Signed-off-by: Mattijs Korpershoek --- Changes in v2: - Use FAST

Re: [PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-07-07 Thread Mattijs Korpershoek
On jeu., juil. 06, 2023 at 13:00, Tom Rini wrote: > On Thu, Jul 06, 2023 at 11:43:13AM +0200, Mattijs Korpershoek wrote: >> On lun., juin 19, 2023 at 10:21, Mattijs Korpershoek >> wrote: >> >> > Hi Qianfan, >> > >> > Thank you for your r

Re: [PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-07-06 Thread Mattijs Korpershoek
On lun., juin 19, 2023 at 10:21, Mattijs Korpershoek wrote: > Hi Qianfan, > > Thank you for your review. > > On lun., juin 19, 2023 at 14:19, qianfan wrote: > >> 在 2023/6/16 21:26, Mattijs Korpershoek 写道: >>> Commit 62649165cb02 ("lib: sparse: Make CHU

Re: [PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-06-19 Thread Mattijs Korpershoek
Hi Qianfan, Thank you for your review. On lun., juin 19, 2023 at 14:19, qianfan wrote: > 在 2023/6/16 21:26, Mattijs Korpershoek 写道: >> Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") >> fixed cache alignment for systems with a D-CACHE. >>

Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2023-06-16 Thread Mattijs Korpershoek
On ven., juin 16, 2023 at 13:56, Mattijs Korpershoek wrote: > Hi Gary, Sean, > > On lun., nov. 21, 2022 at 10:09, Sean Anderson wrote: > >> On 11/21/22 09:50, Gary Bisson wrote: >>> Hi, >>> >>> On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anders

[PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-06-16 Thread Mattijs Korpershoek
121323.4009193-1-gary.bis...@boundarydevices.com [2] https://lore.kernel.org/r/all/43e4c17c-4483-ec8e-f843-9b4c5569b...@seco.com/ Fixes: 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") Signed-off-by: Mattijs Korpershoek --- lib/image-sparse.c | 2 +- 1 file changed,

Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2023-06-16 Thread Mattijs Korpershoek
Hi Gary, Sean, On lun., nov. 21, 2022 at 10:09, Sean Anderson wrote: > On 11/21/22 09:50, Gary Bisson wrote: >> Hi, >> >> On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anderson wrote: >>> On 11/18/22 07:13, Gary Bisson wrote: >>> > This reverts commit 62649165cb02ab95b57360bb362886935f524f26.

[PATCH] serial: meson: fix meson_serial_pending() tx logic

2023-06-06 Thread Mattijs Korpershoek
b60 ("console: Use flush() before panic and reset"), Signed-off-by: Mattijs Korpershoek --- Tested with: => reset # vim3 board no longer hangs --- drivers/serial/serial_meson.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_meson.c b/drivers/ser

<    1   2   3   4   5   6   >