Marczak p.marc...@samsung.com
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cli_hush.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index d643912..296542f 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -3217,7 +3217,7
On Sat, Nov 01, 2014 at 09:11:34AM -0600, Simon Glass wrote:
On 29 October 2014 16:21, Rabin Vincent ra...@rab.in wrote:
Attempting to run the sandbox leads to a segfault, because some dynamic
libraries (outside of u-boot) attempt to use malloc() to allocate memory
before u-boot's gd
On Sat, Nov 01, 2014 at 09:12:37AM -0600, Simon Glass wrote:
On 29 October 2014 16:21, Rabin Vincent ra...@rab.in wrote:
+ assert(run_command(setenv ut_var '\'; setenv ut_var2
\${ut_var}\, 0) == 0);
+ assert(!strcmp(getenv(ut_var2), \));
+
+ assert(run_command(setenv
Attempting to run:
- an empty string
- a string with just spaces
returns different error codes, 1 for the empty string and 0
for the string with just spaces. Make both of them return
0 for consistency.
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cli_hush.c | 4 +++-
test
run_command() returns success even if the command had a syntax error;
correct this behaviour.
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cli_hush.c | 2 +-
test/command_ut.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
) at dl-init.c:126
#8 0x77ddd1ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/dlmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/dlmalloc.c b/common/dlmalloc.c
index f987339..d87834d 100644
catout
'\\\''\$\$catin'\\\''' \; run catX
Signed-off-by: Rabin Vincent ra...@rab.in
---
test/command_ut.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/test/command_ut.c b/test/command_ut.c
index 926573a..21804a4 100644
--- a/test/command_ut.c
+++ b/test/command_ut.c
sandbox crashes if a variable is set in the -c command, because
hush's top_vars is not allocated. Call cli_init() from sandbox
to ensure this is done before we execute the -c command.
$ ./u-boot -c 'a=1'
...
Segmentation fault (core dumped)
Signed-off-by: Rabin Vincent ra...@rab.in
---
arch
() checks for rcode not being -1, but rcode is only
ever 0 or 1.
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cli_hush.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index 9607e93..a07ae71 100644
--- a/common/cli_hush.c
+++ b/common
On Thu, Apr 14, 2011 at 04:03, Simon Glass s...@chromium.org wrote:
On Wed, Apr 13, 2011 at 12:16 PM, Andy Fleming aflem...@gmail.com wrote:
+ read_buf = ~HW_CFG_RXDOFF_;
+
+#ifdef CONFIG_TEGRA2
+ /* Tegra2 requires NET_IP_ALIGN = 0 */
+#define NET_IP_ALIGN 0
+#else
+ /*
Use C structs for registers, and use readl/writel instead of custom
accessors.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
drivers/serial/serial_pl01x.c | 56 ++--
drivers/serial
Hi Tom,
On Sun, Apr 11, 2010 at 10:45:41PM +0200, Tom wrote:
Rabin Vincent wrote:
On Fri, Apr 9, 2010 at 6:57 PM, Vaibhav Bedia vaibhav.be...@gmail.com
wrote:
As all Cortex processors implement the ARMv7 architecture a better grouping
IMHO would be cpu/cortex/a8 and cpu/cortex/a9
-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
Makefile | 20 ++--
arch/arm/cpu/{arm_cortexa8 = cortex}/Makefile |0
.../cpu/{arm_cortexa8 = cortex/a8}/mx51/Makefile |0
.../cpu/{arm_cortexa8 = cortex/a8}/mx51/clock.c
$CPUDIR. CPU-specific Makefiles can
choose to include code from inside $SUBCPU as necessary.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
Makefile |2 +-
board/freescale/mx51evk/config.mk |2
' would seem more logical to me.
Updated patch below.
Rabin
From 2131e817d21162d0dd47b56cc068eb868b1ac7fc Mon Sep 17 00:00:00 2001
From: Rabin Vincent rabin.vinc...@stericsson.com
Date: Tue, 13 Apr 2010 15:18:56 +0530
Subject: [PATCHv2 1/2] Allow SOC to be two-levels deep inside CPU
On ARM, it has
On Fri, Apr 9, 2010 at 6:57 PM, Vaibhav Bedia vaibhav.be...@gmail.com wrote:
As all Cortex processors implement the ARMv7 architecture a better grouping
IMHO would be cpu/cortex/a8 and cpu/cortex/a9. The common stuff can be under
cpu/cortex/.
Perhaps Tom can clarify if he's OK with this, since
On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote:
Rabin Vincent wrote:
+ /* UART2 */
+ nmk_gpio_af(29, GPIO_ALT_C);
+ nmk_gpio_af(30, GPIO_ALT_C);
Change these to immediates to logical #define's
I've changed this in the other places you mentioned, but for these
GPIOs, I'd
v2: Addressed review comments.
This series adds base support for ST-Ericsson's Ux500 series of Cortex-A9 based
SoCs. Several peripherals are shared with the Nomadik family, for which
support already exists in U-Boot.
Rabin Vincent (13):
Nomadik: move nomadik.h to asm/arch/nhk8815.h
Nomadik
The Nomadik GPIO driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
board/st/nhk8815/nhk8815.c
Eliminate some single-use macros. USEC_TO_COUNT and COUNT_TO_USEC are
replaced in a later patch.
Cc: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm926ejs/nomadik/timer.c |5
Change the Nomadik GPIO driver to get the base addresses from platform
specific code, since it will be used on multiple platforms with
different base addresses.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent
The Nomadik MTU driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm926ejs/nomadik/Makefile
Change the Nomadik MTU driver to get the clock rate and prescaler from
the config file. Also remove the hardcoded divisors and do the
calculations based on the configured rate.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin
Cc: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
drivers/gpio/nomadik_gpio.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio
Eliminate register address #defines by using C structs, and move the
rest of the header contents into timer.c.
Cc: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm926ejs/nomadik/timer.c
It contains only 8815-specific addresses, so move it to an appropriate
location and name, freeing up the nomadik.h name for common
Nomadik-family peripherals.
Cc: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc
Add Cortex A9 support by copying the code for Cortex A8. The only
change is a removal of some OMAP3 specific code.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/{arm_cortexa8 = arm_cortexa9}/Makefile |0
cpu
Conditionally compile the code calling lowlevel_init, to avoid the
following build error when CONFIG_SKIP_LOWLEVEL_INIT is defined:
start.S:218: undefined reference to `lowlevel_init'
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc
Add the base SoC code for ST-Ericsson's Ux500 series of Cortex A9 based
SoCs.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm_cortexa9/ux500/Makefile | 45 ++
cpu/arm_cortexa9/ux500/clock.c
The Ux500 variants of the pl011 have separate LCRH registers for RX and
TX. The TX register is at the same offset as the unmodified pl011, so
we need to additionally program only the RX register.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc
Add base board code for the MOP500 board, which uses the U8500 SoC.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
MAINTAINERS |4 ++
MAKEALL |9 +++
Makefile
On Sun, Mar 28, 2010 at 07:42:27PM +0200, Tom wrote:
Rabin Vincent wrote:
+/* Turn on peripheral clock at PRCC level */
+void u8500_clock_enable(int periph, int kern, int cluster)
+{
+ struct clkrst *clkrst = (struct clkrst *) clkrst_base[periph - 1];
-1 on array access.
Convert
On Sun, Mar 28, 2010 at 07:30:01PM +0200, Tom wrote:
Rabin Vincent wrote:
The Nomadik MTU driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off
On Sun, Mar 28, 2010 at 07:32:17PM +0200, Tom wrote:
Rabin Vincent wrote:
diff --git a/include/configs/nhk8815.h b/include/configs/nhk8815.h
[...]
#ifndef __ASSEMBLY__
-#include asm/arch/gpio.h
+#include nomadik_gpio.h
It would be better if the #include was not in config file.
Can
The Nomadik GPIO driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
board/st/nhk8815/nhk8815.c
The Nomadik MTU driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm926ejs/nomadik/Makefile
by Alessandro Rubini on 2009-11-25:
http://lists.denx.de/pipermail/u-boot/2009-November/064800.html
Cc: Alessandro Rubini rub...@unipv.it
Rabin Vincent (8):
Nomadik: move timer code to drivers/misc
Nomadik: move gpio driver to drivers/gpio
nomadik_gpio: get base address from platform code
nomadik_mtu
Change the Nomadik MTU driver to get the clock rate and prescaler from
the config file. Also remove the hardcoded divisors and do the
calculations based on the configured rate.
Acked-by: Alessandro Rubini rub...@unipv.it
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
cpu/arm_cortexa8/ux500/Makefile | 45 +++
cpu/arm_cortexa8/ux500/clock.c| 56 +++
cpu/arm_cortexa8/ux500/cpu.c | 49
include/asm-arm/arch-ux500/clock.h
Conditionally compile the code calling lowlevel_init, to avoid the
following build error when CONFIG_SKIP_LOWLEVEL_INIT is defined:
start.S:218: undefined reference to `lowlevel_init'
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc
The Ux500 variants of the pl011 have separate LCRH registers for RX and
TX. The TX register is at the same offset as the unmodified pl011, so
we need to additionally program only the RX register.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc
Add base board code for the MOP500 board, which uses the U8500 SoC.
Acked-by: Michael Brandt michael.bra...@stericsson.com
Tested-by: Michael Brandt michael.bra...@stericsson.com
Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com
---
MAINTAINERS |4 ++
MAKEALL
On Fri, Jul 10, 2009 at 02:52:32PM +0200, Drasko DRASKOVIC wrote:
[...]
Suppose that I allocated one register in start.S and put in it some data I
want to have later on C side. From start.S we enter to start_armboot(void)
function.
Would this work :
void start_armboot (void)
{
On Tue, Jun 02, 2009 at 05:47:09PM +0200, Herrmann Ulrich wrote:
Rabin Vincent's fix for little endian systems fixes only the issues
regarding responses received on the command line.
However the SD card's SCR register is received on the DAT0 line
- therefore it must be handled in an endian
Andy,
On Sun, Apr 05, 2009 at 01:30:52PM +0530, Rabin Vincent wrote:
Remove some repeated words and superfluous newlines in the mmc command
help entries.
Signed-off-by: Rabin Vincent ra...@rab.in
Any comments on this set of patches?
Rabin
___
U
Remove some repeated words and superfluous newlines in the mmc command
help entries.
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cmd_mmc.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
index f1fa32f..bd55ff1 100644
find_mmc_device returns NULL if an invalid device number is specified.
Check for this to avoid dereferencing NULL pointers.
Signed-off-by: Rabin Vincent ra...@rab.in
---
common/cmd_mmc.c |9 +
drivers/mmc/mmc.c |2 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git
The generic MMC core uses direct long long divisions, which do not build
with ARM EABI toolchains. Use lldiv() instead, which works everywhere.
Signed-off-by: Rabin Vincent ra...@rab.in
---
drivers/mmc/mmc.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers
on little endian systems because they
assume that the bytes in the uints are in big endian byte order.
This patch fixes this by changing the response to be an array of four
uints and replacing the char-wise accesses with equivalent uint-wise
accesses.
Signed-off-by: Rabin Vincent ra...@rab.in
Now that response is a uint, we can drop all the casts.
Signed-off-by: Rabin Vincent ra...@rab.in
---
drivers/mmc/fsl_esdhc.c | 10 +-
drivers/mmc/mmc.c | 20 ++--
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers
50 matches
Mail list logo
