Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-31 Thread Christian Riesch
Hi Tom, On Mon, Jan 30, 2012 at 6:03 PM, Tom Rini tom.r...@gmail.com wrote: On Sun, Jan 29, 2012 at 6:36 AM, Christian Riesch christian.rie...@omicron.at wrote: 3) As Sughosh pointed out, the current code changes the V bit (location of exceptions). Sughosh's patch removes this code that does

[U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-30 Thread Christian Riesch
Hi, On Monday, January 30, 2012, Heiko Schocher h...@denx.de wrote: Hello Christian, Christian Riesch wrote: Hi all, On Fri, Jan 27, 2012 at 7:33 PM, Tom Rini tom.r...@gmail.com wrote: So, what do we want to do here? We really want to get this fix in so we can get the hawkboard SPL

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-30 Thread Sughosh Ganu
hi Christian, On Mon Jan 30, 2012 at 09:10:46AM +0100, Christian Riesch wrote: snip Perhaps we should revert that change and instead remove CONFIG_SKIP_LOWLEVEL_INIT from the da850 board config files. But since we don't need the lowlevel_init function for DA850 SoCs we must either add a

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-30 Thread Christian Riesch
Hello Heiko, On Mon, Jan 30, 2012 at 7:39 AM, Heiko Schocher h...@denx.de wrote: Christian Riesch wrote: 2) The current version of Sughosh's patch does not change the logic behind the LOWLEVEL_INIT defines but just fixes the code to agree with ARM's manual. Instead of invalidating the cache

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-30 Thread Tom Rini
On Sun, Jan 29, 2012 at 6:36 AM, Christian Riesch christian.rie...@omicron.at wrote: 3) As Sughosh pointed out, the current code changes the V bit (location of exceptions). Sughosh's patch removes this code that does this change.  I'm not sure if this is correct or not, so maybe you, Tom,

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-30 Thread Sughosh Ganu
On Mon Jan 30, 2012 at 10:03:40AM -0700, Tom Rini wrote: Q1) Currently, the low level initialization code for ARM926EJS CPUs in the u-boot bootloader clears the V-bit of the cp15 control register c1. By default, this bit is set on AM1808 and OMAP-L138 before u-boot ist started. Sughosh Ganu

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-29 Thread Christian Riesch
Hi all, On Fri, Jan 27, 2012 at 7:33 PM, Tom Rini tom.r...@gmail.com wrote: So, what do we want to do here?  We really want to get this fix in so we can get the hawkboard SPL changes in, and the other platforms / fixups that are gated by that. If I can sum it up, in the relevant section of

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-29 Thread Heiko Schocher
Hello Christian, Christian Riesch wrote: Hi all, On Fri, Jan 27, 2012 at 7:33 PM, Tom Rini tom.r...@gmail.com wrote: So, what do we want to do here? We really want to get this fix in so we can get the hawkboard SPL changes in, and the other platforms / fixups that are gated by that. If

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-29 Thread Sughosh Ganu
hi Christian, On Sun Jan 29, 2012 at 02:36:39PM +0100, Christian Riesch wrote: Hi all, On Fri, Jan 27, 2012 at 7:33 PM, Tom Rini tom.r...@gmail.com wrote: So, what do we want to do here?  We really want to get this fix in so we can get the hawkboard SPL changes in, and the other platforms

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-27 Thread Tom Rini
On Fri, Jan 20, 2012 at 6:06 AM, Aneesh V ane...@ti.com wrote: Hi Christian, On Friday 20 January 2012 06:18 PM, Christian Riesch wrote: Hi Aneesh, On Fri, Jan 20, 2012 at 1:13 PM, Aneesh Vane...@ti.com  wrote: On Friday 20 January 2012 02:51 PM, Christian Riesch wrote: On Fri, Jan 20,

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Aneesh V
Sughosh, On Friday 20 January 2012 12:58 PM, Christian Riesch wrote: On Thu, Jan 19, 2012 at 12:54 PM, Aneesh Vane...@ti.com wrote: On Thursday 19 January 2012 05:00 PM, Christian Riesch wrote: On Thu, Jan 19, 2012 at 11:17 AM, Aneesh Vane...@ti.comwrote: On Thursday 19 January 2012

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Christian Riesch
Hi Aneesh, On Fri, Jan 20, 2012 at 9:52 AM, Aneesh V ane...@ti.com wrote: Sughosh, [...] Can you send the value of SCR you found at SPL entry? This will clarify what's enabled and what's not. I would like to try that on my board as well for comparison. Could you please tell me how this

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread James W.
so sorry to you, i think it's difference between DISABLE and Flush. be careful. On Wed, Jan 11, 2012 at 2:12 AM, Sughosh Ganu urwithsugh...@gmail.comwrote: The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Tom Rini
On Fri, Jan 20, 2012 at 12:28 AM, Christian Riesch christian.rie...@omicron.at wrote: On Thu, Jan 19, 2012 at 12:54 PM, Aneesh V ane...@ti.com wrote: On Thursday 19 January 2012 05:00 PM, Christian Riesch wrote: On Thu, Jan 19, 2012 at 11:17 AM, Aneesh Vane...@ti.com  wrote: On Thursday 19

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Aneesh V
On Friday 20 January 2012 02:51 PM, Christian Riesch wrote: Hi Aneesh, On Fri, Jan 20, 2012 at 9:52 AM, Aneesh Vane...@ti.com wrote: Sughosh, [...] Can you send the value of SCR you found at SPL entry? This will clarify what's enabled and what's not. I would like to try that on my board

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Christian Riesch
Hi Aneesh, On Fri, Jan 20, 2012 at 1:13 PM, Aneesh V ane...@ti.com wrote: On Friday 20 January 2012 02:51 PM, Christian Riesch wrote: On Fri, Jan 20, 2012 at 9:52 AM, Aneesh Vane...@ti.com  wrote: Sughosh, [...] Can you send the value of SCR you found at SPL entry? This will clarify

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-20 Thread Aneesh V
Hi Christian, On Friday 20 January 2012 06:18 PM, Christian Riesch wrote: Hi Aneesh, On Fri, Jan 20, 2012 at 1:13 PM, Aneesh Vane...@ti.com wrote: On Friday 20 January 2012 02:51 PM, Christian Riesch wrote: On Fri, Jan 20, 2012 at 9:52 AM, Aneesh Vane...@ti.comwrote: Sughosh, [...]

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-19 Thread Aneesh V
Hi Sughosh, On Thursday 19 January 2012 12:23 PM, Sughosh Ganu wrote: On Tue Jan 17, 2012 at 08:27:58AM -0700, Tom Rini wrote: On Mon, Jan 16, 2012 at 11:46 PM, Sughosh Ganuurwithsugh...@gmail.com wrote: Hmm.. how did u-boot work on such boards? How can u-boot work with D-Cache enabled, if

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-19 Thread Christian Riesch
Hi Aneesh, On Thu, Jan 19, 2012 at 11:17 AM, Aneesh V ane...@ti.com wrote: On Thursday 19 January 2012 12:23 PM, Sughosh Ganu wrote:   Tried a few things on my end.   * Read the D-cache value in the spl, and confirmed that the data     cache is indeed not enabled. What is the value of the B

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-19 Thread Aneesh V
On Thursday 19 January 2012 05:00 PM, Christian Riesch wrote: Hi Aneesh, On Thu, Jan 19, 2012 at 11:17 AM, Aneesh Vane...@ti.com wrote: On Thursday 19 January 2012 12:23 PM, Sughosh Ganu wrote: Tried a few things on my end. * Read the D-cache value in the spl, and confirmed that the

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-19 Thread Christian Riesch
On Thu, Jan 19, 2012 at 12:54 PM, Aneesh V ane...@ti.com wrote: On Thursday 19 January 2012 05:00 PM, Christian Riesch wrote: On Thu, Jan 19, 2012 at 11:17 AM, Aneesh Vane...@ti.com  wrote: On Thursday 19 January 2012 12:23 PM, Sughosh Ganu wrote:   Tried a few things on my end.   * Read the

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-18 Thread Sughosh Ganu
On Tue Jan 17, 2012 at 08:27:58AM -0700, Tom Rini wrote: On Mon, Jan 16, 2012 at 11:46 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: Hmm.. how did u-boot work on such boards? How can u-boot work with D-Cache enabled, if u-boot is not initializing it? (And I think, on davinci SoC

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-17 Thread Tom Rini
On Mon, Jan 16, 2012 at 11:46 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: On Mon Jan 16, 2012 at 10:57:05AM -0700, Tom Rini wrote: On Fri, Jan 13, 2012 at 10:38 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote:

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-16 Thread Tom Rini
On Fri, Jan 13, 2012 at 10:38 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-16 Thread Heiko Schocher
Hello Tom, Tom Rini wrote: On Fri, Jan 13, 2012 at 10:38 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-16 Thread Sughosh Ganu
On Mon Jan 16, 2012 at 10:57:05AM -0700, Tom Rini wrote: On Fri, Jan 13, 2012 at 10:38 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13,

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-15 Thread Heiko Schocher
Hello Sughosh, Sughosh Ganu wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-14 Thread Albert ARIBAUD
Le 12/01/2012 07:29, Sughosh Ganu a écrit : On Thu Jan 12, 2012 at 06:56:01AM +0100, Christian Riesch wrote: On Wednesday, January 11, 2012, Marek Vasutmarek.va...@gmail.com wrote: snip RBL executes an AIS script. Sughosh, could you please explain what your AIS does or how you create it?

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-14 Thread Christian Riesch
Hi Albert, On Saturday, January 14, 2012, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Le 12/01/2012 07:29, Sughosh Ganu a écrit : On Thu Jan 12, 2012 at 06:56:01AM +0100, Christian Riesch wrote: On Wednesday, January 11, 2012, Marek Vasutmarek.va...@gmail.com wrote: snip RBL

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-14 Thread Christian Riesch
Hi Sughosh, On Thursday, January 12, 2012, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Christian, On Thu Jan 12, 2012 at 03:04:37PM +0100, Christian Riesch wrote: On Thu, Jan 12, 2012 at 2:53 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: On Thu Jan 12, 2012 at 01:03:05PM +0100,

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-14 Thread Sughosh Ganu
hi Christian, On Sat Jan 14, 2012 at 06:20:06PM +0100, Christian Riesch wrote: Hi Sughosh, snip On Thursday, January 12, 2012, Sughosh Ganu urwithsugh...@gmail.com wrote: 1) The first test was done with the SPL and yes, here the RBL loads the SPL into SRAM, initializes DDR memory and then

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Sughosh Ganu
hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand what's going on here (I must confess that I didn't know anything about this cache stuff). Ok, thanks for taking time off to understand this issue.

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Tom Rini
On Fri, Jan 13, 2012 at 1:26 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand what's going on here (I must confess that I didn't know anything about

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Heiko Schocher
Hello Christian, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand what's going on here (I must confess that I didn't know anything about this cache stuff). On Tue, Jan 10, 2012 at 7:12 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: The current

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Heiko Schocher
Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand what's going on here (I must confess that I didn't know anything about this cache stuff). Ok, thanks for

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Sughosh Ganu
hi Heiko, On Fri Jan 13, 2012 at 04:06:22PM +0100, Heiko Schocher wrote: snip mcr p15, 0, r0, c8, c7, 0 /* flush v4 TLB */ /* * disable MMU stuff and caches */ mrc p15, 0, r0, c1, c0, 0 - bic r0, r0, #0x2300 /*

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Sughosh Ganu
On Fri Jan 13, 2012 at 07:41:37AM -0700, Tom Rini wrote: On Fri, Jan 13, 2012 at 1:26 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: snip        bic     r0, r0, #0x0087     /* clear bits 7, 2:0 (B--- -CAM) */        orr     r0, r0, #0x0002     /* set bit 2 (A) Align */    

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Sughosh Ganu
hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I tried to understand what's going on here (I must

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Aneesh V
On Friday 13 January 2012 11:08 PM, Sughosh Ganu wrote: hi Heiko, On Fri Jan 13, 2012 at 04:29:29PM +0100, Heiko Schocher wrote: Hello Sugosh, Sughosh Ganu wrote: hi Christian, On Fri Jan 13, 2012 at 09:06:26AM +0100, Christian Riesch wrote: Hi Sughosh, I had a look at the patch and I

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-13 Thread Sughosh Ganu
On Fri Jan 13, 2012 at 11:49:57PM +0530, Aneesh V wrote: On Friday 13 January 2012 11:08 PM, Sughosh Ganu wrote: snip Are you sure, the RBL enables the D-Cache on your board? Nevertheless, I think, we must disable the D-Cache here with cleaning it (as your patch did) instead only

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-12 Thread Christian Riesch
): mono dvflashutils/OMAP-L138/GNU/sfh_OMAP-L138.exe -targetType AM1808 -flashType SPI_MEM -p /dev/ttyUSB0 -flash dvflashutils/OMAP-L138/GNU/ubl/ubl_AM1808_SPI_MEM.bin ../u-boot/u-boot.bin And tried to boot - SUCCESS Countercheck: I reverted patch [U-Boot,1/2,V2] arm926: Flush the data cache before

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-12 Thread Sughosh Ganu
-boot/u-boot.bin And tried to boot - SUCCESS Countercheck: I reverted patch [U-Boot,1/2,V2] arm926: Flush the data cache before disabling it. and rebuilt git revert HEAD~2 make mrproper make da850evm_config make -j3 -s u-boot.ais Again I tried with ubl and without - both worked - SUCCESS

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-12 Thread Christian Riesch
-L138/GNU/ubl/ubl_AM1808_SPI_MEM.bin ../u-boot/u-boot.bin And tried to boot - SUCCESS Countercheck: I reverted patch [U-Boot,1/2,V2] arm926: Flush the data cache before disabling it. and rebuilt git revert HEAD~2 make mrproper make da850evm_config make -j3 -s u-boot.ais Again I tried

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-12 Thread Sughosh Ganu
hi Christian, On Thu Jan 12, 2012 at 03:04:37PM +0100, Christian Riesch wrote: On Thu, Jan 12, 2012 at 2:53 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: On Thu Jan 12, 2012 at 01:03:05PM +0100, Christian Riesch wrote: snip Since all my tests were successful I wonder what issues did

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM, with caches enabled by a first stage bootloader. What platforms

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Wed Jan 11, 2012 at 11:47:27AM +0100, Marek Vasut wrote: On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM, with

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Wed Jan 11, 2012 at 11:47:27AM +0100, Marek Vasut wrote: On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM,

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Wed Jan 11, 2012 at 01:42:38PM +0100, Marek Vasut wrote: On Wed Jan 11, 2012 at 11:47:27AM +0100, Marek Vasut wrote: On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems on

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Wed Jan 11, 2012 at 01:42:38PM +0100, Marek Vasut wrote: On Wed Jan 11, 2012 at 11:47:27AM +0100, Marek Vasut wrote: On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Wed Jan 11, 2012 at 01:42:38PM +0100, Marek Vasut wrote: On Wed Jan 11, 2012 at 11:47:27AM +0100, Marek Vasut wrote: On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Wed Jan 11, 2012 at 02:52:44PM +0100, Marek Vasut wrote: Changing the ecc layout for a single board, hmm not sure. Using a spl instead does me no harm whatsoever -- I don't need to update the spl frequently in any case, and then can use the nand driver as is. And how do you

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Wed Jan 11, 2012 at 02:52:44PM +0100, Marek Vasut wrote: Changing the ecc layout for a single board, hmm not sure. Using a spl instead does me no harm whatsoever -- I don't need to update the spl frequently in any case, and then can use the nand driver as is. And

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so if rbl changes it's layout for any subsequent board, we'd have to add that as well to the nand driver, and both in u-boot as well as the kernel.

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so if rbl changes it's layout for any subsequent board, we'd have to add that as well to the nand driver, and both in u-boot as well as the kernel.

[U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Christian Riesch
Hi, On Wednesday, January 11, 2012, Marek Vasut marek.va...@gmail.com wrote: On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so if rbl changes it's layout for any subsequent board, we'd have to add that

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Marek Vasut
Hi, On Wednesday, January 11, 2012, Marek Vasut marek.va...@gmail.com wrote: On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so if rbl changes it's layout for any subsequent board, we'd have to

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Christian Riesch
On Wednesday, January 11, 2012, Marek Vasut marek.va...@gmail.com wrote: Hi, On Wednesday, January 11, 2012, Marek Vasut marek.va...@gmail.com wrote: On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Thu Jan 12, 2012 at 06:56:01AM +0100, Christian Riesch wrote: On Wednesday, January 11, 2012, Marek Vasut marek.va...@gmail.com wrote: snip RBL executes an AIS script. Sughosh, could you please explain what your AIS does or how you create it? So basically, this SPL business can be

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-11 Thread Sughosh Ganu
On Wed Jan 11, 2012 at 07:50:50PM +0100, Marek Vasut wrote: On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: More so, given the fact that we don't have any control over rbl -- so if rbl changes it's layout for any subsequent board, we'd have to add that as well to

[U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-10 Thread Sughosh Ganu
The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM, with caches enabled by a first stage bootloader. The V bit of the cp15's control register c1 is set to the value of VINITHI on reset. Do

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-10 Thread Marek Vasut
The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM, with caches enabled by a first stage bootloader. What platforms are affected? M The V bit of the cp15's control register c1 is set

Re: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it.

2012-01-10 Thread Sughosh Ganu
On Tue Jan 10, 2012 at 09:07:58PM +0100, Marek Vasut wrote: The current implementation invalidates the cache instead of flushing it. This causes problems on platforms where the spl/u-boot is already loaded to the RAM, with caches enabled by a first stage bootloader. What platforms are