Re: U-Boot atheros PHY support and cubox ethernet

2020-06-25 Thread Fabio Estevam
Hi Soeren, On Thu, Jun 25, 2020 at 6:56 AM Soeren Moch wrote: > The phy-handle was missing in the fec node. With this added everything > works fine: Ops :-) Yes, I will submit this patch for U-Boot. Thanks

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-25 Thread Soeren Moch
Hi Fabio, On 25.06.20 01:19, Fabio Estevam wrote: > Hi Soeren, > > On Wed, Jun 24, 2020 at 7:29 PM Soeren Moch wrote: > >> Unfortunately I have no access to my usual development board (and will >> not have until the v2020.07 release). I only can use an old board >> without working USB-OTG, limite

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Fabio Estevam
On Wed, Jun 24, 2020 at 8:19 PM Fabio Estevam wrote: > - We tried via devicetree with the "qca,clk-out-frequency" property, > but it did not work. This is an area where you could add some debug > prints inside drivers/net/phy/atheros.c and see if if > qca,clk-out-frequency is being parsed correct

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Fabio Estevam
Hi Soeren, On Wed, Jun 24, 2020 at 7:29 PM Soeren Moch wrote: > Unfortunately I have no access to my usual development board (and will > not have until the v2020.07 release). I only can use an old board > without working USB-OTG, limited to eMMC boot. So I tried to avoid > bisecting, because a b

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Soeren Moch
Hi Fabio, On 24.06.20 23:35, Fabio Estevam wrote: > Hi Soeren, > > On Wed, Jun 24, 2020 at 5:45 PM Sören Moch wrote: > >> Still no luck: > > mx6cuboxi has an AR8035 too and it is working fine in U-Boot mainline. > > I am not sure why tbs2910 is failing. Could you try to bisect? > Unfortunately I

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Fabio Estevam
Hi Soeren, On Wed, Jun 24, 2020 at 5:45 PM Sören Moch wrote: > Still no luck: mx6cuboxi has an AR8035 too and it is working fine in U-Boot mainline. I am not sure why tbs2910 is failing. Could you try to bisect?

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Sören Moch
Hi Fabio, On 24.06.20 22:29, Fabio Estevam wrote: > Hi Soeren, > > On Wed, Jun 24, 2020 at 5:13 PM Soeren Moch wrote: > >> Schematics are at >> https://www.tbsdtv.com/download/document/tbs2910/TBS2910-Matrix-ARM-mini-PC-SCH_rev2.1.pdf > Here is another patch for you to try: > https://pastebin.com

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Fabio Estevam
Hi Soeren, On Wed, Jun 24, 2020 at 5:13 PM Soeren Moch wrote: > Schematics are at > https://www.tbsdtv.com/download/document/tbs2910/TBS2910-Matrix-ARM-mini-PC-SCH_rev2.1.pdf Here is another patch for you to try: https://pastebin.com/raw/Dkipgq1n

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Soeren Moch
Hi Fabio On 24.06.20 21:39, Fabio Estevam wrote: > Hi Soeren, > > On Wed, Jun 24, 2020 at 4:20 PM Soeren Moch wrote: > >> I tested current master (v2020.07-rc5 + imx fixes) on tbs2910 (imx6q + >> atheros PHY). >> Unfortunately ethernet is broken now, while it used to work well on >> u-boot versio

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Fabio Estevam
Hi Soeren, On Wed, Jun 24, 2020 at 4:20 PM Soeren Moch wrote: > I tested current master (v2020.07-rc5 + imx fixes) on tbs2910 (imx6q + > atheros PHY). > Unfortunately ethernet is broken now, while it used to work well on > u-boot version v2020.04. Ethernet support was copied from imx6q-sabresd,

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-24 Thread Soeren Moch
On 20.06.20 04:14, Fabio Estevam wrote: > Hi Tom, > > On Thu, Jun 18, 2020 at 10:39 AM Tom Rini wrote: > >> It's a good question what else doesn't work. What has been actively >> verified at this point? > > After the fixes I sent yesterday, the few imx boards I have access at > the moment have Et

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-19 Thread Fabio Estevam
Hi Tom, On Thu, Jun 18, 2020 at 10:39 AM Tom Rini wrote: > It's a good question what else doesn't work. What has been actively > verified at this point? After the fixes I sent yesterday, the few imx boards I have access at the moment have Ethernet working well.

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-18 Thread Tom Rini
On Wed, Jun 17, 2020 at 09:41:17PM -0300, Fabio Estevam wrote: > On Wed, Jun 17, 2020 at 6:30 PM Tom Rini wrote: > > > I'll test that out tomorrow. But my question now is, what do you want > > to do about the various platforms where ethernet isn't working? > > I fixed the mx6sabresd Ethernet re

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
Hi Tom, On Wed, Jun 17, 2020 at 6:28 PM Fabio Estevam wrote: > > Hi Tom, > > On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > > > Based on your follow-up patches, I think you'll be unsurprised it > > doesn't work. I get: > > Net: Could not get PHY for FEC0: addr 0 > > Now I understand why th

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
On Wed, Jun 17, 2020 at 6:30 PM Tom Rini wrote: > I'll test that out tomorrow. But my question now is, what do you want > to do about the various platforms where ethernet isn't working? I fixed the mx6sabresd Ethernet regression today and I can also try to convert other imx platforms from rgmii

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 06:28:37PM -0300, Fabio Estevam wrote: > Hi Tom, > > On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > > > Based on your follow-up patches, I think you'll be unsurprised it > > doesn't work. I get: > > Net: Could not get PHY for FEC0: addr 0 > > Now I understand why t

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
Hi Tom, On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > Based on your follow-up patches, I think you'll be unsurprised it > doesn't work. I get: > Net: Could not get PHY for FEC0: addr 0 Now I understand why the PHY could not be found with the patches I sent. On mx6cubox the AR8035 is clo

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 04:18:27PM -0300, Fabio Estevam wrote: > On Wed, Jun 17, 2020 at 4:09 PM Fabio Estevam wrote: > > > Does it still probe if you remove the PHY reset from the board code? > > Another suggestion: please use the ar8031_phy_fixup() and > board_phy_config() from mx6sabresd into

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 04:09:19PM -0300, Fabio Estevam wrote: > On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > > > +#ifdef CONFIG_FEC_MXC > > +static int setup_fec(void) > > +{ > > + struct iomuxc *const iomuxc_regs = (struct iomuxc > > *)IOMUXC_BASE_ADDR; > > + struct gpio_desc

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
On Wed, Jun 17, 2020 at 4:09 PM Fabio Estevam wrote: > Does it still probe if you remove the PHY reset from the board code? Another suggestion: please use the ar8031_phy_fixup() and board_phy_config() from mx6sabresd into cubox board file to see if Ethernet works.

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > +#ifdef CONFIG_FEC_MXC > +static int setup_fec(void) > +{ > + struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR; > + struct gpio_desc desc; > + > + int ret = enable_fec_anatop_clock(0, ENET_25MHZ); > + if

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 09:04:44AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Tue, Jun 16, 2020 at 7:30 PM Tom Rini wrote: > > > Yeah, OK, I got far enough on trying to convert this that I see I don't > > quite have time to pick it up and run with it. It looks like there's > > going to be som

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
On Wed, Jun 17, 2020 at 10:23 AM Tom Rini wrote: > You probably need 5f09f9af3cc335fe6a74c031cfa0b1d8bdf4b9db applied when > you see that failure, or a smaller make -j number. Ok, I fixed the issue for mx6sabresd. It was dts problem. I will send the patch.

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 10:06:25AM -0300, Fabio Estevam wrote: > On Wed, Jun 17, 2020 at 9:04 AM Fabio Estevam wrote: > > > > Hi Tom, > > > > On Tue, Jun 16, 2020 at 7:30 PM Tom Rini wrote: > > > > > Yeah, OK, I got far enough on trying to convert this that I see I don't > > > quite have time to

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
On Wed, Jun 17, 2020 at 9:04 AM Fabio Estevam wrote: > > Hi Tom, > > On Tue, Jun 16, 2020 at 7:30 PM Tom Rini wrote: > > > Yeah, OK, I got far enough on trying to convert this that I see I don't > > quite have time to pick it up and run with it. It looks like there's > > going to be some extra f

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Fabio Estevam
Hi Tom, On Tue, Jun 16, 2020 at 7:30 PM Tom Rini wrote: > Yeah, OK, I got far enough on trying to convert this that I see I don't > quite have time to pick it up and run with it. It looks like there's > going to be some extra fun around resetting the PHY perhaps? My quick > pass got things see

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-17 Thread Michael Walle
Am 2020-06-16 23:57, schrieb Vladimir Oltean: On Wed, 17 Jun 2020 at 00:35, Tom Rini wrote: On Tue, Jun 16, 2020 at 11:37:17PM +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 23:31, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 11:21:08PM +0300, Vladimir Oltean wrote: > > > On Tue, 1

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 06:01:24PM -0300, Fabio Estevam wrote: > On Tue, Jun 16, 2020 at 5:58 PM Tom Rini wrote: > > > I'm looking at the conversion now, thanks. > > When doing the DM_ETH conversion, this kernel commit may also help as > 'qca,clk-out-frequency' is also supported in U-Boot: > >

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 00:35, Tom Rini wrote: > > On Tue, Jun 16, 2020 at 11:37:17PM +0300, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 23:31, Tom Rini wrote: > > > > > > On Tue, Jun 16, 2020 at 11:21:08PM +0300, Vladimir Oltean wrote: > > > > On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote:

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Wed, Jun 17, 2020 at 12:01:39AM +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > > > > > Ah. So this is probably why the DT being rig

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 00:57, Tom Rini wrote: > > On Wed, Jun 17, 2020 at 12:04:16AM +0300, Vladimir Oltean wrote: > > On Wed, 17 Jun 2020 at 00:01, Vladimir Oltean wrote: > > > > > > On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > > > > > > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Es

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Wed, Jun 17, 2020 at 12:04:16AM +0300, Vladimir Oltean wrote: > On Wed, 17 Jun 2020 at 00:01, Vladimir Oltean wrote: > > > > On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > > > > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > > > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 11:30:00PM +0200, Michael Walle wrote: > Am 16. Juni 2020 22:21:08 MESZ schrieb Vladimir Oltean : > >On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: > >> > >> On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: > >> > Hi Tom, > >> > > >> > On Tue, 16 Jun 2020 at

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 11:37:17PM +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 23:31, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 11:21:08PM +0300, Vladimir Oltean wrote: > > > On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: > > > > > > > > On Tue, Jun 16, 2020 at 10:58:26PM +0300, V

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Michael Walle
Am 16. Juni 2020 22:21:08 MESZ schrieb Vladimir Oltean : >On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: >> >> On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: >> > Hi Tom, >> > >> > On Tue, 16 Jun 2020 at 22:55, Tom Rini wrote: >> > > >> > > Hey all, >> > > >> > > In commit 4346df

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 00:01, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > > > > > Ah. So this is probably why the DT being right isn't

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > > > Ah. So this is probably why the DT being right isn't helping then. If > > > you want to blind-convert I'm happy to test,

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Fabio Estevam
On Tue, Jun 16, 2020 at 5:58 PM Tom Rini wrote: > I'm looking at the conversion now, thanks. When doing the DM_ETH conversion, this kernel commit may also help as 'qca,clk-out-frequency' is also supported in U-Boot: commit 86b08bd5b99480b79a25343f24c1b8c4ddcb5c09 Author: Russell King Date: W

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > Ah. So this is probably why the DT being right isn't helping then. If > > you want to blind-convert I'm happy to test, otherwise do you have a > > similar board conversion for

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Fabio Estevam
On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > Ah. So this is probably why the DT being right isn't helping then. If > you want to blind-convert I'm happy to test, otherwise do you have a > similar board conversion for me to look at? Thanks! Please try Vladimir's suggestion as it seems to

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 05:42:34PM -0300, Fabio Estevam wrote: > Hi Tom, > > On Tue, Jun 16, 2020 at 4:55 PM Tom Rini wrote: > > > > Hey all, > > > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > > configurable for AR8035") we brought in changes to get in to line with > >

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Tue, 16 Jun 2020 at 23:43, Fabio Estevam wrote: > > Hi Tom, > > On Tue, Jun 16, 2020 at 4:55 PM Tom Rini wrote: > > > > Hey all, > > > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > > configurable for AR8035") we brought in changes to get in to line with > > upstream

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Fabio Estevam
Hi Tom, On Tue, Jun 16, 2020 at 4:55 PM Tom Rini wrote: > > Hey all, > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > configurable for AR8035") we brought in changes to get in to line with > upstream linux kernel support for this PHY and in turn deal with more > "driver

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Tue, 16 Jun 2020 at 23:31, Tom Rini wrote: > > On Tue, Jun 16, 2020 at 11:21:08PM +0300, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: > > > > > > On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: > > > > Hi Tom, > > > > > > > > On Tue, 16 Jun 2020 at

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 11:21:08PM +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: > > > Hi Tom, > > > > > > On Tue, 16 Jun 2020 at 22:55, Tom Rini wrote: > > > > > > > > Hey all, > > > > > > >

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
On Tue, 16 Jun 2020 at 23:10, Tom Rini wrote: > > On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: > > Hi Tom, > > > > On Tue, 16 Jun 2020 at 22:55, Tom Rini wrote: > > > > > > Hey all, > > > > > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > > > configur

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Tom Rini
On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote: > Hi Tom, > > On Tue, 16 Jun 2020 at 22:55, Tom Rini wrote: > > > > Hey all, > > > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > > configurable for AR8035") we brought in changes to get in to line with > >

Re: U-Boot atheros PHY support and cubox ethernet

2020-06-16 Thread Vladimir Oltean
Hi Tom, On Tue, 16 Jun 2020 at 22:55, Tom Rini wrote: > > Hey all, > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually > configurable for AR8035") we brought in changes to get in to line with > upstream linux kernel support for this PHY and in turn deal with more > "driver wa