,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Q: Why do PCs have a reset button on the front?
A: Because
-Transfer-Encoding: quoted-printable
And please don't post HTML here!
BTW: nice to hear from you again after a long time!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone
few
weeks, so I think we should keep the merge window open for another
week, i. e. until June 10.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989
).
Actually it is pretty foul game to try and make me pull in stuff
which I explicitely rejected.
please refrain from such irrelevant comments
Please don't try to make me pull rejected code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev
In message [EMAIL PROTECTED] you wrote:
The following changes since commit 1f1554841a4c8e069d331176f0c3059fb2bb8280:
Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git
*/)
+ syscontrol(SYSCTRL_SOFTRESET, NULL, NULL);
+ else
+ asm(jump (%0); : : a (bfin_reset));
}
Your comment suggests you change something, but actually you;re just
adding dead code.
Rejected.
Best regards,
Wolfgang Denk
--
DENX Software
-09-06
+ * New release for AX88180 US2 chip.
Also, this is old stuff. Why did you not base your work on more
recent code (like version 1.0.1 , 2006-06-14) ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
();
Please do not declare variables in the middle of the code. We do not
accept such a style in U-Boot.
Please fix and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell
be changed into functions.
Stopped reviewing here.
Please fix and resubmit - as is, this code has no chance to go into
mainline.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Register 0 */
+#define bfin_read_MXVR_INT_STAT_0()bfin_read32(MXVR_INT_STAT_0)
I do not think that we should allow such code in U-Boot.
I do not want to see this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
(256 * 1024)/* Reserve 256 kB for
monitor */
+#define CFG_MALLOC_LEN (384 * 1024)/* Reserve 384 kB for
malloc() (video/spi are big) */
etc. Many lines are much too long...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev
.
*
* (C) Copyright 2000-2004
* Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
*
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU
Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
GUIs are virtually useless. Learn tools. They're configurable
.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
How can you tell when sour cream goes bad
of sane defaults. the bitmask EBSZ_# would not be usable.
many... large number... well:
$ find * -type f | xargs egrep CONFIG_MEM_SIZE | wc -l
17
Sounds not *that* big a number to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235
a correct value for
the ethaddr variable in your environment and save that.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80
then have to carry this patch somewhere it can got lost
and i need to waste time and rewrite it.
I don't want to add such dead code. Please resubmit when it is really
used.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich
normally do.
However here I'm really uncertain. Actually I am deeply disappointed
that such code made it into the Linux kernel. This should have never
happened.
Anybody else cares to comment what we should do?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk
not
revert this reject, and I do not revert it now.
Actually it is pretty foul game to try and make me pull in stuff
which I explicitely rejected.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D
.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Nail here --X-- for new monitor
Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The day-to-day travails of the IBM programmer are so amusing to most
In message [EMAIL PROTECTED] you wrote:
+ /* momorize fpga status */
momorize ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49
*/
+ gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
Description and patch don't match. Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10
.
--_=_NextPart_001_01C8C2A8.E5EB52D1
Content-Type: text/html;
charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
And stop posting HTML.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D
ELDK 4.1
Just tried to build a few boards on a FC5 host. A few warnings about
including /usr/include/asm/byteorder.h, but it builds fine.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
In message [EMAIL PROTECTED] you wrote:
Wolfgang Denk wrote:
Signed-off-by: Sergei Poselenov [EMAIL PROTECTED]
---
board/socrates/socrates.c | 13 +++--
include/configs/socrates.h |3 ++-
2 files changed, 13 insertions(+), 3 deletions(-)
Better subject line, please
In message [EMAIL PROTECTED] you wrote:
Wolfgang Denk wrote:
Be careful - keep in mind that variables in the data segment will be
read-only before relocation to RAM, and variables in BSS will be
uninitialized *and* get overwritten with zero when the BSS gets
initialized
, should have postphone submission for the review.
Please ignore this patch. I'll drop this patch from my queue.
...
How much memory footprint does this code add?
OK, but please be prepared that I will repeat these two questions,
then :-)
Best regards,
Wolfgang Denk
--
DENX Software
regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
I think it's a new feature. Don't tell anyone
In message [EMAIL PROTECTED] you wrote:
Wolfgang Denk wrote:
In message [EMAIL PROTECTED] you wrote:
Adjust to the current Linux way.
Signed-off-by: Shinya Kuribayashi [EMAIL PROTECTED]
...
-#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
+#define CONFIG_CPU_MIPS32_R1
we keep the bigger
picture in mind.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Even if you
.
Be careful - keep in mind that variables in the data segment will be
read-only before relocation to RAM, and variables in BSS will be
uninitialized *and* get overwritten with zero when the BSS gets
initialized.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD
is this file released under?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A star captain's most
750 lines of code - for which benefit
exactly?
How much memory footprint does this code add?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax
this changes.
We're adding a lot of fine ganularity here, and we pay for this with
added memory footprint - but I fail to see any significant benefits
from this.
What exactly is the reason for all these changes? Which problem are
you trying to fix?
Best regards,
Wolfgang Denk
--
DENX Software
have to break compatibility here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Men will always
-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
And please don't post HTML.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
(hm, if my interpretation is right, we were to report the
incidents to his management, but I'm afraid I don't have enough
time...).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
.
The text reads: IT IS STRICTLY FORBIDDEN TO *ANYONE* TO TAKE
COGNIZANCE...
In legal speak, anyone really means anyone, including the
indicated recipients.
Yes, we agree that this is plain stupid, but that's what it says.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD
regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
It is not best to swap horses while crossing the river
.
--=_Part_9191_25451952.1211573000914
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Please stop posting HTML.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich
request soon :-) And please also fix the subject.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL
\
+ setenv setboot setenv bootargs \\$(bootargs);run setboot
Do not use the old $(...) syntax any more, it is deprecated. Please
use ${...} instead.
Also, this statement is nonsense, as you don't do anything there that
has any effect.
Best regards,
Wolfgang Denk
--
DENX
subpackages.
So on Fedora, yum install git should do the trick.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email
setboot;run setboot
That's even worse. The first part (setenv setboot will delete the
setboot variable, so the second part (run setboot) will always
just raise an error message.
Please review what exactly you are tyring to do here...
Best regards,
Wolfgang Denk
--
DENX Software Engineering
please
tell me how to do it.
Well, if you don't need a specific boot command, then just do not
define CONFIG_BOOTCOMMAND at all.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
.
Is there any specific guidance on this?
As a rule of thumb I'd say if you added or modified more than 10
lines of code, and/or if you implemented a significant conceptual
change, you should add your own copyright notice.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH
, we
will adjust it then...
Please fix (add) the copyright now, i. e. in the version of the patch
that gets accepted.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone
been pushed (or accepted) upstream yet, but it
should not be much, and not for long any more.
--0-1969350365-1211490580=:25202
Content-Type: text/html; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Please never post HTML on this list.
Best regards,
Wolfgang Denk
--
DENX Software
to adapt board/freescale/mercury/Makefile to your new
board. Are you sure this is indeed a Freescale board? If not, then
why is it located in the Freescale vendor directory?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich
the white-space cleanup patches as far as /npe/ code is
affected.
Short discussion on IRC showed preference for 1).
If you agree, that's what we'll do.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D
procedure and spin another
patch?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Do you suppose
,
board/purple/purple.c, L39,
board/purple/purple.c, L50-54, Hmm. Special case?
thanks. Fixed manually in a separate commit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
;
charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Please don't post HTML here!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49
regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Q: How do you spell onomatopoeia?
A: The way it sounds
In message [EMAIL PROTECTED] you wrote:
Sorry, I forgot this line:
Signed-off-by: Christian Eggers [EMAIL PROTECTED]
Dear Markus,
I've made I new patch with git as requested.
Line-wrapped again.
Please fix your mailer before you post more patches.
Best regards,
Wolfgang Denk
((CFG_OCM_DATA_ADDR) + (CFG_POST_WORD_ADDR))
+#elif defined(CFG_POST_ALT_WORD_ADDR)
+# define _POST_ADDR CFG_POST_ALT_WORD_ADDR
# define _POST_ADDR (CFG_POST_ALT_WORD_ADDR)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235
.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
I express preference for a chronological
there
are no wrapped lines anymore.
Yes, it helped, this time. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL
From: Sergei Poselenov [EMAIL PROTECTED]
Add new configuration variable CONFIG_PCI_OHCI_DEVNO.
In case of several PCI USB controllers on a board this variable
specifys which controller to use.
See doc/README.generic_usb_ohci for details.
Signed-off-by: Sergei Poselenov [EMAIL PROTECTED]
---
is not really an issue in almost all cases.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A witty
to register custom interrupt handlers.
It's just just most U-Boot drivers do not use interrupts but polling
mode - note that there are exceptions from this rule, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
is strictly single-tasking.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Wherever you go...There you
,
^^
+ USB_HUB_PRINTF(usb_hub_configure: failed to get hub descriptor
- too
long: %d\n,
^^
Please fix your mailer to not wrap lines!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
In message [EMAIL PROTECTED] you wrote:
Remove gaps and whitespaces in README file
Rejected. You corrupt the nice alignment which IMHO makes the code
more readable.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich
In message [EMAIL PROTECTED] you wrote:
What could you prevent from using git? I cannot imagine...
Even i dont know y and i am trying to convince them.
I mean: what prevents you from installing it locally in your $HOME
dir?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH
you return from a
normal function call.
delivery? I mean who is taking care of context switch at the time of
interrupts?
There is no such thing as a context switch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office
tick timer that
forms the MIPS time base wraps to 0 after 14.316 seconds.
That's a bug in the MIPS implementation, then.
Well, then we've got a big problem on MIPS.
A fixable one, I hope.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
vector code jumps to _start (or
_start_440 in my case), and then step through _start afterwards.
Probably your BDI config file needs adjusting. Try what you see when
you use the telnet interface directly, i. e. where do you end up
after a reset halt ?
Best regards,
Wolfgang Denk
--
DENX
, and if there are any, they should be straightforward to
resolve. And they are definitely easier for you to resolve who knows
the patches you are wokring on than for me. Also, I would like to
spread the load of this work a bit.
That's why I want to push this first.
Best regards,
Wolfgang Denk
/tmp/big-white-space-cleanup.patch-v.2.gz
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Ernest
up
after a reset halt ?
Best regards,
...
Please don't top-post / full-quote!
--_a74128a5-4aff-492d-8a22-57e20feb9b73_
Content-Type: text/html; charsetÿindows-1252
Content-Transfer-Encoding: quoted-printable
And please do NOT post HTML here.
Best regards,
Wolfgang Denk
--
DENX
://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.3.gz
All good things come in threes :-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49
)) (a) - 1)
Actually that should be
... __ALIGN_MASK((x), (typeof(x)) (a) - 1)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142
In message [EMAIL PROTECTED] you wrote:
+ for (i=0; i rgn-cnt; i++) {
please i = 0
Andy, please leave as it was.
Jean-Christophe - this is really nitpicking, and in my opinion your
version is more difficult to read.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH
Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Death. Destruction. Disease. Horror. That's what war is all about.
That's
indentation problems.
Signed-off-by: Wolfgang Denk [EMAIL PROTECTED]
The latest version of this patch is available for download here:
ftp://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.3.gz
I also checked in this patch in the master branch of the
u-boot-testing repository, so you can just pull
+++--
3 files changed, 506 insertions(+), 457 deletions(-)
Sorry, this patch fails bacause of (expected, and announced) conflicts
with the Big white-space cleanup patch.
Please rebase.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang
In message [EMAIL PROTECTED] you wrote:
The following changes since commit a38dc3ea8614f8b0c41e432b445a9959b9711295:
Wolfgang Denk (1):
TQM8272: fix out-of-tree building
are available in the git repository at:
git://www.denx.de/git/u-boot-ppc4xx.git master
Stefan Roese (1
124903)
Developers with the most changesets
Marian Balakowicz 68 (9.5%)
Wolfgang Denk 63 (8.8%)
Stefan Roese63 (8.8%)
Kumar Gala 35 (4.9%)
Jean-Christophe PLAGNIOL-VILLARD 28 (3.9%)
Yuri Tikhonov 27 (3.8%)
Mike Frysinger
range'. Please consider it a constant with the value 1000.
Nonconforming ports should be fixed instead of adding code that
supports this brokenness.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
-bit timestamps)...
Not needed. CFG_HZ == 1000 for all sane ports.
Broken ports should be fixed.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax
In message [EMAIL PROTECTED] you wrote:
Broken ports should be fixed.
Maybe we should define it in a non-board-specific header, so as to make
the intent clear that it not actually be configurable?
Good idea. But the change fill break some 100 boards.
Best regards,
Wolfgang Denk
review it all and signal any problem. Not to mention
aesthetics.
If possible, we *want* the preprocessor to remove any code that does
not apply for a specific configuration. Generating code just bloats
the memory footprint.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD
requested.
...
That seems reasonable. Wolfgang, if you agree, please pull York's patch
directly.
Sorry, I missed this one.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
| 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
Applied.
Please keep the review comments in mind, and send a follow-up patch
ASAP.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr
In message [EMAIL PROTECTED] you wrote:
+ if (rc)
+ printf(Unable to update property status in PCIe node,
err=%s\n,
+fdt_strerror(rc));
Multiline statements definitely need curly braces.
Best regards,
Wolfgang Denk
--
DENX
/sbc8560.c
board/stxgp3/stxgp3.c
board/tqm85xx/sdram.c
board/xilinx/ml300/ml300.c
board/xpedite1k/xpedite1k.c
board/stxssa/stxssa.c
board/zeus/zeus.c
board/atum8548/atum8548.c
board/sbc8548/sbc8548.c
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev
In message [EMAIL PROTECTED] you wrote:
The following changes since commit a38dc3ea8614f8b0c41e432b445a9959b9711295:
Wolfgang Denk (1):
TQM8272: fix out-of-tree building
are available in the git repository at:
git://www.denx.de/git/u-boot-ppc4xx.git master
Stefan Roese (1
in the repository. Therefor a useful
subject line is absolutely mandatory.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989
given why these boards should not
be able to use DC as initial RAM?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email
In message [EMAIL PROTECTED]@transmode.se you wrote:
+ return (void *)ret;
return dst;
Right. Thanks for catching.
Unapplied.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
In message [EMAIL PROTECTED] you wrote:
+ if (rc)
+ printf(Unable to update property status in PCIe node,
err=%s\n,
+fdt_strerror(rc));
This if needs curly braces.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH
,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The IQ of the group is the lowest IQ of a member of the group divided
*)src);
into
*dst++ = *((char *)src);
and leave all the rest.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80
In message [EMAIL PROTECTED] you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
examples/.gitignore |4
1 files changed, 4 insertions(+), 0 deletions(-)
Applied. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang
regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Inside every old person is a young person wondering
In message [EMAIL PROTECTED] you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
lib_i386/bootm.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk
-1307 USA
+ */
Copyright entry missing.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED
In message [EMAIL PROTECTED] you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
drivers/pcmcia/Makefile |1 +
drivers/pcmcia/i82365.c |4
2 files changed, 1 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX
501 - 600 of 1438 matches
Mail list logo