Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi, all I’m +1 to support HBase 2.x and also keep the HBase1.x in flink project. IIRC, HBase1.x is still widely used in production in the early discussion of this thread according to HBase PMC memeber Yu Li and OpenInx’s investigation. Moving HBase1.x connector to Bahir means the HBase1.x con

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi All, I am also fairly torn on this one, however unless we are vigilant in keeping the flink repository relatively lean the number of modules will just keep increasing and pose an increasingly greater maintainability challenge. Less frequently used connectors are a strong candidate to be maintai

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

@Jark: Thanks for bringing up these concerns. All the problems you've mentioned are "solvable": - uber jar: Bahir could provide a hbase1 uber jar (we could theoretically also add a dependency from flink to bahir and provide the uber jar from Flink) - e2e tests: we know that the connector is stable,

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi all! Im new here; I have been using the flink connector for hbase 1.2, but recently opt to upgrading to hbase 2.1(basically because was bundled in CDH6) it would be nice to add support for hbase 2.x! I found that supporting hbase 1.4.3 and 2.1 needs minimal changes and keeping that in mind

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

I'm +1 to add HBase 2.x However, I have some concerns about moving HBase 1.x to Bahir: 1) As discussed above, there are still lots of people using HBase 1.x. 2) Bahir doesn't have the infrastructure to run the existing HBase E2E tests. 3) We also paid lots of effort to provide an uber connector ja

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi, Thank you for picking this up so quickly. I have no objections regarding all the proposed items. @Gyula: Once the bahir contribution is properly reviewed, ping me if you need somebody to merge it. On Fri, Aug 7, 2020 at 10:43 AM Márton Balassi wrote: > Hi Robert and Gyula, > > Thanks for r

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi Robert and Gyula, Thanks for reviving this thread. We have the implementation (currently for 2.2.3) and it is straightforward to contribute it back. Miklos (ccd) has recently written a readme for said version, he would be interested in contributing the upgraded connector back. The latest HBase

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi Robert, I completely agree with you on the Bahir based approach. I am happy to help with the contribution on the bahir side, with thorough review and testing. Cheers, Gyula On Fri, 7 Aug 2020 at 09:30, Robert Metzger wrote: > It seems that this thead is not on dev@ anymore. Adding it back

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

It seems that this thead is not on dev@ anymore. Adding it back ... On Fri, Aug 7, 2020 at 9:23 AM Robert Metzger wrote: > I would like to revive this discussion. There's a new JIRA[1] + PR[2] for > adding HBase 2 support. > > it seems that there is demand for a HBase 2 connector, and consensus

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

I would like to revive this discussion. There's a new JIRA[1] + PR[2] for adding HBase 2 support. it seems that there is demand for a HBase 2 connector, and consensus to do it. The remaining question in this thread seems to be the "how". I would propose to go the other way around as Gyula suggest

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

If we were to go the bahir route, I don't see the point in migrating the 1.4.x version there since that's already available in Flink. To me that is almost the same as dropping explicit support for 1.4 and telling users to use older connector versions if they wish to keep using it. If we want to ke

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

If we support both HBase 1 and 2, maybe it's a good time to pull them out to Bahir and list them in flink-packages to avoid adding even more modules to Flink core? On Mon, Jun 22, 2020 at 4:05 AM OpenInx wrote: > Hi > > According to my observation in the hbase community, there are still lots > o

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi According to my observation in the hbase community, there are still lots of hbase users running their production cluster with version 1.x (1.4x or 1.5.x). so I'd like to suggest that supporting both hbase1.x & hbase2.x connector. Thanks. On Sat, Jun 20, 2020 at 2:41 PM Ming Li wrote: > +1 t

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+1 to support both HBase 2.x and Hbase 1.4.x, just as what we are doing for Kafka. On Fri, Jun 19, 2020 at 4:02 PM Yu Li wrote: > One supplement: > > I noticed that there are discussions in HBase ML this March about removing > stable-1 pointer and got consensus [1], and will follow up in HBase

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

One supplement: I noticed that there are discussions in HBase ML this March about removing stable-1 pointer and got consensus [1], and will follow up in HBase community about why we didn't take real action. However, this doesn't change my previous statement / stand due to the number of 1.x usages

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+1 on upgrading the HBase version of the connector, and 1.4.3 is indeed an old version. OTOH, AFAIK there're still quite some 1.x HBase clusters in production. We could also see that the HBase community is still maintaining 1.x release lines (with "stable-1 release" point to 1.4.13) [1] Please al

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+1 to support HBase 2.2.x, and +1 to retain HBase 1.4.3 until we deprecates finished(maybe one version is enough). Currently we only support HBase 1.4.3 which is pretty old, and I’m making a flink-sql-connector-hbase[1] shaded jar for pure SQL user, the dependencies is a little more complex.

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

cc'ed YuLi and ZhengHu who are HBase PMC members and may know how many users are using HBase 1.4.x and 2.2.x Best, Jark On Fri, 19 Jun 2020 at 14:20, jackylau wrote: > + 1 to support HBase 2.x and the hbase 2.x client dependencies are simple > and clear. Tbe hbase project shades them all > > Ja

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+ 1 to support HBase 2.xand the hbase 2.x client dependencies are simple and clear. Tbe hbase project shades them all Jark Wu-3 wrote > +1 to support HBase 2.xBut not sure about dropping support for 1.4.xI > cc'ed to user@ and user-zh@ to hear more feedback from users.Best,JarkOn > Thu, 18 Jun 2020

Re: Re: [DISCUSS] Upgrade HBase connector to 2.2.x

Hi! Having both 1.4.x and 2.x supported means we need different modules or some shim logic as they are not compatible with each other. I would love to avoid this if possible because it is a lot of extra effort from a maintainability perspective. It would be great to see how many users still use H

Re:Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+1 to support HBase 2.x And I think the 1.4.x version can be retained for the time being, so that users who are currently using the 1.4.x version can have more time to evaluate whether their projects need to be upgraded and the cost of upgrading. At 2020-06-19 12:35:36, "Jark Wu"

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

+1 to support HBase 2.x But not sure about dropping support for 1.4.x I cc'ed to user@ and user-zh@ to hear more feedback from users. Best, Jark On Thu, 18 Jun 2020 at 21:25, Gyula Fóra wrote: > Hi All! > > I would like to revive an old ticket >