Dear all,
I submitted "Bug 55893 - Split AccessLogValve and extract the
formatting logic in an AbstractAccessLogValve".
If this split is accepted, I will then propose a SyslogAccessLogValve.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893
Cyrille
On Thu, Dec 12, 2013 at 5:41 PM, Cyril
Hi Christopher,
Changing the existing AccessLogValve to use a logger would have an impact
on performances with the creation of intermediate String objects and
keeping backward compatibility on the access logs files management (naming,
rotation, ...) with a new "LogFactory.getLogger()" approach wou
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Cyrille,
On 12/12/13, 3:56 AM, Cyrille Le Clerc wrote:
> Hello Christopher,
>
> Delegating to log4j/logback/java.util.logging could be an option
> but it would still greatly benefit of a refactoring to split the
> existing AccessLogValve into an Ab
Thanks for your support Brian :-)
Regarding the performances, I'm sure that a native
SyslogAccessLogValve will have much better performances than relying
on a logging framework:
* there will be less layers to go through
* we can eliminate any String or byte[] creation which to lower the
pressure o
On 12/12/13 08:56, Cyrille Le Clerc wrote:
Hello Christopher,
Delegating to log4j/logback/java.util.logging could be an option but it
would still greatly benefit of a refactoring to split the existing
AccessLogValve into an AbstractAccessLogValve with the formatting logic and
an AccessLogValve t
Hello Christopher,
Delegating to log4j/logback/java.util.logging could be an option but it
would still greatly benefit of a refactoring to split the existing
AccessLogValve into an AbstractAccessLogValve with the formatting logic and
an AccessLogValve that would keep the logic to write in the file
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Cyrille,
On 12/11/13, 1:49 PM, Cyrille Le Clerc wrote:
> Dear Tomcat community,
>
> We at CloudBees implemented a SyslogAccessLogValve that outputs
> the access logs to a syslog server.
>
> The support of Syslog is more detailed that what we can u
Dear Tomcat community,
We at CloudBees implemented a SyslogAccessLogValve that outputs the
access logs to a syslog server.
The support of Syslog is more detailed that what we can usually find
in java logging libraries as it allows to
* configure all the syslog header fields: appName, source hostn