Revision: 2735
Author: sgje...@chromium.org
Date: Thu Aug 20 23:30:59 2009
Log: Fix an ASSERT in the scanner.
The assert when performing a push back on a two byte string was wrong.
Added a small regression test.
Review URL: http://codereview.chromium.org/173116
http://code.google.com/p/v8/source
http://codereview.chromium.org/173116/diff/1/4
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/173116/diff/1/4#newcode7159
Line 7159: const char *ascii_sources[] = {
On 2009/08/20 11:33:09, Kasper Lund wrote:
> const char * -> const char*
Done.
http://codereview.chromium.o
http://codereview.chromium.org/174141/diff/1002/12
File src/global-handles.cc (right):
http://codereview.chromium.org/174141/diff/1002/12#newcode279
Line 279: int time_stamp = 0;
On 2009/08/21 05:58:16, Mads Ager wrote:
> You could expose Heap::mc_count() instead of introducing a new
variable fo
LGTM.
http://codereview.chromium.org/174141/diff/1002/12
File src/global-handles.cc (right):
http://codereview.chromium.org/174141/diff/1002/12#newcode279
Line 279: int time_stamp = 0;
You could expose Heap::mc_count() instead of introducing a new variable
for this.
http://codereview.chromium.
Revision: 2734
Author: m...@chromium.org
Date: Thu Aug 20 12:12:59 2009
Log: Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release
mode.
-fstrict-aliasing is enabled by mainline gcc at -O2 and higher, but in Apple
gcc, it must be enabled explicitly. This results in a 1.5% impro
LGTM.
http://codereview.chromium.org/174154
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Kasper Lund,
Description:
Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release
mode.
-fstrict-aliasing is enabled by mainline gcc at -O2 and higher, but in
Apple
gcc, it must be enabled explicitly. This results in a 1.5% improvement
in V8
benchmark scores.
This also
Hi Kevin,
On Thu, Aug 20, 2009 at 8:28 PM, Kevin C wrote:
> Do the V8 team have any ideas re:
> - is the jsonML format V8 AST specific or can it be generic
It is literally the V8 AST, so there are some V8-specific things in there.
(We also rewrite some of the AST at parse time, so it doesn't
The idea of prototyping a 'standard' AST format in JSON was discussed
at es-discuss:
https://mail.mozilla.org/pipermail/es-discuss/2009-May/009231.html
And jsonML was suggested. A sample:
["||",
["||",
["Id", "X"],
["Id", "Y"]],
["Id", "Z"]]
I was about to start hacking V8
On Aug 20, 8:12 pm, Kasper Lund wrote:
> You should be able to use the tools/test.py script. Let me know if you
> need more information.
step...@jareth:~/src/google/v8$ ./tools/test.py
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
g++ -o ob
On Thu, Aug 20, 2009 at 8:01 PM, Stephan Beal wrote:
> Hi, all!
>
> i'm REALLY interested in taking a dive into threading with v8, in the
> hopes of implementing something like setTimeout() (and eventually
> XMLHttpRequest, though i find it severely odd that the capitalize XML
> but not HTTP). A d
Hi, all!
i'm REALLY interested in taking a dive into threading with v8, in the
hopes of implementing something like setTimeout() (and eventually
XMLHttpRequest, though i find it severely odd that the capitalize XML
but not HTTP). A day or two ago someone mentioned (on this list)
threading tests i
http://codereview.chromium.org/173016
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2733
Author: m...@chromium.org
Date: Thu Aug 20 07:48:52 2009
Log: Don't use -fomit-frame-pointer to build Mac V8. The Chrome crash
reporting
system can't currently process stacks produced by gcc -fomit-frame-pointer
properly. The drawback outweighs the 2% performance improvement. O
kasp...@chromium.org wrote:
> LGTM. Do we have feature request for the crash reporting system to be
> able to handle this? If so, maybe we should add a note there about this
> issue.
There isn't a tracker, but a Breakpad contributor from Mozilla is
currently working on it. Since they share the s
LGTM. Do we have feature request for the crash reporting system to be
able to handle this? If so, maybe we should add a note there about this
issue.
http://codereview.chromium.org/173123
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
Reviewers: Kasper Lund,
Description:
Don't use -fomit-frame-pointer to build Mac V8. The Chrome crash
reporting
system can't currently process stacks produced by gcc
-fomit-frame-pointer
properly. The drawback outweighs the 2% performance improvement. Once
the crash reporting system is able to
Mads, couple of funny observations.
Actually, in debug mode ASSERT would be triggered if one would trigger
heavyweight GC phase from another heavyweight GC (due to
allow_allocation(false) in GC prologue). Alas, in release mode there
is no checks.
However, as we have this check already, maybe we
Reviewers: Mads Ager,
Description:
Do not finish GlobalHandles::PostGarbageCollectionProcessing if weak
callback
triggered it already (it's not safe).
Please review this at http://codereview.chromium.org/174141
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
Revision: 2732
Author: a...@chromium.org
Date: Thu Aug 20 04:45:18 2009
Log: Fix mozilla test expectations. Generating a huge error message can
not time out of the 64-bit version because of the larger heap.
Review URL: http://codereview.chromium.org/173118
http://code.google.com/p/v8/source/deta
Dong-dong-dynamohest!
http://codereview.chromium.org/173118
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Christian Plesner Hansen,
Description:
Fix mozilla test expectations. Generating a huge error message can
not time out of the 64-bit version because of the larger heap.
Please review this at http://codereview.chromium.org/173118
SVN Base: http://v8.googlecode.com/svn/branches/bleed
Revision: 2731
Author: kasp...@chromium.org
Date: Thu Aug 20 04:37:56 2009
Log: Experimental change to omit frame pointers from V8 on Mac
built through the v8.gyp file. The optimization flags for
Mac and Linux (both gcc-based) builds are now much closer.
Review URL: http://codereview.chromium.org/
LGTM, thanks!
http://codereview.chromium.org/173117
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/173115/diff/1/7
File src/objects-inl.h (right):
http://codereview.chromium.org/173115/diff/1/7#newcode940
Line 940: int map_page_index = static_cast(
How about putting all on the next line - I think that should fit?
int map_page_index =
static_cast((val
LGTM.
http://codereview.chromium.org/173116/diff/1/4
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/173116/diff/1/4#newcode7159
Line 7159: const char *ascii_sources[] = {
const char * -> const char*
http://codereview.chromium.org/173116/diff/1/4#newcode7167
Line 7167: int
Reviewers: Kasper Lund,
Description:
Fix an ASSERT in the scanner.
The assert when performing a push back on a two byte string was wrong.
Added a small regression test.
Please review this at http://codereview.chromium.org/173116
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Reviewers: Mads Ager,
Description:
Experimental change to omit frame pointers from V8 on Mac
built through the v8.gyp file. The optimization flags for
Mac and Linux (both gcc-based) builds are now much closer.
Please review this at http://codereview.chromium.org/173117
SVN Base: http://v8.googl
LGTM
http://codereview.chromium.org/174137
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2730
Author: kasp...@chromium.org
Date: Thu Aug 20 04:13:51 2009
Log: Try compiling V8 for Mac with -O3 when using the v8.gyp file.
Review URL: http://codereview.chromium.org/174138
http://code.google.com/p/v8/source/detail?r=2730
Modified:
/branches/bleeding_edge/tools/gyp/v8.gyp
==
Yes, please!
http://codereview.chromium.org/174138
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Søren Gjesse,
Description:
X64: Set target machine for Visual Studio projects to x64.
Please review this at http://codereview.chromium.org/174137
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/visual_studio/d8_x64.vcproj
M tools/v
Reviewers: Mads Ager,
Description:
Change some integer types to make the x64 Win32 platform happier.
Please review this at http://codereview.chromium.org/173115
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/objects-inl.h
M src/objects.h
M
Reviewers: Mads Ager,
Description:
Try compiling V8 for Mac with -O3 when using the v8.gyp file.
Please review this at http://codereview.chromium.org/174138
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
==
Revision: 2729
Author: a...@chromium.org
Date: Thu Aug 20 03:32:11 2009
Log: Fix a test that test out of memory situations. On the 64-bit port the
test did not actually run out of memory which the test treats as an
error.
Review URL: http://codereview.chromium.org/174136
http://code.google.com/p
Lgtm!
http://codereview.chromium.org/174136
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Christian Plesner Hansen,
Description:
Fix a test that test out of memory situations. On the 64-bit port the
test did not actually run out of memory which the test treats as an
error.
Please review this at http://codereview.chromium.org/174136
SVN Base: http://v8.googlecode.com/svn
Revision: 2728
Author: a...@chromium.org
Date: Thu Aug 20 01:12:30 2009
Log: Go back to doubling the size when growing new space.
Our memory tests show little improvement by only growing by 50%.
Review URL: http://codereview.chromium.org/174133
http://code.google.com/p/v8/source/detail?r=2728
M
LGTM. Beautiful.
http://codereview.chromium.org/174133
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
I committed this, because we really want to see the effect on
performance.
http://codereview.chromium.org/173103
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~
Revision: 2727
Author: whe...@chromium.org
Date: Thu Aug 20 01:08:18 2009
Log: Fix build error
http://code.google.com/p/v8/source/detail?r=2727
Modified:
/branches/bleeding_edge/src/heap.cc
===
--- /branches/bleeding_edge/src/heap.cc Wed Aug 19 17:07:19 2009
Reviewers: Kasper Lund,
Description:
Go back to doubling the size when growing new space.
Our memory tests show little improvement by only growing by 50%.
Please review this at http://codereview.chromium.org/174133
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files
On 2009/08/20 07:20:25, Kasper Lund wrote:
> http://codereview.chromium.org/165448/diff/1/5
> File src/v8.cc (right):
> http://codereview.chromium.org/165448/diff/1/5#newcode158
> Line 158:
> Two newlines between function definitions?
I will fix this one.
http://codereview.chromium.org/165448
Landed in bleeding_edge revision 2726.
http://codereview.chromium.org/174005
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2726
Author: a...@chromium.org
Date: Thu Aug 20 00:41:46 2009
Log: Land patch by a...@chromium.org to hopefully fix build failure on
Ubuntu with GCC 4.4.
Review URL: http://codereview.chromium.org/174005
http://code.google.com/p/v8/source/detail?r=2726
Modified:
/branches/bleeding_e
LGTM
I will land this patch.
http://codereview.chromium.org/174005
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/165448/diff/1/5
File src/v8.cc (right):
http://codereview.chromium.org/165448/diff/1/5#newcode158
Line 158:
Two newlines between function definitions?
http://codereview.chromium.org/165448
--~--~-~--~~~---~--~~
v8-dev mailing list
47 matches
Mail list logo
