Thanks Søren!
2009/11/17 Søren Gjesse
> Mads is not back until Wednesday. I will merge it to the V8 branch for the
> release tomorrow.
>
> /Søren
>
>
> On Mon, Nov 16, 2009 at 20:06, Yury Semikhatsky wrote:
>
>> Mads,
>>
>> Is there any chance we can have this patch in the Chrome release branch
Revision: 3313
Author: fschnei...@chromium.org
Date: Mon Nov 16 15:11:19 2009
Log: Re-enable using push instructions for syncing the virtual frame.
This change fixes the problem with the original version of this approach
(r3032) that may lead to a corrupted stack if we would invoke spilling
dur
http://codereview.chromium.org/391079/diff/2003/3003
File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/391079/diff/2003/3003#newcode474
Line 474: void LoadUnsafeSmi(int offset, Handle value);
On 2009/11/16 22:09:18, Kasper Lund wrote:
> This seems like pretty unfortunate overl
LGTM, but you need to fix that name...
http://codereview.chromium.org/391079/diff/2003/3003
File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/391079/diff/2003/3003#newcode474
Line 474: void LoadUnsafeSmi(int offset, Handle value);
This seems like pretty unfortunate overloadin
Reviewers: Kasper Lund,
Description:
Re-enable using push instructions for syncing the virtual frame.
This change fixes the problem with the original version of this approach
(r3032) that may lead to a corrupted stack if we would invoke spilling
during
syncing a large SMI constant (unsafe SMIs
Revision: 3312
Author: yu...@chromium.org
Date: Mon Nov 16 13:59:31 2009
Log: Step next should respect do/while condition block.
Condition block of do/while statements is a valid break location so it
should have its own position. The block is represented by a regular
Expression node so we can
LGTM
http://codereview.chromium.org/385136
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Mads is not back until Wednesday. I will merge it to the V8 branch for the
release tomorrow.
/Søren
On Mon, Nov 16, 2009 at 20:06, Yury Semikhatsky wrote:
> Mads,
>
> Is there any chance we can have this patch in the Chrome release branch?
>
> Yury
>
> On Mon, Nov 16, 2009 at 10:04 PM, Adam Bar
Reviewers: Søren Gjesse,
Description:
Step next should respect do/while condition block.
Condition block of do/while statements is a valid break location so it
should
have its own position. The block is represented by a regular Expression
node so
we cannot store the position in it, instead th
Status: Assigned
Owner: yu...@chromium.org
CC: sgje...@chromium.org, pfeld...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 514 by yu...@chromium.org: StepNext action skips condition in
do/while statements
http://code.google.com/p/v8/issues/detail?id=514
Consider the following funct
Mads,
Is there any chance we can have this patch in the Chrome release branch?
Yury
On Mon, Nov 16, 2009 at 10:04 PM, Adam Barth wrote:
> Thanks so much. Can you let me know when this is pushed far enough
> that I can land the other patch?
>
> Adam
>
>
> On Monday, November 16, 2009, wrote:
Thanks so much. Can you let me know when this is pushed far enough
that I can land the other patch?
Adam
On Monday, November 16, 2009, wrote:
>
> http://codereview.chromium.org/398002/diff/4002/4003
> File test/cctest/test-debug.cc (right):
>
> http://codereview.chromium.org/398002/diff/4002
Status: New
Owner:
New issue 513 by tombrown52: The TryCatch class captures undesired
exceptions while processing a "finally" block.
http://code.google.com/p/v8/issues/detail?id=513
If code inside a finally block causes a v8::TryCatch object to come into
existence, if the finally block wa
You can easily make an extra.$400 DAILY .DIRECTLY TO YOUR PAYPAL
ACCOUNT!
http://www.easyinternetbiz.net/index.html
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--
LGTM
http://codereview.chromium.org/41
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 3311
Author: yu...@chromium.org
Date: Mon Nov 16 08:58:09 2009
Log: Fix some presubmit errors.
tbr=sgje...@chromium.org
Review URL: http://codereview.chromium.org/41
http://code.google.com/p/v8/source/detail?r=3311
Modified:
/branches/bleeding_edge/src/top.cc
/branches/bleeding
Reviewers: Søren Gjesse,
Description:
Fix some presubmit errors.
tbr=sgje...@chromium.org
Please review this at http://codereview.chromium.org/41
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/top.cc
M test/cctest/test-debug.cc
Index: t
Reviewers: Lasse Reichstein,
Message:
I also considered using a form taking two registers and asserting that the
second (the shift amount) was always ecx, but decided against it.
Description:
Changes to Intel shift functions
Change name of shifts picking the shift count from cl to sal_cl, shl_c
Status: New
Owner:
New issue 512 by rodolph.perfetta: Enhancement to VFP support code (ARM)
http://code.google.com/p/v8/issues/detail?id=512
Currently VFP registers are declared as any ARM register (same struct), it
is far from ideal:
* rn, sn and dn look the same to the compiler, erroneo
Reviewers: fschneider, Lasse Reichstein, Kevin Millikin,
Message:
Here is a start on what I think we should do.
Description:
A start on allowing non-local control flow, for exceptions, try-finally, and
returns, in the fast compiler.
Please review this at http://codereview.chromium.org/397010
S
Revision: 3310
Author: yu...@chromium.org
Date: Mon Nov 16 06:41:55 2009
Log: Skip debugger frames when looking for calling context.
BUG=509
Review URL: http://codereview.chromium.org/398002
http://code.google.com/p/v8/source/detail?r=3310
Modified:
/branches/bleeding_edge/src/top.cc
/branc
http://codereview.chromium.org/398002/diff/4002/4003
File test/cctest/test-debug.cc (right):
http://codereview.chromium.org/398002/diff/4002/4003#newcode5674
Line 5674: // Create a function for testing beak.
On 2009/11/16 07:34:08, Søren Gjesse wrote:
> beak?
Done.
http://codereview.chromium.or
Updates:
Status: Fixed
Comment #1 on issue 503 by erik.corry: undefined <= undefined on ARM
http://code.google.com/p/v8/issues/detail?id=503
Fixed in bleeding edge revision 3309
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you s
Revision: 3309
Author: erik.co...@gmail.com
Date: Mon Nov 16 06:12:27 2009
Log: Fix bug 503: undefined <= undefined should return false on ARM.
Review URL: http://codereview.chromium.org/399001
http://code.google.com/p/v8/source/detail?r=3309
Added:
/branches/bleeding_edge/test/mjsunit/regress/
LGTM
http://codereview.chromium.org/399001
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Updates:
Status: Fixed
Comment #1 on issue 499 by erik.corry: mjsunit/cyrillic times out on arm
http://code.google.com/p/v8/issues/detail?id=499
Fixed in bleeding edge revision 3308.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because
Revision: 3308
Author: erik.co...@gmail.com
Date: Mon Nov 16 05:06:27 2009
Log: Fix bug 499 by splitting up long-running test to minimise the amount
of code that can't be tested on slow targets.
Review URL: http://codereview.chromium.org/385133
http://code.google.com/p/v8/source/detail?r=3308
Add
> So, I'm trying to avoid a memcpy. I'd like to be able to recv() directly
> into
> the V8 heap. As long as no V8 functions are called, the GC shouldn't run.
Could
> a method like this be exposed if it was surrounded by a big scary warning
> and
> combined with safer WriteBytes() and ReadBytes
Thinking about this some more, I suppose just using an External is probably
best. I like the idea of having the memory managed by V8 without doing the
weak
reference callback, but maybe that's not a big enough reason to justify
exposing
an unsafe pointer.
ry
http://codereview.chromium.org/39
Lgtm!
http://codereview.chromium.org/385133
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
On 2009/11/16 12:12:22, Christian Plesner Hansen wrote:
> Except for giving out a derived pointer
> (see below) it looks okay to me.
So, I'm trying to avoid a memcpy. I'd like to be able to recv() directly
into
the V8 heap. As long as no V8 functions are called, the GC shouldn't run.
Could
a
Reviewers: Christian Plesner Hansen,
Description:
Fix bug 499 by splitting up long-running test to minimise the amount
of code that can't be tested on slow targets.
Please review this at http://codereview.chromium.org/385133
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affect
I agree that SetIndexedPropertiesToExternalArrayData which was introduced
only a
few weeks ago is probably closer to what you want.
I've looked through the code anyway. Except for giving out a derived
pointer
(see below) it looks okay to me.
http://codereview.chromium.org/391068/diff/1/3
F
LGTM.
I'll land it later today or possibly tomorrow.
http://codereview.chromium.org/384132
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Comment #7 on issue 463 by chosenperfect: Cant build in gcc 4.4.1
http://code.google.com/p/v8/issues/detail?id=463
erhm, i mean GIT..
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notific
Comment #6 on issue 463 by chosenperfect: Cant build in gcc 4.4.1
http://code.google.com/p/v8/issues/detail?id=463
thanks for the patch file, why not include it to the SVN? ^^
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred thi
36 matches
Mail list logo
