[v8-dev] Re: MIPS: Reduced the number of threads in cctest test-lockers. (issue 8506008)

Adding ri...@chromium.org as reviewer. http://codereview.chromium.org/8506008/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1836 in v8: ARM/MIPS HW: creating Contexts from multiple threads fails

Comment #4 on issue 1836 by gerg...@homejinni.com: ARM/MIPS HW: creating Contexts from multiple threads fails http://code.google.com/p/v8/issues/detail?id=1836 Hi, We already created a submission for this: http://codereview.chromium.org/8506008/ I added you as a reviewer. Best Regards, G

[v8-dev] قد تم التصديق على صورك

لقد تم تعديل صورك البعض من صورك لا يتماشى مع دلائل المستخدم على Badoo. من فضلك إتبع الرابط لمعرفة التغييرات التي تم اجراءها: http://badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=18&m=18&mid=4eccaa99000b0046d8d63870 إذا الضغط على الرابط في هذه الرسالة لا يعمل ، انسخه و ألصقه

[v8-dev] [v8] r10047 committed - Decrease number of threads in ExtensionRegistration tests for mips, cu...

Revision: 10047 Author: ri...@chromium.org Date: Wed Nov 23 00:06:13 2011 Log: Decrease number of threads in ExtensionRegistration tests for mips, current number is causing OOMs. This was fixed for arm in revision 10045 Review URL: http://codereview.chromium.org/8662003 http://code.

[v8-dev] Re: Issue 1836 in v8: ARM/MIPS HW: creating Contexts from multiple threads fails

Updates: Status: Fixed Comment #5 on issue 1836 by ri...@chromium.org: ARM/MIPS HW: creating Contexts from multiple threads fails http://code.google.com/p/v8/issues/detail?id=1836 Fix landed in revision 10047 I did not see that there was already a cl up for review on this, I already

[v8-dev] [v8] r10048 committed - MIPS: Reduced the number of threads in cctest test-lockers....

Revision: 10048 Author: ri...@chromium.org Date: Wed Nov 23 00:36:03 2011 Log: MIPS: Reduced the number of threads in cctest test-lockers. Some MIPS boards could not handle the large number of threads and failed these tests. BUG= TEST= Review URL: http://codereview.chromium.org/850

[v8-dev] لديك 1 رسالة جديدة...

لديك 1 رسالة جديدة... هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 1 رسالة جديدة من 1 جهة إتصال ، إتبع هذا الرابط: http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4eccb343

[v8-dev] Re: MIPS: Reduced the number of threads in cctest test-lockers. (issue 8506008)

thanks for the patch, landed http://codereview.chromium.org/8506008/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Introduce short external strings without pointer cache. (issue 8635011)

LGTM http://codereview.chromium.org/8635011/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/8635011/diff/1/src/api.cc#newcode4563 src/api.cc:4563: if (size < i::ExternalString::kShortSize) Put braces around the then-statement. http://codereview.chromium.org/8635011/di

[v8-dev] Re: Upstream Android V8 change. (issue 8631012)

LGTM, I'll land. http://codereview.chromium.org/8631012/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/8631012/diff/1/build/common.gypi#newcode144 build/common.gypi:144: ['host_arch=="x64" or OS=="android"', { This is a little hacky, but it's OK for now.

[v8-dev] Re: Introduce short external strings without pointer cache. (issue 8635011)

Landing... http://codereview.chromium.org/8635011/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/8635011/diff/1/src/api.cc#newcode4563 src/api.cc:4563: if (size < i::ExternalString::kShortSize) On 2011/11/23 08:43:20, Lasse Reichstein wrote: Put braces around the the

[v8-dev] [v8] r10049 committed - Introduce short external strings without pointer cache....

Revision: 10049 Author: yang...@chromium.org Date: Wed Nov 23 01:58:58 2011 Log: Introduce short external strings without pointer cache. BUG= TEST= Review URL: http://codereview.chromium.org/8635011 http://code.google.com/p/v8/source/detail?r=10049 Modified: /branches/bleeding_edge/

[v8-dev] Rolling back r10049 due to webkit failures. (issue 8681007)

Reviewers: Michael Starzinger, Message: PTAL. Description: Rolling back r10049 due to webkit failures. Please review this at http://codereview.chromium.org/8681007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/api.cc M src/heap-inl.h M src/heap.h

[v8-dev] Re: Rolling back r10049 due to webkit failures. (issue 8681007)

LGTM (rubber-stamp). http://codereview.chromium.org/8681007/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r10050 committed - Rolling back r10049 due to webkit failures....

Revision: 10050 Author: yang...@chromium.org Date: Wed Nov 23 02:41:12 2011 Log: Rolling back r10049 due to webkit failures. Review URL: http://codereview.chromium.org/8681007 http://code.google.com/p/v8/source/detail?r=10050 Modified: /branches/bleeding_edge/src/api.cc /branches/bl

[v8-dev] لديك 1 رسالة جديدة...

لديك 1 رسالة جديدة... هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 1 رسالة جديدة من 1 جهة إتصال ، إتبع هذا الرابط: http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4ecccf63

[v8-dev] Re: Implement crankshaft support for nested object literals. (issue 8640001)

Added new patch set. Will start porting to x64 and ARM. http://codereview.chromium.org/8640001/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8640001/diff/2001/src/hydrogen.cc#newcode3363 src/hydrogen.cc:3363: Handle closure = info()->closure(); On 2011/1

[v8-dev] Prepare push to trunk. Now working on version 3.7.11. (issue 8679002)

Reviewers: Jakob, Description: Prepare push to trunk. Now working on version 3.7.11. R=jkumme...@chromium.org Please review this at http://codereview.chromium.org/8679002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M ChangeLog M src/version.cc Index

[v8-dev] Re: Prepare push to trunk. Now working on version 3.7.11. (issue 8679002)

lgtm http://codereview.chromium.org/8679002/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r10051 committed - Prepare push to trunk. Now working on version 3.7.11....

Revision: 10051 Author: mstarzin...@chromium.org Date: Wed Nov 23 03:56:52 2011 Log: Prepare push to trunk. Now working on version 3.7.11. R=jkumme...@chromium.org Review URL: http://codereview.chromium.org/8679002 http://code.google.com/p/v8/source/detail?r=10051 Modified: /branch

[v8-dev] [v8] r10053 committed - Tagging version 3.7.10

Revision: 10053 Author: mstarzin...@chromium.org Date: Wed Nov 23 04:14:15 2011 Log: Tagging version 3.7.10 http://code.google.com/p/v8/source/detail?r=10053 Added: /tags/3.7.10 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r10052 committed - Version 3.7.10...

Revision: 10052 Author: mstarzin...@chromium.org Date: Wed Nov 23 04:13:52 2011 Log: Version 3.7.10 Set maximum length of FixedArray in terms of elements instead an absolute number of bytes. (Chromium issue 103103) Stability and performance improvements on all platforms. http://cod

[v8-dev] Recommit introducing short external strings. (issue 8677006)

Reviewers: Michael Starzinger, Message: Please take a look. Patch set 1 is merely r10049 that has been rolled back. Patch set 2 contains the actual fix. http://codereview.chromium.org/8677006/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/

[v8-dev] Re: Recommit introducing short external strings. (issue 8677006)

LGTM (just looked at second patch set, rubber-stamped the first one). http://codereview.chromium.org/8677006/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r10054 committed - Recommit introducing short external strings....

Revision: 10054 Author: yang...@chromium.org Date: Wed Nov 23 05:08:28 2011 Log: Recommit introducing short external strings. Review URL: http://codereview.chromium.org/8677006 http://code.google.com/p/v8/source/detail?r=10054 Modified: /branches/bleeding_edge/src/api.cc /branches/b

[v8-dev] Refactor Heap::SymbolMapForString to use switch/case. (issue 8683001)

Reviewers: Jakob, Message: PTAL. Description: Refactor Heap::SymbolMapForString to use switch/case. Please review this at http://codereview.chromium.org/8683001/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/heap.cc Index: src/heap.cc diff --git a/s

[v8-dev] Re: Refactor Heap::SymbolMapForString to use switch/case. (issue 8683001)

lgtm http://codereview.chromium.org/8683001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r10055 committed - Refactor Heap::SymbolMapForString to use switch/case....

Revision: 10055 Author: yang...@chromium.org Date: Wed Nov 23 05:31:26 2011 Log: Refactor Heap::SymbolMapForString to use switch/case. Review URL: http://codereview.chromium.org/8683001 http://code.google.com/p/v8/source/detail?r=10055 Modified: /branches/bleeding_edge/src/heap.cc =

[v8-dev] Relax inlining limits for simple leaf functions. (issue 8677008)

Reviewers: fschneider, Message: Please take a look. Description: Relax inlining limits for simple leaf functions. A simple leaf is a function that does not call other functions and does not contain complex statements. Store AST node count and a flag, that indicates whether the function is a

[v8-dev] Porting r10023 and r10054 to x64 (pointer cache for external strings). (issue 8662009)

Reviewers: Lasse Reichstein, Message: Please take a look. This CL replaces http://codereview.chromium.org/8569008/ http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#new

[v8-dev] ARM: Implement code stub for object literal creation. (issue 8638012)

LGTM http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newcode362 src/arm/code-stubs-arm.cc:362: __ cmp(r3, ip); Seems like you could use CompareRoot here. http

[v8-dev] Re: Catch non-string subject in RegExpExecStub. (issue 8554004)

On 2011/11/21 14:27:35, Yang wrote: Please take a look. This patch adds a guard against non-string subjects when executing regexp in generated code, something that would only happen if the native function is called with unsafe arguments. The price is that sliced string subjects are handled m

[v8-dev] Re: Implement crankshaft support for nested object literals. (issue 8640001)

LGTM with a few comments. http://codereview.chromium.org/8640001/diff/6001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/8640001/diff/6001/src/ia32/lithium-codegen-ia32.cc#newcode4186 src/ia32/lithium-codegen-ia32.cc:4186: object-

[v8-dev] Porting r10023 and r10054 to arm (pointer cache for external strings). (issue 8682010)

Reviewers: Rico, Message: Please take a look. The first patch set merely refactors so that both the full-codegen version and the crankshaft version of charCodeAt use the same piece of code now generated by StringCharLoadGenerator::Generate in codegen-arm.cc The second patch set includes th

[v8-dev] Re: [hydrogen] optimize switch with string clauses (issue 8373029)

Any status updates on http://codereview.chromium.org/8499010/ ? Cheers, Fedor. On Fri, Nov 18, 2011 at 12:07 PM, Fedor Indutny wrote: > Thank you for merging this! > > I opened new code review request to add second-pass of `fast` symbol > comparisons and some type feedback to this switch opti

[v8-dev] Re: ARM: Implement code stub for object literal creation. (issue 8638012)

Reviewers: Erik Corry, Message: Added new patch set. Landed. http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newcode362 src/arm/code-stubs-arm.cc:362: __ cmp(

[v8-dev] [v8] r10056 committed - ARM: Implement code stub for object literal creation....

Revision: 10056 Author: mstarzin...@chromium.org Date: Wed Nov 23 07:01:20 2011 Log: ARM: Implement code stub for object literal creation. This just ports r10036 to the ARM codegenerator. Please see the original revision for a detailed description. R=erik.co...@gmail.com Review URL:

[v8-dev] Optimize switch statements (second pass) (issue 8499010)

I'm worried about the code size with this approach, especially if you have a nested switch statement. http://codereview.chromium.org/8499010/diff/5003/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8499010/diff/5003/src/hydrogen.cc#newcode2887 src/hydrogen.cc:2887:

[v8-dev] Add external strings support to regexp in generated code. (issue 8680010)

Reviewers: Lasse Reichstein, Message: Please take a look. This replaces http://codereview.chromium.org/8584003/ Description: Add external strings support to regexp in generated code. TEST=test/mjsunit/string-external-cached.js Please review this at http://codereview.chromium.org/8680010/ SV

[v8-dev] Remove the static qualifier from functions in header files. (issue 8680013)

Reviewers: danno, Message: I can't think of a really good reason to put static functions in headers (and I can think of a bad reason). Description: Remove the static qualifier from functions in header files. This shaves 416+ KB, just under 1% off the size of the debug d8 executable on Linux

[v8-dev] Re: Start incremental marking on idle notification (second version). (issue 8519002)

Addressed comments and tuned heuristics for starting and finishing the idle round. Could you please take another look? http://codereview.chromium.org/8519002/diff/9002/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/8519002/diff/9002/src/heap.cc#newcode4497 src/heap.cc:449

[v8-dev] Re: Remove the static qualifier from functions in header files. (issue 8680013)

Drive-by on this one file... http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h#newcode309 src/arm/assembler-arm.h:309: extern const DwVfpRegister& kDoubleRegZero; dis

[v8-dev] [v8] r10057 committed - Upstream Android V8 change....

Revision: 10057 Author: jkumme...@chromium.org Date: Wed Nov 23 09:32:34 2011 Log: Upstream Android V8 change. Fix the Mac build. "_toolset" needs to be tested inside target_conditions now. And there is no need to have -llog any more. Review URL: http://codereview.chromium.org/863

[v8-dev] Issue 1840 in v8: High num of deopts for attached production code from game engine

Status: New Owner: New issue 1840 by sethl...@google.com: High num of deopts for attached production code from game engine http://code.google.com/p/v8/issues/detail?id=1840 Please see both the JavaScript and Flash versions of this code which decompressed PVR textures. http://www.mand

[v8-dev] Re: Remove the static qualifier from functions in header files. (issue 8680013)

No, you are right. I will revert that, also in the corresponding spot in the MIPS file. On Wed, Nov 23, 2011 at 5:58 PM, wrote: > Drive-by on this one file... > > > > http://codereview.chromium.**org/8680013/diff/1/src/arm/**assembler-arm.h

[v8-dev] Re: Issue 1797 in v8: Chrome - toLocaleString() function is not converting the number into local format.

Comment #2 on issue 1797 by dried...@gmail.com: Chrome - toLocaleString() function is not converting the number into local format. http://code.google.com/p/v8/issues/detail?id=1797 Is there a suggested work around until the best solution is offered? Will this be resolved in the future? --

[v8-dev] V8 improvement with a deterministic memory manager of constant complexity

Gentlemen, I would like to present you a memory manager of constant complexity I wrote in C++. It can easily be integrated in the core V8 engine to replace the garbage collector it is currently using. Its documentation and a presentation can be found here: https://svn.boost.org/svn/boost/sandbox

[v8-dev] لديك 3 رسائل جدد...

لديك 3 رسائل جدد... هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 3 رسائل جدد من 3 جهات إتصال ، إتبع هذا الرابط: http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4ecd8f93

[v8-dev] لديك 2 رسالتان جديدتان ...

لديك 2 رسالتان جديدتان ... هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 2 رسالتان جديدتان من 2 جهتان إتصال ، إتبع هذا الرابط: http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&m

[v8-dev] Re: Porting r10023 and r10054 to arm (pointer cache for external strings). (issue 8682010)

LGMT with comments addressed http://codereview.chromium.org/8682010/diff/1001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8682010/diff/1001/src/arm/code-stubs-arm.cc#newcode5072 src/arm/code-stubs-arm.cc:5072: masm, object_, index_, result_,

[v8-dev] trouble build v8

I'm try build v8 from svn on my laptop (5.0.9) and scons stop with error scons library=shared scons: Reading SConscript files ... KeyError: 0: File "/tmp/v8-read-only/SConstruct", line 1568: Build() File "/tmp/v8-read-only/SConstruct", line 1521: VerifyOptions(env) File "/tmp/v8-rea

Re: [v8-dev] V8 improvement with a deterministic memory manager of constant complexity

I think you misunderstood a few thinks: 1. V8 is open source software, we do not licence and put in commercial components (since the licences would not be compatible. Anybody can take and use V8 for most purposes, the licensing is very permissive (New BSD License). 2. V8 has a completely custom mem