Status: New
Owner:
New issue 1970 by alexei.i...@gmail.com: localeCompare does not sort UTF-8
strings properly
http://code.google.com/p/v8/issues/detail?id=1970
Consider simple example:
var t_a = ["Côte d'Ivoire","Czech Republic","China"];
t_a.sort(function(a,b){return a.localeCompar
fyi: Cris.
https://chromiumcodereview.appspot.com/9452002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Erik Corry,
Description:
Ensure that executable pages are properly guarded.
Split executable memory chunks into two pieces: header with all metadata
(protection: RW) and body (protection: RWX). Separate header from metadata
with
a guard page and add a guard page after the page body
Revision: 10799
Author: mikhail.naga...@gmail.com
Date: Wed Feb 22 15:06:11 2012
Log: Speedup dominators construction in heap snapshot.
It is achieved by:
1. skipping entries those dominators have already reached root.
2. processing only entries those retainers have changed their
do
On 2012/02/22 16:24:46, alexeif wrote:
Mike, could you please take a look.
Thanks!
Awesome!
LGTM, I'll submit this.
https://chromiumcodereview.appspot.com/9372105/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Adding ri...@chromium.org (issue owner) as reviewer.
https://chromiumcodereview.appspot.com/9433031/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10798
Author: vego...@chromium.org
Date: Wed Feb 22 11:47:57 2012
Log: RandomizedVirtualAlloc should check for isolate presence instead
of using Isolate::Current()
CpuFeatures::Probe request executable memory before any isolate is
initialized and entered.
TBR=erik.co..
Reviewers: Erik Corry,
Description:
RandomizedVirtualAlloc should check for isolate presence instead of using
Isolate::Current()
CpuFeatures::Probe request executable memory before any isolate is
initialized
and entered.
TBR=erik.co...@gmail.com
Please review this at https://chromiumcodere
Reviewers: Sven Panne,
Description:
Make HashMap a template class to specify the allocation policy.
The old HashMap class had an explicit member to determine the allocation
policy. The template version matches the approach used already for
lists.
Cleanup some include dependencies and unnecessar
Revision: 10797
Author: vego...@chromium.org
Date: Wed Feb 22 09:21:55 2012
Log: Randomize allocation addresses on windows.
BUG=115151
Review URL: https://chromiumcodereview.appspot.com/9372083
Patch from Cris Neckar .
http://code.google.com/p/v8/source/detail?r=10797
Modified:
/bra
landed.
http://codereview.chromium.org/9372083/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10796
Author: vego...@chromium.org
Date: Wed Feb 22 08:45:35 2012
Log: Support OSR in for-in loops.
Modify PreProcessOsrEntry to work with OSR entries that have non-empty
expression stack.
Modify graph builder to take for-in state from environment instead of
directly re
Reviewers: Mikhail Naganov (Chromium), Yury Semikhatsky,
Message:
Mike, could you please take a look.
Thanks!
Description:
Speedup dominators construction in heap snapshot.
It is achieved by:
1. skipping entries those dominators have already reached root.
2. processing only entries those retai
lgtm
https://chromiumcodereview.appspot.com/9431030/diff/4001/test/mjsunit/compiler/optimized-for-in.js
File test/mjsunit/compiler/optimized-for-in.js (right):
https://chromiumcodereview.appspot.com/9431030/diff/4001/test/mjsunit/compiler/optimized-for-in.js#newcode295
test/mjsunit/compiler/o
PTAL, I have extended OptimizeFunctionOnNextCall with an argument to force
OSR
and improved coverage of OSR.
https://chromiumcodereview.appspot.com/9431030/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #19 on issue 1630 by alonza...@gmail.com: Compiled raytrace code is
very slow
http://code.google.com/p/v8/issues/detail?id=1630
@svenpanne: Emscripten has several code generation modes, two with typed
arrays and one without. The one without is slower, but will work in all
browsers
lgtm
https://chromiumcodereview.appspot.com/9431030/diff/1/test/mjsunit/compiler/optimized-for-in.js
File test/mjsunit/compiler/optimized-for-in.js (right):
https://chromiumcodereview.appspot.com/9431030/diff/1/test/mjsunit/compiler/optimized-for-in.js#newcode246
test/mjsunit/compiler/optimiz
Reviewers: fschneider,
Description:
Support OSR in for-in loops.
Modify PreProcessOsrEntry to work with OSR entries that have non-empty
expression stack.
Modify graph builder to take for-in state from environment instead of
directly
referencing emitted instructions
R=fschnei...@chromium.org
Revision: 10795
Author: jkumme...@chromium.org
Date: Wed Feb 22 07:18:29 2012
Log: Profiler experiments: interrupt check at function exit
Review URL: https://chromiumcodereview.appspot.com/9432026
http://code.google.com/p/v8/source/detail?r=10795
Modified:
/branches/bleeding_edge/src
LGTM
https://chromiumcodereview.appspot.com/9432026/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Cc: fschnei...@chromium.org
Comment #2 on issue 1969 by yang...@chromium.org: non-termination after
optimizer run on a function with 10K inline array assignments
http://code.google.com/p/v8/issues/detail?id=1969
While this specific case has been fixed as a side effect of r106
Reviewers: Vyacheslav Egorov,
Message:
Please take a look.
Description:
Profiler experiments: interrupt check at function exit
Please review this at https://chromiumcodereview.appspot.com/9432026/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-def
Reviewers: Michael Starzinger,
Description:
When redefining accessor properties, defensively copy AccessorPairs.
The previous code relied on the tricky global invariant that there is no map
sharing when accessor properties are involved (or in other words: that
TransformToFastProperties is dumb e
I'd prefer moving the number (digit, really) test before the ZWNJ/ZWJ
test,
since digits are probably more likely to be in actual identifiers.
I was wondering about that. Done.
Perhaps add a comment after the constants (like " // U+200C is
ZeroWidthNonJoiner.").
Done.
https://chromiumcod
https://chromiumcodereview.appspot.com/9433031/diff/1/src/char-predicates.h
File src/char-predicates.h (right):
https://chromiumcodereview.appspot.com/9433031/diff/1/src/char-predicates.h#newcode60
src/char-predicates.h:60: || c == 0x200D
Good thought.
I'd prefer moving the number (digit, really
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 1969 by yang...@chromium.org: non-termination after
optimizer run on a function with 10K inline array assignments
http://code.google.com/p/v8/issues/detail?id=1969
This is reproducable on 18.0.1025.33 be
Updates:
Status: PendingFurtherInfo
Comment #3 on issue 1944 by yang...@chromium.org: Date.parse doesn't accept
leap second
http://code.google.com/p/v8/issues/detail?id=1944
The ECMA262 spec says "In time values leap seconds are ignored." without
really saying what that implies (ign
Status: New
Owner:
New issue 1969 by bergur.r...@gmail.com: non-termination after optimizer
run on a function with 10K inline array assignments
http://code.google.com/p/v8/issues/detail?id=1969
On the second call to the javascript function below, the optimizer
apparently kicks in, but
Comment #5 on issue 1010 by net...@gmail.com: V8 crash on XP-x64/MinGW-w64
- possibly stack corruption
http://code.google.com/p/v8/issues/detail?id=1010
I get this crash:
# Fatal error in src\x64\macro-assembler-x64.cc, line 265
#
CHECK(is_int32(static_cast((v8::internal::Isolate::Current()
Comment #4 on issue 1010 by yang...@chromium.org: V8 crash on
XP-x64/MinGW-w64 - possibly stack corruption
http://code.google.com/p/v8/issues/detail?id=1010
Unfortunately, we do not officially support MinGW and have no way to test
changes that affect MinGW builds. It is not very high on our
Comment #3 on issue 1010 by net...@gmail.com: V8 crash on XP-x64/MinGW-w64
- possibly stack corruption
http://code.google.com/p/v8/issues/detail?id=1010
Should be able to compile with MinGW-w64 now without any patches. All
that's left is to fix the crashing.
--
v8-dev mailing list
v8-dev@
Updates:
Status: Fixed
Owner: yang...@chromium.org
Comment #2 on issue 1962 by yang...@chromium.org: AssertNoZoneAllocation
class is not used
http://code.google.com/p/v8/issues/detail?id=1962
I changed my mind and removed the said class. It's not in use currently and
is easy
Updates:
Status: Fixed
Comment #8 on issue 1943 by yang...@chromium.org: Fix compilation with
MinGW-w64
http://code.google.com/p/v8/issues/detail?id=1943
Landed as r10793. Thanks for your contribution!
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
Revision: 10793
Author: yang...@chromium.org
Date: Wed Feb 22 04:26:36 2012
Log: Fix compilation with MinGW-w64.
BUG=v8:1943
TEST=
Review URL: https://chromiumcodereview.appspot.com/9428027
Patch from Jonathan Liu .
http://code.google.com/p/v8/source/detail?r=10793
Modified:
/branch
LGTM with some comments.
I will fix everything myself and land.
Thank you for the patch.
http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc
File src/platform-win32.cc (right):
http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode832
src/platform-win32.cc
Revision: 10792
Author: yang...@chromium.org
Date: Wed Feb 22 04:21:18 2012
Log: Remove unused class AssertNoZoneAllocation.
BUG=v8:1962
TEST=
Review URL: https://chromiumcodereview.appspot.com/9430044
http://code.google.com/p/v8/source/detail?r=10792
Modified:
/branches/bleeding_ed
Hi Amir
Since your last visit, new girls have joined in الرباط
Maryam, 22 (الرباط, المغرب)
Khwanita, 19 (الرباط, المغرب)
Norààà, 22 (الرباط, المغرب)
Nina, 18 (الرباط, المغرب)
Yones, 19 (الرباط, المغرب)
Sara, 22 (الرباط, المغرب)
Ilhame, 20 (الرباط, المغرب)
Malak, 21 (الرباط, المغرب)
Salma, 18 (ا
Updates:
Status: WorkingAsIntended
Comment #4 on issue 1966 by jkumme...@chromium.org: Scons build problem on
SmartOS
http://code.google.com/p/v8/issues/detail?id=1966
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
Comment #7 on issue 1943 by net...@gmail.com: Fix compilation with MinGW-w64
http://code.google.com/p/v8/issues/detail?id=1943
CLA has been signed electronically.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
When V8 source files are edited, the copyright date should be modified to
the current year. If you don't use emacs, stop reading now.
Emacs has a function copyright-update that does the right thing. So, in
your .emacs file define a wrapper that updates for the file types you care
about (modify t
Comment #6 on issue 1943 by net...@gmail.com: Fix compilation with MinGW-w64
http://code.google.com/p/v8/issues/detail?id=1943
Looks good to me and compiles fine. errno.h defines STRUNCATE and includes
_mingw.h which defines _TRUNCATE. platform-win32.c includes win32-headers.h
which includes
lgtm
https://chromiumcodereview.appspot.com/9430044/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10791
Author: fschnei...@chromium.org
Date: Wed Feb 22 03:40:28 2012
Log: Eliminate use of ZONE macro in BitVector class and pass a zone
explicitly.
Review URL: https://chromiumcodereview.appspot.com/9416092
http://code.google.com/p/v8/source/detail?r=10791
Modified:
/bra
Reviewers: ulan,
Message:
PTAL.
Description:
Remove unused class AssertNoZoneAllocation.
BUG=v8:1962
TEST=
Please review this at https://chromiumcodereview.appspot.com/9430044/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/isolate.h
M src/zone-inl
Revision: 10790
Author: svenpa...@chromium.org
Date: Wed Feb 22 03:38:31 2012
Log: Added -Woverloaded-virtual to GCC flags, syncing scons and gyp
builds.
Review URL: https://chromiumcodereview.appspot.com/9430043
http://code.google.com/p/v8/source/detail?r=10790
Modified:
/branche
LGTM.
https://chromiumcodereview.appspot.com/9416092/diff/1/src/data-flow.h
File src/data-flow.h (right):
https://chromiumcodereview.appspot.com/9416092/diff/1/src/data-flow.h#newcode1
src/data-flow.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012
https://chromiumc
Revision: 10789
Author: rossb...@chromium.org
Date: Wed Feb 22 03:35:17 2012
Log: Add Ioseb Dzmanashvili to authors.
R=vego...@google.com,yang...@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9430011
http://code.google.com/p/v8/source/detail?r=10789
Modif
https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h
File src/mips/constants-mips.h (right):
https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h#newcode42
src/mips/constants-mips.h:42: enum arch_variants {mips32r2, mips32r1,
loongson};
https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc#newcode11053
test/cctest/test-api.cc:11053: const char* a = "a";
On 2012/02/20 14:28:13, Vyacheslav Eg
Reviewers: Jakob,
Description:
Eliminate use of ZONE macro in BitVector class and pass a zone explicitly.
Please review this at https://chromiumcodereview.appspot.com/9416092/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/data-flow.h
M src/hyd
Comment #3 on issue 1966 by isaacsch...@gmail.com: Scons build problem on
SmartOS
http://code.google.com/p/v8/issues/detail?id=1966
jkummerow, Thanks! Seems to be proceeding with the build properly now.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
https://chromiumcodereview.appspot.com/9430043/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Description:
Added -Woverloaded-virtual to GCC flags, syncing scons and gyp builds.
Please review this at https://chromiumcodereview.appspot.com/9430043/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M SConstruct
Index: SConstruct
diff --g
Drive-by comment.
https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h
File src/mips/constants-mips.h (right):
https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h#newcode42
src/mips/constants-mips.h:42: enum arch_variants {mips32r2, m
Revision: 10788
Author: svenpa...@chromium.org
Date: Wed Feb 22 02:52:57 2012
Log: Cleaned up setting of accessors.
This CL is an intermediate step only, in the end we need to have a single
DefineOrRedefineAccessorProperty call for a single Object.defineProperty
call. Currently we can
https://chromiumcodereview.appspot.com/9428026/diff/1/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/9428026/diff/1/src/objects.cc#newcode4418
src/objects.cc:4418: return GetHeap()->undefined_value();
On 2012/02/22 10:24:38, Michael Starzinger wrote:
I prefer
Revision: 10787
Author: jkumme...@chromium.org
Date: Wed Feb 22 02:48:58 2012
Log: Profiler experiments: self-optimization for functions containing
calls
Review URL: https://chromiumcodereview.appspot.com/9430042
http://code.google.com/p/v8/source/detail?r=10787
Modified:
/branche
LGTM.
https://chromiumcodereview.appspot.com/9430042/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Yang,
Message:
PTAL.
Description:
Profiler experiments: self-optimization for functions containing calls
Please review this at https://chromiumcodereview.appspot.com/9430042/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-ar
Updates:
Status: WorkingAsIntended
Comment #1 on issue 1962 by yang...@chromium.org: AssertNoZoneAllocation
class is not used
http://code.google.com/p/v8/issues/detail?id=1962
This class serves to ensure that there are no zone allocations in the scope
where an instance of this class
On 2012/02/22 08:57:38, rossberg wrote:
On 2012/02/21 20:35:38, Yang wrote:
> Drive-by:
>
> Since you are already doing this, could you please also add "Michael
Lutz
> " to the list? He provided
> http://codereview.chromium.org/9395074/ for which I forgot to credit
him.
Done.
Drive-by L
Updates:
Status: Fixed
Comment #1 on issue 1963 by yang...@chromium.org: missing NULL check in
fail function (preparser-process.cc)
http://code.google.com/p/v8/issues/detail?id=1963
Thank you for pointing this out! This has been fixed at r10786.
--
v8-dev mailing list
v8-dev@googlegr
Revision: 10786
Author: yang...@chromium.org
Date: Wed Feb 22 02:31:32 2012
Log: Prevent segfault when preparser fails due to lack of argument.
BUG=v8:1963
TEST=run preparser with no command line arguments
Review URL: https://chromiumcodereview.appspot.com/9431028
http://code.google.c
LGTM
http://codereview.chromium.org/9431028/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Message:
PTAL.
Description:
Prevent segfault when preparser fails due to lack of argument.
BUG=v8:1963
TEST=run preparser with no command line arguments
Please review this at http://codereview.chromium.org/9431028/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_e
LGTM.
https://chromiumcodereview.appspot.com/9428026/diff/1/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/9428026/diff/1/src/objects.cc#newcode4418
src/objects.cc:4418: return GetHeap()->undefined_value();
I prefer having the result of GetHeap() in a local "
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #5 on issue 1943 by yang...@chromium.org: Fix compilation with
MinGW-w64
http://code.google.com/p/v8/issues/detail?id=1943
I looked through the patch. It did not apply cleanly, so I created a new
change list based
Reviewers: net147_gmail.com,
Message:
Please confirm that this patch indeed fixes compilation on MinGW-w64.
Description:
Fix compilation with MinGW-w64.
BUG=v8:1943
TEST=
Please review this at https://chromiumcodereview.appspot.com/9428027/
SVN Base: https://v8.googlecode.com/svn/branches/b
Status: New
Owner:
New issue 1968 by isaacsch...@gmail.com: Hang on SunOS by doing `new
Error("foo").stack`
http://code.google.com/p/v8/issues/detail?id=1968
Using node 0.7.5, v8 3.9.5, I see this behavior:
[root@9086445f-5f87-47d8-b0bc-493d2fd7b52f ~/node]# ./node -pe 'new
Error("foo
LGTM!
https://chromiumcodereview.appspot.com/9425045/diff/4001/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):
https://chromiumcodereview.appspot.com/9425045/diff/4001/src/arm/lithium-arm.h#newcode2100
src/arm/lithium-arm.h:2100: class LCheckMapValue: public
LTemplateInstruction<1, 2,
Comment #2 on issue 1966 by jkumme...@chromium.org: Scons build problem on
SmartOS
http://code.google.com/p/v8/issues/detail?id=1966
No idea about the scons error, and I'm sorry to say that I won't
investigate it either: building V8 with scons is deprecated, and SmartOS is
not officially
Comment #2 on issue 1820 by yang...@chromium.org: Suggestion: Flag to
prevent breakpoint relocation across source lines
http://code.google.com/p/v8/issues/detail?id=1820
Having looked into the debugger code of V8 recently, I'm not sure this can
be implemented without an unproportionally lar
Reviewers: Lasse Reichstein,
Message:
As an `IdentifierStart` character is the most common case for an
`IdentifierPart`, I figured it would be best to perform the U+200C and
U+200D
checks right after, but before the more expensive Unicode category lookups.
https://chromiumcodereview.appspot.
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #2 on issue 1391 by yang...@chromium.org: Fixing deprecated python
code
http://code.google.com/p/v8/issues/detail?id=1391
I'm sorry for the long delay. The patches look good to me. However, I have
to ask you to s
Updates:
Status: Fixed
Comment #1 on issue 488 by yang...@chromium.org: mjsunit/array-constructor
times out
http://code.google.com/p/v8/issues/detail?id=488
Not relevant anymore.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Description:
Cleaned up setting of accessors.
This CL is an intermediate step only, in the end we need to have a single
DefineOrRedefineAccessorProperty call for a single Object.defineProperty
call. Currently we can end up making two such calls, making the necessar
Updates:
Status: Fixed
Comment #3 on issue 153 by yang...@chromium.org: Add support for running
multiple JS tests in same VM
http://code.google.com/p/v8/issues/detail?id=153
I suppose this is outdated. D8 has the options --isolate and -p. The former
is used for stress testing, the l
On 2012/02/21 20:35:38, Yang wrote:
Drive-by:
Since you are already doing this, could you please also add "Michael Lutz
" to the list? He provided
http://codereview.chromium.org/9395074/ for which I forgot to credit him.
Done.
https://chromiumcodereview.appspot.com/9430011/
--
v8-dev maili
Updates:
Status: Fixed
Comment #6 on issue 173 by yang...@chromium.org: v8::Script::Compile()
crashes when parsing very long (but simple) file
http://code.google.com/p/v8/issues/detail?id=173
Tested as described in #0. Chrome no longer crashes.
--
v8-dev mailing list
v8-dev@googlegro
Updates:
Status: Accepted
Owner: fschnei...@chromium.org
Comment #18 on issue 1630 by fschnei...@chromium.org: Compiled raytrace
code is very slow
http://code.google.com/p/v8/issues/detail?id=1630
Thanks for trying this. I can reproduce the slowness even when using the
whole
Status: Assigned
Owner: yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1967 by yang...@chromium.org: Enable string compare for
non-sequential strings in generated code.
http://code.google.com/p/v8/issues/detail?id=1967
.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
Updates:
Labels: Type-FeatureRequest
Comment #1 on issue 1965 by l...@chromium.org: Use Unicode 6.1.0 when
determining whether an identifier is acceptable or not
http://code.google.com/p/v8/issues/detail?id=1965
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@
82 matches
Mail list logo
