LGTM with a nit.
https://codereview.chromium.org/16365008/diff/4001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/16365008/diff/4001/include/v8.h#newcode5677
include/v8.h:5677: bool fits_into_int32_t = (i & (1 << 31)) == 0;
I think 'i < INT32_MAX' is more readable than
Revision: 14990
Author: dcar...@chromium.org
Date: Fri Jun 7 00:34:25 2013
Log: ReturnValue::Set(uint32_t) is wrong
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/16365008
http://code.google.com/p/v8/source/detail?r=14990
Modified:
/branches/bleeding_edge
Committed patchset #3 manually as r14990.
https://codereview.chromium.org/16365008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
lgtm
https://codereview.chromium.org/15795006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/16180011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 14991
Author: dcar...@chromium.org
Date: Fri Jun 7 00:54:39 2013
Log: build fix for 14990
BUG=
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/16180011
http://code.google.com/p/v8/source/detail?r=14991
Modified:
/branches/bleeding_edge/include/v8.h
=
Reviewers: Sven Panne,
Message:
Committed patchset #2 manually as r14991.
Description:
build fix for 14990
BUG=
R=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=14991
Please review this at https://codereview.chromium.org/16180011/
SVN Base: https://v8.googleco
Reviewers: Jakob,
Message:
PTAL
Description:
Observed double + truncating input = observed int32
Please review this at https://chromiumcodereview.appspot.com/16439019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
M src/hydrog
Status: New
Owner:
New issue 2713 by luocan19...@gmail.com: help , ObjectTemplate.NewInstance
always return a empty object
http://code.google.com/p/v8/issues/detail?id=2713
I want to dymanic add a funtion to a object, so I use prototype, but
NewInstance always return a empty(null) obje
Revision: 14992
Author: dcar...@chromium.org
Date: Fri Jun 7 00:56:49 2013
Log: lint failure with latest depot_tools
BUG=
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/15795006
http://code.google.com/p/v8/source/detail?r=14992
Modified:
/branches/bleeding_edg
Hi Andrew,
it's correct that the interpreted irregexp could have been tested more
frequently than currently being done. This will hopefully change for the
better in the near future. For now I'll fix this oversight. Thanks!
Regards,
Yang
On Fri, Jun 7, 2013 at 5:20 AM, Andrew Low wrote:
> Apo
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r14992 (presubmit successful).
Description:
lint failure with latest depot_tools
BUG=
R=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=14992
Please review this at https://codereview.chromium.org/
LGTM with a nit (drive-by, after heated discussions ;-)
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc#newcode1326
src/hydrogen-instruction
lgtm
https://codereview.chromium.org/16409011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r14993 (presubmit successful).
Description:
build fix for build fix for 14990
BUG=
R=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=14993
Please review this at https://codereview.chromium.org/164
Revision: 14993
Author: dcar...@chromium.org
Date: Fri Jun 7 01:15:00 2013
Log: build fix for build fix for 14990
BUG=
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/16409011
http://code.google.com/p/v8/source/detail?r=14993
Modified:
/branches/bleeding_edge/i
Addressed comment. Landing.
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc#newcode1326
src/hydrogen-instructions.cc:1326: Range* result = n
https://chromiumcodereview.appspot.com/16268009/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16268009/diff/1/src/hydrogen-instructions.cc#newcode1317
src/hydrogen-instructions.cc:1317: bool spans_zero = lower < 0 && 0 <
upp
Reviewers: Jakob,
Message:
PTAL
Description:
Don't ignore the actual input representation in UnaryMathOperations
Please review this at https://chromiumcodereview.appspot.com/16035014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.
Reviewers: Sven Panne,
Description:
Remove use of Isolate::Current in regexp macro assemblers.
R=svenpa...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/16026020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/regexp
On 2013/06/07 08:30:11, Yang wrote:
Please take a look.
https://codereview.chromium.org/16026020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
LGTM!
https://codereview.chromium.org/16026020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Committed patchset #1 manually as r14994 (presubmit successful).
https://chromiumcodereview.appspot.com/16026020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 14994
Author: yang...@chromium.org
Date: Fri Jun 7 01:38:05 2013
Log: Remove use of Isolate::Current in regexp macro assemblers.
BUG=
R=hpa...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16026020
http://code.google.com/p/v8/source/detail?r=14994
Modifie
Reviewers: Jakob, Rodolph Perfetta,
Message:
PTAL. Jakob, this is the snippet that you sent me with minor fixes.
Description:
ARM: Fix build flags for snapshot generation.
The existing code ignores armv7 and arm_fpu flags since r14288.
R=jkumme...@chromium.org
Please review this at https://ch
https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc#newcode3075
src/hydrogen-instructions.cc:3075: rep =
rep.generalize(observed_input_re
Revision: 14995
Author: dcar...@chromium.org
Date: Fri Jun 7 01:46:39 2013
Log: Add Value::Cast.
It's needed for upcasting Persistent to Persistent after
handlepocalypse (with Persistent::As or Persistent::Cast).
BUG=
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.
Committed patchset #3 manually as r14995 (presubmit successful).
https://codereview.chromium.org/16206014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Updates:
Status: WorkingAsIntended
Comment #1 on issue 2712 by yang...@chromium.org: slice hangs
http://code.google.com/p/v8/issues/detail?id=2712
Unfortunately, the spec is pretty precise about this:
15.4.4.10 Array.prototype.slice(start, end)
[...]
1. Let O be the result of calling To
Comment #11 on issue 2612 by yang...@chromium.org: Memory black hole for a
loop above a certain number of iterations
http://code.google.com/p/v8/issues/detail?id=2612
Glad we could help!
--
You received this message because this project is configured to send all
issue notifications to this
Addressed comments, PTAL again
https://chromiumcodereview.appspot.com/16268009/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16268009/diff/1/src/hydrogen-instructions.cc#newcode1317
src/hydrogen-instructions.cc:1317: bool s
LGTM with one more comment.
https://chromiumcodereview.appspot.com/16268009/diff/16001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16268009/diff/16001/src/hydrogen-instructions.cc#newcode1320
src/hydrogen-instructions.cc:1320: i
Hopefully now it works :)
https://chromiumcodereview.appspot.com/16268009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
Committed patchset #5 manually as r14996 (presubmit successful).
https://chromiumcodereview.appspot.com/16268009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://chromiumcodereview.appspot.com/16268009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Revision: 14996
Author: verwa...@chromium.org
Date: Fri Jun 7 02:07:53 2013
Log: Infer the range of Math.abs
R=jkumme...@chromium.org, svenpa...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16268009
http://code.google.com/p/v8/source/detail?r=14996
Modified:
/bra
Updated patch adds some try/catch and proxy tests. PTAL :)
https://codereview.chromium.org/15288011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Addressed comment, ptal
https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc#newcode3075
src/hydrogen-instructions.cc:3075: rep =
rep.gen
lgtm
https://chromiumcodereview.appspot.com/16035014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Revision: 14997
Author: verwa...@chromium.org
Date: Fri Jun 7 02:11:33 2013
Log: Don't ignore the actual input representation in
UnaryMathOperations
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16035014
http://code.google.com/p/v8/source/detail?r=149
Committed patchset #2 manually as r14997 (presubmit successful).
https://chromiumcodereview.appspot.com/16035014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Reviewers: Jakob,
Message:
PTAL
Description:
Allow boundscheck elimination to work on Smi keys.
Please review this at https://chromiumcodereview.appspot.com/16035016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
M src/hydroge
lgtm
https://chromiumcodereview.appspot.com/16313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM if comments are addressed.
https://codereview.chromium.org/16147004/diff/3001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/16147004/diff/3001/src/api.cc#newcode4313
src/api.cc:4313: static const uint64_t value = 0xFF00FF00FF00ULL;
Shouldn't this be 0xFF00FF00FF00FF00
On 2013/06/04 12:26:44, Toon Verwaest wrote:
Committed patchset #4 manually as r14933 (presubmit successful).
https://codereview.chromium.org/9156001/ unfortunately never landed, but it
is
more precise and more general as it covers all binary bitwise ops. I think
it
should replace this CL.
On Thu, Jun 6, 2013 at 6:50 PM, Yang Guo wrote:
FYI we already set the current VM state in CallApiFunctionAndReturn
guarded
by FLAG_log_timer_events. This is so that the timeline plot accounts for
the
compiled callbacks.
Cheers,
Yang
Yeah, I've seen that code but we want to be able t
https://codereview.chromium.org/15288011/diff/19001/test/mjsunit/harmony/iteration-semantics.js
File test/mjsunit/harmony/iteration-semantics.js (right):
https://codereview.chromium.org/15288011/diff/19001/test/mjsunit/harmony/iteration-semantics.js#newcode297
test/mjsunit/harmony/iteration-sema
Thanks for the ref to that CL. I'll have a look at addressing Svens
comments on
that CL on Monday; and replace my ad-hoc approach.
https://chromiumcodereview.appspot.com/16361003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this mes
lgtm
https://chromiumcodereview.appspot.com/16313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
alright, made it a friend instead
https://codereview.chromium.org/15848010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Committed patchset #2 manually as r14998 (presubmit successful).
https://chromiumcodereview.appspot.com/16313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 14998
Author: u...@chromium.org
Date: Fri Jun 7 03:02:42 2013
Log: ARM: Fix build flags for snapshot generation.
The existing code ignores armv7 and arm_fpu flags since r14288.
R=jkumme...@chromium.org, rodolph.perfe...@gmail.com
Review URL: https://chromiumcodereview.apps
Added more tests, thanks for the feedback. See inline question about proxy
receivers for generators.
https://codereview.chromium.org/15288011/diff/19001/test/mjsunit/harmony/iteration-semantics.js
File test/mjsunit/harmony/iteration-semantics.js (right):
https://codereview.chromium.org/1528801
lgtm
https://codereview.chromium.org/15848010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
svenpanne@, ptal
https://codereview.chromium.org/15848010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
lgtm
https://codereview.chromium.org/15848010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM from my side
https://codereview.chromium.org/15288011/diff/19001/test/mjsunit/harmony/iteration-semantics.js
File test/mjsunit/harmony/iteration-semantics.js (right):
https://codereview.chromium.org/15288011/diff/19001/test/mjsunit/harmony/iteration-semantics.js#newcode297
test/mjsunit/har
lgtm
https://codereview.chromium.org/15562008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #2 manually as r14999 (presubmit successful).
https://codereview.chromium.org/15848010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14999
Author: dcar...@chromium.org
Date: Fri Jun 7 03:46:51 2013
Log: Make ReturnValue a friend of Persistent, so it can use operator*.
BUG=
R=dcar...@chromium.org, svenpa...@chromium.org
Review URL: https://codereview.chromium.org/15848010
Patch from Marja Hölttä .
http:/
LGTM
https://chromiumcodereview.appspot.com/16035016/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/16035016/diff/1/src/hydrogen-instructions.h#newcode3663
src/hydrogen-instructions.h:3663: virtual Representation
observed_inpu
Committed patchset #6 manually as r15000 (presubmit successful).
https://codereview.chromium.org/15562008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM from my end as well.
https://codereview.chromium.org/15288011/diff/25001/test/mjsunit/harmony/iteration-semantics.js
File test/mjsunit/harmony/iteration-semantics.js (right):
https://codereview.chromium.org/15288011/diff/25001/test/mjsunit/harmony/iteration-semantics.js#newcode30
test/mjsu
Revision: 15000
Author: dslo...@chromium.org
Date: Fri Jun 7 03:52:11 2013
Log: Recording array buffer views.
R=hpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/15562008
http://code.google.com/p/v8/source/detail?r=15000
Added:
/branches/bleeding_edge/test/cctest
Addressed comment, landing.
https://chromiumcodereview.appspot.com/16035016/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/16035016/diff/1/src/hydrogen-instructions.h#newcode3663
src/hydrogen-instructions.h:3663: virtual Repre
Committed patchset #2 manually as r15001 (presubmit successful).
https://chromiumcodereview.appspot.com/16035016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 15001
Author: verwa...@chromium.org
Date: Fri Jun 7 04:00:39 2013
Log: Allow boundscheck elimination to work on Smi keys.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16035016
http://code.google.com/p/v8/source/detail?r=15001
Modified:
/bran
LGTM from my end as well, even though you didn't seem to bother. :)
https://codereview.chromium.org/15562008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
lgtm
https://codereview.chromium.org/16408005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2013/06/06 11:49:44, Yang wrote:
I've uploaded a second patch set to remove the changes to transition maps
and
initial object/array maps to put into a second CL.
https://codereview.chromium.org/16542003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
Revision: 15002
Author: wi...@igalia.com
Date: Fri Jun 7 04:12:21 2013
Log: Baseline for-of implementation
Add full-codegen support for the ES6 for-of iteration statement.
R=mstarzin...@chromium.org, rossb...@chromium.org
TEST=mjsunit/harmony/iteration-semantics
BUG=v8:2214
Review U
Committed patchset #6 manually as r15002 (presubmit successful).
https://codereview.chromium.org/15288011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/06/07 11:02:57, Michael Starzinger wrote:
LGTM from my end as well, even though you didn't seem to bother. :)
Sorry about, I treated R= line as an 'or' not as 'and'. Rest assured, I do
care
about your opinion!
Next time I'll designate one person as an R= and put others on CC:.
Thank
Reviewers: Toon Verwaest,
Description:
Fix InlineCacheState for ToBoolean and CompareIC
BUG=
Please review this at https://codereview.chromium.org/16613003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/code-stubs.h
M src/code-stubs.cc
Index: src/c
Updated patch is rebased onto master, and fixes the AstTyper to record the
right
information for for-of.
https://codereview.chromium.org/15740007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: Sven Panne,
Message:
API for neutering ArrayBuffer.
svenpanne: please review
mstarzinger,hpayer: FYI (this is the reason for ArrayBuffer weak lists etc)
Description:
Neutering API for v8::ArrayBuffer
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/16
lgtm
https://codereview.chromium.org/16613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/15737023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
On 2013/06/05 15:36:12, Yang wrote:
On 2013/05/28 22:23:21, peter.rybin wrote:
LGTM.
Hi Yang,
since I completely missed to send you
https://codereview.chromium.org/15737023/
for review, FindBreakLocationFromAddress still has "weird" semantics, so my
change actually must be as in the new
ia32/x64/ARM complete, PTAL again. Note that the TODOs should probably be
done
by platform experts.
@ARM people: Reviewing my ARM changes might be a good idea. :-)
@MIPS people: I've restructured the code to make it more similar to the
other
platforms, but did no real changes.
https://code
On 2013/06/07 11:34:01, peter.rybin wrote:
LGTM. Please add a comment on "pc - 1", something about the pc pointing to
the
instruction after the break point.
Alternatively, rename FindBreakLocationFromAddress to something like
FindClosestBreakLocationBeforeAddress and leave the current impleme
LGTM with a nit.
https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc#newcode2668
test/cctest/test-api.cc:2668: int byteOffset,
Using size_t instead of int for
Reviewers: Sven Panne,
Description:
use undefined as the default return value for runtime callbacks
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/16637002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arguments.h
Ping on this one. I don't think there is any ordering issue between this and
anything else. Renaming send to next can happen in another commit.
https://codereview.chromium.org/15455002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received thi
Reviewers: Yang,
Description:
Add missing AllowHandleDereference to LAllocator::BuildLiveRanges.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/16509004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/lithium-allocator.cc
Reviewers: Michael Starzinger,
Description:
Fix store buffer ensure space heuristics.
This change results in less scan on scavenge memory chunks.
BUG=
Please review this at https://codereview.chromium.org/15896037/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
On 2013/06/07 13:06:49, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/16509004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
Revision: 15003
Author: ol...@chromium.org
Date: Fri Jun 7 06:11:17 2013
Log: Fix InlineCacheState for ToBoolean and CompareIC
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/16613003
http://code.google.com/p/v8/source/detail?r=15003
Modified:
/branches/ble
Committed patchset #1 manually as r15003 (presubmit successful).
https://codereview.chromium.org/16613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/16637002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r15004 (presubmit successful).
https://codereview.chromium.org/16408005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc#newcode146
src/compiler.cc:146: for (int j = 0; j < group_maps->length(); j++) {
This has O(n^2) complexity. It is probably OK
Revision: 15004
Author: mvstan...@chromium.org
Date: Fri Jun 7 06:21:20 2013
Log: CallNewArray sites need the original feedback cell at crankshaft
time.
This CL addresses a TODO in the hydrogen-based array constructor code,
to pass through the actual type feedback cell, rather than
Revision: 15005
Author: yang...@chromium.org
Date: Fri Jun 7 06:27:03 2013
Log: Enable map dependency to in-flight compilation info.
R=u...@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/16542003
http://code.google.com/p/v8/source/detail?r=15005
Modified:
/bra
Committed patchset #3 manually as r15005 (presubmit successful).
https://chromiumcodereview.appspot.com/16542003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
So I disabled CPU throttling as Dan suggested and ran full Dromaeo DOM Core
test
suite using src/tools/perf/run_measurement three times with each of the
following builds:
1) With patch set #9: generated assembly code checks if profiler is enabled
and
calls the callback directly as before if n
Reviewers: ulan,
Description:
Fix parallel recompilation wrt initial object/array map dependency.
R=u...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/16641002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-
Updates:
Status: WorkingAsIntended
Comment #1 on issue 2708 by wi...@igalia.com: ES6 yield shouldn't require a
value
http://code.google.com/p/v8/issues/detail?id=2708
From the 14 May 2013 draft, section 13.6:
YieldExpression :
yield YieldDelegatoropt [Lexical goal InputElementReg
Reviewers: ulan,
Description:
Fix parallel recompilation wrt transition maps dependency.
R=u...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/15896038/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-codegen-a
Reviewers: Jakob,
Message:
PTAL
Description:
Lists tests to skip. The test expectations file will be assigned to the
run_webkit_tests script using the additional expectations flag.
The tests listed in this file will be maintained manually. The list contains
tests that typically fail on the V8 w
1 - 100 of 152 matches
Mail list logo
