https://codereview.chromium.org/22935005/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/22935005/diff/1/src/x64/full-codegen-x64.cc#newcode4425
src/x64/full-codegen-x64.cc:4425: if (expr->op() == Token::INC) {
Thanks for the comments.
Committed as r16252.
https://codereview.chromium.org/23072023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 16252
Author: plin...@gmail.com
Date: Tue Aug 20 22:10:20 2013 UTC
Log: MIPS: Fix bug that prevents JALR to JAL optimizations.
TEST=
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/23072023
Patch from Dusan Milosavljevic .
http://code.google.com/p/v8/s
Added some more tests, too; still interested in your thoughts on how much
coverage is enough here.
https://codereview.chromium.org/22962009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Go
https://codereview.chromium.org/22962009/diff/5001/test/cctest/test-object-observe.cc
File test/cctest/test-object-observe.cc (right):
https://codereview.chromium.org/22962009/diff/5001/test/cctest/test-object-observe.cc#newcode479
test/cctest/test-object-observe.cc:479: TEST(ObserveNamedAccessC
Updates:
Cc: verwa...@chromium.org
Comment #5 on issue 2843 by jkumme...@chromium.org: Flaky error on the 3.20
branch
http://code.google.com/p/v8/issues/detail?id=2843
There are two aspects to this:
(1) Yes, environment liveness. This is another case where we're not
visiting the en
Committed manually as r16251.
https://codereview.chromium.org/22815014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Revision: 16251
Author: pal...@homejinni.com
Date: Tue Aug 20 18:07:22 2013 UTC
Log: MIPS: Remove platform-specific dead code for KeyedStores
Port r16227 (02df4098)
BUG=
Review URL: https://codereview.chromium.org/22815014
http://code.google.com/p/v8/source/detail?r=16251
Modified:
lgtm
https://codereview.chromium.org/22815014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Paul Lind, kisg, kilvadyb, danno,
Message:
PTAL.
Description:
MIPS: Remove platform-specific dead code for KeyedStores
Port r16227 (02df4098)
BUG=
Please review this at https://codereview.chromium.org/22815014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affec
Reviewers: Yang,
Description:
In reporting step-in positions be more accurate with a position the debugger
paused at
Please review this at https://codereview.chromium.org/23264015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/debug.cc
M src/runtime.c
First comment about the API names. Looping in Andreas and Sven about the
naming.
https://codereview.chromium.org/23182003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23182003/diff/1/include/v8.h#newcode3008
include/v8.h:3008: void SetNativeAccessor(Handle na
About testing: Can you make sure that all of the code paths > are hit that
you've added?
The situation is the following: everything has good coverage except for
X87TOSToI and TruncateX87TOSToI, which is atm dead code, therefore not
testable.
It will be extensively used and covered in the com
Reviewers: Michael Starzinger,
Description:
Fix scoping of function declarations in eval inside non-trivial local scope
R=mstarzin...@chromium.org
BUG=v8:2594
Please review this at https://codereview.chromium.org/22901010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affecte
Very close, I like this CL a lot.
About testing: Can you make sure that all of the code paths are hit that
you've
added? i.e. add single OS::DebugBreaks one after another in
macro-assembler-ia32.cc to the different branches you've created, and run
the
unit tests to make sure that each one g
Hi Haitao,
Thanks for your continued iteration on this CL. I know it's a lot of work,
and I
appreciate you persistence and patience working through some of these trick
issues. I really want to make sure that we get this right, even if it takes
longer, since it will be the foundation of a lot o
https://chromiumcodereview.appspot.com/22935005/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://chromiumcodereview.appspot.com/22935005/diff/1/src/x64/full-codegen-x64.cc#newcode4425
src/x64/full-codegen-x64.cc:4425: if (expr->op() == Token::INC) {
On 2013/08
Reviewers: Sven Panne, Michael Starzinger,
Message:
here's a first round of this
it more or less works, but I'm going to add a bunch more tests once the
approach
etc is commented on/lgtm'd
Description:
js accessor creation on Template
R=svenpa...@chromium.org, mstarzin...@chromium.org
BUG=
Updates:
Status: WorkingAsIntended
Comment #5 on issue 2848 by mstarzin...@chromium.org: cctest:
TestJSONStringifyAccessCheck() fails with empty handle in r16208
http://code.google.com/p/v8/issues/detail?id=2848
The V8 wiki explains how to run tests through the test harness and I adde
Revision: 16250
Author: mstarzin...@chromium.org
Date: Tue Aug 20 15:20:45 2013 UTC
Log: Edited wiki page Testing through web user interface.
http://code.google.com/p/v8/source/detail?r=16250
Modified:
/wiki/Testing.wiki
===
--- /wiki/Testing.wiki
On 2013/08/13 13:04:20, danno wrote:
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.cc#newcode281
src/ia32/macro-assembler-ia
danno, thanks a lot for the review. I appreciate it. I know you are quite
busy
preparing Chrome 30.
I will think about the best approach to separate policy and mechanism to
address
the problem that SMI macro instructions could be called by Lithium and
FullCodeGen/Stubs and make 31-bit SMI in
LGTM, I'll commit this for you.
https://codereview.chromium.org/23072023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
Again, thanks for the patch. Two more high-level comments:
- There are several, disparate changes in the CL. It would be very helpful
to
break it up into several CLs with a more detailed description of each... it
also
make bisection of potential problems easier in the unlikely case that there
https://codereview.chromium.org/22935005/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/22935005/diff/1/src/x64/full-codegen-x64.cc#newcode4425
src/x64/full-codegen-x64.cc:4425: if (expr->op() == Token::INC) {
Thanks for the review an
Reviewers: danno, Paul Lind, palfia, kisg,
Description:
MIPS: Fix bug that prevents JALR to JAL optimizations.
TEST=
BUG=
Please review this at https://codereview.chromium.org/23072023/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/assembler-mips
Committed patchset #2 manually as r16249.
https://codereview.chromium.org/22964004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16249
Author: jkumme...@chromium.org
Date: Tue Aug 20 13:57:01 2013 UTC
Log: Fix a bug in Div when all uses are truncating
Refine the related test cases to cover truncating cases
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/22964004
Patch from
Committed patchset #2 manually as r16248.
https://codereview.chromium.org/22390008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16248
Author: dslo...@chromium.org
Date: Tue Aug 20 13:55:52 2013 UTC
Log: Promote ArrayBuffer, DataView and typed arrays to
non-experimental.
The primary reason for this change is to bake these guys into the
snapshot.
Flag definitions (--harmony-typed-arrays, --harmony-a
Good catch, thanks for the fix! LGTM with comment:
The ARM version can be turned into a one-liner too, see patch set 2. (The
diff
view between patch sets is screwed up due to rebasing, sorry about that.)
I'll land this for you.
https://codereview.chromium.org/22964004/diff/1/test/mjsunit/sh
Updates:
Status: Fixed
Comment #8 on issue 435 by a...@chromium.org: The .length property of a
function always returns zero
http://code.google.com/p/v8/issues/detail?id=435
I'm closing this now.
V8 added support for setting the length of a FunctionTemplate and the Blink
bindings us
Committed patchset #2 manually as r16247.
https://codereview.chromium.org/23067008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Thanks for the review. Sure I will wait for that.
https://codereview.chromium.org/22350005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
Revision: 16247
Author: yang...@chromium.org
Date: Tue Aug 20 13:20:40 2013 UTC
Log: Add warning to cctest when running multiple tests in sequence.
R=mstarzin...@chromium.org
BUG=v8:2848
Review URL: https://codereview.chromium.org/23067008
http://code.google.com/p/v8/source/detail?r=1
danno, thanks for refining the comments.
https://codereview.chromium.org/22348005/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://codereview.chromium.org/22348005/diff/7001/src/x64/macro-assembler-x64.h#newcode724
src/x64/macro-assembler-x64.h:724: //
Committed patchset #6 manually as r16246.
https://codereview.chromium.org/20781007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16246
Author: ol...@chromium.org
Date: Tue Aug 20 13:01:54 2013 UTC
Log: Add X87 implementations for Integer32ToDouble, DoubleToI,
DoubleToSmi
Additionally refactor the X87Stack tracking
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/20781007
ht
On 2013/08/20 12:29:19, Benedikt Meurer wrote:
On 2013/08/20 12:25:05, Yury Semikhatsky wrote:
> On 2013/08/20 12:13:02, Benedikt Meurer wrote:
> > On 2013/08/20 12:07:36, Yury Semikhatsky wrote:
> > > On 2013/08/20 11:58:56, Benedikt Meurer wrote:
> > > > What's the benefit of this change, other
On 2013/08/20 12:25:05, Yury Semikhatsky wrote:
On 2013/08/20 12:13:02, Benedikt Meurer wrote:
> On 2013/08/20 12:07:36, Yury Semikhatsky wrote:
> > On 2013/08/20 11:58:56, Benedikt Meurer wrote:
> > > What's the benefit of this change, other than trying to somehow
unify
the
> code
> > > path
On 2013/08/20 12:13:02, Benedikt Meurer wrote:
On 2013/08/20 12:07:36, Yury Semikhatsky wrote:
> On 2013/08/20 11:58:56, Benedikt Meurer wrote:
> > What's the benefit of this change, other than trying to somehow unify
the
code
> > paths?
>
> Just unification of the code no obvious performance
LGTM with a nit.
https://codereview.chromium.org/23067008/diff/1/test/cctest/cctest.cc
File test/cctest/cctest.cc (right):
https://codereview.chromium.org/23067008/diff/1/test/cctest/cctest.cc#newcode109
test/cctest/cctest.cc:109: void SuggestTestHarness(int tests) {
nit: This should be static.
On 2013/08/20 12:07:36, Yury Semikhatsky wrote:
On 2013/08/20 11:58:56, Benedikt Meurer wrote:
> What's the benefit of this change, other than trying to somehow unify
the
code
> paths?
Just unification of the code no obvious performance gains at the moment.
After
this change all but Wind
Reviewers: Michael Starzinger,
Description:
Add warning to cctest when running multiple tests in sequence.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23067008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cc
On 2013/08/20 11:58:56, Benedikt Meurer wrote:
What's the benefit of this change, other than trying to somehow unify the
code
paths?
Just unification of the code no obvious performance gains at the moment.
After
this change all but Windows port use the same mechanism based on signals.
htt
lgtm
https://chromiumcodereview.appspot.com/23129003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
What's the benefit of this change, other than trying to somehow unify the
code
paths?
https://chromiumcodereview.appspot.com/23115005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
https://chromiumcodereview.appspot.com/23156006/diff/1/src/globals.h
File src/globals.h (right):
https://chromiumcodereview.appspot.com/23156006/diff/1/src/globals.h#newcode170
src/globals.h:170: #define V8_BETTER_OPERAND_ON_RIGHT
I don't like this #define. Why not switch the order for the
XXXMe
Reviewers: Sven Panne, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Improve detection of C++11 features.
Also improve detection of V8_INFINITY while we're at it.
Please review this at https://chromiumcodereview.appspot.com/23323003/
SVN Base: https://v8.googlecode.com/svn/branches/blee
Committed patchset #2 manually as r16245.
https://codereview.chromium.org/23330005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16245
Author: dslo...@chromium.org
Date: Tue Aug 20 11:14:56 2013 UTC
Log: Replace OS::MemCopy with memcpy in typed array initialization.
This is an attempt to fix a weird perf regression on MacOS X 10.6 bot.
Perf regression is not reproducible on MacOS X 10.8.
This differenc
LGTM
On a side note: The system memcpy() is pretty much optimal nowadays in
nearly
all cases, but we still try to be smarter? :-)
https://chromiumcodereview.appspot.com/23330005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this me
Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as r16244.
Description:
Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs
revealed by
them.".
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
-
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Replace OS::MemCopy with memcpy in typed array initialization.
This is an attempt to fix a weird perf regression on MacOS X 10.6 bot.
Perf regression is not reproducible on MacOS X 10.8.
This difference in memory-copying routines is the onl
Updates:
Status: WorkingAsIntended
Comment #2 on issue 2849 by jkumme...@chromium.org: ArrayBuffer::New cause
CHECK(object->IsJSFunction()) failed
http://code.google.com/p/v8/issues/detail?id=2849
(No comment was entered for this change.)
--
You received this message because this pro
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16243.
Description:
Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs
revealed by
them."
This reverts commit r16232 for breaking the
tools/gen-postmortem-metadata.py script. Will reland without the
objects.{
Revision: 16242
Author: yang...@chromium.org
Date: Tue Aug 20 10:46:02 2013 UTC
Log: Remove access-check-failed callback after test.
BUG=v8:2848
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/22802013
http://code.google.com/p/v8/source/detail?r=16242
Modified:
/
Committed patchset #2 manually as r16242.
https://codereview.chromium.org/22802013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Comment #1 on issue 2852 by jkumme...@chromium.org: Latest V8 engine
library for Android application and issue build errors (version 3.20.15)
http://code.google.com/p/v8/issues/detail?id=2852
Issue 2850 has been merged into this issue.
--
You received this message because this project is con
Updates:
Status: Duplicate
Mergedinto: 2852
Comment #1 on issue 2850 by jkumme...@chromium.org: V8 3.20.15 Error
http://code.google.com/p/v8/issues/detail?id=2850
(No comment was entered for this change.)
--
You received this message because this project is configured to send al
On 2013/08/20 09:51:26, jochen wrote:
https://codereview.chromium.org/23304005/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
src/i18n.js:29: // ECMAScript 402 API implementation is broken into
separate
files for
On 2013/08
https://codereview.chromium.org/23304005/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
src/i18n.js:29: // ECMAScript 402 API implementation is broken into
separate files for
On 2013/08/20 09:49:29, Michael Starzinger wrote:
Th
LGTM.
https://codereview.chromium.org/23304005/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
src/i18n.js:29: // ECMAScript 402 API implementation is broken into
separate files for
This file is rubber-stamped under the assumpti
I left some comments how we could clean up and unify the code even further.
I
stopped after line 5572. WDYT?
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22925004/diff/3001/src/heap.cc#newcode2844
src/heap.cc:2844: Al
lgtm
https://codereview.chromium.org/22802013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16241
Author: bmeu...@chromium.org
Date: Tue Aug 20 09:37:21 2013 UTC
Log: Visual Studio 2012 and later support the C++11 final keyword.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/23128007
http://code.google.com/p/v8/source/detail?r=16241
Modifie
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16241.
Description:
Visual Studio 2012 and later support the C++11 final keyword.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16241
Please review this at https://codereview.chromium.org/2
Added comments. Looking good, minus the missing empty-handle-check.
https://codereview.chromium.org/22934006/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/22934006/diff/1/src/objects.cc#newcode5710
src/objects.cc:5710:
(IsFastObjectElementsKind(copy->GetElem
LGTM after offline discussion, but as said, someone with better knowledge of
these internals should have a look at this
https://chromiumcodereview.appspot.com/22911018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Comment #4 on issue 2848 by i...@bnoordhuis.nl: cctest:
TestJSONStringifyAccessCheck() fails with empty handle in r16208
http://code.google.com/p/v8/issues/detail?id=2848
Can I suggest that you add a CONTRIBUTING file in the top-level directory
that explains things like that? Something tha
Status: New
Owner:
New issue 2852 by shinyh2...@gmail.com: Latest V8 engine library for
Android application and issue build errors (version 3.20.15)
http://code.google.com/p/v8/issues/detail?id=2852
Latest V8 engine (3.20.15) Android made for the library and then apply to
eclipse the f
Reviewers: dcarney, Michael Starzinger,
Description:
Snapshot i18n Javascript code
BUG=v8:2745
R=mstarzin...@chromium.org,dcar...@chromium.org
Please review this at https://codereview.chromium.org/23304005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src
Comment #3 on issue 2848 by mstarzin...@chromium.org: cctest:
TestJSONStringifyAccessCheck() fails with empty handle in r16208
http://code.google.com/p/v8/issues/detail?id=2848
Yes, it is a known problem that running a set of tests directly through
the "cctest" binary in one process breaks
Reviewers: alph, loislo, Benedikt Meurer, Sven Panne,
Description:
Use signals for cpu profiling on Mac OS X
A while ago in r2315 Mac OS X cpu profiler implementation was changed to
pause
sampled thread instead of sending SIGPROF signal. That was done because at
that
point profiler send the
Revision: 16240
Author: mstarzin...@chromium.org
Date: Tue Aug 20 08:53:34 2013 UTC
Log: Consistently use CompilationInfo::AbortOptimization.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/22832002
http://code.google.com/p/v8/source/detail?r=16240
Modified:
/bran
Committed patchset #1 manually as r16240.
https://codereview.chromium.org/22832002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16239
Author: joc...@chromium.org
Date: Tue Aug 20 08:46:36 2013 UTC
Log: Move i18n break iterator C++ code to runtime
BUG=v8:2745
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/22764007
http://code.google.com/p/v8/source/detail?r=16239
Deleted:
/br
LGTM with comments.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393
src/hydrogen-instructions.h:3393: bool SameConstantObject(HCo
Updates:
Cc: mstarzin...@chromium.org
Comment #2 on issue 2848 by yang...@chromium.org: cctest:
TestJSONStringifyAccessCheck() fails with empty handle in r16208
http://code.google.com/p/v8/issues/detail?id=2848
https://codereview.chromium.org/22802013/ fixes part of the issue. However
Committed patchset #4 manually as r16239.
https://codereview.chromium.org/22764007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16238
Author: bmeu...@chromium.org
Date: Tue Aug 20 08:29:21 2013 UTC
Log: Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp.
R=jkumme...@chromium.org, svenpa...@chromium.org
Review URL: https://codereview.chromium.org/23283010
http://code.google.com/p/v8/source/det
Committed patchset #3 manually as r16238.
https://codereview.chromium.org/23283010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp#newcode791
tools/gyp/v8.gyp:791: 'V8_OS_BSD=1',
On 2013/08/20 08:27:26, Jakob wrote:
really?
Nope, copy&paste, fixed.
https:/
LGTM.
As discussed offline, we might want to move this to build/features.gypi if
other
targets need those defines as well, but doing so has other drawbacks, so
let's
keep them in v8.gyp for now.
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (righ
Committed patchset #1 manually as r16237.
https://codereview.chromium.org/22927014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16237
Author: joc...@chromium.org
Date: Tue Aug 20 08:17:43 2013 UTC
Log: Fix null handle deref in InternalDateFormat
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/22927014
http://code.google.com/p/v8/source/detail?r=16237
Modified:
/branches/bleed
Revision: 16236
Author: bmeu...@chromium.org
Date: Tue Aug 20 08:14:19 2013 UTC
Log: Fix non-Xcode build on Mac with clang.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/22793008
http://code.google.com/p/v8/source/detail?r=16236
Modified:
/branches/bleeding_
LGTM.
https://codereview.chromium.org/22927014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16236.
Description:
Fix non-Xcode build on Mac with clang.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16236
Please review this at https://codereview.chromium.org/22793008/
SVN Base: htt
Revision: 16235
Author: jkumme...@chromium.org
Date: Tue Aug 20 08:12:19 2013 UTC
Log: Avoid -O3 in nacl as it does not play well with -W.
Also cleans up some uninitialized data I saw while investigating
the problem.
R=jkumme...@chromium.org, machenb...@chromium.org
Review URL: https
Committed patchset #1 manually as r16235.
https://codereview.chromium.org/23119004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Committed patchset #2 manually as r16234.
https://codereview.chromium.org/22432009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16234
Author: joc...@chromium.org
Date: Tue Aug 20 08:07:52 2013 UTC
Log: Don't use Persistent in runtime
R=dcar...@chromium.org, mstarzin...@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/22432009
http://code.google.com/p/v8/source/detail?r=16234
Modifie
Revision: 16233
Author: joc...@chromium.org
Date: Tue Aug 20 08:06:48 2013 UTC
Log: During bootstrapping, the script's name is not necessarily set.
So check whether the name is actually set before printing it when
throwing an exception.
BUG=none
R=mstarzin...@chromium.org
Review URL:
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16233.
Description:
During bootstrapping, the script's name is not necessarily set.
So check whether the name is actually set before printing it when
throwing an exception.
BUG=none
R=mstarzin...@chromium.org
Committed
Indeed, there's no CQ for V8. I'll land this for you.
https://codereview.chromium.org/23119004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe f
Reviewers: Michael Starzinger,
Description:
Fix null handle deref in InternalDateFormat
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/22927014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/run
Committed patchset #2 manually as r16232.
https://codereview.chromium.org/23064017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
On 2013/08/19 18:20:01, Benedikt Meurer wrote:
On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
> LGTM!
> I think we should make the use of FINAL and OVERRIDE mandatory in all
new
code
> (except additions to public API)
Hm, looking through the code again, we should probably use V8_FI
99 matches
Mail list logo
