[v8-dev] Re: Issue 2879 in v8: 3.21.13: Windows build broken

Updates: Status: Accepted Comment #1 on issue 2879 by svenpa...@chromium.org: 3.21.13: Windows build broken http://code.google.com/p/v8/issues/detail?id=2879 Could you check if changing the line 3739 in include/v8.h from class V8_EXPORT ResourceConstraints { to class Resource

[v8-dev] Re: Issue 2880 in v8: PutValue to primitives should throw in strict mode

Updates: Status: Invalid Comment #1 on issue 2880 by a...@chromium.org: PutValue to primitives should throw in strict mode http://code.google.com/p/v8/issues/detail?id=2880 Sorry, this is invalid. Here is why: http://people.mozilla.org/~jorendorff/es6-draft.html#sec-6.2.4.2 5. Is fa

[v8-dev] Re: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (issue 23654026)

On 2013/09/11 13:37:02, Yang wrote: On 2013/09/11 11:34:14, Jakob wrote: > Redirecting to Yang. We use cvtsi2sd in a couple of other places as well. Would it make sense to do that elsewhere as well? Or even bundle xorps and cvtsi2sd into a MacroAssembler method and use that everywhere? S

[v8-dev] Issue 2880 in v8: PutValue to primitives should throw in strict mode

Status: Accepted Owner: CC: rossb...@chromium.org, rafa...@chromium.org, a...@chromium.org Labels: Type-Bug Priority-Medium ES5 New issue 2880 by a...@chromium.org: PutValue to primitives should throw in strict mode http://code.google.com/p/v8/issues/detail?id=2880 function f() { 'us

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2412 src/hydrogen.h:2412: bool found = false; Hence the version I attached in my previous comment ;) On 2013/09/11 15:01:49, rossberg

[v8-dev] Re: Update behavior of inspection of |acceptList| during Object.observe: (issue 23464058)

PTAL https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js#newcode123 test/mjsunit/harmony/object-observe.js:123: ['

[v8-dev] Re: Update behavior of inspection of |acceptList| during Object.observe: (issue 23464058)

Sold. Changed (back). On Wed, Sep 11, 2013 at 6:27 AM, Erik Arvidsson wrote: > I'm with Andreas on this. It seems more consistent to allow an empty list. > Sure, it doesn't do anything but neither does array.push(). > > > On Wed, Sep 11, 2013 at 9:24 AM, Rafael Weinstein wrote: > >> The main mo

[v8-dev] Issue 2879 in v8: 3.21.13: Windows build broken

Status: New Owner: New issue 2879 by bitcor...@gmail.com: 3.21.13: Windows build broken http://code.google.com/p/v8/issues/detail?id=2879 Please see the attached build log. Thanks! Attachments: BuildLog.txt 145 KB -- You received this message because this project is configured to

[v8-dev] Revert "Fix leftover usage of OS::Allocate()." (issue 23691049)

Reviewers: Benedikt Meurer, Message: Committed patchset #1 manually as r16664 (presubmit successful). Description: Revert "Fix leftover usage of OS::Allocate()." TBR=bmeu...@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16664 Please review this at https://codereview.chro

[v8-dev] Re: Add access check for observed objects (issue 22962009)

Committed patchset #9 manually as r16663 (presubmit successful). https://codereview.chromium.org/22962009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r16663 committed - Add access check for observed objects...

Revision: 16663 Author: ad...@chromium.org Date: Wed Sep 11 20:03:54 2013 UTC Log: Add access check for observed objects This change is mostly straightforward: for 'normal' sorts of change records, simply don't deliver a changeRecord to a given observer callback if an access the cal

[v8-dev] Re: Add access check for observed objects (issue 22962009)

On 2013/08/22 11:14:09, rossberg wrote: > Okay, added everything I think we needed. The tests have gotten a little > verbose; let me know if you'd like them refactored before commit. LGTM, except that, yes, it would be good if you could refactor the tests to avoid the repetition. Can't you ju

[v8-dev] [v8] r16664 committed - Revert "Fix leftover usage of OS::Allocate()."...

Revision: 16664 Author: mstarzin...@chromium.org Date: Wed Sep 11 20:04:51 2013 UTC Log: Revert "Fix leftover usage of OS::Allocate()." TBR=bmeu...@chromium.org Review URL: https://codereview.chromium.org/23691049 http://code.google.com/p/v8/source/detail?r=16664 Modified: /branches

[v8-dev] Re: Issue 2804 in v8: Generic use of __proto__ accessor not allowed

Comment #5 on issue 2804 by erights: Generic use of __proto__ accessor not allowed http://code.google.com/p/v8/issues/detail?id=2804 confirmed -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification

[v8-dev] Re: Issue 2743 in v8: `in` operator performance

Updates: Cc: da...@chromium.org rossb...@chromium.org mstarzin...@chromium.org Comment #1 on issue 2743 by a...@chromium.org: `in` operator performance http://code.google.com/p/v8/issues/detail?id=2743 This is starting to hurt us too. We need to do a hasOwnProperty check but it turned

[v8-dev] Re: Issue 2743 in v8: `in` operator performance

Updates: Labels: Type-FeatureRequest Priority-Medium Comment #2 on issue 2743 by mstarzin...@chromium.org: `in` operator performance http://code.google.com/p/v8/issues/detail?id=2743 Related to issue 1956 as well. -- You received this message because this project is configured to sen

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

lgtm https://codereview.chromium.org/23609020/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Revert r16648, r16641, r16638 and r16637. (issue 23970004)

Committed patchset #1 manually as r16662 (presubmit successful). https://codereview.chromium.org/23970004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Revert r16648, r16641, r16638 and r16637. (issue 23970004)

Reviewers: Benedikt Meurer, Description: Revert r16648, r16641, r16638 and r16637. Original descriptions were: - "Refactor and cleanup VirtualMemory." - "Fix typo." - "Deuglify V8_INLINE and V8_NOINLINE." - "Don't align size on allocation granularity for unaligned ReserveRegion calls." Reasons

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

On 2013/09/11 10:34:07, rossberg wrote: https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2309 src/hydrogen.h:2309: class HUnique V8_FINAL { I think this should live somewhere else (

[v8-dev] Re: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (issue 23620036)

LGTM. https://codereview.chromium.org/23620036/diff/10001/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/23620036/diff/10001/src/stub-cache.h#newcode411 src/stub-cache.h:411: static const int kInterceptorArgsNameIndex = 0; nit: Maybe even add a short one-line co

[v8-dev] Issue 2878 in v8: cctest/test-alloc/CodeRange flaky

Status: New Owner: CC: bmeu...@chromium.org Labels: Type-Bug Priority-Medium OS-Windows New issue 2878 by machenb...@chromium.org: cctest/test-alloc/CodeRange flaky http://code.google.com/p/v8/issues/detail?id=2878 cctest/test-alloc/CodeRange became flaky on windows around revision 16640.

[v8-dev] [v8] r16661 committed - Revert "Unify computation of load stubs in stub cache."...

Revision: 16661 Author: mstarzin...@chromium.org Date: Wed Sep 11 16:27:41 2013 UTC Log: Revert "Unify computation of load stubs in stub cache." TBR=verwa...@chromium.org Review URL: https://codereview.chromium.org/24095005 http://code.google.com/p/v8/source/detail?r=16661 Modified:

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

On 2013/09/11 15:27:52, Toon Verwaest wrote: https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2412 src/hydrogen.h:2412: bool found = false; Hence the version I attached in my previo

[v8-dev] Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". (issue 23435006)

Reviewers: Toon Verwaest, Description: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". This was reverted due to performance regressions on Sunspider and other benchmarks due to double GCs caused by the trampoline. R=verwa...@chromium.org Please review this at

[v8-dev] Re: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (issue 23620036)

Thanks for having a look! https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc#newcode403 src/ia32/stub-cache-ia32.cc:403: STATIC_ASSERT(PropertyCal

[v8-dev] Revert "Unify computation of load stubs in stub cache." (issue 24095005)

Reviewers: Toon Verwaest, Message: Committed patchset #1 manually as r16661. Description: Revert "Unify computation of load stubs in stub cache." TBR=verwa...@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16661 Please review this at https://codereview.chromium.org/240950

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2412 src/hydrogen.h:2412: bool found = false; On 2013/09/11 14:24:11, Toon Verwaest wrote: This version double-checks every entry tho

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

On Wed, Sep 11, 2013 at 4:11 PM, wrote: > On 2013/09/11 13:53:45, titzer wrote: > >> On 2013/09/11 10:34:07, rossberg wrote: >> > https://codereview.chromium.**org/23609020/diff/1/src/**hydrogen.h >> > File src/hydrogen.h (right): >>

[v8-dev] Remove indirection when calling Runtime_StackGuard. (issue 23496046)

Reviewers: ulan, Description: Remove indirection when calling Runtime_StackGuard. R=u...@chromium.org BUG= Please review this at https://codereview.chromium.org/23496046/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+10, -29 lines): M src/arm/full-codegen-a

[v8-dev] Re: Unify computation of load stubs in stub cache. (issue 23647011)

Committed patchset #2 manually as r16660 (presubmit successful). https://codereview.chromium.org/23647011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Issue 2804 in v8: Generic use of __proto__ accessor not allowed

Updates: Cc: erig...@google.com Comment #4 on issue 2804 by a...@chromium.org: Generic use of __proto__ accessor not allowed http://code.google.com/p/v8/issues/detail?id=2804 It is not a security concern any more. We had some discussion regarding this in TC39 and the initial concern

[v8-dev] [v8] r16660 committed - Unify computation of load stubs in stub cache....

Revision: 16660 Author: mstarzin...@chromium.org Date: Wed Sep 11 15:44:09 2013 UTC Log: Unify computation of load stubs in stub cache. R=verwa...@chromium.org Review URL: https://codereview.chromium.org/23647011 http://code.google.com/p/v8/source/detail?r=16660 Modified: /branches/

[v8-dev] Re: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". (issue 23435006)

Committed patchset #1 manually as r16659 (presubmit successful). https://codereview.chromium.org/23435006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r16659 committed - Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreA...

Revision: 16659 Author: mstarzin...@chromium.org Date: Wed Sep 11 15:16:56 2013 UTC Log: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". This was reverted due to performance regressions on Sunspider and other benchmarks due to double GCs caused by t

[v8-dev] [v8] r16658 committed - Make handle dereference check more precise....

Revision: 16658 Author: yang...@chromium.org Date: Wed Sep 11 15:12:27 2013 UTC Log: Make handle dereference check more precise. R=mstarzin...@chromium.org BUG= Review URL: https://codereview.chromium.org/23578022 http://code.google.com/p/v8/source/detail?r=16658 Modified: /branches

[v8-dev] Re: Fix MSVC compiler warning after commit r16612. (issue 23534052)

LGTM (rubber-stamped). https://codereview.chromium.org/23534052/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] Re: Enable preaging of code objects for low-memory devices. (issue 23480031)

Updated for all architectures. I'll report back with the performance impact if enabled for all devices. https://codereview.chromium.org/23480031/diff/22001/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): https://codereview.chromium.org/23480031/diff/22001/src/ia32/codegen-ia3

[v8-dev] Re: Unify computation of load stubs in stub cache. (issue 23647011)

Thanks for the review. Addressed comments. Landing. https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/23647011/diff/1/src/stub-cache.h#newcode649 src/stub-cache.h:649: case Code::STORE_IC: return GDBJITInterface::LOAD

[v8-dev] Re: Issue 2804 in v8: Generic use of __proto__ accessor not allowed

Comment #3 on issue 2804 by ndgau...@gmail.com: Generic use of __proto__ accessor not allowed http://code.google.com/p/v8/issues/detail?id=2804 I agree. This is very frustrating. If you have an object that does not inherit from Object.prototype, you cannot set the prototype since the set

[v8-dev] Re: Revert "Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes". (issue 23435006)

lgtm (rubberstamp) https://codereview.chromium.org/23435006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

[v8-dev] Re: Make handle dereference check more precise. (issue 23578022)

Committed patchset #1 manually as r16658 (presubmit successful). https://codereview.chromium.org/23578022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Merged r16656 into trunk branch. (issue 23981007)

PTAL. https://codereview.chromium.org/23981007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Merged r16656 into trunk branch. (issue 23981007)

Reviewers: Yang, Description: Merged r16656 into trunk branch. MIPS: thread isolate for EntryHookTrampoline. R=yang...@chromium.org BUG= Please review this at https://codereview.chromium.org/23981007/ SVN Base: https://v8.googlecode.com/svn/trunk Affected files (+4, -1 lines): M src/mips/c

[v8-dev] Re: MIPS: remove most uses of Isolate::Current in arch specific files. (issue 24108002)

Committed as r16657. https://codereview.chromium.org/24108002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] [v8] r16657 committed - MIPS: remove most uses of Isolate::Current in arch specific files....

Revision: 16657 Author: pal...@homejinni.com Date: Wed Sep 11 14:36:27 2013 UTC Log: MIPS: remove most uses of Isolate::Current in arch specific files. Port r16643 (b818da5) BUG= R=gerg...@homejinni.com Review URL: https://codereview.chromium.org/24108002 Patch from Balazs Kilvady .

[v8-dev] Re: MIPS: remove most uses of Isolate::Current in arch specific files. (issue 24108002)

LGTM https://codereview.chromium.org/24108002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] [v8] r16656 committed - MIPS: thread isolate for EntryHookTrampoline....

Revision: 16656 Author: pal...@homejinni.com Date: Wed Sep 11 14:15:18 2013 UTC Log: MIPS: thread isolate for EntryHookTrampoline. Port r16630 (e045054) BUG= R=gerg...@homejinni.com Review URL: https://codereview.chromium.org/23503050 Patch from Balazs Kilvady . http://code.google.c

[v8-dev] Re: MIPS: thread isolate for EntryHookTrampoline. (issue 23503050)

Committed as r16656. https://codereview.chromium.org/23503050/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2412 src/hydrogen.h:2412: bool found = false; This version double-checks every entry though; since you don't increment to the next val

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

On 2013/09/11 13:53:45, titzer wrote: On 2013/09/11 10:34:07, rossberg wrote: > https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h > File src/hydrogen.h (right): > > https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2309 > src/hydrogen.h:2309: class HUnique V8_F

[v8-dev] Re: remove OS::StackWalk (issue 23703013)

LGTM. https://chromiumcodereview.appspot.com/23703013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Revert "Handlify JSObject::AddProperty method" for performance. (issue 23464069)

lgtm https://codereview.chromium.org/23464069/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: First implementation of HUnique and HUniqueSet, which is supposed to replace UniqueValueId. (issue 23609020)

On 2013/09/11 10:34:07, rossberg wrote: https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2309 src/hydrogen.h:2309: class HUnique V8_FINAL { I think this should live somewhere else (

[v8-dev] [v8] r16655 committed - Revert "Handlify JSObject::AddProperty method" for performance....

Revision: 16655 Author: mstarzin...@chromium.org Date: Wed Sep 11 13:42:57 2013 UTC Log: Revert "Handlify JSObject::AddProperty method" for performance. TBR=verwa...@chromium.org Review URL: https://codereview.chromium.org/23464069 http://code.google.com/p/v8/source/detail?r=16655 Mo

[v8-dev] Re: Make handle dereference check more precise. (issue 23578022)

LGTM. https://codereview.chromium.org/23578022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Revert "Handlify JSObject::AddProperty method" for performance. (issue 23464069)

Reviewers: Toon Verwaest, Message: Committed patchset #1 manually as r16655 (presubmit successful). Description: Revert "Handlify JSObject::AddProperty method" for performance. TBR=verwa...@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16655 Please review this at https:/

[v8-dev] Re: Issue 2856 in v8: Implement Harmony Array comprehensions

Updates: Cc: mstarzin...@chromium.org Comment #2 on issue 2856 by rossb...@chromium.org: Implement Harmony Array comprehensions http://code.google.com/p/v8/issues/detail?id=2856 (No comment was entered for this change.) -- You received this message because this project is configured

[v8-dev] Re: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (issue 23654026)

Could you describe the underlying reason why zeroing out things first makes this faster? The upper half remained unchanged before. It would be good to know the actual pattern of instructions to avoid. https://codereview.chromium.org/23654026/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 2804 in v8: Generic use of __proto__ accessor not allowed

Updates: Owner: mstarzin...@chromium.org Labels: Type-FeatureRequest Comment #2 on issue 2804 by rossb...@chromium.org: Generic use of __proto__ accessor not allowed http://code.google.com/p/v8/issues/detail?id=2804 The reason for this behaviour is that poisoning the setter (i

[v8-dev] Re: To diagnose chromium bug 284577, some additional CHECKS. TODOs are (issue 23936007)

Committed patchset #2 manually as r16654 (presubmit successful). https://codereview.chromium.org/23936007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r16654 committed - To diagnose chromium bug 284577, some additional CHECKS. TODOs are...

Revision: 16654 Author: mvstan...@chromium.org Date: Wed Sep 11 13:39:11 2013 UTC Log: To diagnose chromium bug 284577, some additional CHECKS. TODOs are added so these can be backed out once the cause of the bug is determined. BUG= R=hpa...@chromium.org Review URL: https://codereview

[v8-dev] Re: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (issue 23654026)

On 2013/09/11 11:34:14, Jakob wrote: Redirecting to Yang. We use cvtsi2sd in a couple of other places as well. Would it make sense to do that elsewhere as well? Or even bundle xorps and cvtsi2sd into a MacroAssembler method and use that everywhere? https://codereview.chromium.org/23654026

[v8-dev] Re: remove getcurrent from stubs (issue 23756009)

lgtm https://codereview.chromium.org/23756009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Delete useless CompileStoreGlobal (issue 23881004)

Committed patchset #2 manually as r16653 (presubmit successful). https://chromiumcodereview.appspot.com/23881004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r16653 committed - Delete useless CompileStoreGlobal...

Revision: 16653 Author: verwa...@chromium.org Date: Wed Sep 11 13:34:07 2013 UTC Log: Delete useless CompileStoreGlobal StoreGlobal stubs are generated by Hydrogen now BUG= R=verwa...@chromium.org Review URL: https://chromiumcodereview.appspot.com/23881004 Patch from Weiliang Lin .

[v8-dev] Re: Update behavior of inspection of |acceptList| during Object.observe: (issue 23464058)

I'm with Andreas on this. It seems more consistent to allow an empty list. Sure, it doesn't do anything but neither does array.push(). On Wed, Sep 11, 2013 at 9:24 AM, Rafael Weinstein wrote: > The main motivation is that it is an error. Nothing can be observed if the > acceptList is empty. Woul

[v8-dev] Simplify installing concurrently recompiled code. (issue 23542029)

Reviewers: Michael Starzinger, Description: Simplify installing concurrently recompiled code. Instead of overwriting the code entry of the function, we trigger an interrupt to install the code on the main thread. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium

[v8-dev] Re: To diagnose chromium bug 284577, some additional CHECKS. TODOs are (issue 23936007)

LGTM, one nit. https://codereview.chromium.org/23936007/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23936007/diff/1/src/hydrogen.cc#newcode1841 src/hydrogen.cc:1841: // HObjectAccess::ForAllocationSiteTransitionInfo()); I guess you are planing to land th

[v8-dev] Re: Update behavior of inspection of |acceptList| during Object.observe: (issue 23464058)

The main motivation is that it is an error. Nothing can be observed if the acceptList is empty. Would you prefer to silently return? Arv? On Wed, Sep 11, 2013 at 3:51 AM, wrote: > Is there a strong motivation for disallowing empty accept lists? IME, > artificial > discontinuities like that are

[v8-dev] Re: Issue 2804 in v8: Generic use of __proto__ accessor not allowed

Updates: Status: Accepted Cc: rossb...@chromium.org dslo...@chromium.org Labels: Harmony Comment #1 on issue 2804 by a...@chromium.org: Generic use of __proto__ accessor not allowed http://code.google.com/p/v8/issues/detail?id=2804 (No comment was entered for this chan

[v8-dev] remove OS::StackWalk (issue 23703013)

Reviewers: Benedikt Meurer, Description: remove OS::StackWalk R=bmeu...@chromium.org BUG= Please review this at https://chromiumcodereview.appspot.com/23703013/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+0, -258 lines): M src/platform-cygwin.cc M src/p

[v8-dev] Re: Issue 2856 in v8: Implement Harmony Array comprehensions

Updates: Status: Accepted Cc: wi...@igalia.com rossb...@chromium.org Labels: Harmony Comment #1 on issue 2856 by a...@chromium.org: Implement Harmony Array comprehensions http://code.google.com/p/v8/issues/detail?id=2856 The spec is at http://people.mozilla.org/~jore

[v8-dev] MIPS: remove most uses of Isolate::Current in arch specific files. (issue 24108002)

Reviewers: danno, dcarney, Paul Lind, kisg, palfia, Jakob, Description: MIPS: remove most uses of Isolate::Current in arch specific files. Port r16643 (b818da5) BUG= Please review this at https://codereview.chromium.org/24108002/ SVN Base: https://github.com/v8/v8.git@gbl Affected files (+17

[v8-dev] To diagnose chromium bug 284577, some additional CHECKS. TODOs are (issue 23936007)

Reviewers: Hannes Payer, Message: Hi Hannes, here are the changes we discussed. Description: To diagnose chromium bug 284577, some additional CHECKS. TODOs are added so these can be backed out once the cause of the bug is determined. BUG= Please review this at https://codereview.chromium.org/2

[v8-dev] Re: Handlify JSObject::AddProperty helpers. (issue 23857009)

https://codereview.chromium.org/23857009/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23857009/diff/1/src/objects.cc#newcode1927 src/objects.cc:1927: void JSObject::AddFastProperty(Handle object, Could we rename this to either JSObject::AddField or JSObject:

[v8-dev] Re: Add assertion to UniqueValueId constructor. (issue 23781006)

Committed patchset #3 manually as r16652 (presubmit successful). https://codereview.chromium.org/23781006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r16652 committed - Add assertion to UniqueValueId constructor....

Revision: 16652 Author: yang...@chromium.org Date: Wed Sep 11 13:00:27 2013 UTC Log: Add assertion to UniqueValueId constructor. R=verwa...@chromium.org BUG= Review URL: https://codereview.chromium.org/23781006 http://code.google.com/p/v8/source/detail?r=16652 Modified: /branches/bl

[v8-dev] Re: Improve alias analysis for HConstants (and fix small snafu in MustAlias). (issue 24107003)

Committed patchset #1 manually as r16651 (presubmit successful). https://codereview.chromium.org/24107003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r16651 committed - Improve alias analysis for HConstants (and fix small snafu in MustAlia...

Revision: 16651 Author: tit...@chromium.org Date: Wed Sep 11 12:59:07 2013 UTC Log: Improve alias analysis for HConstants (and fix small snafu in MustAlias). BUG= R=verwa...@chromium.org Review URL: https://codereview.chromium.org/24107003 http://code.google.com/p/v8/source/detail?

[v8-dev] Re: refactor test instruction on ia32 (issue 23679007)

On 2013/09/11 11:04:06, Jakob wrote: On 2013/09/10 03:09:41, weiliang.lin2 wrote: > https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc > File src/ia32/assembler-ia32.cc (right): > > https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc#newcode1170

[v8-dev] [v8] r16650 committed - Clean-up v8::ArrayBuffer::Allocator interface...

Revision: 16650 Author: dslo...@chromium.org Date: Wed Sep 11 12:54:28 2013 UTC Log: Clean-up v8::ArrayBuffer::Allocator interface BUG=v8:2823 R=bmeu...@chromium.org Review URL: https://codereview.chromium.org/23514050 http://code.google.com/p/v8/source/detail?r=16650 Modified: /bra

[v8-dev] Re: Clean-up v8::ArrayBuffer::Allocator interface (issue 23514050)

Committed patchset #1 manually as r16650 (presubmit successful). https://codereview.chromium.org/23514050/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Add assertion to UniqueValueId constructor. (issue 23781006)

https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h#newcode312 src/hydrogen-instructions.h:312: explicit UniqueValueId(Handle handle) { On 2013/09/1

[v8-dev] Re: Add assertion to UniqueValueId constructor. (issue 23781006)

lgtm with comment https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h#newcode312 src/hydrogen-instructions.h:312: explicit UniqueValueId(Handle han

[v8-dev] Re: Improve alias analysis for HConstants (and fix small snafu in MustAlias). (issue 24107003)

lgtm https://codereview.chromium.org/24107003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Delete useless CompileStoreGlobal (issue 23881004)

On 2013/09/11 11:49:34, Toon Verwaest wrote: CompileStoreGlobal is still mentioned in code-stubs-.cc. If you remove that, LGTM. Thanks for cleaning up this dead code :) Done, Thanks for review https://codereview.chromium.org/23881004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http:/

[v8-dev] Re: MIPS: thread isolate for EntryHookTrampoline. (issue 23503050)

LGTM https://codereview.chromium.org/23503050/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] [v8] r16649 committed - Pass PC offset into runtime when compiling for OSR....

Revision: 16649 Author: yang...@chromium.org Date: Wed Sep 11 12:39:00 2013 UTC Log: Pass PC offset into runtime when compiling for OSR. R=tit...@chromium.org BUG= Review URL: https://codereview.chromium.org/23842004 http://code.google.com/p/v8/source/detail?r=16649 Modified: /branc

[v8-dev] Re: Pass PC offset into runtime when compiling for OSR. (issue 23842004)

Committed patchset #6 manually as r16649 (presubmit successful). https://codereview.chromium.org/23842004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] remove getcurrent from stubs (issue 23756009)

Reviewers: Sven Panne, Description: remove getcurrent from stubs R=svenpa...@chromium.org BUG= Please review this at https://codereview.chromium.org/23756009/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+40, -28 lines): M src/arm/builtins-arm.cc M src/ar

[v8-dev] Re: Clean-up v8::ArrayBuffer::Allocator interface (issue 23514050)

LGTM. https://codereview.chromium.org/23514050/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Clean-up v8::ArrayBuffer::Allocator interface (issue 23514050)

Reviewers: Benedikt Meurer, Message: PTAL Description: Clean-up v8::ArrayBuffer::Allocator interface BUG=v8:2823 R=bmeu...@chromium.org Please review this at https://codereview.chromium.org/23514050/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+3, -23 lines

[v8-dev] Re: Fix phis for non-sse2 double values (issue 23068038)

lgtm with comment. Doesn't support two doubles yet, but I think it's ok to leave it like this until we have an actual use-case for it. https://codereview.chromium.org/23068038/diff/8001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium

[v8-dev] Re: Tweak the Better{Left,Right}Operand() heuristic (issue 23717039)

A new fix direction based on comments. Please have a review. Thanks https://codereview.chromium.org/23717039/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] Make handle dereference check more precise. (issue 23578022)

Reviewers: Michael Starzinger, Description: Make handle dereference check more precise. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/23578022/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+7, -4 lines): M src/handles

[v8-dev] Handlify JSObject::AddProperty helpers. (issue 23857009)

Reviewers: Toon Verwaest, Description: Handlify JSObject::AddProperty helpers. R=verwa...@chromium.org Please review this at https://codereview.chromium.org/23857009/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+136, -139 lines): M src/objects.h M src/ob

[v8-dev] Improve alias analysis for HConstants (and fix small snafu in MustAlias). (issue 24107003)

Reviewers: Toon Verwaest, Description: Improve alias analysis for HConstants (and fix small snafu in MustAlias). BUG= Please review this at https://codereview.chromium.org/24107003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+6, -2 lines): M src/hydrogen-

[v8-dev] MIPS: thread isolate for EntryHookTrampoline. (issue 23503050)

Reviewers: danno, dcarney, Paul Lind, kisg, palfia, Jakob, Description: MIPS: thread isolate for EntryHookTrampoline. Port r16630 (e045054) BUG= Please review this at https://codereview.chromium.org/23503050/ SVN Base: https://github.com/v8/v8.git@gbl Affected files (+3, -0 lines): M src/m

[v8-dev] Re: Add a missing instruction to the ia32 disassembler. (issue 23451024)

LGTM with nit https://codereview.chromium.org/23451024/diff/1/src/ia32/disasm-ia32.cc File src/ia32/disasm-ia32.cc (right): https://codereview.chromium.org/23451024/diff/1/src/ia32/disasm-ia32.cc#newcode701 src/ia32/disasm-ia32.cc:701: case 2: mnem = "fstp_s"; break; This one is not popping; so

  1   2   >