Reviewers: Hannes Payer,
Description:
Lazily initialize thread pool to avoid allocating all the threads during
startup
R=hpa...@chromium.org
BUG=none
LOG=n
Please review this at https://codereview.chromium.org/98123004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
LGTM
https://codereview.chromium.org/98123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 18381
Author: joc...@chromium.org
Date: Fri Dec 20 08:34:42 2013 UTC
Log: Lazily initialize thread pool to avoid allocating all the threads
during startup
R=hpa...@chromium.org
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/98123004
Committed patchset #1 manually as r18381.
https://codereview.chromium.org/98123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: dcarney,
Description:
More API cleanup.
* Removed String::Empty, Number::New, Integer::New,
Integer::NewFromUnsigned,
FunctionTemplate::New and Object::New without Isolate* parameter.
* Removed Integer::New and Integer::NewUnsigned with weird argument order.
Chrome CLs matching
Updates:
Status: Assigned
Owner: yang...@chromium.org
Cc: aand...@chromium.org
Labels: Type-Bug
Comment #7 on issue 2825 by aand...@chromium.org: breakpoint resolved to
incorrect location
http://code.google.com/p/v8/issues/detail?id=2825
(No comment was
lgtm
https://codereview.chromium.org/118523003/diff/11/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/118523003/diff/11/src/api.cc#newcode888
src/api.cc:888: v8::Isolate* v8_isolate =
reinterpret_castv8::Isolate*(isolate);
isolate-factory-NewNumberFromInt(length)
Issue 2825: breakpoint resolved to incorrect location
http://code.google.com/p/v8/issues/detail?id=2825
This issue is now blocking issue chromium:304150.
See http://code.google.com/p/chromium/issues/detail?id=304150
--
You received this message because you are listed in the owner
or CC fields
On 2013/12/06 10:14:50, Toon Verwaest wrote:
LGTM.
I've added a test case and verified this optimization triggers. Landing...
We should also use transitioning information to distinguish receivers. The
receiver cannot alias any other object that already had at least the
target
number of
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r18382.
Description:
Always terminate the task queue
BUG=none
LOG=n
TBR=hpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=18382
Please review this at https://codereview.chromium.org/107503005/
SVN
Revision: 18382
Author: joc...@chromium.org
Date: Fri Dec 20 09:09:04 2013 UTC
Log: Always terminate the task queue
BUG=none
LOG=n
TBR=hpa...@chromium.org
Review URL: https://codereview.chromium.org/107503005
http://code.google.com/p/v8/source/detail?r=18382
Modified:
Landing...
https://codereview.chromium.org/118523003/diff/11/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/118523003/diff/11/src/api.cc#newcode888
src/api.cc:888: v8::Isolate* v8_isolate =
reinterpret_castv8::Isolate*(isolate);
On 2013/12/20 08:59:01, dcarney
LGTM
https://codereview.chromium.org/107503005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2013/12/18 12:49:54, Paweł Hajdan Jr. wrote:
Drive-by.
https://codereview.chromium.org/77913003/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/77913003/diff/1/include/v8.h#oldcode5544
include/v8.h:5544: V8_INLINE static void SetEmbedderData(v8::Isolate*
Committed patchset #8 manually as r18383 (presubmit successful).
https://codereview.chromium.org/118523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2013/12/20 10:15:40, jochen wrote:
On 2013/12/18 12:49:54, Paweł Hajdan Jr. wrote:
Drive-by.
https://codereview.chromium.org/77913003/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/77913003/diff/1/include/v8.h#oldcode5544
include/v8.h:5544: V8_INLINE
It looks pretty straightforward.
Kind of a nit, it would be neat if the notion of external array and fixed
array
could be unified for some checks. It's a little depressing to just add
another
check to if() statements all over the code. Maybe predicates like
external_or_fixed() could live in
Reviewers: Hannes Payer,
Description:
Revert More API cleanup.
This reverts r18383. The CL in itself is OK, we just have to wait until
Chrome's
commit queue lands the final corresponding change and re-land this CL. :-/
Please review this at https://codereview.chromium.org/119013004/
SVN
Committed patchset #1 manually as r18384.
https://codereview.chromium.org/119013004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM
https://codereview.chromium.org/119013004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
I think this CL breaks API in a backward-incompatible way, and doesn't use
V8_DEPRECATED to keep the old interface for at least one release.
We intentionally violate this policy now because tons of old stuff has been
accumulated by now which really slows our development down, and we want to
Committed patchset #4 manually as r18385 (presubmit successful).
https://codereview.chromium.org/104923010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Drive-by with a question.
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h
File include/v8.h (left):
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h#oldcode386
include/v8.h:386: templateclass M
Is this change backward-compatible? It seems that
Revision: 18385
Author: mvstan...@chromium.org
Date: Fri Dec 20 11:46:31 2013 UTC
Log: Remove flag track-allocation-sites.
The flag has been on in the build for ~9 months, and we aren't likely to
turn it off. The only customer of the flag is a set of tests that want to
verify
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h
File include/v8.h (left):
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h#oldcode386
include/v8.h:386: templateclass M
On 2013/12/20 11:47:51, Paweł Hajdan Jr. wrote:
Is this change
Committed patchset #1 manually as r18386.
https://codereview.chromium.org/109303006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Jakob,
Message:
TBR
Description:
Revert Remove flag track-allocation-sites.
This reverts commit 6c430da40efe388035504d3603756aa8c46ed1dc.
BUG=
Please review this at https://codereview.chromium.org/109303006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
rubberstamp LGTM except for the commit message: please mention the SVN
revision
instead of the git commit hash of the CL you're reverting.
https://codereview.chromium.org/109303006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Revision: 18386
Author: hpa...@chromium.org
Date: Fri Dec 20 12:04:34 2013 UTC
Log: Revert Remove flag track-allocation-sites.
This reverts commit 6c430da40efe388035504d3603756aa8c46ed1dc.
BUG=
Review URL: https://codereview.chromium.org/109303006
Committed patchset #3 manually as r18387 (presubmit successful).
https://codereview.chromium.org/99203006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 18387
Author: rossb...@chromium.org
Date: Fri Dec 20 12:06:11 2013 UTC
Log: Make a strict function's name property non-writable.
Set [[Writable]] to false for the name property of strict
functions as well, mirroring what non-strict functions have
it as.
LOG=N
Reviewers: Michael Starzinger, titzer,
Description:
Fixed Lithium environment generation bug for captured objects (created
by escape analysis). Added several tests that expose the bug.
Summary:
LCodegen::AddToTranslation assumes that Lithium environments are
generated by depth-first traversal,
Revision: 18388
Author: tit...@chromium.org
Date: Fri Dec 20 12:12:41 2013 UTC
Log: Improve load elimination handling of transitioning stores.
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/106973005
http://code.google.com/p/v8/source/detail?r=18388
Committed patchset #2 manually as r18388 (presubmit successful).
https://codereview.chromium.org/106973005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm.
thanks.
https://codereview.chromium.org/119093006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Drive-by with questions.
https://codereview.chromium.org/110573004/diff/1/include/v8-defaults.h
File include/v8-defaults.h (left):
https://codereview.chromium.org/110573004/diff/1/include/v8-defaults.h#oldcode42
include/v8-defaults.h:42: bool V8_EXPORT
Hm, I get plenty of assertion failures when running the test suite on a
debug
build...
https://codereview.chromium.org/108083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
On 2013/12/20 12:16:42, Paweł Hajdan Jr. wrote:
Drive-by with questions.
https://codereview.chromium.org/110573004/diff/1/include/v8-defaults.h
File include/v8-defaults.h (left):
https://codereview.chromium.org/110573004/diff/1/include/v8-defaults.h#oldcode42
include/v8-defaults.h:42:
I'm doubtful about this CL, see Dan's and my comments. I think the obvious
solution is to simply eliminate duplicates downstream.
https://codereview.chromium.org/116533003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
On 2013/12/20 11:44:42, Sven Panne wrote:
I think this CL breaks API in a backward-incompatible way, and doesn't
use
V8_DEPRECATED to keep the old interface for at least one release.
We intentionally violate this policy now because tons of old stuff has
been
accumulated by now which
Committed patchset #3 manually as r18389 (presubmit successful).
https://codereview.chromium.org/105313008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 18389
Author: jkumme...@chromium.org
Date: Fri Dec 20 13:33:20 2013 UTC
Log: Delete unused TypeInfo class
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/105313008
http://code.google.com/p/v8/source/detail?r=18389
Modified:
Committed patchset #1 manually as r18390 (presubmit successful).
https://codereview.chromium.org/109073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 18390
Author: joc...@chromium.org
Date: Fri Dec 20 13:36:50 2013 UTC
Log: Roll gyp 1685:1806
Too many updates to summarize them here.
BUG=none
LOG=n
R=machenb...@chromium.org
Review URL: https://codereview.chromium.org/109073004
Even though we aren't officially on the hook for MIPS, this change seems
sufficiently mechanical that we should go ahead and do it in this CL, I
think.
https://codereview.chromium.org/93803003/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
lgtm
https://codereview.chromium.org/102563004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Status: Accepted
Owner: dcar...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3066 by vego...@chromium.org: NativeDataProperty accessor
attached to the PrototypeTemplate is not called
http://code.google.com/p/v8/issues/detail?id=3066
This either a bug in the lookup routines that go
Reviewers: Hannes Payer,
Description:
Fix sporadic crash in the RequestInterruptTestWithNativeAccessor.
The test was broken. V8 currently does not correctly lookup
NativeDataProperty
accessors attached to the PrototypeTemplate of FunctionTemplate (Issue
3066). As
the result
LGTM
https://codereview.chromium.org/109653010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #1 manually as r18391.
https://codereview.chromium.org/109653010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 18391
Author: vego...@chromium.org
Date: Fri Dec 20 14:07:19 2013 UTC
Log: Fix sporadic crash in the RequestInterruptTestWithNativeAccessor.
The test was broken. V8 currently does not correctly lookup
NativeDataProperty accessors attached to the PrototypeTemplate of
Committed patchset #1 manually as r18392.
https://codereview.chromium.org/111523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 18392
Author: joc...@chromium.org
Date: Fri Dec 20 14:25:10 2013 UTC
Log: Sync cygwin version with chromium
231940 - Set executable bit on third_party/cygwin/bin/dos2unix.exe
229213 - Add back module paths from old python_26 configuration.
228972 - Remove old python from
Revision: 18393
Author: joc...@chromium.org
Date: Fri Dec 20 14:26:01 2013 UTC
Log: Update required cygwin version
http://code.google.com/p/v8/source/detail?r=18393
Modified:
/wiki/BuildingWithGYP.wiki
===
--- /wiki/BuildingWithGYP.wiki Sat Nov
Revision: 18394
Author: joc...@chromium.org
Date: Fri Dec 20 14:35:15 2013 UTC
Log: Revert r18390 - Roll gyp 1685:1806
Doesn't work with python2.7 - I tested with 2.6 :-/
BUG=none
TBR=hpa...@chromium.org
LOG=n
http://code.google.com/p/v8/source/detail?r=18394
Modified:
On 2013/12/20 12:54:54, rossberg wrote:
I'm doubtful about this CL, see Dan's and my comments. I think the obvious
solution is to simply eliminate duplicates downstream.
thanks, will adjust. How far downstream is acceptable -- something for the
embedder entirely to handle, or are you
On 20 December 2013 16:13, sigbjo...@opera.com wrote:
thanks, will adjust. How far downstream is acceptable -- something for the
embedder entirely to handle, or are you referring to
Runtime_GetLocalPropertyNames() ?
The latter. The API level should always be observable as doing the
right
Let me look at it after the holidays. Sorry for wasting your time.
On Fri, Dec 20, 2013 at 7:16 AM, rossb...@chromium.org wrote:
Hm, I get plenty of assertion failures when running the test suite on a
debug
build...
https://codereview.chromium.org/108083005/
--
erik
--
--
v8-dev
Comment #2 on issue 3050 by jakearch...@google.com: Align Promise API with
spec
http://code.google.com/p/v8/issues/detail?id=3050
Kinda related: what's the plan for logging details on rejected but uncaught
promises? Or promise debugging in general?
--
You received this message because
I have moved the common code to a newly created super class. Does it look
better?
https://codereview.chromium.org/93803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: Paul Lind, kisg, palfia, danno, Jakob,
Description:
MIPS: Improve allocate locals to reduce code size.
TEST=
BUG=
Please review this at https://codereview.chromium.org/104713013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -7 lines):
M
LGTM.
https://codereview.chromium.org/104713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney, danno, Jakob, Paul Lind, kisg, palfia,
Description:
MIPS: Improve registers saving for safepoints in deferred code.
This reduces code size of initial snapshot by more than 25Kb.
Registers are saved or restored via common stubs, instead of doing it
through inlined push/pop
Reviewers: danno,
Description:
Prepare push to trunk. Now working on version 3.24.7.
R=da...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/106583004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1 lines):
M ChangeLog
M
LGTM. Jakob, Danno, could one of you PTAL for code-stubs.h
https://codereview.chromium.org/109653013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/106583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #8 on issue 2885 by scot...@chromium.org: mksnapshot's output isn't
deterministic
http://code.google.com/p/v8/issues/detail?id=2885
In looking at https://code.google.com/p/chromium/issues/detail?id=326030 I
see not-quite-identical repeated builds in v8_snapshot.lib.
I've attached
lgtm
https://codereview.chromium.org/109653013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r18395 (presubmit successful).
https://codereview.chromium.org/106583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 18395
Author: hpa...@chromium.org
Date: Fri Dec 20 19:19:28 2013 UTC
Log: Prepare push to trunk. Now working on version 3.24.7.
R=jkumme...@chromium.org, da...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/106583004
Revision: 18397
Author: hpa...@chromium.org
Date: Fri Dec 20 19:23:23 2013 UTC
Log: Tagging version 3.24.6
http://code.google.com/p/v8/source/detail?r=18397
Added:
/tags/3.24.6
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
Revision: 18398
Author: plin...@gmail.com
Date: Fri Dec 20 19:40:12 2013 UTC
Log: MIPS: Improve allocate locals to reduce code size.
TEST=
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/104713013
Patch from Dusan Milosavljevic dusan.milosavlje...@rt-rk.com.
Committed as r18398.
https://codereview.chromium.org/104713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Revision: 18399
Author: plin...@gmail.com
Date: Fri Dec 20 19:44:03 2013 UTC
Log: MIPS: Improve registers saving for safepoints in deferred code.
This reduces code size of initial snapshot by more than 25Kb.
Registers are saved or restored via common stubs, instead of doing it
Committed as r18399.
https://codereview.chromium.org/109653013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Comment #9 on issue 2885 by tha...@chromium.org: mksnapshot's output isn't
deterministic
http://code.google.com/p/v8/issues/detail?id=2885
(since this is blocking chromium:314403, it'd be nice if it could be marked
in some non-Fixed state since some work is apparently still left to do)
Comment #9 on issue 3060 by clearscr...@gmail.com: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
Sorry, that should have been it's incorrect for V8 to kill the host for
OOM reasons. Terminating the process to stop a
Comment #2 on issue 2890 by rsturg...@google.com: Deopt loops involving
Math.round / Math.floor
http://code.google.com/p/v8/issues/detail?id=2890
This seems more urgent now that Math.ceil(x) is implemented as
-Math.floor(-x). 0 is a very innocent argument to pass to Math.ceil, but
now
78 matches
Mail list logo
