On 2014/04/04 06:44:57, haraken wrote:
On 2014/04/01 11:21:38, dcarney wrote:
> Committed patchset #3 manually as r20392 (presubmit successful).
It looks like this CL is rolled to Chromium. (Chromium DEPS is saying
that the
V8 revision is r20418.) May I land the Blink-side CL that moves DOM
Status: New
Owner:
New issue 3257 by sean93.p...@gmail.com: Concurrent recompilation with
Lithium code generation
http://code.google.com/p/v8/issues/detail?id=3257
Hello, this is not an issue but I don't know where to post so...maybe
groups?
I'm trying to add lithium code generation pa
lgtm
https://codereview.chromium.org/223863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/04/01 11:21:38, dcarney wrote:
Committed patchset #3 manually as r20392 (presubmit successful).
It looks like this CL is rolled to Chromium. (Chromium DEPS is saying that
the
V8 revision is r20418.) May I land the Blink-side CL that moves DOM
attributes
to prototype chains?
https
I'm pretty surprised by the duplicate flags too. I wonder why that doesn't
happen for chromium. I'd add a few print statments in
build/gyp/pylib/gyp/input.py ('configuration'-related stuff, __init__.py and
generators/ninja.py ) :-/
https://codereview.chromium.org/224443003/diff/40001/build.ninja
Revision: 20494
Author: bmeu...@chromium.org
Date: Fri Apr 4 04:49:07 2014 UTC
Log: Get rid of the TRANSITION PropertyType and consistently use
CanHoldValue().
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/223193005
http://code.google.com/p/v8/source/detail?r
Committed patchset #3 manually as r20494 (presubmit successful).
https://codereview.chromium.org/223193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Когда у Вас в квартире, коттедже и др. плохое качество сотовой связи.
Советуем решение - усиление сигнала сотовой связи GSM и мобильного интернета.
Стоимость на усилители и работы по установке ниже чем у конкурентов - дилерские
цены от производителя !
После установки ретранслятора ST_REPEATER Вы п
Revision: 20493
Author: machenb...@chromium.org
Date: Fri Apr 4 00:05:45 2014 UTC
Log: Tagging version 3.26.6
http://code.google.com/p/v8/source/detail?r=20493
Added:
/tags/3.26.6
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
Committed patchset #1 manually as r20491 (presubmit successful).
https://codereview.chromium.org/224583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20491
Author: pal...@homejinni.com
Date: Thu Apr 3 23:34:28 2014 UTC
Log: MIPS: Check in Lithium that allocation size in Smi range.
Port r20458 (984d99c9)
Oirginal commit message:
This is to avoid triggering an assertion from Smi::FromInt. The
generated code is unreachable,
lgtm
https://codereview.chromium.org/224583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15898
src/objects.cc:15898: MaybeObject*
OrderedHashTable::Allocate(Heap* heap, int capacity) {
On 2014/04/01 15:22:45, arv wrote:
Updated tests to avoid duplication
https://codereview.chromium.org/220293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Nico,
https://codereview.chromium.org/224443003/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/224443003/diff/40001/build/standalone.gypi#newcode195
build/standalone.gypi:195: 'cflags': [ '-Wall', '<(werror)', '-W',
'-Wno-unused-p
Reviewers: jarin, danno, Paul Lind, kisg, kilvadyb, dusmil,
Message:
PTAL.
Description:
MIPS: Check in Lithium that allocation size in Smi range.
Port r20458 (984d99c9)
Oirginal commit message:
This is to avoid triggering an assertion from Smi::FromInt. The
generated code is unreachable, so it
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251
src/objects.cc:7251: explicit IntrusiveMapTransitionIterator(
On 2014/04/03 13:07:37, Michael Starzinger wrote:
nit: D
+ulan
Seems reasonable to me, but adding Ulan to check as well.
https://codereview.chromium.org/223623003/diff/1/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://codereview.chromium.org/223623003/diff/1/src/arm/disasm-arm.cc#newcode1275
src/arm/disasm-arm.cc:1275: int fraction
On 2014/04/03 16:02:45, oetuaho-nv wrote:
Thanks for the quick review, one comment inline.
I can look into this alternative solution and submit a new version once I
have
code and test results ready, and submit the assembler bug fix separately.
https://codereview.chromium.org/222403002/dif
Reviewers: jbramley, rmcilroy, jarin,
Message:
Spun off bugfix part from https://codereview.chromium.org/222403002/ since
the
optimization is likely to take a different route.
Description:
Fix fixed-point vcvt_f64_s32 immediate value encoding
The (32 - fraction_bits) value should be encoded
Status: New
Owner:
New issue 3256 by oetu...@nvidia.com: ARM: Immediate value of fixed-point
vcvt_f64_s32 encoded incorrectly by the assembler
http://code.google.com/p/v8/issues/detail?id=3256
The (32 - fraction_bits) value of vcvt_f64_s32 should be encoded so that
the least significan
(uploaded test fix; state of hubris now less)
https://codereview.chromium.org/222123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
Reviewers: Toon Verwaest, Michael Starzinger,
Description:
Make sure value is a heap number when reusing the double box in
BinaryOpICStub.
BUG=
Please review this at https://codereview.chromium.org/216823005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1
Reviewers: ulan,
Message:
ulan, ptal
Description:
Parser cleanup: PreParser doesn't need to produce symbol data any more.
State of the art:
- There is no preparsing phase any more.
- We start parsing with Parser, and when it sees a lazy function, it falls
back
to PreParser for that function.
Reviewers: ulan,
Message:
ulan, ptal
Description:
Parser cleanup: PreParser doesn't need to produce symbol data any more.
State of the art:
- There is no preparsing phase any more.
- We start parsing with Parser, and when it sees a lazy function, it falls
back
to PreParser for that function.
Committed patchset #2 manually as r20490 (presubmit successful).
https://codereview.chromium.org/223643004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20490
Author: a...@chromium.org
Date: Thu Apr 3 16:32:59 2014 UTC
Log: Do not mark prototype transitions link as weak in heap snapshot.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/223643004
http://code.google.com/p/v8/source/detail?r=20490
Modified:
/b
Revision: 20489
Author: dslo...@chromium.org
Date: Thu Apr 3 16:25:05 2014 UTC
Log: Harden IsMoreGeneralElementsKindTransition.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/213783004
http://code.google.com/p/v8/source/detail?r=20489
Modified:
/branches/bleedi
Committed patchset #1 manually as r20489 (presubmit successful).
https://codereview.chromium.org/213783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Fra Pulten til Dr.Tom Hart ,
Assisterende Manager Santander Bank Plc ,
London Storbritannia
Tele : +4470 3591 0619
Hei Sir ,
Komplimenter av dagen , jeg er Dr.Tom Hart , assisterende leder av Santander
Bank Plc Storbritannia , jeg kontakter deg for et felles forretnings gunstig å
tro vil du ikk
Yes you are right, the HCheckMaps is unnecessary in the case it's directly
on
the object. However, that's also true in case the property is in the
prototype
chain. The holder requires no checks, while all objects up to the holder do
need
map-checks (and negative lookups in case of NORMAL).
Thanks for the quick review, one comment inline.
I can look into this alternative solution and submit a new version once I
have
code and test results ready, and submit the assembler bug fix separately.
https://codereview.chromium.org/222403002/diff/1/src/arm/macro-assembler-arm.cc
File src/a
On 2014/04/03 15:41:59, Toon Verwaest wrote:
Yes it does. But why do you limit it to just that case? Why not also
support
values that are eg loaded from the prototype chain (and hence predictable)
that
are not configurable / read-only?
Originally it was there because of the frozen check whi
Yes it does. But why do you limit it to just that case? Why not also support
values that are eg loaded from the prototype chain (and hence predictable)
that
are not configurable / read-only?
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gr
lgtm
https://codereview.chromium.org/223193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc#newcode458
src/ic.cc:458:
maps.at(i)->AddDependentCode(DependentCode::kWeaklyEmbeddedGroup, stub);
On 2014/04/03 15:18:36, Toon Verwaest wrote:
lgtm
https://codereview.chromium.org/213783004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/188783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Overall looks good. Just some comments
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/188783003/diff/120001/src/ic.cc#newcode458
src/ic.cc:458:
maps.at(i)->AddDependentCode(DependentCode::kWeaklyEmbeddedGroup, stub);
This
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: Handle elms_obj =
maybe_elms_obj.ToHandleChecked();
On 2014/04/03 15:04:04, Yang wrote:
That would be a
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: Handle elms_obj =
maybe_elms_obj.ToHandleChecked();
That would be a duplicate check. Why not use ToHandl
Reviewers: Yang,
Message:
PTAL
Description:
Maybehandlification of EnsureJSArrayWithWritableFastElements().
Please review this at https://codereview.chromium.org/223743003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+25, -16 lines):
M src/builtins.cc
In
Revision: 20488
Author: ish...@chromium.org
Date: Thu Apr 3 14:42:56 2014 UTC
Log: Further Kraken regression recover due to handlification.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/223873004
http://code.google.com/p/v8/source/detail?r=20488
Modified:
/bran
Committed patchset #1 manually as r20488 (presubmit successful).
https://codereview.chromium.org/223873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/03 14:35:38, alph wrote:
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc#newcode1336
src/heap-snapshot-generator.cc:1336: Ma
On 2014/04/03 14:10:36, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/223873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc#newcode1336
src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
On 2014/
Revision: 20487
Author: alexandre.ra...@arm.com
Date: Thu Apr 3 14:30:44 2014 UTC
Log: ARM64: Fixes and more support for FRINT instructions.
Fix simulation and tests for the [-0.5, -0.0[ range for FRINTA and FRINTN,
and
add support for FRINTM.
R=u...@chromium.org
Review URL: http
Committed patchset #1 manually as r20487 (presubmit successful).
https://codereview.chromium.org/223843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r20486 (presubmit successful).
https://codereview.chromium.org/220203012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20486
Author: alexandre.ra...@arm.com
Date: Thu Apr 3 14:28:40 2014 UTC
Log: ARM64: Fix the atomic type width in the 64bit Acquire_Load().
R=u...@chromium.org
Review URL: https://codereview.chromium.org/220203012
http://code.google.com/p/v8/source/detail?r=20486
Modified:
Revision: 20485
Author: yang...@chromium.org
Date: Thu Apr 3 14:25:59 2014 UTC
Log: Return MaybeHandle from JsonParser.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/223553003
http://code.google.com/p/v8/source/detail?r=20485
Modified:
/branches/bleeding_edge/sr
Committed patchset #2 manually as r20485 (presubmit successful).
https://codereview.chromium.org/223553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/223553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
PTAL
Description:
Further Kraken regression recover due to handlification.
Please review this at https://codereview.chromium.org/223873004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+51, -44 lines):
M src/builtins.cc
Index: sr
Revision: 20484
Author: joc...@chromium.org
Date: Thu Apr 3 14:04:05 2014 UTC
Log: Revert r20476.
Reason for revert: crashes arm64.debug cctest
Fatal error in ../src/hydrogen-instructions.h, line 2968
CHECK(value->IsCheckHeapObject()) failed
Fixed environment assignment for LCheckNo
Committed patchset #1 manually as r20484 (tree was closed).
https://codereview.chromium.org/223873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: Sven Panne,
Description:
Revert r20476.
Reason for revert: crashes arm64.debug cctest
Fatal error in ../src/hydrogen-instructions.h, line 2968
CHECK(value->IsCheckHeapObject()) failed
Fixed environment assignment for LCheckNonSmi.
TBR=svenpa...@chromium.org
BUG=
Please review this
Reviewers: jarin,
Message:
PTAL
Description:
Make auto-roll script also roll patched trunk revisions.
BUG=
Please review this at https://codereview.chromium.org/223863003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -7 lines):
M tools/push-to-trunk/a
What is (or was) kDontSoftInline? It does not seem to be used anywhere.
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Igor Sheludko,
Description:
Return MaybeHandle from JsonParser.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/223553003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -22 lines):
M src/api.cc
M src/json-parser.
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc#newcode1336
src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
MarkTran
lgtm
https://codereview.chromium.org/223843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/220203012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL (unfortunately I have no easy repro)
Description:
Harden IsMoreGeneralElementsKindTransition.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/213783004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affect
Comment #33 on issue 2073 by yu...@chromium.org: Garbage collector
sometimes fails on objects with Object.defineProperty (memleak?)
http://code.google.com/p/v8/issues/detail?id=2073
#32 is also reproducible with--js-flags="--nocrankshaft --noopt" and
with https://codereview.chromium.org
Comment #32 on issue 2073 by yu...@chromium.org: Garbage collector
sometimes fails on objects with Object.defineProperty (memleak?)
http://code.google.com/p/v8/issues/detail?id=2073
I just discovered the following problem in tip of tree Chromium (Developer
Build from r261336 and Blink r1707
LGTM (👀👍). I like it. Just a couple of nits. Only one real suggestion about
the
ChildIteratorStart function.
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251
src/obj
Committed patchset #2 manually as r20483 (presubmit successful).
https://codereview.chromium.org/223463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20483
Author: machenb...@chromium.org
Date: Thu Apr 3 13:01:22 2014 UTC
Log: Fix bug entry and quotation marks in merge-to-branch.
This fixes usage of quotation marks inside titles of merged patches.
This also fixes aggregation of empty or "none" BUG entries.
BUG=
R=ja...@c
Revision: 20482
Author: machenb...@chromium.org
Date: Thu Apr 3 12:57:33 2014 UTC
Log: Add merged patches to commit title in merge-to-branch.
This makes it easier to grep for patches in title in the revision history.
This also removes the redundant information into which branch was m
Committed patchset #1 manually as r20482 (presubmit successful).
https://codereview.chromium.org/223753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: ulan, jochen,
Description:
ARM64: Fixes and more support for FRINT instructions.
Fix simulation and tests for the [-0.5, -0.0[ range for FRINTA and FRINTN,
and
add support for FRINTM.
Please review this at https://codereview.chromium.org/223843002/
SVN Base: https://v8.googlecode
Reviewers: ulan, jochen, JF,
Description:
ARM64: Fix the atomic type width in the 64bit Acquire_Load().
Please review this at https://codereview.chromium.org/220203012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/atomicops_internals_arm
Revision: 20481
Author: yang...@chromium.org
Date: Thu Apr 3 12:41:37 2014 UTC
Log: Return MaybeHandle from NewExternalStringFrom*.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/223653003
http://code.google.com/p/v8/source/detail?r=20481
Modified:
/branches/blee
Committed patchset #1 manually as r20481 (presubmit successful).
https://codereview.chromium.org/223653003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/223653003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/223753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 20480
Author: yang...@chromium.org
Date: Thu Apr 3 12:30:37 2014 UTC
Log: Reland "Return MaybeHandle from NewConsString."
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/223813002
http://code.google.com/p/v8/source/detail?r=20480
Modified:
/branches/blee
Committed patchset #1 manually as r20480 (presubmit successful).
https://codereview.chromium.org/223813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/223463003/diff/20001/tools/push-to-trunk/test_scripts.py
File tools/push-to-trunk/test_scripts.py (right):
https://codereview.chromium.org/223463003/diff/20001/tools/push-to-trunk/test_scripts.py#newcode1000
tools/push-to-trunk/test_scripts.py:1000: Revert "
Revision: 20479
Author: yang...@chromium.org
Date: Thu Apr 3 12:30:08 2014 UTC
Log: Return MaybeHandle from NewRaw???String.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/223573002
http://code.google.com/p/v8/source/detail?r=20479
Modified:
/branches/bleeding_ed
Committed patchset #2 manually as r20479 (presubmit successful).
https://codereview.chromium.org/223573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Yang,
Message:
Committed patchset #1 manually as r20478 (presubmit successful).
Description:
Revert r20474
This reverts commit r20474 due to an x64 release issue.
R=yang...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=20478
Please review this at https://cod
lgtm
https://codereview.chromium.org/223813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm.
https://codereview.chromium.org/223823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2014/04/03 11:42:34, Toon Verwaest wrote:
That sounds reasonable.
On second thought, please move all of this code to BuildLoadNamedField.
The
rest
of the machinery is there to ensure that all checks are done properly,
and you
*do* need them as well. Suppose the value you are loading co
Reviewers: jarin,
Message:
PTAL
Description:
Fix bug entry and quotation marks in merge-to-branch.
This fixes usage of quotation marks inside titles of merged patches.
This also fixes aggregation of empty or "none" BUG entries.
BUG=
Please review this at https://codereview.chromium.org/223463
Committed patchset #2 manually as r20477 (presubmit successful).
https://codereview.chromium.org/223473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20477
Author: mstarzin...@chromium.org
Date: Thu Apr 3 12:23:35 2014 UTC
Log: Use premordial Object.isSealed/isFrozen in builtins.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/223473002
http://code.google.com/p/v8/source/detail?r=20477
Added:
/bran
Reviewers: Igor Sheludko,
Description:
Reland "Return MaybeHandle from NewConsString."
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/223813002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+117, -88 lines):
M src/api.cc
M src
Revision: 20476
Author: svenpa...@chromium.org
Date: Thu Apr 3 12:12:28 2014 UTC
Log: Fixed environment assignment for LCheckNonSmi.
This fixes browsing facebook.com with a debug version of Chrome.
TBR=u...@chromium.org
Review URL: https://codereview.chromium.org/223763003
http://co
Reviewers: ulan,
Message:
Committed patchset #2 manually as r20476 (presubmit successful).
Description:
Fixed environment assignment for LCheckNonSmi.
This fixes browsing facebook.com with a debug version of Chrome.
TBR=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r
Revision: 20475
Author: yang...@chromium.org
Date: Thu Apr 3 12:09:14 2014 UTC
Log: Revert "Return MaybeHandle from NewConsString."
This reverts r20473.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/223593004
http://code.google.com/p/v8/source/detail?r=20475
Committed patchset #1 manually as r20475 (tree was closed).
https://codereview.chromium.org/223593004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm
https://codereview.chromium.org/223593004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mvstanton,
Description:
Revert "Return MaybeHandle from NewConsString."
This reverts r20473.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/223593004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+88, -117 lines):
Reviewers: yurys, loislo, ulan,
Message:
ptal
Description:
Do not mark prototype transitions link as weak in heap snapshot.
Please review this at https://codereview.chromium.org/223643004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+15, -1 lines):
M src/h
Mostly LG TM, just one comment.
https://codereview.chromium.org/222133003/diff/20001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/222133003/diff/20001/src/x64/macro-assembler-x64.cc#newcode1112
src/x64/macro-assembler-x64.cc:1112: i
Reviewers: jarin,
Message:
PTAL
Description:
Add merged patches to commit title in merge-to-branch.
This makes it easier to grep for patches in title in the revision history.
This also removes the redundant information into which branch was merged, as
this can be derived from the version numbe
1 - 100 of 168 matches
Mail list logo
