On 2014/04/01 11:21:38, dcarney wrote:
Committed patchset #3 manually as r20392 (presubmit successful).
It looks like this CL is rolled to Chromium. (Chromium DEPS is saying that
the
V8 revision is r20418.) May I land the Blink-side CL that moves DOM
attributes
to prototype chains?
lgtm
https://codereview.chromium.org/223863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Status: New
Owner:
New issue 3257 by sean93.p...@gmail.com: Concurrent recompilation with
Lithium code generation
http://code.google.com/p/v8/issues/detail?id=3257
Hello, this is not an issue but I don't know where to post so...maybe
groups?
I'm trying to add lithium code generation
On 2014/04/04 06:44:57, haraken wrote:
On 2014/04/01 11:21:38, dcarney wrote:
Committed patchset #3 manually as r20392 (presubmit successful).
It looks like this CL is rolled to Chromium. (Chromium DEPS is saying
that the
V8 revision is r20418.) May I land the Blink-side CL that moves DOM
Reviewers: Benedikt Meurer,
Description:
Reland Fixed environment assignment for LCheckNonSmi.
Now with (hopefully correct) ARM64 part... :-}
Please review this at https://codereview.chromium.org/225313003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12,
LGTM
https://codereview.chromium.org/225313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 20495
Author: svenpa...@chromium.org
Date: Fri Apr 4 07:07:34 2014 UTC
Log: Reland Fixed environment assignment for LCheckNonSmi.
Now with (hopefully correct) ARM64 part... :-}
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/225313003
Committed patchset #1 manually as r20495 (presubmit successful).
https://codereview.chromium.org/225313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Message:
Trivial one... PTAL
Description:
TypePrint() does not depend on Object::Print().
Please review this at https://codereview.chromium.org/225353004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -6 lines):
M src/types.h
M
lgtm
https://codereview.chromium.org/225353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20496
Author: bmeu...@chromium.org
Date: Fri Apr 4 07:21:59 2014 UTC
Log: TypePrint() does not depend on Object::Print().
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/225353004
http://code.google.com/p/v8/source/detail?r=20496
Modified:
Committed patchset #1 manually as r20496 (presubmit successful).
https://codereview.chromium.org/225353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20497
Author: machenb...@chromium.org
Date: Fri Apr 4 07:23:45 2014 UTC
Log: Make auto-roll script also roll patched trunk revisions.
This will allow the auto-roll bot to roll the last trunk patches,
e.g. Version 3.4.5.1
BUG=
R=ja...@chromium.org
Review URL:
Committed patchset #1 manually as r20497 (presubmit successful).
https://codereview.chromium.org/223863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Meh, I'll restructure this a bit, I'll make another CL for just updating the
tests inside V8 to use the new compilation API. No need to review this...
https://codereview.chromium.org/222123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
On 2014/04/03 15:17:06, Igor Sheludko wrote:
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: HandleFixedArrayBase elms_obj =
Committed patchset #2 manually as r20498 (presubmit successful).
https://codereview.chromium.org/223743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20498
Author: ish...@chromium.org
Date: Fri Apr 4 08:17:23 2014 UTC
Log: Maybehandlification of EnsureJSArrayWithWritableFastElements().
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/223743003
http://code.google.com/p/v8/source/detail?r=20498
Reviewers: jochen,
Description:
Version 3.26.6.1 (merged r20491)
MIPS: Check in Lithium that allocation size in Smi range.
TBR=joc...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/225503002/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files (+8, -2
Committed patchset #1 manually as r20499.
https://codereview.chromium.org/225503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 20499
Author: machenb...@chromium.org
Date: Fri Apr 4 08:28:47 2014 UTC
Log: Version 3.26.6.1 (merged r20491)
MIPS: Check in Lithium that allocation size in Smi range.
TBR=joc...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/225503002
Reviewers: rossberg,
Message:
PTAL
Description:
Properly pass dim to recursive calls in TypePrint().
Please review this at https://codereview.chromium.org/224723007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/types.cc
Index:
lgtm
https://codereview.chromium.org/224723007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20501
Author: hpa...@chromium.org
Date: Fri Apr 4 08:46:49 2014 UTC
Log: Make sure value is a heap number when reusing the double box in
BinaryOpICStub.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/216823005
Committed patchset #1 manually as r20501 (presubmit successful).
https://codereview.chromium.org/216823005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20502 (presubmit successful).
https://codereview.chromium.org/224723007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20502
Author: bmeu...@chromium.org
Date: Fri Apr 4 09:00:30 2014 UTC
Log: Properly pass dim to recursive calls in TypePrint().
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/224723007
http://code.google.com/p/v8/source/detail?r=20502
Modified:
This fix fixes the mutation problem, however it does not fix the double-run
problem afaict. It could be that the operand is indeed a number, but that
the
second operand which used to be a number, is now a string. That would cause
a
deopt due to string-number conversion while trying to save,
Reviewers: Igor Sheludko,
Description:
Return MaybeHandle from SetProperty.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/225283005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+554, -519 lines):
M src/accessors.cc
M
Reviewers: Toon Verwaest,
Message:
Hi Toon,
Here is the update to reland the earlier CL.
Thanks,
--Michael
Description:
Reland of https://codereview.chromium.org/172523002/
Fixed
1) Missing line in x64 port.
2) GcStress found a logic error in the IC miss handler.
Please review this at
lgtm
https://codereview.chromium.org/223533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
This problem shows how much of a bad idea it is to always clear the
feedback ..
:)
LGTM on the fix though.
https://codereview.chromium.org/224903005/diff/60001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/224903005/diff/60001/src/ic.cc#newcode1885
src/ic.cc:1885: //
Revision: 20503
Author: hpa...@chromium.org
Date: Fri Apr 4 09:25:36 2014 UTC
Log: Don't overwrite transition array map while iterating over the
transition tree.
Instread of using the transition array map to store the iteration index, we
are using the constructor field of the
Committed patchset #4 manually as r20503 (presubmit successful).
https://codereview.chromium.org/223533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: dcarney,
Description:
Version 3.25.28.5 (merged r20357)
Do not check for interrupt when allocating stack locals.
BUG=357137
LOG=N
R=dcar...@chromium.org
Please review this at https://codereview.chromium.org/225623002/
SVN Base: https://v8.googlecode.com/svn/branches/3.25
Affected
lgtm
https://codereview.chromium.org/225623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/04/03 18:59:10, rmcilroy wrote:
+ulan
Seems reasonable to me, but adding Ulan to check as well.
https://codereview.chromium.org/223623003/diff/1/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
Committed patchset #1 manually as r20504.
https://codereview.chromium.org/225623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 20504
Author: yang...@chromium.org
Date: Fri Apr 4 09:30:01 2014 UTC
Log: Version 3.25.28.5 (merged r20357)
Do not check for interrupt when allocating stack locals.
BUG=357137
LOG=N
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/225623002
Reviewers: Yang,
Description:
Version 3.24.35.28 (merged r20127)
Fix for performance issue 353661 - 23% regression in dromaeo.
BUG=353661
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/225403004/
SVN Base: https://v8.googlecode.com/svn/branches/3.24
Revision: 20505
Author: yang...@chromium.org
Date: Fri Apr 4 09:30:41 2014 UTC
Log: Tagging version 3.25.28.5
http://code.google.com/p/v8/source/detail?r=20505
Added:
/tags/3.25.28.5
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #1 manually as r20506.
https://codereview.chromium.org/225403004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 20506
Author: mvstan...@chromium.org
Date: Fri Apr 4 09:32:45 2014 UTC
Log: Version 3.24.35.28 (merged r20127)
Fix for performance issue 353661 - 23% regression in dromaeo.
BUG=353661
LOG=N
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/225403004
On 2014/04/04 09:30:59, mvstanton wrote:
lgtm (rubberstamp).
https://codereview.chromium.org/225403004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20507
Author: mvstan...@chromium.org
Date: Fri Apr 4 09:33:23 2014 UTC
Log: Tagging version 3.24.35.28
http://code.google.com/p/v8/source/detail?r=20507
Added:
/tags/3.24.35.28
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
LGTM, just two nits left.
https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15924
src/objects.cc:15924: MaybeObject*
OrderedHashTableentrysize::EnsureGrowable() {
On 2014/04/02
On 2014/04/03 18:29:20, Rodolph Perfetta wrote:
On 2014/04/03 16:02:45, oetuaho-nv wrote:
Thanks for the quick review, one comment inline.
I can look into this alternative solution and submit a new version once
I
have
code and test results ready, and submit the assembler bug fix
Patch set 2 addressed the comments, committing.
https://codereview.chromium.org/223623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.
https://codereview.chromium.org/223623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: ulan, jochen,
Message:
This gives about 5% performance improvement on the v8 and kraken benchmarks.
Description:
ARM64: Use direct deoptimization exits.
Please review this at https://codereview.chromium.org/225703002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Looks like commit bot is rejecting the change. I used instructions from
https://github.com/v8/v8/wiki/Proposing-a-Patch
Are they up to date?
https://codereview.chromium.org/223623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
On 2014/04/04 10:38:45, oetuaho-nv wrote:
Looks like commit bot is rejecting the change. I used instructions from
https://github.com/v8/v8/wiki/Proposing-a-Patch
Are they up to date?
The commit queue doesn't work for the V8 project, and without committer
status
you won't be able to land
Reviewers: jochen,
Message:
Not sure whether I'm on the right track; please have a look at this.
Description:
Add support for --raw and --omit to js2c.
--raw writes the raw source data to a separate file
--omit allows omitting the source data from the generated files.
The intention is
https://codereview.chromium.org/225283005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/225283005/diff/1/src/api.cc#newcode6984
src/api.cc:6984: EXCEPTION_BAILOUT_CHECK(isolate, LocalValue());
This second EXCEPTION_BAILOUT_CHECK will decrement call depth for the
Revision: 20508
Author: rmcil...@chromium.org
Date: Fri Apr 4 11:12:40 2014 UTC
Log: Fix fixed-point vcvt_f64_s32 immediate value encoding
The (32 - fraction_bits) value should be encoded so that the least
significant bit is set to bit 5 and the four next bits to bits 0-3. Fix
the
Committed patchset #2 manually as r20508 (presubmit successful).
https://codereview.chromium.org/223623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/225283005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/225283005/diff/1/src/api.cc#newcode6984
src/api.cc:6984: EXCEPTION_BAILOUT_CHECK(isolate, LocalValue());
On 2014/04/04 10:58:19, Igor Sheludko wrote:
This second
Reviewers: Igor Sheludko,
Description:
Return MaybeHandle from GetProperty.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/225673003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+106, -92 lines):
M src/api.cc
M src/ic.cc
M
lgtm with a nit: please use .Check() in other cctest files you modified.
https://codereview.chromium.org/225283005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Comment #1 on issue 3255 by hpa...@chromium.org: Grow KeyedStoreIC doesn't
respect String value wrappers
http://code.google.com/p/v8/issues/detail?id=3255
This is the same bug as issue 359134.
--
You received this message because this project is configured to send all
issue notifications
Reviewers: ulan,
Message:
ulan, ptal
Description:
Update tests to use the new compilation API + related fixes.
Esp. get rid of PreCompile in tests, as it's going to be removed.
Notes:
- The new compilation API doesn't have a separate precompilation phase, so
there
is no separate way to
lgtm with a nit:
https://codereview.chromium.org/225673003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/225673003/diff/1/src/objects.cc#newcode13216
src/objects.cc:13216: result = GetProperty(object, receiver, lookup,
name, attributes);
Probably it would
can you reference the bug (355539) in the cl description?
lgtm
https://codereview.chromium.org/225723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Benedikt Meurer, ulan,
Message:
num_pending_reloc_info_ was multiplied by 2 during the call of
ConstantPoolMarker and inside ConstantPoolMarker. The result was two many
bytes
taken in account as constant when disassembling.
Move the Constant pool comment after the branch over the
This gives about 5% performance improvement on the v8 and kraken
benchmarks.
Does arm64 deopt more than arm?
https://codereview.chromium.org/225703002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
lgtm, nice catch!
https://codereview.chromium.org/225403005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #2 manually as r20509 (presubmit successful).
https://codereview.chromium.org/225283005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/225673003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/225673003/diff/1/src/objects.cc#newcode13216
src/objects.cc:13216: result = GetProperty(object, receiver, lookup,
name, attributes);
On 2014/04/04 11:52:27, Igor Sheludko
lgtm
https://codereview.chromium.org/225743002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/225743002/diff/40001/src/parser.h#newcode120
src/parser.h:120: if (functions_size 0) return 0;
Shouldn't these checks be ASSERTs instead?
What does it mean if the
thanks for review!
https://codereview.chromium.org/225743002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/225743002/diff/40001/src/parser.h#newcode120
src/parser.h:120: if (functions_size 0) return 0;
On 2014/04/04 12:10:59, ulan wrote:
Shouldn't these
Committed patchset #2 manually as r20510 (presubmit successful).
https://codereview.chromium.org/225673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20510
Author: yang...@chromium.org
Date: Fri Apr 4 12:25:45 2014 UTC
Log: Return MaybeHandle from GetProperty.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/225673003
http://code.google.com/p/v8/source/detail?r=20510
Modified:
Reviewers: Sven Panne, danno, Paul Lind, kisg, kilvadyb, dusmil,
Message:
PTAL.
Description:
MIPS: Reland Fixed environment assignment for LCheckNonSmi.
Port r20495 (705b65bc)
BUG=
Please review this at https://codereview.chromium.org/225023007/
SVN Base:
Committed patchset #4 manually as r20511 (presubmit successful).
https://codereview.chromium.org/225743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20511
Author: ma...@chromium.org
Date: Fri Apr 4 12:36:23 2014 UTC
Log: Update tests to use the new compilation API + related fixes.
Esp. get rid of PreCompile in tests, as it's going to be removed.
Notes:
- The new compilation API doesn't have a separate precompilation
Reviewers: Yang,
Message:
PTAL
Description:
Callers of ElementsAccessor::AddElementsToFixedArray(),
ElementsAccessor::HasElement() and ElementsAccessor::GetKeyForIndex()
handlified.
Please review this at https://codereview.chromium.org/225623004/
SVN Base:
Status: New
Owner:
New issue 3258 by johann...@opera.com: Broken build for ARM when compiling
with DEBUG defined.
http://code.google.com/p/v8/issues/detail?id=3258
This is an issue that affects recent Chromium builds under certain
conditions.
The build fails on ARMv7/Android when
Revision: 20512
Author: rodolph.perfe...@arm.com
Date: Fri Apr 4 12:54:12 2014 UTC
Log: ARM64: fix constant pool size used by disassembler
BUG=
R=u...@chromium.org, bmeu...@chromium.org
Review URL: https://codereview.chromium.org/225403005
On 2014/04/04 12:44:06, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/225623004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as r20513 (presubmit successful).
https://codereview.chromium.org/225623004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20513
Author: ish...@chromium.org
Date: Fri Apr 4 13:05:37 2014 UTC
Log: Callers of ElementsAccessor::AddElementsToFixedArray(),
ElementsAccessor::HasElement() and ElementsAccessor::GetKeyForIndex()
handlified.
R=yang...@chromium.org
Review URL:
Reviewers: Benedikt Meurer,
Description:
Refactoring to allow adding new structured types
Also, simplfy representation of zone types, using a simple struct.
R=bmeu...@chromium.org
BUG=
LOG=N
Please review this at https://codereview.chromium.org/225923002/
SVN Base:
Reviewers: Sven Panne,
Message:
svenpanne, PTAL.
(Note: this is just removing stuff from the API, not adding anything.
Chromium
has already been updated to not use ScriptData.)
Description:
Remove the PreCompile API and ScriptData.
The new compilation API (ScriptCompiler::Compile) can
Reviewers: ,
Message:
PTAL
Description:
ElementsAccessor's public interface handlification.
Please review this at https://codereview.chromium.org/225933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+65, -35 lines):
M src/elements.h
M src/elements.cc
PTAL
https://codereview.chromium.org/225933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2014/04/04 13:12:57, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/225933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Starzinger,
Description:
Fix materialization of accessor frames with captured receivers
I have fixed skipping of the receiver object to materialize captured
objects. This is done with a new DoTranslateSkip method.
We should consider unifying DoTranslateSkip,
Revision: 20514
Author: ish...@chromium.org
Date: Fri Apr 4 13:20:24 2014 UTC
Log: ElementsAccessor's public interface handlification.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/225933002
http://code.google.com/p/v8/source/detail?r=20514
Modified:
Committed patchset #1 manually as r20514 (presubmit successful).
https://codereview.chromium.org/225933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/225703002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/225703002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode2153
src/arm64/lithium-codegen-arm64.cc:2153: }
On 2014/04/04 12:04:13,
I added support from loading from prototypes which works
even if the object is not a Constant.
If the property is directly on the object then it needs
to be a Constant (e.g. Math).
I also had a go at eliminating the map check from the holder.
https://codereview.chromium.org/220163012/
--
--
On 2014/04/04 12:04:12, ulan wrote:
This gives about 5% performance improvement on the v8 and kraken
benchmarks.
Does arm64 deopt more than arm?
This patch spares the cpu from taking unconditional branches to jump over
deopt
sites. That's where the improvement comes from.
Reviewers: ulan, jochen,
Description:
ARM64: Fix disassembly of branch targets.
Please review this at https://codereview.chromium.org/225743004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src/arm64/disasm-arm64.cc
Index:
On 2014/04/04 13:24:56, Alexandre Rames wrote:
On 2014/04/04 12:04:12, ulan wrote:
This gives about 5% performance improvement on the v8 and kraken
benchmarks.
Does arm64 deopt more than arm?
This patch spares the cpu from taking unconditional branches to jump over
deopt
sites. That's
Updates:
Status: Invalid
Comment #1 on issue 3257 by jkumme...@chromium.org: Concurrent
recompilation with Lithium code generation
http://code.google.com/p/v8/issues/detail?id=3257
Don't do it, it's impossible, reason is on-demand stub generation, as well
as some other things that
Committed patchset #2 manually as r20515 (presubmit successful).
https://codereview.chromium.org/225703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20515
Author: alexandre.ra...@arm.com
Date: Fri Apr 4 13:41:12 2014 UTC
Log: ARM64: Use direct deoptimization exits.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/225703002
http://code.google.com/p/v8/source/detail?r=20515
Modified:
Status: Accepted
Owner: svenpa...@chromium.org
CC: yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3259 by yang...@chromium.org: Floor of div on ARM returns
incorrect results.
http://code.google.com/p/v8/issues/detail?id=3259
The following variation of
Reviewers: jarin,
Message:
PTAL
Description:
Automatically determine current V8 sheriff in chromium-roll script.
BUG=
Please review this at https://codereview.chromium.org/225283007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+82, -13 lines):
M
Committed patchset #4 manually as r20516 (presubmit successful).
https://codereview.chromium.org/224903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
1 - 100 of 144 matches
Mail list logo
