https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660
src/flag-definitions.h:660: DEFINE_bool(omit, false, "Omit raw snapshot
bytes in generated code.
On 2014/04/23 19:26:22, Igor Sheludko wrote:
PTAL #9
lgtm.
https://codereview.chromium.org/250023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
lgtm
https://codereview.chromium.org/246743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/04/23 19:19:51, Igor Sheludko wrote:
PTAL #6
lgtm.
https://codereview.chromium.org/249723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Committed patchset #2 manually as r20919 (presubmit successful).
https://codereview.chromium.org/246643014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm.
https://codereview.chromium.org/249883003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/249883003/diff/1/src/objects.cc#newcode15955
src/objects.cc:15955: USE(k);
Yeah this seems weird to have.
https://codereview.chromium.org/249883003/
--
--
v8-dev
On 2014/04/23 19:15:50, Igor Sheludko wrote:
PTAL #4
lgtm.
https://codereview.chromium.org/250003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Addressed comments, landing...
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#oldcode3787
src/arm/code-stubs-arm.cc:3787:
On 2014/04/23 13:58:21, Michael
On 2014/04/23 19:14:01, Igor Sheludko wrote:
PTAL #3
lgtm.
https://codereview.chromium.org/249993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
On 2014/04/23 15:39:32, wingo wrote:
Updated patchset, ptal.
lgtm.
https://codereview.chromium.org/247003004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
On 2014/04/23 19:13:02, Igor Sheludko wrote:
PTAL #2
lgtm.
https://codereview.chromium.org/249973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Updates:
Status: Duplicate
Mergedinto: chromium:346587
Comment #2 on issue 3284 by yang...@chromium.org: Optimization corner case
causing a string to not be == to an identical string
http://code.google.com/p/v8/issues/detail?id=3284
Seems like a duplicate of an already fixed i
Revision: 20918
Author: ja...@chromium.org
Date: Thu Apr 24 05:29:00 2014 UTC
Log: Fix C++ type of Factory::NewFixedDoubleArray.
The change fixes the C++ type of Factory::NewFixedDoubleArray to
reflect the empty array case, where we return an empty
FixedArray (rather than FixedDoubleAr
Committed patchset #2 manually as r20918 (presubmit successful).
https://codereview.chromium.org/249593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/238443005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #8 on issue 2543 by polt...@gmail.com: ARMv5 Illegal Instruction
vpush even with vfp2=off and vfp3=off
http://code.google.com/p/v8/issues/detail?id=2543
What was the solution for this last year?
I've a pretty similar problem with the same CPU.
http://code.google.com/p/v8/issues/deta
Revision: 20917
Author: machenb...@chromium.org
Date: Thu Apr 24 00:05:40 2014 UTC
Log: Tagging version 3.26.23
http://code.google.com/p/v8/source/detail?r=20917
Added:
/tags/3.26.23
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Reviewers: Toon Verwaest,
Description:
Store JSGlobalProxy's identity hash directly on the proxy itself
Previously, the hash was stored on the underlying global object, since
it was stored in the hidden property table. This patch moves to an
implementation modeled on JSProxy, adding a new 'hash'
Please ignore this for now, it fails on
cctest/test-strings/StringOOMInternalizeUtf8String
https://codereview.chromium.org/247953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Gr
Reviewers: Yang,
Message:
PTAL #9
Description:
Dictionary::DeleteProperty() handlified.
Please review this at https://codereview.chromium.org/250023002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -39 lines):
M src/objects.h
M src/objects.cc
Index
Reviewers: Yang,
Message:
PTAL #8
Description:
Dictionary::New() handlified.
Please review this at https://codereview.chromium.org/246743003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+27, -101 lines):
M src/factory.h
M src/factory.cc
M src/heap.cc
Reviewers: yangguo,
Message:
PTAL #7
Description:
Dictionary::GenerateNewEnumerationIndices() and Dictionary::EnsureCapacity()
handlified.
Please review this at https://codereview.chromium.org/250013002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+43, -62 l
Reviewers: Yang,
Message:
PTAL #6
Description:
Dictionary::Add() handlified.
Please review this at https://codereview.chromium.org/249723004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+38, -54 lines):
M src/factory.cc
M src/objects.h
M src/objects.cc
Reviewers: Yang,
Message:
PTAL #5
Description:
Dictionary::AtPut() handlified.
Please review this at https://codereview.chromium.org/249883003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+47, -31 lines):
M src/objects.h
M src/objects.cc
M src/objects-
Reviewers: Yang,
Message:
PTAL #4
Description:
*NumberDictionary::AtNumberPut() handlified.
Please review this at https://codereview.chromium.org/250003002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -43 lines):
M src/code-stubs.cc
M src/factory.h
Reviewers: Yang,
Message:
PTAL #3
Description:
*NumberDictionary::AddNumberEntry() handlified.
Please review this at https://codereview.chromium.org/249993002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -21 lines):
M src/objects.h
M src/objects.cc
Reviewers: Yang,
Message:
PTAL #2
Description:
*NumberDictionary::Set() handlified.
Please review this at https://codereview.chromium.org/249973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+42, -43 lines):
M src/objects.h
M src/objects.cc
M src/obj
Reviewers: Yang,
Message:
PTAL
Description:
Tiny cleanup.
Please review this at https://codereview.chromium.org/247953003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -5 lines):
M src/api.cc
M src/objects.cc
Index: src/api.cc
diff --git a/src/api.c
On Wed, Apr 23, 2014 at 5:23 PM, wrote:
> lgtm
>
> I guess make quickcheck still passes with this?
>
Indeed.
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
Yep. Or at least restricted to the heap. We are actively working towards
removing MaybeObjects from non GC-related places.
Yang
On Apr 23, 2014 5:57 PM, "Andy Wingo" wrote:
> On Wed 23 Apr 2014 17:08, "codesite-nore...@google.com via v8-dev" <
> v8-dev@googlegroups.com> writes:
>
> > Revision: 2
lgtm
https://codereview.chromium.org/249593002/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/249593002/diff/1/src/builtins.cc#newcode473
src/builtins.cc:473: new_elms = Handle::cast(
Might have a comment that this is safe because we know capacity > 0.
h
On Wed 23 Apr 2014 17:08, "codesite-nore...@google.com via v8-dev"
writes:
> Revision: 20914
> Author: yang...@chromium.org
> Date: Wed Apr 23 15:08:03 2014 UTC
> Log: Clean up some uses of Failures and MaybeObjects.
>
> R=mstarzin...@chromium.org
What's the logic here? (Not questio
Committed patchset #2 manually as r20915 (presubmit successful).
https://codereview.chromium.org/249103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150
src/mark-compact.cc:2150: // String table could have already been marked
via handle scope iteration.
On 2014/04/
Reviewers: mvstanton,
Description:
Fix C++ type of Factory::NewFixedDoubleArray.
The change fixes the C++ type of Factory::NewFixedDoubleArray to
reflect the empty array case, where we return an empty
FixedArray (rather than FixedDoubleArray).
R=mvstan...@chromium.org
BUG=
Please review this a
Revision: 20915
Author: ish...@chromium.org
Date: Wed Apr 23 15:43:39 2014 UTC
Log: StringTable::LookupKey() and all callers handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/249103002
http://code.google.com/p/v8/source/detail?r=20915
Modified:
/branches
Updated patchset, ptal.
https://codereview.chromium.org/247003004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop recei
Reviewers: ulan, jochen,
Description:
ARM64: Slightly improve MacroAssembler::Allocate.
BUG=
Please review this at https://codereview.chromium.org/247533005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -14 lines):
M src/arm64/constants-arm64.h
M src
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 3284 by yang...@chromium.org: Optimization corner case
causing a string to not be == to an identical string
http://code.google.com/p/v8/issues/detail?id=3284
(No comment was entered for this change.)
--
lgtm
I guess make quickcheck still passes with this?
https://codereview.chromium.org/249283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
LGTM
https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150
src/mark-compact.cc:2150: // String table could have already been marked
via handle scope iteration.
I wou
Revision: 20914
Author: yang...@chromium.org
Date: Wed Apr 23 15:08:03 2014 UTC
Log: Clean up some uses of Failures and MaybeObjects.
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/245963007
http://code.google.com/p/v8/source/detail?r=20914
Modified:
/branche
Committed patchset #3 manually as r20914 (presubmit successful).
https://codereview.chromium.org/245963007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/245963007/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/245963007/diff/20001/src/objects.h#newcode1680
src/objects.h:1680: // 01 NOT_FOUND
On 2014/04/23 14:34:52, Michael Starzinger wrote:
nit: This NOT_FOUND constant does
Committed patchset #1 manually as r20913 (presubmit successful).
https://codereview.chromium.org/248483004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20913
Author: wi...@igalia.com
Date: Wed Apr 23 15:01:30 2014 UTC
Log: Move bug 3280 regression test to mjsunit/harmony
R=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/248483004
http://code.google.com/p/v8/source/detail?r=20913
Added:
/branches/blee
Reviewers: rossberg,
Message:
First draft of this. I still have to write a test case for a custom
deferred for
which the reject throws. Maybe some more test cases that I can't think of
are
missing?
Description:
Trigger debug event on not yet caught exception in promises.
R=rossb...@chromiu
LGTM with comments.
https://codereview.chromium.org/245963007/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/245963007/diff/20001/src/objects.h#newcode1680
src/objects.h:1680: // 01 NOT_FOUND
nit: This NOT_FOUND constant doesn't seem to exist, can we drop
Reviewers: danno, danno-g,
Message:
Committed patchset #1 manually as r20912 (presubmit successful).
Description:
Fix the Array.push simulate for non-effect context.
R=da...@google.com, da...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20912
Please review this at
Revision: 20912
Author: ja...@chromium.org
Date: Wed Apr 23 14:26:53 2014 UTC
Log: Fix the Array.push simulate for non-effect context.
R=da...@google.com, da...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/246543007
http://code.google.com/p/v8/source/detail?r=20912
A
lgtm
https://codereview.chromium.org/246543007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, just nits.
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#oldcode3787
src/arm/code-stubs-arm.cc:3787:
nit: Can we get the empty newline back for re
Status: New
Owner:
New issue 3284 by mari...@gmail.com: Optimization corner case causing a
string to not be == to an identical string
http://code.google.com/p/v8/issues/detail?id=3284
When running the attached file (I tested in Chrome 34 Linux and Chrome 33
Window), the following body
On 2014/04/23 13:29:56, ulan wrote:
PTAL
LGTM.
Please make sure that we do have tests covering the exception case.
https://codereview.chromium.org/246693005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Yang,
Message:
PTAL
Description:
Convert function.prototype to API-style accessor.
Please review this at https://codereview.chromium.org/246693005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+44, -45 lines):
M src/accessors.h
M src/accessors.
Reviewers: Sven Panne,
Description:
Remove static CallCompletedCallback handlers
BUG=none
R=svenpa...@chromium.org
LOG=y
Please review this at https://codereview.chromium.org/249313002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+51, -92 lines):
M include
Committed patchset #1 manually as r20911 (presubmit successful).
https://codereview.chromium.org/247573008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20911
Author: da...@chromium.org
Date: Wed Apr 23 13:20:28 2014 UTC
Log: Fix deoptimization problem with inlined Array.push()
R=ja...@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/247573008
http://code.google.com/p/v8/source/detail?r=20911
Added:
/branches
Reviewers: Michael Starzinger,
Message:
Long and boring, but mechanical... :-)
Description:
CodeStubs contain their corresponding Isolate* now. (part 1)
This is a purely mechanical change, adding an Isolate* to the CodeStub
constructor and a corresponding field plus a getter. A few methods in
C
Reviewers: jochen, Sven Panne,
Message:
Next steps would be:
1, add a variable to gyp files to generate raw files.
2, add logic in Chromium to (statically) use these.
3, put the runtime part of mksnapshot behind an API
(essentially, rip out SnapshotWriter), so this can
(optionally) be don
Revision: 20910
Author: u...@chromium.org
Date: Wed Apr 23 13:05:38 2014 UTC
Log: Allow Object.defineProperty to update value of an API accessor.
This is needed for converting internal accessors to API accessors and can
break blink tests.
BUG=
R=yang...@chromium.org
Review URL: ht
Committed patchset #2 manually as r20910 (presubmit successful).
https://codereview.chromium.org/240573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/247573008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Description:
Fix deoptimization problem with inlined Array.push()
R=ja...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/247573008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+17, -4 lines):
M src/deoptimizer.cc
Committed patchset #1 manually as r20909 (presubmit successful).
https://codereview.chromium.org/240223006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20909
Author: mstarzin...@chromium.org
Date: Wed Apr 23 12:48:32 2014 UTC
Log: Fix ToObject and Object.isSealed in four Array builtins.
R=mvstan...@chromium.org
TEST=mjsunit/regress/regress-builtinbust-6
Review URL: https://codereview.chromium.org/240223006
http://code.googl
Revision: 20908
Author: u...@chromium.org
Date: Wed Apr 23 12:28:50 2014 UTC
Log: Harden DefineOrRedefineDataProperty.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/240973002
http://code.google.com/p/v8/source/detail?r=20908
Modified:
/branches/bleeding_edge/s
Committed patchset #2 manually as r20908 (presubmit successful).
https://codereview.chromium.org/240973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20907
Author: joc...@chromium.org
Date: Wed Apr 23 12:28:43 2014 UTC
Log: Introduce .DEPS.git file to support full git checkouts
This is the result of running deps2git.py -d DEPS -o .DEPS.git -s -c /tmp
BUG=none
R=jkumme...@chromium.org, machenb...@chromium.org
LOG=n
Review
Committed patchset #1 manually as r20907 (presubmit successful).
https://codereview.chromium.org/246633009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20906
Author: da...@chromium.org
Date: Wed Apr 23 12:19:54 2014 UTC
Log: Version 3.25.28.14 (partial merge of r20839)
Fix Object.observe() notifications from Array.push()/Array.pop()
R=mstarzin...@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/247073002
http
Committed patchset #3 manually as r20906 (presubmit successful).
https://codereview.chromium.org/247073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Merged by r20903, closing CL.
https://codereview.chromium.org/246793007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
rubberstamp LGTM.
Note that the DEPS file is not intended for local usage, just for the
buildbots.
https://codereview.chromium.org/246633009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to t
Reviewers: Jakob, Michael Achenbach,
Description:
Introduce .DEPS.git file to support full git checkouts
This is the result of running deps2git.py -d DEPS -o .DEPS.git -s -c /tmp
BUG=none
R=machenb...@chromium.org,jkumme...@chromium.org
LOG=n
Please review this at https://codereview.chromium.o
Committed patchset #1 manually as r20905 (presubmit successful).
https://codereview.chromium.org/249183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20905
Author: joc...@chromium.org
Date: Wed Apr 23 11:51:28 2014 UTC
Log: Extract common macros and start a base library
BUG=v8:3015
R=svenpa...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/249183003
http://code.google.com/p/v8/source/detail?r=20905
Added:
lgtm. Nice test too.
https://codereview.chromium.org/240223006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h
File src/base/macros.h (right):
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode31
src/base/macros.h:31: #include "../../include/v8stdint.h"
On 2014/04/23 11:38:35, Sven Panne wrote:
Just a note: I thin
Added Dmitry as reviewer
https://codereview.chromium.org/240873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
LGTM with a nit
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h
File src/base/macros.h (right):
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode31
src/base/macros.h:31: #include "../../include/v8stdint.h"
Just a note: I think we have to reconsider ou
Revision: 20903
Author: u...@chromium.org
Date: Wed Apr 23 11:10:31 2014 UTC
Log: Version 3.26.22 (based on bleeding_edge revision r20902)
Disable field type tracking by default (Chromium issue 365172).
Performance and stability improvements on all platforms.
http://code.google.com/p/
Revision: 20904
Author: u...@chromium.org
Date: Wed Apr 23 11:10:51 2014 UTC
Log: Tagging version 3.26.22
http://code.google.com/p/v8/source/detail?r=20904
Added:
/tags/3.26.22
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received t
Updates:
Owner: yang...@chromium.org
Comment #5 on issue 3274 by yang...@chromium.org:
PropertyCallbackInfo.This() should return Local instead of
Local
http://code.google.com/p/v8/issues/detail?id=3274
(No comment was entered for this change.)
--
You received this message because t
Comment #4 on issue 3274 by joc...@chromium.org:
PropertyCallbackInfo.This() should return Local instead of
Local
http://code.google.com/p/v8/issues/detail?id=3274
PropertyCallbackInfo stuff has landed in chrome and blink, so you can
change the v8 side
--
You received this message becau
Reviewers: Sven Panne,
Description:
Extract common macros and start a base library
BUG=v8:3015
R=svenpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/249183003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+134, -71 lines):
A s
On 2014/04/23 09:06:30, wingo wrote:
lgtm.
https://codereview.chromium.org/248483004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Revision: 20902
Author: bmeu...@chromium.org
Date: Wed Apr 23 10:40:31 2014 UTC
Log: Disable field type tracking by default.
BUG=365172
LOG=y
R=u...@chromium.org
Review URL: https://codereview.chromium.org/247913005
http://code.google.com/p/v8/source/detail?r=20902
Modified:
/branch
Committed patchset #1 manually as r20902 (presubmit successful).
https://codereview.chromium.org/247913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc
File src/parser-thread.cc (right):
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc#newcode94
src/parser-thread.cc:94: preparser.set_allow_lazy(true);
On 2014/04/23 10:18:20, ulan wrote:
Would i
lgtm
https://codereview.chromium.org/247913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan,
Description:
Disable field type tracking by default.
Please review this at https://codereview.chromium.org/247913005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/flag-definitions.h
Index: src/flag-definitions.h
diff -
One suggestion, maybe for subsequent CL:
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc
File src/parser-thread.cc (right):
https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc#newcode94
src/parser-thread.cc:94: preparser.set_allow_lazy(true);
Wo
Revision: 20901
Author: bmeu...@chromium.org
Date: Wed Apr 23 09:41:28 2014 UTC
Log: Fix tracking of computed fields when field type tracking is
disabled.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/247523004
http://code.google.com/p/v8/source/detail?r=2090
Committed patchset #1 manually as r20901 (presubmit successful).
https://codereview.chromium.org/247523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/247523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
PTAL
Description:
Fix tracking of computed fields when field type tracking is disabled.
Please review this at https://codereview.chromium.org/247523004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/object
Committed patchset #1 manually as r20900 (presubmit successful).
https://codereview.chromium.org/246523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20900
Author: ja...@chromium.org
Date: Wed Apr 23 09:21:24 2014 UTC
Log: Avoid setting transitions in-place for cached maps when observed
R=verwa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/246523004
http://code.google.com/p/v8/source/detail?r=20900
Add
Reviewers: Yang,
Message:
PTAL
Description:
StringTable::LookupKey() and all callers handlified.
Please review this at https://codereview.chromium.org/249103002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+106, -158 lines):
M src/factory.h
M src/factory
1 - 100 of 117 matches
Mail list logo
