Comment #2 on issue 3392 by cor...@corsix.org: Miscompilation of numeric
comparison
http://code.google.com/p/v8/issues/detail?id=3392
For background, we've observed that part of one of our massive GWT webapps
has been broken in recent versions of Chrome, which was finally tied down
and re
Updates:
Status: Accepted
Cc: hpa...@chromium.org mstarzin...@chromium.org verwa...@chromium.org
Comment #1 on issue 3392 by jkumme...@chromium.org: Miscompilation of
numeric comparison
http://code.google.com/p/v8/issues/detail?id=3392
Thanks for the report. Interesting bug :-
lgtm
https://codereview.chromium.org/334913004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: jochen traveling until Jun 23,
Description:
Support external startup data in V8.
[Re-retry of r21696 and r21739]
If the embedder chooses, the 'natives' (library sources) and the
precompiled startup blob can be written to files during the build
process and handed over to V8 at startup
Reviewers: Benedikt Meurer,
Description:
Move random seed flag handling out of RNG
BUG=none
R=bmeu...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/333053002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -26 lines):
M src/isol
Comment #15 on issue 3337 by trev.nor...@gmail.com: Not caching map
transitions when using SetIndexedPropertiesToExternalArrayData()
http://code.google.com/p/v8/issues/detail?id=3337
Actually, nm. Seems the issue appeared from backporting the fix to 3.25.
The issue doesn't appear when backp
Comment #14 on issue 3337 by trev.nor...@gmail.com: Not caching map
transitions when using SetIndexedPropertiesToExternalArrayData()
http://code.google.com/p/v8/issues/detail?id=3337
ping
This issue isn't fixed as you can see by the flame graph I've provided.
There's still a massive perfor
Revision: 21847
Author: joc...@chromium.org
Date: Fri Jun 13 16:56:50 2014 UTC
Log: Fix x87 compile
TBR=ma...@chormium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/337713003
http://code.google.com/p/v8/source/detail?r=21847
Modified:
/branches/bleeding_edge/src/x87
Committed patchset #1 manually as r21847 (presubmit successful).
https://codereview.chromium.org/337713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: marja_chormium.org,
Description:
Fix x87 compile
TBR=ma...@chormium.org
LOG=n
BUG=none
Please review this at https://codereview.chromium.org/337713003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/x87/disasm-x87.cc
Index: s
Status: New
Owner:
New issue 3392 by cor...@corsix.org: Miscompilation of numeric comparison
http://code.google.com/p/v8/issues/detail?id=3392
The following code defines a deterministic function "enb" which performs
some numeric comparisons to return a boolean result, calls said function
Committed patchset #16 manually as r21846 (presubmit successful).
https://codereview.chromium.org/328343003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Comment #4 on issue 3347 by a...@google.com: Optimization causes dart2js to
fail in Try Dart
http://code.google.com/p/v8/issues/detail?id=3347
Seems to be fixed in Version 37.0.2046.3 canary.
--
You received this message because this project is configured to send all
issue notifications to
I added bottlenecks for object allocation events and object movement events
and
most likely fixed a bug (see comments below).
https://codereview.chromium.org/325553002/diff/60001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/325553002/diff/60001/src/mar
Thanks. No rush.
On Fri, Jun 13, 2014 at 10:55 AM, wrote:
> Oh and I'll land this CL next week, since it's Friday after-work-a-clock
> here.
>
>
> https://codereview.chromium.org/329413002/
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---
Reviewers: rossberg, Toon Verwaest,
Description:
Add machinery to support arguments escaping to safe builtins
BUG=
R=verwa...@chromium.org, rossb...@chromium.org
Please review this at https://codereview.chromium.org/330303002/
SVN Base: https://github.com/v8/v8.git@master
Affected files (+96,
https://codereview.chromium.org/332443002/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/ast.h#newcode1455
src/ast.h:1455: bool is_computed_name);
Is this flag needed? Isn't it implied by the type of key Expression
node?
https://codereview.
Reviewers: ulan, jochen traveling until Jun 23,
Description:
ARM64: updated literal pool implementation.
Currently the literal pool implemetation is inherited from the arm 32-bit
port
and it shares the same limitations: 4k of range and 1000 entries max. In
arm64
the load literal has a 1MB r
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21845 (presubmit successful).
Description:
Fix windows build (size_t vs. int) some more.
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=21845
Please review this at https://cod
Revision: 21845
Author: ma...@chromium.org
Date: Fri Jun 13 15:08:57 2014 UTC
Log: Fix windows build (size_t vs. int) some more.
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/336803002
http://code.google.com/p/v8/source/detail?r=21845
Modified:
/branc
Oh and I'll land this CL next week, since it's Friday after-work-a-clock
here.
https://codereview.chromium.org/329413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-d
LGTM (rubber-stamped).
https://codereview.chromium.org/334903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
On 2014/06/13 at 14:05:51, marja wrote:
On 2014/06/12 17:40:04, arv wrote:
> On 2014/06/12 at 07:25:16, marja wrote:
> > Code LGTM. Looks like a reasonable thing to do. There might be some
surprising
> breakage though, like, some scripts might have the wrong get/set
parameter
count
> inside l
Revision: 21844
Author: ma...@chromium.org
Date: Fri Jun 13 14:24:56 2014 UTC
Log: Fix windows build (size_t vs. int).
Sadly, Vector ctor takes an argument "int length".
TBR=dcar...@chromium.org, mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/334903002
http
Reviewers: dcarney, Michael Starzinger,
Message:
Committed patchset #1 manually as r21844 (presubmit successful).
Description:
Fix windows build (size_t vs. int).
Sadly, Vector ctor takes an argument "int length".
TBR=dcar...@chromium.org, mstarzin...@chromium.org
BUG=
Committed: https://code
https://codereview.chromium.org/332443002/diff/20001/test/mjsunit/object-literal-computed-names.js
File test/mjsunit/object-literal-computed-names.js (right):
https://codereview.chromium.org/332443002/diff/20001/test/mjsunit/object-literal-computed-names.js#newcode25
test/mjsunit/object-literal-
On 2014/06/12 17:40:04, arv wrote:
On 2014/06/12 at 07:25:16, marja wrote:
> Code LGTM. Looks like a reasonable thing to do. There might be some
surprising
breakage though, like, some scripts might have the wrong get/set parameter
count
inside lazy functions which were never executed. But I t
LGTM (rubber-stamped).
https://codereview.chromium.org/338553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
Revision: 21843
Author: ma...@chromium.org
Date: Fri Jun 13 13:45:49 2014 UTC
Log: Fix gn build.
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/338553002
http://code.google.com/p/v8/source/detail?r=21843
Modified:
/branches/bleeding_edge/BUILD.gn
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21843 (presubmit successful).
Description:
Fix gn build.
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=21843
Please review this at https://codereview.chromium.org/338553002/
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21842 (presubmit successful).
Description:
Fix clang build after r21839
R=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21842
Please review this at https://codereview.chromium.org/330
Revision: 21842
Author: jkumme...@chromium.org
Date: Fri Jun 13 13:39:01 2014 UTC
Log: Fix clang build after r21839
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/330793003
http://code.google.com/p/v8/source/detail?r=21842
Modified:
/branches/bleeding_edge/sr
LGTM (rubber-stamped).
https://codereview.chromium.org/330793003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
Committed patchset #12 manually as r21841 (presubmit successful).
https://codereview.chromium.org/314603004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Updates:
Status: Fixed
Comment #1 on issue 3063 by vego...@chromium.org: Support
Function.prototype.call in Crankshaft
http://code.google.com/p/v8/issues/detail?id=3063
Petka Antonov submitted a patch for this in r21840
--
You received this message because this project is configured
lgtm
https://codereview.chromium.org/333013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Cc: mstarzin...@chromium.org
Labels: Harmony
Comment #1 on issue 3391 by rossb...@chromium.org: Arguments objects should
have @@iterator == ArrayValues own property
http://code.google.com/p/v8/issues/detail?id=3391
I agree, the proliferation of extension hooks in ES6
thx again!
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h#newcode159
src/ast-value-factory.h:159: SYMBOL
On 2014/06/13 13:00:41, rossberg wrote:
Ni
lgtm
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h#newcode159
src/ast-value-factory.h:159: SYMBOL
Nitty nit: move up next to string
https://code
Revision: 21840
Author: verwa...@chromium.org
Date: Fri Jun 13 12:52:23 2014 UTC
Log: Optimize Function.prototype.call
- May inline the function, or call it directly, instead of going through
call
- Supports arguments object escaping when it escapes to builtins
(preparation for sli
Committed patchset #4 manually as r21840 (presubmit successful).
https://codereview.chromium.org/335683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21839
Author: jkumme...@chromium.org
Date: Fri Jun 13 12:19:04 2014 UTC
Log: Have one, long-lived map for bound functions.
This avoids creating a new map for every bound function. Bonus: some
cleanup in Runtime_FunctionBindArguments.
R=verwa...@chromium.org
Review URL: h
Comment #3 on issue 3347 by svenpa...@chromium.org: Optimization causes
dart2js to fail in Try Dart
http://code.google.com/p/v8/issues/detail?id=3347
I can reproduce this with Chrome 36.0.1985.67 beta on Linux x64, but not
with a fresh Chromium from ToT (37.0.2048.0 (276994) (64-bit)). @ahe
Committed patchset #2 manually as r21839 (presubmit successful).
https://codereview.chromium.org/335653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21838
Author: jkumme...@chromium.org
Date: Fri Jun 13 12:12:42 2014 UTC
Log: Keep maps when resetting elements.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/335553004
http://code.google.com/p/v8/source/detail?r=21838
Modified:
/branches/bleeding_edge
Committed patchset #2 manually as r21838 (presubmit successful).
https://codereview.chromium.org/335553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js
File test/mjsunit/compiler/inlined-call.js (right):
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js#newcode94
test/mjsunit/compiler/inlined-call.js:94: assertEqua
Updates:
Status: Accepted
Owner: ---
Cc: svenpa...@chromium.org yang...@chromium.org joc...@chromium.org
Comment #1 on issue 3378 by svenpa...@chromium.org: V8 counters and
histograms do not work in Chrome
http://code.google.com/p/v8/issues/detail?id=3378
As discussed
Nice, lgtm with some last comments regarding the tests.
If you address those, I'll land.
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js
File test/mjsunit/compiler/inlined-call.js (right):
https://codereview.chromium.org/335683002/diff/20001/test/mjsun
https://codereview.chromium.org/335553004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/335553004/diff/1/src/objects.cc#newcode4861
src/objects.cc:4861: if (object->map() ==
heap->sloppy_arguments_elements_map()) {
On 2014/06/12 21:58:03, Toon Verwaest wrote:
I like that suggestion.
https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc#newcode271
src/bootstrapper.cc:271: enum ForBoundFunctionMode {
On 2014/06/12 21:53:35, Toon Verwae
Is this CL still relevant?
https://codereview.chromium.org/196103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop re
On 2014/03/31 06:57:46, Benedikt Meurer wrote:
On 2014/01/28 13:11:26, jochen wrote:
> no, i think this can be landed
Do we actually want to land this?
+1 for either landing or closing this CL...
https://codereview.chromium.org/125133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
h
Some parts of this CL have already been landed in separate CLs:
https://codereview.chromium.org/23452022
https://codereview.chromium.org/24278004
Should the remaining parts of this CL be re-uploaded in a new (small) CL or
shall we simply close this?
Please try to split CLs into self-conta
What's the state of this CL?
https://codereview.chromium.org/214883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
On 2014/06/13 11:14:05, Sven Panne wrote:
What's the state of this CL?
On hold; the new best bet is to parse on a background thread while loading
(for
that, https://codereview.chromium.org/314603004/ is the first step). After
that
is done, this one might get resurrected (so we'd use severa
Thanks for review!
ulan@, since svenpanne@ reviewed everything, I'm not expecting you to
review too
(though, feel free to have a look if you want to). The same for vsevik@,
since
yurys@ has already reviewed.
I'm not going to land this until https://codereview.chromium.org/314603004/
lands,
Reviewers: rossberg,
Description:
Check alpha-sorting of includes during presubmit.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/333013002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+490, -460 lines):
M samples/lineproces
Committed patchset #2 manually as r21837 (presubmit successful).
https://codereview.chromium.org/331823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21837
Author: svenpa...@chromium.org
Date: Fri Jun 13 11:06:42 2014 UTC
Log: Reland "Rename kIs64BitArch with kRequiresCodeRange."
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/331823002
Patch from Weiliang Lin .
http://code.google.com/p/v8/source/det
Revision: 21836
Author: jkumme...@chromium.org
Date: Fri Jun 13 11:02:34 2014 UTC
Log: Remove one more arch-specific target name.
One more target had the architecture added to its name since r14209
originally landed and was missed when that change was reverted. Remove
the architecture
Committed patchset #1 manually as r21836 (presubmit successful).
https://codereview.chromium.org/334793004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Comment #6 on issue 2735 by wi...@igalia.com: Add support for @@iterator
http://code.google.com/p/v8/issues/detail?id=2735
Fixed in r21820. Some data structures are missing @@iterator
implementations; I'll be working on that.
--
You received this message because this project is configured t
Revision: 21835
Author: svenpa...@chromium.org
Date: Fri Jun 13 10:50:11 2014 UTC
Log: Emulate MLS on pre-ARMv6T2. Cleaned up thumbee vs. thumb2
confusion.
This should unbreak things on the Raspberry Pi.
LOG=y
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/3318
Committed patchset #2 manually as r21835 (presubmit successful).
https://codereview.chromium.org/331803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/331803003/diff/2/src/cpu.cc
File src/cpu.cc (right):
https://codereview.chromium.org/331803003/diff/2/src/cpu.cc#newcode395
src/cpu.cc:395: has_thumb2_ = HasListItem(features, "thumb2");
On 2014/06/13 10:38:23, Rodolph Perfetta wrote:
thumb2 doesn't get reported
LGTM, I'll land.
https://codereview.chromium.org/334793004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
LGTM (and the bots ;-), I'll land it for you.
https://codereview.chromium.org/331823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
https://codereview.chromium.org/331803003/diff/2/src/cpu.cc
File src/cpu.cc (right):
https://codereview.chromium.org/331803003/diff/2/src/cpu.cc#newcode395
src/cpu.cc:395: has_thumb2_ = HasListItem(features, "thumb2");
thumb2 doesn't get reported as such in cpuinfo:
* ARMv7 (or higher) => thumb
LGTM with nits.
https://codereview.chromium.org/316173002/diff/170001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/316173002/diff/170001/src/messages.js#newcode566
src/messages.js:566: $Array("source", "name", "source_url",
"source_mapping_url", "line_ends", "li
On 2014/06/13 10:17:57, Benedikt Meurer wrote:
This should be renamed to Thumb2. ThumbEE was the wrong name anyway.
But testing for T2 is correct, since mls was introduced with ARMv6T2.
Updated accordingly...
https://codereview.chromium.org/331803003/
--
--
v8-dev mailing list
v8-dev@googlegr
Reviewers: Jakob,
Description:
Remove one more arch-specific target name.
One more target had the architecture added to its name since r14209
originally landed and was missed when that change was reverted. Remove
the architecture from v8_libbase as well.
BUG=
Please review this at https://code
On 2014/06/13 10:13:23, Rodolph Perfetta wrote:
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc#newcode106
src/arm/assembler-arm.cc:106: if (FLAG_enable_m
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc#newcode106
src/arm/assembler-arm.cc:106: if (FLAG_enable_mls && cpu.has_thumbee())
supported_ |= 1u << MLS;
D
We tried to go down this route before, but by simplifying all object
accesses
into a either two loads or a load and a store. That had the disadvantage
of
reducing the accuracy of GVN and load/store elimination.
This approach doesn't that have the disadvantage of reducing the accuracy
of
th
Revision: 21834
Author: jkumme...@chromium.org
Date: Fri Jun 13 09:59:39 2014 UTC
Log: Allow all Names to be fast property names
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/329393005
http://code.google.com/p/v8/source/detail?r=21834
Modified:
/branches/bleedi
Committed patchset #1 manually as r21834 (presubmit successful).
https://codereview.chromium.org/329393005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Status: Accepted
Owner: wi...@igalia.com
CC: rossb...@chromium.org, a...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3391 by wi...@igalia.com: Arguments objects should have
@@iterator == ArrayValues own property
http://code.google.com/p/v8/issues/detail?id=3391
Since r24, ES6 spe
Committed patchset #1 manually as r21833 (presubmit successful).
https://codereview.chromium.org/323403008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21833
Author: jkumme...@chromium.org
Date: Fri Jun 13 09:46:29 2014 UTC
Log: Use generic representation when normalizing boilerplate properties
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/323403008
http://code.google.com/p/v8/source/detail?r=21833
Mo
rossberg@,
I had to do a non-trivial rebase because
https://codereview.chromium.org/332663004 got committed first.
So I'd need to internalize Symbol (as in, JavaScript symbols). There is
only one
type of Symbol produced by parsing as of now, so it's kinda hard to see
what's
the most elegant
LGTM
https://codereview.chromium.org/331803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2014/06/12 13:39:18, ulan wrote:
[+Ben]
Ben, wdyt about the HObjectAccess comment?
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions
lgtm
https://codereview.chromium.org/328343003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
Emulate MLS on pre-ARMv6T2.
This should unbreak things on the Raspberry Pi.
LOG=y
Please review this at https://codereview.chromium.org/331803003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -6 lines):
M src/a
Committed patchset #1 manually as r21832 (presubmit successful).
https://codereview.chromium.org/333643006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21832
Author: yang...@chromium.org
Date: Fri Jun 13 09:07:56 2014 UTC
Log: Mark timed range in the profile plot.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/333643006
http://code.google.com/p/v8/source/detail?r=21832
Modified:
/branches/bleeding_ed
Status: New
Owner:
New issue 3390 by sanxiyn: Android build does not rebuild when build
options are changed
http://code.google.com/p/v8/issues/detail?id=3390
If you run "make x64.release" and then "make x64.release disassembler=on",
it rebuilds correctly.
If you run "make android_arm
For handling arguments, I think we need some way to signal that a builtin
can
handle arguments properly, or? Or should all the builtins that cannot handle
arguments check for them (e.g. in the case of push it would check if the
first
argument is arguments, it already checks the receiver)?
ht
https://codereview.chromium.org/335683002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/335683002/diff/1/src/hydrogen.cc#newcode7978
src/hydrogen.cc:7978: bool
HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(
On 2014/06/12 21:41:13, Toon Verwaest wrote:
Drive-by comments.
https://codereview.chromium.org/332443002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/preparser.h#newcode1607
src/preparser.h:1607: is_computed_name = true;
Shouldn't the detection of this syntax live behin
Committed patchset #1 manually as r21831 (presubmit successful).
https://codereview.chromium.org/331823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21831
Author: u...@chromium.org
Date: Fri Jun 13 08:05:34 2014 UTC
Log: Disable regress/regress-2653 until
deopt_every_n_garbage_collections is fixed.
BUG=3389
LOG=N
R=ma...@chromium.org
Review URL: https://codereview.chromium.org/331823003
http://code.google.com/p/v8/sou
lgtm
https://codereview.chromium.org/331823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
I refined the macro definition so that when we invoke "make x32.release" on
Mac
and Windows, it will report the correct error message.
https://codereview.chromium.org/18014003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
An alternative is to run those test under V8_TARGET_ARCH_X64 ||
V8_TARGET_ARCH_ARM64 so that the code range feature is tested for the ports
requiring it.
https://codereview.chromium.org/331823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
Reviewers: marja,
Message:
PTAL
Description:
Disable regress/regress-2653 until deopt_every_n_garbage_collections is
fixed.
BUG=3389
LOG=N
Please review this at https://codereview.chromium.org/331823003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -0
Changed the assertion to ASSERT(!kRequiresCodeRange || requested <=
kMaximalCodeRangeSize);
I am glad I could access trybots now, thanks Michael!
https://codereview.chromium.org/331823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
Revision: 21830
Author: ish...@chromium.org
Date: Fri Jun 13 07:51:45 2014 UTC
Log: GVN fix, preventing loads hoisting above stores to the same field
when HObjectAccess's representation is not the same.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/331493006
ht
Committed patchset #1 manually as r21830 (presubmit successful).
https://codereview.chromium.org/331493006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
1 - 100 of 106 matches
Mail list logo
