PTAL
https://codereview.chromium.org/984773003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2015/03/06 21:20:40, titzer wrote:
On 2015/03/06 14:20:35, dougc wrote:
> On 2015/03/05 19:44:45, titzer wrote:
...
> var buffer = new ArrayBuffer(16*1024*1024);
> var asm = (function test (glob, env, b) {
...
Ok, we need to look into why context specialization doesn't catch this.
Moz
sho
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/2091)
https://codereview.chromium.org/989823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/989823002/1
https://codereview.chromium.org/989823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/tools/clang to ba7cd7c571bf618a8cec2690aab8885b338a8232
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/989823002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (
New review to cleanup serialize.cc and bring ppc dirs to be current
with changes over the last week. At time of submission it was current
with latest commits and ppc and ppc64 compiled/ran.
https://codereview.chromium.org/986553005/
https://codereview.chromium.org/882263003/
--
--
v8-dev mailin
Reviewers: danno, Sven Panne,
Message:
Patch to clean up serialize.cc and bring us to currency with changes from
the
last week
Description:
Contribution of PowerPC port (continuation of 422063005) - serialize.cc
cleanup
Contribution of PowerPC port (continuation of 422063005,
817143002,86
Patchset 4 (id:??) landed as
https://crrev.com/9633ebabd405c264d33f603f8798c31f59418dcd
Cr-Commit-Position: refs/heads/master@{#27054}
https://codereview.chromium.org/957273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #4 (id:230001)
https://codereview.chromium.org/957273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: jbramley, Benedikt Meurer,
Description:
Use a different variant of CpuFeatures::FlushICache asm with clang.
This variant avoids a constant pool entry, which can be problematic
when LTO'ing. It is also slightly shorter.
According to the description of https://codereview.chromium.org/3
Status: New
Owner:
New issue 3950 by coola...@gmail.com: compile javascript asynchronously
https://code.google.com/p/v8/issues/detail?id=3950
Architecture: ARM
THE PROBLEM
--
I have so much JavaScript in my application that it is too much to load in
a single minified fil
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/957273002/230001
https://codereview.chromium.org/957273002/revert
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
LGTM. I am looking forward to have a new store buffer implementation that
avoids
complicated code like that.
https://codereview.chromium.org/957273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
On 2015/03/06 14:20:35, dougc wrote:
On 2015/03/05 19:44:45, titzer wrote:
> As far as I can tell, this just duplicates the logic of context
specialization
> in the graph builder. The only advantage here I see is that it avoids
inserting
> a branch that would be immediately optimized away after
Comment #83 on issue 2599 by math...@qiwi.be: Implement "use asm"
https://code.google.com/p/v8/issues/detail?id=2599
@ODensmore:
https://github.com/petkaantonov/bluebird/wiki/Optimization-killers
--
You received this message because this project is configured to send all
issue notification
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/984463003/1
https://codereview.chromium.org/984463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Committed patchset #1 (id:1)
https://codereview.chromium.org/984463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/087c8298a0a37561702e502f07af03c9a6949d23
Cr-Commit-Position: refs/heads/master@{#27052}
https://codereview.chromium.org/984463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Reviewers: Yang, jochen (traveling),
Message:
Created Revert of Revert of Revert of Turn on job based recompilation
Description:
Revert of Revert of Revert of Turn on job based recompilation (patchset #1
id:1
of https://codereview.chromium.org/955723002/)
Reason for revert:
Breaks Octane on
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/984463003/ by rmcil...@chromium.org.
The reason for reverting is: Breaks Octane on Arm64 running on Chrome.
BUG=464538.
https://codereview.chromium.org/955723002/
--
--
v8-dev mailing list
v8-dev@googleg
Comment #82 on issue 2599 by odensm...@gmail.com: Implement "use asm"
https://code.google.com/p/v8/issues/detail?id=2599
Is there a pointer to how to write JS code that will not de-optimize the
optimizers? A list of bad practices that will hurt optimization?
--
You received this message beca
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc
File src/compiler/visualizer.cc (right):
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc#newcode824
src/compiler/visualizer.cc:824: std::ostream& operator<<(std::ostream&
os, const Sch
Comment #7 on issue 2180 by caitpott...@gmail.com: ObjectTemplate needs
SetClassName too
https://code.google.com/p/v8/issues/detail?id=2180
Might be worth working that out with heycam et all for webidl?
--
You received this message because this project is configured to send all
issue notif
Comment #5 on issue 2180 by jsb...@chromium.org: ObjectTemplate needs
SetClassName too
https://code.google.com/p/v8/issues/detail?id=2180
Does this need API, or can Blink just use @@toStringTag ?
Is that still a work in progress, tracked at issue 3502 ?
--
You received this message because
Comment #6 on issue 2180 by a...@chromium.org: ObjectTemplate needs
SetClassName too
https://code.google.com/p/v8/issues/detail?id=2180
IMO, we should just transition to @@toStringTag.
--
You received this message because this project is configured to send all
issue notifications to this a
Patchset 2 (id:??) landed as
https://crrev.com/9e482baf81d9c742be48b30cde8a55c5a17f2b0a
Cr-Commit-Position: refs/heads/master@{#27051}
https://codereview.chromium.org/982153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
I applied the first layer of StackHandler'b'gone and let it soak for a
while. I
think after four more applications we should be good. :)
https://codereview.chromium.org/985803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this mes
Reviewers: Yang,
Description:
Remove code object from StackHandler.
This reduces the size of the StackHandler by one word. We no longer
need to keep track of the code objects, as the stack walk find it.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/985803002/
Ba
Committed patchset #2 (id:20001)
https://codereview.chromium.org/982153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Reviewers: alph, yurys,
Message:
PTAL
Description:
CpuProfiler: fix for GetDeoptReason code.
The original code always returned the first entry from RelocInfo that
matched
with
bailout_id. But we may have a few different deopt reasons for one
bailout_id.
So we need to get the one which matc
Committed patchset #1 (id:1)
https://codereview.chromium.org/987653005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/c23035cdd0b47afe3717c1a25f13ca075af0c1a2
Cr-Commit-Position: refs/heads/master@{#27049}
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Patchset 1 (id:??) landed as
https://crrev.com/6f946d6c02ec99022e4af8bc3b54020da9551166
Cr-Commit-Position: refs/heads/master@{#27050}
https://codereview.chromium.org/987653005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
I like this better.
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc#newcode1455
src/scopes.cc:1455: if (!IsConciseMethod(function_kind_) &&
!IsConstructor(function_kind_)) {
This
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/982153003/20001
https://codereview.chromium.org/982153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
LGTM
https://codereview.chromium.org/982153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2015/03/06 16:11:16, arv wrote:
On 2015/03/06 15:22:49, kalman wrote:
> > _not_ a full super star committer.
>
> That line gets on my nerves.
Just change the reviewers :-)
I meant in general :)
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
[turbofan] Add an extra frame state for deoptimization before binary op.
BUG=
Please review this at https://codereview.chromium.org/983153002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affecte
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/987653005/1
https://codereview.chromium.org/987653005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
No, I was confused. I was just failing w/ unnamed classes but I fixed that.
Now I still think that this makes sense as an step forward; we don't yet
produce
errors for methods inside object literals inside computed property names
(bug
filed) but the overall state is saner (stronger?) after t
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/986463005/1
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
LGTM!
https://codereview.chromium.org/987653005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2015/03/06 13:52:13, caitp wrote:
The error is that the `prototype` property is set up with writable=false,
configurable=false properties --- so the expected error is either
`strict_cannot_assign` or `strict_read_only_property`, and shouldn't
affect
sloppy mode once the construct is availab
On 2015/03/06 15:22:49, kalman wrote:
> _not_ a full super star committer.
That line gets on my nerves.
Just change the reviewers :-)
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this me
Disclaimer, after patch set 10 this is a rewritten version:
1) No CLASS_SCOPE, we don't want to add "class context" which would
basically be
the same as block context. Instead, allow tagging some block scopes as class
scopes.
2) Not all functions inside a class scope are methods, so we need to
Reviewers: danno, Michael Achenbach, Jakob, paul.l..., akos.palfi.imgtec,
balazs.kilvady,
Description:
MIPS: Update test status files.
TEST=
BUG=
Please review this at https://codereview.chromium.org/987653005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0,
Patchset 4 (id:??) landed as
https://crrev.com/1e638c3610ec6938e5fb16c42018642195782fb2
Cr-Commit-Position: refs/heads/master@{#27048}
https://codereview.chromium.org/988693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #4 (id:60001)
https://codereview.chromium.org/988693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
_not_ a full super star committer.
That line gets on my nerves.
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
All required reviewers (with asterisk prefixes) have not yet approved this
CL.
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involv
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/986463005/1
https://codereview.chromium.org/986463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Comment #1 on issue 3948 by rossb...@chromium.org: strong mode: early
reference error missing when a computed property name of C contains an
object literal w/ a method that refers to C
https://code.google.com/p/v8/issues/detail?id=3948
Is this specific to methods, or does it apply to functi
Comment #2 on issue 3948 by ma...@chromium.org: strong mode: early
reference error missing when a computed property name of C contains an
object literal w/ a method that refers to C
https://code.google.com/p/v8/issues/detail?id=3948
It's specific to methods. This bug talks about the state a
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
[turbofan] Add schedule to visualizer output
Please review this at https://codereview.chromium.org/985023002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+121, -998 lines):
M src/compiler/basic-block-
Committed patchset #3 (id:40001)
https://codereview.chromium.org/981213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Status: New
Owner:
New issue 3949 by fedor.in...@gmail.com: Object circular leak via some v8
internals
https://code.google.com/p/v8/issues/detail?id=3949
Version: 4.1.0.21
OS: Any
Architecture: x64, but likely others too
What steps will reproduce the problem?
1. git clone https://github
Patchset 3 (id:??) landed as
https://crrev.com/206303f7036798979f129e208cb811fc1e9dd8c1
Cr-Commit-Position: refs/heads/master@{#27047}
https://codereview.chromium.org/981213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/988693003/60001
https://codereview.chromium.org/988693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Status: Accepted
Owner: ma...@chromium.org
CC: dslo...@chromium.org, rossb...@chromium.org, a...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3948 by ma...@chromium.org: strong mode: early reference error
missing when a computed property name of C contains an object literal w/ a
Comment #6 on issue 3947 by bugdro...@chromium.org: Simplify and unify the
handling of intrinsics in the various compilers
https://code.google.com/p/v8/issues/detail?id=3947#c6
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/e2ce456754368cb11a24cac
On 2015/03/06 14:24:30, Toon Verwaest wrote:
PTAL
lgtm.
https://codereview.chromium.org/988693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Patchset 2 (id:??) landed as
https://crrev.com/e2ce456754368cb11a24cacc2a1d1c5fe6f05e5b
Cr-Commit-Position: refs/heads/master@{#27046}
https://codereview.chromium.org/983183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/983183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/981213002/40001
https://codereview.chromium.org/981213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
This approach looks good to me, and seems like CLASS_SCOPE is unnecessary
complication indeed. As discussed offline, this still does not report an
error
in the following case:
class C {
[ o = { m() { ... C ... } }; o.m();] { }
}
but that be fixed in a later CL.
I have some test sugges
On 2015/03/06 10:01:06, arv wrote:
On 2015/03/05 23:25:57, caitp wrote:
> I dunno if anyone has an opinion on this, but I think it's weird to say
> "constructor can't be an accessor" when it's not.
I agree. This is an improvement.
Can you add some tests (in test/message/)?
Certainly, done
Committed patchset #1 (id:1)
https://codereview.chromium.org/984833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/5de20c05d54f0d0585b083764bdd8d78cb7ef350
Cr-Commit-Position: refs/heads/master@{#27045}
https://codereview.chromium.org/984833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc#newcode9938
src/hydrogen.cc:9938: (this->*generator)(expr);
On 2015/03/06 14:13:16, Michael Starzinger wrote:
nit: DCHECK(generator !=
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/983183002/20001
https://codereview.chromium.org/983183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (left):
https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc#oldcode2613
src/bootstrapper.cc:2613: // TODO(mstarzinger): This is just a temporary
hack to make TurboFan work,
On 2
Reviewers: Yang, dcarney,
Message:
PTAL
Description:
Store the next serial number in the function cache rather than in the
isolate.
BUG=
Please review this at https://codereview.chromium.org/988693003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+18, -7 li
One more nit (unless I am late to the party already).
https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc#newcode11
src/compiler/pipeline.cc:11: #includ
On 2015/03/05 19:44:45, titzer wrote:
As far as I can tell, this just duplicates the logic of context
specialization
in the graph builder. The only advantage here I see is that it avoids
inserting
a branch that would be immediately optimized away after the first round of
context specializatio
LGTM.
https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc#newcode9938
src/hydrogen.cc:9938: (this->*generator)(expr);
nit: DCHECK(generator != nullptr) or make sure the
FindInlineFunction
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/984833003/1
https://codereview.chromium.org/984833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Committed patchset #4 (id:270001)
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 4 (id:??) landed as
https://crrev.com/233ea0eef8510063ea8a27a2b8261b23bdd78a6b
Cr-Commit-Position: refs/heads/master@{#27044}
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM with comments.
https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2969
src/compiler/ast-graph-builder.cc:2969: r
Reviewers: Michael Starzinger,
Description:
Intrinsics in the RUNTIME_FUNCTION_LIST are now available with '_', too.
Now the three intrinsic lists only differ in their compiler
support. Unifying the lists and making the logic what is supported in
which compiler local to the compilers themselves
On 2015/03/06 13:52:48, Michael Achenbach wrote:
FYI: CL description and subject are different. But never mind - I guess
the CL
description is turned into the commit message...
Yes. I kept it that way (auto-generated title, manually edited description)
so
that GMail succeeds in grouping the
FYI: CL description and subject are different. But never mind - I guess the
CL
description is turned into the commit message...
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message beca
Comment #5 on issue 3947 by bugdro...@chromium.org: Simplify and unify the
handling of intrinsics in the various compilers
https://code.google.com/p/v8/issues/detail?id=3947#c5
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/d8416f5524830213ce1a618
The error is that the `prototype` property is set up with writable=false,
configurable=false properties --- so the expected error is either
`strict_cannot_assign` or `strict_read_only_property`, and shouldn't affect
sloppy mode once the construct is available in sloppy mode.
I think this could be
Patchset 2 (id:??) landed as
https://crrev.com/d8416f5524830213ce1a618c344d776f50f91bf2
Cr-Commit-Position: refs/heads/master@{#27043}
https://codereview.chromium.org/984963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
On 2015/03/06 06:38:43, loislo wrote:
On 2015/03/05 15:05:48, Sven Panne wrote:
> Or even simpler: Just avoid pointers altogether here and simply
construct
the
> object directly without new?
I don't know the exact reason but test is failing on OpenHandle when I
construct
the processor on
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
[turbofan] Introduce JSStackCheck operator.
The key idea here is that the stack check should be explicit, such that
we can eliminate unnecessary stack checks after graph building and
potentially inlining.
Please review this at https://c
Committed patchset #2 (id:20001)
https://codereview.chromium.org/984963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
lgtm
https://codereview.chromium.org/984833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/984963002/20001
https://codereview.chromium.org/984963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/988703002/270001
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Reviewers: ulan,
Description:
Do not use eternal handles when creating a start-up snapshot.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/984833003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -0 lines):
M src/date.js
M src/
LGTM.
https://codereview.chromium.org/984963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/988703002/30004
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/988703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm, awesome
https://codereview.chromium.org/981213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
LGTM on the TF part, didn't look at the rest.
https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (left):
https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc#oldcode2613
src/bootstrapper.cc:2613: // TODO(mstarzinger): This is ju
Reviewers: Michael Starzinger,
Message:
Includes some funky "git cl format" stuff... :-/
Description:
Intrinsics in the INLINE_FUNCTION_LIST are now avaliable without '_', too.
This involved renaming apart a few more intrinsics. In the long run,
we want to clean up redundant intrinsics which ju
Committed patchset #1 (id:1)
https://codereview.chromium.org/979243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
1 - 100 of 167 matches
Mail list logo
