[v8-dev] Re: Android IA32: enable PIE (issue 1145513006 by jing....@intel.com)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1145513006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Android IA32: enable PIE (issue 1145513006 by jing....@intel.com)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/6726406c09eed3887c51eb3d3752701e3ab66bfe Cr-Commit-Position: refs/heads/master@{#28571} https://codereview.chromium.org/1145513006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Where is the Isolate destructor of v8 called in the chromium classic browser?

2015-05-21 Thread Yun Ji Kim
In the chromium browser, does anyone know where the Isolate destructor of v8 is called? I'm working on the classic browser in the lollipop-mr1(android-5.1.0_r1). The Isolate constructor was called from the browser, but I couldn't find the point that the Isolate destructor was called when the bro

[v8-dev] Re: Move hash code from hidden string to a private symbol (issue 1149863005 by erikco...@chromium.org)

2015-05-21 Thread erik . corry
https://codereview.chromium.org/1149863005/diff/40001/src/collection.js File src/collection.js (right): https://codereview.chromium.org/1149863005/diff/40001/src/collection.js#newcode5 src/collection.js:5: var $gethash; On 2015/05/21 19:11:32, adamk wrote: Rename to $getHash Done. https://co

[v8-dev] Re: Generalize alignment in heap GC functions. (issue 1152513002 by bbu...@chromium.org)

2015-05-21 Thread hpayer
https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc#newcode2257 src/heap/heap.cc:2257: #define kObjectAligned kDoubleAligned Why do we need this? https://codereview.chromium.

[v8-dev] Re: Android IA32: enable PIE (issue 1145513006 by jing....@intel.com)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145513006/1 https://codereview.chromium.org/1145513006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Type::Internal() should have representation kMachPtr (issue 1154463004 by da...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/03aae81998c138eeb4b24adca67d0b116bee0980 Cr-Commit-Position: refs/heads/master@{#28570} https://codereview.chromium.org/1154463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Type::Internal() should have representation kMachPtr (issue 1154463004 by da...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1154463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1157613002 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1157613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1157613002 by machenb...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/67c0dcbe1bfa6856e8691097b7f32926a6df5bea Cr-Commit-Position: refs/heads/master@{#28569} https://codereview.chromium.org/1157613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1157613002 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157613002/1 https://codereview.chromium.org/1157613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1157613002 by machenb...@chromium.org)

2015-05-21 Thread machenbach
Reviewers: Hannes Payer, ulan, Message: Created Revert of Revert of Pass GC flags to incremental marker and start incremental marking with Description: Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #1 id:1 of https://codereview.chromium.

[v8-dev] Re: Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1151143002 by machenb...@chromium.org)

2015-05-21 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1157613002/ by machenb...@chromium.org. The reason for reverting is: Wasn't the reason https://codereview.chromium.org/1151143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.googl

[v8-dev] Re: Type::Internal() should have representation kMachPtr (issue 1154463004 by da...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154463004/1 https://codereview.chromium.org/1154463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Issue 4136 in v8: Building V8 on windows

2015-05-21 Thread codesite-noreply via v8-dev
Comment #2 on issue 4136 by nand.tor...@gmail.com: Building V8 on windows https://code.google.com/p/v8/issues/detail?id=4136 Tried,group(v8-users)does not exist. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust yo

[v8-dev] Re: Type::Internal() should have representation kMachPtr (issue 1154463004 by da...@chromium.org)

2015-05-21 Thread bmeurer
LGTM. https://codereview.chromium.org/1154463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 4139 in v8: android.arm shared library fails to load

2015-05-21 Thread codesite-noreply via v8-dev
Comment #1 on issue 4139 by akad...@wizcorp.jp: android.arm shared library fails to load https://code.google.com/p/v8/issues/detail?id=4139 the above link has moved to: https://github.com/AlmirKadric/jslib-V8Engine/tree/develop/test/helloworld/shared -- You received this message because this

[v8-dev] [strong] Implement per-object restrictions behaviour of property freezing (issue 1142393003 by conr...@chromium.org)

2015-05-21 Thread conradw
Reviewers: rossberg, arv, Message: PTAL Description: [strong] Implement per-object restrictions behaviour of property freezing Implements the strong mode proposal's restrictions on changing a strong object's writable, non-configurable property to non-writable. Setting the strong bit is stil

[v8-dev] Re: [strong] Implement per-object restrictions behaviour for prototype setting (issue 1143623002 by conr...@chromium.org)

2015-05-21 Thread conradw
PTAL, updated https://codereview.chromium.org/1143623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

[v8-dev] [strong] Implement per-object restrictions behaviour of delete operator (issue 1156573002 by conr...@chromium.org)

2015-05-21 Thread conradw
Reviewers: rossberg, arv, Message: PTAL Description: [strong] Implement per-object restrictions behaviour of delete operator Implements the strong mode proposal's restrictions on the behaviour of the delete operator for strong objects. Setting the strong bit is still wip, so this change will o

[v8-dev] Re: [strong] Implement per-object restrictions behaviour of delete operator (issue 1144453002 by conr...@chromium.org)

2015-05-21 Thread conradw
On 2015/05/18 13:46:40, rossberg wrote: This one should definitely have a cctest for the API. Does that go through the JS as well? It doesn't, so changing the runtime won't work :(. Between this and a rebase, I've shoved the fixed version into another CL. https://codereview.chromium.org/11

[v8-dev] Re: Issue 4140 in v8: Generator method `prototype` property incorrectly defined as non-writable

2015-05-21 Thread codesite-noreply via v8-dev
Comment #1 on issue 4140 by m...@bocoup.com: Generator method `prototype` property incorrectly defined as non-writable https://code.google.com/p/v8/issues/detail?id=4140 This applies to generator function instances created via other declarative forms, as well: $ d8 -e "function* g() {}

[v8-dev] Add basic API support for Map & Set (issue 1157453002 by ad...@chromium.org)

2015-05-21 Thread adamk
Reviewers: arv, jochen, Description: Add basic API support for Map & Set Only supports constructing new objects and returning size. Followup patch will need to add ability to retrieve and set contents in order to support structured clone. Also removes a bunch of outdated "experimental" markers

[v8-dev] Re: Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1151143002 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1151143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1151143002 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151143002/1 https://codereview.chromium.org/1151143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1151143002 by machenb...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 Cr-Commit-Position: refs/heads/master@{#28568} https://codereview.chromium.org/1151143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread machenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1151143002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Speculative revert because chromebook is really misbehaving: http://build.chromium.org/p/client.v8/builders/V8%20Arm/bui

[v8-dev] Revert of Pass GC flags to incremental marker and start incremental marking with (issue 1151143002 by machenb...@chromium.org)

2015-05-21 Thread machenbach
Reviewers: Hannes Payer, ulan, Message: Created Revert of Pass GC flags to incremental marker and start incremental marking with Description: Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/)

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread caitpotter88
https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc#newcode309 src/x64/full-codegen-x64.cc:309: __ movp(LoadDescriptor::ReceiverRegister(),

[v8-dev] Re: Move hash code from hidden string to a private symbol (issue 1149863005 by erikco...@chromium.org)

2015-05-21 Thread erik . corry
https://codereview.chromium.org/1149863005/diff/40001/src/collection.js File src/collection.js (left): https://codereview.chromium.org/1149863005/diff/40001/src/collection.js#oldcode26 src/collection.js:26: for (var entry = HashToEntry(table, hash, numBuckets); On 2015/05/21 19:11:32, adamk wrot

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread caitpotter88
https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc#newcode309 src/x64/full-codegen-x64.cc:309: __ movp(LoadDescriptor::ReceiverRegister(),

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread arv
On 2015/05/21 18:12:35, caitp wrote: On 2015/05/21 17:56:20, arv wrote: > On 2015/05/20 22:38:34, arv wrote: > > I've cleanly applied the patch now. > > > > There is some problem related to call spread. > > test/mjsunit/harmony/spread-call-super-property.js is failing now. > > > > I'm also seeing

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread arv
https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/1135243004/diff/120001/src/x64/full-codegen-x64.cc#newcode309 src/x64/full-codegen-x64.cc:309: __ movp(LoadDescriptor::ReceiverRegister(),

[v8-dev] Re: Move hash code from hidden string to a private symbol (issue 1149863005 by erikco...@chromium.org)

2015-05-21 Thread adamk
Thanks for the detailed writeup, can you move the important bits of that into the CL description for posterity? https://codereview.chromium.org/1149863005/diff/40001/src/collection.js File src/collection.js (left): https://codereview.chromium.org/1149863005/diff/40001/src/collection.js#oldcod

[v8-dev] Issue 4140 in v8: Generator method `prototype` property incorrectly defined as non-writable

2015-05-21 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4140 by m...@bocoup.com: Generator method `prototype` property incorrectly defined as non-writable https://code.google.com/p/v8/issues/detail?id=4140 Version: 7ffdb5194d51a5813f9474d2453859c376223b18 (Thu May 21 10:47:07 2015 -0700) OS: Ubuntu Linux

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #3 (id:40001) https://codereview.chromium.org/1156463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc Cr-Commit-Position: refs/heads/master@{#28567} https://codereview.chromium.org/1156463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/4438) https://codereview.chromium.org/1148633005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-d

[v8-dev] Re: [strong] cache strong object literal maps (issue 1145213005 by rossb...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5040) https://codereview.chromium.org/1145213005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: Fixing Heap::Available() to return total of all spaces. (issue 1141693003 by s...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/3f162d416e32caad3f28006c213227bb0e945128 Cr-Commit-Position: refs/heads/master@{#28566} https://codereview.chromium.org/1141693003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Fixing Heap::Available() to return total of all spaces. (issue 1141693003 by s...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1141693003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread caitpotter88
On 2015/05/21 17:56:20, arv wrote: On 2015/05/20 22:38:34, arv wrote: > I've cleanly applied the patch now. > > There is some problem related to call spread. > test/mjsunit/harmony/spread-call-super-property.js is failing now. > > I'm also seeing an invalid BailoutId in the same test with TF. > >

[v8-dev] Re: [es6] Support super.property in eval and arrow functions (issue 1135243004 by a...@chromium.org)

2015-05-21 Thread arv
On 2015/05/20 22:38:34, arv wrote: I've cleanly applied the patch now. There is some problem related to call spread. test/mjsunit/harmony/spread-call-super-property.js is failing now. I'm also seeing an invalid BailoutId in the same test with TF. I'll look closer tomorrow. Caitlin, it

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/7ffdb5194d51a5813f9474d2453859c376223b18 Cr-Commit-Position: refs/heads/master@{#28565} https://codereview.chromium.org/1149043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #2 (id:20001) https://codereview.chromium.org/1149043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Issue 4137 in v8: Support elements in the LookupIterator

2015-05-21 Thread codesite-noreply via v8-dev
Comment #4 on issue 4137 by bugdro...@chromium.org: Support elements in the LookupIterator https://code.google.com/p/v8/issues/detail?id=4137#c4 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a40e85d668919a2afab69355e1d3bad6bbfbaaf0 commit a40e8

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156463002/40001 https://codereview.chromium.org/1156463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Prepare GetProperty(Attributes)WithInterceptor to support elements (issue 1147863002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #5 (id:11) https://codereview.chromium.org/1147863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Prepare GetProperty(Attributes)WithInterceptor to support elements (issue 1147863002 by verwa...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/a40e85d668919a2afab69355e1d3bad6bbfbaaf0 Cr-Commit-Position: refs/heads/master@{#28564} https://codereview.chromium.org/1147863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [strong] create strong arry literals (issue 1151853003 by rossb...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/627) https://codereview.chromium.org/1151853003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group

[v8-dev] Re: Fixing Heap::Available() to return total of all spaces. (issue 1141693003 by s...@chromium.org)

2015-05-21 Thread ssid
On 2015/05/20 08:56:13, Hannes Payer wrote: Large object space is special. There is no memory available in this space. Each object has its own page and leftover memory (because of right trimming) cannot be reused. Therefore, it calls the system memory allocator and asks if there is more spa

[v8-dev] Re: Fixing Heap::Available() to return total of all spaces. (issue 1141693003 by s...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141693003/1 https://codereview.chromium.org/1141693003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread dslomov
https://codereview.chromium.org/1149043005/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1149043005/diff/1/src/parser.cc#newcode3461 src/parser.cc:3461: // special case for legacy for (var/const x = in) On 2015/05/21 17:18:04, rossberg wrote: Does this act

[v8-dev] Re: [strong] create strong arry literals (issue 1151853003 by rossb...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/20001 https://codereview.chromium.org/1151853003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [strong] cache strong object literal maps (issue 1145213005 by rossb...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145213005/20001 https://codereview.chromium.org/1145213005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148633005/20001 https://codereview.chromium.org/1148633005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread rossberg
https://codereview.chromium.org/1149043005/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1149043005/diff/1/src/parser.cc#newcode3461 src/parser.cc:3461: // special case for legacy for (var/const x = in) Does this actually work with const? You are doing a re

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread hpayer
https://codereview.chromium.org/1148633005/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/1148633005/diff/1/src/heap/gc-tracer.cc#newcode626 src/heap/gc-tracer.cc:626: return static_cast(allocated_bytes / kThroughputTimeFrame); On 2015/05/21 15:2

[v8-dev] Re: [strong] create strong arry literals (issue 1151853003 by rossb...@chromium.org)

2015-05-21 Thread dslomov
lgtm https://codereview.chromium.org/1151853003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread ulan
thanks, landing https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc#newcode470 src/heap/incremental-marking.cc:470: void IncrementalMarki

[v8-dev] Re: [strong] cache strong object literal maps (issue 1145213005 by rossb...@chromium.org)

2015-05-21 Thread dslomov
lgtm https://codereview.chromium.org/1145213005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread hpayer
LGTM, just one renaming nit https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc#newcode470 src/heap/incremental-marking.cc:470: void Incr

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149043005/20001 https://codereview.chromium.org/1149043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread dslomov
Landing https://codereview.chromium.org/1149043005/diff/1/test/mjsunit/harmony/destructuring.js File test/mjsunit/harmony/destructuring.js (right): https://codereview.chromium.org/1149043005/diff/1/test/mjsunit/harmony/destructuring.js#newcode680 test/mjsunit/harmony/destructuring.js:680: var o

[v8-dev] Re: [strong] cache strong object literal maps (issue 1145213005 by rossb...@chromium.org)

2015-05-21 Thread rossberg
https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js File test/mjsunit/strong/literals.js (right): https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js#newcode105 test/mjsunit/strong/literals.js:105: // TODO(rossberg): teach strongness to

[v8-dev] Re: Update UTF-8 decoder to detect more special cases. (issue 1148653007 by joc...@chromium.org)

2015-05-21 Thread vogelheim
I'm afraid this CL has left me largely confused. https://codereview.chromium.org/1148653007/diff/1/src/unicode.cc File src/unicode.cc (right): https://codereview.chromium.org/1148653007/diff/1/src/unicode.cc#newcode205 src/unicode.cc:205: 4, 4, 4, 4, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; The tab

[v8-dev] Re: Remove v8::Private (issue 1152523002 by joc...@chromium.org)

2015-05-21 Thread jochen
ptal https://codereview.chromium.org/1152523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Pass GC flags to incremental marker and start incremental marking with (issue 1156463002 by u...@chromium.org)

2015-05-21 Thread ulan
Reviewers: Hannes Payer, Message: PTAL Description: Pass GC flags to incremental marker and start incremental marking with reduce memory footprint in idle notification. BUG= Please review this at https://codereview.chromium.org/1156463002/ Base URL: https://chromium.googlesource.com/v8/v8.git

[v8-dev] Re: Prepare GetProperty(Attributes)WithInterceptor to support elements (issue 1147863002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147863002/11 https://codereview.chromium.org/1147863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc

[v8-dev] Re: Prepare GetProperty(Attributes)WithInterceptor to support elements (issue 1147863002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147863002/80001 https://codereview.chromium.org/1147863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread arv
LGTM https://codereview.chromium.org/1149043005/diff/1/test/mjsunit/harmony/destructuring.js File test/mjsunit/harmony/destructuring.js (right): https://codereview.chromium.org/1149043005/diff/1/test/mjsunit/harmony/destructuring.js#newcode680 test/mjsunit/harmony/destructuring.js:680: var o =

[v8-dev] Re: Remove obsolete JSFunction::IsOptimizable predicate. (issue 1146423002 by mstarzin...@chromium.org)

2015-05-21 Thread titzer
On 2015/05/21 16:30:53, Michael Starzinger wrote: Patch Set #1: Just pure reland. Patch Set #2: Fixed assertion. LGTM https://codereview.chromium.org/1146423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

[v8-dev] Remove obsolete JSFunction::IsOptimizable predicate. (issue 1146423002 by mstarzin...@chromium.org)

2015-05-21 Thread mstarzinger
Reviewers: titzer, Message: Patch Set #1: Just pure reland. Patch Set #2: Fixed assertion. Description: Remove obsolete JSFunction::IsOptimizable predicate. This just delegates to SharedFunctionInfo::optimization_disabled and was primarily used for assertions. Removing it due to misleading name

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/e514015264f1e0193b57dee76487c85d24f7e4f1 Cr-Commit-Position: refs/heads/master@{#28563} https://codereview.chromium.org/1145213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #3 (id:40001) https://codereview.chromium.org/1145213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] [strong] create strong arry literals (issue 1151853003 by rossb...@chromium.org)

2015-05-21 Thread 'rossberg' via codereview.chromium.org
Reviewers: Dmitry Lomov (chromium), Description: [strong] create strong arry literals R=dslo...@chromium.org BUG= Please review this at https://codereview.chromium.org/1151853003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+253, -173 lines): M src/compiler/

[v8-dev] Re: Reland "Avoid excessive GCs in small heaps." (issue 1148953005 by u...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/b59fda16fcc3a8b3d49acee72cfea7253c556b7d Cr-Commit-Position: refs/heads/master@{#28562} https://codereview.chromium.org/1148953005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland "Avoid excessive GCs in small heaps." (issue 1148953005 by u...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1148953005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] [destructuring] Grand for statement parsing unification. (issue 1149043005 by dslo...@chromium.org)

2015-05-21 Thread dslomov
Reviewers: arv, rossberg, Message: PTAL Description: [destructuring] Grand for statement parsing unification. Also support patterns in ``for (var p in/of ...)`` This CL extends the rewriting we used to do for ``for (let p in/of...)`` to ``for (var p in/of ...)``. For all for..in/of loop declar

[v8-dev] Re: Test CL for demonstrating msan build failures. (issue 1146863006 by machenb...@chromium.org)

2015-05-21 Thread earthdok
Also on the topic of standalone.gypi, is there an actual reason for using prepending merge here? ("cflags_cc+" vs "cflags_cc"). I think it only adds confusion. https://codereview.chromium.org/1146863006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: [test] Apply more detailed origin tracking in MSAN builds. (issue 1148333004 by machenb...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/643c85a7922041ec6865ddb7f8d73b6fedd436a0 Cr-Commit-Position: refs/heads/master@{#28561} https://codereview.chromium.org/1148333004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [test] Apply more detailed origin tracking in MSAN builds. (issue 1148333004 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1148333004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Test CL for demonstrating msan build failures. (issue 1146863006 by machenb...@chromium.org)

2015-05-21 Thread earthdok
On 2015/05/21 15:10:10, earthdok wrote: PS#2: The issue is with ICU, which is a C-only target. You put -fsanitize-memory in cflags_cc, so it isn't applied to ICU. Thus, even though -fPIC is implied by any of -fsanitize={memory,address,thread}, ICU doesn't receive -fPIC. Takeaways: - -fsaniti

[v8-dev] Re: [test] Apply more detailed origin tracking in MSAN builds. (issue 1148333004 by machenb...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148333004/1 https://codereview.chromium.org/1148333004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: PPC: [es6] Spread in array literals (issue 1149873005 by mbra...@us.ibm.com)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/fc146e9e91350eb455e1a5bc71c46733413dd054 Cr-Commit-Position: refs/heads/master@{#28560} https://codereview.chromium.org/1149873005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Reland "Avoid excessive GCs in small heaps." (issue 1148953005 by u...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148953005/1 https://codereview.chromium.org/1148953005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: PPC: [es6] Spread in array literals (issue 1149873005 by mbra...@us.ibm.com)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1149873005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Update UTF-8 decoder to detect more special cases. (issue 1148653007 by joc...@chromium.org)

2015-05-21 Thread 'jochen' via codereview.chromium.org
Reviewers: vogelheim, Description: Update UTF-8 decoder to detect more special cases. The blink version is stricter and for parsing it's important that both decoders behave the same. BUG=chromium:489944 R=vogelh...@chromium.org LOG=n Please review this at https://codereview.chromium.org/114865

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145213004/40001 https://codereview.chromium.org/1145213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Prepare GetProperty(Attributes)WithInterceptor to support elements (issue 1147863002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5023) https://codereview.chromium.org/1147863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2874) https://codereview.chromium.org/1145213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Type::Internal() should have representation kMachPtr (issue 1154463004 by da...@chromium.org)

2015-05-21 Thread danno
Reviewers: Benedikt Meurer, Description: Type::Internal() should have representation kMachPtr R=bmeu...@chromium.org Please review this at https://codereview.chromium.org/1154463004/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+2, -0 lines): M src/compiler/s

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145213004/40001 https://codereview.chromium.org/1145213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (issue 1145213004 by h...@chromium.org)

2015-05-21 Thread hans
https://codereview.chromium.org/1145213004/diff/20001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/1145213004/diff/20001/include/v8config.h#newcode281 include/v8config.h:281: #endif On 2015/05/21 04:43:49, Benedikt Meurer wrote: Nit: keep the empty line be

[v8-dev] Re: Adjust GetPropertyWithFailedAccessCheck to support elements (issue 1155503003 by verwa...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/10329be641f2cb832ec2129f61e71fe311a10620 Cr-Commit-Position: refs/heads/master@{#28559} https://codereview.chromium.org/1155503003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Adjust GetPropertyWithFailedAccessCheck to support elements (issue 1155503003 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1155503003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread ulan
lgtm We could also move this code into the GC epilogue to also uncommit when there is no idle time (e.g. on mobile). WDYT? Yes and the same for scaling allocation factor based on throughput. https://codereview.chromium.org/1148633005/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.c

[v8-dev] Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread hpayer
Reviewers: ulan, Description: Uncommit and shrink semi-spaces only on low allocation rate. BUG= Please review this at https://codereview.chromium.org/1148633005/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+37, -7 lines): M src/heap/gc-idle-time-handler.h

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread hpayer
We could also move this code into the GC epilogue to also uncommit when there is no idle time (e.g. on mobile). WDYT? https://codereview.chromium.org/1148633005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

[v8-dev] Re: Uncommit and shrink semi-spaces only on low allocation rate. (issue 1148633005 by hpa...@chromium.org)

2015-05-21 Thread hpayer
We could also move this code into the GC epilogue to also uncommit when there is no idle time (e.g. on mobile). WDYT? https://codereview.chromium.org/1148633005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

  1   2   3   >