Comment #5 on issue 4026 by mattginz...@gmail.com: Exception is not
properly propagated if enumerate interceptor throws an exception
https://code.google.com/p/v8/issues/detail?id=4026
The scenario I have is I've written an interceptor which calls back into
Javascript with Function-Call. If
On 2015/06/04 20:54:15, caitp wrote:
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6616
test/cctest/test-parsing.cc:6616: {
Updates:
Status: Fixed
Comment #29 on issue 3578 by little...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578
All methods have been implemented and landed.
--
You received this message because
Reviewers: Michael Achenbach (OOO),
Description:
Update V8 DEPS.
Rolling v8/third_party/icu to 9939a5d5314b6d59d5fb070902d73304c2482f88
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1168573003/
Base URL: https://chromium.googlesource.com/v8/v8@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1168573003/1
https://codereview.chromium.org/1168573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #4 on issue 4026 by mattginz...@gmail.com: Exception is not
properly propagated if enumerate interceptor throws an exception
https://code.google.com/p/v8/issues/detail?id=4026
This bug is still present in V8 4.2.77.20 (used in iojs 2.1.0), and a
similar fix is still necessary and
Updates:
Cc: a...@chromium.org dehrenb...@chromium.org ad...@chromium.org
Labels: Area-Language
Comment #7 on issue 3895 by ad...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895
We should fix this before shipping
Reviewers: adamk,
Message:
PTAL
Description:
[es6] Array.prototype.find and findIndex should include holes
We should not skip holes for these 2 functions.
BUG=v8:3895
LOG=N
R=adamk
Please review this at https://codereview.chromium.org/1165003005/
Base URL:
Comment #9 on issue 3895 by a...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895
same issue with findIndex
--
You received this message because this project is configured to send all
issue notifications to this address.
You
You'll need to remove the skip-empty line from test262-es6.status to pass
the
CQ.
lgtm with that change
https://codereview.chromium.org/1165003005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: Started
Comment #10 on issue 3895 by a...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895
(No comment was entered for this change.)
--
You received this message because this project is configured to send
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_-RecordSuperPropertyUsage();
On 2015/06/04 20:15:57, arv
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6616
test/cctest/test-parsing.cc:6616: { x: new.target },
On 2015/06/04 20:08:04,
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 4 (id:??) landed as
https://crrev.com/8c065681865599b29d52c01c6c644fa920c0b551
Cr-Commit-Position: refs/heads/master@{#28806}
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Assigned
Owner: a...@chromium.org
Comment #8 on issue 3895 by ad...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895
(No comment was entered for this change.)
--
You received this message because
ah, I like it, still lgtm
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1164073003/60001
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #15 on issue 3768 by bugdro...@chromium.org: super does not work in
eval
https://code.google.com/p/v8/issues/detail?id=3768#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/8c065681865599b29d52c01c6c644fa920c0b551
commit
Updates:
Status: Fixed
Comment #16 on issue 3768 by a...@chromium.org: super does not work in eval
https://code.google.com/p/v8/issues/detail?id=3768
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
Updates:
Status: Duplicate
Mergedinto: 4085
Comment #8 on issue 3762 by ad...@chromium.org: Implement shared ES6 typed
array prototype
https://code.google.com/p/v8/issues/detail?id=3762
(No comment was entered for this change.)
--
You received this message because this
PTAL
This is blocking my work on eval super
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Patchset 1 (id:??) landed as
https://crrev.com/07c1f277bd93dcbfef3c2dd2b256cdde5665289c
Cr-Commit-Position: refs/heads/master@{#28804}
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
I rebased the patch and added the target_conditions check so the --rpath and
--dynamic-linker flags are not used for building mksnapshot. I tested it
with
mips64el only. Further tests are in progress.
https://codereview.chromium.org/1160973006/
--
--
v8-dev mailing list
Reviewers: arv,
Description:
Stage ES6 Array and TypedArray methods
Also stages ES6 @@isConcatSpreadable support.
BUG=v8:3578
LOG=y
Please review this at https://codereview.chromium.org/1148983006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
On 2015/06/04 16:20:56, adamk wrote:
On 2015/06/04 15:24:30, arv wrote:
Is there a reason we need both LanguageMode and Strength? Can we just
user
LanguageMode in the places where we use Strength?
+1 to this. From outside the strong mode work, needing to understand that
Strength::FIRM
Updates:
Cc: ape...@igalia.com
Comment #3 on issue 4085 by ad...@chromium.org: TypedArray proto chain is
wrong
https://code.google.com/p/v8/issues/detail?id=4085
Issue 3762 has been merged into this issue.
--
You received this message because this project is configured to send all
Reviewers: arv, Dmitry Lomov (ooo until Jun 8),
Message:
PTAL, I hacked around on this for a bit and now, make check is passing along
with a bunch of new parsing tests.
It's quite likely that the eager rewriting of AssignmentExpressions could
break
binding pattern runtime stuff though, so
That failure looks strange.
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1154103005/20001
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #13 on issue 3768 by a...@chromium.org: super does not work in eval
https://code.google.com/p/v8/issues/detail?id=3768
There is one more problem which I'm working on.
In the following case:
var o = {
m() {
eval('super.toString')
}
};
o.m();
the code might get optimized by
Committed patchset #1 (id:1)
https://codereview.chromium.org/1159663004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/c1e3e3018e5833f1377bb72648c938fea7f53b03
Cr-Commit-Position: refs/heads/master@{#28803}
https://codereview.chromium.org/1159663004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1159663004/diff/1/test/mjsunit/harmony/typedarray-reduce.js
File test/mjsunit/harmony/typedarray-reduce.js (right):
https://codereview.chromium.org/1159663004/diff/1/test/mjsunit/harmony/typedarray-reduce.js#newcode242
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1159663004/1
https://codereview.chromium.org/1159663004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1153263004/1
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/345fa142a9fca4b468417350ac26f61101d626e8
Cr-Commit-Position: refs/heads/master@{#28802}
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #14 on issue 3768 by bugdro...@chromium.org: super does not work in
eval
https://code.google.com/p/v8/issues/detail?id=3768#c14
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/345fa142a9fca4b468417350ac26f61101d626e8
commit
Comment #27 on issue 3578 by bugdro...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578#c27
The following revision refers to this bug:
On 2015/06/04 15:24:30, arv wrote:
Is there a reason we need both LanguageMode and Strength? Can we just user
LanguageMode in the places where we use Strength?
+1 to this. From outside the strong mode work, needing to understand that
Strength::FIRM means the same thing as STRONG seems
Reviewers: Benedikt Meurer, michael_dawson, rmcilroy,
Message:
Let's try this again.
Description:
Add support for Embedded Constant Pools for PPC and Arm
Embed constant pools within their corresponding Code
objects.
This removes support for out-of-line constant pools in favor
of the new
On 2015/06/04 13:56:15, rmcilroy wrote:
On 2015/06/04 13:54:00, mtbrandyberry wrote:
Let's try this again.
I Assume this has no real changes other than rebasing? If so, lgtm.
Yes. Thanks.
https://codereview.chromium.org/1162993006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1162993006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/06/04 13:54:00, mtbrandyberry wrote:
Let's try this again.
I Assume this has no real changes other than rebasing? If so, lgtm.
https://codereview.chromium.org/1162993006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 1 (id:??) landed as
https://crrev.com/eac7f04669208cb15132d03ca15c8acd1a2be869
Cr-Commit-Position: refs/heads/master@{#28801}
https://codereview.chromium.org/1162993006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1162993006/1
https://codereview.chromium.org/1162993006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Is there a reason we need both LanguageMode and Strength? Can we just user
LanguageMode in the places where we use Strength?
https://codereview.chromium.org/1144183004/diff/180001/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):
lgtm.
https://codereview.chromium.org/1152993005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc#newcode659
src/heap/spaces.cc:659: commit_size CodePageAreaSize()) {
Thank you for spotting this, typo mistake
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc#newcode659
src/heap/spaces.cc:659: commit_size CodePageAreaSize()) {
The commit_size includes the
On 2015/06/04 18:38:31, conradw wrote:
On 2015/06/04 16:20:56, adamk wrote:
On 2015/06/04 15:24:30, arv wrote:
Is there a reason we need both LanguageMode and Strength? Can we just
user
LanguageMode in the places where we use Strength?
+1 to this. From outside the strong mode work,
Updated the test262 test status, the mozilla failures look like unrelated
flakes.
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
On 2015/06/04 17:15:06, arv wrote:
PTAL
This is blocking my work on eval super
I unblocked it... Take your time.
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
On 2015/06/04 17:33:44, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/07c1f277bd93dcbfef3c2dd2b256cdde5665289c
Cr-Commit-Position: refs/heads/master@{#28804}
Please fix layout test expectations.
https://codereview.chromium.org/1153263004/
--
--
v8-dev
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/303
inspector/console/console-format-es6.html
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: adamk, wingo,
Message:
PTAL
Description:
[es6] super.prop, eval and lazy functions
We used to only store the uses_super_property in the preparse data
logger. Let the logger use NeedsHomeObject instead.
BUG=v8:3768
LOG=N
R=wingo, adamk
Please review this at
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1148983006/40001
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
PTAL.
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1152993005/1
https://codereview.chromium.org/1152993005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1152993005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/ac1d19208cb97f98ee2d7e21d7fca376feabf78f
Cr-Commit-Position: refs/heads/master@{#28800}
https://codereview.chromium.org/1152993005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Looks solid to me. A few nits and comments.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode626
src/preparser.h:626: inline void
Patchset 3 (id:??) landed as
https://crrev.com/131062fc41e2d95c9ae7b0913b7efb8e32785e2c
Cr-Commit-Position: refs/heads/master@{#28805}
https://codereview.chromium.org/1148983006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #28 on issue 3578 by bugdro...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578#c28
The following revision refers to this bug:
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc#newcode239
src/ast.cc:239: DCHECK_NOT_NULL(expr-AsFunctionLiteral());
On 2015/06/04 20:02:33, adamk wrote:
This DCHECK seems a little
On 2015/06/04 18:38:31, conradw wrote:
On 2015/06/04 16:20:56, adamk wrote:
On 2015/06/04 15:24:30, arv wrote:
Is there a reason we need both LanguageMode and Strength? Can we just
user
LanguageMode in the places where we use Strength?
+1 to this. From outside the strong mode work,
On 2015/06/04 19:27:42, Michael Achenbach (OOO) wrote:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/303
inspector/console/console-format-es6.html
I'm on it.
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm % (nit + naming)
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc#newcode239
src/ast.cc:239: DCHECK_NOT_NULL(expr-AsFunctionLiteral());
This DCHECK seems a little over-anxious, the
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_-RecordSuperPropertyUsage();
On 2015/06/04 20:02:33, adamk
Reviewers: michael_dawson, Sven Panne,
Description:
Fix uninitialized variable compiler errors [GCC 4.8.4]
R=svenpa...@chromium.org, michael_daw...@ca.ibm.com
BUG=
Please review this at https://codereview.chromium.org/1163143005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
On 2015/06/03 19:16:53, mtbrandyberry wrote:
On 2015/06/03 17:02:50, rmcilroy wrote:
On 2015/06/03 16:50:41, mtbrandyberry wrote:
On 2015/06/03 15:54:32, rmcilroy wrote:
On 2015/06/03 15:44:26, mtbrandyberry wrote:
On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
75 matches
Mail list logo
