Patchset 3 (id:??) landed as
https://crrev.com/eaba98d97aa9c2847fffd8baa22d10d135ed15e0
Cr-Commit-Position: refs/heads/master@{#30280}
https://codereview.chromium.org/1293493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1293493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1301183002/120001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1301183002/120001
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/21 05:26:43, Benedikt Meurer wrote:
LGTM.
One question: While we are changing the heap testing stuff, can we
migrate the
tests to unittests using GoogleTest?
Thought about it but didn't dare to touch and convert the tests (yet). I
will
have a look at some point though.
https
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293493004/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293493004/40001
https://codereview.chromium.org/1293493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
LGTM, nice!
https://codereview.chromium.org/1292173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1303873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM.
One question: While we are changing the heap testing stuff, can we migrate
the
tests to unittests using GoogleTest?
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Patchset 1 (id:??) landed as
https://crrev.com/2e84d14274de820cc43109975f817f86f1281749
Cr-Commit-Position: refs/heads/master@{#30279}
https://codereview.chromium.org/1307783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1307783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Michael Achenbach (OOO),
Description:
Update V8 DEPS.
Rolling v8/tools/clang to 5439585778385813bc7711f3d6b7035b9eb78572
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1307783002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1307783002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1307783002/1
https://codereview.chromium.org/1307783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
https://codereview.chromium.org/1293283002/diff/11/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1293283002/diff/11/src/parser.cc#newcode2982
src/parser.cc:2982: factory()->NewBlock(labels, 2, true,
RelocInfo::kNoPosition);
Seems weird that you pass labels bot
Reviewers: adamk,
Description:
Add a separate scope for switch
The ES2015 specification for switch statements 13.12.11 specifies that
they get their own lexical scope. This patch introduces such a scope
through a complex desugaring in terms of blocks, done so that Crankshaft
does not have to be
On 2015/08/20 at 05:19:58, jarin wrote:
On 2015/08/19 17:36:23, binji wrote:
> https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc
> File src/execution.cc (right):
>
>
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc#newcode418
> src/execution.cc:418:
https://codereview.chromium.org/1302133002/diff/20001/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1302133002/diff/20001/src/harmony-simd.js#newcode328
src/harmony-simd.js:328: }
You should be able to "macroize" these too. Parameterize on NAME and
COUNT.
Reviewers: Jarin, dehrenberg, bbudge,
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js#newcode339
src/harmony-simd.js:339: }
On 2015/08/20 18:23:34, bbudge wrote:
You sh
Reviewers: rossberg, titzer,
Description:
Don't allocate AstTyper with the zone allocator.
While the class Type objects the AstTyper generates should be
allocated to zone memory, there's no particular reason
the typer object itself needs to be.
BUG=None
TEST=None
R=rossb...@chromium.org,tit...@
PTAL
That it much niced not needing to plumb in the zone.
I've sent out separate CL to change typing.h similarly.
I also looked at one of the items in hydrogen.h too that uses this pattern,
but
it appears to actually need it, as that object gets handed to an
OptimizedCompileJob, which is also
lgtm
Such a weird spec, but your implementation makes sense. I can't think of a
simpler way. Why don't the default parameter direct evals just run within
the
function's existing var scope? (Or, why 1JS?!)
https://codereview.chromium.org/1292753007/
--
--
v8-dev mailing list
v8-dev@googlegrou
lgtm
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1302133002/diff/1/src/harmony-simd.js#newcode339
src/harmony-simd.js:339: }
You should be able to use the V8 macro system on these to reduce
duplication. There
lgtm
https://codereview.chromium.org/1303863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Cc: nedngu...@chromium.org
Labels: Performance
Comment #1 on issue 4383 by nedngu...@google.com: TextEncoder.encode is slow
https://code.google.com/p/v8/issues/detail?id=4383
(No comment was entered for this change.)
--
You received this message because this project is
Status: Untriaged
Owner:
New issue 4383 by joelt...@google.com: TextEncoder.encode is slow
https://code.google.com/p/v8/issues/detail?id=4383
Version: V8 4.4.63.29
OS: Ubuntu
Architecture: x86_64
We have a stringToUtf8ByteArray method in Closure:
https://github.com/google/closure-library
Patchset 1 (id:??) landed as
https://crrev.com/a683f83dec0fcd1a89a59248a7f805f8aaeafb2f
Cr-Commit-Position: refs/heads/master@{#30278}
https://codereview.chromium.org/1300363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1300363002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1300363002/1
https://codereview.chromium.org/1300363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Committed patchset #1 (id:1)
https://codereview.chromium.org/1300363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
On 2015/08/20 16:28:29, H
https://codereview.chromium.org/1286383005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1286383005/diff/20001/src/preparser.h#newcode2288
src/preparser.h:2288: result =
Nit: unnecessary line break?
https://codereview.chromium.org/1286383005/diff/20001
Patchset 1 (id:??) landed as
https://crrev.com/de57a6c0609aa9ab43cea474d252178ba044d448
Cr-Commit-Position: refs/heads/master@{#30277}
https://codereview.chromium.org/1288913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1288913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1288913003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1288913003/1
https://codereview.chromium.org/1288913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1288913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
On 2015/08/20 16:28:29, H
On 2015/08/20 16:26:31, vogelheim wrote:
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h#newcode367
src/scanner.h:367: if (my_bookmark_) scanner_->DropBookmark();
On 2015/08/20 15:45:12,
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.h
File src/ast-expression-visitor.h (right):
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.h#newcode26
src/ast-expression-visitor.h:26: void* operator new(size_t size, Zone*
zone)
lgtm, nits attached
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
We s
Reviewers: Benedikt Meurer,
Description:
Remove obsolete static methods from V8 class.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1303873002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -16 lines):
M src/api.cc
M src/v
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h#newcode367
src/scanner.h:367: if (my_bookmark_) scanner_->DropBookmark();
On 2015/08/20 15:45:12, rossberg wrote:
Hm, this _does_ change th
Reviewers: titzer, Michael Starzinger, rmcilroy,
Message:
mstarzin...@chromium.org
rmcil...@chromium.org
tit...@chromium.org
PTAL. This is just a start. Input on wiring up graphs for the simple
bytecodes
we have today would be appreciated. Thanks!
Description:
[Interpreter] Skeleton bytecode
On 2015/08/20 15:47:57, wingo wrote:
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h#newcode3604
src/preparser.h:3604: ArrowFormalParametersUnexpectedToken(classifier);
On
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2814
test/cctest/test-heap.cc:2814: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceM
lgtm
https://codereview.chromium.org/1306583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
[heap] Hide MemoryReducer inside the heap component.
This prevents leakage of the memory-reducer.h declarations inside of the
heap and prevents it from being exposed to the world. Protects private
state from being inadvertently mocked with.
R=mlippa...@
LGTM from my end.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc#newcode490
src/heap/incremental-marking.cc:490: StartMarkin
Patchset 1 (id:??) landed as
https://crrev.com/1a3c7e2fb139e23abcb5de9124734ebdf40ebd5a
Cr-Commit-Position: refs/heads/master@{#30276}
https://codereview.chromium.org/1294763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h#newcode3604
src/preparser.h:3604: ArrowFormalParametersUnexpectedToken(classifier);
On 2015/08/20 15:22:57, caitp wrote:
prob
Committed patchset #1 (id:1)
https://codereview.chromium.org/1294763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode28
src/heap/heap.h:28: class HeapTester;
On 2015/08/20 13:33:37, Michael Starzinger wrote:
nit: No need for forward de
https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h#newcode1346
src/heap/heap.h:1346: GCTracer* tracer() { return tracer_; }
On 2015/08/20 15:09:07, Michael Lippautz wrote:
Suggestion:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294763004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294763004/1
https://codereview.chromium.org/1294763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h#newcode367
src/scanner.h:367: if (my_bookmark_) scanner_->DropBookmark();
Hm, this _does_ change the semantics, doesn't it? It looks
Comment #5 on issue 4338 by ofrob...@google.com: Segfault when vector ICs
are enabled on ARMv6
https://code.google.com/p/v8/issues/detail?id=4338
With Node.js + V8 4.5.103.20, this is no longer failing for me on a
Raspberry Pi. I tried both the reduced test-case above, and the original
No
Patchset 2 (id:??) landed as
https://crrev.com/267381d9789419922c959d6ea44bbd1b17641e1f
Cr-Commit-Position: refs/heads/master@{#30275}
https://codereview.chromium.org/1305733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1305733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1306583002/diff/60001/src/preparser.h#newcode3604
src/preparser.h:3604: ArrowFormalParametersUnexpectedToken(classifier);
probably want to make sure destructuring s
On 2015/08/20 14:05:16, commit-bot: I haz the power wrote:
Dry run: CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1306583002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1306583002/60001
the array-native-elements
lgtm, thanks a lot!
https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h#newcode1346
src/heap/heap.h:1346: GCTracer* tracer() { return tracer_; }
Suggestion: GCTracer& ?
https://coderev
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1305733003/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1305733003/20001
https://codereview.chromium.org/1305733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
lgtm
https://codereview.chromium.org/1305733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
[heap] Hide GCTracer inside the heap component.
This prevents leakage of the gc-tracer.h declarations inside of the
heap and prevents it from being exposed to the world. Protects private
state from being inadvertently mocked with.
R=mlippa...@chromium.o
heap: lgtm
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Committed patchset #1 (id:1)
https://codereview.chromium.org/1303813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/e31695f907d5a36b859078c16705271c708445c4
Cr-Commit-Position: refs/heads/master@{#30274}
https://codereview.chromium.org/1303813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/08/20 14:38:31, bbudge-google wrote:
mailto:hpa...@chromium.org: Please review changes in
HEAP
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
hpa...@chromium.org: Please review changes in
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Reviewers: Michael Lippautz,
Description:
Don't filter store buffer after sweeping.
Additionally, this CL moves a bit of code around to free up more memory
before
compaction starts.
BUG=
Please review this at https://codereview.chromium.org/1305733003/
Base URL:
https://chromium.googleso
Reviewers: Jarin,
Description:
[simd] Introduce SIMD types (as classes)
- Introduce a proper bit for SIMD primitive values.
- Introduce constructors for individual SIMD types. These are currently just
classes, which seems good enough for now, given that we always have exactly
one
global map p
Patchset 1 (id:??) landed as
https://crrev.com/a4bcd81aed29e75c8be935274e0e9c2dbbf48e40
Cr-Commit-Position: refs/heads/master@{#30273}
https://codereview.chromium.org/1298183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1298183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1298183003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1298183003/1
https://codereview.chromium.org/1298183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: Hannes Payer,
Message:
Hannes, PTAL. This is the last incarnation of deferred free I was tinkering
with. As discussed results varied across platforms. Interested to know if it
helps.
Description:
Experimental support for deferring the release of memory chunks. It is
enabled when --def
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1303813004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1303813004/1
https://codereview.chromium.org/1303813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1303813004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1303813004/1
https://codereview.chromium.org/1303813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1305763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Failed to apply patch for src/heap/heap.h:
While running git apply --index -3 -p1;
error: patch failed: src/heap/heap.h:1812
Falling back to three-way merge...
Applied patch to 'src/heap/heap.h' with conflicts.
U src/heap/heap.h
Patch: src/heap/heap.h
Index: src/heap/heap.h
diff --g
Committed patchset #1 (id:1)
https://codereview.chromium.org/1292963006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/05e843443a46f39fedeac32985a1416a221c797c
Cr-Commit-Position: refs/heads/master@{#30272}
https://codereview.chromium.org/1292963006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/6d67f7db3797620e1daf4e52f57782f70d4a4d2f
Cr-Commit-Position: refs/heads/master@{#30271}
https://codereview.chromium.org/1305763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
LGTM. Somehow the compiler seems to ignore all our comments. :)
https://codereview.chromium.org/1300363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2015/08/20 13:39:06, commit-bot: I haz the power wrote:
Dry run: CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1306583002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1306583002/20001
I had a hard time finding
Reviewers: Michael Starzinger,
Description:
Fix bug in Code::VerifyRecompiledCode.
The code should do what the comment says :)
R=mstarzin...@chromium.org
BUG=chromium:522895
LOG=N
Please review this at https://codereview.chromium.org/1300363002/
Base URL: https://chromium.googlesource.com/v8/
On 2015/08/20 13:44:53, mvstanton wrote:
Hi Yang,
Here is a cleanup discovered on my vector store path...
lgtm.
https://codereview.chromium.org/1303813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are su
Committed patchset #1 (id:1)
https://codereview.chromium.org/1305763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292963006/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292963006/1
https://codereview.chromium.org/1292963006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: mvstanton,
Message:
A revert of this CL (patchset #6 id:11) has been created in
https://codereview.chromium.org/1305763002/ by cbr...@chromium.org.
The reason for reverting is: failing bot
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/b
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1305763002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1305763002/1
https://codereview.chromium.org/1305763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: mvstanton,
Message:
Created Revert of Moving ArraySplice Builtin to ElementsAccessor
Description:
Revert of Moving ArraySplice Builtin to ElementsAccessor (patchset #6
id:11
of https://codereview.chromium.org/1293683005/ )
Reason for revert:
failing bot
http://build.chromium.o
Reviewers: rossberg,
Description:
Tighten & check the BookmarkScope API contract a bit.
The real fix for crbug.com/510825 is in Blink (crrev.com/1286883004).
When debugging, I first suspected abuse of the BookmarkScope and added
additional assertions to check proper use. It turned out that didn'
Reviewers: Yang,
Message:
Hi Yang,
Here is a cleanup discovered on my vector store path...
Description:
Simplify KeyedAccessStoreMode.
The map tells us the source elements kind, and holeyness.
BUG=
Please review this at https://codereview.chromium.org/1303813004/
Base URL: https://chromium.g
Reviewers: rossberg,
Message:
PTAL. This one is pretty serious and probably should be uplifted to beta
(45)
before it becomes stable.
Description:
Fix parsing of arrow function formal parameters
Not all parenthesized AssignmentExpressions whose components are valid
binding patterns are vali
The compiler and full-code parts look OK, didn't look at the rest (or at the
general issue this CL is about).
https://codereview.chromium.org/1286383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Looking good. I like it.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode28
src/heap/heap.h:28: class HeapTester;
nit: No need for forward declare, friend declaration
lgtm
https://codereview.chromium.org/1292963006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Description:
[heap] Move {hidden_string} into the root list.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/1292963006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -19 lines):
M src/factory.h
M src/
On 2015/08/20 12:50:12, rossberg wrote:
LGTM
It's sad that this makes the use of private symbols unmodular. But I guess
uniformity wins...
The upside is that we would share private symbols across different native
contexts instead of allocating new ones. This saves us from ICs going
polymorph
On 2015/08/20 12:50:12, rossberg wrote:
LGTM
It's sad that this makes the use of private symbols unmodular. But I guess
uniformity wins...
https://codereview.chromium.org/1293493004/diff/1/src/array-iterator.js
File src/array-iterator.js (right):
https://codereview.chromium.org/129349300
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293493004/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293493004/20001
https://codereview.chromium.org/1293493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
LGTM
https://codereview.chromium.org/1298183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
1 - 100 of 169 matches
Mail list logo
