On 2014/08/04 13:39:02, aandrey wrote:
On 2014/08/04 13:28:22, Yang wrote:
> On 2014/08/01 14:55:54, aandrey wrote:
> > lgtm
>
> A bit confused by this. Do we no longer care about the source of the
event
(aka
> type)?
we can calculate it from the data set that we receive
I've updated the
On 2014/08/04 13:28:22, Yang wrote:
On 2014/08/01 14:55:54, aandrey wrote:
> lgtm
A bit confused by this. Do we no longer care about the source of the event
(aka
type)?
We do, but we can tell the type according to property values (e.g.
parentPromise
is not undefined => it's a promise cha
https://codereview.chromium.org/416213004/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode61
src/promise.js:61: %DebugPromiseEvent({ promise: promise,
On 2014/08/01 13:22:21, aandrey wrote:
nit: can it be a one li
https://codereview.chromium.org/416213004/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/416213004/diff/20001/src/promise.js#newcode61
src/promise.js:61: var type = status === 0 ? "new" : "update";
On 2014/08/01 07:46:18, aandrey wrote:
remove this and th
On 2014/07/31 15:33:14, Alexandra Mikhaylova wrote:
BTW, this is DevTools backend support for this:
https://codereview.chromium.org/433653003/.
https://codereview.chromium.org/416213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received th
Reviewers: Yang, aandrey,
Description:
Merge three PromiseEvent's into one with the "type" field.
This also adds missing instrumentation and removes resolver tracking.
BUG=v8:3093
Please review this at https://codereview.chromium.org/416213004/
SVN Base: https://v8.googlecode.com/svn/branches
On 2014/07/24 09:18:37, Alexandra Mikhaylova wrote:
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
src/debug-debugger.js:1211: event = new
Up
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
src/debug-debugger.js:1211: event = new
UpdatePromiseParentEvent(event_data);
On 2014/07/24 08:43:
https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js#newcode1338
src/mirror-debugger.js:1338: var iter = %_CallFunction(this.value_,
builtins.SetEntries);
On 2014/07/22
https://codereview.chromium.org/393283007/diff/70001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/70001/src/promise.js#newcode226
src/promise.js:226: %DebugPromiseEvent({ type: "update",
On 2014/07/22 11:58:49, aandrey wrote:
now 3 update event call
https://codereview.chromium.org/393283007/diff/50001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode41
src/promise.js:41: var promise = PromiseInit(this);
On 2014/07/18 12:10:44, aandrey wrote:
this will fire "update" event
Reviewers: aandrey, Yang,
Description:
Expose the content of Sets and WeakSets through SetMirror.
BUG=v8:3093
Please review this at https://codereview.chromium.org/402423003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+141, -16 lines):
M src/mirror-debugg
Fixed the test, the problem was in GC being called before it was expected
in the
test.
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Grou
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: aandrey,
Message:
WIP
Description:
Introduce more debug events for promises.
BUG=v8:3093
Please review this at https://codereview.chromium.org/393283007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+105, -13 lines):
M src/debug-debugger.js
M
On 2014/07/17 14:10:31, Yang wrote:
On 2014/07/17 12:06:31, aandrey wrote:
> lgtm
lgtm.
Yang, could you please land it then?
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message bec
https://codereview.chromium.org/398513005/diff/10001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/398513005/diff/10001/src/runtime.cc#newcode1722
src/runtime.cc:1722: entries->set(number_of_non_hole_elements * 2,
*key);
On 2014/07/17 09:42:28, aandrey wrote:
maybe
https://codereview.chromium.org/398513005/diff/10001/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/398513005/diff/10001/src/mirror-debugger.js#newcode1295
src/mirror-debugger.js:1295: var iter = this.value_.entries();
On 2014/07/17 08:49:29, Yang wro
https://codereview.chromium.org/398513005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/398513005/diff/1/src/runtime.cc#newcode1742
src/runtime.cc:1742: Handle key(table->KeyAt(i), isolate);
On 2014/07/16 12:10:58, Yang wrote:
Indentation size is weird. We u
https://codereview.chromium.org/398513005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/398513005/diff/1/src/runtime.cc#newcode1709
src/runtime.cc:1709: RUNTIME_FUNCTION(Runtime_GetMapEntries) {
On 2014/07/16 09:51:07, rossberg wrote:
Is this necessary? You
Reviewers: Yang, aandrey, yurys, rossberg,
Description:
Expose the content of Maps and WeakMaps through MapMirror.
BUG=v8:3291
Please review this at https://codereview.chromium.org/398513005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+161, -6 lines):
M s
On 2014/05/15 14:26:33, Yang wrote:
On 2014/05/15 14:25:49, Alexandra Mikhaylova wrote:
> On 2014/05/15 13:56:00, Yang wrote:
> > This CL is dependent on https://codereview.chromium.org/273653007/
> >
> > What this changes:
> > - circumvent cross context access checks for PromiseMirror.
> > - ret
On 2014/05/15 13:56:00, Yang wrote:
This CL is dependent on https://codereview.chromium.org/273653007/
What this changes:
- circumvent cross context access checks for PromiseMirror.
- return a mirror object from Promise.prototype.promiseValue instead of
the
raw
value, to maintain consisten
https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newcode828
src/mirror-debugger.js:828: var promiseStatus =
builtins.GetPromiseStatus(value);
On 2014/05/08 15:05:16
Reviewers: aandrey, yurys, Yang,
Description:
Read internal properties [[Status]] and [[Value]] of the promise.
BUG=v8:3093
Please review this at https://codereview.chromium.org/273653007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+35, -1 lines):
M src/m
Reviewers: Yury Semikhatsky, loislo, alph,
Description:
JS allocations tracking for arm architecture
BUG=
Please review this at https://codereview.chromium.org/54963002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+53, -0 lines):
M src/arm/macro-assembler-
Reviewers: Yury Semikhatsky, loislo, alph,
Description:
JS allocations tracking for ia32 architecture
BUG=
Please review this at https://codereview.chromium.org/38753007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+110, -2 lines):
M src/ia32/code-stubs-ia
https://codereview.chromium.org/32583002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/32583002/diff/1/src/hydrogen-instructions.h#newcode5358
src/hydrogen-instructions.h:5358:
Isolate::Current()->heap_profiler()->is_tracking_allocat
https://codereview.chromium.org/32583002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/32583002/diff/1/src/hydrogen-instructions.h#newcode5358
src/hydrogen-instructions.h:5358:
Isolate::Current()->heap_profiler()->is_tracking_allocat
Reviewers: loislo, Yury Semikhatsky, alph,
Description:
Disable allocation folding when allocations tracking is on
BUG=
Please review this at https://codereview.chromium.org/32583002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -2 lines):
M src/hydrog
On 2013/10/02 18:20:03, Hannes Payer wrote:
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc#newcode4979
src/heap.cc:4979: HeapProfiler* profiler = isolate()->heap_profiler();
On 2013/10/02
https://codereview.chromium.org/22852024/diff/84001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/22852024/diff/84001/include/v8-profiler.h#newcode478
include/v8-profiler.h:478: * and tracking of heap objects population
statistics.
On 2013/10/02 18:00:
https://codereview.chromium.org/22852024/diff/72001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/72001/src/heap.cc#newcode4982
src/heap.cc:4982: object_size);
On 2013/09/25 14:51:52, Yury Semikhatsky wrote:
style: wrong alignment
Done.
https://coderevie
https://codereview.chromium.org/22852024/diff/40001/src/heap-profiler.cc
File src/heap-profiler.cc (right):
https://codereview.chromium.org/22852024/diff/40001/src/heap-profiler.cc#newcode162
src/heap-profiler.cc:162: DropCompiledCode();
On 2013/09/25 10:41:12, Yury Semikhatsky wrote:
Would it
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h#newcode1701
src/spaces.h:1701: MUST_USE_RESULT inline MaybeObject* AllocateRaw(int
size_in_bytes);
On 2013/08/28 09:51:32, Hannes Payer wrote
https://codereview.chromium.org/22852024/diff/28001/test/cctest/cctest.cc
File test/cctest/cctest.cc (right):
https://codereview.chromium.org/22852024/diff/28001/test/cctest/cctest.cc#newcode195
test/cctest/cctest.cc:195: LocalContext env;
All we need to do here is to quickly initialize the isol
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc#newcode1320
src/assembler.cc:1320: Isolate* isolate) {
On 2013/08/28 09:51:32, Hannes Payer wrote:
4 spaces indent
Removed thi
https://codereview.chromium.org/22852024/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/22852024/diff/1/src/heap-snapshot-generator.cc#newcode635
src/heap-snapshot-generator.cc:635:
heap()->isolate()->heap_profiler()->StartHeapO
38 matches
Mail list logo
