[v8-dev] Re: Support stepping into getters and setters

2009-07-13 Thread ager
http://codereview.chromium.org/149542/diff/7/1008 File src/objects.cc (right): http://codereview.chromium.org/149542/diff/7/1008#newcode212 Line 212: return Object::GetPropertyWithDefinedGetter(receiver, Since the debugger can cause GCs, you have to wrap 'receiver' in a handle as well and have a

[v8-dev] Re: Support stepping into getters and setters

2009-07-14 Thread yurys
http://codereview.chromium.org/149542/diff/7/1008 File src/objects.cc (right): http://codereview.chromium.org/149542/diff/7/1008#newcode212 Line 212: return Object::GetPropertyWithDefinedGetter(receiver, On 2009/07/13 20:12:19, Mads Ager wrote: > Since the debugger can cause GCs, you have to wra

[v8-dev] Re: Support stepping into getters and setters

2009-07-14 Thread yurys
On 2009/07/14 09:55:17, Yury Semikhatsky wrote: > http://codereview.chromium.org/149542/diff/7/1008 > File src/objects.cc (right): > http://codereview.chromium.org/149542/diff/7/1008#newcode212 > Line 212: return Object::GetPropertyWithDefinedGetter(receiver, > On 2009/07/13 20:12:19, Mads Ager w

[v8-dev] Re: Support stepping into getters and setters

2009-07-14 Thread ager
LGTM! http://codereview.chromium.org/149542/diff/1045/34 File src/debug.cc (right): http://codereview.chromium.org/149542/diff/1045/34#newcode337 Line 337: // Step in through constructs call requires no changes to the running code. Not your change, but: constructs -> construct http://coderevie

[v8-dev] Re: Support stepping into getters and setters

2009-07-14 Thread yurys
http://codereview.chromium.org/149542/diff/1045/34 File src/debug.cc (right): http://codereview.chromium.org/149542/diff/1045/34#newcode337 Line 337: // Step in through constructs call requires no changes to the running code. On 2009/07/14 16:36:47, Mads Ager wrote: > Not your change, but: const