Change in vdsm[master]: PEP8 fixes for localFsSD

Dan Kenigsberg has submitted this change and it was merged. Change subject: PEP8 fixes for localFsSD .. PEP8 fixes for localFsSD % pep8 vdsm/storage/localFsSD.py vdsm/storage/localFsSD.py:16:80: E501 line too long (80 character

Change in vdsm[master]: PEP8 fixes for localFsSD

Dan Kenigsberg has posted comments on this change. Change subject: PEP8 fixes for localFsSD .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 7: I would prefer that you didn't submit this (1 inline comment) .

Change in vdsm[master]: Replace username and file location for SASL by constants

Dan Kenigsberg has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Add passwd command to vdsm-tool

Wenyi Gao has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 7: (1 inline comment) File vdsm-tool/passwd.py Line 48: rai

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Eduardo has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 6: (1 inline comment) File vdsm/storage/volume.py Lin

Change in vdsm[master]: Replace username and file location for SASL by constants

Lei Li has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 1: (1 inline comment) File vdsm/libvirtconnec

Change in vdsm[master]: Add passwd command to vdsm-tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 6: (2 inline comments) With small fixed. File vdsm-tool/passwd.py Lin

Change in vdsm[master]: PEP8 fixes for localFsSD

Wenyi Gao has posted comments on this change. Change subject: PEP8 fixes for localFsSD .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://

Change in vdsm[master]: Make safer to get vdsm section version in configuration file...

Wenyi Gao has posted comments on this change. Change subject: Make safer to get vdsm section version in configuration files .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://ge

Change in vdsm[master]: Make safer to get vdsm section version in configuration file...

Wenyi Gao has uploaded a new change for review. Change subject: Make safer to get vdsm section version in configuration files .. Make safer to get vdsm section version in configuration files For "configure_libvirt" function in v

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Zhou Zheng Sheng has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 2: Verified The changes pass vdsm test. pydiff report: $ pydiff define*.py 2 difference(s) first file: defineo.py

Change in vdsm[master]: clean PEP 8 problems in vdsm/clientIF.py

Zhou Zheng Sheng has posted comments on this change. Change subject: clean PEP 8 problems in vdsm/clientIF.py .. Patch Set 1: Verified The changes pass vdsm test. I examine the old version and the new version with pydiff (htt

Change in vdsm[master]: clean PEP 8 problems in vdsm/clientIF.py

Zhou Zheng Sheng has posted comments on this change. Change subject: clean PEP 8 problems in vdsm/clientIF.py .. Patch Set 1: (3 inline comments) File vdsm/clientIF.py Line 7

Change in vdsm[master]: use default libvirt event handler impl

Royce Lv has posted comments on this change. Change subject: use default libvirt event handler impl .. Patch Set 1: Dan, I agree with you on introducing more tests to this, But not particularly sure what are necessary.Searched

Change in vdsm[master]: fix can't get ssl opt in vdsm sos plugin

Xu He Jie has posted comments on this change. Change subject: fix can't get ssl opt in vdsm sos plugin .. Patch Set 2: Ok, I will try to add functional test and find hack method for import vdsm.config -- To view, visit http:/

Change in vdsm[master]: rest-api: Add functional tests for complex API operations

Adam Litke has uploaded a new change for review. Change subject: rest-api: Add functional tests for complex API operations .. rest-api: Add functional tests for complex API operations Signed-off-by: Adam Litke Change-Id: I286fd

Change in vdsm[master]: rest-api: Add basic create and delete support

Adam Litke has uploaded a new change for review. Change subject: rest-api: Add basic create and delete support .. rest-api: Add basic create and delete support Update the Resource class so that it can dispatch both GET and DELET

Change in vdsm[master]: rest-api: Allow optional data in DELETE request bodies

Adam Litke has uploaded a new change for review. Change subject: rest-api: Allow optional data in DELETE request bodies .. rest-api: Allow optional data in DELETE request bodies By default, cherrypy does not allow data in DELETE

Change in vdsm[master]: rest-api: Handle resource links

Adam Litke has uploaded a new change for review. Change subject: rest-api: Handle resource links .. rest-api: Handle resource links Change the method for resolving links in a REST Resource. Instead of each class defining a _han

Change in vdsm[master]: rest-api: Model volumes

Adam Litke has posted comments on this change. Change subject: rest-api: Model volumes .. Patch Set 6: (1 inline comment) File vdsm/rest/Controller.py Line 362: role

Change in vdsm[master]: rest-api: Model VMs

Adam Litke has posted comments on this change. Change subject: rest-api: Model VMs .. Patch Set 6: (2 inline comments) Addressed some of Gal's comments. About to push a new series.

Change in vdsm[master]: Fix "unknown device" issue for balloon device

Dan Kenigsberg has posted comments on this change. Change subject: Fix "unknown device" issue for balloon device .. Patch Set 2: Looks good to me, approved Mark, would you formally state that this has been tested? -- To view,

Change in vdsm[master]: Related to BZ#769502 - One shot teardown.

Dan Kenigsberg has posted comments on this change. Change subject: Related to BZ#769502 - One shot teardown. .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4234 To unsu

Change in vdsm[master]: rest-api: Delete unneeded directory

Dan Kenigsberg has submitted this change and it was merged. Change subject: rest-api: Delete unneeded directory .. rest-api: Delete unneeded directory Hmm, I thought this orphaned directory had ben cleaned from the REST infrast

Change in vdsm[master]: rest-api: Delete unneeded directory

Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Delete unneeded directory .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5045 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: rest-api: Delete unneeded directory

Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Delete unneeded directory .. Patch Set 1: Looks good to me, approved huh? how did it manage to sneak in? -- To view, visit http://gerrit.ovirt.org/50

Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.

Dan Kenigsberg has posted comments on this change. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. Patch Set 2: I would prefer that you didn't submit this (4 inline comments) Thank! I have a couple of reques

Change in vdsm[master]: PEP8 fixes for localFsSD

Adam Litke has posted comments on this change. Change subject: PEP8 fixes for localFsSD .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http:/

Change in vdsm[master]: rest-api: Delete unneeded directory

Adam Litke has uploaded a new change for review. Change subject: rest-api: Delete unneeded directory .. rest-api: Delete unneeded directory Hmm, I thought this orphaned directory had ben cleaned from the REST infrastructure patc

Change in vdsm[master]: API: Add formal definition for disk types

Ryan Harper has posted comments on this change. Change subject: API: Add formal definition for disk types .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4957 To unsubsc

Change in vdsm[master]: getDeviceList - passing includePartitioned to HSM

Daniel Erez has posted comments on this change. Change subject: getDeviceList - passing includePartitioned to HSM .. Patch Set 3: (3 inline comments) File AUTHORS Line 29:

Change in vdsm[master]: CpuPinning for vdsClient (#514657)

Igor Lvovsky has posted comments on this change. Change subject: CpuPinning for vdsClient (#514657) .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: CpuPinning (#514657)

Igor Lvovsky has posted comments on this change. Change subject: CpuPinning (#514657) .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) just curious, what about migration? .

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Saggi Mizrahi has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 6: (1 inline comment) File vdsm/storage/volume.

Change in vdsm[master]: hook: balloon - Enable the virtio balloon

Adam Litke has abandoned this change. Change subject: hook: balloon - Enable the virtio balloon .. Patch Set 1: Abandoned Since vdsm is getting first class support for ballooning, this hook will not be required. -- To view, v

Change in vdsm[master]: Change oop to be a new process instead of a fork

Dan Kenigsberg has posted comments on this change. Change subject: Change oop to be a new process instead of a fork .. Patch Set 3: No score I have minor unanswered comments. Saggi, I'd rather you fix them, but I'm removing my

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Replace the username for SASL authenticating by constant

Dan Kenigsberg has posted comments on this change. Change subject: Replace the username for SASL authenticating by constant .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) thanks - but let's be mo

Change in vdsm[master]: Add passwd command to vdsm-tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 5: (4 inline comments) File vdsm-tool/passwd.py Line 29: @vdsm_tool_ex

Change in vdsm[master]: Add passwd command to vdsm-tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 6: All the comments from Dan fixed. -- To view, visit http://gerrit.ovirt.org/4528 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[master]: Replace the username for SASL authenticating by constant

Lei Li has uploaded a new change for review. Change subject: Replace the username for SASL authenticating by constant .. Replace the username for SASL authenticating by constant As Dan suggested, replace the uername for SASL aut

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Shu Ming has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 2: (1 inline comment) File vdsm/define.py Line 44:

Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.

Gal Hammer has uploaded a new change for review. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. BZ#737104 Disallow cross-vendor virtualization. Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Signed-off-

Change in vdsm[master]: PEP8 fixes for localFsSD

Ryan Harper has posted comments on this change. Change subject: PEP8 fixes for localFsSD .. Patch Set 3: Verified Verified rpm build and install. No behavioral changes found. -- To view, visit http://gerrit.ovirt.org/3938 To

Change in vdsm[master]: PEP8 fixes for localFsSD

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: PEP8 fixes for localFsSD .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3938 To

Change in vdsm[master]: Reuse the stored pool host id on reconstructMaster

Federico Simoncelli has posted comments on this change. Change subject: Reuse the stored pool host id on reconstructMaster .. Patch Set 1: (2 inline comments) File vdsm/stora

Change in vdsm[master]: getDeviceList - passing includePartitioned to HSM

Ayal Baron has posted comments on this change. Change subject: getDeviceList - passing includePartitioned to HSM .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments) ..

Change in vdsm[master]: Changing origin of memShared stats to /sys/kernel/mm/ksm/pag...

Douglas Schilling Landgraf has posted comments on this change. Change subject: Changing origin of memShared stats to /sys/kernel/mm/ksm/pages_sharing .. Patch Set 8: Looks good to me, but someone else must approve -- To view,

Change in vdsm[master]: clean PEP 8 problems in vdsm/clientIF.py

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: clean PEP 8 problems in vdsm/clientIF.py .. Patch Set 1: (3 inline comments) File vdsm/clientIF

Change in vdsm[master]: configuNetworks: no need to create set repeatedly

Dan Kenigsberg has submitted this change and it was merged. Change subject: configuNetworks: no need to create set repeatedly .. configuNetworks: no need to create set repeatedly Yes, this is a very minor performance improvemen

Change in vdsm[master]: configNetworks: reject bridge names starting w/ dash

Dan Kenigsberg has submitted this change and it was merged. Change subject: configNetworks: reject bridge names starting w/ dash .. configNetworks: reject bridge names starting w/ dash Evil users may attempt to create bridges w

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 2: (2 inline comments) Mostly good, but I'd like someone else's opinion regarding changing the message b

Change in vdsm[master]: clean PEP 8 problems in vdsm/guestIF.py

Zhou Zheng Sheng has posted comments on this change. Change subject: clean PEP 8 problems in vdsm/guestIF.py .. Patch Set 1: Verified The patch passes tests in vdsm. Comparing the old file and new file with a tool named pydiff

Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

Federico Simoncelli has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. .. Patch Set 2: (1 inline comment) File vdsm/storage/bloc

Change in vdsm[master]: Related to BZ#769502 - One shot prepare.

Dan Kenigsberg has posted comments on this change. Change subject: Related to BZ#769502 - One shot prepare. .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 5: I would prefer that you didn't submit this (6 inline comments)

Change in vdsm[master]: use default libvirt event handler impl

Dan Kenigsberg has posted comments on this change. Change subject: use default libvirt event handler impl .. Patch Set 1: I would prefer that you didn't submit this (5 inline comments) Thanks for this patch! relatively minor c

Change in vdsm[master]: Remove the effect of other parameters on configure_sysctl in...

Wenyi Gao has posted comments on this change. Change subject: Remove the effect of other parameters on configure_sysctl in vdsmd.init .. Patch Set 3: No score Thanks for Dan's and Mark's comments. Yes, the "modprobe bridge" i

Change in vdsm[master]: Changing origin of memShared stats to /sys/kernel/mm/ksm/pag...

Dan Kenigsberg has posted comments on this change. Change subject: Changing origin of memShared stats to /sys/kernel/mm/ksm/pages_sharing .. Patch Set 8: Looks good to me, but someone else must approve Thanks! -- To view, vis

Change in vdsm[master]: Remove the effect of other parameters on configure_sysctl in...

Mark Wu has posted comments on this change. Change subject: Remove the effect of other parameters on configure_sysctl in vdsmd.init .. Patch Set 3: I would prefer that you didn't submit this Yes, I agree with Dan's comments. Y