Saggi Mizrahi has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): My opinion is that keeping the interface clean is more important then evading produce calls. Unless this causes a real performance hit. I don't see why we should make the interface more complicated -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
